1 2002-03-23 Havoc Pennington <hp@pobox.com>
3 * gtk/gtktextlayout.c (gtk_text_layout_real_invalidate):
4 invalidate the line containing start, even if the [start,end)
5 range is empty (just invalidate [start,end], essentially).
8 2002-03-23 Havoc Pennington <hp@pobox.com>
10 * gtk/gtktextview.c (gtk_text_view_do_popup): end any selection in
11 progress, patch from db@zigo.dhs.org, #74620
13 2002-03-23 Havoc Pennington <hp@pobox.com>
15 * gtk/gtktextview.c (gtk_text_view_move_cursor_internal): extend
16 selection for pageup/pagedown and ctrl+pageup/pagedown if
17 shift is held. more of #53934
19 2002-03-23 Havoc Pennington <hp@pobox.com>
21 * gtk/gtktextview.c (gtk_text_view_destroy_layout): disconnect
22 layout handlers earlier in the function, to avoid possible
24 (gtk_text_view_invalidate): Don't install idle handlers if
25 layout == NULL, otherwise we get problems during finalization
26 since clearing the buffer invalidates and puts the idle handlers
27 back after we destroy the layout. #74660
28 (gtk_text_view_ensure_layout): Install the validation handlers
29 right after creating the layout.
31 * gtk/gtktexttagtable.c (foreach_unref): call
32 _gtk_text_buffer_notify_will_remove_tag(), #75126
34 2002-03-22 Havoc Pennington <hp@pobox.com>
36 * gdk/x11/gdkfont-x11.c (gdk_fontset_load): add more explanatory
37 text to the error message about missing charsets, and use
38 g_printerr() not g_warning() since this is typically not a
39 programming error (we do not export any API to ask whether
40 a font set will have missing charsets so apps realistically can't
41 do anything other than try the gdk_fontset_load())
43 * gtk/gtktextview.c (gtk_text_view_key_press_event): return FALSE
44 if the text view isn't editable and the user presses Return,
45 so default buttons and such can be activated, #74937
47 * gtk/gtktextbuffer.c (paste_from_buffer): don't insert
48 if the insertion point is not editable and the paste
49 is interactive, #74125
51 * gtk/gtkwindow.c (gtk_window_move_resize): enhance the #if 0
54 * gtk/gtktextbuffer.c (cut_or_copy): only remove the previous
55 cut/copied data right before replacing it, when we know we are
56 going to replace it. Fixes #74049
58 2002-03-22 Richard Hult <rhult@codefactory.se>
60 * gdk/gdkevents.c (gdk_event_get_root_coords): Fix typo, where x
61 value was assigned to both x and y.
63 Fri Mar 22 11:29:11 2002 Owen Taylor <otaylor@redhat.com>
65 Partial fix for problem where keypad keys acted
66 as shift-arrows in an entry rather than arrows (#74327)
68 * gtk/gtkkeyhash.c (_gtk_key_hash_lookup): Sort lookup
69 results by number of modifiers in the entry. Fixes
70 problem where if a key matched both modified and unmodified
71 key bindings ... e.g., the distinguishing key binding
72 was consumed, then it was random which was used.
74 * gtk/gtkbindings.c (gtk_binding_entries_sort_patterns):
75 Catch the case where there are multiple entries from the
76 same bindingset (with different modifiers), and use only
77 the first entry, which, with the change in _gtk_key_hash_lookup()
78 will be the preferred value.
80 Fri Mar 22 10:56:19 2002 Owen Taylor <otaylor@redhat.com>
82 * gtk/gtkaccelmap.c (gtk_accel_map_save_fd): Fix memory
83 leak. (#74400, Morten Welinder.)
85 * gtk/gtkaccelmap.c: Properly handle short returns from
86 write() calls. (Handling EINTR isn't enough... that only
87 handles the case where you were interrupted before you
90 * gdk/linux-fb/gdkmouse-fb.c gdk/linux-fb/gdkkeyboard-fb.c:
91 Robustify against short returns from write() calls.
93 Fri Mar 22 10:12:10 2002 Owen Taylor <otaylor@redhat.com>
95 * gtk/gtktextview.c (gtk_text_view_paint): Change
96 G_BREAKPOINT() to g_assert_not_reached ().
97 (#75865, Ashok Venkiteswaran)
99 2002-03-22 Tor Lillqvist <tml@iki.fi>
101 * gdk/win32/gdkgc-win32.c (gdk_win32_gc_set_dashes): Don't clear
102 all of the pen_style, just the PS_STYLE_MASK. Seems to fix #74441,
103 but that is just the special case of one-pixel wide one-pixel
104 on-off dotted lines. To fully implement generic X11 style dashed
105 lines a major rewrite would be needed.
107 2002-03-21 Matthias Clasen <maclas@gmx.de>
109 * gtk/gtkaccelgroup.c (gtk_accelerator_valid): Trivial typo
110 fix. (Vitaly Tishkov, #75726)
112 Thu Mar 21 10:04:05 2002 Owen Taylor <otaylor@redhat.com>
114 * gdk/gdkwindow.c (gdk_window_real_get_depth): Remove
115 some left over debugging code with a G_BREAKPOINT()
118 Wed Mar 20 19:33:31 2002 Owen Taylor <otaylor@redhat.com>
120 * gtk/gtkcalendar.c (gtk_calendar_main_button): When
121 changing months when the user clicks on a prev-month
122 or next-month day, focus and select the new day.
123 Ignore double clicks on prev-month, next-month days.
124 (Based on suggestions from Andras Salamon, #74173)
126 * gtk/gtkcalendar.c: Implement the focused/unfocused
127 selected color change.
129 2002-03-20 Alex Larsson <alexl@redhat.com>
131 Patches from Carlo E. Prelz <fluido@fluido.as>
132 Now gtkfb at least compiles and mostly works. The keyboard
133 stuff needs more loving.
135 * gdk/linux-fb/gdkkeyboard-fb.c (xlate_get_for_keyval,
136 xlate_get_for_keycode, raw_get_for_keyval, raw_get_for_keycode):
137 At least set the out parameters for these calls.
139 * gdk/linux-fb/gdkmain-fb.c:
140 (gdk_pointer_grab_info_libgtk_only, gdk_keyboard_grab_info_libgtk_only):
141 Implement new functions.
143 Wed Mar 20 19:00:03 2002 Owen Taylor <otaylor@redhat.com>
145 * gtk/gtkentry.c (gtk_entry_set_text): Short-circuit
146 the text to the exact same thing, so we don't
147 unexpectedly change the selection or cursor position.
148 (#74290, John Ellis.)
150 Thu Mar 21 00:05:14 2002 Kristian Rietveld <kris@gtk.org>
152 * gtk/gtktreeview.c (gtk_tree_view_get_background_area),
153 (gtk_tree_view_get_cell_area): fix logic (fixes #74235, #73593)
155 Wed Mar 20 17:11:51 2002 Owen Taylor <otaylor@redhat.com>
157 * gtk/gtkrc.c: Patch from Richard Hestilow to fix
158 gtk-font-name changes for widgets that get the actual
159 default style. (#73709)
161 Wed Mar 20 22:59:23 2002 Kristian Rietveld <kris@gtk.org>
163 * gtk/gtkrbtree.[ch]: add _gtk_rbtree_set_fixed_height()
165 * gtk/gtktreeprivate.h: add fixed_height_check field
167 * gtk/gtktreeview.c (gtk_tree_view_init): initialize
168 scroll_sync_timer and fixed_height_check
169 (do_validate_rows): add fixed_height_check. If all validated rows
170 in the first cycle have the same height, then we set that height for
171 the entire tree. This is some sort of 'fake' optimization, but helps
172 a lot for the common case. We keep validating the entire tree in
173 the background though.
174 (gtk_tree_view_set_model): reset fixed_height_check
176 Wed Mar 20 16:36:08 2002 Owen Taylor <otaylor@redhat.com>
178 * gtk/*.c: Patch from Erwann Chenede, #73900 fixing
179 a lot of warnings with Forte CC, mostly implicit
180 casts between void * and function pointers.
182 * gdk/gdkevents.c (gdk_event_get_state): GdkEventVisibility's
183 state field is not a GdkModifierType. (Also #73900)
185 Wed Mar 20 12:35:22 2002 Owen Taylor <otaylor@redhat.com>
187 * gtk/gtkwidget.c (gtk_widget_grab_default): Remove
188 leftover notification of has-default. (#75508, Jacob
191 Wed Mar 20 12:27:07 2002 Owen Taylor <otaylor@redhat.com>
193 * gtk/gtkaccelgroup.c (gtk_accelerator_valid): Allow
194 arrow keys as accelerators, as long as some modifier
197 * gtk/gtkaccelgroup.c (gtk_accelerator_valid): Fix
198 incorrect example in the docs.
200 Wed Mar 20 12:06:30 2002 Owen Taylor <otaylor@redhat.com>
202 * gtk/gtkwidget.c (gtk_widget_set_child_visible):
203 Fix segfault when widget->parent is NULL.
204 (#75615, Alexey A. Malyshev)
206 Wed Mar 20 11:32:07 2002 Owen Taylor <otaylor@redhat.com>
208 * gtk/gtkentry.c: Improve test to prevent infinite
209 loop. (#74952, Thomas Leonard)
211 * gtk/gtkmenushell.c (gtk_real_menu_shell_cycle_focus):
212 Fix warning when toplevel menu shell isn't a menu
213 bar. (Thomas Leonard, #75602)
215 Wed Mar 20 11:00:59 2002 Owen Taylor <otaylor@redhat.com>
217 * configure.in: Use $PKG_CONFIG, not pkg-config.
218 (LEE Sau Dan, #75572)
220 Wed Mar 20 10:55:56 2002 Owen Taylor <otaylor@redhat.com>
222 * gdk/x11/gdkevents-x11.c (gdk_event_translate): Fix assignment
223 of time in scroll events. (Sven Neumann, #75574)
225 2002-03-20 Tor Lillqvist <tml@iki.fi>
227 * gdk/win32/gdkdnd-win32.c (gdk_drag_find_window): Use
228 gdk_window_get_toplevel(), as it is the top-level windows that are
231 * gdk/win32/gdkwin32.h: Don't include gdkinternals.h.
233 2002-03-19 jacob berkman <jacob@ximian.com>
235 * gtk/gtkcombo.c (gtk_combo_find): fix infinite loop when
236 gtk_combo_func() returns NULL (bug #75464)
238 2002-03-18 jacob berkman <jacob@ximian.com>
240 * gtk/gtkaspectframe.c (gtk_aspect_frame_class_init): set the
241 correct min/max values for the ratio property (fixes #75331)
243 Mon Mar 18 11:55:03 2002 Owen Taylor <otaylor@redhat.com>
245 * gtk/gtkimmulticontext.c (gtk_im_multicontext_get_slave):
246 Patch from Yao Zhang fixing reference count leak.
248 * gtk/gtkentry.c (gtk_entry_key_release): if (entry->editable),
249 not if (!entry->editable).
251 Mon Mar 18 11:09:17 2002 Owen Taylor <otaylor@redhat.com>
253 * gdk/x11/gdkwindow-x11.c (gdk_window_set_override_redirect):
254 Fix backwards conditional. (#75019, Dan Winship.)
256 Sun Mar 17 01:11:16 2002 Kristian Rietveld <kris@gtk.org>
258 * gtk/gtktreeview.c (gtk_tree_view_size_request): use
259 do_validate_rows instead of validate_rows_handler (fix by
262 Sat Mar 16 23:54:56 2002 Kristian Rietveld <kris@gtk.org>
264 * gdk/x11/gdkwindow-x11.c (gdk_window_set_static_bit_gravity): just
265 return when we have an input_only window (fix by Owen Taylor)
267 * gtk/gtktreeprivate.h (struct _GtkTreeViewPrivate): add
270 * gtk/gtktreeview.c (install_scroll_sync_handler): new function,
271 (scroll_sync_handler): ditto,
272 (gtk_tree_view_unrealize): take scroll_sync_timer into account
273 (gtk_tree_view_row_deleted): install scroll_sync_timer instead of
274 calling top_row_to_dy/dy_to_top_row directly
275 -- this greatly speeds up clearing the model (#73199)
277 * gtk/gtktreemodelsort.c
278 (gtk_tree_model_sort_convert_path_to_child_path): fix up this function,
279 for some reason I really screwed it up (fixes #74663)
281 2002-03-16 Sven Neumann <sven@gimp.org>
283 * configure.in (GDK_PIXBUF_DEP_CFLAGS) (GDK_PIXBUF_XLIB_DEP_CFLAGS)
284 (GDK_DEP_CFLAGS) (GTK_DEP_CFLAGS): include CFLAGS from gthread-2.0
285 so that the libs work correctly in a threaded environment.
287 Fri Mar 15 12:51:42 2002 Jonathan Blandford <jrb@redhat.com>
289 * gtk/gtktreeviewcolumn.c
290 (gtk_tree_view_column_new_with_attributes): add example to docs,
291 as people are seeming to have trouble with this function.
293 2002-03-15 Tor Lillqvist <tml@iki.fi>
295 * configure.in: Set MATH_LIB to empty also on Win32.
297 Fri Mar 15 15:37:01 2002 Owen Taylor <otaylor@redhat.com>
299 * gdk/x11/gdkdrawable-x11.c (convert_to_format):
300 Fix byte shift arithmetic for big-endian. (Tracked
301 down with help from Tuomas Kuosmanen)
303 Fri Mar 15 11:28:41 2002 Jonathan Blandford <jrb@redhat.com>
305 * gtk/gtktreeview.c (gtk_tree_view_insert_column_with_data_func):
306 make args const, 74159
307 (gtk_tree_view_insert_column_with_attributes): ditto
309 * gtk/gtktreeviewcolumn.c
310 (gtk_tree_view_column_cell_process_action): remov unused variables.
312 Fri Mar 15 13:31:51 2002 Soeren Sandmann <sandmann@daimi.au.dk>
314 * gtk/gtkmenu.c (gtk_menu_leave_notify): Fix test for "active
317 2002-03-15 Padraig O'Briain <padraig.obriain@sun.com>
319 * gdk/x11/gdkkeys-x11.c (update_keymaps): Fudge keymap to have lower
320 upper case variants if there is only a single keysym per keycode and
321 the key symbol has upper and lower case variants (#74512)
323 Thu Mar 14 17:09:52 2002 Owen Taylor <otaylor@redhat.com>
325 * gdk/gdkwindow.c (gdk_window_process_all_updates): Fix rather
326 improbable reentrancy problem if a window is destroyed
327 while updates are being processed on another window. (Noticed
328 by Michael Meeks, #74708)
330 2002-03-14 Vitaly Tishkov <tvv@sparc.spb.su>
332 * gtk/gtktreemodelsort.c
333 typo in docs for gtk_tree_model_sort_convert_iter_to_child_iter() fixed
336 Thu Mar 14 11:17:18 2002 Owen Taylor <otaylor@redhat.com>
338 * gtk/gtkkeyhash.c (_gtk_key_hash_remove_entry): When
339 removing keys from the key hash, reinsert the right list
340 back into the hash. (Dave Camp, #74571)
342 Wed Mar 13 17:17:40 2002 Owen Taylor <otaylor@redhat.com>
344 * gtk/gtkobject.h: Remove left-over GTK_OBJECT_CONNECTED
345 macro that was defined in terms of the now-gone GTK_CONNECTED
346 flag. (Seth Burgess, #74028)
348 Wed Mar 13 17:11:10 2002 Owen Taylor <otaylor@redhat.com>
350 * gtk/gtkaccelgroup.c (accel_group_weak_ref_detach): Unset
351 the acceleratable_groups qdata because qdata isn't removed
352 on ->dispose but rather on ->finalize. (#74569, found
355 Tue Mar 12 23:14:23 2002 Jonathan Blandford <jrb@redhat.com>
357 * gtk/gtktreeselection.c (gtk_tree_selection_unselect_iter): Fix
360 Sat Mar 9 18:23:25 2002 Richard Hestilow <hestilow@ximian.com>
362 * gtk/gtkimage.c (gtk_image_set_from_filename): Allow NULL
365 Tue Mar 12 10:50:09 2002 Owen Taylor <otaylor@redhat.com>
367 * modules/input/gtkimcontextxim.c (gtk_im_context_xim_filter_keypress):
368 Fix incorrect return value, filter out returns of 0x7f for
369 the delete key. (#74179, Kang Jeong-He)
371 Mon Mar 11 23:42:11 2002 Jonathan Blandford <jrb@redhat.com>
373 * gtk/gtktreemodel.c (gtk_tree_model_foreach): fix totally broken
376 2002-03-11 Matthias Clasen <maclas@gmx.de>
378 * gtk/gtkitemfactory.c (gtk_item_factory_add_foreign): Document
379 gtk_{menu_item,widget}_set_accel_path() as the recommended API.
382 2002-03-11 James Henstridge <james@daa.com.au>
384 * configure.in: set CCAS and CCASFLAGS to get automake 1.6
385 compatibility without breaking things for people using 1.4.
387 Sun Mar 10 21:04:30 2002 Jonathan Blandford <jrb@redhat.com>
389 * gtk/gtktreeview.c (gtk_tree_view_button_press): finally get the
392 Mon Mar 11 01:25:14 2002 Kristian Rietveld <kris@gtk.org>
394 * gtk/gtktreeview.c (gtk_tree_view_button_press): compare path with
395 cursor path and not with the selected iter in the 'decide to edit'