1 2002-03-25 Sven Neumann <sven@gimp.org>
3 * gtk/gtkrc.c (gtk_rc_parse_font_name): free the style's
4 font_description before accessing a new one.
5 (gtk_rc_parse_stock): always unref the created icon_set. #76289
7 2002-03-25 Mark McLoughlin <mark@skynet.ie>
9 * gtk/gtkbindings.c: (gtk_binding_entry_add_signal),
10 kill code duplicated in gtk_binding_entry_add_signall.
12 Sun Mar 24 10:32:38 2002 Jonathan Blandford <jrb@redhat.com>
14 * gtk/gtktreemodel.c (gtk_tree_path_copy): Make path arg const, #75653
16 * gtk/gtkfontsel.c (gtk_font_selection_show_available_styles): fix
19 * gtk/gtktreeview.c (gtk_tree_view_button_press): remove the grab
20 when we emit row_activated so that listeners of this signal can
21 grab the mouse, #75629
23 2002-03-23 Havoc Pennington <hp@pobox.com>
25 * gtk/gtktextlayout.c (gtk_text_layout_real_invalidate):
26 invalidate the line containing start, even if the [start,end)
27 range is empty (just invalidate [start,end], essentially).
28 Partially fixes #72374
30 2002-03-23 Havoc Pennington <hp@pobox.com>
32 * gtk/gtktextview.c (gtk_text_view_do_popup): end any selection in
33 progress, patch from db@zigo.dhs.org, #74620
35 2002-03-23 Havoc Pennington <hp@pobox.com>
37 * gtk/gtktextview.c (gtk_text_view_move_cursor_internal): extend
38 selection for pageup/pagedown and ctrl+pageup/pagedown if
39 shift is held. more of #53934
41 2002-03-23 Havoc Pennington <hp@pobox.com>
43 * gtk/gtktextview.c (gtk_text_view_destroy_layout): disconnect
44 layout handlers earlier in the function, to avoid possible
46 (gtk_text_view_invalidate): Don't install idle handlers if
47 layout == NULL, otherwise we get problems during finalization
48 since clearing the buffer invalidates and puts the idle handlers
49 back after we destroy the layout. #74660
50 (gtk_text_view_ensure_layout): Install the validation handlers
51 right after creating the layout.
53 * gtk/gtktexttagtable.c (foreach_unref): call
54 _gtk_text_buffer_notify_will_remove_tag(), #75126
56 2002-03-22 Havoc Pennington <hp@pobox.com>
58 * gdk/x11/gdkfont-x11.c (gdk_fontset_load): add more explanatory
59 text to the error message about missing charsets, and use
60 g_printerr() not g_warning() since this is typically not a
61 programming error (we do not export any API to ask whether
62 a font set will have missing charsets so apps realistically can't
63 do anything other than try the gdk_fontset_load())
65 * gtk/gtktextview.c (gtk_text_view_key_press_event): return FALSE
66 if the text view isn't editable and the user presses Return,
67 so default buttons and such can be activated, #74937
69 * gtk/gtktextbuffer.c (paste_from_buffer): don't insert
70 if the insertion point is not editable and the paste
71 is interactive, #74125
73 * gtk/gtkwindow.c (gtk_window_move_resize): enhance the #if 0
76 * gtk/gtktextbuffer.c (cut_or_copy): only remove the previous
77 cut/copied data right before replacing it, when we know we are
78 going to replace it. Fixes #74049
80 2002-03-22 Richard Hult <rhult@codefactory.se>
82 * gdk/gdkevents.c (gdk_event_get_root_coords): Fix typo, where x
83 value was assigned to both x and y.
85 Fri Mar 22 11:29:11 2002 Owen Taylor <otaylor@redhat.com>
87 Partial fix for problem where keypad keys acted
88 as shift-arrows in an entry rather than arrows (#74327)
90 * gtk/gtkkeyhash.c (_gtk_key_hash_lookup): Sort lookup
91 results by number of modifiers in the entry. Fixes
92 problem where if a key matched both modified and unmodified
93 key bindings ... e.g., the distinguishing key binding
94 was consumed, then it was random which was used.
96 * gtk/gtkbindings.c (gtk_binding_entries_sort_patterns):
97 Catch the case where there are multiple entries from the
98 same bindingset (with different modifiers), and use only
99 the first entry, which, with the change in _gtk_key_hash_lookup()
100 will be the preferred value.
102 Fri Mar 22 10:56:19 2002 Owen Taylor <otaylor@redhat.com>
104 * gtk/gtkaccelmap.c (gtk_accel_map_save_fd): Fix memory
105 leak. (#74400, Morten Welinder.)
107 * gtk/gtkaccelmap.c: Properly handle short returns from
108 write() calls. (Handling EINTR isn't enough... that only
109 handles the case where you were interrupted before you
110 wrote a single byte.)
112 * gdk/linux-fb/gdkmouse-fb.c gdk/linux-fb/gdkkeyboard-fb.c:
113 Robustify against short returns from write() calls.
115 Fri Mar 22 10:12:10 2002 Owen Taylor <otaylor@redhat.com>
117 * gtk/gtktextview.c (gtk_text_view_paint): Change
118 G_BREAKPOINT() to g_assert_not_reached ().
119 (#75865, Ashok Venkiteswaran)
121 2002-03-22 Tor Lillqvist <tml@iki.fi>
123 * gdk/win32/gdkgc-win32.c (gdk_win32_gc_set_dashes): Don't clear
124 all of the pen_style, just the PS_STYLE_MASK. Seems to fix #74441,
125 but that is just the special case of one-pixel wide one-pixel
126 on-off dotted lines. To fully implement generic X11 style dashed
127 lines a major rewrite would be needed.
129 2002-03-21 Matthias Clasen <maclas@gmx.de>
131 * gtk/gtkaccelgroup.c (gtk_accelerator_valid): Trivial typo
132 fix. (Vitaly Tishkov, #75726)
134 Thu Mar 21 10:04:05 2002 Owen Taylor <otaylor@redhat.com>
136 * gdk/gdkwindow.c (gdk_window_real_get_depth): Remove
137 some left over debugging code with a G_BREAKPOINT()
140 Wed Mar 20 19:33:31 2002 Owen Taylor <otaylor@redhat.com>
142 * gtk/gtkcalendar.c (gtk_calendar_main_button): When
143 changing months when the user clicks on a prev-month
144 or next-month day, focus and select the new day.
145 Ignore double clicks on prev-month, next-month days.
146 (Based on suggestions from Andras Salamon, #74173)
148 * gtk/gtkcalendar.c: Implement the focused/unfocused
149 selected color change.
151 2002-03-20 Alex Larsson <alexl@redhat.com>
153 Patches from Carlo E. Prelz <fluido@fluido.as>
154 Now gtkfb at least compiles and mostly works. The keyboard
155 stuff needs more loving.
157 * gdk/linux-fb/gdkkeyboard-fb.c (xlate_get_for_keyval,
158 xlate_get_for_keycode, raw_get_for_keyval, raw_get_for_keycode):
159 At least set the out parameters for these calls.
161 * gdk/linux-fb/gdkmain-fb.c:
162 (gdk_pointer_grab_info_libgtk_only, gdk_keyboard_grab_info_libgtk_only):
163 Implement new functions.
165 Wed Mar 20 19:00:03 2002 Owen Taylor <otaylor@redhat.com>
167 * gtk/gtkentry.c (gtk_entry_set_text): Short-circuit
168 the text to the exact same thing, so we don't
169 unexpectedly change the selection or cursor position.
170 (#74290, John Ellis.)
172 Thu Mar 21 00:05:14 2002 Kristian Rietveld <kris@gtk.org>
174 * gtk/gtktreeview.c (gtk_tree_view_get_background_area),
175 (gtk_tree_view_get_cell_area): fix logic (fixes #74235, #73593)
177 Wed Mar 20 17:11:51 2002 Owen Taylor <otaylor@redhat.com>
179 * gtk/gtkrc.c: Patch from Richard Hestilow to fix
180 gtk-font-name changes for widgets that get the actual
181 default style. (#73709)
183 Wed Mar 20 22:59:23 2002 Kristian Rietveld <kris@gtk.org>
185 * gtk/gtkrbtree.[ch]: add _gtk_rbtree_set_fixed_height()
187 * gtk/gtktreeprivate.h: add fixed_height_check field
189 * gtk/gtktreeview.c (gtk_tree_view_init): initialize
190 scroll_sync_timer and fixed_height_check
191 (do_validate_rows): add fixed_height_check. If all validated rows
192 in the first cycle have the same height, then we set that height for
193 the entire tree. This is some sort of 'fake' optimization, but helps
194 a lot for the common case. We keep validating the entire tree in
195 the background though.
196 (gtk_tree_view_set_model): reset fixed_height_check
198 Wed Mar 20 16:36:08 2002 Owen Taylor <otaylor@redhat.com>
200 * gtk/*.c: Patch from Erwann Chenede, #73900 fixing
201 a lot of warnings with Forte CC, mostly implicit
202 casts between void * and function pointers.
204 * gdk/gdkevents.c (gdk_event_get_state): GdkEventVisibility's
205 state field is not a GdkModifierType. (Also #73900)
207 Wed Mar 20 12:35:22 2002 Owen Taylor <otaylor@redhat.com>
209 * gtk/gtkwidget.c (gtk_widget_grab_default): Remove
210 leftover notification of has-default. (#75508, Jacob
213 Wed Mar 20 12:27:07 2002 Owen Taylor <otaylor@redhat.com>
215 * gtk/gtkaccelgroup.c (gtk_accelerator_valid): Allow
216 arrow keys as accelerators, as long as some modifier
219 * gtk/gtkaccelgroup.c (gtk_accelerator_valid): Fix
220 incorrect example in the docs.
222 Wed Mar 20 12:06:30 2002 Owen Taylor <otaylor@redhat.com>
224 * gtk/gtkwidget.c (gtk_widget_set_child_visible):
225 Fix segfault when widget->parent is NULL.
226 (#75615, Alexey A. Malyshev)
228 Wed Mar 20 11:32:07 2002 Owen Taylor <otaylor@redhat.com>
230 * gtk/gtkentry.c: Improve test to prevent infinite
231 loop. (#74952, Thomas Leonard)
233 * gtk/gtkmenushell.c (gtk_real_menu_shell_cycle_focus):
234 Fix warning when toplevel menu shell isn't a menu
235 bar. (Thomas Leonard, #75602)
237 Wed Mar 20 11:00:59 2002 Owen Taylor <otaylor@redhat.com>
239 * configure.in: Use $PKG_CONFIG, not pkg-config.
240 (LEE Sau Dan, #75572)
242 Wed Mar 20 10:55:56 2002 Owen Taylor <otaylor@redhat.com>
244 * gdk/x11/gdkevents-x11.c (gdk_event_translate): Fix assignment
245 of time in scroll events. (Sven Neumann, #75574)
247 2002-03-20 Tor Lillqvist <tml@iki.fi>
249 * gdk/win32/gdkdnd-win32.c (gdk_drag_find_window): Use
250 gdk_window_get_toplevel(), as it is the top-level windows that are
253 * gdk/win32/gdkwin32.h: Don't include gdkinternals.h.
255 2002-03-19 jacob berkman <jacob@ximian.com>
257 * gtk/gtkcombo.c (gtk_combo_find): fix infinite loop when
258 gtk_combo_func() returns NULL (bug #75464)
260 2002-03-18 jacob berkman <jacob@ximian.com>
262 * gtk/gtkaspectframe.c (gtk_aspect_frame_class_init): set the
263 correct min/max values for the ratio property (fixes #75331)
265 Mon Mar 18 11:55:03 2002 Owen Taylor <otaylor@redhat.com>
267 * gtk/gtkimmulticontext.c (gtk_im_multicontext_get_slave):
268 Patch from Yao Zhang fixing reference count leak.
270 * gtk/gtkentry.c (gtk_entry_key_release): if (entry->editable),
271 not if (!entry->editable).
273 Mon Mar 18 11:09:17 2002 Owen Taylor <otaylor@redhat.com>
275 * gdk/x11/gdkwindow-x11.c (gdk_window_set_override_redirect):
276 Fix backwards conditional. (#75019, Dan Winship.)
278 Sun Mar 17 01:11:16 2002 Kristian Rietveld <kris@gtk.org>
280 * gtk/gtktreeview.c (gtk_tree_view_size_request): use
281 do_validate_rows instead of validate_rows_handler (fix by
284 Sat Mar 16 23:54:56 2002 Kristian Rietveld <kris@gtk.org>
286 * gdk/x11/gdkwindow-x11.c (gdk_window_set_static_bit_gravity): just
287 return when we have an input_only window (fix by Owen Taylor)
289 * gtk/gtktreeprivate.h (struct _GtkTreeViewPrivate): add
292 * gtk/gtktreeview.c (install_scroll_sync_handler): new function,
293 (scroll_sync_handler): ditto,
294 (gtk_tree_view_unrealize): take scroll_sync_timer into account
295 (gtk_tree_view_row_deleted): install scroll_sync_timer instead of
296 calling top_row_to_dy/dy_to_top_row directly
297 -- this greatly speeds up clearing the model (#73199)
299 * gtk/gtktreemodelsort.c
300 (gtk_tree_model_sort_convert_path_to_child_path): fix up this function,
301 for some reason I really screwed it up (fixes #74663)
303 2002-03-16 Sven Neumann <sven@gimp.org>
305 * configure.in (GDK_PIXBUF_DEP_CFLAGS) (GDK_PIXBUF_XLIB_DEP_CFLAGS)
306 (GDK_DEP_CFLAGS) (GTK_DEP_CFLAGS): include CFLAGS from gthread-2.0
307 so that the libs work correctly in a threaded environment.
309 Fri Mar 15 12:51:42 2002 Jonathan Blandford <jrb@redhat.com>
311 * gtk/gtktreeviewcolumn.c
312 (gtk_tree_view_column_new_with_attributes): add example to docs,
313 as people are seeming to have trouble with this function.
315 2002-03-15 Tor Lillqvist <tml@iki.fi>
317 * configure.in: Set MATH_LIB to empty also on Win32.
319 Fri Mar 15 15:37:01 2002 Owen Taylor <otaylor@redhat.com>
321 * gdk/x11/gdkdrawable-x11.c (convert_to_format):
322 Fix byte shift arithmetic for big-endian. (Tracked
323 down with help from Tuomas Kuosmanen)
325 Fri Mar 15 11:28:41 2002 Jonathan Blandford <jrb@redhat.com>
327 * gtk/gtktreeview.c (gtk_tree_view_insert_column_with_data_func):
328 make args const, 74159
329 (gtk_tree_view_insert_column_with_attributes): ditto
331 * gtk/gtktreeviewcolumn.c
332 (gtk_tree_view_column_cell_process_action): remov unused variables.
334 Fri Mar 15 13:31:51 2002 Soeren Sandmann <sandmann@daimi.au.dk>
336 * gtk/gtkmenu.c (gtk_menu_leave_notify): Fix test for "active
339 2002-03-15 Padraig O'Briain <padraig.obriain@sun.com>
341 * gdk/x11/gdkkeys-x11.c (update_keymaps): Fudge keymap to have lower
342 upper case variants if there is only a single keysym per keycode and
343 the key symbol has upper and lower case variants (#74512)
345 Thu Mar 14 17:09:52 2002 Owen Taylor <otaylor@redhat.com>
347 * gdk/gdkwindow.c (gdk_window_process_all_updates): Fix rather
348 improbable reentrancy problem if a window is destroyed
349 while updates are being processed on another window. (Noticed
350 by Michael Meeks, #74708)
352 2002-03-14 Vitaly Tishkov <tvv@sparc.spb.su>
354 * gtk/gtktreemodelsort.c
355 typo in docs for gtk_tree_model_sort_convert_iter_to_child_iter() fixed
358 Thu Mar 14 11:17:18 2002 Owen Taylor <otaylor@redhat.com>
360 * gtk/gtkkeyhash.c (_gtk_key_hash_remove_entry): When
361 removing keys from the key hash, reinsert the right list
362 back into the hash. (Dave Camp, #74571)
364 Wed Mar 13 17:17:40 2002 Owen Taylor <otaylor@redhat.com>
366 * gtk/gtkobject.h: Remove left-over GTK_OBJECT_CONNECTED
367 macro that was defined in terms of the now-gone GTK_CONNECTED
368 flag. (Seth Burgess, #74028)
370 Wed Mar 13 17:11:10 2002 Owen Taylor <otaylor@redhat.com>
372 * gtk/gtkaccelgroup.c (accel_group_weak_ref_detach): Unset
373 the acceleratable_groups qdata because qdata isn't removed
374 on ->dispose but rather on ->finalize. (#74569, found
377 Tue Mar 12 23:14:23 2002 Jonathan Blandford <jrb@redhat.com>
379 * gtk/gtktreeselection.c (gtk_tree_selection_unselect_iter): Fix
382 Sat Mar 9 18:23:25 2002 Richard Hestilow <hestilow@ximian.com>
384 * gtk/gtkimage.c (gtk_image_set_from_filename): Allow NULL
387 Tue Mar 12 10:50:09 2002 Owen Taylor <otaylor@redhat.com>
389 * modules/input/gtkimcontextxim.c (gtk_im_context_xim_filter_keypress):
390 Fix incorrect return value, filter out returns of 0x7f for
391 the delete key. (#74179, Kang Jeong-He)
393 Mon Mar 11 23:42:11 2002 Jonathan Blandford <jrb@redhat.com>
395 * gtk/gtktreemodel.c (gtk_tree_model_foreach): fix totally broken
398 2002-03-11 Matthias Clasen <maclas@gmx.de>
400 * gtk/gtkitemfactory.c (gtk_item_factory_add_foreign): Document
401 gtk_{menu_item,widget}_set_accel_path() as the recommended API.
404 2002-03-11 James Henstridge <james@daa.com.au>
406 * configure.in: set CCAS and CCASFLAGS to get automake 1.6
407 compatibility without breaking things for people using 1.4.
409 Sun Mar 10 21:04:30 2002 Jonathan Blandford <jrb@redhat.com>
411 * gtk/gtktreeview.c (gtk_tree_view_button_press): finally get the
414 Mon Mar 11 01:25:14 2002 Kristian Rietveld <kris@gtk.org>
416 * gtk/gtktreeview.c (gtk_tree_view_button_press): compare path with
417 cursor path and not with the selected iter in the 'decide to edit'