1 2005-11-21 Matthias Clasen <mclasen@redhat.com>
3 * gtk/gtkpathbar.c: Merge remaining fixes from the 2.8 branch,
4 pointed out by Michael Natterer.
6 Fix for bug #321542, Benedikt Meurer:
8 * gtk/gtkcombobox.c (gtk_combo_box_set_active_internal):
11 (gtk_combo_box_child_show, gtk_combo_box_child_hide): Use
12 g_signal_emit, not g_signal_emit_by_name.
14 2005-11-18 Matthias Clasen <mclasen@redhat.com>
16 Fix crashes in connection with pathbar scrolling (#321560,
19 * gtk/gtkpathbar.c (gtk_path_bar_update_slider_buttons):
20 Stop scrolling when desensitising slider buttons.
21 (gtk_path_bar_scroll_timeout, gtk_path_bar_slider_button_press):
24 * gtk/gtkpathbar.h (struct _GtkPathBar): Add a separate
27 2005-11-18 Matthias Clasen <mclasen@redhat.com>
29 * gtk/gtkpathbar.c (button_clicked_cb): Fix a C99ism.
30 (#321777, Jens Granseuer)
32 * gtk/gtkaction.c (disconnect_proxy): Disconnect the
33 sync callback for the visibility property. (#321761,
36 Turn off input methods in invisible entries, since
37 they are confusing. (#317002, James Su)
39 * gtk/gtkentry.c (gtk_entry_set_visibility): Toggle input
40 methods if visibility changes.
41 (popup_targets_received): Don't show the input method
42 menu if the entry is invisible.
44 2005-11-17 Matthias Clasen <mclasen@redhat.com>
46 * README.in: Add a note about range arrow sensitivity.
48 * perf/treeview.c: const correctness fixes
49 found by Arjan van de Ven and gcc.
51 2005-11-16 Michael Natterer <mitch@imendio.com>
53 * gtk/gtkimage.c (animation_timeout): call
54 gtk_window_process_updates() so the animation keeps running even
55 if the main loop is busy with sources that eat a lot of cpu with
56 high priority. Fixes bug #321444.
58 (gtk_image_new_from_animation): document the fact that the
59 animation will stop running if the main loop is busy with sources
60 that have priorities higher than G_PRIORITY_DEFAULT.
62 * tests/testimage.c: added test case that shows an animation even
63 though a cpu-eating idle function is running.
65 2005-11-16 Michael Natterer <mitch@imendio.com>
67 * gdk/x11/gdkevents-x11.c (_gdk_events_uninit): new internal
68 function which destroys the display's event source. Also removes
69 the source from the global display_sources list and unrefs it.
71 * gdk/x11/gdkprivate-x11.h: declare the function.
73 * gdk/x11/gdkdisplay-x11.c (gdk_display_x11_dispose): call it
74 instead of half-destroying the source here.
76 2005-11-15 Matthias Clasen <mclasen@redhat.com>
78 * gtk/gtktreestore.c (gtk_tree_store_move): Fix a memory
79 leak. (#321032, Peter Zelezny)
81 2005-11-15 Michael Natterer <mitch@imendio.com>
83 * gdk/x11/gdkdisplay-x11.c (gdk_display_x11_finalize): destroy
84 display->xid_ht as late as possible (right before XCloseDisplay)
85 because it still needs to be around when the display's screens are
88 2005-11-14 Matthias Clasen <mclasen@redhat.com>
90 * gtk/gtkselection.c (gtk_selection_data_set_uris): Don't
91 leak result. (#321441, Tommi Komulainen)
93 2005-11-14 Matthias Clasen <mclasen@redhat.com>
95 * gtk/gtkicontheme.c (gtk_icon_theme_get_icon_sizes):
96 Don't crash if there is no builtin icon.
98 2005-11-14 Michael Natterer <mitch@imendio.com>
100 * gtk/gtkcellrenderertoggle.c (gtk_cell_renderer_toggle_set_property):
101 removed redundant calls to g_object_notify().
103 2005-11-13 Matthias Clasen <mclasen@redhat.com>
105 * gdk/gdkcolor.c (gdk_color_parse): Documentation
106 improvements. (#321338)
108 * gtk/gtktextiter.c (gtk_text_iter_forward_search): Make
109 limit an inclusive boundary. (#321299)
111 2005-11-12 Michael Natterer <mitch@imendio.com>
113 * gtk/Makefile.am: fixed icon rules so gtkbuiltincache.h is only
116 2005-11-12 Dom Lachowicz <cinamod@hotmail.com>
118 * modules/engines/ms-windows/msw_style.c: Bug #313627. Make win32
119 theme's handling of toolbars, handleboxes, and menubars more in-line
120 with Microsoft's IE style.
121 * modules/engines/ms-windows/*.c: Indentation cleanups
123 2005-11-12 Matthias Clasen <mclasen@redhat.com>
125 Make builtin icons work in gtk_window_set_icon_name()
126 (#321046, Maxim Udushlivy)
128 * gtk/gtkicontheme.c (insert_theme): Always insert the default
130 (ensure_valid_themes): Call _gtk_icon_theme_ensure_builtin_cache()
132 (theme_lookup_icon, find_builtin_icon): ...and not from here.
133 (gtk_icon_theme_lookup_icon): Remove an unncessary assert.
134 (gtk_icon_theme_get_icon_sizes): Also check builtin icons.
136 2005-11-12 Tor Lillqvist <tml@novell.com>
138 * gtk/gtkfilesystemwin32.c (filename_get_info): Don't hide
139 dotfiles, no such convention on Win32. Just hide files with the
140 hidden attribute. (#314627)
142 2005-11-11 Federico Mena Quintero <federico@ximian.com>
144 * gtk/gtkfilechooserdefault.c (shortcuts_insert_path): Do not
145 check whether the path is a folder. It is useful to bookmark
146 files as well (e.g. todo.txt), and this will also help
148 (shortcuts_add_bookmark_from_path): Likewise.
149 (shortcuts_activate_iter): Change folders or select files, as
152 2005-11-11 Federico Mena Quintero <federico@ximian.com>
154 * tests/autotestfilechooser.c (main): Use
155 g_log_set_default_handler() instead of explicitly setting a
156 handler for each domain.
158 * gtk/gtkfilechooserdefault.c (shortcuts_add_volumes): Only get
159 the base path of the volume if it is mounted.
161 2005-11-11 Michael Natterer <mitch@imendio.com>
163 Added per-stepper API for GtkRange's stepper sensitivity as
164 discussed in bug #321056:
166 * gtk/gtkenums.h: added GtkSensitivityType which can be
169 * gtk/gtkrange.[ch]: added properties "lower-stepper-sensitivity"
170 and "upper-stepper-sensitivity" and public getters/setters for
171 them. Changed stepper drawing to honor the new properties.
173 * gtk/gtk.symbols: added the new symbols.
175 2005-11-10 Matthias Clasen <mclasen@redhat.com>
177 * gtk/gtkcombobox.c: Add show-popup and hide-popup signals and
178 emit them when the popup is shown or hidden. (#162531, Tommi
181 * tests/testcombo.c: Add an example of popuplating a combobox
184 * gtk/gtktreeview.c (gtk_tree_view_motion_resize_column): Another
187 * gdk/x11/gdkcolor-x11.c (gdkx_colormap_get): Remove an erroneous
190 Don't corrupt odd keymaps (#316638, Kean Johnston)
192 * gdk/x11/gdkkeys-x11.c (set_symbol): Auxiliary function to
193 handle frobbing keymaps with odd numbers of syms/code.
195 * gdk/x11/gdkkeys-x11.c (update_keymaps): Use set_symbol() to
198 Improve navigation to parent folders. (#318444, Andrei Yurkevich)
200 * gtk/gtkpathbar.[hc]: Add a child_path argument to
201 the path_clicked signal.
202 * gtk/gtkfilechooserdefault.c (path_bar_clicked): Select the
203 child_path, if it is provided.
204 * gtk/marshalers.list (path_bar_clicked): Add the necessary
207 * gtk/gtkmenu.c: Fix some compiler warnings. (#321141,
212 * gtk/gtktreeview.c: Implement a getter for headers-clickable.
213 (#163851, Richard Hult)
215 2005-11-10 Michael Natterer <mitch@imendio.com>
217 Applied patch from maemo-gtk that addresses many issues wrt
218 display migration and display closing (bug #85715).
220 * gdk/gdkdisplay.c (gdk_display_dispose): don't just set the
221 default display to NULL when it's closed. Instead set the most
222 recently opened display as new default (if one exists).
224 * gdk/gdkpango.c (on_renderer_display_closed): fixed signature
227 * gdk/gdkscreen.c (gdk_screen_dispose): check if the GCs still
228 exist before unrefing them.
230 * gdk/gdkwindow.c (_gdk_window_destroy_hierarchy): if the screen
231 is closed, allow destruction of the root window.
233 * gdk/x11/gdkdisplay-x11.c: moved some stuff from finalize() to
234 dispose(), free stuff that was leaked before.
236 * gdk/x11/gdkevents-x11.c (_gdk_x11_events_uninit_screen): check if
237 the xsettings_client still exists before destroying it.
239 * gdk/x11/gdkkeys-x11.c: added finalization and free the allocated
242 * gdk/x11/gdkpixmap-x11.c: moved stuff from finalize() to new
243 dispose() implementation.
245 * gdk/x11/gdkscreen-x11.c: moved stuff from finalize() to
246 dispose() and check if it still exists before unrefing it. Set
247 their pointers to NULL/None *after* upchaining in dispose(),
248 because X11 implementations of members of the parent class still
249 need them for their own destruction.
251 * gdk/x11/gdkvisual-x11.c: removed finalize() implementation which
252 was g_error()ing when finalizing a visual.
254 * gtk/gtkclipboard.c (gtk_clipboard_finalize): don't use
255 get_clipboard_widget() because it would create the widget if it
256 doesn't exist. Use g_object_get_data() directly instead.
258 * gtk/gtktextdisplay.c (on_renderer_display_closed): fixed signature
261 2005-11-10 Simos Xenitellis <simos@gnome.org>
263 * configure.in: Added Tatar (tt) to ALL_LINGUAS.
265 Wed Nov 9 16:29:42 2005 Tim Janik <timj@imendio.com>
267 * gtk/gtkrange.c: patch from maemo-gtk that changes GtkRange
268 to render its arrows insensitive when the adjustment is in
269 its min or max position. this makes range arrow behaviour
270 consistent with spin button behaviour. (#321056)
272 2005-11-09 Tor Lillqvist <tml@novell.com>
275 * gdk/gdk.c (gdk_debug_keys[]): Add new GDK_DEBUG_DRAW flag to
276 the GdkDebugFlag enum.
278 * gdk/win32/gdkdrawable-win32.c: Use DRAW to trigger GDK_NOTEs in
279 this file instead of MISC. Now asking for MISC will give mainly
280 window manipulation debugging output with the Win32 backend.
282 2005-11-09 Tor Lillqvist <tml@novell.com>
284 * gdk/win32/gdkwindow-win32.c: Remove unnecessary includes.
286 (_gdk_win32_get_adjusted_client_rect): Remove this two-line
287 function which was used only in one place.
289 (get_outer_rect): Use _gdk_win32_adjust_client_rect().
291 (gdk_window_set_geometry_hints): If we have identical minimum and
292 maximum size hints, remove the resize and maximize
293 decorations/functions. (#104514)
295 If we have a maximum size hint, remove the maximize
296 decoration/function but ensure the resize decoration/function is
297 available. Otherwise ensure both resize and maximize
298 decorations/functions are there.
300 (set_or_clear_style_bits): Factored out common code from
301 gdk_window_set_decorations() and gdk_window_set_functions().
303 Hack the window style setting once more: Only touch the window
304 style bits corresponding to the GdkWMDecoration or GdkWMFunction
305 parameter bitmasks. Hopefully this finally is the correct thing to
306 do. We used to clear all other bits than those that were being
307 set, or set all other bits than those that were being cleared.
309 Take into account that adding or removing decorations leaves the
310 window's outer size unchanged, i.e., the client area's size and
311 position change. This is apparently not what we want, so change
312 also the window's (outer) position and size appropriately so that
313 the client area's position and size stay constant.
315 gtk-demo's color selector dialog is now non-resizable like on X11
316 (I tested with metacity in GNOME). Torn off menus are shrinkable
317 vertically but have a maximum size, and are not maximizable or
318 minimizable, like on X11.
320 (gdk_window_set_decorations, gdk_window_set_functions): Let
321 set_or_clear_decorations() do most of the job.
323 * gdk/win32/gdkprivate-win32.h: Remove declaration of
324 _gdk_win32_get_adjusted_client_rect().
326 2005-11-09 Tor Lillqvist <tml@novell.com>
328 * gdk/win32/gdkwindow-win32.h (struct _GdkWindowImplWin32)
329 * gdk/win32/gdkwindow-win32.c (gdk_window_impl_win32_init,
330 gdk_window_get_type_hint, gdk_window_get_type_hint): Store the
331 type hint. Implement gdk_window_get_type_hint() by just returning
334 2005-11-09 Tor Lillqvist <tml@novell.com>
336 * gdk/win32/gdkwindow-win32.c (gdk_window_set_geometry_hints):
337 Remove code that has been permanently ifdeffed out for two years.
339 2005-11-08 Matthias Clasen <mclasen@redhat.com>
341 * gdk/gdkgc.c (gdk_gc_finalize): Unref tile and stipple when
342 finalizing a gc. (#320789, Nickolay V. Shmyrev)
344 * gdk/x11/gdkwindow-x11.c (gdk_window_set_icon_list): Ignore
345 icons if they would make the request large enough to cause
346 Xlib to loose the connection. (#320909, Claudio Saavedra)
348 2005-11-08 Michael Natterer <mitch@imendio.com>
352 * gdk/x11/gdkwindow-x11.c: added gdk_window_get_type_hint() (patch
353 extracted from maemo-gtk). Fixes bug #320872.
355 2005-11-07 Matthias Clasen <mclasen@redhat.com>
357 * gtk/gtkfilechooserdefault.c (shortcuts_reorder): Don't
358 looks the bookmark label when reordering. (#320720, Jeremy Cook)
360 * gtk/gtkpathbar.[hc]: Set focus-on-click to FALSE for all buttons.
361 Don't grab focus when a slider button is pressed, instead, use
362 a bit in the pathbar struct to determine whether to scroll up
363 or down. (#314486, Carlos Garnacho)
365 * gtk/gtkentrycompletion.c (_gtk_entry_completion_popup):
366 Don't popup the completions if the focus has already been
367 moved somewhere else. (#319914, Christian Persch)
369 * gtk/gtktoolitem.c (_gtk_tool_item_toolbar_reconfigured):
370 Raise the drag_window after reconfiguring the
371 toolbar. (#320803, Christian Persch)
374 * gtk/gtkfilechooserbutton.h:
375 * gtk/gtkfilechooserbutton.c: Add a focus-on-click property
376 with setter and getter. (#318945, Christian Persch)
378 Mon Nov 7 16:15:16 2005 Tim Janik <timj@imendio.com>
380 * configure.in: fixed missing $X_CFLAGS setup in case x11.pc is present.
382 2005-11-07 Matthias Clasen <mclasen@redhat.com>
384 * configure.in: Adjust to the stock icon changes.
386 2005-11-07 Tor Lillqvist <tml@novell.com>
388 * gdk/win32/gdkcursor-win32.c (pixbuf_to_hbitmaps_normal):
389 Correct the calculation of maskstride. (#320152, Peter Zelezny)
391 2005-11-06 Michael Natterer <mitch@imendio.com>
393 * gtk/Makefile.am (icons): fixed rule to actually create the
394 symlinks, erroring out if anything goes wrong.
396 2005-11-06 Tor Lillqvist <tml@novell.com>
398 * gtk/updateiconcache.c (build_cache): Can't rename a file if the
399 target exists on Win32. First rename the target temporarily, then
400 if the renaming of the source to target fails, restore the
401 original name for the target.
403 * gtk/Makefile.am: Use EXEEXT in the dependency on gtk-update-icon-cache.
405 2005-11-06 Tor Lillqvist <tml@novell.com>
407 (pixbuf_to_hbitmaps_alpha_winxp): Use an 1-bit mask bitmap,
408 like pixbuf_to_hbitmaps_normal().
409 (_gdk_win32_pixbuf_to_hicon_supports_alpha): Check
410 G_WIN32_IS_NT_BASED() first, so we can pretend being on Win9x by
411 setting the G_WIN32_PRETEND_WIN9X environment variable.
413 2005-11-06 Tor Lillqvist <tml@novell.com>
415 Make icon masks work on Win98 (#320152, Peter Zelezny)
417 * gdk/win32/gdkcursor-win32.c (create_color_bitmap): Take also a
418 parameter for the depth of the bitmap, so that this function can
419 be used to create 1-bit bitmaps, too.
420 (pixbuf_to_hbitmaps_normal): Create an 1-bit bitmap for the mask,
421 and initialize it properly.
423 2005-11-04 Matthias Clasen <mclasen@redhat.com>
425 Store builtin stock icons in an icon cache, instead of
426 populating a hash table with pixbufs at startup, to save both
427 memory and startup time.
429 * gtk/stock-icons/*: Reorganize the icons in a directory structure
430 suitable for gtk-update-icon-cache, and rename them to match the
433 * gtk/gtkiconcache.[hc]: Support non-mmapped icon caches, and
434 add _gtk_icon_cache_has_icon_in_directory().
436 * gtk/updateiconcache.c: Support a --source <VARIABLE> argument
437 to store the contents of the icon cache in a C header.
439 * gtk/gtkbuiltincache.h: Generated private header which contains
440 the icon cache for the builtin icons.
442 * gtk/gtkicontheme.c: Create a GtkIconCache for the builtin
443 icons, and use that in addition to the hash table whenever
444 builtin icons are searched.
446 * gtk/gtkiconfactory.c: Add GTK_ICON_SOURCE_STATIC_ICON_NAME and
447 use it for static stock ids.
448 (get_default_icons): Don't add the builtin
449 icons to the icon theme, just register the stock ids.
450 (render_fallback_image): Take the fallback image out of the
453 * gtk/Makefile.am: Remove stock-icons from SUBDIRS and add
454 the necessary machinery to rebuild gtkbuiltincache.h.
456 2005-11-04 Michael Natterer <mitch@imendio.com>
458 * gtk/gtkrc.c (gtk_rc_reparse_all_for_settings): applied patch
459 from maemo-gtk that changes the mtime check for rc files from
460 '>' to '!=', otherwise theme changes go unnoticed when turning
461 back the clock (Tommi Komulainen).
463 2005-11-04 Tor Lillqvist <tml@novell.com>
465 * gtk/gtkstatusicon.c (gtk_status_icon_set_tooltip): Plug memory
468 2005-11-03 Tor Lillqvist <tml@novell.com>
470 * gdk/win32/gdkcursor-win32.c: As there is only one GdkDisplay in
471 the Win32 backend, check that GdkDisplay* parameters are equal to
472 _gdk_display instead of using the unnecessarily general
475 (pixbuf_to_hbitmaps_alpha_winxp): Rename the variables for the
476 color bitmap to have "color" in their name, for similarity with
477 pixbuf_to_hbitmaps_normal(). Create a color bitmap for the mask,
478 too, instead of creating a b&w bitmap with CreateBitmap(). Set up
479 the mask bitmap's contents, ones for those pixels in the color
480 bitmap where the alpha is zero, zero for other pixels. We used to
481 use an uninitialized mask bitmap! This meant that icons and
482 cursors created presumably worked more or less by accident.
483 Totally blank icons with zero alpha everywhere (as used by
484 gtktrayicon.c) definitely did not work as expected.
486 * gtk/Makefile.am: Include gtkstatusicon.c on all platforms.
488 * gtk/gtkstatusicon.c: Implement for Win32. Use code from
489 gtktrayicon-win32.c as applicable. (gtktrayicon-win32.c is not
490 necessary and can be removed from CVS. It has never been mentioned
491 in gtk/Makefile.am.) No tray icon widget, GtkImage or GtkTooltips
492 are used on Win32. One label widget is used (but never shown) as
493 gtk_widget_render_icon() needs a widget.
495 Ifdefs used as necessary in several places. It might be cleaner to
496 split out the backend-specific parts to separate files, or at
497 least collect them into separate blocks in the file.
499 (wndproc): New function. Window procedure to monitor mouse events
500 in the system tray icon. Call gtk_status_icon_button_press() as
502 (create_tray_observer): New function. Creates a hidden window that
503 only serves as a tray icon message observer.
505 * tests/teststatusicon.c (icon_activated): Position the dialog
506 with GTK_WIN_POS_CENTER.
507 (do_quit): New function, hide and unref the GtkStatusIcon, and
508 call gtk_main_quit().
509 (popup_menu): Add a Quit menu item that calls do_quit().
511 2005-11-02 Tor Lillqvist <tml@novell.com>
513 * gdk/win32/gdkcolor-win32.c
514 * gdk/win32/gdkscreen-win32.c
515 * gdk/win32/gdkwindow-win32.c: Whitespace consistency
516 fixes. Remove superfluous test for GdkWindow* parameters being
517 non-NULL. Testing GDK_IS_WINDOW() is enough. As there is only one
518 GdkScreen and one GdkDisplay in the Win32 backend, use those
519 variables instead of the getter functions. For GdkDisplay* and
520 GdkScreen* parameters, check that they are equal to the
521 corresponding singleton variables instead of the more general
522 GDK_IS_DISPLAY() or GDK_IS_SCREEN().
524 2005-11-02 Matthias Clasen <mclasen@redhat.com>
526 * gtk/gtktextview.c: Remove some g_return_if_fail() from
527 static functions, replace some others by g_assert().
529 * gtk/gtktextview.c (selection_motion_event_handler)
530 (gtk_text_view_start_selection_drag): Keep track of the original
531 selection boundaries during a drag selection, in order to correctly
532 decide when to extend or shrink the selection. (#320167,
533 reported by Arvind S N, patch by Paolo Borelli)
535 * gtk/gtktextbtree.c (_gtk_text_line_char_to_byte_offsets):
536 * gtk/gtktextiter.c (gtk_text_iter_backward_chars): Replace
537 manual offset calculations by g_utf8_offset_to_pointer().
538 (#320360, Paolo Borelli)
540 Tue Nov 1 16:18:24 2005 Tim Janik <timj@imendio.com>
542 * gtk/gtkrbtree.[hc]: get rid of GAllocator usage, allocate and free
543 nodes via the g_slice_*() API.
544 _gtk_rbtree_new(): fixed wrong node allocation via g_new().
546 2005-11-01 Tor Lillqvist <tml@novell.com>
548 * gdk/win32/gdkprivate-win32.h
549 * gdk/win32/gdkglobals-win32.c
550 * gdk/win32/gdkmain-win32.c (_gdk_windowing_init): Add more
551 pre-interned GdkAtoms and pre-registered clipboard formats. Sort
552 their declarations, definitions and assignments into a more
553 logical and consistent order.
555 * gdk/win32/gdkmain-win32.c (_gdk_win32_cf_to_string): Include the
556 CF_ prefix for the predefined clipboard format names. Put quotes
557 around registered format names to distinguish them.
559 * gdk/win32/gdkproperty-win32.c (gdk_property_change): Return
560 immediately with a warning if the property type is STRING, TEXT,
561 COMPOUND_TEXT or SAVE_TARGETS, as these are X11-specific that we
562 should never pretend to handle on Win32. Handle only UTF8_STRING
563 here, other formats with delayed rendering. Use \uc1 instead of
564 \uc0 when generating Rich Text Format for easier testability on
565 XP, where WordPad misinterprets \uc0 encoded characters. Add more
566 GDK_NOTE debugging output for Clipboard operations.
568 * gdk/win32/gdkselection-win32.c: Debugging printout improvements.
569 (gdk_selection_convert): Don't pretent to handle STRING, just
570 UTF8_STRING. Streamline error handling, don't unnecessarily have a
571 GError which then isn't used for anything anyway if it gets set.
572 (gdk_win32_selection_add_targets): Skip also STRING, TEXT,
573 COMPOUND_TEXT and SAVE_TARGETS in addition to UTF8_STRING.
575 * config.h.win32.in: Sync with what configure produces.
577 * configure.in: Don't look for X_PACKAGES unless building for
578 x11. (#313986, John Ehresman)
580 2005-10-28 Erdal Ronahi <erdal.ronahi@gmail.com>
582 * configure.in: Added ku (Kurdish) to ALL_LINGUAS
583 Wondered why there was no ku there before??
585 2005-10-28 Matthias Clasen <mclasen@redhat.com>
587 * gtk/gtkentrycompletion.c (_gtk_entry_completion_popup): Add the popup
588 window to the toplevels window group. (#319912, Christian Persch)
590 2005-10-28 Kristian Rietveld <kris@gtk.org>
592 * gtk/gtktreemodelfilter.c (gtk_tree_model_filter_row_deleted): fix
595 2005-10-28 Matthias Clasen <mclasen@redhat.com>
597 * gtk/gtkdnd.c (gtk_drag_get_cursor): Fix the anchor of the default
598 drag cursors. (#319200, Federico Mena Quintero)
600 * gtk/gtktreeview.c (gtk_tree_view_search_key_press_event): Handle
601 Shift-G to go to the previous match, like firefox. (#320061, Christian
604 * gtk/gtktreemodelfilter.c (gtk_tree_model_filter_build_level): Fix a
605 C99ism. (#320000, Kazuki Iwamoto)
607 * gtk/gtkaboutdialog.c (gtk_about_dialog_init): Add the little
608 stars. (#319985, Bastien Nocera)
610 * gtk/gtktreeview.c (gtk_tree_view_search_entry_flush_timeout): Return
611 FALSE, so we don't flush repeatedly. (#319151, Alexander Larsson)
613 2005-10-26 Michael Natterer <mitch@imendio.com>
617 * gtk/gtkcellrendererpixbuf.c (gtk_cell_renderer_pixbuf_set_property):
618 make sure that setting any of pixbuf/stock-id/icon-name resets the
619 others because they are mutually exclusive, and that unsetting any
620 of them only resets the pixbuf and nothing else. Also added
621 some missing g_object_notify().
623 (gtk_cell_renderer_pixbuf_get_property): simplified calls to
624 g_value_set_object().
626 (gtk_cell_renderer_pixbuf_create_stock_pixbuf)
627 (gtk_cell_renderer_pixbuf_create_named_icon_pixbuf): added
628 g_object_notify ("pixbuf").
630 2005-10-27 Matthias Clasen <mclasen@redhat.com>
632 * gtk/gtktreeview.c (gtk_tree_view_button_press): Be more
633 careful about initializing cell_area. (#319382, Tommi
636 * gtk/gtkcombobox.c (gtk_combo_box_key_press): Don't eat
637 Ctrl-PageUp/PageDown. (#318670, Christian Neumair)
639 * demos/gtk-demo/clipboard.c (paste_received): Only set the
640 text if it is not NULL. (#319930, Thomas Klausner)
642 * gtk/gtkselection.c (gtk_selection_data_get_pixbuf): Close the
643 loader before trying to get the pixbuf. (#319930, Thomas Klausner)
645 2005-10-26 Matthias Clasen <mclasen@redhat.com>
647 * gtk/gtkfilesystem.c (gtk_file_system_module_load):
648 * gtk/gtkthemes.c (gtk_theme_engine_load):
649 * gtk/gtkimmodule.c (gtk_im_module_load): Use G_MODULE_BIND_LAZY
650 when dlopening modules. (#319557, Laszlo Peter)
652 2005-10-26 Matthias Clasen <mclasen@redhat.com>
654 * gtk/gtktextbtree.c (gtk_text_btree_resolve_bidi): Only use text
655 segments when determining text direction. (#319065, Tommi Komulainen)
657 * gtk/gtktreeview.c (gtk_tree_view_destroy): Don't crash
658 on duplicate destroy. (#318953, Gustavo Carneiro)
660 * gtk/gtkfilechooserbutton.c (gtk_file_chooser_button_new_with_dialog):
661 Point out that destroy-with-parent is a bad idea for the dialog
662 passed to this function. (#318943, Christian Persch)
664 * */Makefile.am: use $(GLIB_MKENUMS) instead of
665 glib-mkenums. (#318582, Damien Carbery)
667 * gtk/gtktreemodel.c (gtk_tree_model_rows_reordered): Clarify
668 docs. (#317682, Christian Neumair)
670 * gdk/x11/gdkdnd-x11.c: Remove an extra const which doesn't
671 seem to affect the placement of the data in the readonly
672 section, and causes problems with some compilers. (#317844)
674 2005-10-25 Matthias Clasen <mclasen@redhat.com>
676 * gtk/gtktreeviewcolumn.c (gtk_tree_view_column_cell_process_action):
677 Fix some issues with background drawing in RTL. (#318781,
681 * tests/testentrycompletion.c: Apply a patch by Christian
682 Persch to add property editors.
684 * gtk/gtkstatusicon.c: Emit activate on single-click,
685 not on double-click, change proposed by Milosz Derezynski.
687 2005-10-25 Kristian Rietveld <kris@gtk.org>
689 Fixes #311955, reported by Markku Vire; and a lot more.
691 * gtk/gtktreemodelfilter.c: Made this thing work correctly.
692 Levels can now have invisible nodes cached, functions have been
693 rewritten/refactored to take this into account; also the logic in
694 some functions has been corrected.
696 Each referenced node now references all visible children or a single
697 invisible child, in order to be able to monitor all changes in the
698 child model required for correct operation.
700 When a virtual root is set, all nodes on the virtual root level are
703 At last, a bunch of random bug fixes and comment updates.
705 2005-10-25 Matthias Clasen <mclasen@redhat.com>
707 * gtk/gtktexttagtable.c (gtk_text_tag_table_foreach): Add some
708 more docs. (#319722, Paolo Borelli)
710 * gdk/x11/gdkxftdefaults.c (init_xft_settings): Make the
711 initialization of screen_x11->xft_rgba more explicit. (#319627,
714 * gtk/gtkfilechooser.c (gtk_file_chooser_class_init): Fix whitespace
715 in a blurb. (#319499, Francisco Javier F. Serrador)
717 2005-10-24 Matthias Clasen <mclasen@redhat.com>
719 Add settings to hide the input method and Unicode control character
720 submenus in the context menus of GtkEntry and GtkTextView.
722 * gdk/x11/gdkevents-x11.c: Map GTK+ settings to X settings.
724 * gtk/gtksettings.c (gtk_settings_class_init): Declare GTK+ settings here.
726 * gtk/gtktextview.c (popup_targets_received):
727 * gtk/gtkentry.c (popup_targets_received): Use the settings here.
729 2005-10-24 Kristian Rietveld <kris@gtk.org>
731 * gtk/gtktreemodelsort.c (gtk_tree_model_sort_row_inserted): emitting
732 row-has-child-toggled when the level is not in the cache does not
733 make sense. (This bug probably crept in during the early stages
734 of GtkTreeModelSort when there wasn't a correct row-has-child-toggled
736 (gtk_tree_model_sort_real_unref_node): only get the child iter
737 when we will actually also use it.
739 2005-10-22 Michael Natterer <mitch@imendio.com>
741 * gtk/gtktreeview.c (gtk_tree_view_scroll_to_cell): check for the
742 widget being realized, in addition to being visible, to avoid
743 running into precondition check in gtk_tree_view_get_cell_area().
746 2005-10-22 Dom Lachowicz <cinamod@hotmail.com>
748 * modules/engines/ms-windows/msw_style.c (setup_msw_rc_style):
749 Experimentally, scrollbar steppers can shrink to 8 pixels on
750 Win32. Reflect that in the theme.
751 * modules/engines/ms-windows/Theme/gtk-2.0/gtkrc: Experimentally,
752 there is a 1-pixel border between a scrollbar and its child
753 in ScrolledWindows on Win32. Reflect that in the theme.
755 2005-10-20 Matthias Clasen <mclasen@redhat.com>
757 * gtk/gtklabel.c (gtk_label_create_window): Use GDK_WINDOW_CHILD
758 for the selection window. (#318806, Alex Larsson)
760 2005-10-18 Federico Mena Quintero <federico@ximian.com>
764 * tests/autotestfilechooser.c
765 (test_button_folder_states_for_action): Test that we have either
766 $cwd or the explicitly-set folder.
767 (test_reload_sequence): Likewise.
769 * gtk/gtkfilechooserdefault.c
770 (gtk_file_chooser_default_get_current_folder): If our reload_state
771 is RELOAD_EMPTY, return a GtkFilePath corresponding to $cwd.
773 2005-10-14 Tor Lillqvist <tml@novell.com>
775 * gdk/win32/gdkdisplay-win32.c: Remove the clipboard viewer code.
776 It didn't really do anything useful, and was just confusing and
777 incomplete. Comments claimed we don't do delayed rendering, but in
778 fact we do, for images. (The delayed rendering code has other
779 problems, though, see #168173.) The clipboard viewer code was
780 probably even buggy (the WM_CHANGECBCHAIN handled didn't propagate
781 the message when necessary). It was just test code, it said so in
782 a comment. Add something similar back later if necessary.
784 (_win32_on_clipboard_change,
785 _gdk_win32_register_clipboard_notification): Remove.
787 (gdk_display_supports_selection_notification,
788 gdk_display_request_selection_notification): Always just return
789 FALSE. We didn't generate any GDK_OWNER_CHANGE events anywhere.
791 2005-10-13 Tor Lillqvist <tml@novell.com>
793 * gdk/win32/gdkevents-win32.c (gdk_event_translate): Don't treat
794 Alt-Enter specially. It does not have any special meaning and
795 should be passed on to the application. (#318378, Tim Evans)
797 2005-10-13 Tor Lillqvist <tml@novell.com>
799 Set visual depth to 24 for 32 bits-per-pixel devices on
800 Win32. This allows gdk_drawable_real_draw_pixbuf() to use the
801 optimized composite_0888() function rather than the slower image
802 dithering functions to draw pixbufs (#313993, John Ehresman)
804 * gdk/win32/gdkimage-win32.c (_gdk_win32_new_image): Use
805 _gdk_windowing_get_bits_for_depth() to initialize
806 GdkImage::bits_per_pixel.
807 (_gdk_windowing_get_bits_for_depth): Return 32 bits for depth 24.
809 * gdk/win32/gdkpixmap-win32.c (gdk_pixmap_new): Use
810 _gdk_windowing_get_bits_for_depth() to initialize
811 BITMAPINFOHEADER::biBitCount.
813 * gdk/win32/gdkvisual-win32.c (_gdk_visual_init): Set
814 GdkVisual::depth to 24 even if GetDeviceCaps(BITSPIXEL) returns
817 2005-10-12 Stefan Kost <ensonic@users.sf.net>
819 * demos/gtk-demo/appwindow.c: (about_cb):
820 use PACKAGE_VERSION,bump year (#318654)
822 2005-10-11 Matthias Clasen <mclasen@redhat.com>
824 * gtk/gtktextbtree.c (_gtk_text_btree_delete): Try to match an off
825 toggle here with the matching on toggle if it immediately follows.
826 This is a common case, and handling it here prevents quadratic blowup
827 in cleanup_line() below. (#317125)
829 * gtk/gtktextsegment.h:
830 * gtk/gtktextsegment.c (_gtk_char_segment_new_from_two_strings): Pass
831 the character counts into this function instead of computing them
834 2005-10-10 Tommi Komulainen <tommi.komulainen@iki.fi>
836 * gtk/gtkfilechooser.h (GtkFileChooserError): Add ALREADY_EXISTS error
838 * gtk/gtkfilechooserdefault.c
839 (gtk_file_chooser_default_add_shortcut_folder): Return an error code
840 when the shortcut already exists in the sidebar. (#147521)
842 2005-10-09 Matthias Clasen <mclasen@redhat.com>
844 * tests/testcombo.c: Demonstrate how to use custom widgets in
847 2005-10-07 Federico Mena Quintero <federico@ximian.com>
851 * tests/autotestfilechooser.c (test_reload_sequence): Ensure that
852 the the result of gtk_file_chooser_get_folder() is NULL or
853 non-NULL at the right times. Log the tests.
854 (test_button_folder_states): New test for the initial states of
855 the current folder in GtkFileChooserButton.
856 (main): Test that the number of warnings/errors/critical errors is
859 * gtk/gtkfilechooser.c (gtk_file_chooser_get_current_folder):
860 Clarify the documentation on when this can return NULL.
861 (gtk_file_chooser_get_current_folder_uri): Likewise.
863 * gtk/gtkfilechooserbutton.c (struct
864 _GtkFileChooserButtonPrivate): Added a folder_has_been_set flag;
865 we use it to keep track of whether a folder has been set.
866 (gtk_file_chooser_button_map): Implement. If no folder has been
867 loaded before, we at least try to load $cwd here.
868 (gtk_file_chooser_button_constructor): If the construct-time
869 dialog already has a folder set, turn on our folder_has_been_set
871 (dialog_current_folder_changed_cb): Turn on our
872 folder_has_been_set flag.
874 2005-10-07 Michael Natterer <mitch@gimp.org>
876 * gtk/gtkfilechooserdefault.c: remove some explicit #defines of
877 PROFILE_FILE_CHOOSER because they break compilation after the
878 removal of <unistd.h>.
880 2005-10-07 Matthias Clasen <mclasen@redhat.com>
882 * gtk/gtkfilechooserdefault.c: Properly fix the unistd.h include
883 by moving it out of the profiling ifdef.
885 * gtk/gtkfilechooserdefault.c: Remove a redundant (and
886 unconditional) include of unistd.h (#318211, Kazuki Iwamoto)
888 * gtk/gtktexttag.c (gtk_text_attributes_ref): Use
889 g_return_val_if_fail(), not g_return_if_fail(). (#318412,
892 2005-10-06 Matthias Clasen <mclasen@redhat.com>
895 * gtk/gtktextbuffer.h:
896 * gtk/gtktextbuffer.c: Add a readonly has-selection property
897 with a getter. (#318161, Paolo Borelli)
899 2005-10-05 Matthias Clasen <mclasen@redhat.com>
901 * README.in: Start collecting release notes for 2.10.
903 * gtk/gtkrc.c (gtk_rc_clear_realized_style): Readd the memory
904 leak fix, since the assertion failures were traced to
905 an xchat bug. (#314696)
907 * gtk/gtkstyle.c (gtk_style_detach):
908 (gtk_style_attach): Documentation improvements.
909 (gtk_style_detach): Assert that the attach_count is > 0.
911 2005-10-04 Federico Mena Quintero <federico@ximian.com>
913 * gtk/gtkfilechooserdefault.c (switch_to_shortcut): Take a
914 shortcut position, not a ShortcutsIndex, to make the function more
916 (home_folder_handler): Pass the resolved index to
917 switch_to_shortcut(), rather than just SHORTCUTS_HOME.
918 (desktop_folder_handler): Likewise for SHORTCUTS_DESKTOP.
919 (gtk_file_chooser_default_class_init): Add a "quick-bookmark"
920 binding signal, and bind it to Alt-1, Alt-2. ..., Alt-0. These
921 make the respective key switch to the first, second, ..., tenth
923 (quick_bookmark_handler): Implement.
925 2005-10-04 Federico Mena Quintero <federico@ximian.com>
927 * gtk/gtkpathbar.c (get_dir_name): Don't special-case Home and
928 Desktop; just use their real names on the file system for the
931 * gtk/gtkfilechooserdefault.c
932 (gtk_file_chooser_default_class_init): Add a "desktop-folder"
933 binding signal, and bind it to M-d by default.
934 (desktop_folder_handler): Implement the default handler.
935 (home_folder_handler): Use a helper function.
936 (switch_to_shortcut): New helper function.
937 (shortcuts_append_home): Don't special-case the name of "Home";
938 just use the folder name.
940 2005-10-04 Tor Lillqvist <tml@novell.com>
942 * gtk/gtkcalendar.c (gtk_calendar_init): Make it compile without
943 HAVE__NL_TIME_FIRST_WEEKDAY. (#317910, Mathias Hasselmann)
945 2005-10-04 Matthias Clasen <mclasen@redhat.com>
947 * gtk/gtkrc.c (gtk_rc_clear_realized_style): Revert the change
948 from yesterday, since it leads to assertion failures. (#317879,
951 2005-10-03 Matthias Clasen <mclasen@redhat.com>
953 * gtk/gtkcalendar.c (gtk_calendar_init): Call
954 calendar_compute_days() after setting priv->week_start.
956 2005-10-03 Matthias Clasen <mclasen@redhat.com>
958 * gtk/gtkrc.c (gtk_rc_clear_realized_style): Unref the style when
959 removing it from the hash table. (#314696, Benjamin Berg)
961 2005-10-01 Tor Lillqvist <tml@novell.com>
963 * gdk/win32/gdkdrawable-win32.c (blit_from_pixmap): In case
964 BitBlt() fails with ERROR_INVALID_HANDLE, the most probable cause
965 is that the the desktop isn't visible because the session has been
966 switched, the screen is locked, or a terminal server session
967 disconnected, so no error message necessary. (#137796)
969 It is of course remotely possible that BitBlt() failing with
970 ERROR_INVALID_HANDLE might also be caused by some other
971 problem. We could strive for perfection and track whether the
972 desktop is visible by using WTSRegisterSessionNotification() and
973 handling WM_WTSESSION_CHANGE. I think that's overdoing it just for
974 this issue, though. If we would track desktop visibility, we
975 should then avoid even trying to update the display at all while
976 the desktop isn't visible.
978 2005-09-30 Matthias Clasen <mclasen@redhat.com>
980 * gtk/gtkcalendar.c (gtk_calendar_init): Another attempt
981 to correct the calculations for the first week day. We may
982 just have to remove this code if too many locales turn out
985 * gtk/gtkimage.c (gtk_image_expose): Don't leak pixbuf in
986 some cases. (#317611, Tommi Komulainen)
988 * gtk/gtksocket-x11.c (_gtk_socket_windowing_size_request):
989 Prevent overflow when storing size hints in an unsigned
990 short variable. Tracked down by Ray Strode and Søren Sandmann.
992 2005-09-29 Matthias Clasen <mclasen@redhat.com>
994 * gtk/gtkbutton.c (gtk_button_set_image): Check arguments. (#317491,
997 * gtk/gtkpaned.c (gtk_paned_grab_notify): Stop drags when being
998 grab shadowed. (#317332)
1000 2005-09-29 Tor Lillqvist <tml@novell.com>
1002 * gtk-zip.sh.in: DLLs are always in bin nowadays, no need to test.
1004 2005-09-28 Federico Mena Quintero <federico@ximian.com>
1006 * tests/autotestfilechooser.c (test_reload_sequence): Oops, return
1007 if the unmap test fails.
1008 (test_reload_sequence): Use gtk_widget_show_now() instead of
1009 gtk_widget_show() for the dialog.
1010 Thanks to Tim Janik for noticing these.
1012 2005-09-28 Federico Mena Quintero <federico@ximian.com>
1014 * tests/testcellrenderertext.c: New file with a set of tests for
1015 GtkCellRendererText. The idea is to run a text renderer through
1016 most of its interesting property values to see that it works
1019 * tests/Makefile.am: Added testcellrenderertext.
1021 * gtk/gtkfilechooserdefault.c (load_set_model): Mark the
1022 entry/exit of this function for profiling.
1023 (gtk_file_chooser_default_style_set): Mark the start/end of the
1024 calls to the parent class and the the signal emission for profiling.
1026 2005-09-29 Tor Lillqvist <tml@novell.com>
1028 * gtk/gtkmain.c (_gtk_get_localedir): The locale directory is
1029 passed to bindtextdomain() which isn't UTF-8-aware, so convert to
1030 system codepage using g_win32_locale_filename_from_utf8().
1031 (#317457, Kazuki Iwamoto)
1033 2005-09-28 Matthias Clasen <mclasen@redhat.com>
1035 * gtk/gtkselection.c (_gtk_selection_request): Free mult_atoms
1036 here. (#317039, Paolo Borelli)
1039 * gtk/gtktexttag.c (gtk_text_attributes_ref): Return the attributes
1040 to make this function work as boxed copy function. (#317455,
1043 * gtk/gtkclipboard.c (request_image_received_func): Don't unref
1044 NULL. (#316828, Tor Lillqvist)
1046 2005-09-28 Tor Lillqvist <tml@novell.com>
1048 * modules/input/imime.c: Include <config.h>. (#317444, Kazuki
1051 2005-09-27 Federico Mena Quintero <federico@ximian.com>
1053 Don't reload the current folder unnecessarily on ::map().
1055 * gtk/gtkfilechooserprivate.h (ReloadState): New enum to represent
1056 the reloading state.
1057 (struct _GtkFileChooserDefault): Added a "reload_state" field.
1059 * gtk/gtkfilechooserdefault.c (gtk_file_chooser_default_init):
1060 Initialize impl->reload_state.
1061 (gtk_file_chooser_default_map): Check the impl->reload_state; load
1062 a default folder if no folder has been set, or reload the current
1063 one only if we had been unmapped first.
1064 (gtk_file_chooser_default_update_current_folder): Set the
1065 reload_state to RELOAD_HAS_FOLDER.
1066 (gtk_file_chooser_default_unmap): Implement, and set the
1067 reload_state to RELOAD_WAS_UNMAPPED.
1068 (shortcuts_model_create): Don't call shortcuts_add_bookmarks()
1069 here; they'll get (re)loaded on ::map() anyway.
1071 * gtk/gtkfilechooserwidget.c
1072 (gtk_file_chooser_widget_constructor): Don't set a default folder here.
1074 * tests/autotestfilechooser.c (test_action_widgets): Don't take in
1075 a dialog; build it ourselves.
1076 (test_reload): New test to ensure that we don't load the default
1077 folder more than once, and that we reload it when
1078 unmapping/remapping.
1079 (get_impl_from_dialog): New utility function.
1080 (test_widgets_for_current_action): Use get_impl_from_dialog().
1082 2005-09-27 Federico Mena Quintero <federico@ximian.com>
1084 * gtk/gtkfilechooserdefault.c
1085 (gtk_file_chooser_default_constructor): Mark the entry/exit of
1086 this function for profiling.
1087 (check_icon_theme): Likewise.
1088 (change_icon_theme): Likewise.
1089 (settings_notify_cb): Likewise.
1090 (gtk_file_chooser_default_screen_changed): Likewise.
1091 (update_chooser_entry): If the selection is empty, clear the file
1092 name entry only if we are in CREATE_FOLDER mode. In SAVE mode,
1093 nothing will be selected when the user starts typeahead in the
1094 treeview, and we don't want to clear the file name entry in that
1095 case --- the user could be typing-ahead to look for a folder name.
1096 Fixes bug #308332, patch by Jürg Billeter.
1098 2005-09-27 Matthias Clasen <mclasen@redhat.com>
1100 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
1101 Pop below the entry if there's more free space below the entry
1102 than above. (#316948, Tommi Komulainen)
1104 2005-09-26 Federico Mena Quintero <federico@ximian.com>
1106 Do not create the save mode-specific widgets in the open modes, so
1107 that we don't carry their baggage around.
1109 * gtk/gtkfilechooserdefault.c
1110 (gtk_file_chooser_default_constructor): Don't create the
1112 (save_widgets_create): Set the impl->save_widgets directly here,
1113 instead of passing the widgets back to the caller. Also, pack
1114 them into the impl's box.
1115 (update_appearance): Create or destroy the save widgets as
1116 appropriate. Set the action of the save_file_name_entry here.
1117 (shortcuts_add_current_folder): Set the active item in the
1118 save_folder_combo only if it exists.
1119 (gtk_file_chooser_default_set_property): Don't set the action of
1120 the save_file_name_entry here.
1121 (gtk_file_chooser_default_update_current_folder): Set the base
1122 folder of the save_file_name_entry only if the entry exists.
1123 (shortcuts_drag_data_received_cb): Cast the selection_data->data
1124 to (const char *) since that's what shortcuts_drop_uris() expects.
1125 (file_list_drag_data_received_cb): Likewise, for
1126 g_uri_list_extract_uris().
1128 2005-09-26 Tor Lillqvist <tml@novell.com>
1130 * gdk/win32/gdkwindow-win32.c (gdk_window_shape_combine_mask): Set
1131 the shaped flag here, too. (#316871)
1132 (gdk_window_shape_combine_region): Currently unimplemented, so
1133 don't do anything to the shaped flag here.
1135 2005-09-26 Matthias Clasen <mclasen@redhat.com>
1137 Fix #316871, reported by Dan Winship:
1139 * gdk/gdkwindow.h (struct _GdkWindowObject): Add a shaped flag.
1141 * gdk/x11/gdkwindow-x11.c (gdk_window_shape_combine_mask)
1142 (gdk_window_shape_combine_region): Set it here.
1144 * gdk/gdkwindow.c (gdk_window_invalidate_maybe_recurse): Don't
1145 remove the child area for shaped windows.
1147 2005-09-23 Matthias Clasen <mclasen@redhat.com>
1149 * gtk/gtkcellrendererpixbuf.c (gtk_cell_renderer_pixbuf_finalize):
1150 Don't leak expander pixbufs. (#316946, Tommi Komulainen)
1152 2005-09-22 Michael Natterer <mitch@imendio.com>
1154 Renamed GtkCellRendererKeys to GtkCellRendererAccel to be
1155 consistent with GTK+ terminology:
1157 * gtk/gtkcellrendererkeys.[ch]
1158 * tests/testkeys.c: removed...
1160 * gtk/gtkcellrendereraccel.[ch]
1161 * tests/testaccel.c: ...and added.
1166 * tests/Makefile.am: changed accordingly.
1168 2005-09-22 Matthias Clasen <mclasen@redhat.com>
1170 * gtk/gtkwidget.c (gtk_widget_class_init): Fix the documentation
1171 for the grab-broken-event signal, noticed by Damon Chaplin.
1173 2005-09-21 Tor Lillqvist <tml@novell.com>
1175 * gdk/win32/gdkselection-win32.c (gdk_selection_convert,
1176 gdk_text_property_to_text_list_for_display,
1177 gdk_text_property_to_utf8_list_for_display,
1178 gdk_win32_selection_add_targets,
1179 _gdk_win32_selection_convert_to_dib): Free return value from
1181 (gdk_text_property_to_text_list_for_display): Drop GError variable
1182 that isn't actually used after being set.
1184 2005-09-20 Johan Dahlin <jdahlin@async.com.br>
1186 * gtk/gtkentry.c (gtk_entry_set_completion): Mention NULL in
1189 2005-09-20 Tor Lillqvist <tml@novell.com>
1191 * gdk/win32/gdkselection-win32.c
1192 (gdk_selection_owner_get_for_display): Do return the correct owner
1193 for CLIPBOARD (i.e., the owner of the Windows Clipboard, if it is
1194 a window GDK knows about). The reason to return NULL seems to have
1195 gone when in the fix for bug #163702 the artificial
1196 GDK_SELECTION_CLEAR event generation was removed from
1197 gdk_selection_send_notify_for_display(). Fixes bug #316552.
1199 2005-09-20 Matthias Clasen <mclasen@redhat.com>
1201 Avoid unnecessary XkbGetState() calls and XkbStateNotify
1202 events. (#151555, Søren Sandmann)
1204 * gdk/x11/gdkdisplay-x11.c (gdk_display_open): Use
1205 XkbSelectEventDetails() to select XkbStateNotify events
1206 for only the state we care about.
1208 * gdk/x11/gdkprivate-x11.h:
1209 * gdk/x11/gdkkeys-x11.c (_gdk_keymap_state_changed): Pass
1210 the event into the function and update the keymap state from
1211 the state information contained in the event. Adjust all callers.
1213 2005-09-19 Matthias Clasen <mclasen@redhat.com>
1215 * gtk/gtkiconview.c: Use g_list_nth_data() instead of g_list_nth()->data
1216 in multiple places to avoid segfaults if the index is out of range.
1217 (#316422, Guillaume Cottenceau)
1218 (gtk_icon_view_set_drag_dest_item):
1219 (gtk_icon_view_scroll_to_path): Fix a typo in the docs. (#316419,
1220 #316424, Guillaume Cottenceau)
1222 2005-09-18 Hans Breuer <hans@breuer.org>
1224 * gtk/gtktrayicon-win32.c : now handling events by hard-coded
1225 g_signal_emit_by_name() - will break when gtkstatusicon.c changes.
1227 2005-09-18 Hans Breuer <hans@breuer.org>
1229 * gdk/gdk.symbols gdk/win32/gdkwin32.h gdk/win32/gdkcursorwin32.c : export
1230 _gdk_win32_pixbuf_to_hicon() as gdk_win32_pixbuf_to_hicon_libgtk_only()
1231 * gtk/gtktrayicon-win32.c : a lot of debug spew but it has started to show
1232 the icon and is blinking with teststatusicon. More to come ...
1234 2005-09-18 Hans Breuer <hans@breuer.org>
1236 * gtk/makefile.msc.in : fix typo for GTK_VER; define HAVE_CONFIG_H
1237 cause gtkprogressbar.c has #include <config.h> conditionally; less
1238 noise from generated gtk.def
1239 * gtk/stock-icons/makefile.msc gdk/makefile.msc tests/makefile.msc : updated
1241 * gtk/gtktrayicon-win32.c : dummy implmentation to make gtk compile.
1242 For me it works as well as the *NIX implemenation, that is not at all.
1244 * gdk/win32/gdkproperty-win32.c : implement gdk_atom_intern_static_string()
1246 * gdk/win32/gdkwindow-win32.c(gdk_window_set_urgency_hint) : only use
1247 only use (WINVER >= 0x0500) when available from the SDK. Otherwise fall
1248 back to true dynamic linking of FlashWindowEx. Makes gtk+ work on NT4.0
1249 again - if compiled properly.
1251 * tests/teststatusicon.c : don't use GNOME icons for testing, but icons
1252 already coming with Gtk+. Makes it compile on win32.
1254 2005-09-18 Guilherme de S. Pastore <gpastore@cvs.gnome.org>
1256 * README.cvs-commits: fixed some tiny typos
1258 2005-09-16 Tor Lillqvist <tml@novell.com>
1260 * modules/engines/ms-windows/msw_style.c (draw_extension,
1261 draw_box_gap): Check whether the widget actually is a GtkNotebook
1262 before treating it as such. Drop some unneeded local variables,
1263 use parameter with same information instead. (#316412)
1265 2005-09-15 Federico Mena Quintero <federico@ximian.com>
1267 * tests/autotestfilechooser.c: Start a set of automated tests for
1268 the file chooser. The only test in there right now doesn't pass
1269 yet. It specifies the intended behavior of the first optimization
1270 of a series which I'll do on the file chooser (see
1271 http://primates.ximian.com/~federico/news-2005-09.html#14 for the
1272 details of this optimization).
1274 * tests/Makefile.am: Added autotestfilechooser.c.
1276 * gtk/gtkfilechooserprivate.h (struct
1277 _GtkFileChooserDialogPrivate): Move all the file chooser's private
1278 structures to here, so that they can be accessed by
1279 tests/autotestfilechooser.c: _GtkFileChooserDialogPrivate,
1280 _GtkFileChooserWidgetPrivate, LoadState, _GtkFileChooserDefault.
1282 * gtk/gtkfilechooserdialog.c: See above.
1284 * gtk/gtkfilechooserwidget.c: See above.
1286 * gtk/gtkfilechooserdefault.c: See above.
1288 Thu Sep 15 15:27:55 2005 Tim Janik <timj@imendio.com>
1291 gtk_window_map_event(): new function to work around lost unmap requests.
1294 2005-09-14 Federico Mena Quintero <federico@ximian.com>
1296 * gtk/gtkfilechooserdefault.c (gtk_file_chooser_default_init): Add
1297 an easy-to-find profiling marker when starting to create a file
1299 (browse_files_model_finished_loading_cb): Likewise, for when the
1300 chooser is finished loading.
1302 2005-09-14 Tristan Van Berkom <tvb@cvs.gnome.org>
1304 * gtk/gtkcolorbutton.c: Check "color" argument in
1305 gtk_color_button_set_color ()
1307 2005-09-14 Matthias Clasen <mclasen@redhat.com>
1309 * gtk/gtklabel.c (gtk_label_get_type):
1310 * gtk/gtkbutton.c (gtk_button_get_type):
1311 * gtk/gtkwindow.c (gtk_window_group_get_type): No point in
1312 using a mem chunk for window groups, buttons, labels.
1314 * gtk/updateiconcache.c (foreach_remove_func): Fix
1315 a use-after-free bug. (#316256, Alexander Nedotsukov)
1317 2005-09-13 Matthias Clasen <mclasen@redhat.com>
1319 * gtk/*.c: Various cleanups. (#315360, Kjartan Maraas)
1321 * gdk/*.c: Various cleanups. (#315359, Kjartan Maraas)
1323 2005-09-13 Matthias Clasen <mclasen@redhat.com>
1325 * gtk/gtkimcontextsimple.c (gtk_im_context_simple_filter_keypress):
1326 Let GDK_Return pass through in some more cases.
1328 * gtk/gtkentry.c (gtk_entry_key_press): Reset the im context before
1329 activating the entry.
1331 * gtk/gtkiconview.c (gtk_icon_view_class_init):
1332 (gtk_icon_view_get_dest_item_at_pos): Fix typos in the
1333 docs. (#316008, #316027, #316121, Guillaume Cottenceau)
1335 * gtk/gtkfilechooser.c (gtk_file_chooser_class_init): Add some docs.
1336 (#316001, Guillaume Cottenceau)
1338 * gtk/gtkdnd.c (gtk_drag_set_icon_name): Fix a copy-and-paste
1339 mistake in the docs. (#315993, Guillaume Cottenceau)
1341 * tests/testentrycompletion.c (create_simple_completion_model): Add
1342 some strings containing multibyte characters.
1344 * gtk/gtkentrycompletion.c (gtk_entry_completion_real_insert_prefix):
1345 Fix prefix insertion for multibyte characters. (#316095,
1348 * gtk/gtktreeview.c (gtk_tree_view_create_row_drag_icon):
1349 * gtk/gtkiconview.c (gtk_icon_view_create_drag_icon): Silently
1350 return NULL if the widget is not realized. (#316023,
1351 Guillaume Cottenceau)
1353 2005-09-11 Matthias Clasen <mclasen@redhat.com>
1356 * gdk/gdkproperty.h:
1357 * gdk/x11/gdkproperty-x11.c (gdk_atom_intern_static_string):
1358 New function to avoid pointless strdups when creating atoms
1359 from static strings.
1362 * gtk/*.c: Use gdk_atom_intern_static_string() where
1365 2005-09-09 Matthias Clasen <mclasen@redhat.com>
1367 * gtk/gtkcellrendererkeys.h:
1368 * gtk/gtkcellrendererkeys.c: Add a cell renderer for displaying
1369 and editing accelerators, a port of EggCellRendererKeys .
1373 * gtk/Makefile.am: Add the keys cell renderer.
1375 * tests/Makefile.am:
1376 * tests/testkeys.c: Test GtkCellRendererKeys
1378 2005-09-09 Matthias Clasen <mclasen@redhat.com>
1380 Make it possible to determine if a key event is for a
1383 * gdk/x11/gdkprivate-x11.h:
1384 * gdk/x11/gdkkeys-x11.c (_gdk_keymap_key_is_modifier):
1385 New function to determine if a keycode is mapped to a modifier.
1386 (get_xkb): Get the modmap.
1388 * gdk/x11/gdkevents-x11.c (translate_key_event): Set the
1389 is_modifier bit by calling _gdk_keymap_key_is_modifier().
1391 * gdk/gdkevents.h (struct _GdkEventKey): Add an is_modifier
1394 2005-09-09 Matthias Clasen <mclasen@redhat.com>
1396 * gdk/gdkpixbuf-drawable.c (convert_real_slow): Remove an
1397 unused variable, noticed by Kjartan Maraas.
1399 2005-09-09 Matthias Clasen <mclasen@redhat.com>
1401 * gtk/gtktreeviewcolumn.c (gtk_tree_view_column_button_event):
1402 Make drag reordering work properly for columns other than the
1403 first. (#315054, Dan Winship)
1405 * gtk/gtkfontsel.c (gtk_font_selection_set_font_name): Handle
1406 invalid fontnames better. (#136926, Michael R. Walton)
1408 Stop cursor blinking in non-editable regions of a text view.
1409 (#311508, Torbjörn Andersson)
1411 * gtk/gtktextview.c (gtk_text_view_check_cursor_blink):
1412 (cursor_blinks): Take editability into account when deciding
1413 whether the cursor blinks.
1414 (gtk_text_view_button_release_event):
1415 (gtk_text_view_move_cursor_internal): Update cursor blinking here.
1417 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_start_editing):
1418 Use connect_after to connect to the focus_out event. This
1419 ensures that the entry has already stopped blinking by the time
1420 we emit the edited signal. (#315229, Thomas Leonard)
1422 * tests/testgtk.c: Use GDK_MOD1_MASK, not GDK_ALT_MASK.
1424 * gtk/gtkwindow.c (gtk_window_parse_geometry): Don't set
1425 unsigned ints to -1. (#315481, Kjartan Maraas)
1427 * gtk/gtkcalendar.c (gtk_calendar_init): first_weekday is relative
1428 to week_1stday, not to Sunday. Gotta love the ISO 14652 guys...
1429 (#314473, Stanislav Brabec)
1431 2005-09-09 Matthias Clasen <mclasen@redhat.com>
1433 * gtk/gtktreeview.c (gtk_tree_view_get_visible_range): Document
1434 memory handling. (#314975, Torsten Schoenfeld)
1436 * gtk/gtkiconview.c (gtk_icon_view_class_init):
1437 * gtk/gtkfilesel.c (gtk_file_selection_class_init):
1438 * gtk/gtkcombobox.c (gtk_combo_box_class_init):
1439 * gtk/gtklabel.c (gtk_label_class_init):
1440 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_class_init):
1441 Stylistic improvements and clarifications for some blurbs.
1442 (#315520, Clytie Siddall)
1444 2005-09-09 Tor Lillqvist <tml@novell.com>
1446 * gdk/win32/gdkdisplay-win32.c (gdk_display_get_name): Cache the
1447 display name. There is only one GdkDisplay on Win32, and
1448 constructing the display name isn't entirely trivial, so cacheing
1449 is probably worth it. For instance GIMP calls this function a lot.
1450 (gdk_display_open): Call gdk_display_get_name() to prime the
1452 (gdk_display_get_n_screens, gdk_display_get_screen,
1453 gdk_display_get_default_screen): Verify parameter correctness like
1454 the X11 backend does.
1456 * gdk/win32/gdkscreen-win32.c (gdk_screen_make_display_name):
1457 Return a freshly allocated string, as the API specifies. Fixes a
1458 heap corruption problem that caused random errors and crashes in
1461 2005-09-07 Matthias Clasen <mclasen@redhat.com>
1463 * gtk/gtkimcontextsimple.c (gtk_im_context_simple_filter_keypress):
1464 Make C-u commit and restart hex input if we are already in a
1467 2005-09-06 Matthias Clasen <mclasen@redhat.com>
1469 * gdk/x11/gdkkeys-x11.c (update_modmap): Make the modmap reflexive.
1470 (_gdk_keymap_add_virtual_modifiers): Don't add both Alt and Meta
1471 if they are mapped to the same modifier.
1473 * gtk/Makefile.am: Rename gtkstatusicon-x11.c and gtktrayicon.c
1474 to gtkstatusicon.c and gtktrayicon-x11.c
1476 * gtk/gtkaccelgroup.c: Include Super, Hyper and Meta in the
1477 default accel mod mask.
1479 * gtk/gtkaccelgroup.c (gtk_accelerator_parse):
1480 * gtk/gtkaccellabel.c (_gtk_accel_label_class_get_accelerator_label):
1481 Don't use GDK_ALT_MASK.
1483 * gdk/gdktypes.h: No need to introduce GDK_ALT_MASK
1485 2005-09-06 Matthias Clasen <mclasen@redhat.com>
1487 Add support for extra virtual modifiers: (#85780, Owen Taylor)
1489 * tests/testgtk.c (create_key_lookup): Add tests for extra virtual
1492 * gtk/gtkkeyhash.c (_gtk_key_hash_lookup): Try to match both against
1493 Mod2 - Mod5 and against Super, Hyper, Meta.
1495 * gtk/gtkaccellabel.c (_gtk_accel_label_class_get_accelerator_label):
1496 * gtk/gtkaccelgroup.c (gtk_accelerator_parse)
1497 (gtk_accelerator_name): Support Super, Hyper Meta and Mod2 - Mod5.
1499 * gdk/x11/gdkkeys-x11.c (struct _GdkKeymapX11): Add a
1500 modmap to maintain the information which X modifiers map to
1502 (get_xkb): Set up the modmap from the XKB tables.
1503 (update_keymaps): Set up the modmap from the information returned
1504 by XGetModifierMapping in the non-XKB case.
1506 * gdk/x11/gdkprivate-x11.h:
1507 * gdk/x11/gdkkeys-x11.c (_gdk_keymap_add_virtual_modifiers): New
1508 function to set the virtual modifiers in the state.
1510 * gdk/x11/gdkevents-x11.c (translate_key_event): Call
1511 _gdk_keymap_add_virtual_modifiers here.
1513 * gdk/gdktypes.h (GdkModifierType): Add bits for virtual Super,
1514 Hyper and Meta modifiers. Also add GDK_ALT_MASK as an alias
1517 2005-09-05 Matthias Clasen <mclasen@redhat.com>
1519 * gtk/gtkaction.c (connect_proxy): Set the label of a button
1520 if it has no child. (#315253, John Finlay)
1522 2005-09-02 Matthias Clasen <mclasen@redhat.com>
1524 * gtkimcontextsimple.h: Add a modifiers_dropped bit
1526 2005-09-02 Matthias Clasen <mclasen@redhat.com>
1528 * gtk/gtkentry.c (gtk_entry_destroy): Disconnect idle handlers
1529 on destroy to avoid problems when they are called on a destroyed
1530 widget. (#315135, John Cupitt)
1532 * gtk/gtkentry.c (gtk_entry_class_init):
1533 * gtk/gtktextview.c (gtk_text_view_class_init): Add bindings
1534 for Ctrl-Shift-A to unselect all. (#309301, Kathy Fernandes)
1536 * gtk/gtkimcontextsimple.c: Rework the Unicode hex input
1537 code. Now we only steal a single key combination, Ctrl-Shift-U,
1539 A hex Unicode sequence must be started with Ctrl-Shift-U, followed
1540 by a sequence of hex digits entered with Ctrl-Shift still held.
1541 Releasing one of the modifiers or pressing space while the modifiers
1542 are still held commits the character. It is possible to erase
1543 digits using backspace.
1544 As an extension to the above, we also allow to start the sequence
1545 with Ctrl-Shift-U, then release the modifiers before typing any
1546 digits, and enter the digits without modifiers.
1547 (#82011, Owen Taylor)
1549 2005-09-02 Matthias Clasen <mclasen@redhat.com>
1551 * gtk/gtkmain.c (gtk_get_event_widget): If the window is destroyed,
1552 we still need to deliver the destroy event. (#314980, Chris Lahey)
1554 * gtk/gtktextview.c (gtk_text_view_key_press_event): Reset
1555 im context before committing \n or \t.
1557 2005-09-02 Alexander Larsson <alexl@redhat.com>
1559 * gtk/gtkfilechooserdefault.c: (shortcuts_add_volumes),
1560 (shortcuts_activate_volume):
1561 Handle base_path being null in the rest of the cases (#310270)
1563 2005-09-02 Tor Lillqvist <tml@novell.com>
1565 * gdk/win32/gdkevents-win32.c (gdk_event_translate): Keep track of
1566 cursor position also in root window coordinates. Prune out
1567 superfluous WM_MOUSEMOVE events even earlier, based on root window
1568 coordinates. Windows sends WM_MOUSEMOVE messages after a new
1569 window has ben mapped below the cursor even if the mouse doesn't
1570 move. We used to generate GDK_MOTION_NOTIFY in these cases. This
1571 confused at least gtk_menu_motion_notify(). (#314995)
1573 * gtk/gtkintl.h: No need to include config.h here. It caused
1574 warnings about GTK_LOCALEDIR being redefined on Win32 when
1575 compiling files where gtkintl.h is included after gtkprivate.h
1576 (which #undefines and re-#defines GTK_LOCALEDIR on Win32).
1578 * gtk/gtkplug.c: Include config.h.
1580 2005-09-01 Matthias Clasen <mclasen@redhat.com>
1582 * gtk/gtkfilesystemunix.c: Pass statbufs down to
1583 xdg_mime_get_mime_type_for_file() where possible, to avoid
1586 * gtk/gtkaction.c (gtk_action_get_accel_closure): Fix doc
1587 typo. (#314921, Guillaume Cottenceau)
1589 * gdk/*.c: Intern some more strings.
1591 * gtk/*.c: Define an I_() macro and use it instead of the
1592 bulky g_intern_static_string().
1594 2005-08-31 Matthias Clasen <mclasen@redhat.com>
1596 * gtk/gtkbindings.c (binding_signal_new): Intern the signal name
1597 instead of copying it.
1599 * gtk/gtktypeutils.c (gtk_identifier_get_type): Some more string interning.
1601 * gtk/*.c: Also intern static strings passed to
1602 g_object_set_data().
1605 * gtk/Makefile.am: Intern type names in code generated by
1610 * gdk/*.c: Intern type names before registering the type to avoid
1613 * configure.in: Require GLib 2.9.0
1615 2005-08-31 Matthias Clasen <mclasen@redhat.com>
1617 * gtk/gtktoolbar.c: Undeprecate gtk_toolbar_set_icon_size(),
1618 and add icon-size and icon-size-set properties. (#314172)
1620 * gtk/gtkwindow.c (gtk_window_set_transient_for): Inherit window
1621 groups across transient parents. (#312918, Christian Persch)
1623 * gtk/gtktreemodel.c: Some documentation fixes. (#314882,
1624 Guillaume Cottenceau)
1626 * gtk/gtktextiter.c (gtk_text_iter_backward_visible_cursor_positions):
1627 Fix a typo in the docs. (#314878, Guillaume Cottenceau)
1629 2005-08-30 Matthias Clasen <mclasen@redhat.com>
1631 * gtk/gtkentry.c (gtk_entry_class_init): Add key bindings to
1632 make C-/ select all and C-\ unselect all. (#309301,
1635 * gtk/gtkimcontextsimple.c: Change the compose sequence for
1636 soft hyphen to be multi_key-minus-minus-space, and add
1637 compose sequences multi_key-minus-minus-period and
1638 multi_key-minus-minus-minus for en dash and em dash.
1639 (#172653, Christian Lohmaier)
1641 * gtk/gtkentry.c (gtk_entry_draw_frame): Fix some unused
1642 code. (#313946, Christian Persch)
1644 * gtk/gtkuimanager.c (gtk_ui_manager_class_init): Another
1645 fix for the default value of the "ui" property.
1647 2005-08-30 Matthias Clasen <mclasen@redhat.com>
1650 * gtk/gtkselection.h:
1651 * gtk/gtkselection.c: Add functions which look for text, image
1652 or uri targets in an array of atoms. (#314089, Mark Wielaard)
1655 * gtk/gtkselection.h:
1656 * gtk/gtkselection.c (gtk_selection_data_targets_include_uri):
1657 Add a function to check wether targets include uri.
1658 (#314092, Mark Wielaard)
1662 * gtk/gtkwindow.c: Add a deletable property with getter
1663 and setter, to control the close button in the window
1664 frame. (#59718, Havoc Pennington)
1666 2005-08-29 Matthias Clasen <mclasen@redhat.com>
1668 * gtk/gtkrc.key.emacs: Add C-n/C-p/C-f/C-b as alternatives
1669 to the arrow keys for menu navigation. (#162825, Carl Worth)
1671 * gtk/gtkentry.c, gtk/gtktextview.c: More typo fixes
1673 * gtk/gtksocket-x11.c, gtk/gtkstatusicon-x11.c: Fix typos.
1675 * gtk/gtkstatusicon-x11.c (gtk_status_icon_new_from_stock):
1676 * gtk/gtkimage.c (gtk_image_new_from_stock): Don't
1677 refer to nonexisting stock ids.
1679 * gtk/gtktextview.c (popup_targets_received):
1680 * gtk/gtkentry.c (popup_targets_received): Construct
1681 the "Select All" menuitem from stock.
1683 * gtk/stock-icons/stock_select_all_{16,24}.png:
1684 * gtk/stock-icons/Makefile.am:
1685 * gtk/gtkiconfactory.c:
1687 * gtk/gtkstock.c: Add a "Select All" stock item. (#78545,
1690 * gtk/gtktrayicon.c: Add a pointer to the spec.
1692 * gtk/gtkstatusicon-x11.c: Add docs.
1694 * gtk/gtkstatusicon.h: Fix a typo.
1696 Add a cross-platform "tray icon" API, by
1697 porting EggStatusIcon/EggTrayIcon (#105101)
1699 * gtk/gtkstatusicon.h: A GtkStatusIcon is an object which
1700 displays an icon in a notification area.
1702 * gtk/gtkstatusicon-x11.c: GtkStatusIcon implementation for
1703 X11, using GtkTrayIcon.
1705 * gtk/gtktrayicon.h:
1706 * gtk/gtktrayicon.c: An implementation of the freedesktop.org
1707 system tray specification, not public API.
1709 * gtk/gtk.symbols: Add new exported functions.
1711 * gtk/gtk.h: Include gtkstatusicon.h.
1713 * gtk/Makefile.am: Add new files.
1715 * tests/Makefile.am:
1716 * tests/teststatusicon.c: Test for GtkStatusIcon.
1718 2005-08-29 Christopher Aillon <caillon@redhat.com>
1720 * gtk/gtkstock.c: Add builtin GtkStockItems for GTK_STOCK_CONNECT
1721 and GTK_STOCK_DISCONNECT
1723 2005-08-29 Matthias Clasen <mclasen@redhat.com>
1725 * gtk/gtksocket-x11.c (_gtk_socket_windowing_embed_notify):
1726 Use XFixesChangeSaveSet if available. (#314682)
1728 * gtk/gtkmenu.c (gtk_menu_grab_notify): Only cancel if the menu
1729 was active. (#314298, Christian Persch, analysis by Mark McLoughlin)
1731 2005-08-29 Matthias Clasen <mclasen@redhat.com>
1733 * gtk/gtkiconcache.c (_gtk_icon_cache_get_icon): Remove an
1734 accidentally leftover duplicate pixbuf creation. (#314700,
1737 * gtk/gtksettings.c (settings_update_cursor_theme): Don't
1738 leak the cursor theme name. (#314693, Kjartan Maraas)
1740 * gdk/x11/gdkasync.c (_gdk_x11_get_window_child_info): Free
1741 state.children in all cases. (#313862, Kjartan Maraas)
1743 2005-08-28 Matthias Clasen <mclasen@redhat.com>
1745 * po/POTFILES.in, po-properties/POTFILES.in:
1748 2005-08-27 Matthias Clasen <mclasen@redhat.com>
1750 * gtk/gtkuimanager.c (gtk_ui_manager_class_init): Fix the default
1751 value of the ui property. (#314532, Yong Wang)
1753 * gdk/x11/gdkproperty-x11.c (gdk_property_get): Don't warn
1754 when G_MAXLONG is passed as length.
1756 2005-08-26 Matthias Clasen <mclasen@redhat.com>
1758 * gtk/updateiconcache.c: Add a separate --ignore-theme-index option
1759 to avoid overloading --force. (JP Rosevaar)
1761 2005-08-26 Matthias Clasen <mclasen@redhat.com>
1763 * configure.in: Bump version to 2.9.0
1767 * gdk/gdkscreen.c: Make the GdkScreen font options api
1768 public, and add properties GdkScreen::font-options and
1769 GdkScreen::resolution. (#314004)
1772 * gtk/gtksettings.c:
1773 * gtk/gtkwidget.c: Adjust all callers.
1775 * gdk/gdkintl.h: Simplify and use glib/gi18n-lib.h.
1776 * gdk/gdkpango.c: Include gdkintl.h, not gtkintl.h.
1777 * gdk/gdkscreen.c: Include gdkintl.h.
1779 * gtk/gtkicontheme.c (theme_lookup_icon): Avoid an uninitialized
1780 variable warning, pointed out by Colin Walters. (#314585)
1782 2005-08-26 Tor Lillqvist <tml@novell.com>
1784 * gtk/gtkfilesystemwin32.c: Remove some ifdeffed out debugging
1786 (gtk_file_system_win32_parse): Don't mishandle UNC paths. (#314519)
1788 2005-08-26 Matthias Clasen <mclasen@redhat.com>
1790 * gtk/gtkcalendar.c (gtk_calendar_init): Fix the calculation
1791 of week_start. (#314473, JP Rosevaar)
1793 2005-08-25 Thomas Fitzsimmons <fitzsim@redhat.com>
1795 * gtk/gtkfilesystemmodel.c (idle_finished_loading_cb): Acquire GDK
1796 lock. (#314533, Thomas Fitzsimmons)
1798 2005-08-25 Matthias Clasen <mclasen@redhat.com>
1800 * gtk/gtktoolbar.c (_gtk_toolbar_elide_underscores): Handle
1801 NULL gracefully. (#314523, Ed Catmur)
1803 2005-08-25 Owen Taylor <otaylor@redhat.com>
1805 * gdk/x11/gdkcursor-x11.c (gdk_x11_display_set_cursor_theme):
1806 Handle theme == NULL.
1808 2005-08-25 Matthias Clasen <mclasen@redhat.com>
1810 * gtk/gtkmenutoolbutton.c (menu_position_func): Take widget
1811 y offset into account when positioning the popup. (#314470,
1814 2005-08-25 Owen Taylor <otaylor@redhat.com>
1816 * gdk/gdkscreen.c (gdk_screen_get_type): Use gdk_screen_init
1817 as instance_init, not base_init! (#314452, Fix from Frederic
1818 Crozat, reported by Joe Marcus Clarke). Trivial cleanup: use -1.
1819 rather than 1 for a negative flag value.
1821 2005-08-24 Owen Taylor <otaylor@redhat.com>
1823 * gdk/gdkpango.c (draw_error_underline): Add a note about
1824 cut-and-paste between here and Pango.
1826 2005-08-24 Matthias Clasen <mclasen@redhat.com>
1828 * === Released 2.8.2 ===
1830 * gtk/gtkclipboard.c (request_image_received_func): Use the correct
1831 callback for image/gif, and also try image/bmp. (#314086, Mark
1834 * gtk/gtkfilesystemunix.c (gtk_file_system_unix_volume_render_icon):
1835 Use gnome-dev-harddisk for volumes, not gnome-fs-blockdev. (#314382,
1840 * gtk/gtksettings.c (gtk_settings_get_for_screen): Make sure font
1841 and cursor settings get propagated down to the screen initially.
1842 Pointed out by Frederic Crozat.
1844 * gtk/gtkicontheme.c (ensure_valid_themes): Don't try to send a client
1845 message if the screen is NULL. Noticed by Kjartan Maraas.
1847 2005-08-24 Matthias Clasen <mclasen@redhat.com>
1851 * === Released 2.8.1 ===
1855 2005-08-24 Matthias Clasen <mclasen@redhat.com>
1857 * gtk/gtktreemodelfilter.c (gtk_tree_model_filter_visible): Protect
1858 against lazy filterers which return values other than TRUE or
1859 FALSE from their visible func. (#314335)
1861 2005-08-23 Owen Taylor <otaylor@redhat.com>
1863 Fix for #314004, reported by Michael Reinsch:
1866 * gdk/gdkscreen.[ch]: Add gdk_screen_get/set_font_options_libgtk_only()
1867 Add gdk_screen_get/set_resolution_libgtk_only()
1869 * gdk/gdkpango.c (gdk_pango_context_get_for_screen): Set
1870 the options for the screen on the newly created context.
1872 * gtk/gtksettings.c (settings_update_font_options/dpi) gtkwidget.c:
1873 Move font options and dpi code from gtkwidget.c to gtksettings.c, set
1874 the font options on the screen.
1876 * gtk/gtkwidget.c (gtk_widget_update_pango_context): Just get
1877 the font options from the screen and set them on the context.
1879 2005-08-23 Kristian Rietveld <kris@gtk.org>
1881 * gtk/gtktreemodelsort.c (gtk_tree_model_sort_row_inserted): don't
1882 bother inserting new rows in a level with a zero refcount and
1883 immediately free the level. (Fixes #312350, reported by Markku Vire).
1885 2005-08-23 Matthias Clasen <mclasen@redhat.com>
1887 * gtk/updateiconcache.c: Complain when there is no index.theme file
1888 in the specified directory, unless --force is used. Also add an
1889 --index-only option to create caches without image data.
1891 * gtk/gtkfilechooserdefault.c (shortcuts_append_desktop): Fix a
1892 C99ism. (#314262, Robert Jeff Mitchell)
1894 2005-08-22 Manish Singh <yosh@gimp.org>
1896 * gtk/gtkicontheme.h: add declaration for _gtk_icon_theme_check_reload.
1898 * gtk/gtkwindow.c: remove declaration of gtk_window_read_rcfiles.
1900 2005-08-22 Matthias Clasen <mclasen@redhat.com>
1902 * gtk/gtkwindow.c (gtk_window_client_event):
1903 * gtk/gtkicontheme.c (ensure_valid_themes)
1904 (_gtk_icon_theme_check_reload): Implement a clientmessage based
1905 scheme for makeing sure that all GTK+ applications notice if an
1906 icon theme has been updated. This should prevent multiple versions
1907 of an icon theme cache to be mapped in memory at the same time,
1908 which can cause excessive memory consumption. (#313156, Chris
1911 2005-08-22 Matthias Clasen <mclasen@redhat.com>
1913 * gtk/gtkicontheme.c (gtk_icon_theme_load_icon): Add a note
1914 regarding icon theme changes.
1916 * gtk/gtkiconcache.c (_gtk_icon_cache_get_icon): When returning
1917 pixbufs which are backed by the mmapped memory of an icon cache,
1918 increase the refcount of the icon cache, so that the memory is not
1919 munmapped away underneath the pixbuf upon icon theme changes.
1920 (#314170, Kjartan Maraas)
1922 * docs/tools/Makefile.am (LDADDS): Add GTK_DEP_LIBS, in order
1923 to link against Xext. (#314062)
1925 * gtk/gtkhsv.c (paint_triangle): One more fix to prevent buffer
1926 overruns. (#314081, Hans Breuer)
1928 2005-08-20 Matthias Clasen <mclasen@redhat.com>
1930 * gtk/gtkentry.c (gtk_entry_get_layout): Clarify that the
1931 returned layout must not be modified.
1933 Sat Aug 20 16:12:14 2005 Jonathan Blandford <jrb@redhat.com>
1935 * gtk/gtktreeview.c (gtk_tree_view_set_model): clear
1936 scroll_to_path if the model changes.
1938 * gtk/gtkiconview.c: (gtk_icon_view_destroy),
1939 (gtk_icon_view_size_allocate), (gtk_icon_view_set_cursor),
1940 (gtk_icon_view_scroll_to_path): Handle scrolling to a path before
1941 we're realized, #312798
1942 (gtk_icon_view_set_model): clear scroll_to_path if the model
1945 2005-08-20 Matthias Clasen <mclasen@redhat.com>
1947 * gtk/gtkrange.c (gtk_range_adjustment_changed)
1948 (gtk_range_adjustment_value_changed): Don't queue a draw
1949 if the layout has not changed. (#313991, Benjamin Berg)
1951 2005-08-19 Matthias Clasen <mclasen@redhat.com>
1953 * gtk/gtktreeitem.c: Remove duplicate lines. (#313344,
1956 * modules/engines/ms-windows/msw_style.c (setup_system_styles):
1959 * gtk/gtkfilechooserbutton.c (change_icon_theme)
1960 (model_add_special, model_add_special, model_add_volumes):
1961 Handle pixbuf being NULL without warnings. Also, don't
1962 leak pixbuf references when the icon theme is changed.
1964 * gtk/gtkmain.c (gtk_get_event_widget): Don't access
1965 the user data on destroyed windows, since at best
1966 it can be a stale pointer. (#313953, Robin Green)
1968 2005-08-19 Matthias Clasen <mclasen@redhat.com>
1970 * gtk/gtkhsv.c (paint_triangle): Avoid a buffer overrun.
1971 (#313900, Sebastien Bacher)
1973 * gtk/gtktreeview.c (gtk_tree_view_get_visible_range): Return
1974 FALSE if the tree is empty. (#313891, Guillaume Cottenceau)
1976 * gdk/x11/gdkdnd-x11.c (_gdk_drag_get_protocol_for_display)
1977 (xdnd_read_actions, get_client_window_at_coords_recurse):
1978 Free data returned from XGetWindowProperty.
1980 * gdk/x11/gdkevents-x11.c (fetch_net_wm_check_window)
1981 Free data returned from XGetWindowProperty. (313867, Kjartan
1984 * gdk/x11/gdkdnd-x11.c (get_client_window_at_coords_recurse): Free
1985 children in all cases. (#313862, Kjartan Maraas)
1987 * gtk/gtkicontheme.c (theme_lookup_icon): Store GtkIconData structs
1988 in the per-directory hash, even if they come from the icon cache.
1989 We tried to avoid that before, but as a result leaked icon data
1990 structs. (#313852, Kjartan Maraas)
1992 2005-08-18 Matthias Clasen <mclasen@redhat.com>
1994 * gtk/gtkmenutoolbutton.c (gtk_menu_tool_button_destroy): Disconnect
1995 signal handlers on destroy, not on finalize. (#313759, Brett Atoms)
1997 2005-08-15 Owen Taylor <otaylor@redhat.com>
1999 * configure.in: Add -lXext to GDK_EXTRA_LIBS in absence of pkg-config
2000 files for x11/xext. (Jonas Bonn)
2002 2005-08-15 Tor Lillqvist <tml@novell.com>
2004 * gtk/gtkicontheme.c (theme_lookup_icon): Put debugging printout
2007 2005-08-15 Owen Taylor <otaylor@redhat.com>
2009 * configure.in: Fix have_base_pc / have_base_x_pc typo.
2011 * gdk/x11/gdkdrawable-x11.c gtk/gtksettings.c: Remove panoxft.h includes.
2012 (#313417, James Andrewartha)
2014 * configure.in: Add fontconfig to X_PACKAGES, since we use it for
2015 FcNameConstant(). (More of #313417)
2017 2005-08-15 Matthias Clasen <mclasen@redhat.com>
2019 * gtk/gtkfilechooserdefault.c: When using gtk_dialog_run() for
2020 modal dialogs, make sure to inherit the window group from
2021 the parent, since we don't inherit window groups across
2022 transient parents currently. (#312918, Christian Persch)
2024 * gtk/gtkmessagedialog.c (gtk_message_dialog_new):
2025 * gtk/gtkdialog.c (gtk_dialog_run): Slight update to the docs.
2027 * gtk/gtkiconview.c (gtk_icon_view_select_path)
2028 (gtk_icon_view_scroll_to_path): Handle paths of depth 0
2029 gracefully. (#312796, Jonathan Blandford)
2031 * tests/testtoolbar.c: Add some more tests for menu placement.
2033 * gtk/gtkmenutoolbutton.c (menu_position_func):
2034 * gtk/gtktoolbar.c (menu_position_func): Improve positioning
2035 of toolbutton menus and of the overflow menu. (#312937,
2036 #153870, Christian Persch, Paolo Borelli)
2038 2005-08-15 Tor Lillqvist <tml@novell.com>
2040 * gtk/updateiconcache.c: Use g_path_get_dirname() instead of
2041 the nonportable <libgen.h> and dirname().
2043 2005-08-15 Matthias Clasen <mclasen@redhat.com>
2045 * gtk/gtksizegroup.c: Use object data to mark widgets and
2046 groups as visited, so that we avoid constant extra list
2047 traversals. Also allocate quarks in class_init. (#311618,
2050 * gtk/gtkicontheme.c (gtk_icon_theme_lookup_icon): Correct the
2051 download location for the hicolor icon theme. (#313475, Olexiy
2054 * gtk/gtkicontheme.c: Remove debug spew.
2056 2005-08-15 Owen Taylor <otaylor@redhat.com>
2058 * gdk/linux-fb/gdkwindow-fb.c (gdk_window_set_back_pixmap):
2059 * gdk/win32/gdkwindow-win32.c (gdk_window_set_back_pixmap):
2060 * gdk/x11/gdkwindow-x11.c (gdk_window_set_back_pixmap):
2061 Handle pixmap == NULL when checking for a colormap.
2064 2005-08-14 Matthias Clasen <mclasen@redhat.com>
2066 * gtk/updateiconcache.c: Store only one copy of the pixel data
2067 for symlinked icons. To achieve this, maintain a hashtable
2068 mapping pathnames to pixel data, and share the pixel data for
2069 all symlinks resolving to the same pathname. When writing out
2070 the image data, write out the pixel data only the first time
2071 it is met, and store the offset pointing to the first copy
2072 for use in all later cases.
2073 This reduces the size of the Bluecurve icon cache from 40