1 Wed Jul 7 23:44:32 2004 Matthias Clasen <maclas@gmx.de>
3 * gtk/gtkimage.c (gtk_image_expose): Make sure that subpixbufs
4 are properly aligned for gdk_pixbuf_saturate_and_pixelate(),
5 in order to avoid rendering artifacts from misaligned
6 pixelation patterns. (#145585, Felipe Heidrich, Billy Biggs)
8 2004-07-07 Matthias Clasen <mclasen@redhat.com>
11 * gtk/gtktreeview.h: Small documentation fixes.
13 2004-07-07 Matthias Clasen <mclasen@redhat.com>
15 Support separators in combo boxes and more generally in tree
19 * gtk/gtkcombobox.c (gtk_combo_box_get_row_separator_column):
20 * gtk/gtkcombobox.c (gtk_combo_box_set_row_separator_column):
21 Add a ::row-separator-column property with getter and setter,
22 which can indicate a boolean model column to determine which
25 * gtk/gtkcombobox.c: Display separator rows as separator menu
26 items in menu mode, and by using the new treeview separator
27 functionality in list mode.
30 * gtk/gtktreeprivate.h:
31 * gtk/gtktreeview.c (gtk_tree_view_get_row_separator_func):
32 * gtk/gtktreeview.c (gtk_tree_view_set_row_separator_func):
33 Add a callback to determine whether a row is a separator.
35 * gtk/gtktreeview.c (gtk_tree_view_bin_expose):
36 * gtk/gtktreeview.c (gtk_tree_view_create_row_drag_icon):
37 * gtk/gtktreeview.c (validate_row): Use the new callback
38 to determine whether a row is a separator, and draw it
39 as a separator then. Since separators should take up less
40 vertical space than regular rows, this requires removing
41 the redundant MAX(...,expander_size) calls which appear in
42 many places. Instead, the MAX() is now only done in
43 validate_row(), and only if the row is not a separator.
44 To catch possible side effects of this intrusive change,
45 I have left EXPANDER_MAX() calls in place of the MAX() calls
46 which will emit a warning if something breaks. They should
47 be removed before 2.6.
49 * gtk/gtktreeselection.c (row_is_selectable): Don't let
50 separator rows be selected.
52 * tests/testcombo.c (create_blaat): Add a separator column.
54 Tue Jul 6 22:58:00 2004 Matthias Clasen <maclas@gmx.de>
56 * gdk/x11/gdkwindow-x11.c (gdk_x11_window_set_user_time): Fix
57 a 64bit alignment issue. (#144302, Sunil)
59 2004-07-07 Tor Lillqvist <tml@iki.fi>
61 * gdk/win32/gdkdrawable-win32.c (gdk_win32_draw_text)
62 * gdk/win32/gdkfont-win32.c (gdk_text_extents)
63 * gdk/win32/gdkproperty-win32.c (find_common_locale,
65 * gdk/win32/gdkselection-win32.c (gdk_selection_convert): Use
66 g_utf8_to_utf16() instead of the removed _gdk_utf8_to_ucs2() (see
69 * gdk/win32/gdkglobals-win32.c
70 * gdk/win32/gdkmain-win32.c (_gdk_windowing_init)
71 * gdk/win3/gdkprivate-win32.h: Add a variable for the TARGETS
72 atom. Initialize it. Declare it. Drop the variable for the
75 * gdk/win32/gdkim-win32.c (gdk_wcstombs): Don't return UTF-8. This
76 function is supposed to return the string in the locale's charset
77 and encoding. Use g_convert().
79 (gdk_mbstowcs): Similarily, don't take an UTF-8 string, but a
80 string in the locale's charset. Use g_convert().
82 (_gdk_ucs2_to_utf8, _gdk_utf8_to_wcs, _gdk_utf8_to_ucs2):
83 Delete. The UCS-2 functions didn't handle surrogates anyway. Use
84 GLib's UTF-16 functions instead. Windows uses UTF-16.
86 * gdk/win32/gdkprivate-win32.h: Remove declarations of the deleted
87 functions mentioned above.
89 * gdk/win32/gdkproperty-win32.c (gdk_property_change): Use CF_TEXT
90 also if the string is of type STRING, i.e. ISO-8859-1, and the
91 current codepage is 1252, and contains no C1 chars. Accept
94 * gdk/win32/gdkselection-win32.c (_gdk_selection_property_store):
95 Mark as static. When storing STRING data, convert to
97 (gdk_selection_owner_set_for_display): Now that STRING is always
98 ISO-8859-1, use UTF8_STRING when sending the selection request
101 (gdk_selection_convert): Handle also UTF8_STRING. (#140537, John
104 (gdk_text_property_to_text_list_for_display): Make work more like
105 X11 version. Do obey the encoding parameter.
107 (gdk_string_to_compound_text_for_display,
108 gdk_utf8_to_compound_text_for_display): Don't even pretend
109 supporting COMPOUND_TEXT.
111 (gdk_utf8_to_string_target): Convert to ISO-8859-1, like on X11.
113 (sanitize_utf8): Zero-terminate string.
115 2004-07-06 Matthias Clasen <mclasen@redhat.com>
117 * gtk/stock-icons/Makefile.am: Add stock_file_16.png,
118 stock_file_24.png, stock_directory_16.png and stock_directory_24.png.
120 * gtk/gtkstock.h (GTK_STOCK_FILE, GTK_STOCK_DIRECTORY):
121 * gtk/gtkiconfactory.c (get_default_icons): New stock icons as
122 fallbacks for gtkfilechooser. Currently these are the same images
123 as the "new" and "open" items...
125 Tue Jul 6 10:00:22 2004 Jonathan Blandford <jrb@redhat.com>
127 Fix for #136496, Pawel Salek:
129 * gtk/gtktreeview.c (gtk_tree_view_row_changed): Queue a redraw on
130 a node when it changes in fixed_height mode.
132 (gtk_tree_view_node_queue_redraw): new function to queue a redraw
135 2004-07-06 Matthias Clasen <mclasen@redhat.com>
137 * gtk/gtkmenu.c (gtk_menu_position): Make sure
138 private->monitor_num is a valid monitor number before
139 using it. (#139187, Michael Natterer)
141 Tue Jul 6 02:00:28 2004 Matthias Clasen <maclas@gmx.de>
143 * gtk/gtkfilechooserdefault.c (popup_position_func):
144 * gtk/gtkentry.c (popup_position_func):
145 * gtk/gtktextview.c (popup_position_func): Improve positioning
146 of keyboard-activated menus with Xinerama.
148 Tue Jul 6 00:29:03 2004 Matthias Clasen <maclas@gmx.de>
150 * gtk/gtkuimanager.c (do_updates):
151 (do_updates_idle): Only call GDK_THREADS_ENTER() / _LEAVE()
152 when called from an idle handler. (#145429, Jan-Marek Glogowski)
154 Mon Jul 5 23:47:38 2004 Matthias Clasen <maclas@gmx.de>
156 * gtk/gtkfilechooserutils.c (delegate_notify): Use
157 the less efficient g_object_interface_find_property () instead
158 of the param_id range check, since the GParamSpecs we're
159 dealing with are the overridden onces on the interface, whose
160 param_id is always zero. (#145312, Alex Roitman, fix proposed
163 2004-07-05 Lorenzo Gil Sanchez <lgs@sicem.biz>
165 * gtk/gtklayout.c (gtk_layout_add): added a default method for the add
166 virtual method of GtkContainer.
167 (gtk_layout_class_init): assign gtk_layout_add to the 'add' virtual
168 method slot of the container class.
170 2004-07-05 Anders Carlsson <andersca@gnome.org>
172 * gtk/gtkiconview.c: (gtk_icon_view_set_markup_column):
174 Use gint, not int in gtk_icon_view_set_markup_column,
177 2004-07-05 Anders Carlsson <andersca@gnome.org>
179 * gtk/gtkiconview.c: (gtk_icon_view_class_init),
180 (gtk_icon_view_real_select_cursor_item),
181 (gtk_icon_view_real_activate_cursor_item):
183 Add an "activate_cursor_item" action signal
184 and bind it to the return key.
186 2004-07-04 Anders Carlsson <andersca@gnome.org>
188 * demos/gtk-demo/Makefile.am:
189 * demos/gtk-demo/gnome-fs-directory.png:
190 * demos/gtk-demo/gnome-fs-regular.png:
191 * demos/gtk-demo/iconview.c: (load_pixbufs), (fill_store),
192 (sort_func), (create_store), (item_activated), (up_clicked),
193 (home_clicked), (do_iconview):
194 Add a simple file browser based on the icon view.
197 Add gtk/gtkiconview.h
199 * gtk/gtkiconview.c: (gtk_icon_view_layout),
200 (gtk_icon_view_item_new), (gtk_icon_view_item_activated):
201 Fix a few bugs discovered while writing the demo.
203 2004-07-04 Anders Carlsson <andersca@gnome.org>
208 Add GtkIconView to the build, remove debugging output.
210 Sun Jul 4 01:29:35 2004 Matthias Clasen <maclas@gmx.de>
212 * gtk/gtkcalendar.c (gtk_calendar_drag_data_get):
213 (gtk_calendar_drag_data_received): Fix off-by-one error.
214 GDate month is one-based and GtkCalendar month is zero-based.
215 (#145134, William Jon McCann)
217 Sun Jul 4 01:11:07 2004 Matthias Clasen <maclas@gmx.de>
219 * gtk/gtktreestore.c (gtk_tree_store_move): Don't crash if
220 somebody tries to move a node after itself in a list of
221 length 1. (#145291, Sampo Nurmentaus)
223 Sat Jul 3 23:43:23 2004 Matthias Clasen <maclas@gmx.de>
225 * docs/faq/gtk-faq.sgml:
226 * gtk/gtkwindow.c: Fix links to www.freedesktop.org. (#145210,
229 Sat Jul 3 02:09:51 2004 Matthias Clasen <maclas@gmx.de>
231 * gtk/gtksocket.c (gtk_socket_end_embedding): Reset current_width
232 and current_height to 0 when ending the embedding. (#143675,
235 Sat Jul 3 01:48:19 2004 Matthias Clasen <maclas@gmx.de>
237 * gtk/gtkentry.c (gtk_entry_move_visually): Let the cursor move
238 to the right end of the entry text, even if it ends in combining
239 marks. (#141728, Theppitak Karoonboonyanan)
241 Fri Jul 2 23:34:33 2004 Matthias Clasen <maclas@gmx.de>
243 * gtk/gtkcombobox.c (gtk_combo_box_unset_model): Unset the displayed
244 row when unsetting the model. (#138560, Christian Persch)
246 Fri Jul 2 23:01:07 2004 Matthias Clasen <maclas@gmx.de>
248 * gtk/gtkcombobox.c (update_menu_sensitivity): Don't crash if there
251 Fri Jul 2 22:41:27 2004 Matthias Clasen <maclas@gmx.de>
253 * gtk/gtkimage.c (gtk_image_expose): Properly align mask and
254 pixbuf if a subarea is exposed. (#135423, fix by John Ehresman)
256 Fri Jul 2 21:40:21 2004 Matthias Clasen <maclas@gmx.de>
258 * gtk/gtknotebook.c (gtk_notebook_realize): Add scroll events
259 to the event mask, set a scroll_event handler.
260 * gtk/gtknotebook.c (gtk_notebook_scroll): Handle scroll events
261 by switching tabs. (#145244, Gabriel de Perthuis)
263 2004-07-02 Anders Carlsson <andersca@gnome.org>
265 * gtk/gtktreeview.c (gtk_tree_view_set_model):
266 Make sure we check for a NULL model first.
268 2004-07-01 J. Ali Harlow <ali@juiblex.co.uk>
270 * gdk/win32/gdkinput-win32.c (_gdk_input_ungrab_pointer): Fix
271 win32 build problem w/o wintab. Fixed #145242
273 2004-06-30 Anders Carlsson <andersca@gnome.org>
275 * gtk/gtktreeview.c (gtk_tree_view_set_model): Use
276 g_return_if_fail to make sure that the model is a GtkTreeModel.
278 Sat Jun 26 17:41:10 2004 Soeren Sandmann <sandmann@daimi.au.dk>
280 * gtk/gtk[hv]separator.c (gtk_[hv]separator_expose): Draw line with the
281 current state, not GTK_STATE_NORMAL
283 * gtk/gtkframe.c (gtk_frame_paint): Fix a rounding error
285 Sat Jun 26 15:07:25 2004 Soeren Sandmann <sandmann@daimi.au.dk>
287 * gtk/gtkstyle.c, gtk/gtkrc.c: small color tweak. (#141173)
289 Sat Jun 26 01:15:40 2004 Matthias Clasen <maclas@gmx.de>
291 * gdk/x11/gdkwindow-x11.c (set_initial_hints): Handle
292 _NET_WM_STATE_ABOVE and _NET_WM_STATE_BELOW. (#144851,
295 Sat Jun 26 01:04:31 2004 Matthias Clasen <maclas@gmx.de>
297 * gtk/gtkiconfactory.c (clear_cache): Prevent unwanted
298 recursion by resetting icon_set->cache before freeing
299 the cache. (#144947, Tim Janik)
301 Sat Jun 26 00:40:02 2004 Matthias Clasen <maclas@gmx.de>
303 * gtk/gtkiconfactory.c (render_icon_name_pixbuf):
304 * gtk/gtkiconfactory.c (gtk_icon_set_render_icon):
305 * gtk/gtkstyle.c (gtk_default_render_icon): Accept a NULL
308 Sat Jun 26 00:04:36 2004 Matthias Clasen <maclas@gmx.de>
310 * gtk/gtkentrycompletion.c (gtk_entry_completion_set_model):
311 * gtk/gtkcombobox.c (gtk_combo_box_set_model): Reflect the
312 last change in the docs.
314 Fri Jun 25 23:35:42 2004 Matthias Clasen <maclas@gmx.de>
316 * gtk/gtkentrycompletion.c (gtk_entry_completion_set_model):
317 * gtk/gtkcombobox.c (gtk_combo_box_set_model): Allow passing
318 NULL to unset the model. (#137211, patch by Mariano Suárez-Alvarez)
320 Fri Jun 25 23:33:05 2004 Matthias Clasen <maclas@gmx.de>
322 * gtk/gtkcombobox.c (gtk_combo_box_menu_position_below): Fix the
323 placement policy for GtkComboBoxEntry to be: if it fits below,
324 place below, if it fits above place above, else place in the
325 larger space and scroll so that the scroll arrow appear at the
326 far end. (#144362, David A. Knight)
328 Fri Jun 25 22:49:58 2004 Matthias Clasen <maclas@gmx.de>
330 * gtk/gtktreestore.c (gtk_tree_store_move): Avoid uninitialized
331 use of &parent_iter. (#145007, John Finlay)
333 2004-06-25 Bastien Nocera <hadess@hadess.net>
335 reviewed by: Matthias Clasen <maclas@gmx.de>
337 * gdk/x11/gdkkeys-x11.c: (get_symbol), (update_keymaps),
338 (gdk_keymap_lookup_key), (translate_keysym): fix keys parsing when
339 the number of keysyms per keycode is odd. Fixes #144808.
341 2004-06-25 Matthias Clasen <mclasen@redhat.com>
343 * gtk/gtkfontbutton.c (gtk_font_button_update_font_info): Avoid
344 a crash if the font doesn't exist. (#144967, Yevgen Muntyan)
346 Fri Jun 25 00:32:15 2004 Matthias Clasen <maclas@gmx.de>
348 * gtk/gtktreestore.c (gtk_tree_store_swap): Commit the change
349 which was mentioned below.
351 Thu Jun 24 23:35:09 2004 Matthias Clasen <maclas@gmx.de>
353 * gtk/gtknotebook.c (gtk_notebook_class_init): Fix a typo,
354 string change. (#139503, Baris Cicek)
356 2004-06-22 Federico Mena Quintero <federico@ximian.com>
358 * gtk/gtkfilechooserdefault.c (location_popup_handler): Use a Save
359 or an Open stock button for the C-l dialog depending on the action
360 in which the file chooser operates. Fixes #141753.
362 2004-06-22 Federico Mena Quintero <federico@ximian.com>
364 Fixes the GTK+ part of #142308:
366 * gtk/gtkfilesystemunix.c (gtk_file_system_unix_filename_to_path):
367 Use filename_to_path().
368 (gtk_file_system_unix_uri_to_path): Likewise.
369 (filename_to_path): Use remove_trailing_slash().
371 2004-06-22 Matthias Clasen <mclasen@redhat.com>
373 * gtk/gtktextview.c (gtk_text_view_class_init): Improve docs
374 for the ::move_cursor signal.
376 * gtk/gtkaccelmap.c (_gtk_accel_path_is_valid): Accept
377 "<WINDOWTYPE>" as a valid accel path. (#144427, Philip
380 * gtk/gtkselection.c (GTK_SELECTION_MAX_SIZE): Make sure
381 this gets defined for all backends, so linux-fb has a
384 * gdk/x11/gdkgc-x11.c:
385 * gdk/gdkgc.c: Move function docs inline, add hints about
386 obtaining rgb colors from gcs. (#144688, Steve Chaplin)
388 * gtk/gtktreestore.c (gtk_tree_store_swap): Make this work
389 for children of the root. (#139785, Jean-François Wauthy,
390 patch by John Finlay)
392 * gtk/gtkicontheme.h (GTK_ICON_THEME_GET_CLASS): Typo
393 fix. (#144750, Jeff Franks)
395 2004-06-21 Michael Natterer <mitch@gimp.org>
398 * gdk/x11/gdkdrawable-x11.[ch]: made convert_format() utility
399 function public as _gdk_x11_convert_to_format().
401 * gdk/x11/gdkcursor-x11.c (create_cursor_image): premultiply
402 the pixels from the GdkPixbuf when putting them in the
403 Xcursor image. Fixes bug #144350.
405 2004-06-16 Federico Mena Quintero <federico@ximian.com>
407 * gtk/gtkfilesystemmodel.c (do_files_added): When inserting a
408 visible node, free the old path before creating the new one.
411 Tue Jun 15 01:10:32 2004 Matthias Clasen <maclas@gmx.de>
413 * gtk/gtkcombobox.c: Make GtkComboBox work without model.
414 (#144198, Mariano Suárez-Alvarez)
416 Fri Jun 11 22:05:56 2004 Matthias Clasen <maclas@gmx.de>
418 * gtk/gtkfilechooserdefault.c: Don't use
419 contractions like "don't" or "isn't" in error messages.
420 It isn't nice to use them in log entries either...
421 (#137774, Morten Welinder, patch by Alexander Winston)
423 2004-06-11 Federico Mena Quintero <federico@ximian.com>
427 * gtk/gtkfilesystemmodel.c (_gtk_file_system_model_add_editable):
428 Don't ref the editable node.
429 (_gtk_file_system_model_remove_editable): Don't unref the editable node.
430 (_gtk_file_system_model_remove_editable): Ahem, free the node.
432 * gtk/gtkfilechooserdefault.c (struct _GtkFileChooserDefault):
433 Added fields for edited_idle and edited_new_text.
434 (renderer_edited_cb): Queue the
435 creation of the folder in an idle handler.
436 (renderer_editing_canceled_cb): Likewise for the cancellation.
437 (gtk_file_chooser_default_finalize): Free the impl->edited_new_text.
439 Thu Jun 10 22:12:26 2004 Matthias Clasen <maclas@gmx.de>
441 * gtk/gtkmain.c (gtk_parse_args): Typo fix.
443 2004-06-10 Federico Mena Quintero <federico@ximian.com>
445 Fixes #144110, patch by Bastien Nocera <hadess@hadess.net>.
447 * gtk/gtkfilechooser.c (gtk_file_chooser_list_shortcut_folders):
448 Refer to gtk_file_chooser_add_shortcut_folder().
449 (gtk_file_chooser_list_shortcut_folder_uris): Refer to
450 gtk_file_chooser_add_shortcut_folder_uri().
452 Thu Jun 10 00:36:15 2004 Matthias Clasen <maclas@gmx.de>
454 * gtk/gtkcalendar.c (gtk_calendar_main_button): Start
455 the drag before focusing the selected.day.
456 * gtk/gtkcalendar.c (gtk_calendar_state_changed): Stop
457 a beginning drag if the widget becomes insensitive.
459 Thu Jun 10 00:09:06 2004 Matthias Clasen <maclas@gmx.de>
461 * gtk/gtkcalendar.c (gtk_calendar_button_press): Start
462 spinning before calling arrow_action(), so that a signal
463 handler triggered from arrow_action() has a chance to
464 stop the spinning. (#143966, Davyd Madeley)
466 Wed Jun 9 23:11:23 2004 Matthias Clasen <maclas@gmx.de>
468 * gtk/gtkstyle.c (_gtk_style_init_for_settings): Fix a
469 typo. (#144070, Kent Sandvik)
471 Thu Jun 10 00:22:51 2004 Soeren Sandmann <sandmann@daimi.au.dk>
473 * gtk/gtkmenu.c: Revert the "drag select" part of
476 Mon Jun 7 23:07:40 2004 Matthias Clasen <maclas@gmx.de>
478 * gtk/gtkcombobox.c (gtk_combo_box_remeasure): Handle
479 priv->model being NULL. (#143856, Mariano Suárez-Alvarez)
481 2004-06-07 Federico Mena Quintero <federico@ximian.com>
483 * gtk/gtktreeview.c (gtk_tree_view_button_press): Revert the patch
484 from 2003/Sep/12. This kept DnD in tree views within modal
485 dialogs from working, which is especially bad for the file
486 chooser. Fixes #135168.
488 Sun Jun 6 23:57:21 2004 Matthias Clasen <maclas@gmx.de>
490 Make the entry context menu work in editable text cells. The changes
491 are based on a patch by Kristian Rietveld, which implemented an
492 approach outlined by Owen Taylor. (#50075)
494 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_focus_out_event):
495 Ignore focus out if the entry menu is posted.
496 (gtk_cell_renderer_text_populate_popup): Mark the entry menu as
497 posted, and set up a signal handler to clear the flag if the menu
499 (gtk_cell_renderer_text_popup_unmap): Clear the in_entry_menu flag,
500 set up a timeout to stop editing if the focus is lost.
501 (popdown_timeout): Stop editing if the entry doesn't have focus anymore.
502 (gtk_cell_renderer_text_start_editing): Connect to the populate_popup
503 signal on the entry and keep a pointer to the entry.
504 (gtk_cell_renderer_text_editing_done): Disconnect from popuplate_popup,
505 clear the pointer to the entry.
507 Sun Jun 6 23:24:43 2004 Matthias Clasen <maclas@gmx.de>
509 * gtk/gtktexttag.c (gtk_text_tag_class_init): Improve the description
510 of the ::language property. (#143802, Owen Taylor)
512 Sat Jun 5 23:07:30 2004 Matthias Clasen <maclas@gmx.de>
514 * gtk/gtkentrycompletion.c: (gtk_entry_completion_init),
515 (gtk_entry_completion_list_enter_notify),
516 (gtk_entry_completion_list_motion_notify),
517 (_gtk_entry_completion_popup), (_gtk_entry_completion_popdown):
518 * gtk/gtkentryprivate.h: Add an ignore_enter flag and
519 use it as in the menu code to avoid the initial selection if
520 the window pops up under the pointer. (Anders Carlsson)
522 Sat Jun 5 20:05:39 2004 Soeren Sandmann <sandmann@daimi.au.dk>
524 * tests/testmerge.c: Add a checkbox to queue an
525 merge/unmerge. Patch from Matthias Clasen.
527 * gtk/gtktoolbar.c (struct _GtkToolbarPrivate): Add a new flag
529 (rebuild_menu): New function that rebuilds the overflow menu and
530 makes sure it doesn't start or end with a separator.
531 (toolbar_content_new_tool_item)
532 (toolbar_content_remove)
533 (toolbar_content_new_compatibility): Set the rebuild_needed flag
534 (gtk_toolbar_size_allocate): Only show the overflow arrow when we
535 have actually overflown an item with a proxy menu item. Also make
536 sure we rebuild the menu if needed.
538 Fix #125504, #142377, #143463
540 * gtk/gtkseparatortoolitem.c (gtk_separator_tool_item_expose):
541 Obey the "priv->draw" flag. (#143692)
543 2004-06-04 Matthias Clasen <mclasen@redhat.com>
545 * docs/widget_geometry.txt: Add a note about the !CAN_FOCUS
546 quirk in the button size allocation code.
548 * gtk/gtkbutton.c (gtk_button_size_allocate): Give the space
549 requested for drawing the focus indicator to the child in the
550 !CAN_FOCUS case. This should fix issues which the Gimp has with
551 the button allocation changes in 2.4.2.
553 Thu Jun 3 21:17:29 2004 Matthias Clasen <maclas@gmx.de>
555 * gtk/gtkentry.c (gtk_entry_completion_timeout): Calculate the
556 length of the entry contents in characters, not in bytes.
558 * gtk/gtkentry.c (paste_received): Don't pop up the completion
559 window on paste, noticed by Anders Carlsson.
561 Thu Jun 3 20:56:19 2004 Matthias Clasen <maclas@gmx.de>
563 * gtk/gtkcombobox.c (gtk_combo_box_class_init): Fix the allowed
564 values and default value for the ::active property. (#143669,
567 2004-06-03 Michael Natterer <mitch@gimp.org>
569 * gtk/gtkimagemenuitem.c: use gtk_widget_get_child_requisition()
570 instead of accessing item->image->allocation.width/height
571 directly. Makes widgets which only have a requisition set using
572 gtk_widget_set_size_request() work and fixes bug #142789.
574 Thu Jun 3 08:07:59 2004 Soeren Sandmann <sandmann@daimi.au.dk>
576 * gtk/gtkmenu.c: Revert previous commit. It caused the problem
577 of sticky right click menus to return.
579 Wed Jun 2 01:56:02 2004 Soeren Sandmann <sandmann@daimi.au.dk>
581 * gtk/gtkmenu.c: Fix the stay up algorithm for combo boxes to
582 better handle the "click" case. bug Better fix for #141169.
584 2004-06-02 Federico Mena Quintero <federico@ximian.com>
586 * gtk/gtktreeview.c (gtk_tree_view_search_init): Bail out if the
587 model is empty. Fixes #143536.
589 2004-06-02 Matthias Clasen <mclasen@redhat.com>
591 * gtk/gtkfontsel.c (gtk_font_selection_size_focus_out): Don't
592 close the dialog on focus out of the size entry. (#143505,
595 2004-06-02 Federico Mena Quintero <federico@ximian.com>
599 * gtk/fnmatch.c (_gtk_fnmatch): Take a no_leading_period argument.
600 (gtk_fnmatch_intern): Likewise; also implement this option.
602 * gtk/gtkprivate.h (_gtk_fnmatch): Updated prototype.
604 * gtk/gtkfilesel.c (find_completion_dir): Pass TRUE for the
605 no_leading_period argument of _gtk_fnmatch().
606 (attempt_file_completion): Likewise.
608 * gtk/gtkfilefilter.c (gtk_file_filter_filter): Pass FALSE for the
609 no_leading_period argument of _gtk_fnmatch().
611 Wed Jun 2 00:47:11 2004 Matthias Clasen <maclas@gmx.de>
613 * gtk/gtkselection.c (_gtk_selection_request): Remove leftover
616 Wed Jun 2 00:13:57 2004 Matthias Clasen <maclas@gmx.de>
618 * gtk/gtktreeselection.c (gtk_tree_selection_select_range): Don't
619 allow unless selection mode is multiple. (#142634, John Finlay)
621 Tue Jun 1 23:00:20 2004 Matthias Clasen <maclas@gmx.de>
625 * gtk/gtkentrycompletion.h:
626 * gtk/gtkentrycompletion.c:
628 * gtk/gtkcombobox.c: Rename function parameters from
629 index to index_ to prevent clash with BSD index(). (#143001)
631 Tue Jun 1 22:45:42 2004 Matthias Clasen <maclas@gmx.de>
633 * gtk/gtkmenu.c (get_accel_path): Handle accel_closure being
634 NULL on an accel label. (#139641, Sam Stephenson, patch by
637 Tue Jun 1 22:19:55 2004 Matthias Clasen <maclas@gmx.de>
639 * gtk/gtkicontheme.c (theme_subdir_load): Prevent icon
640 lookup finding icons in the wrong prefix. (#143328,
643 Wed Jun 2 00:39:58 2004 Soeren Sandmann <sandmann@daimi.au.dk>
647 * gtk/gtkmenushell.c (gtk_menu_shell_button_release): Make menus
648 only stay up if you release within 500 milliseconds.
649 (gtk_menu_shell_button_press): Set the activate_time to the event
650 time when a button is pressed.
652 * gtk/gtkmenu.c (gtk_menu_motion_notify, gtk_menu_enter_notify):
653 Interprete button releases as activate when we have seen both an
654 enter an a motion event.
656 2004-06-01 Federico Mena Quintero <federico@ximian.com>
658 * gtk/gtkfilesystemmodel.c (do_files_removed): Don't insert a
659 dummy node if there is no parent node. Fixes #143362.
661 2004-05-31 Federico Mena Quintero <federico@ximian.com>
663 * gtk/gtkfilechooserdefault.c (renderer_edited_cb): Change to the
664 newly-created folder. Fixes #138932.
665 (trap_activate_cb): Only return TRUE if we did handle the event.
666 Fixes #143359; patch by jylefort@brutele.be.
668 Mon May 31 02:39:32 2004 Matthias Clasen <maclas@gmx.de>
670 * gtk/gtkimage.c (gtk_image_new_from_pixmap): Fix typo in
671 docs. (#142892, Tommi Komulainen)
673 Mon May 31 02:16:37 2004 Matthias Clasen <maclas@gmx.de>
675 * gtk/gtkhandlebox.c: Make detached handleboxes work when their
676 parent is minimized, porting the fix from 1.2. (#1923, #57182)
678 Mon May 31 02:03:17 2004 Matthias Clasen <maclas@gmx.de>
680 * gtk/gtkwindow.c (gtk_window_show): Make moving realized,
681 unmapped windows work.
683 Mon May 31 00:27:33 2004 Matthias Clasen <maclas@gmx.de>
685 * gtk/gtkfilechooserutils.c (_gtk_file_chooser_set_delegate): Fix
688 Mon May 31 00:23:55 2004 Matthias Clasen <maclas@gmx.de>
690 * gtk/gtkfilechooser.c (gtk_file_chooser_set_preview_widget):
691 Refer to ::update-preview, not ::selection-changed.
693 2004-05-29 Christian Rose <menthos@menthos.com>
695 * configure.in: Added "tk" to ALL_LINGUAS.
697 Fri May 28 15:00:01 2004 Matthias Clasen <maclas@gmx.de>
699 * gtk/gtkwidget.c (gtk_widget_set_parent): Add informative
700 messages for common problems. (#137974, Owen Taylor)
702 Fri May 28 14:20:17 2004 Matthias Clasen <maclas@gmx.de>
704 * gdk/x11/gdkevents-x11.c: Fix off-by-one allocation
705 errors. (#143337, Billy Biggs)
707 Thu May 27 16:36:22 2004 Owen Taylor <otaylor@redhat.com>
709 * gdk/x11/gdkcolor-x11.c (gdk_colormap_alloc_colors): Set
710 bits within visual->depth that aren't used for color to
711 1s, in case they are alpha.
713 2004-05-27 Anders Carlsson <andersca@gnome.org>
715 * gtk/gtkfilechooserdefault.c (save_folder_combo_create):
716 Make separator rows insensitive.
718 Thu May 27 00:48:16 2004 Matthias Clasen <maclas@gmx.de>
720 * gtk/gtkentrycompletion.c (gtk_entry_completion_set_text_column):
723 Thu May 27 00:45:07 2004 Matthias Clasen <maclas@gmx.de>
725 * gtk/gtkentrycompletion.h:
726 * gtk/gtkentrycompletion.c (gtk_entry_completion_get_text_column):
727 Getter for text_column. Also make ::text_column a property.
729 Thu May 27 00:11:01 2004 Matthias Clasen <maclas@gmx.de>
731 * gtk/gtkmenuitem.c (gtk_menu_item_size_request): Fix a typo.
733 Thu May 27 00:07:47 2004 Jonathan Blandford <jrb@gnome.org>
735 * gtk/gtkcombobox.c (gtk_combo_box_list_destroy): only remove the
736 signal if the box exists.
738 Wed May 26 23:26:51 2004 Matthias Clasen <maclas@gmx.de>
740 Support insensitive cells in tree views and combo boxes:
742 * gtk/gtkcellrenderer.h:
743 * gtk/gtkcellrenderer.c: Add a ::sensitive property.
745 * gtk/gtkcellrendererpixbuf.c (gtk_cell_renderer_pixbuf_render):
746 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_render):
747 * gtk/gtkcellrenderertoggle.c (gtk_cell_renderer_toggle_render):
748 Support drawing insensitive.
751 * gtk/gtkcellview.c (gtk_cell_view_get_cell_renderers): New
752 function to obtain the cell renderers from a cell view. Also
753 export gtk_cell_view_set_cell_data().
755 * gtk/gtktreeselection.c (tree_column_is_sensitive):
756 * gtk/gtktreeselection.c (row_is_selectable): Helper functions
757 to determine whether all visible cells in a row are insensitive
758 and whether a row is selectable. A row is not selectable if the
759 user function says so or if all visible cells are insensitive.
760 * gtk/gtktreeselection.c (_gtk_tree_selection_internal_select_node):
761 * gtk/gtktreeselection.c (gtk_tree_selection_real_select_node):
762 Use row_is_selectable().
764 * gtk/gtkcombobox.c (row_is_sensitive):
765 * gtk/gtkcombobox.c (tree_column_row_is_sensitive):
766 * gtk/gtkcombobox.c (menu_row_is_sensitive): Helper functions
767 to determine row sensitivity in menu or list mode.
769 * gtk/gtkcombobox.c (update_menu_sensitivity): Helper function
770 to set up sensitivity menu items from the underlying rows.
772 * gtk/gtkcombobox.c (gtk_combo_box_popup):
773 * gtk/gtkcombobox.c (gtk_combo_box_menu_button_press): Use
774 update_menu_sensitivity().
776 * gtk/gtkcombobox.c (gtk_combo_box_list_setup): Setup the cell
779 * gtk/gtkcombobox.c (gtk_combo_box_key_press): Skip insensitive
782 * tests/testcombo.c (main): Make some rows insensitive.
784 2004-05-26 Robert Ögren <gtk@roboros.com>
786 * gdk/win32/gdkinput-win32.c (_gdk_input_other_event): Send key
787 modifiers (shift, ctrl etc) in button and motion events from the
790 2004-05-26 Robert Ögren <gtk@roboros.com>
792 * gdk/win32/gdkinput-win32.c (gdk_device_get_state): Simple
793 implementation for extended input devices using last known
794 device state (#143237)
796 Tue May 25 21:54:00 2004 Matthias Clasen <maclas@gmx.de>
798 * gtk/gtkframe.c: Move docs inline, fixing them on the
799 way. (#143029, Steve Chaplin)
801 2004-05-11 Robert Ögren <gtk@roboros.com>
803 * gdk/win32/gdkevents-win32.c (propagate): Don't propagate mouse
804 events to windows that want extended input events. (#142943)
805 (gdk_event_translate): Move check for extended input devices to
806 propagate, new parameter to propagate.
807 (gdk_pointer_grab, gdk_display_pointer_ungrab): Enable calls to
808 _gdk_input_(un)grab_pointer. (#142943)
810 * gdk/win32/gdkinput-win32.c (_gdk_input_other_event): Check for
811 input grab. [Fix missing update of impl in "dijkstra" event
812 propagation loop] Drop the parallel "impl" pointer, just use a
813 cast. Don't propagate beyond windows that want normal input
815 (gdk_input_grab_pointer, gdk_input_ungrab_pointer): Limited
816 implementation of input grab. (#142943)
818 2004-05-22 Tor Lillqvist <tml@iki.fi>
820 * gdk/win32/gdkinput-win32.c (print_lc): Remove duplicated
821 line. (Spotted by Benoît Carpentier.)
823 2004-05-18 Matthias Clasen <mclasen@redhat.com>
825 * configure.in: Check for XFIXES extension.
827 * gdk/x11/gdkdisplay-x11.h (struct _GdkDisplayX11): Add
828 a gboolean have_xfixes member.
830 * gdk/x11/gdkdisplay-x11.c (gdk_display_open): Register
831 XFIXES events and set have_xfixes.
833 * gdk/gdkevents.h (GdkEventType): Add GDK_OWNER_CHANGE.
834 (GdkEventOwnerChange): New event struct for owner change events.
835 (GdkOwnerChange): New enum for the reason field of GdkEventOwnerChange.
837 * gdk/x11/gdkevents-x11.c (gdk_event_translate): Translate
838 XFixesSelectionNotify events into GdkEventOwnerChange events.
841 * gdk/x11/gdkdisplay-x11.c (gdk_display_supports_selection_notification):
842 (gdk_display_request_selection_notification): New api
843 to support selection ownership notification.
845 * gtk/gtkclipboard.h:
846 * gtk/gtkclipboard.c (_gtk_clipboard_handle_event): New private
847 api to handle owner change events.
848 (clipboard_peek): Refactored out the body of
849 gtk_clipboard_get_for_display() for use in _gtk_clipboard_handle_event().
851 * gtk/gtkmain.c (gtk_main_do_event): Handle GDK_OWNER_CHANGE events
852 by calling _gtk_clipboard_handle_event().
854 2004-05-18 Matthias Clasen <mclasen@redhat.com>
856 * gtk/gtkintl.h: Include glib/gi18n-lib.h and only define
857 the P_() macros ourselves.
859 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
860 Restrict the width of the popup to be no larger than the
861 monitor. (#142678, DmD Ljungmark)
863 * gtk/gtkbutton.c: Go back to the initial fix for the
864 focus-overdrawing problem, which was actually correct
865 according to docs/widget_geometry.txt.
867 * gtk/gtkarrow.c (gtk_arrow_class_init): Bump the initial
868 arrow size from 11 to 15 to compensate for that.
870 * gtk/gtktextview.c (gtk_text_view_class_init): Document the
871 arguments of the ::move-cursor signal. (#142725)
873 2004-05-17 Matthias Clasen <mclasen@redhat.com>
877 * gtk/gtkbutton.c (gtk_button_size_request)
878 (gtk_button_size_allocate, _gtk_button_paint): Allocate
879 space for the focus rectangle only if necessary. (#142668,
882 Sun May 16 23:11:47 2004 Matthias Clasen <maclas@gmx.de>
886 * gtk/gtkhruler.c (gtk_hruler_draw_ticks): Remove two useless
887 lines. (#142479, Morten Welinder)
889 Sun May 16 22:27:17 2004 Matthias Clasen <maclas@gmx.de>
891 * gtk/gtkintl.h (Q_): Add a Q_() macro.
893 * gtk/gtkcellrendererprogress.h: Remove GTK_PROGRESS_CELL_UNKNOWN
894 and GTK_PROGRESS_CELL_FAILED. With the ability the set the label,
895 they are not really needed.
897 * gtk/gtkcellrendererprogress.c: Use the xpad and ypad properties
898 instead of hardwired padding, use Q_() for the default label,
899 compute a reasonable minimal size. (#142571, #142572, #142573,
900 Tommi Komulainen, Christian Persch)
902 2004-05-15 Tor Lillqvist <tml@iki.fi>
904 * gdk/win32/gdkdnd-win32.c: Put back the ref_count field in the
905 GdkDragContextPrivateWin32 struct (but inside ifdef OLE2_DND this
906 time). It is used by the OLE2_DND code, which is unfinished and
907 presumably horribly broken, but still, let's not make it not
908 compile on purpose. Silence some gcc warnings in the OLE2_DND
911 2004-05-14 Matthias Clasen <mclasen@redhat.com>
913 * gtk/gtktreeview.c (gtk_tree_view_tree_window_to_tree_coords):
914 New function to go from tree window to tree coordinates, kept
915 static for now until we figure out the multiple coordinate
916 system mess in GtkTreeView API-wise.
917 (gtk_tree_view_scroll_to_cell): Transform the coordinates
918 from tree window to tree coordinates, using the new function.
919 Previously, the x coordinate was wrongly transformed. (#142494)
921 * gdk/gdktypes.h (GdkModifierType): Add a comment about unused
924 * gtk/gtkstock.c (real_add, gtk_stock_lookup): Use an unused
925 modifier bit to mark stock item which need to be freed
926 eventually. (#140654, Michal Pasternak, Scott Tsai)
928 2004-05-11 Robert Ögren <gtk@roboros.com>
930 * gdk/win32/gdkevents-win32.c (gdk_event_translate): Add missing
931 call to g_object_ref in Wintab code. (#138341)
933 * gdk/win32/gdkinput-win32.c: Fix numerous Wintab problems
934 including unallocated buffers for event->motion.axes and
935 event->button.axes, unsigned wraparound problem in the code for
936 detecting missing press/release events and assigning min instead
937 of max when setting up axes.
939 2004-05-12 Matthias Clasen <mclasen@redhat.com>
941 * tests/testtreeedit.c: Add a progress column.
943 * gtk/Makefile.am: Add gtkcellrendererprogress.[hc] in the right
946 * gtk/gtk.h: Include gtkcellrendererprogress.h.
948 * gtk/gtkcellrendererprogress.[hc]: A progress cell renderer,
949 based on the one found in Epiphany.
951 2004-05-11 Michael Natterer <mitch@gimp.org>
953 * gtk/gtkcombobox.c (gtk_combo_box_popup)
954 (gtk_combo_box_menu_button_press): don't allocate the popup
955 smaller than the combobox. Fixes bug #59660.
957 2004-05-11 Matthias Clasen <mclasen@redhat.com>
959 * gtk/gtkuimanager.c (gtk_ui_manager_get_widget): Revert the
960 previous change to this function, clarify the docs instead.
962 * gtk/gtkcombobox.c (gtk_combo_box_list_setup): Use
963 GTK_SELECTION_BROWSE.
965 * gtk/gtktreeview.c: Make hover selection work for
966 GTK_SELECTION_BROWSE as well.
968 Tue May 11 00:38:25 2004 Matthias Clasen <maclas@gmx.de>
970 * gtk/gtkcellrenderertoggle.c (gtk_cell_renderer_toggle_class_init):
971 Document the ::toggled signal.
973 Mon May 10 23:04:25 2004 Soeren Sandmann <sandmann@daimi.au.dk>
975 * gtk/gtkwidget.h: Add prototype for _gtk_widget_grab_notify()
977 2004-05-10 Matthias Clasen <mclasen@redhat.com>
979 * gtk/gtkwindow.c (get_screen_icon_info): Make static.
981 * gdk/gdkdisplay.c (singlehead_...):
982 * gdk/x11/gdkkeys-x11.c (get_effective_keymap):
983 * gdk/x11/gdkgeometry-x11.c (expose_serial_predicate):
984 * gdk/x11/gdkdisplay-x11.c (escape_for_xmessage): Make static.
986 * gtk/gtktreeview.c (gtk_tree_view_set_fixed_height_mode): Add a
987 note about COLUMN_FIXED restriction.
989 * gtk/gtkentrycompletion.c (gtk_entry_completion_list_button_press):
990 Set the entry in the default handler of the ::match-selected signal.
993 * gtk/gtkcombobox.c (gtk_combo_box_menu_position_below): If we don't
994 do the move-selected-item below pointer thingie, do the
995 place-below-or-above one.
997 * tests/testentrycompletion.c: Make the second example use the
998 ::match-selected signal to make it actually work.
1000 * gtk/gtkentrycompletion.c (gtk_entry_completion_init):
1001 * gtk/gtkcombobox.c (gtk_combo_box_list_setup): Use hover selection
1002 mode. (#127648, Dave Bordoley)
1004 * gtk/gtktreeview.h:
1005 * gtk/gtktreeview.c: Add a new property "hover_selection", which
1006 when TRUE makes the selection follow the mouse. Also add setter
1007 and getter for the fixed_height property.
1009 2004-05-10 Matthias Clasen <mclasen@redhat.com>
1011 * gtk/gtkcombobox.c (gtk_combo_box_popup)
1012 (gtk_combo_box_menu_button_press): Make sure the menu pops up
1013 as wide as the combobox. (#59660, Havoc Pennington)
1015 2004-05-10 Matthias Clasen <mclasen@redhat.com>
1017 * gtk/gtkcombobox.h:
1018 * gtk/gtkcombobox.c: Support tearoffable combo boxes (in menu
1019 mode). Add a new property, add-tearoffs, for this. (#135956)
1021 * gtk/gtkfontsel.c (list_row_activated): Make Return activate the
1022 default button. (#118921)
1024 Mon May 10 15:03:50 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1026 * gtk/gtkwidget.c (_gtk_widget_grab_notify): New internal function
1027 that emits the grab notify signal.
1029 * gtk/gtkmain.c (gtk_grab_notify_foreach): Use it here.
1031 Mon May 10 00:48:08 2004 Matthias Clasen <maclas@gmx.de>
1033 * gtk/gtkmenu.c: Make destruction of a torn off menu work
1034 like un-tearing off.
1036 Sun May 9 21:05:38 2004 Matthias Clasen <maclas@gmx.de>
1040 * gtk/gtkactiongroup.c (gtk_action_group_add_action_with_accel):
1041 Allow to suppress the stock accelerator by using "". (#142196,
1044 Sun May 9 02:01:13 2004 Matthias Clasen <maclas@gmx.de>
1048 * gtk/gtkcombobox.c (gtk_combo_box_list_button_released):
1049 In list mode, accept the same mouse/wheel bindings on
1050 the cellview as on the button. (#136967)
1052 Sun May 9 01:25:37 2004 Matthias Clasen <maclas@gmx.de>
1054 * gtk/gtkiconfactory.c (add_to_cache): Actually count the
1055 cached icons. (#135888, Crispin Flowerday)
1057 Sun May 9 00:03:03 2004 Matthias Clasen <maclas@gmx.de>
1059 * gtk/gtkuimanager.c (gtk_ui_manager_get_widget): Make sure
1060 that we actually return menus for nodes of type menu, not the
1061 menuitems they're attached to.
1063 Sat May 8 22:50:55 2004 Matthias Clasen <maclas@gmx.de>
1065 * gtk/gtkactiongroup.c (gtk_action_group_set_translation_domain):
1066 Add a note regarding UTF-8 requirements, proposed by
1067 Mariano Suárez-Alvarez.
1069 Sat May 8 22:43:11 2004 Matthias Clasen <maclas@gmx.de>
1071 * gtk/gtktearoffmenuitem.h:
1072 * gtk/gtktearoffmenuitem.c: Put the torn_off flag back
1073 into the GtkTearoffMenuItem struct, since it is used
1074 by the Gimp, and keep it synchronized with the
1075 tearoff_state property of the parent menu.
1077 2004-05-08 Hans Breuer <hans@breuer.org>
1079 * gtk/gtkfilesystemwin32.c (extract_icon) : finally also
1080 create the correct mask for 'pseudo mime' icons
1082 * gdk/win32/gdkwindow-win32.c(show_window_internal) : also
1083 take focus_on_map into account
1085 * gtk/gtkselection.c : g_message() only with DEBUG_SELECTION
1087 * gtk/gtkactiongroup.c gtk/gtkcombobox.c :
1088 ... must return a value
1090 * gdk/gdk.def gtk/gtk.def demos/gtk-demo/makefile.msc.in : updated
1092 2004-05-07 Matthias Clasen <mclasen@redhat.com>
1094 * gtk/gtkbutton.c (gtk_button_size_allocate): Don't let the child
1095 draw over the focus rectangle.
1097 * gtk/gtkhsv.c: Draw focus indication in the color wheel using
1098 standard focus style. (#63071, Bill Haneman, idea for new
1099 style by Owen Taylor)
1101 * gtk/gtkstyle.c (gtk_default_draw_focus): Support drawing on
1102 focus on the colorwheel via details.
1104 2004-05-06 Matthias Clasen <mclasen@redhat.com>
1108 * gtk/gtkcombobox.c (gtk_combo_box_menu_state_changed): Remove
1109 this no longer needed signal handler. (#141817, Paul Pogonyshev)
1111 Fri May 7 00:41:46 2004 Matthias Clasen <maclas@gmx.de>
1113 * gtk/gtktearoffmenuitem.h:
1114 * gtk/gtktearoffmenuitem.c: Make the tearoff
1115 functionality model/view, the tearoffmenuitem being
1116 the view and the tearoff_state property of the menu
1117 being the model. (#101185, Owen Taylor)
1119 * gtk/gtkmenu.c: Add a tearoff_state property.
1121 Thu May 6 23:52:13 2004 Matthias Clasen <maclas@gmx.de>
1125 * gtk/gtkmenuitem.c (gtk_menu_item_select_timeout): Also
1126 popup the submenu for items in torn off menus. (#122051)
1128 2004-05-06 Sven Neumann <sven@gimp.org>
1130 * gtk/gtkexpander.c (gtk_expander_size_allocate): in RTL mode,
1131 position the title lable next to the arrow just as we do for LTR
1132 rendering. Fixes bug #141825.
1134 2004-05-06 Matthias Clasen <mclasen@redhat.com>
1136 * docs/RELEASE-HOWTO: Document the new policy of
1137 bumping version numbers after release.
1139 * configure.in: Bump version number to 2.5.0.
1141 2004-05-06 Padraig O'Briain <padraig.obriain@sun.com>
1144 * gtk/gtkmenu.c: Add new function gtk_menu_get_for_attach_widget.
1147 Thu May 6 00:24:11 2004 Matthias Clasen <maclas@gmx.de>
1149 * gtk/gtkactiongroup.h:
1150 * gtk/gtkactiongroup.c (gtk_action_group_translate_string):
1151 New function to translate a string with translate_func.
1154 Thu May 6 00:02:21 2004 Matthias Clasen <maclas@gmx.de>
1156 * gtk/gtkcombobox.c (gtk_combo_box_get_wrap_width):
1157 (gtk_combo_box_get_row_span_column):
1158 (gtk_combo_box_get_column_span_column): Add missing getters
1159 for readwrite properies. (#135649)
1161 Wed May 5 23:42:42 2004 Matthias Clasen <maclas@gmx.de>
1163 * gtk/gtkcombobox.h:
1164 * gtk/gtkcombobox.c (gtk_combo_box_get_active_text):
1165 Add gtk_combo_box_get_active_text() convenience
1166 function. (#136372, Christian Neumeir, patch by Olivier Andrieu)
1168 2004-05-05 Elijah Newren <newren@math.utah.edu>
1170 Changes to support do-not-focus-on-map hint in conjunction with
1171 _NET_WM_USER_TIME (#115650):
1173 * gdk/gdkwindow.h (struct _GdkWindowObject): Add a new boolean
1176 * gdk/gdkwindow.h (gdk_window_set_accept_focus): New function to
1179 * gtk/gtkwindow.[hc]: Add a boolean property "focus_on_map"
1180 and gtk_window_get_focus_on_map() and gtk_window_set_focus_on_map().
1182 * gdk/win32/gdkwindow-win32.c (gdk_window_new):
1183 * gdk/linux-fb/gdkwindow-fb.c (gdk_window_new):
1184 * gdk/x11/gdkwindow-x11.c (gdk_window_new):
1185 Initialize the focus_on_map field to TRUE.
1187 * gdk/win32/gdkwindow-win32.c (gdk_window_set_focus_on_map):
1188 * gdk/linux-fb/gdkwindow-fb.c (gdk_window_set_focus_on_map):
1189 * gdk/x11/gdkwindow-x11.c (gdk_window_set_focus_on_map):
1190 * gdk/x11/gdkwindow-x11.c (setup_toplevel_window):
1191 Implementations for the various backends. The Win32 and linux-fb
1192 implementations set the focus_on_map field, but don't use it yet
1193 to actually implement noinput windows. The X implementation sets
1194 _NET_WM_USER_TIME to 0 if focus_on_map is FALSE (see the EWMH).
1196 * gdk/x11/gdkwindow-x11.h:
1197 * gdk/x11/gdkevents-x11.c (set_user_time):
1198 * gdk/x11/gdkinput-x11.c (_gdk_input_common_other_event):
1199 * gdk/x11/gdkwindow-x11.c (gdk_x11_window_set_user_time):
1200 s/_gdk_x11_window_set_user_time/gdk_x11_window_set_user_time/,
1201 since we want that function to be part of the public API.
1203 Wed May 5 22:20:21 2004 Matthias Clasen <maclas@gmx.de>
1207 * gtk/gtkiconfactory.c (icon_source_clear): Don't
1208 call g_free() on a pixbuf. (#141961, Crispin Flowerday)
1210 2004-05-05 Matthias Clasen <mclasen@redhat.com>
1214 * gtk/gtkuimanager.c (print_node): Make the output
1215 parseable. (#141929, Sven Neumann)
1217 2004-05-05 Tor Lillqvist <tml@iki.fi>
1219 * gdk/win32/gdkdnd-win32.c (gdk_drag_find_window_for_screen): Add
1220 multi-monitor offset. (#141842, John Ehresman)
1222 2004-05-04 Federico Mena Quintero <federico@ximian.com>
1224 Fixes #139562, based on a patch by Christian Neumair.
1226 * gtk/gtkfilechooserdefault.c (struct _GtkFileChooserDefault): Add
1227 a filter_combo_hbox field to contain the filter combo.
1228 (show_filters): Show/hide the filter_combo_hbox.
1229 (create_filename_entry_and_filter_combo): Removed.
1230 (file_pane_create): Create the filter_combo_hbox here.
1232 2004-05-04 Matthias Clasen <mclasen@redhat.com>
1234 * modules/input/gtkimcontextxim.c: Fix the recent
1235 string_conversion_callback change to work on
1236 Solaris. (#141190, Padraig O'Briain)
1238 * gtk/gtkselection.c: Disable debug logging again.
1240 2004-05-03 Matthias Clasen <mclasen@redhat.com>
1242 * gtk/gtkselection.c: Make the chunk size for
1243 incremental transfers depend on the maximal request
1244 size, capped at 256k. This should allow most selections
1245 to be transferred nonincrementally, avoiding many
1246 roundtrips and protocol overhead.
1248 2004-05-03 Federico Mena Quintero <federico@ximian.com>
1250 * gtk/gtkuimanager.c (gtk_ui_manager_class_init): Call
1251 g_signal_new() correctly and initialize the signal fields. Fixes
1252 #141749; patch based on Michael Natterer's.
1254 u2004-05-03 Matthias Clasen <mclasen@redhat.com>
1256 * gtk/gtkselection.c (_gtk_selection_request): Fix
1257 a debug message to show correct information.
1258 (_gtk_selection_incr_event): Make INCRemental transfer
1259 of MULTIPLE targets work. This was broken since 1997!
1261 2004-05-02 Hans Breuer <hans@breuer.org>
1263 * gdk/win32/gdkdrawable-win32.c (draw_segments) : don't
1264 modify the passed in GdkSegment(s) in place, we may get
1265 them again to draw at the same place. Fixes bug #129095,
1267 (draw_segments) draw the end pixel again to get the
1268 pixmap mask right, fixes bug #126710, #130202
1270 * gdk/win32/gdkwindow-win32.c : use SetForegroundWindow,
1271 fixes bug #106013, John Ehresman
1273 * gtk/makefile.msc.in : don't try to link gtk.res but
1274 use gtk-win32.res (as supposed to be fixed below :)
1276 2004-05-01 Hans Breuer <hans@breuer.org>
1278 * tests/Makefile.am : tests/makefile.msc is in CVS for
1279 a long time, finally added to EXTRA_DIST : fixes bug
1280 #141334, John Ehresman
1282 2004-04-30 Matthias Clasen <mclasen@redhat.com>
1284 * === Released 2.4.1 ===
1286 * configure.in: Version 2.4.1, interface age 1.
1290 2004-04-29 Federico Mena Quintero <federico@ximian.com>
1294 * gtk/gtkfilechooserdefault.c (remove_selected_bookmarks): New
1295 function; moved the code over from
1296 remove_bookmark_button_clicked_cb().
1297 (remove_selected_bookmarks): Now, getting a non-removable bookmark
1298 is not an error, as we may be called as a result of hitting the
1300 (shortcuts_key_press_event_cb): New handler; delete the bookmark
1301 if the user presses Backspace, Delete, or KP_Delete.
1303 2004-04-29 Matthias Clasen <mclasen@redhat.com>
1305 * gtk/gtkaction.c (closure_accel_activate): Use
1306 _gtk_action_emit_activate() instead of directly
1307 emitting the activate signal. (#141429, Jody Goldberg)
1309 * gtk/gtkactiongroup.c (gtk_action_group_add_action_with_accel):
1310 Warn people when the accelerator can not be
1311 parsed. (#141429, Jody Goldberg)
1313 2004-04-29 Matthias Clasen <mclasen@redhat.com>
1315 * tests/testentrycompletion.c (main): Add a missing
1316 cat. (#141070, Chris Sherlock)
1318 * gtk/gtkrc.c (gtk_rc_check_pixmap_dir): Remove unused
1319 variable. (#141022, Chris Sherlock)
1321 * gtk/gtkcombo.c (gtk_combo_popup_list): Add a missing
1322 cast. (#141013, Chris Sherlock)
1324 * gtk/gtkcellview.c (gtk_cell_view_cell_layout_clear): Remove
1325 unused variable. (#141011, Chris Sherlock)
1327 2004-04-29 Tor Lillqvist <tml@iki.fi>
1329 * gdk/win32/gdkgc-win32.c (gdk_win32_gc_set_dashes): Plug memory
1330 leak. (#140775, John Ehresman)
1332 Thu Apr 29 01:09:50 2004 Matthias Clasen <maclas@gmx.de>
1334 * gdk/gdkdraw.c (_gdk_drawable_get_scratch_gc): Use depth - 1
1335 to index the cached gcs, not depth. (#139494)
1337 2004-04-28 Matthias Clasen <mclasen@redhat.com>
1339 * gdk/gdkdraw.c (_gdk_drawable_get_scratch_gc): Docs typo fix.
1341 Sun Apr 25 15:36:02 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1343 * gtk/gtktoolbutton.c (gtk_tool_button_set_label_widget): Fix
1344 cut'n'paste-o from previous commit. (#141046, Torsten Schoenfeld).
1346 2004-04-24 Theppitak Karoonboonyanan <thep@linux.thai.net>
1348 Patch to add support for string conversion callbacks to
1349 GtkIMContextXIM (#101814)
1351 * modules/input/gtkimcontextxim.c: Set the string conversion callback
1352 if supported by the XIC.
1354 (struct _GtkIMContextXIM): Add string_conversion_callback member.
1356 (struct _GtkXIMInfo, setup_im): Check and keep flag inidicating
1357 whether string conversion callback is supported.
1359 (gtk_im_context_get_ic, +set_string_conversion_callback,
1360 +string_conversion_callback): Also initialize string conversion
1361 callback, if supported, along with the IC initialization.
1363 * modules/input/imxim.c: Make "xim" module default for Thai as well.
1365 2004-04-23 Matthias Clasen <mclasen@redhat.com>
1367 * gtk/gtkclipboard.c (gtk_clipboard_wait_for_targets): Correctly
1368 initialize targets. (#139883, John Finlay)
1370 * gdk/gdkdraw.c (gdk_draw_drawable): Small doc improvement.
1372 * gtk/gtktreeselection.c (gtk_tree_selection_get_selected_rows):
1373 Don't recommend gtk_tree_row_reference_new_proxy(). (#138309,
1374 Tim-Philipp Müller)
1376 * gtk/gtktreeviewcolumn.c (gtk_tree_view_column_cell_set_cell_data):
1377 Remove an excessive g_return_if_fail().
1379 * gdk/x11/gdkevents-x11.c (set_user_time): Make set_user_time()
1381 * gdk/x11/gdkinput-x11.c (_gdk_input_common_other_event):
1382 _-prefix calls of gdk_x11_window_set_user_time().
1384 2004-04-22 Matthias Clasen <mclasen@redhat.com>
1386 * gtk/gtkuimanager.c (update_node): Make sure the separators
1387 used to demarkate placeholder ends don't show up on
1388 show_all(). (#140496, Murray Cumming)
1390 * gtk/gtkspinbutton.c (spin_button_at_limit): Make spinbuttons
1391 work with negative increments. (#137975, Tim Gerla)
1393 Wed Apr 21 21:38:03 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1395 * gtk/gtktoolbutton.c (gtk_tool_button_set_label_widget,
1396 gtk_tool_button_set_icon_widget): Remove the old widget from the
1397 tool button before overwriting it with the new widget.
1399 (#140508, Todd Goyen)
1401 2004-04-22 Tor Lillqvist <tml@iki.fi>
1403 Fix the file chooser on Windows. I can't make it misbehave or
1404 crash any more now. But presumably there are still corner cases
1405 not handled. I haven't really checked behaviour of UNC paths, for
1408 * gtk/gtkfilesystemwin32.c: Accept both backslash and slash in
1409 several places. Use G_IS_DIR_SEPARATOR macro (which could be added
1412 (gtk_file_system_win32_get_parent): Like the Unix version, assert
1413 filename is absolute, and avoid one unnecessary string allocation
1416 (canonicalize_filename,gtk_file_system_win32_parse): Handle drive
1417 letters more correctly.
1419 (gtk_file_system_win32_render_icon): Assure correct syntax is used
1420 for root folder of a drive. (#137962, Morten Welinder)
1422 (filename_is_some_root): New function that accepts also root
1423 without any drive specified.
1425 (filename_is_drive_root): Rename from filename_is_root.
1427 * gtk/gtkfilechooserentry.c (completion_match_func): Casefold on
1430 2004-04-21 Matthias Clasen <mclasen@redhat.com>
1432 * gtk/gtkentry.c (gtk_entry_completion_timeout): Pop down the
1433 completion window if there are no completions anymore.
1435 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
1436 Don't call gtk_tree_view_scroll_to_cell() on an empty tree view.
1437 It doesn't like that. (#140642, Christian Persch)
1439 * demos/gtk-demo/expander.c (do_expander): A new demo.
1441 * demos/gtk-demo/Makefile.am (demos): Add expander.c.
1443 2004-04-20 Matthias Clasen <mclasen@redhat.com>
1445 * gtk/gtktextview.c (gtk_text_view_allocate_children): Make
1446 sure anchored children get size allocated, even if the layout
1447 is valid. (#122323, Andrew E. Makeev)
1448 (gtk_text_view_scroll_pages):
1449 (gtk_text_view_scroll_hpages): Don't scroll to cursor position
1450 if we already have pending scrolls. Bandaid fix for #78513.
1452 Mon Apr 19 17:59:17 2004 Owen Taylor <otaylor@redhat.com>
1454 * INSTALL.in: Update libpng and libjpeg URLs, remove
1455 note about building without since that's not the normal
1458 Sun Apr 11 09:45:11 2004 Owen Taylor <otaylor@redhat.com>
1460 * gtk/gtkicontheme.c (load_themes): Fix a couple of typos in
1461 handling of SVG/non-SVG unthemed icons.
1463 2004-04-19 Morten Welinder <terra@gnome.org>
1465 * gtk/gtktoolbar.c (gtk_toolbar_focus): Don't leak list of
1468 2004-04-19 Matthias Clasen <mclasen@redhat.com>
1470 * gtk/gtktextbtree.c (_gtk_text_line_previous_could_contain_tag):
1471 Don't stop the iteration up to the tag_root too
1472 early. (#109945, Dongho Shin)
1474 Sun Apr 18 17:06:03 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1476 * gdk/x11/gdkkeys-x11.c (get_effective_keymap): Make
1477 gdk_keymap_translate_keyboard_state() handle NULL
1478 keymaps. (#139715, Torsten Schoenfeld).
1480 Sun Apr 18 16:59:21 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1482 * configure.in: Don't erase GDK_EXTRA_CFLAGS. Fixes bug 139586,
1483 reported by Pedro RODRIGUEZ, about compilation problems when
1484 Xcursor is installed in a non-standard location.
1486 Sun Apr 18 16:15:15 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1488 Support for _NET_WM_USER_TIME (bug 115650). Patch by Elijah
1491 * gdk/x11/gdkwindow-x11.[ch]: Add new internal function
1492 _gdk_x11_set_user_time() to set the _NET_WM_USER_TIME property.
1494 * gdk/x11/gdkdisplay-x11.h (struct _GdkDisplayX11): Add user_time field
1496 * gdk/x11/gdkdisplay-x11.c: Add _NET_WM_USER_TIME to list of
1499 * gdk/x11/gdkinput-x11.c, gdk/x11/gdkevents-x11.c: Set the
1500 property on user interaction.
1502 2004-04-15 Federico Mena Quintero <federico@ximian.com>
1504 * gtk/gtkfilesel.c (open_new_dir): Tell the user to use
1505 G_FILENAME_ENCODING, not G_BROKEN_FILENAMES. Fixes #114065.
1507 * gtk/gtkfilechooserdefault.c (split_uris): Use a variant of the
1508 code from gtkfilesel.c to parse a "text/uri-list" blob. Fixes
1511 2004-04-15 Matthias Clasen <mclasen@redhat.com>
1513 * gtk/gtkcellrenderer.c (gtk_cell_renderer_class_init):
1514 * gtk/gtkbutton.c (gtk_button_class_init): Doc fixes.
1516 2004-04-14 Matthias Clasen <mclasen@redhat.com>
1518 * gtk/gtkcombobox.c:
1520 Make all style properties readonly.
1522 2004-04-14 Matthias Clasen <mclasen@redhat.com>
1524 * gtk/gtkcolorsel.c: Add a11y relations between the color
1525 wheel and the spin buttons. (#132745, Padraig O'Briain)
1527 * gtk/gtkiconfactory.c (gtk_icon_set_render_icon): Document
1528 the meaning of size == -1.
1530 * gtk/gtkwidget.c (gtk_widget_render_icon): Explicitly accept
1531 a size of -1. (#137436, Brian Cameron)
1533 * gtk/gtkcombobox.c: Make the arrow and separator regular
1534 children of an hbox inside the button, and propagate state
1535 changes from the button to the cell view. (part of the fix
1536 for #138650, should also fix #137535)
1538 * gtk/gtkcellview.c (gtk_cell_view_expose): Pass the PRELIT
1539 state to gtk_cell_renderer_render() when prelighted. (part
1540 of the fix for #138650)
1542 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_render):
1543 Use PRELIGHT state when appropriate. (part of the fix for
1546 * gtk/gtkcombobox.c (gtk_combo_box_relayout): Don't spit
1547 out warnings if called before the combo box is
1548 realized. (#139742, Philip Langdale)
1550 Wed Apr 14 03:45:39 2004 Jonathan Blandford <jrb@gnome.org>
1552 * gtk/gtktreeview.c (gtk_tree_view_expose): propagate expose
1555 Wed Apr 14 03:32:58 2004 Jonathan Blandford <jrb@gnome.org>
1557 * gtk/gtkpathbar.c (make_directory_button): remove spurious
1560 Tue Apr 13 16:19:23 2004 Jonathan Blandford <jrb@redhat.com>
1562 * gtk/gtkpathbar.c (make_directory_button): patch from Owen to
1563 make the buttons sized by a bold label. This makes the text
1564 'swim' a little, but stops the buttons from resizing, #137210
1566 2004-04-13 Matthias Clasen <mclasen@redhat.com>
1568 * gtk/gtkuimanager.c (get_child_node): Don't crash if a node
1570 (start_element_handler): Accept separators without unique
1571 names. (#133302, Anders Carlsson)
1573 * gtk/gtkactiongroup.c (gtk_action_group_add_action): Document
1574 possible accelerator gotcha when using this function. (#139641,
1577 * gtk/gtkuimanager.c (node_remove_ui_reference): Don't leak
1578 list nodes. (#138862, Morten Welinder)
1580 Tue Apr 13 12:24:49 2004 Jonathan Blandford <jrb@redhat.com>
1582 * gtk/gtktreeview.c (gtk_tree_view_destroy): remove unused
1584 (gtk_tree_view_button_press): If we activated the row we don't
1585 want to grab focus back, as moving focus to another widget is
1586 pretty common, #138458
1588 2004-04-12 Federico Mena Quintero <federico@ximian.com>
1590 * gtk/gtkfilechooser.c (gtk_file_chooser_class_init): Added
1591 documentation to all the signals.
1593 2004-04-12 Matthias Clasen <mclasen@dhcp64-228.boston.redhat.com>
1595 * gtk/gtkcombobox.c (gtk_combo_box_unset_model): Don't unref
1596 model if it is NULL. (#139770)
1598 * gtk/gtktreeview.c (gtk_tree_view_get_cell_area): Typo fix.
1600 * gtk/gtkentrycompletion.c (gtk_entry_completion_init): Don't add
1601 a shadow inside the scrolled window, add it around the vbox.
1603 * gtk/gtkentryprivate.h:
1604 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
1605 Return a boolean indicating whether the popup is positioned above
1606 or below. Scroll the completions to the beginning or the end,
1607 depending on the positioning.
1609 * gtk/gtkentry.c (gtk_entry_completion_key_press): Make keynav
1610 wrap around in the entry completion popup, and allow GDK_UP to
1611 enter the popup. (#137440)
1613 2004-04-12 Matthias Clasen <mclasen@redhat.com>
1615 * gtk/gtkentry.c (gtk_entry_size_request): Make sure the style is
1616 there before using it.
1618 Sun Apr 11 15:08:45 2004 Jonathan Blandford <jrb@gnome.org>
1620 * gtk/gtktreeprivate.h: Moved search entries into priv data.
1622 * gtk/gtktreeview.c: Prep for type-ahead support.
1624 (gtk_tree_view_destroy): Destroy the search window explicitly.
1625 (gtk_tree_view_key_press): Minor change; prep for type-ahead
1626 (gtk_tree_view_ensure_interactive_directory): New function
1627 (gtk_tree_view_focus_out): Rework to handle new entry life-cycle.
1628 (gtk_tree_view_real_start_interactive_search): rework
1629 (gtk_tree_view_search_dialog_hide): ditto
1630 (gtk_tree_view_search_delete_event): ditto
1631 (gtk_tree_view_search_button_press_event): ditto
1632 (gtk_tree_view_search_key_press_event): ditto
1633 (gtk_tree_view_search_move): ditto
1634 (gtk_tree_view_search_init): ditto
1636 * gtk/gtktreeviewcolumn.c:
1637 (gtk_tree_view_column_cell_layout_clear): remove unused variable.
1639 * tests/testfilechooser.c: (main): change
1641 2004-04-11 Hans Breuer <hans@breuer.org>
1643 * gdk/win32/gdkspawn-win32.c : workaround for bug #137496,
1644 the real fix would involve just another small API breakage,
1645 i.e. gdk_spawn_* using GPid not just gint.
1647 * gtk/makefile.msc.in : build gtk-win32.res, not gtk.res
1649 2004-04-10 Tor Lillqvist <tml@iki.fi>
1651 * gdk/win32/gdkkeys-win32.c (gdk_keymap_translate_keyboard_state):
1652 If both Shift and CapsLock pressed, ignore the shift only for
1653 letters (that would have been affected by the CapsLock). (#139095)
1655 * gdk/win32/gdkglobals-win32.c: Disable tablet support by default,
1656 seems to be even buggier now than it used to be. (#138341)
1657 Initialize _gdk_input_ignore_wintab to TRUE.
1659 * gdk/win32/gdkmain-win32.c: Add --use-wintab switch and
1660 GDK_USE_WINTAB environment variable to turn on tablet support.
1662 2004-04-09 Christian Persch <chpe@cvs.gnome.org>
1664 * gtk/gtkuimanager.c: (gtk_ui_manager_insert_action_group),
1665 (gtk_ui_manager_remove_action_group): Terminate
1666 g_object_[dis]connect() calls with NULL instead of 0.
1669 2004-04-09 Guntupalli Karunakar <karunakar@freedomink.org>
1671 * configure.in: Added "gu" (Gujarati) to ALL_LINGUAS.
1673 2004-04-07 Federico Mena Quintero <federico@ximian.com>
1677 * gtk/gtkfilesystem.c (gtk_file_system_parse): Ensure that the
1678 passed-in 'str' is not NULL.
1680 * gtk/gtkfilesystemunix.c (expand_tilde): New helper function;
1681 expands "~/" or "~foo/" at the beginning of a filename.
1682 (gtk_file_system_unix_parse): Use expand_tilde() before doing
1685 * gtk/gtkfilechooserentry.c
1686 (gtk_file_chooser_entry_maybe_update_directory): Take in a
1687 force_reload argument.
1688 (gtk_file_chooser_entry_changed): If gtk_file_system_parse()
1689 returns an error, set the file_part_pos to -1.
1690 (load_directory_callback): Only populate the model if the
1691 file_part_pos is not -1.
1693 2004-04-06 Pablo Saratxaga <pablo@mandrakesoft.com>
1695 * configure.in: Added Icelandic (is) to ALL_LINGUAS
1697 2004-04-05 Federico Mena Quintero <federico@ximian.com>
1699 * gtk/gtkfilechooserdefault.c (location_popup_handler): Use a
1700 title for SAVE and CREATE_FOLDER modes. Fixes #137272.
1702 * gtk/gtkfilesystemunix.c (gtk_file_system_unix_make_path): Look
1703 for G_DIR_SEPARATOR in the display_name, and err out if it is
1704 present; use the same error message as Nautilus. Fixes #136467.
1706 * gtk/gtkfilechooserdefault.c (file_pane_create): Make the
1707 new-folder button say "Create Fo_lder" rather than "Create
1708 _Folder", so that the mnemonic doesn't conflict with the "Save in
1709 _folder" label. Fixes #136975.
1711 2004-04-05 Federico Mena Quintero <federico@ximian.com>
1713 * gtk/gtkpathbar.c (_gtk_path_bar_set_path): Ref/sink the
1714 buttons. Also, free them correctly upon failure. Based on a
1715 patch by Morten Welinder, fixes #137956.
1717 2004-04-05 Anders Carlsson <andersca@gnome.org>
1719 * gdk/gdk.c (gdk_arg_context_parse): Handle '--' correctly.
1721 Fri Apr 2 17:57:33 2004 Jonathan Blandford <jrb@redhat.com>
1723 * gtk/gtktreeview.c (gtk_tree_view_row_inserted): set the height
1724 correctly for fixed height when inserting a node, #138082
1726 2004-04-01 Federico Mena Quintero <federico@ximian.com>
1730 * gtk/gtkpathbar.h (struct _GtkPathBarClass): Add a
1731 "child_is_hidden" boolean argument to the "path-clicked" signal.
1733 * gtk/gtkpathbar.c (struct _ButtonData): Added a file_is_hidden
1735 (make_directory_button): Take a file_is_hidden argument; put it in
1737 (_gtk_path_bar_set_path): See whether each path component path is
1739 (gtk_path_bar_class_init): Add the file_is_hidden argument to the
1740 "path-clicked" signal.
1741 (button_clicked_cb): See if the downwards button represents a
1742 hidden file for the file_is_hidden argument in the signal
1745 * gtk/gtkmarshalers.list: Added a signal type VOID:POINTER,BOOLEAN.
1747 * gtk/gtkfilechooserdefault.c
1748 (gtk_file_chooser_default_select_path): If we fail to switch
1749 folders, don't try to select the path in the file system model.
1750 Also, return the result from _gtk_file_system_model_path_do().
1751 (gtk_file_chooser_default_select_path): Turn on show_hidden in the
1752 file system model if we are asked to select a hidden file.
1753 (path_bar_clicked): Show hidden files based on whether the
1754 immediate downwards folder in the path bar is a hidden file
1756 (struct _GtkFileChooserDefault): Added fields
1757 browse_files_popup_menu and browse_files_popup_menu_hidden_files_item.
1758 (create_file_list): Set an object data key of
1759 "GtkFileChooserDefault" on the tree view so that we can find the
1760 impl from the popup menu callbacks. Also, hook up to the
1761 "button-press-event" and "popup-menu" signals in the file list to
1762 bring up a popup menu.
1763 (list_popup_menu_cb): New callback.
1764 (list_button_press_event_cb): New callback.
1768 * gtk/gtkfilesystemmodel.c
1769 (_gtk_file_system_model_new): Oops, connect_object to
1772 2004-03-31 Tor Lillqvist <tml@iki.fi>
1774 * configure.in: Move AC_CANONICAL_HOST earlier, before the check
1775 for native Win32. (#136559, J. Ali Harlow)
1777 * gdk/win32/gdkdrawable-win32.c (draw_arc): Use X11 semantics for
1778 angles. Thanks to Tim Newsham.
1780 2004-03-29 Federico Mena Quintero <federico@ximian.com>
1784 * gtk/gtkfilesystem.h (struct _GtkFileFolderIface): Added slots
1785 for an ::is_finished_loading() method and a ::finished_loading()
1786 signal at the end of the struct.
1788 * gtk/gtkfilesystem.c (gtk_file_folder_base_init): Create the
1789 "finished-loading" signal.
1790 (gtk_file_folder_is_finished_loading): New function.
1792 * gtk/gtkfilesystemunix.c
1793 (gtk_file_folder_unix_is_finished_loading): Implement.
1795 * gtk/gtkfilesystemmodel.c (struct _GtkFileSystemModelClass): New
1796 slot for a "finished-loading" signal.
1797 (gtk_file_system_model_class_init): Create the "finished-loading"
1799 (struct _GtkFileSystemModel): New field
1800 idle_finished_loading_source. We emit the "finished-loading"
1801 signal in an idle if the root folder was done loading right in
1802 _gtk_file_system_model_new(), so that the caller has a chance to
1803 connect to the signal.
1804 (_gtk_file_system_model_new): Connect to the normal signals of the
1805 folder even if the initial _list_children() fails. Also, see if
1806 the folder is finished loading; connect to the "finished-loading"
1808 (gtk_file_system_model_finalize): Remove the idle handler.
1810 * gtk/gtkfilechooserdefault.c (set_list_model): Set a busy cursor
1811 and connect to the model's "finished-loading" signal.
1812 (get_toplevel): New helper function.
1813 (error_message): Use get_toplevel().
1814 (trap_activate_cb): Likewise.
1815 (location_popup_handler): Likewise.
1816 (set_busy_cursor): New function.
1817 (browse_files_model_finished_loading_cb): New callback.
1819 2004-03-25 Federico Mena Quintero <federico@ximian.com>
1821 * gtk/gtkfilechooserdefault.c (check_preview_change): Just use the
1822 file under the cursor; we don't need the logic from
1823 GtkFileSelection after all. Fixes #132255.
1825 2004-03-25 Federico Mena Quintero <federico@ximian.com>
1827 * gtk/gtkfilechooserdefault.c (location_entry_create): Fill the
1828 location entry with the display name of the file under the cursor
1829 for Open mode, or the typed filename in Save mode.
1831 2004-03-24 J. Ali Harlow <ali@juiblex.co.uk>
1833 * gtk/gtkfilesystemwin32.c
1834 (filename_is_root): Bare drive designators (eg., "c:") are
1835 no longer considered as root filenames. Fixed #137942
1837 2004-03-24 J. Ali Harlow <ali@juiblex.co.uk>
1839 * gtk/gtkfilesystemwin32.c
1840 (gtk_file_system_win32_create_folder): Invert test for error in
1841 mkdir. Fixes #137945
1843 2004-03-24 J. Ali Harlow <ali@juiblex.co.uk>
1845 Fixed #138004 using Federico's code from #132327.
1847 * gtk/gtkfilesystemwin32.c (struct _GtkFileSystemWin32): Add a
1848 folder_hash field to keep a list of live folder objects.
1849 (gtk_file_system_win32_init): Create the folder_hash.
1850 (gtk_file_system_win32_finalize): Destroy the folder_hash.
1851 (gtk_file_system_win32_get_folder): Ref and return an existing
1852 folder if we have it around, otherwise return a new folder object.
1853 (struct _GtkFileFolderWin32): Add a field for the parent file system.
1854 (gtk_file_folder_win32_finalize): Remove the folder from the file
1855 system's hash table.
1856 (gtk_file_system_win32_create_folder): Emit "files-added" on the
1857 newly-created folder's parent. Fixes #138004.
1859 2004-03-24 J. Ali Harlow <ali@juiblex.co.uk>
1861 * gtk/gtkfilesystemwin32.c
1862 (gtk_file_system_win32_get_folder): Test that path is actually
1863 a directory and throw error if not. Fixed bug #137950
1865 2004-03-22 J. Ali Harlow <ali@juiblex.co.uk>
1867 * gtk/gtkfilesystemwin32.c
1868 (gtk_file_system_win32_volume_get_display_name): Ignore empty
1869 volume labels; assume that GetVolumeInformation would fail if
1870 GetVolumeInformationW does; catches a small memory leak;
1871 pass the buffer size to GetVolumeInformationW in wide
1872 characters instead of bytes. Fixes bug #137543
1873 (list_volumes): Cope with the theoretical possibility of
1874 more than 26 logical drives. Fixes bug #137940
1875 (bookmarks_serialize): Now actually removes bookmarks.
1878 2004-03-22 Guntupalli Karunakar <karunakar@freedomink.org>
1880 * configure.in: Added "pa" (Punjabi) to ALL_LINGUAS.
1882 2004-03-21 Tor Lillqvist <tml@iki.fi>
1884 * gtk/gtkfilesystemwin32.c
1885 (gtk_file_system_win32_volume_get_base_path): Include the
1886 backslash. Otherwise gtk_file_system_win32_path_to_uri() returns
1887 NULL for a volume base path, as g_filename_to_uri() requires an
1888 absolute path, and just a drive letter and colon isn't. (#137543)
1890 2004-03-20 Hans Breuer <hans@breuer.org>
1892 * gtk/gtkfilesystemwin32.c : applied the undisputable and
1893 required [due to recent gtkfilesystem internal api semantic
1894 changes] part of patches to fix bug #137543 (Tor Lillqvist,
1897 * gdk/gdkevents-win32.c (handle_configure_event) :
1898 (gdk_event_translate), WM_WINDOWPOSCHANGED : initialize
1899 GdkWindowObject::x, y with screen coords to make
1900 gdk_window_get_position () return the right thing and thus fix
1901 drag and drop positioning (e.g. Gimp tabs, fixes bug #137192)
1903 2004-03-19 Federico Mena Quintero <federico@ximian.com>
1905 * Revert the patch to #137520, as 2.4.1 is for conservative bug
1906 fixes only. The patch is attached to the bug report, for
1909 2004-03-19 Morten Welinder <terra@gnome.org>
1911 * gtk/gtkfilechooserdefault.c
1912 (gtk_file_chooser_default_set_current_folder): Test existance of
1913 the path after checking for locality, if needed.
1915 2004-03-19 Federico Mena Quintero <federico@ximian.com>
1919 * gtk/gtkfilesystem.h (struct _GtkFileFolderIface): Added slots
1920 for an ::is_finished_loading() method and a ::finished_loading()
1921 signal at the end of the struct.
1923 * gtk/gtkfilesystem.c (gtk_file_folder_base_init): Create the
1924 "finished-loading" signal.
1925 (gtk_file_folder_is_finished_loading): New function.
1927 * gtk/gtkfilesystemunix.c
1928 (gtk_file_folder_unix_is_finished_loading): Implement.
1930 * gtk/gtkfilesystemmodel.c (struct _GtkFileSystemModelClass): New
1931 slot for a "finished-loading" signal.
1932 (gtk_file_system_model_class_init): Create the "finished-loading"
1934 (struct _GtkFileSystemModel): New field
1935 idle_finished_loading_source. We emit the "finished-loading"
1936 signal in an idle if the root folder was done loading right in
1937 _gtk_file_system_model_new(), so that the caller has a chance to
1938 connect to the signal.
1939 (_gtk_file_system_model_new): Connect to the normal signals of the
1940 folder even if the initial _list_children() fails. Also, see if
1941 the folder is finished loading; connect to the "finished-loading"
1943 (gtk_file_system_model_finalize): Remove the idle handler.
1945 * gtk/gtkfilechooserdefault.c (set_list_model): Set a busy cursor
1946 and connect to the model's "finished-loading" signal.
1947 (get_toplevel): New helper function.
1948 (error_message): Use get_toplevel().
1949 (trap_activate_cb): Likewise.
1950 (location_popup_handler): Likewise.
1951 (set_busy_cursor): New function.
1952 (browse_files_model_finished_loading_cb): New callback.
1954 Thu Mar 18 12:10:45 2004 Owen Taylor <otaylor@redhat.com>
1956 * gtk/gtktreeitem.c (gtk_tree_item_forall): Include
1957 eventbox for expander. (#137564, reported by
1960 2004-03-18 Guntupalli Karunakar <karunakar@freedomink.org>
1962 * mr.po: Added "mr" for Marathi to ALL_LINGUAS.
1964 2004-03-17 Morten Welinder <terra@gnome.org>
1966 * gtk/gtkfilechooserdefault.c (shortcuts_add_volumes): Free
1967 volumes not actually put into the shortcut list.
1969 * tests/prop-editor.c (object_changed): Plug leak.
1971 * tests/testfilechooser.c (main): Plug some leaks and expose
1974 * tests/prop-editor.c (create_prop_editor): Don't leak the tooltip
1975 object. Fixed #136652.
1977 * gtk/gtkfilechooserdefault.c (check_icon_theme): Do nothing if we
1978 have no screen. Fixes #137260.
1979 (shortcuts_add_bookmark_from_path): Simplify using check_is_folder
1980 thereby fixing leak. Fixes #137259.
1982 * gtk/gtkpathbar.c (gtk_path_bar_forall): Make this work when the
1983 slider buttons have been destroyed.
1984 (gtk_path_bar_remove): Make this work for slider buttons too.
1987 2004-03-15 Morten Welinder <terra@gnome.org>
1989 * gtk/gtkfilechooserdefault.c (shortcuts_add_bookmark_from_path):
1990 Sanitize and plug leak.
1991 (check_icon_theme): Only do something if the widget has a screen.
1993 Wed Mar 17 01:20:28 2004 Matthias Clasen <maclas@gmx.de>
1995 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
1996 Move the repositioning logic from _gtk_entry_completion() popup
1997 over here. Fixes #137355, reported by Niklas Knutsson.