1 2004-05-11 Robert Ögren <gtk@roboros.com>
3 * gdk/win32/gdkevents-win32.c (gdk_event_translate): Add missing
4 call to g_object_ref in Wintab code. (#138341)
6 * gdk/win32/gdkinput-win32.c: Fix numerous Wintab problems
7 including unallocated buffers for event->motion.axes and
8 event->button.axes, unsigned wraparound problem in the code for
9 detecting missing press/release events and assigning min instead
10 of max when setting up axes.
12 2004-05-12 Matthias Clasen <mclasen@redhat.com>
14 * tests/testtreeedit.c: Add a progress column.
16 * gtk/Makefile.am: Add gtkcellrendererprogress.[hc] in the right
19 * gtk/gtk.h: Include gtkcellrendererprogress.h.
21 * gtk/gtkcellrendererprogress.[hc]: A progress cell renderer,
22 based on the one found in Epiphany.
24 2004-05-11 Michael Natterer <mitch@gimp.org>
26 * gtk/gtkcombobox.c (gtk_combo_box_popup)
27 (gtk_combo_box_menu_button_press): don't allocate the popup
28 smaller than the combobox. Fixes bug #59660.
30 2004-05-11 Matthias Clasen <mclasen@redhat.com>
32 * gtk/gtkuimanager.c (gtk_ui_manager_get_widget): Revert the
33 previous change to this function, clarify the docs instead.
35 * gtk/gtkcombobox.c (gtk_combo_box_list_setup): Use
38 * gtk/gtktreeview.c: Make hover selection work for
39 GTK_SELECTION_BROWSE as well.
41 Tue May 11 00:38:25 2004 Matthias Clasen <maclas@gmx.de>
43 * gtk/gtkcellrenderertoggle.c (gtk_cell_renderer_toggle_class_init):
44 Document the ::toggled signal.
46 Mon May 10 23:04:25 2004 Soeren Sandmann <sandmann@daimi.au.dk>
48 * gtk/gtkwidget.h: Add prototype for _gtk_widget_grab_notify()
50 2004-05-10 Matthias Clasen <mclasen@redhat.com>
52 * gtk/gtkwindow.c (get_screen_icon_info): Make static.
54 * gdk/gdkdisplay.c (singlehead_...):
55 * gdk/x11/gdkkeys-x11.c (get_effective_keymap):
56 * gdk/x11/gdkgeometry-x11.c (expose_serial_predicate):
57 * gdk/x11/gdkdisplay-x11.c (escape_for_xmessage): Make static.
59 * gtk/gtktreeview.c (gtk_tree_view_set_fixed_height_mode): Add a
60 note about COLUMN_FIXED restriction.
62 * gtk/gtkentrycompletion.c (gtk_entry_completion_list_button_press):
63 Set the entry in the default handler of the ::match-selected signal.
66 * gtk/gtkcombobox.c (gtk_combo_box_menu_position_below): If we don't
67 do the move-selected-item below pointer thingie, do the
68 place-below-or-above one.
70 * tests/testentrycompletion.c: Make the second example use the
71 ::match-selected signal to make it actually work.
73 * gtk/gtkentrycompletion.c (gtk_entry_completion_init):
74 * gtk/gtkcombobox.c (gtk_combo_box_list_setup): Use hover selection
75 mode. (#127648, Dave Bordoley)
78 * gtk/gtktreeview.c: Add a new property "hover_selection", which
79 when TRUE makes the selection follow the mouse. Also add setter
80 and getter for the fixed_height property.
82 2004-05-10 Matthias Clasen <mclasen@redhat.com>
84 * gtk/gtkcombobox.c (gtk_combo_box_popup)
85 (gtk_combo_box_menu_button_press): Make sure the menu pops up
86 as wide as the combobox. (#59660, Havoc Pennington)
88 2004-05-10 Matthias Clasen <mclasen@redhat.com>
91 * gtk/gtkcombobox.c: Support tearoffable combo boxes (in menu
92 mode). Add a new property, add-tearoffs, for this. (#135956)
94 * gtk/gtkfontsel.c (list_row_activated): Make Return activate the
95 default button. (#118921)
97 Mon May 10 15:03:50 2004 Soeren Sandmann <sandmann@daimi.au.dk>
99 * gtk/gtkwidget.c (_gtk_widget_grab_notify): New internal function
100 that emits the grab notify signal.
102 * gtk/gtkmain.c (gtk_grab_notify_foreach): Use it here.
104 Mon May 10 00:48:08 2004 Matthias Clasen <maclas@gmx.de>
106 * gtk/gtkmenu.c: Make destruction of a torn off menu work
109 Sun May 9 21:05:38 2004 Matthias Clasen <maclas@gmx.de>
113 * gtk/gtkactiongroup.c (gtk_action_group_add_action_with_accel):
114 Allow to suppress the stock accelerator by using "". (#142196,
117 Sun May 9 02:01:13 2004 Matthias Clasen <maclas@gmx.de>
121 * gtk/gtkcombobox.c (gtk_combo_box_list_button_released):
122 In list mode, accept the same mouse/wheel bindings on
123 the cellview as on the button. (#136967)
125 Sun May 9 01:25:37 2004 Matthias Clasen <maclas@gmx.de>
127 * gtk/gtkiconfactory.c (add_to_cache): Actually count the
128 cached icons. (#135888, Crispin Flowerday)
130 Sun May 9 00:03:03 2004 Matthias Clasen <maclas@gmx.de>
132 * gtk/gtkuimanager.c (gtk_ui_manager_get_widget): Make sure
133 that we actually return menus for nodes of type menu, not the
134 menuitems they're attached to.
136 Sat May 8 22:50:55 2004 Matthias Clasen <maclas@gmx.de>
138 * gtk/gtkactiongroup.c (gtk_action_group_set_translation_domain):
139 Add a note regarding UTF-8 requirements, proposed by
140 Mariano Suárez-Alvarez.
142 Sat May 8 22:43:11 2004 Matthias Clasen <maclas@gmx.de>
144 * gtk/gtktearoffmenuitem.h:
145 * gtk/gtktearoffmenuitem.c: Put the torn_off flag back
146 into the GtkTearoffMenuItem struct, since it is used
147 by the Gimp, and keep it synchronized with the
148 tearoff_state property of the parent menu.
150 2004-05-08 Hans Breuer <hans@breuer.org>
152 * gtk/gtkfilesystemwin32.c (extract_icon) : finally also
153 create the correct mask for 'pseudo mime' icons
155 * gdk/win32/gdkwindow-win32.c(show_window_internal) : also
156 take focus_on_map into account
158 * gtk/gtkselection.c : g_message() only with DEBUG_SELECTION
160 * gtk/gtkactiongroup.c gtk/gtkcombobox.c :
161 ... must return a value
163 * gdk/gdk.def gtk/gtk.def demos/gtk-demo/makefile.msc.in : updated
165 2004-05-07 Matthias Clasen <mclasen@redhat.com>
167 * gtk/gtkbutton.c (gtk_button_size_allocate): Don't let the child
168 draw over the focus rectangle.
170 * gtk/gtkhsv.c: Draw focus indication in the color wheel using
171 standard focus style. (#63071, Bill Haneman, idea for new
172 style by Owen Taylor)
174 * gtk/gtkstyle.c (gtk_default_draw_focus): Support drawing on
175 focus on the colorwheel via details.
177 2004-05-06 Matthias Clasen <mclasen@redhat.com>
181 * gtk/gtkcombobox.c (gtk_combo_box_menu_state_changed): Remove
182 this no longer needed signal handler. (#141817, Paul Pogonyshev)
184 Fri May 7 00:41:46 2004 Matthias Clasen <maclas@gmx.de>
186 * gtk/gtktearoffmenuitem.h:
187 * gtk/gtktearoffmenuitem.c: Make the tearoff
188 functionality model/view, the tearoffmenuitem being
189 the view and the tearoff_state property of the menu
190 being the model. (#101185, Owen Taylor)
192 * gtk/gtkmenu.c: Add a tearoff_state property.
194 Thu May 6 23:52:13 2004 Matthias Clasen <maclas@gmx.de>
198 * gtk/gtkmenuitem.c (gtk_menu_item_select_timeout): Also
199 popup the submenu for items in torn off menus. (#122051)
201 2004-05-06 Sven Neumann <sven@gimp.org>
203 * gtk/gtkexpander.c (gtk_expander_size_allocate): in RTL mode,
204 position the title lable next to the arrow just as we do for LTR
205 rendering. Fixes bug #141825.
207 2004-05-06 Matthias Clasen <mclasen@redhat.com>
209 * docs/RELEASE-HOWTO: Document the new policy of
210 bumping version numbers after release.
212 * configure.in: Bump version number to 2.5.0.
214 2004-05-06 Padraig O'Briain <padraig.obriain@sun.com>
217 * gtk/gtkmenu.c: Add new function gtk_menu_get_for_attach_widget.
220 Thu May 6 00:24:11 2004 Matthias Clasen <maclas@gmx.de>
222 * gtk/gtkactiongroup.h:
223 * gtk/gtkactiongroup.c (gtk_action_group_translate_string):
224 New function to translate a string with translate_func.
227 Thu May 6 00:02:21 2004 Matthias Clasen <maclas@gmx.de>
229 * gtk/gtkcombobox.c (gtk_combo_box_get_wrap_width):
230 (gtk_combo_box_get_row_span_column):
231 (gtk_combo_box_get_column_span_column): Add missing getters
232 for readwrite properies. (#135649)
234 Wed May 5 23:42:42 2004 Matthias Clasen <maclas@gmx.de>
237 * gtk/gtkcombobox.c (gtk_combo_box_get_active_text):
238 Add gtk_combo_box_get_active_text() convenience
239 function. (#136372, Christian Neumeir, patch by Olivier Andrieu)
241 2004-05-05 Elijah Newren <newren@math.utah.edu>
243 Changes to support do-not-focus-on-map hint in conjunction with
244 _NET_WM_USER_TIME (#115650):
246 * gdk/gdkwindow.h (struct _GdkWindowObject): Add a new boolean
249 * gdk/gdkwindow.h (gdk_window_set_accept_focus): New function to
252 * gtk/gtkwindow.[hc]: Add a boolean property "focus_on_map"
253 and gtk_window_get_focus_on_map() and gtk_window_set_focus_on_map().
255 * gdk/win32/gdkwindow-win32.c (gdk_window_new):
256 * gdk/linux-fb/gdkwindow-fb.c (gdk_window_new):
257 * gdk/x11/gdkwindow-x11.c (gdk_window_new):
258 Initialize the focus_on_map field to TRUE.
260 * gdk/win32/gdkwindow-win32.c (gdk_window_set_focus_on_map):
261 * gdk/linux-fb/gdkwindow-fb.c (gdk_window_set_focus_on_map):
262 * gdk/x11/gdkwindow-x11.c (gdk_window_set_focus_on_map):
263 * gdk/x11/gdkwindow-x11.c (setup_toplevel_window):
264 Implementations for the various backends. The Win32 and linux-fb
265 implementations set the focus_on_map field, but don't use it yet
266 to actually implement noinput windows. The X implementation sets
267 _NET_WM_USER_TIME to 0 if focus_on_map is FALSE (see the EWMH).
269 * gdk/x11/gdkwindow-x11.h:
270 * gdk/x11/gdkevents-x11.c (set_user_time):
271 * gdk/x11/gdkinput-x11.c (_gdk_input_common_other_event):
272 * gdk/x11/gdkwindow-x11.c (gdk_x11_window_set_user_time):
273 s/_gdk_x11_window_set_user_time/gdk_x11_window_set_user_time/,
274 since we want that function to be part of the public API.
276 Wed May 5 22:20:21 2004 Matthias Clasen <maclas@gmx.de>
280 * gtk/gtkiconfactory.c (icon_source_clear): Don't
281 call g_free() on a pixbuf. (#141961, Crispin Flowerday)
283 2004-05-05 Matthias Clasen <mclasen@redhat.com>
287 * gtk/gtkuimanager.c (print_node): Make the output
288 parseable. (#141929, Sven Neumann)
290 2004-05-05 Tor Lillqvist <tml@iki.fi>
292 * gdk/win32/gdkdnd-win32.c (gdk_drag_find_window_for_screen): Add
293 multi-monitor offset. (#141842, John Ehresman)
295 2004-05-04 Federico Mena Quintero <federico@ximian.com>
297 Fixes #139562, based on a patch by Christian Neumair.
299 * gtk/gtkfilechooserdefault.c (struct _GtkFileChooserDefault): Add
300 a filter_combo_hbox field to contain the filter combo.
301 (show_filters): Show/hide the filter_combo_hbox.
302 (create_filename_entry_and_filter_combo): Removed.
303 (file_pane_create): Create the filter_combo_hbox here.
305 2004-05-04 Matthias Clasen <mclasen@redhat.com>
307 * modules/input/gtkimcontextxim.c: Fix the recent
308 string_conversion_callback change to work on
309 Solaris. (#141190, Padraig O'Briain)
311 * gtk/gtkselection.c: Disable debug logging again.
313 2004-05-03 Matthias Clasen <mclasen@redhat.com>
315 * gtk/gtkselection.c: Make the chunk size for
316 incremental transfers depend on the maximal request
317 size, capped at 256k. This should allow most selections
318 to be transferred nonincrementally, avoiding many
319 roundtrips and protocol overhead.
321 2004-05-03 Federico Mena Quintero <federico@ximian.com>
323 * gtk/gtkuimanager.c (gtk_ui_manager_class_init): Call
324 g_signal_new() correctly and initialize the signal fields. Fixes
325 #141749; patch based on Michael Natterer's.
327 u2004-05-03 Matthias Clasen <mclasen@redhat.com>
329 * gtk/gtkselection.c (_gtk_selection_request): Fix
330 a debug message to show correct information.
331 (_gtk_selection_incr_event): Make INCRemental transfer
332 of MULTIPLE targets work. This was broken since 1997!
334 2004-05-02 Hans Breuer <hans@breuer.org>
336 * gdk/win32/gdkdrawable-win32.c (draw_segments) : don't
337 modify the passed in GdkSegment(s) in place, we may get
338 them again to draw at the same place. Fixes bug #129095,
340 (draw_segments) draw the end pixel again to get the
341 pixmap mask right, fixes bug #126710, #130202
343 * gdk/win32/gdkwindow-win32.c : use SetForegroundWindow,
344 fixes bug #106013, John Ehresman
346 * gtk/makefile.msc.in : don't try to link gtk.res but
347 use gtk-win32.res (as supposed to be fixed below :)
349 2004-05-01 Hans Breuer <hans@breuer.org>
351 * tests/Makefile.am : tests/makefile.msc is in CVS for
352 a long time, finally added to EXTRA_DIST : fixes bug
353 #141334, John Ehresman
355 2004-04-30 Matthias Clasen <mclasen@redhat.com>
357 * === Released 2.4.1 ===
359 * configure.in: Version 2.4.1, interface age 1.
363 2004-04-29 Federico Mena Quintero <federico@ximian.com>
367 * gtk/gtkfilechooserdefault.c (remove_selected_bookmarks): New
368 function; moved the code over from
369 remove_bookmark_button_clicked_cb().
370 (remove_selected_bookmarks): Now, getting a non-removable bookmark
371 is not an error, as we may be called as a result of hitting the
373 (shortcuts_key_press_event_cb): New handler; delete the bookmark
374 if the user presses Backspace, Delete, or KP_Delete.
376 2004-04-29 Matthias Clasen <mclasen@redhat.com>
378 * gtk/gtkaction.c (closure_accel_activate): Use
379 _gtk_action_emit_activate() instead of directly
380 emitting the activate signal. (#141429, Jody Goldberg)
382 * gtk/gtkactiongroup.c (gtk_action_group_add_action_with_accel):
383 Warn people when the accelerator can not be
384 parsed. (#141429, Jody Goldberg)
386 2004-04-29 Matthias Clasen <mclasen@redhat.com>
388 * tests/testentrycompletion.c (main): Add a missing
389 cat. (#141070, Chris Sherlock)
391 * gtk/gtkrc.c (gtk_rc_check_pixmap_dir): Remove unused
392 variable. (#141022, Chris Sherlock)
394 * gtk/gtkcombo.c (gtk_combo_popup_list): Add a missing
395 cast. (#141013, Chris Sherlock)
397 * gtk/gtkcellview.c (gtk_cell_view_cell_layout_clear): Remove
398 unused variable. (#141011, Chris Sherlock)
400 2004-04-29 Tor Lillqvist <tml@iki.fi>
402 * gdk/win32/gdkgc-win32.c (gdk_win32_gc_set_dashes): Plug memory
403 leak. (#140775, John Ehresman)
405 Thu Apr 29 01:09:50 2004 Matthias Clasen <maclas@gmx.de>
407 * gdk/gdkdraw.c (_gdk_drawable_get_scratch_gc): Use depth - 1
408 to index the cached gcs, not depth. (#139494)
410 2004-04-28 Matthias Clasen <mclasen@redhat.com>
412 * gdk/gdkdraw.c (_gdk_drawable_get_scratch_gc): Docs typo fix.
414 Sun Apr 25 15:36:02 2004 Soeren Sandmann <sandmann@daimi.au.dk>
416 * gtk/gtktoolbutton.c (gtk_tool_button_set_label_widget): Fix
417 cut'n'paste-o from previous commit. (#141046, Torsten Schoenfeld).
419 2004-04-24 Theppitak Karoonboonyanan <thep@linux.thai.net>
421 Patch to add support for string conversion callbacks to
422 GtkIMContextXIM (#101814)
424 * modules/input/gtkimcontextxim.c: Set the string conversion callback
425 if supported by the XIC.
427 (struct _GtkIMContextXIM): Add string_conversion_callback member.
429 (struct _GtkXIMInfo, setup_im): Check and keep flag inidicating
430 whether string conversion callback is supported.
432 (gtk_im_context_get_ic, +set_string_conversion_callback,
433 +string_conversion_callback): Also initialize string conversion
434 callback, if supported, along with the IC initialization.
436 * modules/input/imxim.c: Make "xim" module default for Thai as well.
438 2004-04-23 Matthias Clasen <mclasen@redhat.com>
440 * gtk/gtkclipboard.c (gtk_clipboard_wait_for_targets): Correctly
441 initialize targets. (#139883, John Finlay)
443 * gdk/gdkdraw.c (gdk_draw_drawable): Small doc improvement.
445 * gtk/gtktreeselection.c (gtk_tree_selection_get_selected_rows):
446 Don't recommend gtk_tree_row_reference_new_proxy(). (#138309,
449 * gtk/gtktreeviewcolumn.c (gtk_tree_view_column_cell_set_cell_data):
450 Remove an excessive g_return_if_fail().
452 * gdk/x11/gdkevents-x11.c (set_user_time): Make set_user_time()
454 * gdk/x11/gdkinput-x11.c (_gdk_input_common_other_event):
455 _-prefix calls of gdk_x11_window_set_user_time().
457 2004-04-22 Matthias Clasen <mclasen@redhat.com>
459 * gtk/gtkuimanager.c (update_node): Make sure the separators
460 used to demarkate placeholder ends don't show up on
461 show_all(). (#140496, Murray Cumming)
463 * gtk/gtkspinbutton.c (spin_button_at_limit): Make spinbuttons
464 work with negative increments. (#137975, Tim Gerla)
466 Wed Apr 21 21:38:03 2004 Soeren Sandmann <sandmann@daimi.au.dk>
468 * gtk/gtktoolbutton.c (gtk_tool_button_set_label_widget,
469 gtk_tool_button_set_icon_widget): Remove the old widget from the
470 tool button before overwriting it with the new widget.
472 (#140508, Todd Goyen)
474 2004-04-22 Tor Lillqvist <tml@iki.fi>
476 Fix the file chooser on Windows. I can't make it misbehave or
477 crash any more now. But presumably there are still corner cases
478 not handled. I haven't really checked behaviour of UNC paths, for
481 * gtk/gtkfilesystemwin32.c: Accept both backslash and slash in
482 several places. Use G_IS_DIR_SEPARATOR macro (which could be added
485 (gtk_file_system_win32_get_parent): Like the Unix version, assert
486 filename is absolute, and avoid one unnecessary string allocation
489 (canonicalize_filename,gtk_file_system_win32_parse): Handle drive
490 letters more correctly.
492 (gtk_file_system_win32_render_icon): Assure correct syntax is used
493 for root folder of a drive. (#137962, Morten Welinder)
495 (filename_is_some_root): New function that accepts also root
496 without any drive specified.
498 (filename_is_drive_root): Rename from filename_is_root.
500 * gtk/gtkfilechooserentry.c (completion_match_func): Casefold on
503 2004-04-21 Matthias Clasen <mclasen@redhat.com>
505 * gtk/gtkentry.c (gtk_entry_completion_timeout): Pop down the
506 completion window if there are no completions anymore.
508 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
509 Don't call gtk_tree_view_scroll_to_cell() on an empty tree view.
510 It doesn't like that. (#140642, Christian Persch)
512 * demos/gtk-demo/expander.c (do_expander): A new demo.
514 * demos/gtk-demo/Makefile.am (demos): Add expander.c.
516 2004-04-20 Matthias Clasen <mclasen@redhat.com>
518 * gtk/gtktextview.c (gtk_text_view_allocate_children): Make
519 sure anchored children get size allocated, even if the layout
520 is valid. (#122323, Andrew E. Makeev)
521 (gtk_text_view_scroll_pages):
522 (gtk_text_view_scroll_hpages): Don't scroll to cursor position
523 if we already have pending scrolls. Bandaid fix for #78513.
525 Mon Apr 19 17:59:17 2004 Owen Taylor <otaylor@redhat.com>
527 * INSTALL.in: Update libpng and libjpeg URLs, remove
528 note about building without since that's not the normal
531 Sun Apr 11 09:45:11 2004 Owen Taylor <otaylor@redhat.com>
533 * gtk/gtkicontheme.c (load_themes): Fix a couple of typos in
534 handling of SVG/non-SVG unthemed icons.
536 2004-04-19 Morten Welinder <terra@gnome.org>
538 * gtk/gtktoolbar.c (gtk_toolbar_focus): Don't leak list of
541 2004-04-19 Matthias Clasen <mclasen@redhat.com>
543 * gtk/gtktextbtree.c (_gtk_text_line_previous_could_contain_tag):
544 Don't stop the iteration up to the tag_root too
545 early. (#109945, Dongho Shin)
547 Sun Apr 18 17:06:03 2004 Soeren Sandmann <sandmann@daimi.au.dk>
549 * gdk/x11/gdkkeys-x11.c (get_effective_keymap): Make
550 gdk_keymap_translate_keyboard_state() handle NULL
551 keymaps. (#139715, Torsten Schoenfeld).
553 Sun Apr 18 16:59:21 2004 Soeren Sandmann <sandmann@daimi.au.dk>
555 * configure.in: Don't erase GDK_EXTRA_CFLAGS. Fixes bug 139586,
556 reported by Pedro RODRIGUEZ, about compilation problems when
557 Xcursor is installed in a non-standard location.
559 Sun Apr 18 16:15:15 2004 Soeren Sandmann <sandmann@daimi.au.dk>
561 Support for _NET_WM_USER_TIME (bug 115650). Patch by Elijah
564 * gdk/x11/gdkwindow-x11.[ch]: Add new internal function
565 _gdk_x11_set_user_time() to set the _NET_WM_USER_TIME property.
567 * gdk/x11/gdkdisplay-x11.h (struct _GdkDisplayX11): Add user_time field
569 * gdk/x11/gdkdisplay-x11.c: Add _NET_WM_USER_TIME to list of
572 * gdk/x11/gdkinput-x11.c, gdk/x11/gdkevents-x11.c: Set the
573 property on user interaction.
575 2004-04-15 Federico Mena Quintero <federico@ximian.com>
577 * gtk/gtkfilesel.c (open_new_dir): Tell the user to use
578 G_FILENAME_ENCODING, not G_BROKEN_FILENAMES. Fixes #114065.
580 * gtk/gtkfilechooserdefault.c (split_uris): Use a variant of the
581 code from gtkfilesel.c to parse a "text/uri-list" blob. Fixes
584 2004-04-15 Matthias Clasen <mclasen@redhat.com>
586 * gtk/gtkcellrenderer.c (gtk_cell_renderer_class_init):
587 * gtk/gtkbutton.c (gtk_button_class_init): Doc fixes.
589 2004-04-14 Matthias Clasen <mclasen@redhat.com>
593 Make all style properties readonly.
595 2004-04-14 Matthias Clasen <mclasen@redhat.com>
597 * gtk/gtkcolorsel.c: Add a11y relations between the color
598 wheel and the spin buttons. (#132745, Padraig O'Briain)
600 * gtk/gtkiconfactory.c (gtk_icon_set_render_icon): Document
601 the meaning of size == -1.
603 * gtk/gtkwidget.c (gtk_widget_render_icon): Explicitly accept
604 a size of -1. (#137436, Brian Cameron)
606 * gtk/gtkcombobox.c: Make the arrow and separator regular
607 children of an hbox inside the button, and propagate state
608 changes from the button to the cell view. (part of the fix
609 for #138650, should also fix #137535)
611 * gtk/gtkcellview.c (gtk_cell_view_expose): Pass the PRELIT
612 state to gtk_cell_renderer_render() when prelighted. (part
613 of the fix for #138650)
615 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_render):
616 Use PRELIGHT state when appropriate. (part of the fix for
619 * gtk/gtkcombobox.c (gtk_combo_box_relayout): Don't spit
620 out warnings if called before the combo box is
621 realized. (#139742, Philip Langdale)
623 Wed Apr 14 03:45:39 2004 Jonathan Blandford <jrb@gnome.org>
625 * gtk/gtktreeview.c (gtk_tree_view_expose): propagate expose
628 Wed Apr 14 03:32:58 2004 Jonathan Blandford <jrb@gnome.org>
630 * gtk/gtkpathbar.c (make_directory_button): remove spurious
633 Tue Apr 13 16:19:23 2004 Jonathan Blandford <jrb@redhat.com>
635 * gtk/gtkpathbar.c (make_directory_button): patch from Owen to
636 make the buttons sized by a bold label. This makes the text
637 'swim' a little, but stops the buttons from resizing, #137210
639 2004-04-13 Matthias Clasen <mclasen@redhat.com>
641 * gtk/gtkuimanager.c (get_child_node): Don't crash if a node
643 (start_element_handler): Accept separators without unique
644 names. (#133302, Anders Carlsson)
646 * gtk/gtkactiongroup.c (gtk_action_group_add_action): Document
647 possible accelerator gotcha when using this function. (#139641,
650 * gtk/gtkuimanager.c (node_remove_ui_reference): Don't leak
651 list nodes. (#138862, Morten Welinder)
653 Tue Apr 13 12:24:49 2004 Jonathan Blandford <jrb@redhat.com>
655 * gtk/gtktreeview.c (gtk_tree_view_destroy): remove unused
657 (gtk_tree_view_button_press): If we activated the row we don't
658 want to grab focus back, as moving focus to another widget is
659 pretty common, #138458
661 2004-04-12 Federico Mena Quintero <federico@ximian.com>
663 * gtk/gtkfilechooser.c (gtk_file_chooser_class_init): Added
664 documentation to all the signals.
666 2004-04-12 Matthias Clasen <mclasen@dhcp64-228.boston.redhat.com>
668 * gtk/gtkcombobox.c (gtk_combo_box_unset_model): Don't unref
669 model if it is NULL. (#139770)
671 * gtk/gtktreeview.c (gtk_tree_view_get_cell_area): Typo fix.
673 * gtk/gtkentrycompletion.c (gtk_entry_completion_init): Don't add
674 a shadow inside the scrolled window, add it around the vbox.
676 * gtk/gtkentryprivate.h:
677 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
678 Return a boolean indicating whether the popup is positioned above
679 or below. Scroll the completions to the beginning or the end,
680 depending on the positioning.
682 * gtk/gtkentry.c (gtk_entry_completion_key_press): Make keynav
683 wrap around in the entry completion popup, and allow GDK_UP to
684 enter the popup. (#137440)
686 2004-04-12 Matthias Clasen <mclasen@redhat.com>
688 * gtk/gtkentry.c (gtk_entry_size_request): Make sure the style is
689 there before using it.
691 Sun Apr 11 15:08:45 2004 Jonathan Blandford <jrb@gnome.org>
693 * gtk/gtktreeprivate.h: Moved search entries into priv data.
695 * gtk/gtktreeview.c: Prep for type-ahead support.
697 (gtk_tree_view_destroy): Destroy the search window explicitly.
698 (gtk_tree_view_key_press): Minor change; prep for type-ahead
699 (gtk_tree_view_ensure_interactive_directory): New function
700 (gtk_tree_view_focus_out): Rework to handle new entry life-cycle.
701 (gtk_tree_view_real_start_interactive_search): rework
702 (gtk_tree_view_search_dialog_hide): ditto
703 (gtk_tree_view_search_delete_event): ditto
704 (gtk_tree_view_search_button_press_event): ditto
705 (gtk_tree_view_search_key_press_event): ditto
706 (gtk_tree_view_search_move): ditto
707 (gtk_tree_view_search_init): ditto
709 * gtk/gtktreeviewcolumn.c:
710 (gtk_tree_view_column_cell_layout_clear): remove unused variable.
712 * tests/testfilechooser.c: (main): change
714 2004-04-11 Hans Breuer <hans@breuer.org>
716 * gdk/win32/gdkspawn-win32.c : workaround for bug #137496,
717 the real fix would involve just another small API breakage,
718 i.e. gdk_spawn_* using GPid not just gint.
720 * gtk/makefile.msc.in : build gtk-win32.res, not gtk.res
722 2004-04-10 Tor Lillqvist <tml@iki.fi>
724 * gdk/win32/gdkkeys-win32.c (gdk_keymap_translate_keyboard_state):
725 If both Shift and CapsLock pressed, ignore the shift only for
726 letters (that would have been affected by the CapsLock). (#139095)
728 * gdk/win32/gdkglobals-win32.c: Disable tablet support by default,
729 seems to be even buggier now than it used to be. (#138341)
730 Initialize _gdk_input_ignore_wintab to TRUE.
732 * gdk/win32/gdkmain-win32.c: Add --use-wintab switch and
733 GDK_USE_WINTAB environment variable to turn on tablet support.
735 2004-04-09 Christian Persch <chpe@cvs.gnome.org>
737 * gtk/gtkuimanager.c: (gtk_ui_manager_insert_action_group),
738 (gtk_ui_manager_remove_action_group): Terminate
739 g_object_[dis]connect() calls with NULL instead of 0.
742 2004-04-09 Guntupalli Karunakar <karunakar@freedomink.org>
744 * configure.in: Added "gu" (Gujarati) to ALL_LINGUAS.
746 2004-04-07 Federico Mena Quintero <federico@ximian.com>
750 * gtk/gtkfilesystem.c (gtk_file_system_parse): Ensure that the
751 passed-in 'str' is not NULL.
753 * gtk/gtkfilesystemunix.c (expand_tilde): New helper function;
754 expands "~/" or "~foo/" at the beginning of a filename.
755 (gtk_file_system_unix_parse): Use expand_tilde() before doing
758 * gtk/gtkfilechooserentry.c
759 (gtk_file_chooser_entry_maybe_update_directory): Take in a
760 force_reload argument.
761 (gtk_file_chooser_entry_changed): If gtk_file_system_parse()
762 returns an error, set the file_part_pos to -1.
763 (load_directory_callback): Only populate the model if the
764 file_part_pos is not -1.
766 2004-04-06 Pablo Saratxaga <pablo@mandrakesoft.com>
768 * configure.in: Added Icelandic (is) to ALL_LINGUAS
770 2004-04-05 Federico Mena Quintero <federico@ximian.com>
772 * gtk/gtkfilechooserdefault.c (location_popup_handler): Use a
773 title for SAVE and CREATE_FOLDER modes. Fixes #137272.
775 * gtk/gtkfilesystemunix.c (gtk_file_system_unix_make_path): Look
776 for G_DIR_SEPARATOR in the display_name, and err out if it is
777 present; use the same error message as Nautilus. Fixes #136467.
779 * gtk/gtkfilechooserdefault.c (file_pane_create): Make the
780 new-folder button say "Create Fo_lder" rather than "Create
781 _Folder", so that the mnemonic doesn't conflict with the "Save in
782 _folder" label. Fixes #136975.
784 2004-04-05 Federico Mena Quintero <federico@ximian.com>
786 * gtk/gtkpathbar.c (_gtk_path_bar_set_path): Ref/sink the
787 buttons. Also, free them correctly upon failure. Based on a
788 patch by Morten Welinder, fixes #137956.
790 2004-04-05 Anders Carlsson <andersca@gnome.org>
792 * gdk/gdk.c (gdk_arg_context_parse): Handle '--' correctly.
794 Fri Apr 2 17:57:33 2004 Jonathan Blandford <jrb@redhat.com>
796 * gtk/gtktreeview.c (gtk_tree_view_row_inserted): set the height
797 correctly for fixed height when inserting a node, #138082
799 2004-04-01 Federico Mena Quintero <federico@ximian.com>
803 * gtk/gtkpathbar.h (struct _GtkPathBarClass): Add a
804 "child_is_hidden" boolean argument to the "path-clicked" signal.
806 * gtk/gtkpathbar.c (struct _ButtonData): Added a file_is_hidden
808 (make_directory_button): Take a file_is_hidden argument; put it in
810 (_gtk_path_bar_set_path): See whether each path component path is
812 (gtk_path_bar_class_init): Add the file_is_hidden argument to the
813 "path-clicked" signal.
814 (button_clicked_cb): See if the downwards button represents a
815 hidden file for the file_is_hidden argument in the signal
818 * gtk/gtkmarshalers.list: Added a signal type VOID:POINTER,BOOLEAN.
820 * gtk/gtkfilechooserdefault.c
821 (gtk_file_chooser_default_select_path): If we fail to switch
822 folders, don't try to select the path in the file system model.
823 Also, return the result from _gtk_file_system_model_path_do().
824 (gtk_file_chooser_default_select_path): Turn on show_hidden in the
825 file system model if we are asked to select a hidden file.
826 (path_bar_clicked): Show hidden files based on whether the
827 immediate downwards folder in the path bar is a hidden file
829 (struct _GtkFileChooserDefault): Added fields
830 browse_files_popup_menu and browse_files_popup_menu_hidden_files_item.
831 (create_file_list): Set an object data key of
832 "GtkFileChooserDefault" on the tree view so that we can find the
833 impl from the popup menu callbacks. Also, hook up to the
834 "button-press-event" and "popup-menu" signals in the file list to
835 bring up a popup menu.
836 (list_popup_menu_cb): New callback.
837 (list_button_press_event_cb): New callback.
841 * gtk/gtkfilesystemmodel.c
842 (_gtk_file_system_model_new): Oops, connect_object to
845 2004-03-31 Tor Lillqvist <tml@iki.fi>
847 * configure.in: Move AC_CANONICAL_HOST earlier, before the check
848 for native Win32. (#136559, J. Ali Harlow)
850 * gdk/win32/gdkdrawable-win32.c (draw_arc): Use X11 semantics for
851 angles. Thanks to Tim Newsham.
853 2004-03-29 Federico Mena Quintero <federico@ximian.com>
857 * gtk/gtkfilesystem.h (struct _GtkFileFolderIface): Added slots
858 for an ::is_finished_loading() method and a ::finished_loading()
859 signal at the end of the struct.
861 * gtk/gtkfilesystem.c (gtk_file_folder_base_init): Create the
862 "finished-loading" signal.
863 (gtk_file_folder_is_finished_loading): New function.
865 * gtk/gtkfilesystemunix.c
866 (gtk_file_folder_unix_is_finished_loading): Implement.
868 * gtk/gtkfilesystemmodel.c (struct _GtkFileSystemModelClass): New
869 slot for a "finished-loading" signal.
870 (gtk_file_system_model_class_init): Create the "finished-loading"
872 (struct _GtkFileSystemModel): New field
873 idle_finished_loading_source. We emit the "finished-loading"
874 signal in an idle if the root folder was done loading right in
875 _gtk_file_system_model_new(), so that the caller has a chance to
876 connect to the signal.
877 (_gtk_file_system_model_new): Connect to the normal signals of the
878 folder even if the initial _list_children() fails. Also, see if
879 the folder is finished loading; connect to the "finished-loading"
881 (gtk_file_system_model_finalize): Remove the idle handler.
883 * gtk/gtkfilechooserdefault.c (set_list_model): Set a busy cursor
884 and connect to the model's "finished-loading" signal.
885 (get_toplevel): New helper function.
886 (error_message): Use get_toplevel().
887 (trap_activate_cb): Likewise.
888 (location_popup_handler): Likewise.
889 (set_busy_cursor): New function.
890 (browse_files_model_finished_loading_cb): New callback.
892 2004-03-25 Federico Mena Quintero <federico@ximian.com>
894 * gtk/gtkfilechooserdefault.c (check_preview_change): Just use the
895 file under the cursor; we don't need the logic from
896 GtkFileSelection after all. Fixes #132255.
898 2004-03-25 Federico Mena Quintero <federico@ximian.com>
900 * gtk/gtkfilechooserdefault.c (location_entry_create): Fill the
901 location entry with the display name of the file under the cursor
902 for Open mode, or the typed filename in Save mode.
904 2004-03-24 J. Ali Harlow <ali@juiblex.co.uk>
906 * gtk/gtkfilesystemwin32.c
907 (filename_is_root): Bare drive designators (eg., "c:") are
908 no longer considered as root filenames. Fixed #137942
910 2004-03-24 J. Ali Harlow <ali@juiblex.co.uk>
912 * gtk/gtkfilesystemwin32.c
913 (gtk_file_system_win32_create_folder): Invert test for error in
916 2004-03-24 J. Ali Harlow <ali@juiblex.co.uk>
918 Fixed #138004 using Federico's code from #132327.
920 * gtk/gtkfilesystemwin32.c (struct _GtkFileSystemWin32): Add a
921 folder_hash field to keep a list of live folder objects.
922 (gtk_file_system_win32_init): Create the folder_hash.
923 (gtk_file_system_win32_finalize): Destroy the folder_hash.
924 (gtk_file_system_win32_get_folder): Ref and return an existing
925 folder if we have it around, otherwise return a new folder object.
926 (struct _GtkFileFolderWin32): Add a field for the parent file system.
927 (gtk_file_folder_win32_finalize): Remove the folder from the file
929 (gtk_file_system_win32_create_folder): Emit "files-added" on the
930 newly-created folder's parent. Fixes #138004.
932 2004-03-24 J. Ali Harlow <ali@juiblex.co.uk>
934 * gtk/gtkfilesystemwin32.c
935 (gtk_file_system_win32_get_folder): Test that path is actually
936 a directory and throw error if not. Fixed bug #137950
938 2004-03-22 J. Ali Harlow <ali@juiblex.co.uk>
940 * gtk/gtkfilesystemwin32.c
941 (gtk_file_system_win32_volume_get_display_name): Ignore empty
942 volume labels; assume that GetVolumeInformation would fail if
943 GetVolumeInformationW does; catches a small memory leak;
944 pass the buffer size to GetVolumeInformationW in wide
945 characters instead of bytes. Fixes bug #137543
946 (list_volumes): Cope with the theoretical possibility of
947 more than 26 logical drives. Fixes bug #137940
948 (bookmarks_serialize): Now actually removes bookmarks.
951 2004-03-22 Guntupalli Karunakar <karunakar@freedomink.org>
953 * configure.in: Added "pa" (Punjabi) to ALL_LINGUAS.
955 2004-03-21 Tor Lillqvist <tml@iki.fi>
957 * gtk/gtkfilesystemwin32.c
958 (gtk_file_system_win32_volume_get_base_path): Include the
959 backslash. Otherwise gtk_file_system_win32_path_to_uri() returns
960 NULL for a volume base path, as g_filename_to_uri() requires an
961 absolute path, and just a drive letter and colon isn't. (#137543)
963 2004-03-20 Hans Breuer <hans@breuer.org>
965 * gtk/gtkfilesystemwin32.c : applied the undisputable and
966 required [due to recent gtkfilesystem internal api semantic
967 changes] part of patches to fix bug #137543 (Tor Lillqvist,
970 * gdk/gdkevents-win32.c (handle_configure_event) :
971 (gdk_event_translate), WM_WINDOWPOSCHANGED : initialize
972 GdkWindowObject::x, y with screen coords to make
973 gdk_window_get_position () return the right thing and thus fix
974 drag and drop positioning (e.g. Gimp tabs, fixes bug #137192)
976 2004-03-19 Federico Mena Quintero <federico@ximian.com>
978 * Revert the patch to #137520, as 2.4.1 is for conservative bug
979 fixes only. The patch is attached to the bug report, for
982 2004-03-19 Morten Welinder <terra@gnome.org>
984 * gtk/gtkfilechooserdefault.c
985 (gtk_file_chooser_default_set_current_folder): Test existance of
986 the path after checking for locality, if needed.
988 2004-03-19 Federico Mena Quintero <federico@ximian.com>
992 * gtk/gtkfilesystem.h (struct _GtkFileFolderIface): Added slots
993 for an ::is_finished_loading() method and a ::finished_loading()
994 signal at the end of the struct.
996 * gtk/gtkfilesystem.c (gtk_file_folder_base_init): Create the
997 "finished-loading" signal.
998 (gtk_file_folder_is_finished_loading): New function.
1000 * gtk/gtkfilesystemunix.c
1001 (gtk_file_folder_unix_is_finished_loading): Implement.
1003 * gtk/gtkfilesystemmodel.c (struct _GtkFileSystemModelClass): New
1004 slot for a "finished-loading" signal.
1005 (gtk_file_system_model_class_init): Create the "finished-loading"
1007 (struct _GtkFileSystemModel): New field
1008 idle_finished_loading_source. We emit the "finished-loading"
1009 signal in an idle if the root folder was done loading right in
1010 _gtk_file_system_model_new(), so that the caller has a chance to
1011 connect to the signal.
1012 (_gtk_file_system_model_new): Connect to the normal signals of the
1013 folder even if the initial _list_children() fails. Also, see if
1014 the folder is finished loading; connect to the "finished-loading"
1016 (gtk_file_system_model_finalize): Remove the idle handler.
1018 * gtk/gtkfilechooserdefault.c (set_list_model): Set a busy cursor
1019 and connect to the model's "finished-loading" signal.
1020 (get_toplevel): New helper function.
1021 (error_message): Use get_toplevel().
1022 (trap_activate_cb): Likewise.
1023 (location_popup_handler): Likewise.
1024 (set_busy_cursor): New function.
1025 (browse_files_model_finished_loading_cb): New callback.
1027 Thu Mar 18 12:10:45 2004 Owen Taylor <otaylor@redhat.com>
1029 * gtk/gtktreeitem.c (gtk_tree_item_forall): Include
1030 eventbox for expander. (#137564, reported by
1033 2004-03-18 Guntupalli Karunakar <karunakar@freedomink.org>
1035 * mr.po: Added "mr" for Marathi to ALL_LINGUAS.
1037 2004-03-17 Morten Welinder <terra@gnome.org>
1039 * gtk/gtkfilechooserdefault.c (shortcuts_add_volumes): Free
1040 volumes not actually put into the shortcut list.
1042 * tests/prop-editor.c (object_changed): Plug leak.
1044 * tests/testfilechooser.c (main): Plug some leaks and expose
1047 * tests/prop-editor.c (create_prop_editor): Don't leak the tooltip
1048 object. Fixed #136652.
1050 * gtk/gtkfilechooserdefault.c (check_icon_theme): Do nothing if we
1051 have no screen. Fixes #137260.
1052 (shortcuts_add_bookmark_from_path): Simplify using check_is_folder
1053 thereby fixing leak. Fixes #137259.
1055 * gtk/gtkpathbar.c (gtk_path_bar_forall): Make this work when the
1056 slider buttons have been destroyed.
1057 (gtk_path_bar_remove): Make this work for slider buttons too.
1060 2004-03-15 Morten Welinder <terra@gnome.org>
1062 * gtk/gtkfilechooserdefault.c (shortcuts_add_bookmark_from_path):
1063 Sanitize and plug leak.
1064 (check_icon_theme): Only do something if the widget has a screen.
1066 Wed Mar 17 01:20:28 2004 Matthias Clasen <maclas@gmx.de>
1068 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
1069 Move the repositioning logic from _gtk_entry_completion() popup
1070 over here. Fixes #137355, reported by Niklas Knutsson.