1 2004-05-04 Federico Mena Quintero <federico@ximian.com>
3 Fixes #139562, based on a patch by Christian Neumair.
5 * gtk/gtkfilechooserdefault.c (struct _GtkFileChooserDefault): Add
6 a filter_combo_hbox field to contain the filter combo.
7 (show_filters): Show/hide the filter_combo_hbox.
8 (create_filename_entry_and_filter_combo): Removed.
9 (file_pane_create): Create the filter_combo_hbox here.
11 2004-05-04 Matthias Clasen <mclasen@redhat.com>
13 * modules/input/gtkimcontextxim.c: Fix the recent
14 string_conversion_callback change to work on
15 Solaris. (#141190, Padraig O'Briain)
17 * gtk/gtkselection.c: Disable debug logging again.
19 2004-05-03 Matthias Clasen <mclasen@redhat.com>
21 * gtk/gtkselection.c: Make the chunk size for
22 incremental transfers depend on the maximal request
23 size, capped at 256k. This should allow most selections
24 to be transferred nonincrementally, avoiding many
25 roundtrips and protocol overhead.
27 2004-05-03 Federico Mena Quintero <federico@ximian.com>
29 * gtk/gtkuimanager.c (gtk_ui_manager_class_init): Call
30 g_signal_new() correctly and initialize the signal fields. Fixes
31 #141749; patch based on Michael Natterer's.
33 u2004-05-03 Matthias Clasen <mclasen@redhat.com>
35 * gtk/gtkselection.c (_gtk_selection_request): Fix
36 a debug message to show correct information.
37 (_gtk_selection_incr_event): Make INCRemental transfer
38 of MULTIPLE targets work. This was broken since 1997!
40 2004-05-02 Hans Breuer <hans@breuer.org>
42 * gdk/win32/gdkdrawable-win32.c (draw_segments) : don't
43 modify the passed in GdkSegment(s) in place, we may get
44 them again to draw at the same place. Fixes bug #129095,
46 (draw_segments) draw the end pixel again to get the
47 pixmap mask right, fixes bug #126710, #130202
49 * gdk/win32/gdkwindow-win32.c : use SetForegroundWindow,
50 fixes bug #106013, John Ehresman
52 * gtk/makefile.msc.in : don't try to link gtk.res but
53 use gtk-win32.res (as supposed to be fixed below :)
55 2004-05-01 Hans Breuer <hans@breuer.org>
57 * tests/Makefile.am : tests/makefile.msc is in CVS for
58 a long time, finally added to EXTRA_DIST : fixes bug
59 #141334, John Ehresman
61 2004-04-30 Matthias Clasen <mclasen@redhat.com>
63 * === Released 2.4.1 ===
65 * configure.in: Version 2.4.1, interface age 1.
69 2004-04-29 Federico Mena Quintero <federico@ximian.com>
73 * gtk/gtkfilechooserdefault.c (remove_selected_bookmarks): New
74 function; moved the code over from
75 remove_bookmark_button_clicked_cb().
76 (remove_selected_bookmarks): Now, getting a non-removable bookmark
77 is not an error, as we may be called as a result of hitting the
79 (shortcuts_key_press_event_cb): New handler; delete the bookmark
80 if the user presses Backspace, Delete, or KP_Delete.
82 2004-04-29 Matthias Clasen <mclasen@redhat.com>
84 * gtk/gtkaction.c (closure_accel_activate): Use
85 _gtk_action_emit_activate() instead of directly
86 emitting the activate signal. (#141429, Jody Goldberg)
88 * gtk/gtkactiongroup.c (gtk_action_group_add_action_with_accel):
89 Warn people when the accelerator can not be
90 parsed. (#141429, Jody Goldberg)
92 2004-04-29 Matthias Clasen <mclasen@redhat.com>
94 * tests/testentrycompletion.c (main): Add a missing
95 cat. (#141070, Chris Sherlock)
97 * gtk/gtkrc.c (gtk_rc_check_pixmap_dir): Remove unused
98 variable. (#141022, Chris Sherlock)
100 * gtk/gtkcombo.c (gtk_combo_popup_list): Add a missing
101 cast. (#141013, Chris Sherlock)
103 * gtk/gtkcellview.c (gtk_cell_view_cell_layout_clear): Remove
104 unused variable. (#141011, Chris Sherlock)
106 2004-04-29 Tor Lillqvist <tml@iki.fi>
108 * gdk/win32/gdkgc-win32.c (gdk_win32_gc_set_dashes): Plug memory
109 leak. (#140775, John Ehresman)
111 Thu Apr 29 01:09:50 2004 Matthias Clasen <maclas@gmx.de>
113 * gdk/gdkdraw.c (_gdk_drawable_get_scratch_gc): Use depth - 1
114 to index the cached gcs, not depth. (#139494)
116 2004-04-28 Matthias Clasen <mclasen@redhat.com>
118 * gdk/gdkdraw.c (_gdk_drawable_get_scratch_gc): Docs typo fix.
120 Sun Apr 25 15:36:02 2004 Soeren Sandmann <sandmann@daimi.au.dk>
122 * gtk/gtktoolbutton.c (gtk_tool_button_set_label_widget): Fix
123 cut'n'paste-o from previous commit. (#141046, Torsten Schoenfeld).
125 2004-04-24 Theppitak Karoonboonyanan <thep@linux.thai.net>
127 Patch to add support for string conversion callbacks to
128 GtkIMContextXIM (#101814)
130 * modules/input/gtkimcontextxim.c: Set the string conversion callback
131 if supported by the XIC.
133 (struct _GtkIMContextXIM): Add string_conversion_callback member.
135 (struct _GtkXIMInfo, setup_im): Check and keep flag inidicating
136 whether string conversion callback is supported.
138 (gtk_im_context_get_ic, +set_string_conversion_callback,
139 +string_conversion_callback): Also initialize string conversion
140 callback, if supported, along with the IC initialization.
142 * modules/input/imxim.c: Make "xim" module default for Thai as well.
144 2004-04-23 Matthias Clasen <mclasen@redhat.com>
146 * gtk/gtkclipboard.c (gtk_clipboard_wait_for_targets): Correctly
147 initialize targets. (#139883, John Finlay)
149 * gdk/gdkdraw.c (gdk_draw_drawable): Small doc improvement.
151 * gtk/gtktreeselection.c (gtk_tree_selection_get_selected_rows):
152 Don't recommend gtk_tree_row_reference_new_proxy(). (#138309,
155 * gtk/gtktreeviewcolumn.c (gtk_tree_view_column_cell_set_cell_data):
156 Remove an excessive g_return_if_fail().
158 * gdk/x11/gdkevents-x11.c (set_user_time): Make set_user_time()
160 * gdk/x11/gdkinput-x11.c (_gdk_input_common_other_event):
161 _-prefix calls of gdk_x11_window_set_user_time().
163 2004-04-22 Matthias Clasen <mclasen@redhat.com>
165 * gtk/gtkuimanager.c (update_node): Make sure the separators
166 used to demarkate placeholder ends don't show up on
167 show_all(). (#140496, Murray Cumming)
169 * gtk/gtkspinbutton.c (spin_button_at_limit): Make spinbuttons
170 work with negative increments. (#137975, Tim Gerla)
172 Wed Apr 21 21:38:03 2004 Soeren Sandmann <sandmann@daimi.au.dk>
174 * gtk/gtktoolbutton.c (gtk_tool_button_set_label_widget,
175 gtk_tool_button_set_icon_widget): Remove the old widget from the
176 tool button before overwriting it with the new widget.
178 (#140508, Todd Goyen)
180 2004-04-22 Tor Lillqvist <tml@iki.fi>
182 Fix the file chooser on Windows. I can't make it misbehave or
183 crash any more now. But presumably there are still corner cases
184 not handled. I haven't really checked behaviour of UNC paths, for
187 * gtk/gtkfilesystemwin32.c: Accept both backslash and slash in
188 several places. Use G_IS_DIR_SEPARATOR macro (which could be added
191 (gtk_file_system_win32_get_parent): Like the Unix version, assert
192 filename is absolute, and avoid one unnecessary string allocation
195 (canonicalize_filename,gtk_file_system_win32_parse): Handle drive
196 letters more correctly.
198 (gtk_file_system_win32_render_icon): Assure correct syntax is used
199 for root folder of a drive. (#137962, Morten Welinder)
201 (filename_is_some_root): New function that accepts also root
202 without any drive specified.
204 (filename_is_drive_root): Rename from filename_is_root.
206 * gtk/gtkfilechooserentry.c (completion_match_func): Casefold on
209 2004-04-21 Matthias Clasen <mclasen@redhat.com>
211 * gtk/gtkentry.c (gtk_entry_completion_timeout): Pop down the
212 completion window if there are no completions anymore.
214 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
215 Don't call gtk_tree_view_scroll_to_cell() on an empty tree view.
216 It doesn't like that. (#140642, Christian Persch)
218 * demos/gtk-demo/expander.c (do_expander): A new demo.
220 * demos/gtk-demo/Makefile.am (demos): Add expander.c.
222 2004-04-20 Matthias Clasen <mclasen@redhat.com>
224 * gtk/gtktextview.c (gtk_text_view_allocate_children): Make
225 sure anchored children get size allocated, even if the layout
226 is valid. (#122323, Andrew E. Makeev)
227 (gtk_text_view_scroll_pages):
228 (gtk_text_view_scroll_hpages): Don't scroll to cursor position
229 if we already have pending scrolls. Bandaid fix for #78513.
231 Mon Apr 19 17:59:17 2004 Owen Taylor <otaylor@redhat.com>
233 * INSTALL.in: Update libpng and libjpeg URLs, remove
234 note about building without since that's not the normal
237 Sun Apr 11 09:45:11 2004 Owen Taylor <otaylor@redhat.com>
239 * gtk/gtkicontheme.c (load_themes): Fix a couple of typos in
240 handling of SVG/non-SVG unthemed icons.
242 2004-04-19 Morten Welinder <terra@gnome.org>
244 * gtk/gtktoolbar.c (gtk_toolbar_focus): Don't leak list of
247 2004-04-19 Matthias Clasen <mclasen@redhat.com>
249 * gtk/gtktextbtree.c (_gtk_text_line_previous_could_contain_tag):
250 Don't stop the iteration up to the tag_root too
251 early. (#109945, Dongho Shin)
253 Sun Apr 18 17:06:03 2004 Soeren Sandmann <sandmann@daimi.au.dk>
255 * gdk/x11/gdkkeys-x11.c (get_effective_keymap): Make
256 gdk_keymap_translate_keyboard_state() handle NULL
257 keymaps. (#139715, Torsten Schoenfeld).
259 Sun Apr 18 16:59:21 2004 Soeren Sandmann <sandmann@daimi.au.dk>
261 * configure.in: Don't erase GDK_EXTRA_CFLAGS. Fixes bug 139586,
262 reported by Pedro RODRIGUEZ, about compilation problems when
263 Xcursor is installed in a non-standard location.
265 Sun Apr 18 16:15:15 2004 Soeren Sandmann <sandmann@daimi.au.dk>
267 Support for _NET_WM_USER_TIME (bug 115650). Patch by Elijah
270 * gdk/x11/gdkwindow-x11.[ch]: Add new internal function
271 _gdk_x11_set_user_time() to set the _NET_WM_USER_TIME property.
273 * gdk/x11/gdkdisplay-x11.h (struct _GdkDisplayX11): Add user_time field
275 * gdk/x11/gdkdisplay-x11.c: Add _NET_WM_USER_TIME to list of
278 * gdk/x11/gdkinput-x11.c, gdk/x11/gdkevents-x11.c: Set the
279 property on user interaction.
281 2004-04-15 Federico Mena Quintero <federico@ximian.com>
283 * gtk/gtkfilesel.c (open_new_dir): Tell the user to use
284 G_FILENAME_ENCODING, not G_BROKEN_FILENAMES. Fixes #114065.
286 * gtk/gtkfilechooserdefault.c (split_uris): Use a variant of the
287 code from gtkfilesel.c to parse a "text/uri-list" blob. Fixes
290 2004-04-15 Matthias Clasen <mclasen@redhat.com>
292 * gtk/gtkcellrenderer.c (gtk_cell_renderer_class_init):
293 * gtk/gtkbutton.c (gtk_button_class_init): Doc fixes.
295 2004-04-14 Matthias Clasen <mclasen@redhat.com>
299 Make all style properties readonly.
301 2004-04-14 Matthias Clasen <mclasen@redhat.com>
303 * gtk/gtkcolorsel.c: Add a11y relations between the color
304 wheel and the spin buttons. (#132745, Padraig O'Briain)
306 * gtk/gtkiconfactory.c (gtk_icon_set_render_icon): Document
307 the meaning of size == -1.
309 * gtk/gtkwidget.c (gtk_widget_render_icon): Explicitly accept
310 a size of -1. (#137436, Brian Cameron)
312 * gtk/gtkcombobox.c: Make the arrow and separator regular
313 children of an hbox inside the button, and propagate state
314 changes from the button to the cell view. (part of the fix
315 for #138650, should also fix #137535)
317 * gtk/gtkcellview.c (gtk_cell_view_expose): Pass the PRELIT
318 state to gtk_cell_renderer_render() when prelighted. (part
319 of the fix for #138650)
321 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_render):
322 Use PRELIGHT state when appropriate. (part of the fix for
325 * gtk/gtkcombobox.c (gtk_combo_box_relayout): Don't spit
326 out warnings if called before the combo box is
327 realized. (#139742, Philip Langdale)
329 Wed Apr 14 03:45:39 2004 Jonathan Blandford <jrb@gnome.org>
331 * gtk/gtktreeview.c (gtk_tree_view_expose): propagate expose
334 Wed Apr 14 03:32:58 2004 Jonathan Blandford <jrb@gnome.org>
336 * gtk/gtkpathbar.c (make_directory_button): remove spurious
339 Tue Apr 13 16:19:23 2004 Jonathan Blandford <jrb@redhat.com>
341 * gtk/gtkpathbar.c (make_directory_button): patch from Owen to
342 make the buttons sized by a bold label. This makes the text
343 'swim' a little, but stops the buttons from resizing, #137210
345 2004-04-13 Matthias Clasen <mclasen@redhat.com>
347 * gtk/gtkuimanager.c (get_child_node): Don't crash if a node
349 (start_element_handler): Accept separators without unique
350 names. (#133302, Anders Carlsson)
352 * gtk/gtkactiongroup.c (gtk_action_group_add_action): Document
353 possible accelerator gotcha when using this function. (#139641,
356 * gtk/gtkuimanager.c (node_remove_ui_reference): Don't leak
357 list nodes. (#138862, Morten Welinder)
359 Tue Apr 13 12:24:49 2004 Jonathan Blandford <jrb@redhat.com>
361 * gtk/gtktreeview.c (gtk_tree_view_destroy): remove unused
363 (gtk_tree_view_button_press): If we activated the row we don't
364 want to grab focus back, as moving focus to another widget is
365 pretty common, #138458
367 2004-04-12 Federico Mena Quintero <federico@ximian.com>
369 * gtk/gtkfilechooser.c (gtk_file_chooser_class_init): Added
370 documentation to all the signals.
372 2004-04-12 Matthias Clasen <mclasen@dhcp64-228.boston.redhat.com>
374 * gtk/gtkcombobox.c (gtk_combo_box_unset_model): Don't unref
375 model if it is NULL. (#139770)
377 * gtk/gtktreeview.c (gtk_tree_view_get_cell_area): Typo fix.
379 * gtk/gtkentrycompletion.c (gtk_entry_completion_init): Don't add
380 a shadow inside the scrolled window, add it around the vbox.
382 * gtk/gtkentryprivate.h:
383 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
384 Return a boolean indicating whether the popup is positioned above
385 or below. Scroll the completions to the beginning or the end,
386 depending on the positioning.
388 * gtk/gtkentry.c (gtk_entry_completion_key_press): Make keynav
389 wrap around in the entry completion popup, and allow GDK_UP to
390 enter the popup. (#137440)
392 2004-04-12 Matthias Clasen <mclasen@redhat.com>
394 * gtk/gtkentry.c (gtk_entry_size_request): Make sure the style is
395 there before using it.
397 Sun Apr 11 15:08:45 2004 Jonathan Blandford <jrb@gnome.org>
399 * gtk/gtktreeprivate.h: Moved search entries into priv data.
401 * gtk/gtktreeview.c: Prep for type-ahead support.
403 (gtk_tree_view_destroy): Destroy the search window explicitly.
404 (gtk_tree_view_key_press): Minor change; prep for type-ahead
405 (gtk_tree_view_ensure_interactive_directory): New function
406 (gtk_tree_view_focus_out): Rework to handle new entry life-cycle.
407 (gtk_tree_view_real_start_interactive_search): rework
408 (gtk_tree_view_search_dialog_hide): ditto
409 (gtk_tree_view_search_delete_event): ditto
410 (gtk_tree_view_search_button_press_event): ditto
411 (gtk_tree_view_search_key_press_event): ditto
412 (gtk_tree_view_search_move): ditto
413 (gtk_tree_view_search_init): ditto
415 * gtk/gtktreeviewcolumn.c:
416 (gtk_tree_view_column_cell_layout_clear): remove unused variable.
418 * tests/testfilechooser.c: (main): change
420 2004-04-11 Hans Breuer <hans@breuer.org>
422 * gdk/win32/gdkspawn-win32.c : workaround for bug #137496,
423 the real fix would involve just another small API breakage,
424 i.e. gdk_spawn_* using GPid not just gint.
426 * gtk/makefile.msc.in : build gtk-win32.res, not gtk.res
428 2004-04-10 Tor Lillqvist <tml@iki.fi>
430 * gdk/win32/gdkkeys-win32.c (gdk_keymap_translate_keyboard_state):
431 If both Shift and CapsLock pressed, ignore the shift only for
432 letters (that would have been affected by the CapsLock). (#139095)
434 * gdk/win32/gdkglobals-win32.c: Disable tablet support by default,
435 seems to be even buggier now than it used to be. (#138341)
436 Initialize _gdk_input_ignore_wintab to TRUE.
438 * gdk/win32/gdkmain-win32.c: Add --use-wintab switch and
439 GDK_USE_WINTAB environment variable to turn on tablet support.
441 2004-04-09 Christian Persch <chpe@cvs.gnome.org>
443 * gtk/gtkuimanager.c: (gtk_ui_manager_insert_action_group),
444 (gtk_ui_manager_remove_action_group): Terminate
445 g_object_[dis]connect() calls with NULL instead of 0.
448 2004-04-09 Guntupalli Karunakar <karunakar@freedomink.org>
450 * configure.in: Added "gu" (Gujarati) to ALL_LINGUAS.
452 2004-04-07 Federico Mena Quintero <federico@ximian.com>
456 * gtk/gtkfilesystem.c (gtk_file_system_parse): Ensure that the
457 passed-in 'str' is not NULL.
459 * gtk/gtkfilesystemunix.c (expand_tilde): New helper function;
460 expands "~/" or "~foo/" at the beginning of a filename.
461 (gtk_file_system_unix_parse): Use expand_tilde() before doing
464 * gtk/gtkfilechooserentry.c
465 (gtk_file_chooser_entry_maybe_update_directory): Take in a
466 force_reload argument.
467 (gtk_file_chooser_entry_changed): If gtk_file_system_parse()
468 returns an error, set the file_part_pos to -1.
469 (load_directory_callback): Only populate the model if the
470 file_part_pos is not -1.
472 2004-04-06 Pablo Saratxaga <pablo@mandrakesoft.com>
474 * configure.in: Added Icelandic (is) to ALL_LINGUAS
476 2004-04-05 Federico Mena Quintero <federico@ximian.com>
478 * gtk/gtkfilechooserdefault.c (location_popup_handler): Use a
479 title for SAVE and CREATE_FOLDER modes. Fixes #137272.
481 * gtk/gtkfilesystemunix.c (gtk_file_system_unix_make_path): Look
482 for G_DIR_SEPARATOR in the display_name, and err out if it is
483 present; use the same error message as Nautilus. Fixes #136467.
485 * gtk/gtkfilechooserdefault.c (file_pane_create): Make the
486 new-folder button say "Create Fo_lder" rather than "Create
487 _Folder", so that the mnemonic doesn't conflict with the "Save in
488 _folder" label. Fixes #136975.
490 2004-04-05 Federico Mena Quintero <federico@ximian.com>
492 * gtk/gtkpathbar.c (_gtk_path_bar_set_path): Ref/sink the
493 buttons. Also, free them correctly upon failure. Based on a
494 patch by Morten Welinder, fixes #137956.
496 2004-04-05 Anders Carlsson <andersca@gnome.org>
498 * gdk/gdk.c (gdk_arg_context_parse): Handle '--' correctly.
500 Fri Apr 2 17:57:33 2004 Jonathan Blandford <jrb@redhat.com>
502 * gtk/gtktreeview.c (gtk_tree_view_row_inserted): set the height
503 correctly for fixed height when inserting a node, #138082
505 2004-04-01 Federico Mena Quintero <federico@ximian.com>
509 * gtk/gtkpathbar.h (struct _GtkPathBarClass): Add a
510 "child_is_hidden" boolean argument to the "path-clicked" signal.
512 * gtk/gtkpathbar.c (struct _ButtonData): Added a file_is_hidden
514 (make_directory_button): Take a file_is_hidden argument; put it in
516 (_gtk_path_bar_set_path): See whether each path component path is
518 (gtk_path_bar_class_init): Add the file_is_hidden argument to the
519 "path-clicked" signal.
520 (button_clicked_cb): See if the downwards button represents a
521 hidden file for the file_is_hidden argument in the signal
524 * gtk/gtkmarshalers.list: Added a signal type VOID:POINTER,BOOLEAN.
526 * gtk/gtkfilechooserdefault.c
527 (gtk_file_chooser_default_select_path): If we fail to switch
528 folders, don't try to select the path in the file system model.
529 Also, return the result from _gtk_file_system_model_path_do().
530 (gtk_file_chooser_default_select_path): Turn on show_hidden in the
531 file system model if we are asked to select a hidden file.
532 (path_bar_clicked): Show hidden files based on whether the
533 immediate downwards folder in the path bar is a hidden file
535 (struct _GtkFileChooserDefault): Added fields
536 browse_files_popup_menu and browse_files_popup_menu_hidden_files_item.
537 (create_file_list): Set an object data key of
538 "GtkFileChooserDefault" on the tree view so that we can find the
539 impl from the popup menu callbacks. Also, hook up to the
540 "button-press-event" and "popup-menu" signals in the file list to
541 bring up a popup menu.
542 (list_popup_menu_cb): New callback.
543 (list_button_press_event_cb): New callback.
547 * gtk/gtkfilesystemmodel.c
548 (_gtk_file_system_model_new): Oops, connect_object to
551 2004-03-31 Tor Lillqvist <tml@iki.fi>
553 * configure.in: Move AC_CANONICAL_HOST earlier, before the check
554 for native Win32. (#136559, J. Ali Harlow)
556 * gdk/win32/gdkdrawable-win32.c (draw_arc): Use X11 semantics for
557 angles. Thanks to Tim Newsham.
559 2004-03-29 Federico Mena Quintero <federico@ximian.com>
563 * gtk/gtkfilesystem.h (struct _GtkFileFolderIface): Added slots
564 for an ::is_finished_loading() method and a ::finished_loading()
565 signal at the end of the struct.
567 * gtk/gtkfilesystem.c (gtk_file_folder_base_init): Create the
568 "finished-loading" signal.
569 (gtk_file_folder_is_finished_loading): New function.
571 * gtk/gtkfilesystemunix.c
572 (gtk_file_folder_unix_is_finished_loading): Implement.
574 * gtk/gtkfilesystemmodel.c (struct _GtkFileSystemModelClass): New
575 slot for a "finished-loading" signal.
576 (gtk_file_system_model_class_init): Create the "finished-loading"
578 (struct _GtkFileSystemModel): New field
579 idle_finished_loading_source. We emit the "finished-loading"
580 signal in an idle if the root folder was done loading right in
581 _gtk_file_system_model_new(), so that the caller has a chance to
582 connect to the signal.
583 (_gtk_file_system_model_new): Connect to the normal signals of the
584 folder even if the initial _list_children() fails. Also, see if
585 the folder is finished loading; connect to the "finished-loading"
587 (gtk_file_system_model_finalize): Remove the idle handler.
589 * gtk/gtkfilechooserdefault.c (set_list_model): Set a busy cursor
590 and connect to the model's "finished-loading" signal.
591 (get_toplevel): New helper function.
592 (error_message): Use get_toplevel().
593 (trap_activate_cb): Likewise.
594 (location_popup_handler): Likewise.
595 (set_busy_cursor): New function.
596 (browse_files_model_finished_loading_cb): New callback.
598 2004-03-25 Federico Mena Quintero <federico@ximian.com>
600 * gtk/gtkfilechooserdefault.c (check_preview_change): Just use the
601 file under the cursor; we don't need the logic from
602 GtkFileSelection after all. Fixes #132255.
604 2004-03-25 Federico Mena Quintero <federico@ximian.com>
606 * gtk/gtkfilechooserdefault.c (location_entry_create): Fill the
607 location entry with the display name of the file under the cursor
608 for Open mode, or the typed filename in Save mode.
610 2004-03-24 J. Ali Harlow <ali@juiblex.co.uk>
612 * gtk/gtkfilesystemwin32.c
613 (filename_is_root): Bare drive designators (eg., "c:") are
614 no longer considered as root filenames. Fixed #137942
616 2004-03-24 J. Ali Harlow <ali@juiblex.co.uk>
618 * gtk/gtkfilesystemwin32.c
619 (gtk_file_system_win32_create_folder): Invert test for error in
622 2004-03-24 J. Ali Harlow <ali@juiblex.co.uk>
624 Fixed #138004 using Federico's code from #132327.
626 * gtk/gtkfilesystemwin32.c (struct _GtkFileSystemWin32): Add a
627 folder_hash field to keep a list of live folder objects.
628 (gtk_file_system_win32_init): Create the folder_hash.
629 (gtk_file_system_win32_finalize): Destroy the folder_hash.
630 (gtk_file_system_win32_get_folder): Ref and return an existing
631 folder if we have it around, otherwise return a new folder object.
632 (struct _GtkFileFolderWin32): Add a field for the parent file system.
633 (gtk_file_folder_win32_finalize): Remove the folder from the file
635 (gtk_file_system_win32_create_folder): Emit "files-added" on the
636 newly-created folder's parent. Fixes #138004.
638 2004-03-24 J. Ali Harlow <ali@juiblex.co.uk>
640 * gtk/gtkfilesystemwin32.c
641 (gtk_file_system_win32_get_folder): Test that path is actually
642 a directory and throw error if not. Fixed bug #137950
644 2004-03-22 J. Ali Harlow <ali@juiblex.co.uk>
646 * gtk/gtkfilesystemwin32.c
647 (gtk_file_system_win32_volume_get_display_name): Ignore empty
648 volume labels; assume that GetVolumeInformation would fail if
649 GetVolumeInformationW does; catches a small memory leak;
650 pass the buffer size to GetVolumeInformationW in wide
651 characters instead of bytes. Fixes bug #137543
652 (list_volumes): Cope with the theoretical possibility of
653 more than 26 logical drives. Fixes bug #137940
654 (bookmarks_serialize): Now actually removes bookmarks.
657 2004-03-22 Guntupalli Karunakar <karunakar@freedomink.org>
659 * configure.in: Added "pa" (Punjabi) to ALL_LINGUAS.
661 2004-03-21 Tor Lillqvist <tml@iki.fi>
663 * gtk/gtkfilesystemwin32.c
664 (gtk_file_system_win32_volume_get_base_path): Include the
665 backslash. Otherwise gtk_file_system_win32_path_to_uri() returns
666 NULL for a volume base path, as g_filename_to_uri() requires an
667 absolute path, and just a drive letter and colon isn't. (#137543)
669 2004-03-20 Hans Breuer <hans@breuer.org>
671 * gtk/gtkfilesystemwin32.c : applied the undisputable and
672 required [due to recent gtkfilesystem internal api semantic
673 changes] part of patches to fix bug #137543 (Tor Lillqvist,
676 * gdk/gdkevents-win32.c (handle_configure_event) :
677 (gdk_event_translate), WM_WINDOWPOSCHANGED : initialize
678 GdkWindowObject::x, y with screen coords to make
679 gdk_window_get_position () return the right thing and thus fix
680 drag and drop positioning (e.g. Gimp tabs, fixes bug #137192)
682 2004-03-19 Federico Mena Quintero <federico@ximian.com>
684 * Revert the patch to #137520, as 2.4.1 is for conservative bug
685 fixes only. The patch is attached to the bug report, for
688 2004-03-19 Morten Welinder <terra@gnome.org>
690 * gtk/gtkfilechooserdefault.c
691 (gtk_file_chooser_default_set_current_folder): Test existance of
692 the path after checking for locality, if needed.
694 2004-03-19 Federico Mena Quintero <federico@ximian.com>
698 * gtk/gtkfilesystem.h (struct _GtkFileFolderIface): Added slots
699 for an ::is_finished_loading() method and a ::finished_loading()
700 signal at the end of the struct.
702 * gtk/gtkfilesystem.c (gtk_file_folder_base_init): Create the
703 "finished-loading" signal.
704 (gtk_file_folder_is_finished_loading): New function.
706 * gtk/gtkfilesystemunix.c
707 (gtk_file_folder_unix_is_finished_loading): Implement.
709 * gtk/gtkfilesystemmodel.c (struct _GtkFileSystemModelClass): New
710 slot for a "finished-loading" signal.
711 (gtk_file_system_model_class_init): Create the "finished-loading"
713 (struct _GtkFileSystemModel): New field
714 idle_finished_loading_source. We emit the "finished-loading"
715 signal in an idle if the root folder was done loading right in
716 _gtk_file_system_model_new(), so that the caller has a chance to
717 connect to the signal.
718 (_gtk_file_system_model_new): Connect to the normal signals of the
719 folder even if the initial _list_children() fails. Also, see if
720 the folder is finished loading; connect to the "finished-loading"
722 (gtk_file_system_model_finalize): Remove the idle handler.
724 * gtk/gtkfilechooserdefault.c (set_list_model): Set a busy cursor
725 and connect to the model's "finished-loading" signal.
726 (get_toplevel): New helper function.
727 (error_message): Use get_toplevel().
728 (trap_activate_cb): Likewise.
729 (location_popup_handler): Likewise.
730 (set_busy_cursor): New function.
731 (browse_files_model_finished_loading_cb): New callback.
733 Thu Mar 18 12:10:45 2004 Owen Taylor <otaylor@redhat.com>
735 * gtk/gtktreeitem.c (gtk_tree_item_forall): Include
736 eventbox for expander. (#137564, reported by
739 2004-03-18 Guntupalli Karunakar <karunakar@freedomink.org>
741 * mr.po: Added "mr" for Marathi to ALL_LINGUAS.
743 2004-03-17 Morten Welinder <terra@gnome.org>
745 * gtk/gtkfilechooserdefault.c (shortcuts_add_volumes): Free
746 volumes not actually put into the shortcut list.
748 * tests/prop-editor.c (object_changed): Plug leak.
750 * tests/testfilechooser.c (main): Plug some leaks and expose
753 * tests/prop-editor.c (create_prop_editor): Don't leak the tooltip
754 object. Fixed #136652.
756 * gtk/gtkfilechooserdefault.c (check_icon_theme): Do nothing if we
757 have no screen. Fixes #137260.
758 (shortcuts_add_bookmark_from_path): Simplify using check_is_folder
759 thereby fixing leak. Fixes #137259.
761 * gtk/gtkpathbar.c (gtk_path_bar_forall): Make this work when the
762 slider buttons have been destroyed.
763 (gtk_path_bar_remove): Make this work for slider buttons too.
766 2004-03-15 Morten Welinder <terra@gnome.org>
768 * gtk/gtkfilechooserdefault.c (shortcuts_add_bookmark_from_path):
769 Sanitize and plug leak.
770 (check_icon_theme): Only do something if the widget has a screen.
772 Wed Mar 17 01:20:28 2004 Matthias Clasen <maclas@gmx.de>
774 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
775 Move the repositioning logic from _gtk_entry_completion() popup
776 over here. Fixes #137355, reported by Niklas Knutsson.