1 Sat May 8 22:50:55 2004 Matthias Clasen <maclas@gmx.de>
3 * gtk/gtkactiongroup.c (gtk_action_group_set_translation_domain):
4 Add a note regarding UTF-8 requirements, proposed by
5 Mariano Suárez-Alvarez.
7 Sat May 8 22:43:11 2004 Matthias Clasen <maclas@gmx.de>
9 * gtk/gtktearoffmenuitem.h:
10 * gtk/gtktearoffmenuitem.c: Put the torn_off flag back
11 into the GtkTearoffMenuItem struct, since it is used
12 by the Gimp, and keep it synchronized with the
13 tearoff_state property of the parent menu.
15 2004-05-07 Matthias Clasen <mclasen@redhat.com>
17 * gtk/gtkbutton.c (gtk_button_size_allocate): Don't let the child
18 draw over the focus rectangle.
20 * gtk/gtkhsv.c: Draw focus indication in the color wheel using
21 standard focus style. (#63071, Bill Haneman, idea for new
24 * gtk/gtkstyle.c (gtk_default_draw_focus): Support drawing on
25 focus on the colorwheel via details.
27 2004-05-06 Matthias Clasen <mclasen@redhat.com>
31 * gtk/gtkcombobox.c (gtk_combo_box_menu_state_changed): Remove
32 this no longer needed signal handler. (#141817, Paul Pogonyshev)
34 Fri May 7 00:41:46 2004 Matthias Clasen <maclas@gmx.de>
36 * gtk/gtktearoffmenuitem.h:
37 * gtk/gtktearoffmenuitem.c: Make the tearoff
38 functionality model/view, the tearoffmenuitem being
39 the view and the tearoff_state property of the menu
40 being the model. (#101185, Owen Taylor)
42 * gtk/gtkmenu.c: Add a tearoff_state property.
44 Thu May 6 23:52:13 2004 Matthias Clasen <maclas@gmx.de>
48 * gtk/gtkmenuitem.c (gtk_menu_item_select_timeout): Also
49 popup the submenu for items in torn off menus. (#122051)
51 2004-05-06 Sven Neumann <sven@gimp.org>
53 * gtk/gtkexpander.c (gtk_expander_size_allocate): in RTL mode,
54 position the title lable next to the arrow just as we do for LTR
55 rendering. Fixes bug #141825.
57 2004-05-06 Matthias Clasen <mclasen@redhat.com>
59 * docs/RELEASE-HOWTO: Document the new policy of
60 bumping version numbers after release.
62 * configure.in: Bump version number to 2.5.0.
64 2004-05-06 Padraig O'Briain <padraig.obriain@sun.com>
67 * gtk/gtkmenu.c: Add new function gtk_menu_get_for_attach_widget.
70 Thu May 6 00:24:11 2004 Matthias Clasen <maclas@gmx.de>
72 * gtk/gtkactiongroup.h:
73 * gtk/gtkactiongroup.c (gtk_action_group_translate_string):
74 New function to translate a string with translate_func.
77 Thu May 6 00:02:21 2004 Matthias Clasen <maclas@gmx.de>
79 * gtk/gtkcombobox.c (gtk_combo_box_get_wrap_width):
80 (gtk_combo_box_get_row_span_column):
81 (gtk_combo_box_get_column_span_column): Add missing getters
82 for readwrite properies. (#135649)
84 Wed May 5 23:42:42 2004 Matthias Clasen <maclas@gmx.de>
87 * gtk/gtkcombobox.c (gtk_combo_box_get_active_text):
88 Add gtk_combo_box_get_active_text() convenience
89 function. (#136372, Christian Neumeir, patch by Olivier Andrieu)
91 2004-05-05 Elijah Newren <newren@math.utah.edu>
93 Changes to support do-not-focus-on-map hint in conjunction with
94 _NET_WM_USER_TIME (#115650):
96 * gdk/gdkwindow.h (struct _GdkWindowObject): Add a new boolean
99 * gdk/gdkwindow.h (gdk_window_set_accept_focus): New function to
102 * gtk/gtkwindow.[hc]: Add a boolean property "focus_on_map"
103 and gtk_window_get_focus_on_map() and gtk_window_set_focus_on_map().
105 * gdk/win32/gdkwindow-win32.c (gdk_window_new):
106 * gdk/linux-fb/gdkwindow-fb.c (gdk_window_new):
107 * gdk/x11/gdkwindow-x11.c (gdk_window_new):
108 Initialize the focus_on_map field to TRUE.
110 * gdk/win32/gdkwindow-win32.c (gdk_window_set_focus_on_map):
111 * gdk/linux-fb/gdkwindow-fb.c (gdk_window_set_focus_on_map):
112 * gdk/x11/gdkwindow-x11.c (gdk_window_set_focus_on_map):
113 * gdk/x11/gdkwindow-x11.c (setup_toplevel_window):
114 Implementations for the various backends. The Win32 and linux-fb
115 implementations set the focus_on_map field, but don't use it yet
116 to actually implement noinput windows. The X implementation sets
117 _NET_WM_USER_TIME to 0 if focus_on_map is FALSE (see the EWMH).
119 * gdk/x11/gdkwindow-x11.h:
120 * gdk/x11/gdkevents-x11.c (set_user_time):
121 * gdk/x11/gdkinput-x11.c (_gdk_input_common_other_event):
122 * gdk/x11/gdkwindow-x11.c (gdk_x11_window_set_user_time):
123 s/_gdk_x11_window_set_user_time/gdk_x11_window_set_user_time/,
124 since we want that function to be part of the public API.
126 Wed May 5 22:20:21 2004 Matthias Clasen <maclas@gmx.de>
130 * gtk/gtkiconfactory.c (icon_source_clear): Don't
131 call g_free() on a pixbuf. (#141961, Crispin Flowerday)
133 2004-05-05 Matthias Clasen <mclasen@redhat.com>
137 * gtk/gtkuimanager.c (print_node): Make the output
138 parseable. (#141929, Sven Neumann)
140 2004-05-05 Tor Lillqvist <tml@iki.fi>
142 * gdk/win32/gdkdnd-win32.c (gdk_drag_find_window_for_screen): Add
143 multi-monitor offset. (#141842, John Ehresman)
145 2004-05-04 Federico Mena Quintero <federico@ximian.com>
147 Fixes #139562, based on a patch by Christian Neumair.
149 * gtk/gtkfilechooserdefault.c (struct _GtkFileChooserDefault): Add
150 a filter_combo_hbox field to contain the filter combo.
151 (show_filters): Show/hide the filter_combo_hbox.
152 (create_filename_entry_and_filter_combo): Removed.
153 (file_pane_create): Create the filter_combo_hbox here.
155 2004-05-04 Matthias Clasen <mclasen@redhat.com>
157 * modules/input/gtkimcontextxim.c: Fix the recent
158 string_conversion_callback change to work on
159 Solaris. (#141190, Padraig O'Briain)
161 * gtk/gtkselection.c: Disable debug logging again.
163 2004-05-03 Matthias Clasen <mclasen@redhat.com>
165 * gtk/gtkselection.c: Make the chunk size for
166 incremental transfers depend on the maximal request
167 size, capped at 256k. This should allow most selections
168 to be transferred nonincrementally, avoiding many
169 roundtrips and protocol overhead.
171 2004-05-03 Federico Mena Quintero <federico@ximian.com>
173 * gtk/gtkuimanager.c (gtk_ui_manager_class_init): Call
174 g_signal_new() correctly and initialize the signal fields. Fixes
175 #141749; patch based on Michael Natterer's.
177 u2004-05-03 Matthias Clasen <mclasen@redhat.com>
179 * gtk/gtkselection.c (_gtk_selection_request): Fix
180 a debug message to show correct information.
181 (_gtk_selection_incr_event): Make INCRemental transfer
182 of MULTIPLE targets work. This was broken since 1997!
184 2004-05-02 Hans Breuer <hans@breuer.org>
186 * gdk/win32/gdkdrawable-win32.c (draw_segments) : don't
187 modify the passed in GdkSegment(s) in place, we may get
188 them again to draw at the same place. Fixes bug #129095,
190 (draw_segments) draw the end pixel again to get the
191 pixmap mask right, fixes bug #126710, #130202
193 * gdk/win32/gdkwindow-win32.c : use SetForegroundWindow,
194 fixes bug #106013, John Ehresman
196 * gtk/makefile.msc.in : don't try to link gtk.res but
197 use gtk-win32.res (as supposed to be fixed below :)
199 2004-05-01 Hans Breuer <hans@breuer.org>
201 * tests/Makefile.am : tests/makefile.msc is in CVS for
202 a long time, finally added to EXTRA_DIST : fixes bug
203 #141334, John Ehresman
205 2004-04-30 Matthias Clasen <mclasen@redhat.com>
207 * === Released 2.4.1 ===
209 * configure.in: Version 2.4.1, interface age 1.
213 2004-04-29 Federico Mena Quintero <federico@ximian.com>
217 * gtk/gtkfilechooserdefault.c (remove_selected_bookmarks): New
218 function; moved the code over from
219 remove_bookmark_button_clicked_cb().
220 (remove_selected_bookmarks): Now, getting a non-removable bookmark
221 is not an error, as we may be called as a result of hitting the
223 (shortcuts_key_press_event_cb): New handler; delete the bookmark
224 if the user presses Backspace, Delete, or KP_Delete.
226 2004-04-29 Matthias Clasen <mclasen@redhat.com>
228 * gtk/gtkaction.c (closure_accel_activate): Use
229 _gtk_action_emit_activate() instead of directly
230 emitting the activate signal. (#141429, Jody Goldberg)
232 * gtk/gtkactiongroup.c (gtk_action_group_add_action_with_accel):
233 Warn people when the accelerator can not be
234 parsed. (#141429, Jody Goldberg)
236 2004-04-29 Matthias Clasen <mclasen@redhat.com>
238 * tests/testentrycompletion.c (main): Add a missing
239 cat. (#141070, Chris Sherlock)
241 * gtk/gtkrc.c (gtk_rc_check_pixmap_dir): Remove unused
242 variable. (#141022, Chris Sherlock)
244 * gtk/gtkcombo.c (gtk_combo_popup_list): Add a missing
245 cast. (#141013, Chris Sherlock)
247 * gtk/gtkcellview.c (gtk_cell_view_cell_layout_clear): Remove
248 unused variable. (#141011, Chris Sherlock)
250 2004-04-29 Tor Lillqvist <tml@iki.fi>
252 * gdk/win32/gdkgc-win32.c (gdk_win32_gc_set_dashes): Plug memory
253 leak. (#140775, John Ehresman)
255 Thu Apr 29 01:09:50 2004 Matthias Clasen <maclas@gmx.de>
257 * gdk/gdkdraw.c (_gdk_drawable_get_scratch_gc): Use depth - 1
258 to index the cached gcs, not depth. (#139494)
260 2004-04-28 Matthias Clasen <mclasen@redhat.com>
262 * gdk/gdkdraw.c (_gdk_drawable_get_scratch_gc): Docs typo fix.
264 Sun Apr 25 15:36:02 2004 Soeren Sandmann <sandmann@daimi.au.dk>
266 * gtk/gtktoolbutton.c (gtk_tool_button_set_label_widget): Fix
267 cut'n'paste-o from previous commit. (#141046, Torsten Schoenfeld).
269 2004-04-24 Theppitak Karoonboonyanan <thep@linux.thai.net>
271 Patch to add support for string conversion callbacks to
272 GtkIMContextXIM (#101814)
274 * modules/input/gtkimcontextxim.c: Set the string conversion callback
275 if supported by the XIC.
277 (struct _GtkIMContextXIM): Add string_conversion_callback member.
279 (struct _GtkXIMInfo, setup_im): Check and keep flag inidicating
280 whether string conversion callback is supported.
282 (gtk_im_context_get_ic, +set_string_conversion_callback,
283 +string_conversion_callback): Also initialize string conversion
284 callback, if supported, along with the IC initialization.
286 * modules/input/imxim.c: Make "xim" module default for Thai as well.
288 2004-04-23 Matthias Clasen <mclasen@redhat.com>
290 * gtk/gtkclipboard.c (gtk_clipboard_wait_for_targets): Correctly
291 initialize targets. (#139883, John Finlay)
293 * gdk/gdkdraw.c (gdk_draw_drawable): Small doc improvement.
295 * gtk/gtktreeselection.c (gtk_tree_selection_get_selected_rows):
296 Don't recommend gtk_tree_row_reference_new_proxy(). (#138309,
299 * gtk/gtktreeviewcolumn.c (gtk_tree_view_column_cell_set_cell_data):
300 Remove an excessive g_return_if_fail().
302 * gdk/x11/gdkevents-x11.c (set_user_time): Make set_user_time()
304 * gdk/x11/gdkinput-x11.c (_gdk_input_common_other_event):
305 _-prefix calls of gdk_x11_window_set_user_time().
307 2004-04-22 Matthias Clasen <mclasen@redhat.com>
309 * gtk/gtkuimanager.c (update_node): Make sure the separators
310 used to demarkate placeholder ends don't show up on
311 show_all(). (#140496, Murray Cumming)
313 * gtk/gtkspinbutton.c (spin_button_at_limit): Make spinbuttons
314 work with negative increments. (#137975, Tim Gerla)
316 Wed Apr 21 21:38:03 2004 Soeren Sandmann <sandmann@daimi.au.dk>
318 * gtk/gtktoolbutton.c (gtk_tool_button_set_label_widget,
319 gtk_tool_button_set_icon_widget): Remove the old widget from the
320 tool button before overwriting it with the new widget.
322 (#140508, Todd Goyen)
324 2004-04-22 Tor Lillqvist <tml@iki.fi>
326 Fix the file chooser on Windows. I can't make it misbehave or
327 crash any more now. But presumably there are still corner cases
328 not handled. I haven't really checked behaviour of UNC paths, for
331 * gtk/gtkfilesystemwin32.c: Accept both backslash and slash in
332 several places. Use G_IS_DIR_SEPARATOR macro (which could be added
335 (gtk_file_system_win32_get_parent): Like the Unix version, assert
336 filename is absolute, and avoid one unnecessary string allocation
339 (canonicalize_filename,gtk_file_system_win32_parse): Handle drive
340 letters more correctly.
342 (gtk_file_system_win32_render_icon): Assure correct syntax is used
343 for root folder of a drive. (#137962, Morten Welinder)
345 (filename_is_some_root): New function that accepts also root
346 without any drive specified.
348 (filename_is_drive_root): Rename from filename_is_root.
350 * gtk/gtkfilechooserentry.c (completion_match_func): Casefold on
353 2004-04-21 Matthias Clasen <mclasen@redhat.com>
355 * gtk/gtkentry.c (gtk_entry_completion_timeout): Pop down the
356 completion window if there are no completions anymore.
358 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
359 Don't call gtk_tree_view_scroll_to_cell() on an empty tree view.
360 It doesn't like that. (#140642, Christian Persch)
362 * demos/gtk-demo/expander.c (do_expander): A new demo.
364 * demos/gtk-demo/Makefile.am (demos): Add expander.c.
366 2004-04-20 Matthias Clasen <mclasen@redhat.com>
368 * gtk/gtktextview.c (gtk_text_view_allocate_children): Make
369 sure anchored children get size allocated, even if the layout
370 is valid. (#122323, Andrew E. Makeev)
371 (gtk_text_view_scroll_pages):
372 (gtk_text_view_scroll_hpages): Don't scroll to cursor position
373 if we already have pending scrolls. Bandaid fix for #78513.
375 Mon Apr 19 17:59:17 2004 Owen Taylor <otaylor@redhat.com>
377 * INSTALL.in: Update libpng and libjpeg URLs, remove
378 note about building without since that's not the normal
381 Sun Apr 11 09:45:11 2004 Owen Taylor <otaylor@redhat.com>
383 * gtk/gtkicontheme.c (load_themes): Fix a couple of typos in
384 handling of SVG/non-SVG unthemed icons.
386 2004-04-19 Morten Welinder <terra@gnome.org>
388 * gtk/gtktoolbar.c (gtk_toolbar_focus): Don't leak list of
391 2004-04-19 Matthias Clasen <mclasen@redhat.com>
393 * gtk/gtktextbtree.c (_gtk_text_line_previous_could_contain_tag):
394 Don't stop the iteration up to the tag_root too
395 early. (#109945, Dongho Shin)
397 Sun Apr 18 17:06:03 2004 Soeren Sandmann <sandmann@daimi.au.dk>
399 * gdk/x11/gdkkeys-x11.c (get_effective_keymap): Make
400 gdk_keymap_translate_keyboard_state() handle NULL
401 keymaps. (#139715, Torsten Schoenfeld).
403 Sun Apr 18 16:59:21 2004 Soeren Sandmann <sandmann@daimi.au.dk>
405 * configure.in: Don't erase GDK_EXTRA_CFLAGS. Fixes bug 139586,
406 reported by Pedro RODRIGUEZ, about compilation problems when
407 Xcursor is installed in a non-standard location.
409 Sun Apr 18 16:15:15 2004 Soeren Sandmann <sandmann@daimi.au.dk>
411 Support for _NET_WM_USER_TIME (bug 115650). Patch by Elijah
414 * gdk/x11/gdkwindow-x11.[ch]: Add new internal function
415 _gdk_x11_set_user_time() to set the _NET_WM_USER_TIME property.
417 * gdk/x11/gdkdisplay-x11.h (struct _GdkDisplayX11): Add user_time field
419 * gdk/x11/gdkdisplay-x11.c: Add _NET_WM_USER_TIME to list of
422 * gdk/x11/gdkinput-x11.c, gdk/x11/gdkevents-x11.c: Set the
423 property on user interaction.
425 2004-04-15 Federico Mena Quintero <federico@ximian.com>
427 * gtk/gtkfilesel.c (open_new_dir): Tell the user to use
428 G_FILENAME_ENCODING, not G_BROKEN_FILENAMES. Fixes #114065.
430 * gtk/gtkfilechooserdefault.c (split_uris): Use a variant of the
431 code from gtkfilesel.c to parse a "text/uri-list" blob. Fixes
434 2004-04-15 Matthias Clasen <mclasen@redhat.com>
436 * gtk/gtkcellrenderer.c (gtk_cell_renderer_class_init):
437 * gtk/gtkbutton.c (gtk_button_class_init): Doc fixes.
439 2004-04-14 Matthias Clasen <mclasen@redhat.com>
443 Make all style properties readonly.
445 2004-04-14 Matthias Clasen <mclasen@redhat.com>
447 * gtk/gtkcolorsel.c: Add a11y relations between the color
448 wheel and the spin buttons. (#132745, Padraig O'Briain)
450 * gtk/gtkiconfactory.c (gtk_icon_set_render_icon): Document
451 the meaning of size == -1.
453 * gtk/gtkwidget.c (gtk_widget_render_icon): Explicitly accept
454 a size of -1. (#137436, Brian Cameron)
456 * gtk/gtkcombobox.c: Make the arrow and separator regular
457 children of an hbox inside the button, and propagate state
458 changes from the button to the cell view. (part of the fix
459 for #138650, should also fix #137535)
461 * gtk/gtkcellview.c (gtk_cell_view_expose): Pass the PRELIT
462 state to gtk_cell_renderer_render() when prelighted. (part
463 of the fix for #138650)
465 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_render):
466 Use PRELIGHT state when appropriate. (part of the fix for
469 * gtk/gtkcombobox.c (gtk_combo_box_relayout): Don't spit
470 out warnings if called before the combo box is
471 realized. (#139742, Philip Langdale)
473 Wed Apr 14 03:45:39 2004 Jonathan Blandford <jrb@gnome.org>
475 * gtk/gtktreeview.c (gtk_tree_view_expose): propagate expose
478 Wed Apr 14 03:32:58 2004 Jonathan Blandford <jrb@gnome.org>
480 * gtk/gtkpathbar.c (make_directory_button): remove spurious
483 Tue Apr 13 16:19:23 2004 Jonathan Blandford <jrb@redhat.com>
485 * gtk/gtkpathbar.c (make_directory_button): patch from Owen to
486 make the buttons sized by a bold label. This makes the text
487 'swim' a little, but stops the buttons from resizing, #137210
489 2004-04-13 Matthias Clasen <mclasen@redhat.com>
491 * gtk/gtkuimanager.c (get_child_node): Don't crash if a node
493 (start_element_handler): Accept separators without unique
494 names. (#133302, Anders Carlsson)
496 * gtk/gtkactiongroup.c (gtk_action_group_add_action): Document
497 possible accelerator gotcha when using this function. (#139641,
500 * gtk/gtkuimanager.c (node_remove_ui_reference): Don't leak
501 list nodes. (#138862, Morten Welinder)
503 Tue Apr 13 12:24:49 2004 Jonathan Blandford <jrb@redhat.com>
505 * gtk/gtktreeview.c (gtk_tree_view_destroy): remove unused
507 (gtk_tree_view_button_press): If we activated the row we don't
508 want to grab focus back, as moving focus to another widget is
509 pretty common, #138458
511 2004-04-12 Federico Mena Quintero <federico@ximian.com>
513 * gtk/gtkfilechooser.c (gtk_file_chooser_class_init): Added
514 documentation to all the signals.
516 2004-04-12 Matthias Clasen <mclasen@dhcp64-228.boston.redhat.com>
518 * gtk/gtkcombobox.c (gtk_combo_box_unset_model): Don't unref
519 model if it is NULL. (#139770)
521 * gtk/gtktreeview.c (gtk_tree_view_get_cell_area): Typo fix.
523 * gtk/gtkentrycompletion.c (gtk_entry_completion_init): Don't add
524 a shadow inside the scrolled window, add it around the vbox.
526 * gtk/gtkentryprivate.h:
527 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
528 Return a boolean indicating whether the popup is positioned above
529 or below. Scroll the completions to the beginning or the end,
530 depending on the positioning.
532 * gtk/gtkentry.c (gtk_entry_completion_key_press): Make keynav
533 wrap around in the entry completion popup, and allow GDK_UP to
534 enter the popup. (#137440)
536 2004-04-12 Matthias Clasen <mclasen@redhat.com>
538 * gtk/gtkentry.c (gtk_entry_size_request): Make sure the style is
539 there before using it.
541 Sun Apr 11 15:08:45 2004 Jonathan Blandford <jrb@gnome.org>
543 * gtk/gtktreeprivate.h: Moved search entries into priv data.
545 * gtk/gtktreeview.c: Prep for type-ahead support.
547 (gtk_tree_view_destroy): Destroy the search window explicitly.
548 (gtk_tree_view_key_press): Minor change; prep for type-ahead
549 (gtk_tree_view_ensure_interactive_directory): New function
550 (gtk_tree_view_focus_out): Rework to handle new entry life-cycle.
551 (gtk_tree_view_real_start_interactive_search): rework
552 (gtk_tree_view_search_dialog_hide): ditto
553 (gtk_tree_view_search_delete_event): ditto
554 (gtk_tree_view_search_button_press_event): ditto
555 (gtk_tree_view_search_key_press_event): ditto
556 (gtk_tree_view_search_move): ditto
557 (gtk_tree_view_search_init): ditto
559 * gtk/gtktreeviewcolumn.c:
560 (gtk_tree_view_column_cell_layout_clear): remove unused variable.
562 * tests/testfilechooser.c: (main): change
564 2004-04-11 Hans Breuer <hans@breuer.org>
566 * gdk/win32/gdkspawn-win32.c : workaround for bug #137496,
567 the real fix would involve just another small API breakage,
568 i.e. gdk_spawn_* using GPid not just gint.
570 * gtk/makefile.msc.in : build gtk-win32.res, not gtk.res
572 2004-04-10 Tor Lillqvist <tml@iki.fi>
574 * gdk/win32/gdkkeys-win32.c (gdk_keymap_translate_keyboard_state):
575 If both Shift and CapsLock pressed, ignore the shift only for
576 letters (that would have been affected by the CapsLock). (#139095)
578 * gdk/win32/gdkglobals-win32.c: Disable tablet support by default,
579 seems to be even buggier now than it used to be. (#138341)
580 Initialize _gdk_input_ignore_wintab to TRUE.
582 * gdk/win32/gdkmain-win32.c: Add --use-wintab switch and
583 GDK_USE_WINTAB environment variable to turn on tablet support.
585 2004-04-09 Christian Persch <chpe@cvs.gnome.org>
587 * gtk/gtkuimanager.c: (gtk_ui_manager_insert_action_group),
588 (gtk_ui_manager_remove_action_group): Terminate
589 g_object_[dis]connect() calls with NULL instead of 0.
592 2004-04-09 Guntupalli Karunakar <karunakar@freedomink.org>
594 * configure.in: Added "gu" (Gujarati) to ALL_LINGUAS.
596 2004-04-07 Federico Mena Quintero <federico@ximian.com>
600 * gtk/gtkfilesystem.c (gtk_file_system_parse): Ensure that the
601 passed-in 'str' is not NULL.
603 * gtk/gtkfilesystemunix.c (expand_tilde): New helper function;
604 expands "~/" or "~foo/" at the beginning of a filename.
605 (gtk_file_system_unix_parse): Use expand_tilde() before doing
608 * gtk/gtkfilechooserentry.c
609 (gtk_file_chooser_entry_maybe_update_directory): Take in a
610 force_reload argument.
611 (gtk_file_chooser_entry_changed): If gtk_file_system_parse()
612 returns an error, set the file_part_pos to -1.
613 (load_directory_callback): Only populate the model if the
614 file_part_pos is not -1.
616 2004-04-06 Pablo Saratxaga <pablo@mandrakesoft.com>
618 * configure.in: Added Icelandic (is) to ALL_LINGUAS
620 2004-04-05 Federico Mena Quintero <federico@ximian.com>
622 * gtk/gtkfilechooserdefault.c (location_popup_handler): Use a
623 title for SAVE and CREATE_FOLDER modes. Fixes #137272.
625 * gtk/gtkfilesystemunix.c (gtk_file_system_unix_make_path): Look
626 for G_DIR_SEPARATOR in the display_name, and err out if it is
627 present; use the same error message as Nautilus. Fixes #136467.
629 * gtk/gtkfilechooserdefault.c (file_pane_create): Make the
630 new-folder button say "Create Fo_lder" rather than "Create
631 _Folder", so that the mnemonic doesn't conflict with the "Save in
632 _folder" label. Fixes #136975.
634 2004-04-05 Federico Mena Quintero <federico@ximian.com>
636 * gtk/gtkpathbar.c (_gtk_path_bar_set_path): Ref/sink the
637 buttons. Also, free them correctly upon failure. Based on a
638 patch by Morten Welinder, fixes #137956.
640 2004-04-05 Anders Carlsson <andersca@gnome.org>
642 * gdk/gdk.c (gdk_arg_context_parse): Handle '--' correctly.
644 Fri Apr 2 17:57:33 2004 Jonathan Blandford <jrb@redhat.com>
646 * gtk/gtktreeview.c (gtk_tree_view_row_inserted): set the height
647 correctly for fixed height when inserting a node, #138082
649 2004-04-01 Federico Mena Quintero <federico@ximian.com>
653 * gtk/gtkpathbar.h (struct _GtkPathBarClass): Add a
654 "child_is_hidden" boolean argument to the "path-clicked" signal.
656 * gtk/gtkpathbar.c (struct _ButtonData): Added a file_is_hidden
658 (make_directory_button): Take a file_is_hidden argument; put it in
660 (_gtk_path_bar_set_path): See whether each path component path is
662 (gtk_path_bar_class_init): Add the file_is_hidden argument to the
663 "path-clicked" signal.
664 (button_clicked_cb): See if the downwards button represents a
665 hidden file for the file_is_hidden argument in the signal
668 * gtk/gtkmarshalers.list: Added a signal type VOID:POINTER,BOOLEAN.
670 * gtk/gtkfilechooserdefault.c
671 (gtk_file_chooser_default_select_path): If we fail to switch
672 folders, don't try to select the path in the file system model.
673 Also, return the result from _gtk_file_system_model_path_do().
674 (gtk_file_chooser_default_select_path): Turn on show_hidden in the
675 file system model if we are asked to select a hidden file.
676 (path_bar_clicked): Show hidden files based on whether the
677 immediate downwards folder in the path bar is a hidden file
679 (struct _GtkFileChooserDefault): Added fields
680 browse_files_popup_menu and browse_files_popup_menu_hidden_files_item.
681 (create_file_list): Set an object data key of
682 "GtkFileChooserDefault" on the tree view so that we can find the
683 impl from the popup menu callbacks. Also, hook up to the
684 "button-press-event" and "popup-menu" signals in the file list to
685 bring up a popup menu.
686 (list_popup_menu_cb): New callback.
687 (list_button_press_event_cb): New callback.
691 * gtk/gtkfilesystemmodel.c
692 (_gtk_file_system_model_new): Oops, connect_object to
695 2004-03-31 Tor Lillqvist <tml@iki.fi>
697 * configure.in: Move AC_CANONICAL_HOST earlier, before the check
698 for native Win32. (#136559, J. Ali Harlow)
700 * gdk/win32/gdkdrawable-win32.c (draw_arc): Use X11 semantics for
701 angles. Thanks to Tim Newsham.
703 2004-03-29 Federico Mena Quintero <federico@ximian.com>
707 * gtk/gtkfilesystem.h (struct _GtkFileFolderIface): Added slots
708 for an ::is_finished_loading() method and a ::finished_loading()
709 signal at the end of the struct.
711 * gtk/gtkfilesystem.c (gtk_file_folder_base_init): Create the
712 "finished-loading" signal.
713 (gtk_file_folder_is_finished_loading): New function.
715 * gtk/gtkfilesystemunix.c
716 (gtk_file_folder_unix_is_finished_loading): Implement.
718 * gtk/gtkfilesystemmodel.c (struct _GtkFileSystemModelClass): New
719 slot for a "finished-loading" signal.
720 (gtk_file_system_model_class_init): Create the "finished-loading"
722 (struct _GtkFileSystemModel): New field
723 idle_finished_loading_source. We emit the "finished-loading"
724 signal in an idle if the root folder was done loading right in
725 _gtk_file_system_model_new(), so that the caller has a chance to
726 connect to the signal.
727 (_gtk_file_system_model_new): Connect to the normal signals of the
728 folder even if the initial _list_children() fails. Also, see if
729 the folder is finished loading; connect to the "finished-loading"
731 (gtk_file_system_model_finalize): Remove the idle handler.
733 * gtk/gtkfilechooserdefault.c (set_list_model): Set a busy cursor
734 and connect to the model's "finished-loading" signal.
735 (get_toplevel): New helper function.
736 (error_message): Use get_toplevel().
737 (trap_activate_cb): Likewise.
738 (location_popup_handler): Likewise.
739 (set_busy_cursor): New function.
740 (browse_files_model_finished_loading_cb): New callback.
742 2004-03-25 Federico Mena Quintero <federico@ximian.com>
744 * gtk/gtkfilechooserdefault.c (check_preview_change): Just use the
745 file under the cursor; we don't need the logic from
746 GtkFileSelection after all. Fixes #132255.
748 2004-03-25 Federico Mena Quintero <federico@ximian.com>
750 * gtk/gtkfilechooserdefault.c (location_entry_create): Fill the
751 location entry with the display name of the file under the cursor
752 for Open mode, or the typed filename in Save mode.
754 2004-03-24 J. Ali Harlow <ali@juiblex.co.uk>
756 * gtk/gtkfilesystemwin32.c
757 (filename_is_root): Bare drive designators (eg., "c:") are
758 no longer considered as root filenames. Fixed #137942
760 2004-03-24 J. Ali Harlow <ali@juiblex.co.uk>
762 * gtk/gtkfilesystemwin32.c
763 (gtk_file_system_win32_create_folder): Invert test for error in
766 2004-03-24 J. Ali Harlow <ali@juiblex.co.uk>
768 Fixed #138004 using Federico's code from #132327.
770 * gtk/gtkfilesystemwin32.c (struct _GtkFileSystemWin32): Add a
771 folder_hash field to keep a list of live folder objects.
772 (gtk_file_system_win32_init): Create the folder_hash.
773 (gtk_file_system_win32_finalize): Destroy the folder_hash.
774 (gtk_file_system_win32_get_folder): Ref and return an existing
775 folder if we have it around, otherwise return a new folder object.
776 (struct _GtkFileFolderWin32): Add a field for the parent file system.
777 (gtk_file_folder_win32_finalize): Remove the folder from the file
779 (gtk_file_system_win32_create_folder): Emit "files-added" on the
780 newly-created folder's parent. Fixes #138004.
782 2004-03-24 J. Ali Harlow <ali@juiblex.co.uk>
784 * gtk/gtkfilesystemwin32.c
785 (gtk_file_system_win32_get_folder): Test that path is actually
786 a directory and throw error if not. Fixed bug #137950
788 2004-03-22 J. Ali Harlow <ali@juiblex.co.uk>
790 * gtk/gtkfilesystemwin32.c
791 (gtk_file_system_win32_volume_get_display_name): Ignore empty
792 volume labels; assume that GetVolumeInformation would fail if
793 GetVolumeInformationW does; catches a small memory leak;
794 pass the buffer size to GetVolumeInformationW in wide
795 characters instead of bytes. Fixes bug #137543
796 (list_volumes): Cope with the theoretical possibility of
797 more than 26 logical drives. Fixes bug #137940
798 (bookmarks_serialize): Now actually removes bookmarks.
801 2004-03-22 Guntupalli Karunakar <karunakar@freedomink.org>
803 * configure.in: Added "pa" (Punjabi) to ALL_LINGUAS.
805 2004-03-21 Tor Lillqvist <tml@iki.fi>
807 * gtk/gtkfilesystemwin32.c
808 (gtk_file_system_win32_volume_get_base_path): Include the
809 backslash. Otherwise gtk_file_system_win32_path_to_uri() returns
810 NULL for a volume base path, as g_filename_to_uri() requires an
811 absolute path, and just a drive letter and colon isn't. (#137543)
813 2004-03-20 Hans Breuer <hans@breuer.org>
815 * gtk/gtkfilesystemwin32.c : applied the undisputable and
816 required [due to recent gtkfilesystem internal api semantic
817 changes] part of patches to fix bug #137543 (Tor Lillqvist,
820 * gdk/gdkevents-win32.c (handle_configure_event) :
821 (gdk_event_translate), WM_WINDOWPOSCHANGED : initialize
822 GdkWindowObject::x, y with screen coords to make
823 gdk_window_get_position () return the right thing and thus fix
824 drag and drop positioning (e.g. Gimp tabs, fixes bug #137192)
826 2004-03-19 Federico Mena Quintero <federico@ximian.com>
828 * Revert the patch to #137520, as 2.4.1 is for conservative bug
829 fixes only. The patch is attached to the bug report, for
832 2004-03-19 Morten Welinder <terra@gnome.org>
834 * gtk/gtkfilechooserdefault.c
835 (gtk_file_chooser_default_set_current_folder): Test existance of
836 the path after checking for locality, if needed.
838 2004-03-19 Federico Mena Quintero <federico@ximian.com>
842 * gtk/gtkfilesystem.h (struct _GtkFileFolderIface): Added slots
843 for an ::is_finished_loading() method and a ::finished_loading()
844 signal at the end of the struct.
846 * gtk/gtkfilesystem.c (gtk_file_folder_base_init): Create the
847 "finished-loading" signal.
848 (gtk_file_folder_is_finished_loading): New function.
850 * gtk/gtkfilesystemunix.c
851 (gtk_file_folder_unix_is_finished_loading): Implement.
853 * gtk/gtkfilesystemmodel.c (struct _GtkFileSystemModelClass): New
854 slot for a "finished-loading" signal.
855 (gtk_file_system_model_class_init): Create the "finished-loading"
857 (struct _GtkFileSystemModel): New field
858 idle_finished_loading_source. We emit the "finished-loading"
859 signal in an idle if the root folder was done loading right in
860 _gtk_file_system_model_new(), so that the caller has a chance to
861 connect to the signal.
862 (_gtk_file_system_model_new): Connect to the normal signals of the
863 folder even if the initial _list_children() fails. Also, see if
864 the folder is finished loading; connect to the "finished-loading"
866 (gtk_file_system_model_finalize): Remove the idle handler.
868 * gtk/gtkfilechooserdefault.c (set_list_model): Set a busy cursor
869 and connect to the model's "finished-loading" signal.
870 (get_toplevel): New helper function.
871 (error_message): Use get_toplevel().
872 (trap_activate_cb): Likewise.
873 (location_popup_handler): Likewise.
874 (set_busy_cursor): New function.
875 (browse_files_model_finished_loading_cb): New callback.
877 Thu Mar 18 12:10:45 2004 Owen Taylor <otaylor@redhat.com>
879 * gtk/gtktreeitem.c (gtk_tree_item_forall): Include
880 eventbox for expander. (#137564, reported by
883 2004-03-18 Guntupalli Karunakar <karunakar@freedomink.org>
885 * mr.po: Added "mr" for Marathi to ALL_LINGUAS.
887 2004-03-17 Morten Welinder <terra@gnome.org>
889 * gtk/gtkfilechooserdefault.c (shortcuts_add_volumes): Free
890 volumes not actually put into the shortcut list.
892 * tests/prop-editor.c (object_changed): Plug leak.
894 * tests/testfilechooser.c (main): Plug some leaks and expose
897 * tests/prop-editor.c (create_prop_editor): Don't leak the tooltip
898 object. Fixed #136652.
900 * gtk/gtkfilechooserdefault.c (check_icon_theme): Do nothing if we
901 have no screen. Fixes #137260.
902 (shortcuts_add_bookmark_from_path): Simplify using check_is_folder
903 thereby fixing leak. Fixes #137259.
905 * gtk/gtkpathbar.c (gtk_path_bar_forall): Make this work when the
906 slider buttons have been destroyed.
907 (gtk_path_bar_remove): Make this work for slider buttons too.
910 2004-03-15 Morten Welinder <terra@gnome.org>
912 * gtk/gtkfilechooserdefault.c (shortcuts_add_bookmark_from_path):
913 Sanitize and plug leak.
914 (check_icon_theme): Only do something if the widget has a screen.
916 Wed Mar 17 01:20:28 2004 Matthias Clasen <maclas@gmx.de>
918 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
919 Move the repositioning logic from _gtk_entry_completion() popup
920 over here. Fixes #137355, reported by Niklas Knutsson.