1 Tue May 11 00:38:25 2004 Matthias Clasen <maclas@gmx.de>
3 * gtk/gtkcellrenderertoggle.c (gtk_cell_renderer_toggle_class_init):
4 Document the ::toggled signal.
6 Mon May 10 23:04:25 2004 Soeren Sandmann <sandmann@daimi.au.dk>
8 * gtk/gtkwidget.h: Add prototype for _gtk_widget_grab_notify()
10 2004-05-10 Matthias Clasen <mclasen@redhat.com>
12 * gtk/gtkwindow.c (get_screen_icon_info): Make static.
14 * gdk/gdkdisplay.c (singlehead_...):
15 * gdk/x11/gdkkeys-x11.c (get_effective_keymap):
16 * gdk/x11/gdkgeometry-x11.c (expose_serial_predicate):
17 * gdk/x11/gdkdisplay-x11.c (escape_for_xmessage): Make static.
19 * gtk/gtktreeview.c (gtk_tree_view_set_fixed_height_mode): Add a
20 note about COLUMN_FIXED restriction.
22 * gtk/gtkentrycompletion.c (gtk_entry_completion_list_button_press):
23 Set the entry in the default handler of the ::match-selected signal.
26 * gtk/gtkcombobox.c (gtk_combo_box_menu_position_below): If we don't
27 do the move-selected-item below pointer thingie, do the
28 place-below-or-above one.
30 * tests/testentrycompletion.c: Make the second example use the
31 ::match-selected signal to make it actually work.
33 * gtk/gtkentrycompletion.c (gtk_entry_completion_init):
34 * gtk/gtkcombobox.c (gtk_combo_box_list_setup): Use hover selection
35 mode. (#127648, Dave Bordoley)
38 * gtk/gtktreeview.c: Add a new property "hover_selection", which
39 when TRUE makes the selection follow the mouse. Also add setter
40 and getter for the fixed_height property.
42 2004-05-10 Matthias Clasen <mclasen@redhat.com>
44 * gtk/gtkcombobox.c (gtk_combo_box_popup)
45 (gtk_combo_box_menu_button_press): Make sure the menu pops up
46 as wide as the combobox. (#59660, Havoc Pennington)
48 2004-05-10 Matthias Clasen <mclasen@redhat.com>
51 * gtk/gtkcombobox.c: Support tearoffable combo boxes (in menu
52 mode). Add a new property, add-tearoffs, for this. (#135956)
54 * gtk/gtkfontsel.c (list_row_activated): Make Return activate the
55 default button. (#118921)
57 Mon May 10 15:03:50 2004 Soeren Sandmann <sandmann@daimi.au.dk>
59 * gtk/gtkwidget.c (_gtk_widget_grab_notify): New internal function
60 that emits the grab notify signal.
62 * gtk/gtkmain.c (gtk_grab_notify_foreach): Use it here.
64 Mon May 10 00:48:08 2004 Matthias Clasen <maclas@gmx.de>
66 * gtk/gtkmenu.c: Make destruction of a torn off menu work
69 Sun May 9 21:05:38 2004 Matthias Clasen <maclas@gmx.de>
73 * gtk/gtkactiongroup.c (gtk_action_group_add_action_with_accel):
74 Allow to suppress the stock accelerator by using "". (#142196,
77 Sun May 9 02:01:13 2004 Matthias Clasen <maclas@gmx.de>
81 * gtk/gtkcombobox.c (gtk_combo_box_list_button_released):
82 In list mode, accept the same mouse/wheel bindings on
83 the cellview as on the button. (#136967)
85 Sun May 9 01:25:37 2004 Matthias Clasen <maclas@gmx.de>
87 * gtk/gtkiconfactory.c (add_to_cache): Actually count the
88 cached icons. (#135888, Crispin Flowerday)
90 Sun May 9 00:03:03 2004 Matthias Clasen <maclas@gmx.de>
92 * gtk/gtkuimanager.c (gtk_ui_manager_get_widget): Make sure
93 that we actually return menus for nodes of type menu, not the
94 menuitems they're attached to.
96 Sat May 8 22:50:55 2004 Matthias Clasen <maclas@gmx.de>
98 * gtk/gtkactiongroup.c (gtk_action_group_set_translation_domain):
99 Add a note regarding UTF-8 requirements, proposed by
100 Mariano Suárez-Alvarez.
102 Sat May 8 22:43:11 2004 Matthias Clasen <maclas@gmx.de>
104 * gtk/gtktearoffmenuitem.h:
105 * gtk/gtktearoffmenuitem.c: Put the torn_off flag back
106 into the GtkTearoffMenuItem struct, since it is used
107 by the Gimp, and keep it synchronized with the
108 tearoff_state property of the parent menu.
110 2004-05-08 Hans Breuer <hans@breuer.org>
112 * gtk/gtkfilesystemwin32.c (extract_icon) : finally also
113 create the correct mask for 'pseudo mime' icons
115 * gdk/win32/gdkwindow-win32.c(show_window_internal) : also
116 take focus_on_map into account
118 * gtk/gtkselection.c : g_message() only with DEBUG_SELECTION
120 * gtk/gtkactiongroup.c gtk/gtkcombobox.c :
121 ... must return a value
123 * gdk/gdk.def gtk/gtk.def demos/gtk-demo/makefile.msc.in : updated
125 2004-05-07 Matthias Clasen <mclasen@redhat.com>
127 * gtk/gtkbutton.c (gtk_button_size_allocate): Don't let the child
128 draw over the focus rectangle.
130 * gtk/gtkhsv.c: Draw focus indication in the color wheel using
131 standard focus style. (#63071, Bill Haneman, idea for new
132 style by Owen Taylor)
134 * gtk/gtkstyle.c (gtk_default_draw_focus): Support drawing on
135 focus on the colorwheel via details.
137 2004-05-06 Matthias Clasen <mclasen@redhat.com>
141 * gtk/gtkcombobox.c (gtk_combo_box_menu_state_changed): Remove
142 this no longer needed signal handler. (#141817, Paul Pogonyshev)
144 Fri May 7 00:41:46 2004 Matthias Clasen <maclas@gmx.de>
146 * gtk/gtktearoffmenuitem.h:
147 * gtk/gtktearoffmenuitem.c: Make the tearoff
148 functionality model/view, the tearoffmenuitem being
149 the view and the tearoff_state property of the menu
150 being the model. (#101185, Owen Taylor)
152 * gtk/gtkmenu.c: Add a tearoff_state property.
154 Thu May 6 23:52:13 2004 Matthias Clasen <maclas@gmx.de>
158 * gtk/gtkmenuitem.c (gtk_menu_item_select_timeout): Also
159 popup the submenu for items in torn off menus. (#122051)
161 2004-05-06 Sven Neumann <sven@gimp.org>
163 * gtk/gtkexpander.c (gtk_expander_size_allocate): in RTL mode,
164 position the title lable next to the arrow just as we do for LTR
165 rendering. Fixes bug #141825.
167 2004-05-06 Matthias Clasen <mclasen@redhat.com>
169 * docs/RELEASE-HOWTO: Document the new policy of
170 bumping version numbers after release.
172 * configure.in: Bump version number to 2.5.0.
174 2004-05-06 Padraig O'Briain <padraig.obriain@sun.com>
177 * gtk/gtkmenu.c: Add new function gtk_menu_get_for_attach_widget.
180 Thu May 6 00:24:11 2004 Matthias Clasen <maclas@gmx.de>
182 * gtk/gtkactiongroup.h:
183 * gtk/gtkactiongroup.c (gtk_action_group_translate_string):
184 New function to translate a string with translate_func.
187 Thu May 6 00:02:21 2004 Matthias Clasen <maclas@gmx.de>
189 * gtk/gtkcombobox.c (gtk_combo_box_get_wrap_width):
190 (gtk_combo_box_get_row_span_column):
191 (gtk_combo_box_get_column_span_column): Add missing getters
192 for readwrite properies. (#135649)
194 Wed May 5 23:42:42 2004 Matthias Clasen <maclas@gmx.de>
197 * gtk/gtkcombobox.c (gtk_combo_box_get_active_text):
198 Add gtk_combo_box_get_active_text() convenience
199 function. (#136372, Christian Neumeir, patch by Olivier Andrieu)
201 2004-05-05 Elijah Newren <newren@math.utah.edu>
203 Changes to support do-not-focus-on-map hint in conjunction with
204 _NET_WM_USER_TIME (#115650):
206 * gdk/gdkwindow.h (struct _GdkWindowObject): Add a new boolean
209 * gdk/gdkwindow.h (gdk_window_set_accept_focus): New function to
212 * gtk/gtkwindow.[hc]: Add a boolean property "focus_on_map"
213 and gtk_window_get_focus_on_map() and gtk_window_set_focus_on_map().
215 * gdk/win32/gdkwindow-win32.c (gdk_window_new):
216 * gdk/linux-fb/gdkwindow-fb.c (gdk_window_new):
217 * gdk/x11/gdkwindow-x11.c (gdk_window_new):
218 Initialize the focus_on_map field to TRUE.
220 * gdk/win32/gdkwindow-win32.c (gdk_window_set_focus_on_map):
221 * gdk/linux-fb/gdkwindow-fb.c (gdk_window_set_focus_on_map):
222 * gdk/x11/gdkwindow-x11.c (gdk_window_set_focus_on_map):
223 * gdk/x11/gdkwindow-x11.c (setup_toplevel_window):
224 Implementations for the various backends. The Win32 and linux-fb
225 implementations set the focus_on_map field, but don't use it yet
226 to actually implement noinput windows. The X implementation sets
227 _NET_WM_USER_TIME to 0 if focus_on_map is FALSE (see the EWMH).
229 * gdk/x11/gdkwindow-x11.h:
230 * gdk/x11/gdkevents-x11.c (set_user_time):
231 * gdk/x11/gdkinput-x11.c (_gdk_input_common_other_event):
232 * gdk/x11/gdkwindow-x11.c (gdk_x11_window_set_user_time):
233 s/_gdk_x11_window_set_user_time/gdk_x11_window_set_user_time/,
234 since we want that function to be part of the public API.
236 Wed May 5 22:20:21 2004 Matthias Clasen <maclas@gmx.de>
240 * gtk/gtkiconfactory.c (icon_source_clear): Don't
241 call g_free() on a pixbuf. (#141961, Crispin Flowerday)
243 2004-05-05 Matthias Clasen <mclasen@redhat.com>
247 * gtk/gtkuimanager.c (print_node): Make the output
248 parseable. (#141929, Sven Neumann)
250 2004-05-05 Tor Lillqvist <tml@iki.fi>
252 * gdk/win32/gdkdnd-win32.c (gdk_drag_find_window_for_screen): Add
253 multi-monitor offset. (#141842, John Ehresman)
255 2004-05-04 Federico Mena Quintero <federico@ximian.com>
257 Fixes #139562, based on a patch by Christian Neumair.
259 * gtk/gtkfilechooserdefault.c (struct _GtkFileChooserDefault): Add
260 a filter_combo_hbox field to contain the filter combo.
261 (show_filters): Show/hide the filter_combo_hbox.
262 (create_filename_entry_and_filter_combo): Removed.
263 (file_pane_create): Create the filter_combo_hbox here.
265 2004-05-04 Matthias Clasen <mclasen@redhat.com>
267 * modules/input/gtkimcontextxim.c: Fix the recent
268 string_conversion_callback change to work on
269 Solaris. (#141190, Padraig O'Briain)
271 * gtk/gtkselection.c: Disable debug logging again.
273 2004-05-03 Matthias Clasen <mclasen@redhat.com>
275 * gtk/gtkselection.c: Make the chunk size for
276 incremental transfers depend on the maximal request
277 size, capped at 256k. This should allow most selections
278 to be transferred nonincrementally, avoiding many
279 roundtrips and protocol overhead.
281 2004-05-03 Federico Mena Quintero <federico@ximian.com>
283 * gtk/gtkuimanager.c (gtk_ui_manager_class_init): Call
284 g_signal_new() correctly and initialize the signal fields. Fixes
285 #141749; patch based on Michael Natterer's.
287 u2004-05-03 Matthias Clasen <mclasen@redhat.com>
289 * gtk/gtkselection.c (_gtk_selection_request): Fix
290 a debug message to show correct information.
291 (_gtk_selection_incr_event): Make INCRemental transfer
292 of MULTIPLE targets work. This was broken since 1997!
294 2004-05-02 Hans Breuer <hans@breuer.org>
296 * gdk/win32/gdkdrawable-win32.c (draw_segments) : don't
297 modify the passed in GdkSegment(s) in place, we may get
298 them again to draw at the same place. Fixes bug #129095,
300 (draw_segments) draw the end pixel again to get the
301 pixmap mask right, fixes bug #126710, #130202
303 * gdk/win32/gdkwindow-win32.c : use SetForegroundWindow,
304 fixes bug #106013, John Ehresman
306 * gtk/makefile.msc.in : don't try to link gtk.res but
307 use gtk-win32.res (as supposed to be fixed below :)
309 2004-05-01 Hans Breuer <hans@breuer.org>
311 * tests/Makefile.am : tests/makefile.msc is in CVS for
312 a long time, finally added to EXTRA_DIST : fixes bug
313 #141334, John Ehresman
315 2004-04-30 Matthias Clasen <mclasen@redhat.com>
317 * === Released 2.4.1 ===
319 * configure.in: Version 2.4.1, interface age 1.
323 2004-04-29 Federico Mena Quintero <federico@ximian.com>
327 * gtk/gtkfilechooserdefault.c (remove_selected_bookmarks): New
328 function; moved the code over from
329 remove_bookmark_button_clicked_cb().
330 (remove_selected_bookmarks): Now, getting a non-removable bookmark
331 is not an error, as we may be called as a result of hitting the
333 (shortcuts_key_press_event_cb): New handler; delete the bookmark
334 if the user presses Backspace, Delete, or KP_Delete.
336 2004-04-29 Matthias Clasen <mclasen@redhat.com>
338 * gtk/gtkaction.c (closure_accel_activate): Use
339 _gtk_action_emit_activate() instead of directly
340 emitting the activate signal. (#141429, Jody Goldberg)
342 * gtk/gtkactiongroup.c (gtk_action_group_add_action_with_accel):
343 Warn people when the accelerator can not be
344 parsed. (#141429, Jody Goldberg)
346 2004-04-29 Matthias Clasen <mclasen@redhat.com>
348 * tests/testentrycompletion.c (main): Add a missing
349 cat. (#141070, Chris Sherlock)
351 * gtk/gtkrc.c (gtk_rc_check_pixmap_dir): Remove unused
352 variable. (#141022, Chris Sherlock)
354 * gtk/gtkcombo.c (gtk_combo_popup_list): Add a missing
355 cast. (#141013, Chris Sherlock)
357 * gtk/gtkcellview.c (gtk_cell_view_cell_layout_clear): Remove
358 unused variable. (#141011, Chris Sherlock)
360 2004-04-29 Tor Lillqvist <tml@iki.fi>
362 * gdk/win32/gdkgc-win32.c (gdk_win32_gc_set_dashes): Plug memory
363 leak. (#140775, John Ehresman)
365 Thu Apr 29 01:09:50 2004 Matthias Clasen <maclas@gmx.de>
367 * gdk/gdkdraw.c (_gdk_drawable_get_scratch_gc): Use depth - 1
368 to index the cached gcs, not depth. (#139494)
370 2004-04-28 Matthias Clasen <mclasen@redhat.com>
372 * gdk/gdkdraw.c (_gdk_drawable_get_scratch_gc): Docs typo fix.
374 Sun Apr 25 15:36:02 2004 Soeren Sandmann <sandmann@daimi.au.dk>
376 * gtk/gtktoolbutton.c (gtk_tool_button_set_label_widget): Fix
377 cut'n'paste-o from previous commit. (#141046, Torsten Schoenfeld).
379 2004-04-24 Theppitak Karoonboonyanan <thep@linux.thai.net>
381 Patch to add support for string conversion callbacks to
382 GtkIMContextXIM (#101814)
384 * modules/input/gtkimcontextxim.c: Set the string conversion callback
385 if supported by the XIC.
387 (struct _GtkIMContextXIM): Add string_conversion_callback member.
389 (struct _GtkXIMInfo, setup_im): Check and keep flag inidicating
390 whether string conversion callback is supported.
392 (gtk_im_context_get_ic, +set_string_conversion_callback,
393 +string_conversion_callback): Also initialize string conversion
394 callback, if supported, along with the IC initialization.
396 * modules/input/imxim.c: Make "xim" module default for Thai as well.
398 2004-04-23 Matthias Clasen <mclasen@redhat.com>
400 * gtk/gtkclipboard.c (gtk_clipboard_wait_for_targets): Correctly
401 initialize targets. (#139883, John Finlay)
403 * gdk/gdkdraw.c (gdk_draw_drawable): Small doc improvement.
405 * gtk/gtktreeselection.c (gtk_tree_selection_get_selected_rows):
406 Don't recommend gtk_tree_row_reference_new_proxy(). (#138309,
409 * gtk/gtktreeviewcolumn.c (gtk_tree_view_column_cell_set_cell_data):
410 Remove an excessive g_return_if_fail().
412 * gdk/x11/gdkevents-x11.c (set_user_time): Make set_user_time()
414 * gdk/x11/gdkinput-x11.c (_gdk_input_common_other_event):
415 _-prefix calls of gdk_x11_window_set_user_time().
417 2004-04-22 Matthias Clasen <mclasen@redhat.com>
419 * gtk/gtkuimanager.c (update_node): Make sure the separators
420 used to demarkate placeholder ends don't show up on
421 show_all(). (#140496, Murray Cumming)
423 * gtk/gtkspinbutton.c (spin_button_at_limit): Make spinbuttons
424 work with negative increments. (#137975, Tim Gerla)
426 Wed Apr 21 21:38:03 2004 Soeren Sandmann <sandmann@daimi.au.dk>
428 * gtk/gtktoolbutton.c (gtk_tool_button_set_label_widget,
429 gtk_tool_button_set_icon_widget): Remove the old widget from the
430 tool button before overwriting it with the new widget.
432 (#140508, Todd Goyen)
434 2004-04-22 Tor Lillqvist <tml@iki.fi>
436 Fix the file chooser on Windows. I can't make it misbehave or
437 crash any more now. But presumably there are still corner cases
438 not handled. I haven't really checked behaviour of UNC paths, for
441 * gtk/gtkfilesystemwin32.c: Accept both backslash and slash in
442 several places. Use G_IS_DIR_SEPARATOR macro (which could be added
445 (gtk_file_system_win32_get_parent): Like the Unix version, assert
446 filename is absolute, and avoid one unnecessary string allocation
449 (canonicalize_filename,gtk_file_system_win32_parse): Handle drive
450 letters more correctly.
452 (gtk_file_system_win32_render_icon): Assure correct syntax is used
453 for root folder of a drive. (#137962, Morten Welinder)
455 (filename_is_some_root): New function that accepts also root
456 without any drive specified.
458 (filename_is_drive_root): Rename from filename_is_root.
460 * gtk/gtkfilechooserentry.c (completion_match_func): Casefold on
463 2004-04-21 Matthias Clasen <mclasen@redhat.com>
465 * gtk/gtkentry.c (gtk_entry_completion_timeout): Pop down the
466 completion window if there are no completions anymore.
468 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
469 Don't call gtk_tree_view_scroll_to_cell() on an empty tree view.
470 It doesn't like that. (#140642, Christian Persch)
472 * demos/gtk-demo/expander.c (do_expander): A new demo.
474 * demos/gtk-demo/Makefile.am (demos): Add expander.c.
476 2004-04-20 Matthias Clasen <mclasen@redhat.com>
478 * gtk/gtktextview.c (gtk_text_view_allocate_children): Make
479 sure anchored children get size allocated, even if the layout
480 is valid. (#122323, Andrew E. Makeev)
481 (gtk_text_view_scroll_pages):
482 (gtk_text_view_scroll_hpages): Don't scroll to cursor position
483 if we already have pending scrolls. Bandaid fix for #78513.
485 Mon Apr 19 17:59:17 2004 Owen Taylor <otaylor@redhat.com>
487 * INSTALL.in: Update libpng and libjpeg URLs, remove
488 note about building without since that's not the normal
491 Sun Apr 11 09:45:11 2004 Owen Taylor <otaylor@redhat.com>
493 * gtk/gtkicontheme.c (load_themes): Fix a couple of typos in
494 handling of SVG/non-SVG unthemed icons.
496 2004-04-19 Morten Welinder <terra@gnome.org>
498 * gtk/gtktoolbar.c (gtk_toolbar_focus): Don't leak list of
501 2004-04-19 Matthias Clasen <mclasen@redhat.com>
503 * gtk/gtktextbtree.c (_gtk_text_line_previous_could_contain_tag):
504 Don't stop the iteration up to the tag_root too
505 early. (#109945, Dongho Shin)
507 Sun Apr 18 17:06:03 2004 Soeren Sandmann <sandmann@daimi.au.dk>
509 * gdk/x11/gdkkeys-x11.c (get_effective_keymap): Make
510 gdk_keymap_translate_keyboard_state() handle NULL
511 keymaps. (#139715, Torsten Schoenfeld).
513 Sun Apr 18 16:59:21 2004 Soeren Sandmann <sandmann@daimi.au.dk>
515 * configure.in: Don't erase GDK_EXTRA_CFLAGS. Fixes bug 139586,
516 reported by Pedro RODRIGUEZ, about compilation problems when
517 Xcursor is installed in a non-standard location.
519 Sun Apr 18 16:15:15 2004 Soeren Sandmann <sandmann@daimi.au.dk>
521 Support for _NET_WM_USER_TIME (bug 115650). Patch by Elijah
524 * gdk/x11/gdkwindow-x11.[ch]: Add new internal function
525 _gdk_x11_set_user_time() to set the _NET_WM_USER_TIME property.
527 * gdk/x11/gdkdisplay-x11.h (struct _GdkDisplayX11): Add user_time field
529 * gdk/x11/gdkdisplay-x11.c: Add _NET_WM_USER_TIME to list of
532 * gdk/x11/gdkinput-x11.c, gdk/x11/gdkevents-x11.c: Set the
533 property on user interaction.
535 2004-04-15 Federico Mena Quintero <federico@ximian.com>
537 * gtk/gtkfilesel.c (open_new_dir): Tell the user to use
538 G_FILENAME_ENCODING, not G_BROKEN_FILENAMES. Fixes #114065.
540 * gtk/gtkfilechooserdefault.c (split_uris): Use a variant of the
541 code from gtkfilesel.c to parse a "text/uri-list" blob. Fixes
544 2004-04-15 Matthias Clasen <mclasen@redhat.com>
546 * gtk/gtkcellrenderer.c (gtk_cell_renderer_class_init):
547 * gtk/gtkbutton.c (gtk_button_class_init): Doc fixes.
549 2004-04-14 Matthias Clasen <mclasen@redhat.com>
553 Make all style properties readonly.
555 2004-04-14 Matthias Clasen <mclasen@redhat.com>
557 * gtk/gtkcolorsel.c: Add a11y relations between the color
558 wheel and the spin buttons. (#132745, Padraig O'Briain)
560 * gtk/gtkiconfactory.c (gtk_icon_set_render_icon): Document
561 the meaning of size == -1.
563 * gtk/gtkwidget.c (gtk_widget_render_icon): Explicitly accept
564 a size of -1. (#137436, Brian Cameron)
566 * gtk/gtkcombobox.c: Make the arrow and separator regular
567 children of an hbox inside the button, and propagate state
568 changes from the button to the cell view. (part of the fix
569 for #138650, should also fix #137535)
571 * gtk/gtkcellview.c (gtk_cell_view_expose): Pass the PRELIT
572 state to gtk_cell_renderer_render() when prelighted. (part
573 of the fix for #138650)
575 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_render):
576 Use PRELIGHT state when appropriate. (part of the fix for
579 * gtk/gtkcombobox.c (gtk_combo_box_relayout): Don't spit
580 out warnings if called before the combo box is
581 realized. (#139742, Philip Langdale)
583 Wed Apr 14 03:45:39 2004 Jonathan Blandford <jrb@gnome.org>
585 * gtk/gtktreeview.c (gtk_tree_view_expose): propagate expose
588 Wed Apr 14 03:32:58 2004 Jonathan Blandford <jrb@gnome.org>
590 * gtk/gtkpathbar.c (make_directory_button): remove spurious
593 Tue Apr 13 16:19:23 2004 Jonathan Blandford <jrb@redhat.com>
595 * gtk/gtkpathbar.c (make_directory_button): patch from Owen to
596 make the buttons sized by a bold label. This makes the text
597 'swim' a little, but stops the buttons from resizing, #137210
599 2004-04-13 Matthias Clasen <mclasen@redhat.com>
601 * gtk/gtkuimanager.c (get_child_node): Don't crash if a node
603 (start_element_handler): Accept separators without unique
604 names. (#133302, Anders Carlsson)
606 * gtk/gtkactiongroup.c (gtk_action_group_add_action): Document
607 possible accelerator gotcha when using this function. (#139641,
610 * gtk/gtkuimanager.c (node_remove_ui_reference): Don't leak
611 list nodes. (#138862, Morten Welinder)
613 Tue Apr 13 12:24:49 2004 Jonathan Blandford <jrb@redhat.com>
615 * gtk/gtktreeview.c (gtk_tree_view_destroy): remove unused
617 (gtk_tree_view_button_press): If we activated the row we don't
618 want to grab focus back, as moving focus to another widget is
619 pretty common, #138458
621 2004-04-12 Federico Mena Quintero <federico@ximian.com>
623 * gtk/gtkfilechooser.c (gtk_file_chooser_class_init): Added
624 documentation to all the signals.
626 2004-04-12 Matthias Clasen <mclasen@dhcp64-228.boston.redhat.com>
628 * gtk/gtkcombobox.c (gtk_combo_box_unset_model): Don't unref
629 model if it is NULL. (#139770)
631 * gtk/gtktreeview.c (gtk_tree_view_get_cell_area): Typo fix.
633 * gtk/gtkentrycompletion.c (gtk_entry_completion_init): Don't add
634 a shadow inside the scrolled window, add it around the vbox.
636 * gtk/gtkentryprivate.h:
637 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
638 Return a boolean indicating whether the popup is positioned above
639 or below. Scroll the completions to the beginning or the end,
640 depending on the positioning.
642 * gtk/gtkentry.c (gtk_entry_completion_key_press): Make keynav
643 wrap around in the entry completion popup, and allow GDK_UP to
644 enter the popup. (#137440)
646 2004-04-12 Matthias Clasen <mclasen@redhat.com>
648 * gtk/gtkentry.c (gtk_entry_size_request): Make sure the style is
649 there before using it.
651 Sun Apr 11 15:08:45 2004 Jonathan Blandford <jrb@gnome.org>
653 * gtk/gtktreeprivate.h: Moved search entries into priv data.
655 * gtk/gtktreeview.c: Prep for type-ahead support.
657 (gtk_tree_view_destroy): Destroy the search window explicitly.
658 (gtk_tree_view_key_press): Minor change; prep for type-ahead
659 (gtk_tree_view_ensure_interactive_directory): New function
660 (gtk_tree_view_focus_out): Rework to handle new entry life-cycle.
661 (gtk_tree_view_real_start_interactive_search): rework
662 (gtk_tree_view_search_dialog_hide): ditto
663 (gtk_tree_view_search_delete_event): ditto
664 (gtk_tree_view_search_button_press_event): ditto
665 (gtk_tree_view_search_key_press_event): ditto
666 (gtk_tree_view_search_move): ditto
667 (gtk_tree_view_search_init): ditto
669 * gtk/gtktreeviewcolumn.c:
670 (gtk_tree_view_column_cell_layout_clear): remove unused variable.
672 * tests/testfilechooser.c: (main): change
674 2004-04-11 Hans Breuer <hans@breuer.org>
676 * gdk/win32/gdkspawn-win32.c : workaround for bug #137496,
677 the real fix would involve just another small API breakage,
678 i.e. gdk_spawn_* using GPid not just gint.
680 * gtk/makefile.msc.in : build gtk-win32.res, not gtk.res
682 2004-04-10 Tor Lillqvist <tml@iki.fi>
684 * gdk/win32/gdkkeys-win32.c (gdk_keymap_translate_keyboard_state):
685 If both Shift and CapsLock pressed, ignore the shift only for
686 letters (that would have been affected by the CapsLock). (#139095)
688 * gdk/win32/gdkglobals-win32.c: Disable tablet support by default,
689 seems to be even buggier now than it used to be. (#138341)
690 Initialize _gdk_input_ignore_wintab to TRUE.
692 * gdk/win32/gdkmain-win32.c: Add --use-wintab switch and
693 GDK_USE_WINTAB environment variable to turn on tablet support.
695 2004-04-09 Christian Persch <chpe@cvs.gnome.org>
697 * gtk/gtkuimanager.c: (gtk_ui_manager_insert_action_group),
698 (gtk_ui_manager_remove_action_group): Terminate
699 g_object_[dis]connect() calls with NULL instead of 0.
702 2004-04-09 Guntupalli Karunakar <karunakar@freedomink.org>
704 * configure.in: Added "gu" (Gujarati) to ALL_LINGUAS.
706 2004-04-07 Federico Mena Quintero <federico@ximian.com>
710 * gtk/gtkfilesystem.c (gtk_file_system_parse): Ensure that the
711 passed-in 'str' is not NULL.
713 * gtk/gtkfilesystemunix.c (expand_tilde): New helper function;
714 expands "~/" or "~foo/" at the beginning of a filename.
715 (gtk_file_system_unix_parse): Use expand_tilde() before doing
718 * gtk/gtkfilechooserentry.c
719 (gtk_file_chooser_entry_maybe_update_directory): Take in a
720 force_reload argument.
721 (gtk_file_chooser_entry_changed): If gtk_file_system_parse()
722 returns an error, set the file_part_pos to -1.
723 (load_directory_callback): Only populate the model if the
724 file_part_pos is not -1.
726 2004-04-06 Pablo Saratxaga <pablo@mandrakesoft.com>
728 * configure.in: Added Icelandic (is) to ALL_LINGUAS
730 2004-04-05 Federico Mena Quintero <federico@ximian.com>
732 * gtk/gtkfilechooserdefault.c (location_popup_handler): Use a
733 title for SAVE and CREATE_FOLDER modes. Fixes #137272.
735 * gtk/gtkfilesystemunix.c (gtk_file_system_unix_make_path): Look
736 for G_DIR_SEPARATOR in the display_name, and err out if it is
737 present; use the same error message as Nautilus. Fixes #136467.
739 * gtk/gtkfilechooserdefault.c (file_pane_create): Make the
740 new-folder button say "Create Fo_lder" rather than "Create
741 _Folder", so that the mnemonic doesn't conflict with the "Save in
742 _folder" label. Fixes #136975.
744 2004-04-05 Federico Mena Quintero <federico@ximian.com>
746 * gtk/gtkpathbar.c (_gtk_path_bar_set_path): Ref/sink the
747 buttons. Also, free them correctly upon failure. Based on a
748 patch by Morten Welinder, fixes #137956.
750 2004-04-05 Anders Carlsson <andersca@gnome.org>
752 * gdk/gdk.c (gdk_arg_context_parse): Handle '--' correctly.
754 Fri Apr 2 17:57:33 2004 Jonathan Blandford <jrb@redhat.com>
756 * gtk/gtktreeview.c (gtk_tree_view_row_inserted): set the height
757 correctly for fixed height when inserting a node, #138082
759 2004-04-01 Federico Mena Quintero <federico@ximian.com>
763 * gtk/gtkpathbar.h (struct _GtkPathBarClass): Add a
764 "child_is_hidden" boolean argument to the "path-clicked" signal.
766 * gtk/gtkpathbar.c (struct _ButtonData): Added a file_is_hidden
768 (make_directory_button): Take a file_is_hidden argument; put it in
770 (_gtk_path_bar_set_path): See whether each path component path is
772 (gtk_path_bar_class_init): Add the file_is_hidden argument to the
773 "path-clicked" signal.
774 (button_clicked_cb): See if the downwards button represents a
775 hidden file for the file_is_hidden argument in the signal
778 * gtk/gtkmarshalers.list: Added a signal type VOID:POINTER,BOOLEAN.
780 * gtk/gtkfilechooserdefault.c
781 (gtk_file_chooser_default_select_path): If we fail to switch
782 folders, don't try to select the path in the file system model.
783 Also, return the result from _gtk_file_system_model_path_do().
784 (gtk_file_chooser_default_select_path): Turn on show_hidden in the
785 file system model if we are asked to select a hidden file.
786 (path_bar_clicked): Show hidden files based on whether the
787 immediate downwards folder in the path bar is a hidden file
789 (struct _GtkFileChooserDefault): Added fields
790 browse_files_popup_menu and browse_files_popup_menu_hidden_files_item.
791 (create_file_list): Set an object data key of
792 "GtkFileChooserDefault" on the tree view so that we can find the
793 impl from the popup menu callbacks. Also, hook up to the
794 "button-press-event" and "popup-menu" signals in the file list to
795 bring up a popup menu.
796 (list_popup_menu_cb): New callback.
797 (list_button_press_event_cb): New callback.
801 * gtk/gtkfilesystemmodel.c
802 (_gtk_file_system_model_new): Oops, connect_object to
805 2004-03-31 Tor Lillqvist <tml@iki.fi>
807 * configure.in: Move AC_CANONICAL_HOST earlier, before the check
808 for native Win32. (#136559, J. Ali Harlow)
810 * gdk/win32/gdkdrawable-win32.c (draw_arc): Use X11 semantics for
811 angles. Thanks to Tim Newsham.
813 2004-03-29 Federico Mena Quintero <federico@ximian.com>
817 * gtk/gtkfilesystem.h (struct _GtkFileFolderIface): Added slots
818 for an ::is_finished_loading() method and a ::finished_loading()
819 signal at the end of the struct.
821 * gtk/gtkfilesystem.c (gtk_file_folder_base_init): Create the
822 "finished-loading" signal.
823 (gtk_file_folder_is_finished_loading): New function.
825 * gtk/gtkfilesystemunix.c
826 (gtk_file_folder_unix_is_finished_loading): Implement.
828 * gtk/gtkfilesystemmodel.c (struct _GtkFileSystemModelClass): New
829 slot for a "finished-loading" signal.
830 (gtk_file_system_model_class_init): Create the "finished-loading"
832 (struct _GtkFileSystemModel): New field
833 idle_finished_loading_source. We emit the "finished-loading"
834 signal in an idle if the root folder was done loading right in
835 _gtk_file_system_model_new(), so that the caller has a chance to
836 connect to the signal.
837 (_gtk_file_system_model_new): Connect to the normal signals of the
838 folder even if the initial _list_children() fails. Also, see if
839 the folder is finished loading; connect to the "finished-loading"
841 (gtk_file_system_model_finalize): Remove the idle handler.
843 * gtk/gtkfilechooserdefault.c (set_list_model): Set a busy cursor
844 and connect to the model's "finished-loading" signal.
845 (get_toplevel): New helper function.
846 (error_message): Use get_toplevel().
847 (trap_activate_cb): Likewise.
848 (location_popup_handler): Likewise.
849 (set_busy_cursor): New function.
850 (browse_files_model_finished_loading_cb): New callback.
852 2004-03-25 Federico Mena Quintero <federico@ximian.com>
854 * gtk/gtkfilechooserdefault.c (check_preview_change): Just use the
855 file under the cursor; we don't need the logic from
856 GtkFileSelection after all. Fixes #132255.
858 2004-03-25 Federico Mena Quintero <federico@ximian.com>
860 * gtk/gtkfilechooserdefault.c (location_entry_create): Fill the
861 location entry with the display name of the file under the cursor
862 for Open mode, or the typed filename in Save mode.
864 2004-03-24 J. Ali Harlow <ali@juiblex.co.uk>
866 * gtk/gtkfilesystemwin32.c
867 (filename_is_root): Bare drive designators (eg., "c:") are
868 no longer considered as root filenames. Fixed #137942
870 2004-03-24 J. Ali Harlow <ali@juiblex.co.uk>
872 * gtk/gtkfilesystemwin32.c
873 (gtk_file_system_win32_create_folder): Invert test for error in
876 2004-03-24 J. Ali Harlow <ali@juiblex.co.uk>
878 Fixed #138004 using Federico's code from #132327.
880 * gtk/gtkfilesystemwin32.c (struct _GtkFileSystemWin32): Add a
881 folder_hash field to keep a list of live folder objects.
882 (gtk_file_system_win32_init): Create the folder_hash.
883 (gtk_file_system_win32_finalize): Destroy the folder_hash.
884 (gtk_file_system_win32_get_folder): Ref and return an existing
885 folder if we have it around, otherwise return a new folder object.
886 (struct _GtkFileFolderWin32): Add a field for the parent file system.
887 (gtk_file_folder_win32_finalize): Remove the folder from the file
889 (gtk_file_system_win32_create_folder): Emit "files-added" on the
890 newly-created folder's parent. Fixes #138004.
892 2004-03-24 J. Ali Harlow <ali@juiblex.co.uk>
894 * gtk/gtkfilesystemwin32.c
895 (gtk_file_system_win32_get_folder): Test that path is actually
896 a directory and throw error if not. Fixed bug #137950
898 2004-03-22 J. Ali Harlow <ali@juiblex.co.uk>
900 * gtk/gtkfilesystemwin32.c
901 (gtk_file_system_win32_volume_get_display_name): Ignore empty
902 volume labels; assume that GetVolumeInformation would fail if
903 GetVolumeInformationW does; catches a small memory leak;
904 pass the buffer size to GetVolumeInformationW in wide
905 characters instead of bytes. Fixes bug #137543
906 (list_volumes): Cope with the theoretical possibility of
907 more than 26 logical drives. Fixes bug #137940
908 (bookmarks_serialize): Now actually removes bookmarks.
911 2004-03-22 Guntupalli Karunakar <karunakar@freedomink.org>
913 * configure.in: Added "pa" (Punjabi) to ALL_LINGUAS.
915 2004-03-21 Tor Lillqvist <tml@iki.fi>
917 * gtk/gtkfilesystemwin32.c
918 (gtk_file_system_win32_volume_get_base_path): Include the
919 backslash. Otherwise gtk_file_system_win32_path_to_uri() returns
920 NULL for a volume base path, as g_filename_to_uri() requires an
921 absolute path, and just a drive letter and colon isn't. (#137543)
923 2004-03-20 Hans Breuer <hans@breuer.org>
925 * gtk/gtkfilesystemwin32.c : applied the undisputable and
926 required [due to recent gtkfilesystem internal api semantic
927 changes] part of patches to fix bug #137543 (Tor Lillqvist,
930 * gdk/gdkevents-win32.c (handle_configure_event) :
931 (gdk_event_translate), WM_WINDOWPOSCHANGED : initialize
932 GdkWindowObject::x, y with screen coords to make
933 gdk_window_get_position () return the right thing and thus fix
934 drag and drop positioning (e.g. Gimp tabs, fixes bug #137192)
936 2004-03-19 Federico Mena Quintero <federico@ximian.com>
938 * Revert the patch to #137520, as 2.4.1 is for conservative bug
939 fixes only. The patch is attached to the bug report, for
942 2004-03-19 Morten Welinder <terra@gnome.org>
944 * gtk/gtkfilechooserdefault.c
945 (gtk_file_chooser_default_set_current_folder): Test existance of
946 the path after checking for locality, if needed.
948 2004-03-19 Federico Mena Quintero <federico@ximian.com>
952 * gtk/gtkfilesystem.h (struct _GtkFileFolderIface): Added slots
953 for an ::is_finished_loading() method and a ::finished_loading()
954 signal at the end of the struct.
956 * gtk/gtkfilesystem.c (gtk_file_folder_base_init): Create the
957 "finished-loading" signal.
958 (gtk_file_folder_is_finished_loading): New function.
960 * gtk/gtkfilesystemunix.c
961 (gtk_file_folder_unix_is_finished_loading): Implement.
963 * gtk/gtkfilesystemmodel.c (struct _GtkFileSystemModelClass): New
964 slot for a "finished-loading" signal.
965 (gtk_file_system_model_class_init): Create the "finished-loading"
967 (struct _GtkFileSystemModel): New field
968 idle_finished_loading_source. We emit the "finished-loading"
969 signal in an idle if the root folder was done loading right in
970 _gtk_file_system_model_new(), so that the caller has a chance to
971 connect to the signal.
972 (_gtk_file_system_model_new): Connect to the normal signals of the
973 folder even if the initial _list_children() fails. Also, see if
974 the folder is finished loading; connect to the "finished-loading"
976 (gtk_file_system_model_finalize): Remove the idle handler.
978 * gtk/gtkfilechooserdefault.c (set_list_model): Set a busy cursor
979 and connect to the model's "finished-loading" signal.
980 (get_toplevel): New helper function.
981 (error_message): Use get_toplevel().
982 (trap_activate_cb): Likewise.
983 (location_popup_handler): Likewise.
984 (set_busy_cursor): New function.
985 (browse_files_model_finished_loading_cb): New callback.
987 Thu Mar 18 12:10:45 2004 Owen Taylor <otaylor@redhat.com>
989 * gtk/gtktreeitem.c (gtk_tree_item_forall): Include
990 eventbox for expander. (#137564, reported by
993 2004-03-18 Guntupalli Karunakar <karunakar@freedomink.org>
995 * mr.po: Added "mr" for Marathi to ALL_LINGUAS.
997 2004-03-17 Morten Welinder <terra@gnome.org>
999 * gtk/gtkfilechooserdefault.c (shortcuts_add_volumes): Free
1000 volumes not actually put into the shortcut list.
1002 * tests/prop-editor.c (object_changed): Plug leak.
1004 * tests/testfilechooser.c (main): Plug some leaks and expose
1007 * tests/prop-editor.c (create_prop_editor): Don't leak the tooltip
1008 object. Fixed #136652.
1010 * gtk/gtkfilechooserdefault.c (check_icon_theme): Do nothing if we
1011 have no screen. Fixes #137260.
1012 (shortcuts_add_bookmark_from_path): Simplify using check_is_folder
1013 thereby fixing leak. Fixes #137259.
1015 * gtk/gtkpathbar.c (gtk_path_bar_forall): Make this work when the
1016 slider buttons have been destroyed.
1017 (gtk_path_bar_remove): Make this work for slider buttons too.
1020 2004-03-15 Morten Welinder <terra@gnome.org>
1022 * gtk/gtkfilechooserdefault.c (shortcuts_add_bookmark_from_path):
1023 Sanitize and plug leak.
1024 (check_icon_theme): Only do something if the widget has a screen.
1026 Wed Mar 17 01:20:28 2004 Matthias Clasen <maclas@gmx.de>
1028 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
1029 Move the repositioning logic from _gtk_entry_completion() popup
1030 over here. Fixes #137355, reported by Niklas Knutsson.