1 2005-12-14 Matthias Clasen <mclasen@redhat.com>
3 * gtk/gtkdnd.c (gtk_drag_set_icon_name): Warn if the icon
4 cannot be loaded. (#323504, Kjartan Maraas)
6 * gtk/gtktreeview.c (gtk_tree_view_class_init): Add docs
7 for the row-activated signal. (#324044, Davyd Madeley)
9 2005-12-14 Michael Natterer <mitch@imendio.com>
11 * tests/test-images/valid_jpeg_progressive_test: new test image.
13 Tue Dec 13 09:47:20 2005 Tim Janik <timj@gtk.org>
15 * README.in: added a link to the floating reference docs in the
16 2.10 release NEWS section.
18 2005-12-12 Matthias Clasen <mclasen@redhat.com>
20 * gtk/gtktextiter.c (gtk_text_iter_set_visible_line_index):
21 Speed this function up, using the fact that visibility is
22 constant across segments. (#321548, Paolo Borelli)
24 * gtk/gtktextbtree.c (_gtk_text_line_char_to_byte_offsets):
25 * gtk/gtktextiter.c (gtk_text_iter_backward_chars): Speed up
26 stepping backwards. (#320638, Larry Ewing, Paolo Borelli)
28 * gtk/gtkicontheme.c (ensure_valid_themes): Only broadcast
29 _GTK_LOAD_ICONTHEMES if we detect a real theme change, not
30 upon initial theme load. (#323876, Peter Lund)
32 * gtk/gtkstatusicon.c (gtk_status_icon_class_init): Register
33 the size-changed signal correctly. (#323848, Murray Cumming)
35 * gtk/gtkmarshalers.list: Add necessary marshaller.
37 * gtk/gtktextview.c (gtk_text_view_get_border_window_size): Don't
38 fall thru to the wrong window types. (#323843)
40 Make the gtk-color-scheme setting work.
43 * gtk/gtksettings.c (_gtk_settings_get_color_hash): Add a getter
44 that takes care of initializing the color hash if it is not
47 * gtk/gtkrc.c (gtk_rc_color_scheme_changed, gtk_rc_context_get):
50 2005-12-10 Matthias Clasen <mclasen@redhat.com>
52 * gdk/gdk.c (gdk_parse_args): Warn if parsing fails,
55 2005-12-09 Matthias Clasen <mclasen@redhat.com>
57 * gtk/gtkselection.c (gtk_selection_data_get_uris): Don't
58 leak list[0]. (#323629, Markku Vire)
60 * gtk/gtktextbuffer.c (paste_from_buffer): Unref the buffer
61 when freeing the RequestData. (#323577)
63 2005-12-07 Matthias Clasen <mclasen@redhat.com>
65 * demos/gtk-demo/iconview_edit.c (set_cell_color): Don't
68 * gtk/gtktoolbutton.c (clone_image_menu_size): Fix a
69 variable name clash. (#323475, Ross Burton)
71 2005-12-07 Ross Burton <ross@burtonini.com>
73 * docs/reference/gtk/tmpl/gtkenums.sgml:
74 * gtk/gtktoolbutton.c:
75 If the toolbar mode is ICONS and there is no icon set then show
76 the label, and vice versa (#322019)
78 2005-12-07 Matthias Clasen <mclasen@redhat.com>
80 * gtk/gtktoolbutton.c (clone_image_menu_size): Fix a
81 variable name clash. (#323475, Ross Burton)
83 * gtk/gtktreeview.c (gtk_tree_view_key_press): Use the correct
84 window when synthesizing the key event. (#323077,
85 Sadrul Habib Chowdhury)
87 (gtk_tree_view_search_key_press_event): Also listen for
88 GDK_ISO_Left_Tab. (#323077, Sadrul Habib Chowdhury)
90 * gtk/gtktextview.c (gtk_text_view_preedit_changed_handler):
91 Only scroll if we have focus. (#316310, Paolo Borelli)
93 * gtk/gtkfilesystemunix.c (cb_fill_in_mime_type): Fix a C99ism,
94 spotted by Crispin Flowerday.
96 2005-12-06 Behdad Esfahbod <behdad@gnome.org>
98 * gtk/gtksettings.c (settings_update_font_options): Turn metrics
99 hinting on (part of #307196)
101 2005-12-06 Matthias Clasen <mclasen@redhat.com>
103 * gtk/gtkimcontextsimple.c (gtk_im_context_simple_reset): Don't
104 commit from reset, it upstets GtkTextView.
106 * gtk/gtktextview.c (gtk_text_view_check_cursor_blink): Be more
107 careful when turning blinking on and off.
108 (gtk_text_view_focus_out_event): Make the cursor really invisible
109 when the focus goes away. (#323087, Sadrul Habib Chowdhury)
110 (cursor_blinks): Check the gtk-cursor-blink setting first.
112 * gtk/gtktreeview.c (gtk_tree_view_key_press): Fix refcounting
113 issues with new_event and its window.
115 * gtk/gtkmenu.c (gtk_menu_attach_to_widget): Accept NULL
116 as a detach func. (#323386, Jorn Baayen)
118 * gtk/gtkcalendar.c: Avoid conflict with win32 headers in
119 the libdate routines. (#323045, Kazuki Iwamoto)
121 * gdk/gdk.c (gdk_parse_args):
122 * gtk/gtkmain.c (gtk_parse_args): Don't ignore errors
123 from g_option_context_parse().
125 Tue Dec 6 11:37:59 2005 Tim Janik <timj@gtk.org>
127 * gdk/gdkevents.c (gdk_event_new): fix missing hash table
130 Tue Dec 6 10:32:17 2005 Tim Janik <timj@gtk.org>
132 * gtk/gtkstatusbar.c: ported memchunk uses to g_slice, so the code
135 2005-12-05 Federico Mena Quintero <federico@ximian.com>
137 * gtk/gtkfilechooserdefault.c (trap_activate_cb): "event->state &
138 modifiers", not "event->state && modifiers". Patch by Sadrul
139 Habib Chowdhury <imadil@gmail.com>. Fixes bug #323073.
141 2005-12-05 Matthias Clasen <mclasen@redhat.com>
144 * gtk/gtkuimanager.c:
145 * gtk/gtktreedatalist.c:
148 * gtk/gtkitemfactory.c:
149 * gtk/gtkseparator.[hc]:
152 * gtk/gtkgc.c: Use g_slice instead of mem chunks.
154 2005-12-05 Michael Natterer <mitch@imendio.com>
156 * gdk/x11/gdkevents-x11.c: map the new GtkSettings properties
157 "timeout-initial", "timeout-repeat", "color-scheme" and
158 "enable-enimations" to X settings.
160 2005-12-05 Matthias Clasen <mclasen@redhat.com>
163 * gdk/gdkcolor.c: Use g_slice instead of mem chunks.
165 * gtk/gtktreeview.c (gtk_tree_view_key_press): Free new_event
166 after sending it to the search entry. (#323209, Crispin Flowerday)
168 * README.in: Add a note about GTK_FLOATING.
170 * gtk/gtkobject.h (GTK_OBJECT_FLOATING): Use g_object_is_floating.
172 2005-12-02 Matthias Clasen <mclasen@redhat.com>
174 * gtk/gtktoolbutton.c (clone_image_menu_size): Don't leak
175 a pixbuf. (#323024, Paolo Borelli)
177 2005-12-02 Matthias Clasen <mclasen@redhat.com>
179 * gtk/gtkfilesystemunix.c (get_icon_for_mime_type): Don't crash
180 if mime_type is NULL. (#322998, Sadrul Habib Chowdhury)
182 2005-12-02 Michael Natterer <mitch@imendio.com>
184 * gtk/gtkmenu.c: applied modified patch from maemo-gtk which
185 adds a "horizontal-padding" style property. Fixes bug #323036.
187 2005-12-01 Michael Natterer <mitch@imendio.com>
189 Merged modified patch from maemo-gtk that allows to disable
190 toolbar animations. Addresses bug #142582.
192 * gtk/gtksettings.c: added boolean property "gtk-enable-animations".
193 (patch from Christian Neumair)
195 * gtk/gtktoolbar.c: don't animate toolbar changes if the settings
196 property is FALSE. Replaced the individual "notify::foo"
197 connections to GtkSettings by a single "notify" callback and
200 2005-12-01 Michael Natterer <mitch@imendio.com>
202 * gtk/gtkmenu.c (gtk_menu_class_init): removed redundant
203 assignment of widget_class->motion_notify_event.
205 2005-11-29 Matthias Clasen <mclasen@redhat.com>
207 * gtk/gtktoggleaction.c (gtk_toggle_action_class_init): Add
208 an active property. (#322673, Jorn Baayen)
210 Properly handle model changes in GtkTreeSelection: (#322569,
213 * gtk/gtktreeselection.c (gtk_tree_selection_selected_foreach):
214 Get a reference to the model, and stop the iteration if the model
215 of the treeview is changed on the way.
217 * gtk/gtktreeprivate.h:
218 * gtk/gtktreeselection.c (_gtk_tree_selection_emit_changed): New
219 private function to emit the GtkTreeSelection::changed signal.
221 * gtk/gtktreeview.c (gtk_tree_view_set_model): Call
222 _gtk_tree_selection_emit_changed() when the model changes.
224 2005-11-28 Federico Mena Quintero <federico@ximian.com>
226 Fixes the critical warnings from bug #317999, thus fixing the bug
229 * gtk/gtkfilechooserdefault.c
230 (gtk_file_chooser_default_get_paths): In SELECT_FOLDER mode,
231 use _gtk_file_chooser_get_current_folder_path() instead of fetching the
232 impl->current_folder directly. The latter may be null if we are
233 in RELOAD_NONE state.
235 2005-11-28 Federico Mena Quintero <federico@ximian.com>
237 Fix bug #321560, based on a patch by Bogdan Nicula (bogdanni@hotmail.com):
239 * gtk/gtkfilechooserdefault.c (up_folder_handler): Don't add the
240 current_folder to the pending select paths here; the path bar will
242 (path_bar_clicked): Add the child_path to the pending select paths
244 (show_and_select_paths): Don't filter out folders.
245 (show_and_select_paths): Don't take separate arguments for
246 only_one_path and multiple paths.
248 * tests/autotestfilechooser.c (test_folder_switch_and_filters):
249 New test about preserving the filters when we change folders.
251 2005-11-28 Matthias Clasen <mclasen@redhat.com>
253 * gtk/gtkscale.c (_gtk_scale_format_value): Insert an LRM, to prevent
254 -20 to come out as 20- in RTL locales. (#322571, Tze'ela Hebron)
256 * gtk/gtkaction.c (gtk_action_sync_button_stock_id)
257 (connect_proxy): Buttons use the label property for stock ids. (#322565,
260 * gtk/gtkiconview.c (update_text_cell, update_pixbuf_cell): Correctly
261 handle the cell list and indices into it. (#321856)
263 2005-11-28 Matthias Clasen <mclasen@redhat.com>
265 * gtk/gtktooltips.c (gtk_tooltips_timeout): Set timer_tag to 0 when
266 the timeout is done. (#322291, Jean-Yves Lefort)
268 2005-11-28 Matthias Clasen <mclasen@redhat.com>
270 * gtk/gtkfilechooserdefault.c (shortcuts_key_press_event_cb): Make
271 F2 work for renaming bookmarks. (#320822, Jaap A. Haitsma, patch
274 2005-11-28 Tor Lillqvist <tml@novell.com>
276 * gdk/win32/gdkwindow-win32.c (gdk_window_set_urgency_hint):
277 Implement the conditional use of FlashWindowEx() properly for MSVC
278 compilations. The code was confusingly assuming that if compiled
279 with a "new" compiler, it will only be run on "new" Windows
280 versions. We want it to run on "old" versions, too, even if
281 compiled with a "new" compiler. There are two orthogonal issues:
282 whether the compiler defines the necessary API in its headers, and
283 whether it is present at run-time. (#318077)
285 * gtk/gtkcalendar.c (gtk_calendar_init): Use GetLocaleInfo() on
286 Windows to get the localized weekday and month names. strftime()
287 in the Microsoft C library returns strings in the default codepage
288 for the locale of the process, not the system codepage. Thus
289 g_locale_to_utf8() isn't useable on the return value from
290 strftime(). (#322603)
292 2005-11-27 Matthias Clasen <mclasen@redhat.com>
294 * gtk/gtkmessagedialog.c (gtk_message_dialog_new_with_markup):
295 Fix an example. (#322493, Elie De Brauwer)
297 Fix two memory handling problems in GtkTreeView: (#322350,
300 * gtk/gtktreeview.c (gtk_tree_view_destroy)
301 (gtk_tree_view_set_model): Remove all references to nodes in
303 (gtk_tree_view_real_collapse_row): Unmark expanded_collapsed_node
304 before removing the children.
306 * gtk/gtkcolorbutton.c (gtk_color_button_init): Don't leak a
307 PangoLayout here. (#322505, Paolo Borelli)
309 2005-11-27 Tor Lillqvist <tml@novell.com>
311 Once again rework Win32 window decoration code. Doesn't break
312 #104514. The dialogs in gtk-demo now have the same decorations and
313 behaviour as on X11. Tried to fix #322516 but it seems very hard
314 to make the trivial sample program there behave as expected. OTOH,
315 simply moving the gtk_window_decorate() call in the #322516 sample
316 program after the call to gtk_widget_show() helps...
318 * gdk/win32/gdkwindow-win32.c (set_or_clear_style_bits): Revert to
319 the correct semantics. Each call to gdk_window_set_decorations()
320 which calls this function is supposed to affect all decorations.
322 (decorate_based_on_hints): New function, looks at both geometry
323 hints and type hint and sets window decorations based on
324 that. Consolidate code from gdk_window_set_geometry_hints() and
325 gdk_window_set_type_hint() here.
327 (gdk_window_set_geometry_hints, gdk_window_set_type_hint): Call
328 decorate_based_on_hints().
330 2005-11-25 Dom Lachowicz <cinamod@hotmail.com>
332 * modules/engines/ms-windows/*.[ch]: Merge with gtk-wimp's CVS.
333 Includes improved menu icon spacing, [+]/[-] expander drawing,
334 status-bar gippie drawing, and notebook tab drawing.
336 2005-11-24 Michael Natterer <mitch@imendio.com>
338 * gtk/gtktoolbar.h (struct _GtkToolbar): changed two private guint
339 that used to hold signal handler IDs to two guint of padding.
341 * gtk/gtktoolbar.c (struct _GtkToolbarPrivate): added them as
344 (gtk_toolbar_screen_changed): changed accordingly.
346 Wed Nov 23 18:55:47 2005 Tim Janik <timj@imendio.com>
348 * gtk/gtkobject.[hc]: deprecated floating/sink API and implemented it
349 in terms of the GObject floating/sink API.
351 * gtk/gtkaboutdialog.c:
357 * gtk/gtkfilechooserdefault.c:
359 * gtk/gtkinvisible.c:
360 * gtk/gtkitemfactory.c:
363 * gtk/gtkmenutoolbutton.c:
367 * gtk/gtkspinbutton.c:
368 * gtk/gtkstatusicon.c:
372 * gtk/gtktoolbutton.c:
376 * gtk/gtktreeviewcolumn.c:
377 * gtk/gtkuimanager.c:
381 ported to use GObject's g_object_ref_sink().
384 * gtk/gtkfilechooserdefault.c:
385 * gtk/gtkaboutdialog.c:
386 fixed compiler warnings.
388 2005-11-23 Matthias Clasen <mclasen@redhat.com>
390 * gtk/gtksettings.c (gtk_settings_class_init): Add some docs
391 about gtk-color-scheme.
393 2005-11-23 Behdad Esfahbod <behdad@gnome.org>
395 * configure.in (enable_explicit_deps): Fix typo when checking
396 libtool config deplibs_check_method. Moreover, enable explicit
397 deps if we get anything other than pass_all from libtool. (part of
400 2005-11-23 Matthias Clasen <mclasen@redhat.com>
402 * gtk/updateiconcache.c (write_csource): Don't create a big
403 string, since Visual C++ doesn't like strings longer than 64k.
404 (#322238, Kazuki IWAMOTO
406 * gtk/gtkentry.c: Include gtkimcontextsimple.h (#322235,
409 2005-11-23 Michael Natterer <mitch@imendio.com>
411 * gtk/gtkrc.c (gtk_rc_reset_widgets): don't leak all toplevel
412 windows on other screens (correctly remove all temporary
415 2005-11-23 Michael Natterer <mitch@imendio.com>
417 Added symbolic themable colors. Patch is a merged version of
418 proposals from Matthias and maemo-gtk. Fixes bug #114355.
420 * configure.in: require glib >= 2.9.1 for refcountable hashtables.
422 * gtk/gtksettings.c: added property "color-scheme" which is a
423 string defining colors like "foreground:black\nbackground:grey".
424 Automatically provide a name->GdkColor hash table mapping for the
427 * gtk/gtkrc.[ch]: added list of color hashes that works like the
428 list of icon factories. Append the color scheme hash from
429 GtkSettings if it exists. Extended gtkrc syntax to allow defining
430 and referencing of logical colors. Also allow to modulate colors
431 in gtkrc by using arbitrary expressions of mix(), shade(),
432 lighter() and darker(). Added internal function
433 _gtk_rc_style_get_color_hashes().
435 * gtk/gtkstyle.[ch]: keep a private list of color hashes around.
436 Get the list from _gtk_rc_style_get_color_hashes(). Export
437 internal function _gtk_style_shade() (used by above color
438 expressions). Added public API gtk_style_lookup_color() which
439 looks up a logical color by name.
441 * gtk/gtk.symbols: add gtk_style_lookup_color
443 * tests/testgtkrc: use symbolic colors for making
446 2005-11-22 Michael Natterer <mitch@imendio.com>
448 Made button-press timeouts which work like key repeat timeouts
449 configurable. Addresses bug #142582:
451 * gtk/gtksettings.c: added properties "gtk-timeout-initial" and
452 "gtk-timeout-repeat" which defalt to 200/20 (ms).
454 Use the values from GtkSettings instead of hardcoding them
455 (the repeat value is either taken as-is for fast repeat or
456 multiplied by 5 for slow repeat). Changed all places to use these
457 two standard initial/repeat timings:
459 * gtk/gtkcalendar.c (unchanged 200/20)
460 * gtk/gtknotebook.c (unchanged 200/100)
461 * gtk/gtkpathbar.c (changed from 300/150 to 200/100)
462 * gtk/gtkrange.c (changed from 250/100 to 200/100)
463 * gtk/gtkspinbutton.c (unchanged 200/20)
465 2005-11-21 Anders Carlsson <andersca@imendio.com>
473 * docs/tools/Makefile.am:
474 Only build docshooter when the X11 backend is used.
476 * gtk/gtkplug-stub.c:
477 Include gtkplug.h here.
479 * gtk/gtksocket-stub.c:
480 Include gtksocket.h here.
482 2005-11-21 Matthias Clasen <mclasen@redhat.com>
484 * gtk/gtkinputdialog.c: Convert GtkInputDialog to
485 g_type_class_add_private.
487 * gtk/gtksocket.c: Convert GtkSocket to g_type_class_add_private.
489 * gtk/gtkmenu.c: Convert GtkMenu to g_type_class_add_private.
492 * gtk/gtkcombobox.[hc]: Add a tearoff-title property,
493 with getter and setter. (#316482, Olexiy Avramchenko)
495 * tests/testcombo.c (main): Test gtk_combo_box_set_title
497 * gtk/gtkpathbar.c: Merge remaining fixes from the 2.8 branch,
498 pointed out by Michael Natterer.
500 Fix for bug #321542, Benedikt Meurer:
502 * gtk/gtkcombobox.c (gtk_combo_box_set_active_internal):
505 (gtk_combo_box_child_show, gtk_combo_box_child_hide): Use
506 g_signal_emit, not g_signal_emit_by_name.
508 2005-11-18 Matthias Clasen <mclasen@redhat.com>
510 Fix crashes in connection with pathbar scrolling (#321560,
513 * gtk/gtkpathbar.c (gtk_path_bar_update_slider_buttons):
514 Stop scrolling when desensitising slider buttons.
515 (gtk_path_bar_scroll_timeout, gtk_path_bar_slider_button_press):
518 * gtk/gtkpathbar.h (struct _GtkPathBar): Add a separate
521 2005-11-18 Matthias Clasen <mclasen@redhat.com>
523 * gtk/gtkpathbar.c (button_clicked_cb): Fix a C99ism.
524 (#321777, Jens Granseuer)
526 * gtk/gtkaction.c (disconnect_proxy): Disconnect the
527 sync callback for the visibility property. (#321761,
530 Turn off input methods in invisible entries, since
531 they are confusing. (#317002, James Su)
533 * gtk/gtkentry.c (gtk_entry_set_visibility): Toggle input
534 methods if visibility changes.
535 (popup_targets_received): Don't show the input method
536 menu if the entry is invisible.
538 2005-11-17 Matthias Clasen <mclasen@redhat.com>
540 * README.in: Add a note about range arrow sensitivity.
542 * perf/treeview.c: const correctness fixes
543 found by Arjan van de Ven and gcc.
545 2005-11-16 Michael Natterer <mitch@imendio.com>
547 * gtk/gtkimage.c (animation_timeout): call
548 gtk_window_process_updates() so the animation keeps running even
549 if the main loop is busy with sources that eat a lot of cpu with
550 high priority. Fixes bug #321444.
552 (gtk_image_new_from_animation): document the fact that the
553 animation will stop running if the main loop is busy with sources
554 that have priorities higher than G_PRIORITY_DEFAULT.
556 * tests/testimage.c: added test case that shows an animation even
557 though a cpu-eating idle function is running.
559 2005-11-16 Michael Natterer <mitch@imendio.com>
561 * gdk/x11/gdkevents-x11.c (_gdk_events_uninit): new internal
562 function which destroys the display's event source. Also removes
563 the source from the global display_sources list and unrefs it.
565 * gdk/x11/gdkprivate-x11.h: declare the function.
567 * gdk/x11/gdkdisplay-x11.c (gdk_display_x11_dispose): call it
568 instead of half-destroying the source here.
570 2005-11-15 Matthias Clasen <mclasen@redhat.com>
572 * gtk/gtktreestore.c (gtk_tree_store_move): Fix a memory
573 leak. (#321032, Peter Zelezny)
575 2005-11-15 Michael Natterer <mitch@imendio.com>
577 * gdk/x11/gdkdisplay-x11.c (gdk_display_x11_finalize): destroy
578 display->xid_ht as late as possible (right before XCloseDisplay)
579 because it still needs to be around when the display's screens are
582 2005-11-14 Matthias Clasen <mclasen@redhat.com>
584 * gtk/gtkselection.c (gtk_selection_data_set_uris): Don't
585 leak result. (#321441, Tommi Komulainen)
587 2005-11-14 Matthias Clasen <mclasen@redhat.com>
589 * gtk/gtkicontheme.c (gtk_icon_theme_get_icon_sizes):
590 Don't crash if there is no builtin icon.
592 2005-11-14 Michael Natterer <mitch@imendio.com>
594 * gtk/gtkcellrenderertoggle.c (gtk_cell_renderer_toggle_set_property):
595 removed redundant calls to g_object_notify().
597 2005-11-13 Matthias Clasen <mclasen@redhat.com>
599 * gdk/gdkcolor.c (gdk_color_parse): Documentation
600 improvements. (#321338)
602 * gtk/gtktextiter.c (gtk_text_iter_forward_search): Make
603 limit an inclusive boundary. (#321299)
605 2005-11-12 Michael Natterer <mitch@imendio.com>
607 * gtk/Makefile.am: fixed icon rules so gtkbuiltincache.h is only
610 2005-11-12 Dom Lachowicz <cinamod@hotmail.com>
612 * modules/engines/ms-windows/msw_style.c: Bug #313627. Make win32
613 theme's handling of toolbars, handleboxes, and menubars more in-line
614 with Microsoft's IE style.
615 * modules/engines/ms-windows/*.c: Indentation cleanups
617 2005-11-12 Matthias Clasen <mclasen@redhat.com>
619 Make builtin icons work in gtk_window_set_icon_name()
620 (#321046, Maxim Udushlivy)
622 * gtk/gtkicontheme.c (insert_theme): Always insert the default
624 (ensure_valid_themes): Call _gtk_icon_theme_ensure_builtin_cache()
626 (theme_lookup_icon, find_builtin_icon): ...and not from here.
627 (gtk_icon_theme_lookup_icon): Remove an unncessary assert.
628 (gtk_icon_theme_get_icon_sizes): Also check builtin icons.
630 2005-11-12 Tor Lillqvist <tml@novell.com>
632 * gtk/gtkfilesystemwin32.c (filename_get_info): Don't hide
633 dotfiles, no such convention on Win32. Just hide files with the
634 hidden attribute. (#314627)
636 2005-11-11 Federico Mena Quintero <federico@ximian.com>
638 * gtk/gtkfilechooserdefault.c (shortcuts_insert_path): Do not
639 check whether the path is a folder. It is useful to bookmark
640 files as well (e.g. todo.txt), and this will also help
642 (shortcuts_add_bookmark_from_path): Likewise.
643 (shortcuts_activate_iter): Change folders or select files, as
646 2005-11-11 Federico Mena Quintero <federico@ximian.com>
648 * tests/autotestfilechooser.c (main): Use
649 g_log_set_default_handler() instead of explicitly setting a
650 handler for each domain.
652 * gtk/gtkfilechooserdefault.c (shortcuts_add_volumes): Only get
653 the base path of the volume if it is mounted.
655 2005-11-11 Michael Natterer <mitch@imendio.com>
657 Added per-stepper API for GtkRange's stepper sensitivity as
658 discussed in bug #321056:
660 * gtk/gtkenums.h: added GtkSensitivityType which can be
663 * gtk/gtkrange.[ch]: added properties "lower-stepper-sensitivity"
664 and "upper-stepper-sensitivity" and public getters/setters for
665 them. Changed stepper drawing to honor the new properties.
667 * gtk/gtk.symbols: added the new symbols.
669 2005-11-10 Matthias Clasen <mclasen@redhat.com>
671 * gtk/gtkcombobox.c: Add show-popup and hide-popup signals and
672 emit them when the popup is shown or hidden. (#162531, Tommi
675 * tests/testcombo.c: Add an example of popuplating a combobox
678 * gtk/gtktreeview.c (gtk_tree_view_motion_resize_column): Another
681 * gdk/x11/gdkcolor-x11.c (gdkx_colormap_get): Remove an erroneous
684 Don't corrupt odd keymaps (#316638, Kean Johnston)
686 * gdk/x11/gdkkeys-x11.c (set_symbol): Auxiliary function to
687 handle frobbing keymaps with odd numbers of syms/code.
689 * gdk/x11/gdkkeys-x11.c (update_keymaps): Use set_symbol() to
692 Improve navigation to parent folders. (#318444, Andrei Yurkevich)
694 * gtk/gtkpathbar.[hc]: Add a child_path argument to
695 the path_clicked signal.
696 * gtk/gtkfilechooserdefault.c (path_bar_clicked): Select the
697 child_path, if it is provided.
698 * gtk/marshalers.list (path_bar_clicked): Add the necessary
701 * gtk/gtkmenu.c: Fix some compiler warnings. (#321141,
706 * gtk/gtktreeview.c: Implement a getter for headers-clickable.
707 (#163851, Richard Hult)
709 2005-11-10 Michael Natterer <mitch@imendio.com>
711 Applied patch from maemo-gtk that addresses many issues wrt
712 display migration and display closing (bug #85715).
714 * gdk/gdkdisplay.c (gdk_display_dispose): don't just set the
715 default display to NULL when it's closed. Instead set the most
716 recently opened display as new default (if one exists).
718 * gdk/gdkpango.c (on_renderer_display_closed): fixed signature
721 * gdk/gdkscreen.c (gdk_screen_dispose): check if the GCs still
722 exist before unrefing them.
724 * gdk/gdkwindow.c (_gdk_window_destroy_hierarchy): if the screen
725 is closed, allow destruction of the root window.
727 * gdk/x11/gdkdisplay-x11.c: moved some stuff from finalize() to
728 dispose(), free stuff that was leaked before.
730 * gdk/x11/gdkevents-x11.c (_gdk_x11_events_uninit_screen): check if
731 the xsettings_client still exists before destroying it.
733 * gdk/x11/gdkkeys-x11.c: added finalization and free the allocated
736 * gdk/x11/gdkpixmap-x11.c: moved stuff from finalize() to new
737 dispose() implementation.
739 * gdk/x11/gdkscreen-x11.c: moved stuff from finalize() to
740 dispose() and check if it still exists before unrefing it. Set
741 their pointers to NULL/None *after* upchaining in dispose(),
742 because X11 implementations of members of the parent class still
743 need them for their own destruction.
745 * gdk/x11/gdkvisual-x11.c: removed finalize() implementation which
746 was g_error()ing when finalizing a visual.
748 * gtk/gtkclipboard.c (gtk_clipboard_finalize): don't use
749 get_clipboard_widget() because it would create the widget if it
750 doesn't exist. Use g_object_get_data() directly instead.
752 * gtk/gtktextdisplay.c (on_renderer_display_closed): fixed signature
755 2005-11-10 Simos Xenitellis <simos@gnome.org>
757 * configure.in: Added Tatar (tt) to ALL_LINGUAS.
759 Wed Nov 9 16:29:42 2005 Tim Janik <timj@imendio.com>
761 * gtk/gtkrange.c: patch from maemo-gtk that changes GtkRange
762 to render its arrows insensitive when the adjustment is in
763 its min or max position. this makes range arrow behaviour
764 consistent with spin button behaviour. (#321056)
766 2005-11-09 Tor Lillqvist <tml@novell.com>
769 * gdk/gdk.c (gdk_debug_keys[]): Add new GDK_DEBUG_DRAW flag to
770 the GdkDebugFlag enum.
772 * gdk/win32/gdkdrawable-win32.c: Use DRAW to trigger GDK_NOTEs in
773 this file instead of MISC. Now asking for MISC will give mainly
774 window manipulation debugging output with the Win32 backend.
776 2005-11-09 Tor Lillqvist <tml@novell.com>
778 * gdk/win32/gdkwindow-win32.c: Remove unnecessary includes.
780 (_gdk_win32_get_adjusted_client_rect): Remove this two-line
781 function which was used only in one place.
783 (get_outer_rect): Use _gdk_win32_adjust_client_rect().
785 (gdk_window_set_geometry_hints): If we have identical minimum and
786 maximum size hints, remove the resize and maximize
787 decorations/functions. (#104514)
789 If we have a maximum size hint, remove the maximize
790 decoration/function but ensure the resize decoration/function is
791 available. Otherwise ensure both resize and maximize
792 decorations/functions are there.
794 (set_or_clear_style_bits): Factored out common code from
795 gdk_window_set_decorations() and gdk_window_set_functions().
797 Hack the window style setting once more: Only touch the window
798 style bits corresponding to the GdkWMDecoration or GdkWMFunction
799 parameter bitmasks. Hopefully this finally is the correct thing to
800 do. We used to clear all other bits than those that were being
801 set, or set all other bits than those that were being cleared.
803 Take into account that adding or removing decorations leaves the
804 window's outer size unchanged, i.e., the client area's size and
805 position change. This is apparently not what we want, so change
806 also the window's (outer) position and size appropriately so that
807 the client area's position and size stay constant.
809 gtk-demo's color selector dialog is now non-resizable like on X11
810 (I tested with metacity in GNOME). Torn off menus are shrinkable
811 vertically but have a maximum size, and are not maximizable or
812 minimizable, like on X11.
814 (gdk_window_set_decorations, gdk_window_set_functions): Let
815 set_or_clear_decorations() do most of the job.
817 * gdk/win32/gdkprivate-win32.h: Remove declaration of
818 _gdk_win32_get_adjusted_client_rect().
820 2005-11-09 Tor Lillqvist <tml@novell.com>
822 * gdk/win32/gdkwindow-win32.h (struct _GdkWindowImplWin32)
823 * gdk/win32/gdkwindow-win32.c (gdk_window_impl_win32_init,
824 gdk_window_get_type_hint, gdk_window_get_type_hint): Store the
825 type hint. Implement gdk_window_get_type_hint() by just returning
828 2005-11-09 Tor Lillqvist <tml@novell.com>
830 * gdk/win32/gdkwindow-win32.c (gdk_window_set_geometry_hints):
831 Remove code that has been permanently ifdeffed out for two years.
833 2005-11-08 Matthias Clasen <mclasen@redhat.com>
835 * gdk/gdkgc.c (gdk_gc_finalize): Unref tile and stipple when
836 finalizing a gc. (#320789, Nickolay V. Shmyrev)
838 * gdk/x11/gdkwindow-x11.c (gdk_window_set_icon_list): Ignore
839 icons if they would make the request large enough to cause
840 Xlib to loose the connection. (#320909, Claudio Saavedra)
842 2005-11-08 Michael Natterer <mitch@imendio.com>
846 * gdk/x11/gdkwindow-x11.c: added gdk_window_get_type_hint() (patch
847 extracted from maemo-gtk). Fixes bug #320872.
849 2005-11-07 Matthias Clasen <mclasen@redhat.com>
851 * gtk/gtkfilechooserdefault.c (shortcuts_reorder): Don't
852 looks the bookmark label when reordering. (#320720, Jeremy Cook)
854 * gtk/gtkpathbar.[hc]: Set focus-on-click to FALSE for all buttons.
855 Don't grab focus when a slider button is pressed, instead, use
856 a bit in the pathbar struct to determine whether to scroll up
857 or down. (#314486, Carlos Garnacho)
859 * gtk/gtkentrycompletion.c (_gtk_entry_completion_popup):
860 Don't popup the completions if the focus has already been
861 moved somewhere else. (#319914, Christian Persch)
863 * gtk/gtktoolitem.c (_gtk_tool_item_toolbar_reconfigured):
864 Raise the drag_window after reconfiguring the
865 toolbar. (#320803, Christian Persch)
868 * gtk/gtkfilechooserbutton.h:
869 * gtk/gtkfilechooserbutton.c: Add a focus-on-click property
870 with setter and getter. (#318945, Christian Persch)
872 Mon Nov 7 16:15:16 2005 Tim Janik <timj@imendio.com>
874 * configure.in: fixed missing $X_CFLAGS setup in case x11.pc is present.
876 2005-11-07 Matthias Clasen <mclasen@redhat.com>
878 * configure.in: Adjust to the stock icon changes.
880 2005-11-07 Tor Lillqvist <tml@novell.com>
882 * gdk/win32/gdkcursor-win32.c (pixbuf_to_hbitmaps_normal):
883 Correct the calculation of maskstride. (#320152, Peter Zelezny)
885 2005-11-06 Michael Natterer <mitch@imendio.com>
887 * gtk/Makefile.am (icons): fixed rule to actually create the
888 symlinks, erroring out if anything goes wrong.
890 2005-11-06 Tor Lillqvist <tml@novell.com>
892 * gtk/updateiconcache.c (build_cache): Can't rename a file if the
893 target exists on Win32. First rename the target temporarily, then
894 if the renaming of the source to target fails, restore the
895 original name for the target.
897 * gtk/Makefile.am: Use EXEEXT in the dependency on gtk-update-icon-cache.
899 2005-11-06 Tor Lillqvist <tml@novell.com>
901 (pixbuf_to_hbitmaps_alpha_winxp): Use an 1-bit mask bitmap,
902 like pixbuf_to_hbitmaps_normal().
903 (_gdk_win32_pixbuf_to_hicon_supports_alpha): Check
904 G_WIN32_IS_NT_BASED() first, so we can pretend being on Win9x by
905 setting the G_WIN32_PRETEND_WIN9X environment variable.
907 2005-11-06 Tor Lillqvist <tml@novell.com>
909 Make icon masks work on Win98 (#320152, Peter Zelezny)
911 * gdk/win32/gdkcursor-win32.c (create_color_bitmap): Take also a
912 parameter for the depth of the bitmap, so that this function can
913 be used to create 1-bit bitmaps, too.
914 (pixbuf_to_hbitmaps_normal): Create an 1-bit bitmap for the mask,
915 and initialize it properly.
917 2005-11-04 Matthias Clasen <mclasen@redhat.com>
919 Store builtin stock icons in an icon cache, instead of
920 populating a hash table with pixbufs at startup, to save both
921 memory and startup time.
923 * gtk/stock-icons/*: Reorganize the icons in a directory structure
924 suitable for gtk-update-icon-cache, and rename them to match the
927 * gtk/gtkiconcache.[hc]: Support non-mmapped icon caches, and
928 add _gtk_icon_cache_has_icon_in_directory().
930 * gtk/updateiconcache.c: Support a --source <VARIABLE> argument
931 to store the contents of the icon cache in a C header.
933 * gtk/gtkbuiltincache.h: Generated private header which contains
934 the icon cache for the builtin icons.
936 * gtk/gtkicontheme.c: Create a GtkIconCache for the builtin
937 icons, and use that in addition to the hash table whenever
938 builtin icons are searched.
940 * gtk/gtkiconfactory.c: Add GTK_ICON_SOURCE_STATIC_ICON_NAME and
941 use it for static stock ids.
942 (get_default_icons): Don't add the builtin
943 icons to the icon theme, just register the stock ids.
944 (render_fallback_image): Take the fallback image out of the
947 * gtk/Makefile.am: Remove stock-icons from SUBDIRS and add
948 the necessary machinery to rebuild gtkbuiltincache.h.
950 2005-11-04 Michael Natterer <mitch@imendio.com>
952 * gtk/gtkrc.c (gtk_rc_reparse_all_for_settings): applied patch
953 from maemo-gtk that changes the mtime check for rc files from
954 '>' to '!=', otherwise theme changes go unnoticed when turning
955 back the clock (Tommi Komulainen).
957 2005-11-04 Tor Lillqvist <tml@novell.com>
959 * gtk/gtkstatusicon.c (gtk_status_icon_set_tooltip): Plug memory
962 2005-11-03 Tor Lillqvist <tml@novell.com>
964 * gdk/win32/gdkcursor-win32.c: As there is only one GdkDisplay in
965 the Win32 backend, check that GdkDisplay* parameters are equal to
966 _gdk_display instead of using the unnecessarily general
969 (pixbuf_to_hbitmaps_alpha_winxp): Rename the variables for the
970 color bitmap to have "color" in their name, for similarity with
971 pixbuf_to_hbitmaps_normal(). Create a color bitmap for the mask,
972 too, instead of creating a b&w bitmap with CreateBitmap(). Set up
973 the mask bitmap's contents, ones for those pixels in the color
974 bitmap where the alpha is zero, zero for other pixels. We used to
975 use an uninitialized mask bitmap! This meant that icons and
976 cursors created presumably worked more or less by accident.
977 Totally blank icons with zero alpha everywhere (as used by
978 gtktrayicon.c) definitely did not work as expected.
980 * gtk/Makefile.am: Include gtkstatusicon.c on all platforms.
982 * gtk/gtkstatusicon.c: Implement for Win32. Use code from
983 gtktrayicon-win32.c as applicable. (gtktrayicon-win32.c is not
984 necessary and can be removed from CVS. It has never been mentioned
985 in gtk/Makefile.am.) No tray icon widget, GtkImage or GtkTooltips
986 are used on Win32. One label widget is used (but never shown) as
987 gtk_widget_render_icon() needs a widget.
989 Ifdefs used as necessary in several places. It might be cleaner to
990 split out the backend-specific parts to separate files, or at
991 least collect them into separate blocks in the file.
993 (wndproc): New function. Window procedure to monitor mouse events
994 in the system tray icon. Call gtk_status_icon_button_press() as
996 (create_tray_observer): New function. Creates a hidden window that
997 only serves as a tray icon message observer.
999 * tests/teststatusicon.c (icon_activated): Position the dialog
1000 with GTK_WIN_POS_CENTER.
1001 (do_quit): New function, hide and unref the GtkStatusIcon, and
1002 call gtk_main_quit().
1003 (popup_menu): Add a Quit menu item that calls do_quit().
1005 2005-11-02 Tor Lillqvist <tml@novell.com>
1007 * gdk/win32/gdkcolor-win32.c
1008 * gdk/win32/gdkscreen-win32.c
1009 * gdk/win32/gdkwindow-win32.c: Whitespace consistency
1010 fixes. Remove superfluous test for GdkWindow* parameters being
1011 non-NULL. Testing GDK_IS_WINDOW() is enough. As there is only one
1012 GdkScreen and one GdkDisplay in the Win32 backend, use those
1013 variables instead of the getter functions. For GdkDisplay* and
1014 GdkScreen* parameters, check that they are equal to the
1015 corresponding singleton variables instead of the more general
1016 GDK_IS_DISPLAY() or GDK_IS_SCREEN().
1018 2005-11-02 Matthias Clasen <mclasen@redhat.com>
1020 * gtk/gtktextview.c: Remove some g_return_if_fail() from
1021 static functions, replace some others by g_assert().
1023 * gtk/gtktextview.c (selection_motion_event_handler)
1024 (gtk_text_view_start_selection_drag): Keep track of the original
1025 selection boundaries during a drag selection, in order to correctly
1026 decide when to extend or shrink the selection. (#320167,
1027 reported by Arvind S N, patch by Paolo Borelli)
1029 * gtk/gtktextbtree.c (_gtk_text_line_char_to_byte_offsets):
1030 * gtk/gtktextiter.c (gtk_text_iter_backward_chars): Replace
1031 manual offset calculations by g_utf8_offset_to_pointer().
1032 (#320360, Paolo Borelli)
1034 Tue Nov 1 16:18:24 2005 Tim Janik <timj@imendio.com>
1036 * gtk/gtkrbtree.[hc]: get rid of GAllocator usage, allocate and free
1037 nodes via the g_slice_*() API.
1038 _gtk_rbtree_new(): fixed wrong node allocation via g_new().
1040 2005-11-01 Tor Lillqvist <tml@novell.com>
1042 * gdk/win32/gdkprivate-win32.h
1043 * gdk/win32/gdkglobals-win32.c
1044 * gdk/win32/gdkmain-win32.c (_gdk_windowing_init): Add more
1045 pre-interned GdkAtoms and pre-registered clipboard formats. Sort
1046 their declarations, definitions and assignments into a more
1047 logical and consistent order.
1049 * gdk/win32/gdkmain-win32.c (_gdk_win32_cf_to_string): Include the
1050 CF_ prefix for the predefined clipboard format names. Put quotes
1051 around registered format names to distinguish them.
1053 * gdk/win32/gdkproperty-win32.c (gdk_property_change): Return
1054 immediately with a warning if the property type is STRING, TEXT,
1055 COMPOUND_TEXT or SAVE_TARGETS, as these are X11-specific that we
1056 should never pretend to handle on Win32. Handle only UTF8_STRING
1057 here, other formats with delayed rendering. Use \uc1 instead of
1058 \uc0 when generating Rich Text Format for easier testability on
1059 XP, where WordPad misinterprets \uc0 encoded characters. Add more
1060 GDK_NOTE debugging output for Clipboard operations.
1062 * gdk/win32/gdkselection-win32.c: Debugging printout improvements.
1063 (gdk_selection_convert): Don't pretent to handle STRING, just
1064 UTF8_STRING. Streamline error handling, don't unnecessarily have a
1065 GError which then isn't used for anything anyway if it gets set.
1066 (gdk_win32_selection_add_targets): Skip also STRING, TEXT,
1067 COMPOUND_TEXT and SAVE_TARGETS in addition to UTF8_STRING.
1069 * config.h.win32.in: Sync with what configure produces.
1071 * configure.in: Don't look for X_PACKAGES unless building for
1072 x11. (#313986, John Ehresman)
1074 2005-10-28 Erdal Ronahi <erdal.ronahi@gmail.com>
1076 * configure.in: Added ku (Kurdish) to ALL_LINGUAS
1077 Wondered why there was no ku there before??
1079 2005-10-28 Matthias Clasen <mclasen@redhat.com>
1081 * gtk/gtkentrycompletion.c (_gtk_entry_completion_popup): Add the popup
1082 window to the toplevels window group. (#319912, Christian Persch)
1084 2005-10-28 Kristian Rietveld <kris@gtk.org>
1086 * gtk/gtktreemodelfilter.c (gtk_tree_model_filter_row_deleted): fix
1089 2005-10-28 Matthias Clasen <mclasen@redhat.com>
1091 * gtk/gtkdnd.c (gtk_drag_get_cursor): Fix the anchor of the default
1092 drag cursors. (#319200, Federico Mena Quintero)
1094 * gtk/gtktreeview.c (gtk_tree_view_search_key_press_event): Handle
1095 Shift-G to go to the previous match, like firefox. (#320061, Christian
1098 * gtk/gtktreemodelfilter.c (gtk_tree_model_filter_build_level): Fix a
1099 C99ism. (#320000, Kazuki Iwamoto)
1101 * gtk/gtkaboutdialog.c (gtk_about_dialog_init): Add the little
1102 stars. (#319985, Bastien Nocera)
1104 * gtk/gtktreeview.c (gtk_tree_view_search_entry_flush_timeout): Return
1105 FALSE, so we don't flush repeatedly. (#319151, Alexander Larsson)
1107 2005-10-26 Michael Natterer <mitch@imendio.com>
1111 * gtk/gtkcellrendererpixbuf.c (gtk_cell_renderer_pixbuf_set_property):
1112 make sure that setting any of pixbuf/stock-id/icon-name resets the
1113 others because they are mutually exclusive, and that unsetting any
1114 of them only resets the pixbuf and nothing else. Also added
1115 some missing g_object_notify().
1117 (gtk_cell_renderer_pixbuf_get_property): simplified calls to
1118 g_value_set_object().
1120 (gtk_cell_renderer_pixbuf_create_stock_pixbuf)
1121 (gtk_cell_renderer_pixbuf_create_named_icon_pixbuf): added
1122 g_object_notify ("pixbuf").
1124 2005-10-27 Matthias Clasen <mclasen@redhat.com>
1126 * gtk/gtktreeview.c (gtk_tree_view_button_press): Be more
1127 careful about initializing cell_area. (#319382, Tommi
1130 * gtk/gtkcombobox.c (gtk_combo_box_key_press): Don't eat
1131 Ctrl-PageUp/PageDown. (#318670, Christian Neumair)
1133 * demos/gtk-demo/clipboard.c (paste_received): Only set the
1134 text if it is not NULL. (#319930, Thomas Klausner)
1136 * gtk/gtkselection.c (gtk_selection_data_get_pixbuf): Close the
1137 loader before trying to get the pixbuf. (#319930, Thomas Klausner)
1139 2005-10-26 Matthias Clasen <mclasen@redhat.com>
1141 * gtk/gtkfilesystem.c (gtk_file_system_module_load):
1142 * gtk/gtkthemes.c (gtk_theme_engine_load):
1143 * gtk/gtkimmodule.c (gtk_im_module_load): Use G_MODULE_BIND_LAZY
1144 when dlopening modules. (#319557, Laszlo Peter)
1146 2005-10-26 Matthias Clasen <mclasen@redhat.com>
1148 * gtk/gtktextbtree.c (gtk_text_btree_resolve_bidi): Only use text
1149 segments when determining text direction. (#319065, Tommi Komulainen)
1151 * gtk/gtktreeview.c (gtk_tree_view_destroy): Don't crash
1152 on duplicate destroy. (#318953, Gustavo Carneiro)
1154 * gtk/gtkfilechooserbutton.c (gtk_file_chooser_button_new_with_dialog):
1155 Point out that destroy-with-parent is a bad idea for the dialog
1156 passed to this function. (#318943, Christian Persch)
1158 * */Makefile.am: use $(GLIB_MKENUMS) instead of
1159 glib-mkenums. (#318582, Damien Carbery)
1161 * gtk/gtktreemodel.c (gtk_tree_model_rows_reordered): Clarify
1162 docs. (#317682, Christian Neumair)
1164 * gdk/x11/gdkdnd-x11.c: Remove an extra const which doesn't
1165 seem to affect the placement of the data in the readonly
1166 section, and causes problems with some compilers. (#317844)
1168 2005-10-25 Matthias Clasen <mclasen@redhat.com>
1170 * gtk/gtktreeviewcolumn.c (gtk_tree_view_column_cell_process_action):
1171 Fix some issues with background drawing in RTL. (#318781,
1174 * tests/Makefile.am:
1175 * tests/testentrycompletion.c: Apply a patch by Christian
1176 Persch to add property editors.
1178 * gtk/gtkstatusicon.c: Emit activate on single-click,
1179 not on double-click, change proposed by Milosz Derezynski.
1181 2005-10-25 Kristian Rietveld <kris@gtk.org>
1183 Fixes #311955, reported by Markku Vire; and a lot more.
1185 * gtk/gtktreemodelfilter.c: Made this thing work correctly.
1186 Levels can now have invisible nodes cached, functions have been
1187 rewritten/refactored to take this into account; also the logic in
1188 some functions has been corrected.
1190 Each referenced node now references all visible children or a single
1191 invisible child, in order to be able to monitor all changes in the
1192 child model required for correct operation.
1194 When a virtual root is set, all nodes on the virtual root level are
1197 At last, a bunch of random bug fixes and comment updates.
1199 2005-10-25 Matthias Clasen <mclasen@redhat.com>
1201 * gtk/gtktexttagtable.c (gtk_text_tag_table_foreach): Add some
1202 more docs. (#319722, Paolo Borelli)
1204 * gdk/x11/gdkxftdefaults.c (init_xft_settings): Make the
1205 initialization of screen_x11->xft_rgba more explicit. (#319627,
1208 * gtk/gtkfilechooser.c (gtk_file_chooser_class_init): Fix whitespace
1209 in a blurb. (#319499, Francisco Javier F. Serrador)
1211 2005-10-24 Matthias Clasen <mclasen@redhat.com>
1213 Add settings to hide the input method and Unicode control character
1214 submenus in the context menus of GtkEntry and GtkTextView.
1216 * gdk/x11/gdkevents-x11.c: Map GTK+ settings to X settings.
1218 * gtk/gtksettings.c (gtk_settings_class_init): Declare GTK+ settings here.
1220 * gtk/gtktextview.c (popup_targets_received):
1221 * gtk/gtkentry.c (popup_targets_received): Use the settings here.
1223 2005-10-24 Kristian Rietveld <kris@gtk.org>
1225 * gtk/gtktreemodelsort.c (gtk_tree_model_sort_row_inserted): emitting
1226 row-has-child-toggled when the level is not in the cache does not
1227 make sense. (This bug probably crept in during the early stages
1228 of GtkTreeModelSort when there wasn't a correct row-has-child-toggled
1229 implementation yet),
1230 (gtk_tree_model_sort_real_unref_node): only get the child iter
1231 when we will actually also use it.
1233 2005-10-22 Michael Natterer <mitch@imendio.com>
1235 * gtk/gtktreeview.c (gtk_tree_view_scroll_to_cell): check for the
1236 widget being realized, in addition to being visible, to avoid
1237 running into precondition check in gtk_tree_view_get_cell_area().
1240 2005-10-22 Dom Lachowicz <cinamod@hotmail.com>
1242 * modules/engines/ms-windows/msw_style.c (setup_msw_rc_style):
1243 Experimentally, scrollbar steppers can shrink to 8 pixels on
1244 Win32. Reflect that in the theme.
1245 * modules/engines/ms-windows/Theme/gtk-2.0/gtkrc: Experimentally,
1246 there is a 1-pixel border between a scrollbar and its child
1247 in ScrolledWindows on Win32. Reflect that in the theme.
1249 2005-10-20 Matthias Clasen <mclasen@redhat.com>
1251 * gtk/gtklabel.c (gtk_label_create_window): Use GDK_WINDOW_CHILD
1252 for the selection window. (#318806, Alex Larsson)
1254 2005-10-18 Federico Mena Quintero <federico@ximian.com>
1258 * tests/autotestfilechooser.c
1259 (test_button_folder_states_for_action): Test that we have either
1260 $cwd or the explicitly-set folder.
1261 (test_reload_sequence): Likewise.
1263 * gtk/gtkfilechooserdefault.c
1264 (gtk_file_chooser_default_get_current_folder): If our reload_state
1265 is RELOAD_EMPTY, return a GtkFilePath corresponding to $cwd.
1267 2005-10-14 Tor Lillqvist <tml@novell.com>
1269 * gdk/win32/gdkdisplay-win32.c: Remove the clipboard viewer code.
1270 It didn't really do anything useful, and was just confusing and
1271 incomplete. Comments claimed we don't do delayed rendering, but in
1272 fact we do, for images. (The delayed rendering code has other
1273 problems, though, see #168173.) The clipboard viewer code was
1274 probably even buggy (the WM_CHANGECBCHAIN handled didn't propagate
1275 the message when necessary). It was just test code, it said so in
1276 a comment. Add something similar back later if necessary.
1278 (_win32_on_clipboard_change,
1279 _gdk_win32_register_clipboard_notification): Remove.
1281 (gdk_display_supports_selection_notification,
1282 gdk_display_request_selection_notification): Always just return
1283 FALSE. We didn't generate any GDK_OWNER_CHANGE events anywhere.
1285 2005-10-13 Tor Lillqvist <tml@novell.com>
1287 * gdk/win32/gdkevents-win32.c (gdk_event_translate): Don't treat
1288 Alt-Enter specially. It does not have any special meaning and
1289 should be passed on to the application. (#318378, Tim Evans)
1291 2005-10-13 Tor Lillqvist <tml@novell.com>
1293 Set visual depth to 24 for 32 bits-per-pixel devices on
1294 Win32. This allows gdk_drawable_real_draw_pixbuf() to use the
1295 optimized composite_0888() function rather than the slower image
1296 dithering functions to draw pixbufs (#313993, John Ehresman)
1298 * gdk/win32/gdkimage-win32.c (_gdk_win32_new_image): Use
1299 _gdk_windowing_get_bits_for_depth() to initialize
1300 GdkImage::bits_per_pixel.
1301 (_gdk_windowing_get_bits_for_depth): Return 32 bits for depth 24.
1303 * gdk/win32/gdkpixmap-win32.c (gdk_pixmap_new): Use
1304 _gdk_windowing_get_bits_for_depth() to initialize
1305 BITMAPINFOHEADER::biBitCount.
1307 * gdk/win32/gdkvisual-win32.c (_gdk_visual_init): Set
1308 GdkVisual::depth to 24 even if GetDeviceCaps(BITSPIXEL) returns
1311 2005-10-12 Stefan Kost <ensonic@users.sf.net>
1313 * demos/gtk-demo/appwindow.c: (about_cb):
1314 use PACKAGE_VERSION,bump year (#318654)
1316 2005-10-11 Matthias Clasen <mclasen@redhat.com>
1318 * gtk/gtktextbtree.c (_gtk_text_btree_delete): Try to match an off
1319 toggle here with the matching on toggle if it immediately follows.
1320 This is a common case, and handling it here prevents quadratic blowup
1321 in cleanup_line() below. (#317125)
1323 * gtk/gtktextsegment.h:
1324 * gtk/gtktextsegment.c (_gtk_char_segment_new_from_two_strings): Pass
1325 the character counts into this function instead of computing them
1328 2005-10-10 Tommi Komulainen <tommi.komulainen@iki.fi>
1330 * gtk/gtkfilechooser.h (GtkFileChooserError): Add ALREADY_EXISTS error
1332 * gtk/gtkfilechooserdefault.c
1333 (gtk_file_chooser_default_add_shortcut_folder): Return an error code
1334 when the shortcut already exists in the sidebar. (#147521)
1336 2005-10-09 Matthias Clasen <mclasen@redhat.com>
1338 * tests/testcombo.c: Demonstrate how to use custom widgets in
1341 2005-10-07 Federico Mena Quintero <federico@ximian.com>
1345 * tests/autotestfilechooser.c (test_reload_sequence): Ensure that
1346 the the result of gtk_file_chooser_get_folder() is NULL or
1347 non-NULL at the right times. Log the tests.
1348 (test_button_folder_states): New test for the initial states of
1349 the current folder in GtkFileChooserButton.
1350 (main): Test that the number of warnings/errors/critical errors is
1353 * gtk/gtkfilechooser.c (gtk_file_chooser_get_current_folder):
1354 Clarify the documentation on when this can return NULL.
1355 (gtk_file_chooser_get_current_folder_uri): Likewise.
1357 * gtk/gtkfilechooserbutton.c (struct
1358 _GtkFileChooserButtonPrivate): Added a folder_has_been_set flag;
1359 we use it to keep track of whether a folder has been set.
1360 (gtk_file_chooser_button_map): Implement. If no folder has been
1361 loaded before, we at least try to load $cwd here.
1362 (gtk_file_chooser_button_constructor): If the construct-time
1363 dialog already has a folder set, turn on our folder_has_been_set
1365 (dialog_current_folder_changed_cb): Turn on our
1366 folder_has_been_set flag.
1368 2005-10-07 Michael Natterer <mitch@gimp.org>
1370 * gtk/gtkfilechooserdefault.c: remove some explicit #defines of
1371 PROFILE_FILE_CHOOSER because they break compilation after the
1372 removal of <unistd.h>.
1374 2005-10-07 Matthias Clasen <mclasen@redhat.com>
1376 * gtk/gtkfilechooserdefault.c: Properly fix the unistd.h include
1377 by moving it out of the profiling ifdef.
1379 * gtk/gtkfilechooserdefault.c: Remove a redundant (and
1380 unconditional) include of unistd.h (#318211, Kazuki Iwamoto)
1382 * gtk/gtktexttag.c (gtk_text_attributes_ref): Use
1383 g_return_val_if_fail(), not g_return_if_fail(). (#318412,
1386 2005-10-06 Matthias Clasen <mclasen@redhat.com>
1389 * gtk/gtktextbuffer.h:
1390 * gtk/gtktextbuffer.c: Add a readonly has-selection property
1391 with a getter. (#318161, Paolo Borelli)
1393 2005-10-05 Matthias Clasen <mclasen@redhat.com>
1395 * README.in: Start collecting release notes for 2.10.
1397 * gtk/gtkrc.c (gtk_rc_clear_realized_style): Readd the memory
1398 leak fix, since the assertion failures were traced to
1399 an xchat bug. (#314696)
1401 * gtk/gtkstyle.c (gtk_style_detach):
1402 (gtk_style_attach): Documentation improvements.
1403 (gtk_style_detach): Assert that the attach_count is > 0.
1405 2005-10-04 Federico Mena Quintero <federico@ximian.com>
1407 * gtk/gtkfilechooserdefault.c (switch_to_shortcut): Take a
1408 shortcut position, not a ShortcutsIndex, to make the function more
1410 (home_folder_handler): Pass the resolved index to
1411 switch_to_shortcut(), rather than just SHORTCUTS_HOME.
1412 (desktop_folder_handler): Likewise for SHORTCUTS_DESKTOP.
1413 (gtk_file_chooser_default_class_init): Add a "quick-bookmark"
1414 binding signal, and bind it to Alt-1, Alt-2. ..., Alt-0. These
1415 make the respective key switch to the first, second, ..., tenth
1417 (quick_bookmark_handler): Implement.
1419 2005-10-04 Federico Mena Quintero <federico@ximian.com>
1421 * gtk/gtkpathbar.c (get_dir_name): Don't special-case Home and
1422 Desktop; just use their real names on the file system for the
1425 * gtk/gtkfilechooserdefault.c
1426 (gtk_file_chooser_default_class_init): Add a "desktop-folder"
1427 binding signal, and bind it to M-d by default.
1428 (desktop_folder_handler): Implement the default handler.
1429 (home_folder_handler): Use a helper function.
1430 (switch_to_shortcut): New helper function.
1431 (shortcuts_append_home): Don't special-case the name of "Home";
1432 just use the folder name.
1434 2005-10-04 Tor Lillqvist <tml@novell.com>
1436 * gtk/gtkcalendar.c (gtk_calendar_init): Make it compile without
1437 HAVE__NL_TIME_FIRST_WEEKDAY. (#317910, Mathias Hasselmann)
1439 2005-10-04 Matthias Clasen <mclasen@redhat.com>
1441 * gtk/gtkrc.c (gtk_rc_clear_realized_style): Revert the change
1442 from yesterday, since it leads to assertion failures. (#317879,
1445 2005-10-03 Matthias Clasen <mclasen@redhat.com>
1447 * gtk/gtkcalendar.c (gtk_calendar_init): Call
1448 calendar_compute_days() after setting priv->week_start.
1450 2005-10-03 Matthias Clasen <mclasen@redhat.com>
1452 * gtk/gtkrc.c (gtk_rc_clear_realized_style): Unref the style when
1453 removing it from the hash table. (#314696, Benjamin Berg)
1455 2005-10-01 Tor Lillqvist <tml@novell.com>
1457 * gdk/win32/gdkdrawable-win32.c (blit_from_pixmap): In case
1458 BitBlt() fails with ERROR_INVALID_HANDLE, the most probable cause
1459 is that the the desktop isn't visible because the session has been
1460 switched, the screen is locked, or a terminal server session
1461 disconnected, so no error message necessary. (#137796)
1463 It is of course remotely possible that BitBlt() failing with
1464 ERROR_INVALID_HANDLE might also be caused by some other
1465 problem. We could strive for perfection and track whether the
1466 desktop is visible by using WTSRegisterSessionNotification() and
1467 handling WM_WTSESSION_CHANGE. I think that's overdoing it just for
1468 this issue, though. If we would track desktop visibility, we
1469 should then avoid even trying to update the display at all while
1470 the desktop isn't visible.
1472 2005-09-30 Matthias Clasen <mclasen@redhat.com>
1474 * gtk/gtkcalendar.c (gtk_calendar_init): Another attempt
1475 to correct the calculations for the first week day. We may
1476 just have to remove this code if too many locales turn out
1477 to have broken data.
1479 * gtk/gtkimage.c (gtk_image_expose): Don't leak pixbuf in
1480 some cases. (#317611, Tommi Komulainen)
1482 * gtk/gtksocket-x11.c (_gtk_socket_windowing_size_request):
1483 Prevent overflow when storing size hints in an unsigned
1484 short variable. Tracked down by Ray Strode and Søren Sandmann.
1486 2005-09-29 Matthias Clasen <mclasen@redhat.com>
1488 * gtk/gtkbutton.c (gtk_button_set_image): Check arguments. (#317491,
1491 * gtk/gtkpaned.c (gtk_paned_grab_notify): Stop drags when being
1492 grab shadowed. (#317332)
1494 2005-09-29 Tor Lillqvist <tml@novell.com>
1496 * gtk-zip.sh.in: DLLs are always in bin nowadays, no need to test.
1498 2005-09-28 Federico Mena Quintero <federico@ximian.com>
1500 * tests/autotestfilechooser.c (test_reload_sequence): Oops, return
1501 if the unmap test fails.
1502 (test_reload_sequence): Use gtk_widget_show_now() instead of
1503 gtk_widget_show() for the dialog.
1504 Thanks to Tim Janik for noticing these.
1506 2005-09-28 Federico Mena Quintero <federico@ximian.com>
1508 * tests/testcellrenderertext.c: New file with a set of tests for
1509 GtkCellRendererText. The idea is to run a text renderer through
1510 most of its interesting property values to see that it works
1513 * tests/Makefile.am: Added testcellrenderertext.
1515 * gtk/gtkfilechooserdefault.c (load_set_model): Mark the
1516 entry/exit of this function for profiling.
1517 (gtk_file_chooser_default_style_set): Mark the start/end of the
1518 calls to the parent class and the the signal emission for profiling.
1520 2005-09-29 Tor Lillqvist <tml@novell.com>
1522 * gtk/gtkmain.c (_gtk_get_localedir): The locale directory is
1523 passed to bindtextdomain() which isn't UTF-8-aware, so convert to
1524 system codepage using g_win32_locale_filename_from_utf8().
1525 (#317457, Kazuki Iwamoto)
1527 2005-09-28 Matthias Clasen <mclasen@redhat.com>
1529 * gtk/gtkselection.c (_gtk_selection_request): Free mult_atoms
1530 here. (#317039, Paolo Borelli)
1533 * gtk/gtktexttag.c (gtk_text_attributes_ref): Return the attributes
1534 to make this function work as boxed copy function. (#317455,
1537 * gtk/gtkclipboard.c (request_image_received_func): Don't unref
1538 NULL. (#316828, Tor Lillqvist)
1540 2005-09-28 Tor Lillqvist <tml@novell.com>
1542 * modules/input/imime.c: Include <config.h>. (#317444, Kazuki
1545 2005-09-27 Federico Mena Quintero <federico@ximian.com>
1547 Don't reload the current folder unnecessarily on ::map().
1549 * gtk/gtkfilechooserprivate.h (ReloadState): New enum to represent
1550 the reloading state.
1551 (struct _GtkFileChooserDefault): Added a "reload_state" field.
1553 * gtk/gtkfilechooserdefault.c (gtk_file_chooser_default_init):
1554 Initialize impl->reload_state.
1555 (gtk_file_chooser_default_map): Check the impl->reload_state; load
1556 a default folder if no folder has been set, or reload the current
1557 one only if we had been unmapped first.
1558 (gtk_file_chooser_default_update_current_folder): Set the
1559 reload_state to RELOAD_HAS_FOLDER.
1560 (gtk_file_chooser_default_unmap): Implement, and set the
1561 reload_state to RELOAD_WAS_UNMAPPED.
1562 (shortcuts_model_create): Don't call shortcuts_add_bookmarks()
1563 here; they'll get (re)loaded on ::map() anyway.
1565 * gtk/gtkfilechooserwidget.c
1566 (gtk_file_chooser_widget_constructor): Don't set a default folder here.
1568 * tests/autotestfilechooser.c (test_action_widgets): Don't take in
1569 a dialog; build it ourselves.
1570 (test_reload): New test to ensure that we don't load the default
1571 folder more than once, and that we reload it when
1572 unmapping/remapping.
1573 (get_impl_from_dialog): New utility function.
1574 (test_widgets_for_current_action): Use get_impl_from_dialog().
1576 2005-09-27 Federico Mena Quintero <federico@ximian.com>
1578 * gtk/gtkfilechooserdefault.c
1579 (gtk_file_chooser_default_constructor): Mark the entry/exit of
1580 this function for profiling.
1581 (check_icon_theme): Likewise.
1582 (change_icon_theme): Likewise.
1583 (settings_notify_cb): Likewise.
1584 (gtk_file_chooser_default_screen_changed): Likewise.
1585 (update_chooser_entry): If the selection is empty, clear the file
1586 name entry only if we are in CREATE_FOLDER mode. In SAVE mode,
1587 nothing will be selected when the user starts typeahead in the
1588 treeview, and we don't want to clear the file name entry in that
1589 case --- the user could be typing-ahead to look for a folder name.
1590 Fixes bug #308332, patch by Jürg Billeter.
1592 2005-09-27 Matthias Clasen <mclasen@redhat.com>
1594 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
1595 Pop below the entry if there's more free space below the entry
1596 than above. (#316948, Tommi Komulainen)
1598 2005-09-26 Federico Mena Quintero <federico@ximian.com>
1600 Do not create the save mode-specific widgets in the open modes, so
1601 that we don't carry their baggage around.
1603 * gtk/gtkfilechooserdefault.c
1604 (gtk_file_chooser_default_constructor): Don't create the
1606 (save_widgets_create): Set the impl->save_widgets directly here,
1607 instead of passing the widgets back to the caller. Also, pack
1608 them into the impl's box.
1609 (update_appearance): Create or destroy the save widgets as
1610 appropriate. Set the action of the save_file_name_entry here.
1611 (shortcuts_add_current_folder): Set the active item in the
1612 save_folder_combo only if it exists.
1613 (gtk_file_chooser_default_set_property): Don't set the action of
1614 the save_file_name_entry here.
1615 (gtk_file_chooser_default_update_current_folder): Set the base
1616 folder of the save_file_name_entry only if the entry exists.
1617 (shortcuts_drag_data_received_cb): Cast the selection_data->data
1618 to (const char *) since that's what shortcuts_drop_uris() expects.
1619 (file_list_drag_data_received_cb): Likewise, for
1620 g_uri_list_extract_uris().
1622 2005-09-26 Tor Lillqvist <tml@novell.com>
1624 * gdk/win32/gdkwindow-win32.c (gdk_window_shape_combine_mask): Set
1625 the shaped flag here, too. (#316871)
1626 (gdk_window_shape_combine_region): Currently unimplemented, so
1627 don't do anything to the shaped flag here.
1629 2005-09-26 Matthias Clasen <mclasen@redhat.com>
1631 Fix #316871, reported by Dan Winship:
1633 * gdk/gdkwindow.h (struct _GdkWindowObject): Add a shaped flag.
1635 * gdk/x11/gdkwindow-x11.c (gdk_window_shape_combine_mask)
1636 (gdk_window_shape_combine_region): Set it here.
1638 * gdk/gdkwindow.c (gdk_window_invalidate_maybe_recurse): Don't
1639 remove the child area for shaped windows.
1641 2005-09-23 Matthias Clasen <mclasen@redhat.com>
1643 * gtk/gtkcellrendererpixbuf.c (gtk_cell_renderer_pixbuf_finalize):
1644 Don't leak expander pixbufs. (#316946, Tommi Komulainen)
1646 2005-09-22 Michael Natterer <mitch@imendio.com>
1648 Renamed GtkCellRendererKeys to GtkCellRendererAccel to be
1649 consistent with GTK+ terminology:
1651 * gtk/gtkcellrendererkeys.[ch]
1652 * tests/testkeys.c: removed...
1654 * gtk/gtkcellrendereraccel.[ch]
1655 * tests/testaccel.c: ...and added.
1660 * tests/Makefile.am: changed accordingly.
1662 2005-09-22 Matthias Clasen <mclasen@redhat.com>
1664 * gtk/gtkwidget.c (gtk_widget_class_init): Fix the documentation
1665 for the grab-broken-event signal, noticed by Damon Chaplin.
1667 2005-09-21 Tor Lillqvist <tml@novell.com>
1669 * gdk/win32/gdkselection-win32.c (gdk_selection_convert,
1670 gdk_text_property_to_text_list_for_display,
1671 gdk_text_property_to_utf8_list_for_display,
1672 gdk_win32_selection_add_targets,
1673 _gdk_win32_selection_convert_to_dib): Free return value from
1675 (gdk_text_property_to_text_list_for_display): Drop GError variable
1676 that isn't actually used after being set.
1678 2005-09-20 Johan Dahlin <jdahlin@async.com.br>
1680 * gtk/gtkentry.c (gtk_entry_set_completion): Mention NULL in
1683 2005-09-20 Tor Lillqvist <tml@novell.com>
1685 * gdk/win32/gdkselection-win32.c
1686 (gdk_selection_owner_get_for_display): Do return the correct owner
1687 for CLIPBOARD (i.e., the owner of the Windows Clipboard, if it is
1688 a window GDK knows about). The reason to return NULL seems to have
1689 gone when in the fix for bug #163702 the artificial
1690 GDK_SELECTION_CLEAR event generation was removed from
1691 gdk_selection_send_notify_for_display(). Fixes bug #316552.
1693 2005-09-20 Matthias Clasen <mclasen@redhat.com>
1695 Avoid unnecessary XkbGetState() calls and XkbStateNotify
1696 events. (#151555, Søren Sandmann)
1698 * gdk/x11/gdkdisplay-x11.c (gdk_display_open): Use
1699 XkbSelectEventDetails() to select XkbStateNotify events
1700 for only the state we care about.
1702 * gdk/x11/gdkprivate-x11.h:
1703 * gdk/x11/gdkkeys-x11.c (_gdk_keymap_state_changed): Pass
1704 the event into the function and update the keymap state from
1705 the state information contained in the event. Adjust all callers.
1707 2005-09-19 Matthias Clasen <mclasen@redhat.com>
1709 * gtk/gtkiconview.c: Use g_list_nth_data() instead of g_list_nth()->data
1710 in multiple places to avoid segfaults if the index is out of range.
1711 (#316422, Guillaume Cottenceau)
1712 (gtk_icon_view_set_drag_dest_item):
1713 (gtk_icon_view_scroll_to_path): Fix a typo in the docs. (#316419,
1714 #316424, Guillaume Cottenceau)
1716 2005-09-18 Hans Breuer <hans@breuer.org>
1718 * gtk/gtktrayicon-win32.c : now handling events by hard-coded
1719 g_signal_emit_by_name() - will break when gtkstatusicon.c changes.
1721 2005-09-18 Hans Breuer <hans@breuer.org>
1723 * gdk/gdk.symbols gdk/win32/gdkwin32.h gdk/win32/gdkcursorwin32.c : export
1724 _gdk_win32_pixbuf_to_hicon() as gdk_win32_pixbuf_to_hicon_libgtk_only()
1725 * gtk/gtktrayicon-win32.c : a lot of debug spew but it has started to show
1726 the icon and is blinking with teststatusicon. More to come ...
1728 2005-09-18 Hans Breuer <hans@breuer.org>
1730 * gtk/makefile.msc.in : fix typo for GTK_VER; define HAVE_CONFIG_H
1731 cause gtkprogressbar.c has #include <config.h> conditionally; less
1732 noise from generated gtk.def
1733 * gtk/stock-icons/makefile.msc gdk/makefile.msc tests/makefile.msc : updated
1735 * gtk/gtktrayicon-win32.c : dummy implmentation to make gtk compile.
1736 For me it works as well as the *NIX implemenation, that is not at all.
1738 * gdk/win32/gdkproperty-win32.c : implement gdk_atom_intern_static_string()
1740 * gdk/win32/gdkwindow-win32.c(gdk_window_set_urgency_hint) : only use
1741 only use (WINVER >= 0x0500) when available from the SDK. Otherwise fall
1742 back to true dynamic linking of FlashWindowEx. Makes gtk+ work on NT4.0
1743 again - if compiled properly.
1745 * tests/teststatusicon.c : don't use GNOME icons for testing, but icons
1746 already coming with Gtk+. Makes it compile on win32.
1748 2005-09-18 Guilherme de S. Pastore <gpastore@cvs.gnome.org>
1750 * README.cvs-commits: fixed some tiny typos
1752 2005-09-16 Tor Lillqvist <tml@novell.com>
1754 * modules/engines/ms-windows/msw_style.c (draw_extension,
1755 draw_box_gap): Check whether the widget actually is a GtkNotebook
1756 before treating it as such. Drop some unneeded local variables,
1757 use parameter with same information instead. (#316412)
1759 2005-09-15 Federico Mena Quintero <federico@ximian.com>
1761 * tests/autotestfilechooser.c: Start a set of automated tests for
1762 the file chooser. The only test in there right now doesn't pass
1763 yet. It specifies the intended behavior of the first optimization
1764 of a series which I'll do on the file chooser (see
1765 http://primates.ximian.com/~federico/news-2005-09.html#14 for the
1766 details of this optimization).
1768 * tests/Makefile.am: Added autotestfilechooser.c.
1770 * gtk/gtkfilechooserprivate.h (struct
1771 _GtkFileChooserDialogPrivate): Move all the file chooser's private
1772 structures to here, so that they can be accessed by
1773 tests/autotestfilechooser.c: _GtkFileChooserDialogPrivate,
1774 _GtkFileChooserWidgetPrivate, LoadState, _GtkFileChooserDefault.
1776 * gtk/gtkfilechooserdialog.c: See above.
1778 * gtk/gtkfilechooserwidget.c: See above.
1780 * gtk/gtkfilechooserdefault.c: See above.
1782 Thu Sep 15 15:27:55 2005 Tim Janik <timj@imendio.com>
1785 gtk_window_map_event(): new function to work around lost unmap requests.
1788 2005-09-14 Federico Mena Quintero <federico@ximian.com>
1790 * gtk/gtkfilechooserdefault.c (gtk_file_chooser_default_init): Add
1791 an easy-to-find profiling marker when starting to create a file
1793 (browse_files_model_finished_loading_cb): Likewise, for when the
1794 chooser is finished loading.
1796 2005-09-14 Tristan Van Berkom <tvb@cvs.gnome.org>
1798 * gtk/gtkcolorbutton.c: Check "color" argument in
1799 gtk_color_button_set_color ()
1801 2005-09-14 Matthias Clasen <mclasen@redhat.com>
1803 * gtk/gtklabel.c (gtk_label_get_type):
1804 * gtk/gtkbutton.c (gtk_button_get_type):
1805 * gtk/gtkwindow.c (gtk_window_group_get_type): No point in
1806 using a mem chunk for window groups, buttons, labels.
1808 * gtk/updateiconcache.c (foreach_remove_func): Fix
1809 a use-after-free bug. (#316256, Alexander Nedotsukov)
1811 2005-09-13 Matthias Clasen <mclasen@redhat.com>
1813 * gtk/*.c: Various cleanups. (#315360, Kjartan Maraas)
1815 * gdk/*.c: Various cleanups. (#315359, Kjartan Maraas)
1817 2005-09-13 Matthias Clasen <mclasen@redhat.com>
1819 * gtk/gtkimcontextsimple.c (gtk_im_context_simple_filter_keypress):
1820 Let GDK_Return pass through in some more cases.
1822 * gtk/gtkentry.c (gtk_entry_key_press): Reset the im context before
1823 activating the entry.
1825 * gtk/gtkiconview.c (gtk_icon_view_class_init):
1826 (gtk_icon_view_get_dest_item_at_pos): Fix typos in the
1827 docs. (#316008, #316027, #316121, Guillaume Cottenceau)
1829 * gtk/gtkfilechooser.c (gtk_file_chooser_class_init): Add some docs.
1830 (#316001, Guillaume Cottenceau)
1832 * gtk/gtkdnd.c (gtk_drag_set_icon_name): Fix a copy-and-paste
1833 mistake in the docs. (#315993, Guillaume Cottenceau)
1835 * tests/testentrycompletion.c (create_simple_completion_model): Add
1836 some strings containing multibyte characters.
1838 * gtk/gtkentrycompletion.c (gtk_entry_completion_real_insert_prefix):
1839 Fix prefix insertion for multibyte characters. (#316095,
1842 * gtk/gtktreeview.c (gtk_tree_view_create_row_drag_icon):
1843 * gtk/gtkiconview.c (gtk_icon_view_create_drag_icon): Silently
1844 return NULL if the widget is not realized. (#316023,
1845 Guillaume Cottenceau)
1847 2005-09-11 Matthias Clasen <mclasen@redhat.com>
1850 * gdk/gdkproperty.h:
1851 * gdk/x11/gdkproperty-x11.c (gdk_atom_intern_static_string):
1852 New function to avoid pointless strdups when creating atoms
1853 from static strings.
1856 * gtk/*.c: Use gdk_atom_intern_static_string() where
1859 2005-09-09 Matthias Clasen <mclasen@redhat.com>
1861 * gtk/gtkcellrendererkeys.h:
1862 * gtk/gtkcellrendererkeys.c: Add a cell renderer for displaying
1863 and editing accelerators, a port of EggCellRendererKeys .
1867 * gtk/Makefile.am: Add the keys cell renderer.
1869 * tests/Makefile.am:
1870 * tests/testkeys.c: Test GtkCellRendererKeys
1872 2005-09-09 Matthias Clasen <mclasen@redhat.com>
1874 Make it possible to determine if a key event is for a
1877 * gdk/x11/gdkprivate-x11.h:
1878 * gdk/x11/gdkkeys-x11.c (_gdk_keymap_key_is_modifier):
1879 New function to determine if a keycode is mapped to a modifier.
1880 (get_xkb): Get the modmap.
1882 * gdk/x11/gdkevents-x11.c (translate_key_event): Set the
1883 is_modifier bit by calling _gdk_keymap_key_is_modifier().
1885 * gdk/gdkevents.h (struct _GdkEventKey): Add an is_modifier
1888 2005-09-09 Matthias Clasen <mclasen@redhat.com>
1890 * gdk/gdkpixbuf-drawable.c (convert_real_slow): Remove an
1891 unused variable, noticed by Kjartan Maraas.
1893 2005-09-09 Matthias Clasen <mclasen@redhat.com>
1895 * gtk/gtktreeviewcolumn.c (gtk_tree_view_column_button_event):
1896 Make drag reordering work properly for columns other than the
1897 first. (#315054, Dan Winship)
1899 * gtk/gtkfontsel.c (gtk_font_selection_set_font_name): Handle
1900 invalid fontnames better. (#136926, Michael R. Walton)
1902 Stop cursor blinking in non-editable regions of a text view.
1903 (#311508, Torbjörn Andersson)
1905 * gtk/gtktextview.c (gtk_text_view_check_cursor_blink):
1906 (cursor_blinks): Take editability into account when deciding
1907 whether the cursor blinks.
1908 (gtk_text_view_button_release_event):
1909 (gtk_text_view_move_cursor_internal): Update cursor blinking here.
1911 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_start_editing):
1912 Use connect_after to connect to the focus_out event. This
1913 ensures that the entry has already stopped blinking by the time
1914 we emit the edited signal. (#315229, Thomas Leonard)
1916 * tests/testgtk.c: Use GDK_MOD1_MASK, not GDK_ALT_MASK.
1918 * gtk/gtkwindow.c (gtk_window_parse_geometry): Don't set
1919 unsigned ints to -1. (#315481, Kjartan Maraas)
1921 * gtk/gtkcalendar.c (gtk_calendar_init): first_weekday is relative
1922 to week_1stday, not to Sunday. Gotta love the ISO 14652 guys...
1923 (#314473, Stanislav Brabec)
1925 2005-09-09 Matthias Clasen <mclasen@redhat.com>
1927 * gtk/gtktreeview.c (gtk_tree_view_get_visible_range): Document
1928 memory handling. (#314975, Torsten Schoenfeld)
1930 * gtk/gtkiconview.c (gtk_icon_view_class_init):
1931 * gtk/gtkfilesel.c (gtk_file_selection_class_init):
1932 * gtk/gtkcombobox.c (gtk_combo_box_class_init):
1933 * gtk/gtklabel.c (gtk_label_class_init):
1934 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_class_init):
1935 Stylistic improvements and clarifications for some blurbs.
1936 (#315520, Clytie Siddall)
1938 2005-09-09 Tor Lillqvist <tml@novell.com>
1940 * gdk/win32/gdkdisplay-win32.c (gdk_display_get_name): Cache the
1941 display name. There is only one GdkDisplay on Win32, and
1942 constructing the display name isn't entirely trivial, so cacheing
1943 is probably worth it. For instance GIMP calls this function a lot.
1944 (gdk_display_open): Call gdk_display_get_name() to prime the
1946 (gdk_display_get_n_screens, gdk_display_get_screen,
1947 gdk_display_get_default_screen): Verify parameter correctness like
1948 the X11 backend does.
1950 * gdk/win32/gdkscreen-win32.c (gdk_screen_make_display_name):
1951 Return a freshly allocated string, as the API specifies. Fixes a
1952 heap corruption problem that caused random errors and crashes in
1955 2005-09-07 Matthias Clasen <mclasen@redhat.com>
1957 * gtk/gtkimcontextsimple.c (gtk_im_context_simple_filter_keypress):
1958 Make C-u commit and restart hex input if we are already in a
1961 2005-09-06 Matthias Clasen <mclasen@redhat.com>
1963 * gdk/x11/gdkkeys-x11.c (update_modmap): Make the modmap reflexive.
1964 (_gdk_keymap_add_virtual_modifiers): Don't add both Alt and Meta
1965 if they are mapped to the same modifier.
1967 * gtk/Makefile.am: Rename gtkstatusicon-x11.c and gtktrayicon.c
1968 to gtkstatusicon.c and gtktrayicon-x11.c
1970 * gtk/gtkaccelgroup.c: Include Super, Hyper and Meta in the
1971 default accel mod mask.
1973 * gtk/gtkaccelgroup.c (gtk_accelerator_parse):
1974 * gtk/gtkaccellabel.c (_gtk_accel_label_class_get_accelerator_label):
1975 Don't use GDK_ALT_MASK.
1977 * gdk/gdktypes.h: No need to introduce GDK_ALT_MASK
1979 2005-09-06 Matthias Clasen <mclasen@redhat.com>
1981 Add support for extra virtual modifiers: (#85780, Owen Taylor)
1983 * tests/testgtk.c (create_key_lookup): Add tests for extra virtual
1986 * gtk/gtkkeyhash.c (_gtk_key_hash_lookup): Try to match both against
1987 Mod2 - Mod5 and against Super, Hyper, Meta.
1989 * gtk/gtkaccellabel.c (_gtk_accel_label_class_get_accelerator_label):
1990 * gtk/gtkaccelgroup.c (gtk_accelerator_parse)
1991 (gtk_accelerator_name): Support Super, Hyper Meta and Mod2 - Mod5.
1993 * gdk/x11/gdkkeys-x11.c (struct _GdkKeymapX11): Add a
1994 modmap to maintain the information which X modifiers map to
1996 (get_xkb): Set up the modmap from the XKB tables.
1997 (update_keymaps): Set up the modmap from the information returned
1998 by XGetModifierMapping in the non-XKB case.
2000 * gdk/x11/gdkprivate-x11.h:
2001 * gdk/x11/gdkkeys-x11.c (_gdk_keymap_add_virtual_modifiers): New
2002 function to set the virtual modifiers in the state.
2004 * gdk/x11/gdkevents-x11.c (translate_key_event): Call
2005 _gdk_keymap_add_virtual_modifiers here.
2007 * gdk/gdktypes.h (GdkModifierType): Add bits for virtual Super,
2008 Hyper and Meta modifiers. Also add GDK_ALT_MASK as an alias
2011 2005-09-05 Matthias Clasen <mclasen@redhat.com>
2013 * gtk/gtkaction.c (connect_proxy): Set the label of a button
2014 if it has no child. (#315253, John Finlay)
2016 2005-09-02 Matthias Clasen <mclasen@redhat.com>
2018 * gtkimcontextsimple.h: Add a modifiers_dropped bit
2020 2005-09-02 Matthias Clasen <mclasen@redhat.com>
2022 * gtk/gtkentry.c (gtk_entry_destroy): Disconnect idle handlers
2023 on destroy to avoid problems when they are called on a destroyed
2024 widget. (#315135, John Cupitt)
2026 * gtk/gtkentry.c (gtk_entry_class_init):
2027 * gtk/gtktextview.c (gtk_text_view_class_init): Add bindings
2028 for Ctrl-Shift-A to unselect all. (#309301, Kathy Fernandes)
2030 * gtk/gtkimcontextsimple.c: Rework the Unicode hex input
2031 code. Now we only steal a single key combination, Ctrl-Shift-U,
2033 A hex Unicode sequence must be started with Ctrl-Shift-U, followed
2034 by a sequence of hex digits entered with Ctrl-Shift still held.
2035 Releasing one of the modifiers or pressing space while the modifiers
2036 are still held commits the character. It is possible to erase
2037 digits using backspace.
2038 As an extension to the above, we also allow to start the sequence
2039 with Ctrl-Shift-U, then release the modifiers before typing any
2040 digits, and enter the digits without modifiers.
2041 (#82011, Owen Taylor)
2043 2005-09-02 Matthias Clasen <mclasen@redhat.com>
2045 * gtk/gtkmain.c (gtk_get_event_widget): If the window is destroyed,
2046 we still need to deliver the destroy event. (#314980, Chris Lahey)
2048 * gtk/gtktextview.c (gtk_text_view_key_press_event): Reset
2049 im context before committing \n or \t.
2051 2005-09-02 Alexander Larsson <alexl@redhat.com>
2053 * gtk/gtkfilechooserdefault.c: (shortcuts_add_volumes),
2054 (shortcuts_activate_volume):
2055 Handle base_path being null in the rest of the cases (#310270)
2057 2005-09-02 Tor Lillqvist <tml@novell.com>
2059 * gdk/win32/gdkevents-win32.c (gdk_event_translate): Keep track of
2060 cursor position also in root window coordinates. Prune out
2061 superfluous WM_MOUSEMOVE events even earlier, based on root window
2062 coordinates. Windows sends WM_MOUSEMOVE messages after a new
2063 window has ben mapped below the cursor even if the mouse doesn't
2064 move. We used to generate GDK_MOTION_NOTIFY in these cases. This
2065 confused at least gtk_menu_motion_notify(). (#314995)
2067 * gtk/gtkintl.h: No need to include config.h here. It caused
2068 warnings about GTK_LOCALEDIR being redefined on Win32 when
2069 compiling files where gtkintl.h is included after gtkprivate.h
2070 (which #undefines and re-#defines GTK_LOCALEDIR on Win32).
2072 * gtk/gtkplug.c: Include config.h.
2074 2005-09-01 Matthias Clasen <mclasen@redhat.com>
2076 * gtk/gtkfilesystemunix.c: Pass statbufs down to
2077 xdg_mime_get_mime_type_for_file() where possible, to avoid
2080 * gtk/gtkaction.c (gtk_action_get_accel_closure): Fix doc
2081 typo. (#314921, Guillaume Cottenceau)
2083 * gdk/*.c: Intern some more strings.
2085 * gtk/*.c: Define an I_() macro and use it instead of the
2086 bulky g_intern_static_string().
2088 2005-08-31 Matthias Clasen <mclasen@redhat.com>
2090 * gtk/gtkbindings.c (binding_signal_new): Intern the signal name
2091 instead of copying it.
2093 * gtk/gtktypeutils.c (gtk_identifier_get_type): Some more string interning.
2095 * gtk/*.c: Also intern static strings passed to
2096 g_object_set_data().
2099 * gtk/Makefile.am: Intern type names in code generated by
2104 * gdk/*.c: Intern type names before registering the type to avoid
2107 * configure.in: Require GLib 2.9.0
2109 2005-08-31 Matthias Clasen <mclasen@redhat.com>
2111 * gtk/gtktoolbar.c: Undeprecate gtk_toolbar_set_icon_size(),
2112 and add icon-size and icon-size-set properties. (#314172)
2114 * gtk/gtkwindow.c (gtk_window_set_transient_for): Inherit window
2115 groups across transient parents. (#312918, Christian Persch)
2117 * gtk/gtktreemodel.c: Some documentation fixes. (#314882,
2118 Guillaume Cottenceau)
2120 * gtk/gtktextiter.c (gtk_text_iter_backward_visible_cursor_positions):
2121 Fix a typo in the docs. (#314878, Guillaume Cottenceau)
2123 2005-08-30 Matthias Clasen <mclasen@redhat.com>
2125 * gtk/gtkentry.c (gtk_entry_class_init): Add key bindings to
2126 make C-/ select all and C-\ unselect all. (#309301,
2129 * gtk/gtkimcontextsimple.c: Change the compose sequence for
2130 soft hyphen to be multi_key-minus-minus-space, and add
2131 compose sequences multi_key-minus-minus-period and
2132 multi_key-minus-minus-minus for en dash and em dash.
2133 (#172653, Christian Lohmaier)
2135 * gtk/gtkentry.c (gtk_entry_draw_frame): Fix some unused
2136 code. (#313946, Christian Persch)
2138 * gtk/gtkuimanager.c (gtk_ui_manager_class_init): Another
2139 fix for the default value of the "ui" property.
2141 2005-08-30 Matthias Clasen <mclasen@redhat.com>
2144 * gtk/gtkselection.h:
2145 * gtk/gtkselection.c: Add functions which look for text, image
2146 or uri targets in an array of atoms. (#314089, Mark Wielaard)
2149 * gtk/gtkselection.h:
2150 * gtk/gtkselection.c (gtk_selection_data_targets_include_uri):
2151 Add a function to check wether targets include uri.
2152 (#314092, Mark Wielaard)
2156 * gtk/gtkwindow.c: Add a deletable property with getter
2157 and setter, to control the close button in the window
2158 frame. (#59718, Havoc Pennington)
2160 2005-08-29 Matthias Clasen <mclasen@redhat.com>
2162 * gtk/gtkrc.key.emacs: Add C-n/C-p/C-f/C-b as alternatives
2163 to the arrow keys for menu navigation. (#162825, Carl Worth)
2165 * gtk/gtkentry.c, gtk/gtktextview.c: More typo fixes
2167 * gtk/gtksocket-x11.c, gtk/gtkstatusicon-x11.c: Fix typos.
2169 * gtk/gtkstatusicon-x11.c (gtk_status_icon_new_from_stock):
2170 * gtk/gtkimage.c (gtk_image_new_from_stock): Don't
2171 refer to nonexisting stock ids.
2173 * gtk/gtktextview.c (popup_targets_received):
2174 * gtk/gtkentry.c (popup_targets_received): Construct
2175 the "Select All" menuitem from stock.
2177 * gtk/stock-icons/stock_select_all_{16,24}.png:
2178 * gtk/stock-icons/Makefile.am:
2179 * gtk/gtkiconfactory.c:
2181 * gtk/gtkstock.c: Add a "Select All" stock item. (#78545,
2184 * gtk/gtktrayicon.c: Add a pointer to the spec.
2186 * gtk/gtkstatusicon-x11.c: Add docs.
2188 * gtk/gtkstatusicon.h: Fix a typo.
2190 Add a cross-platform "tray icon" API, by
2191 porting EggStatusIcon/EggTrayIcon (#105101)
2193 * gtk/gtkstatusicon.h: A GtkStatusIcon is an object which
2194 displays an icon in a notification area.
2196 * gtk/gtkstatusicon-x11.c: GtkStatusIcon implementation for
2197 X11, using GtkTrayIcon.
2199 * gtk/gtktrayicon.h:
2200 * gtk/gtktrayicon.c: An implementation of the freedesktop.org
2201 system tray specification, not public API.
2203 * gtk/gtk.symbols: Add new exported functions.
2205 * gtk/gtk.h: Include gtkstatusicon.h.
2207 * gtk/Makefile.am: Add new files.
2209 * tests/Makefile.am:
2210 * tests/teststatusicon.c: Test for GtkStatusIcon.
2212 2005-08-29 Christopher Aillon <caillon@redhat.com>
2214 * gtk/gtkstock.c: Add builtin GtkStockItems for GTK_STOCK_CONNECT
2215 and GTK_STOCK_DISCONNECT
2217 2005-08-29 Matthias Clasen <mclasen@redhat.com>
2219 * gtk/gtksocket-x11.c (_gtk_socket_windowing_embed_notify):
2220 Use XFixesChangeSaveSet if available. (#314682)
2222 * gtk/gtkmenu.c (gtk_menu_grab_notify): Only cancel if the menu
2223 was active. (#314298, Christian Persch, analysis by Mark McLoughlin)
2225 2005-08-29 Matthias Clasen <mclasen@redhat.com>
2227 * gtk/gtkiconcache.c (_gtk_icon_cache_get_icon): Remove an
2228 accidentally leftover duplicate pixbuf creation. (#314700,
2231 * gtk/gtksettings.c (settings_update_cursor_theme): Don't
2232 leak the cursor theme name. (#314693, Kjartan Maraas)
2234 * gdk/x11/gdkasync.c (_gdk_x11_get_window_child_info): Free
2235 state.children in all cases. (#313862, Kjartan Maraas)
2237 2005-08-28 Matthias Clasen <mclasen@redhat.com>
2239 * po/POTFILES.in, po-properties/POTFILES.in:
2242 2005-08-27 Matthias Clasen <mclasen@redhat.com>
2244 * gtk/gtkuimanager.c (gtk_ui_manager_class_init): Fix the default
2245 value of the ui property. (#314532, Yong Wang)
2247 * gdk/x11/gdkproperty-x11.c (gdk_property_get): Don't warn
2248 when G_MAXLONG is passed as length.
2250 2005-08-26 Matthias Clasen <mclasen@redhat.com>
2252 * gtk/updateiconcache.c: Add a separate --ignore-theme-index option
2253 to avoid overloading --force. (JP Rosevaar)
2255 2005-08-26 Matthias Clasen <mclasen@redhat.com>
2257 * configure.in: Bump version to 2.9.0
2261 * gdk/gdkscreen.c: Make the GdkScreen font options api
2262 public, and add properties GdkScreen::font-options and
2263 GdkScreen::resolution. (#314004)
2266 * gtk/gtksettings.c:
2267 * gtk/gtkwidget.c: Adjust all callers.
2269 * gdk/gdkintl.h: Simplify and use glib/gi18n-lib.h.
2270 * gdk/gdkpango.c: Include gdkintl.h, not gtkintl.h.
2271 * gdk/gdkscreen.c: Include gdkintl.h.
2273 * gtk/gtkicontheme.c (theme_lookup_icon): Avoid an uninitialized
2274 variable warning, pointed out by Colin Walters. (#314585)
2276 2005-08-26 Tor Lillqvist <tml@novell.com>
2278 * gtk/gtkfilesystemwin32.c: Remove some ifdeffed out debugging
2280 (gtk_file_system_win32_parse): Don't mishandle UNC paths. (#314519)
2282 2005-08-26 Matthias Clasen <mclasen@redhat.com>
2284 * gtk/gtkcalendar.c (gtk_calendar_init): Fix the calculation
2285 of week_start. (#314473, JP Rosevaar)
2287 2005-08-25 Thomas Fitzsimmons <fitzsim@redhat.com>
2289 * gtk/gtkfilesystemmodel.c (idle_finished_loading_cb): Acquire GDK
2290 lock. (#314533, Thomas Fitzsimmons)
2292 2005-08-25 Matthias Clasen <mclasen@redhat.com>
2294 * gtk/gtktoolbar.c (_gtk_toolbar_elide_underscores): Handle
2295 NULL gracefully. (#314523, Ed Catmur)
2297 2005-08-25 Owen Taylor <otaylor@redhat.com>
2299 * gdk/x11/gdkcursor-x11.c (gdk_x11_display_set_cursor_theme):
2300 Handle theme == NULL.
2302 2005-08-25 Matthias Clasen <mclasen@redhat.com>
2304 * gtk/gtkmenutoolbutton.c (menu_position_func): Take widget
2305 y offset into account when positioning the popup. (#314470,
2308 2005-08-25 Owen Taylor <otaylor@redhat.com>
2310 * gdk/gdkscreen.c (gdk_screen_get_type): Use gdk_screen_init
2311 as instance_init, not base_init! (#314452, Fix from Frederic
2312 Crozat, reported by Joe Marcus Clarke). Trivial cleanup: use -1.
2313 rather than 1 for a negative flag value.
2315 2005-08-24 Owen Taylor <otaylor@redhat.com>
2317 * gdk/gdkpango.c (draw_error_underline): Add a note about
2318 cut-and-paste between here and Pango.
2320 2005-08-24 Matthias Clasen <mclasen@redhat.com>
2322 * === Released 2.8.2 ===
2324 * gtk/gtkclipboard.c (request_image_received_func): Use the correct
2325 callback for image/gif, and also try image/bmp. (#314086, Mark
2328 * gtk/gtkfilesystemunix.c (gtk_file_system_unix_volume_render_icon):
2329 Use gnome-dev-harddisk for volumes, not gnome-fs-blockdev. (#314382,
2334 * gtk/gtksettings.c (gtk_settings_get_for_screen): Make sure font
2335 and cursor settings get propagated down to the screen initially.
2336 Pointed out by Frederic Crozat.
2338 * gtk/gtkicontheme.c (ensure_valid_themes): Don't try to send a client
2339 message if the screen is NULL. Noticed by Kjartan Maraas.
2341 2005-08-24 Matthias Clasen <mclasen@redhat.com>
2345 * === Released 2.8.1 ===
2349 2005-08-24 Matthias Clasen <mclasen@redhat.com>
2351 * gtk/gtktreemodelfilter.c (gtk_tree_model_filter_visible): Protect
2352 against lazy filterers which return values other than TRUE or
2353 FALSE from their visible func. (#314335)
2355 2005-08-23 Owen Taylor <otaylor@redhat.com>
2357 Fix for #314004, reported by Michael Reinsch:
2360 * gdk/gdkscreen.[ch]: Add gdk_screen_get/set_font_options_libgtk_only()
2361 Add gdk_screen_get/set_resolution_libgtk_only()
2363 * gdk/gdkpango.c (gdk_pango_context_get_for_screen): Set
2364 the options for the screen on the newly created context.
2366 * gtk/gtksettings.c (settings_update_font_options/dpi) gtkwidget.c:
2367 Move font options and dpi code from gtkwidget.c to gtksettings.c, set
2368 the font options on the screen.
2370 * gtk/gtkwidget.c (gtk_widget_update_pango_context): Just get
2371 the font options from the screen and set them on the context.
2373 2005-08-23 Kristian Rietveld <kris@gtk.org>
2375 * gtk/gtktreemodelsort.c (gtk_tree_model_sort_row_inserted): don't
2376 bother inserting new rows in a level with a zero refcount and
2377 immediately free the level. (Fixes #312350, reported by Markku Vire).
2379 2005-08-23 Matthias Clasen <mclasen@redhat.com>
2381 * gtk/updateiconcache.c: Complain when there is no index.theme file
2382 in the specified directory, unless --force is used. Also add an
2383 --index-only option to create caches without image data.
2385 * gtk/gtkfilechooserdefault.c (shortcuts_append_desktop): Fix a
2386 C99ism. (#314262, Robert Jeff Mitchell)
2388 2005-08-22 Manish Singh <yosh@gimp.org>
2390 * gtk/gtkicontheme.h: add declaration for _gtk_icon_theme_check_reload.
2392 * gtk/gtkwindow.c: remove declaration of gtk_window_read_rcfiles.
2394 2005-08-22 Matthias Clasen <mclasen@redhat.com>
2396 * gtk/gtkwindow.c (gtk_window_client_event):
2397 * gtk/gtkicontheme.c (ensure_valid_themes)
2398 (_gtk_icon_theme_check_reload): Implement a clientmessage based
2399 scheme for makeing sure that all GTK+ applications notice if an
2400 icon theme has been updated. This should prevent multiple versions
2401 of an icon theme cache to be mapped in memory at the same time,
2402 which can cause excessive memory consumption. (#313156, Chris
2405 2005-08-22 Matthias Clasen <mclasen@redhat.com>
2407 * gtk/gtkicontheme.c (gtk_icon_theme_load_icon): Add a note
2408 regarding icon theme changes.
2410 * gtk/gtkiconcache.c (_gtk_icon_cache_get_icon): When returning
2411 pixbufs which are backed by the mmapped memory of an icon cache,
2412 increase the refcount of the icon cache, so that the memory is not
2413 munmapped away underneath the pixbuf upon icon theme changes.
2414 (#314170, Kjartan Maraas)
2416 * docs/tools/Makefile.am (LDADDS): Add GTK_DEP_LIBS, in order
2417 to link against Xext. (#314062)
2419 * gtk/gtkhsv.c (paint_triangle): One more fix to prevent buffer
2420 overruns. (#314081, Hans Breuer)
2422 2005-08-20 Matthias Clasen <mclasen@redhat.com>
2424 * gtk/gtkentry.c (gtk_entry_get_layout): Clarify that the
2425 returned layout must not be modified.
2427 Sat Aug 20 16:12:14 2005 Jonathan Blandford <jrb@redhat.com>
2429 * gtk/gtktreeview.c (gtk_tree_view_set_model): clear
2430 scroll_to_path if the model changes.
2432 * gtk/gtkiconview.c: (gtk_icon_view_destroy),
2433 (gtk_icon_view_size_allocate), (gtk_icon_view_set_cursor),
2434 (gtk_icon_view_scroll_to_path): Handle scrolling to a path before
2435 we're realized, #312798
2436 (gtk_icon_view_set_model): clear scroll_to_path if the model
2439 2005-08-20 Matthias Clasen <mclasen@redhat.com>
2441 * gtk/gtkrange.c (gtk_range_adjustment_changed)
2442 (gtk_range_adjustment_value_changed): Don't queue a draw
2443 if the layout has not changed. (#313991, Benjamin Berg)
2445 2005-08-19 Matthias Clasen <mclasen@redhat.com>
2447 * gtk/gtktreeitem.c: Remove duplicate lines. (#313344,
2450 * modules/engines/ms-windows/msw_style.c (setup_system_styles):
2453 * gtk/gtkfilechooserbutton.c (change_icon_theme)
2454 (model_add_special, model_add_special, model_add_volumes):
2455 Handle pixbuf being NULL without warnings. Also, don't
2456 leak pixbuf references when the icon theme is changed.
2458 * gtk/gtkmain.c (gtk_get_event_widget): Don't access
2459 the user data on destroyed windows, since at best
2460 it can be a stale pointer. (#313953, Robin Green)
2462 2005-08-19 Matthias Clasen <mclasen@redhat.com>
2464 * gtk/gtkhsv.c (paint_triangle): Avoid a buffer overrun.
2465 (#313900, Sebastien Bacher)
2467 * gtk/gtktreeview.c (gtk_tree_view_get_visible_range): Return
2468 FALSE if the tree is empty. (#313891, Guillaume Cottenceau)
2470 * gdk/x11/gdkdnd-x11.c (_gdk_drag_get_protocol_for_display)
2471 (xdnd_read_actions, get_client_window_at_coords_recurse):
2472 Free data returned from XGetWindowProperty.
2474 * gdk/x11/gdkevents-x11.c (fetch_net_wm_check_window)
2475 Free data returned from XGetWindowProperty. (313867, Kjartan
2478 * gdk/x11/gdkdnd-x11.c (get_client_window_at_coords_recurse): Free
2479 children in all cases. (#313862, Kjartan Maraas)
2481 * gtk/gtkicontheme.c (theme_lookup_icon): Store GtkIconData structs
2482 in the per-directory hash, even if they come from the icon cache.
2483 We tried to avoid that before, but as a result leaked icon data
2484 structs. (#313852, Kjartan Maraas)
2486 2005-08-18 Matthias Clasen <mclasen@redhat.com>
2488 * gtk/gtkmenutoolbutton.c (gtk_menu_tool_button_destroy): Disconnect
2489 signal handlers on destroy, not on finalize. (#313759, Brett Atoms)
2491 2005-08-15 Owen Taylor <otaylor@redhat.com>
2493 * configure.in: Add -lXext to GDK_EXTRA_LIBS in absence of pkg-config
2494 files for x11/xext. (Jonas Bonn)
2496 2005-08-15 Tor Lillqvist <tml@novell.com>
2498 * gtk/gtkicontheme.c (theme_lookup_icon): Put debugging printout
2501 2005-08-15 Owen Taylor <otaylor@redhat.com>
2503 * configure.in: Fix have_base_pc / have_base_x_pc typo.
2505 * gdk/x11/gdkdrawable-x11.c gtk/gtksettings.c: Remove panoxft.h includes.
2506 (#313417, James Andrewartha)
2508 * configure.in: Add fontconfig to X_PACKAGES, since we use it for
2509 FcNameConstant(). (More of #313417)
2511 2005-08-15 Matthias Clasen <mclasen@redhat.com>
2513 * gtk/gtkfilechooserdefault.c: When using gtk_dialog_run() for
2514 modal dialogs, make sure to inherit the window group from
2515 the parent, since we don't inherit window groups across
2516 transient parents currently. (#312918, Christian Persch)
2518 * gtk/gtkmessagedialog.c (gtk_message_dialog_new):
2519 * gtk/gtkdialog.c (gtk_dialog_run): Slight update to the docs.
2521 * gtk/gtkiconview.c (gtk_icon_view_select_path)
2522 (gtk_icon_view_scroll_to_path): Handle paths of depth 0
2523 gracefully. (#312796, Jonathan Blandford)
2525 * tests/testtoolbar.c: Add some more tests for menu placement.
2527 * gtk/gtkmenutoolbutton.c (menu_position_func):
2528 * gtk/gtktoolbar.c (menu_position_func): Improve positioning
2529 of toolbutton menus and of the overflow menu. (#312937,
2530 #153870, Christian Persch, Paolo Borelli)
2532 2005-08-15 Tor Lillqvist <tml@novell.com>
2534 * gtk/updateiconcache.c: Use g_path_get_dirname() instead of
2535 the nonportable <libgen.h> and dirname().
2537 2005-08-15 Matthias Clasen <mclasen@redhat.com>
2539 * gtk/gtksizegroup.c: Use object data to mark widgets and
2540 groups as visited, so that we avoid constant extra list
2541 traversals. Also allocate quarks in class_init. (#311618,
2544 * gtk/gtkicontheme.c (gtk_icon_theme_lookup_icon): Correct the
2545 download location for the hicolor icon theme. (#313475, Olexiy
2548 * gtk/gtkicontheme.c: Remove debug spew.
2550 2005-08-15 Owen Taylor <otaylor@redhat.com>
2552 * gdk/linux-fb/gdkwindow-fb.c (gdk_window_set_back_pixmap):
2553 * gdk/win32/gdkwindow-win32.c (gdk_window_set_back_pixmap):
2554 * gdk/x11/gdkwindow-x11.c (gdk_window_set_back_pixmap):
2555 Handle pixmap == NULL when checking for a colormap.
2558 2005-08-14 Matthias Clasen <mclasen@redhat.com>
2560 * gtk/updateiconcache.c: Store only one copy of the pixel data
2561 for symlinked icons. To achieve this, maintain a hashtable
2562 mapping pathnames to pixel data, and share the pixel data for
2563 all symlinks resolving to the same pathname. When writing out
2564 the image data, write out the pixel data only the first time
2565 it is met, and store the offset pointing to the first copy
2566 for use in all later cases.
2567 This reduces the size of the Bluecurve icon cache from 40