1 Thu May 6 00:24:11 2004 Matthias Clasen <maclas@gmx.de>
3 * gtk/gtkactiongroup.h:
4 * gtk/gtkactiongroup.c (gtk_action_group_translate_string):
5 New function to translate a string with translate_func.
8 Thu May 6 00:02:21 2004 Matthias Clasen <maclas@gmx.de>
10 * gtk/gtkcombobox.c (gtk_combo_box_get_wrap_width):
11 (gtk_combo_box_get_row_span_column):
12 (gtk_combo_box_get_column_span_column): Add missing getters
13 for readwrite properies. (#135649)
15 Wed May 5 23:42:42 2004 Matthias Clasen <maclas@gmx.de>
18 * gtk/gtkcombobox.c (gtk_combo_box_get_active_text):
19 Add gtk_combo_box_get_active_text() convenience
20 function. (#136372, Christian Neumeir, patch by Olivier Andrieu)
22 2004-05-05 Elijah Newren <newren@math.utah.edu>
24 Changes to support do-not-focus-on-map hint in conjunction with
25 _NET_WM_USER_TIME (#115650):
27 * gdk/gdkwindow.h (struct _GdkWindowObject): Add a new boolean
30 * gdk/gdkwindow.h (gdk_window_set_accept_focus): New function to
33 * gtk/gtkwindow.[hc]: Add a boolean property "focus_on_map"
34 and gtk_window_get_focus_on_map() and gtk_window_set_focus_on_map().
36 * gdk/win32/gdkwindow-win32.c (gdk_window_new):
37 * gdk/linux-fb/gdkwindow-fb.c (gdk_window_new):
38 * gdk/x11/gdkwindow-x11.c (gdk_window_new):
39 Initialize the focus_on_map field to TRUE.
41 * gdk/win32/gdkwindow-win32.c (gdk_window_set_focus_on_map):
42 * gdk/linux-fb/gdkwindow-fb.c (gdk_window_set_focus_on_map):
43 * gdk/x11/gdkwindow-x11.c (gdk_window_set_focus_on_map):
44 * gdk/x11/gdkwindow-x11.c (setup_toplevel_window):
45 Implementations for the various backends. The Win32 and linux-fb
46 implementations set the focus_on_map field, but don't use it yet
47 to actually implement noinput windows. The X implementation sets
48 _NET_WM_USER_TIME to 0 if focus_on_map is FALSE (see the EWMH).
50 * gdk/x11/gdkwindow-x11.h:
51 * gdk/x11/gdkevents-x11.c (set_user_time):
52 * gdk/x11/gdkinput-x11.c (_gdk_input_common_other_event):
53 * gdk/x11/gdkwindow-x11.c (gdk_x11_window_set_user_time):
54 s/_gdk_x11_window_set_user_time/gdk_x11_window_set_user_time/,
55 since we want that function to be part of the public API.
57 Wed May 5 22:20:21 2004 Matthias Clasen <maclas@gmx.de>
61 * gtk/gtkiconfactory.c (icon_source_clear): Don't
62 call g_free() on a pixbuf. (#141961, Crispin Flowerday)
64 2004-05-05 Matthias Clasen <mclasen@redhat.com>
68 * gtk/gtkuimanager.c (print_node): Make the output
69 parseable. (#141929, Sven Neumann)
71 2004-05-05 Tor Lillqvist <tml@iki.fi>
73 * gdk/win32/gdkdnd-win32.c (gdk_drag_find_window_for_screen): Add
74 multi-monitor offset. (#141842, John Ehresman)
76 2004-05-04 Federico Mena Quintero <federico@ximian.com>
78 Fixes #139562, based on a patch by Christian Neumair.
80 * gtk/gtkfilechooserdefault.c (struct _GtkFileChooserDefault): Add
81 a filter_combo_hbox field to contain the filter combo.
82 (show_filters): Show/hide the filter_combo_hbox.
83 (create_filename_entry_and_filter_combo): Removed.
84 (file_pane_create): Create the filter_combo_hbox here.
86 2004-05-04 Matthias Clasen <mclasen@redhat.com>
88 * modules/input/gtkimcontextxim.c: Fix the recent
89 string_conversion_callback change to work on
90 Solaris. (#141190, Padraig O'Briain)
92 * gtk/gtkselection.c: Disable debug logging again.
94 2004-05-03 Matthias Clasen <mclasen@redhat.com>
96 * gtk/gtkselection.c: Make the chunk size for
97 incremental transfers depend on the maximal request
98 size, capped at 256k. This should allow most selections
99 to be transferred nonincrementally, avoiding many
100 roundtrips and protocol overhead.
102 2004-05-03 Federico Mena Quintero <federico@ximian.com>
104 * gtk/gtkuimanager.c (gtk_ui_manager_class_init): Call
105 g_signal_new() correctly and initialize the signal fields. Fixes
106 #141749; patch based on Michael Natterer's.
108 u2004-05-03 Matthias Clasen <mclasen@redhat.com>
110 * gtk/gtkselection.c (_gtk_selection_request): Fix
111 a debug message to show correct information.
112 (_gtk_selection_incr_event): Make INCRemental transfer
113 of MULTIPLE targets work. This was broken since 1997!
115 2004-05-02 Hans Breuer <hans@breuer.org>
117 * gdk/win32/gdkdrawable-win32.c (draw_segments) : don't
118 modify the passed in GdkSegment(s) in place, we may get
119 them again to draw at the same place. Fixes bug #129095,
121 (draw_segments) draw the end pixel again to get the
122 pixmap mask right, fixes bug #126710, #130202
124 * gdk/win32/gdkwindow-win32.c : use SetForegroundWindow,
125 fixes bug #106013, John Ehresman
127 * gtk/makefile.msc.in : don't try to link gtk.res but
128 use gtk-win32.res (as supposed to be fixed below :)
130 2004-05-01 Hans Breuer <hans@breuer.org>
132 * tests/Makefile.am : tests/makefile.msc is in CVS for
133 a long time, finally added to EXTRA_DIST : fixes bug
134 #141334, John Ehresman
136 2004-04-30 Matthias Clasen <mclasen@redhat.com>
138 * === Released 2.4.1 ===
140 * configure.in: Version 2.4.1, interface age 1.
144 2004-04-29 Federico Mena Quintero <federico@ximian.com>
148 * gtk/gtkfilechooserdefault.c (remove_selected_bookmarks): New
149 function; moved the code over from
150 remove_bookmark_button_clicked_cb().
151 (remove_selected_bookmarks): Now, getting a non-removable bookmark
152 is not an error, as we may be called as a result of hitting the
154 (shortcuts_key_press_event_cb): New handler; delete the bookmark
155 if the user presses Backspace, Delete, or KP_Delete.
157 2004-04-29 Matthias Clasen <mclasen@redhat.com>
159 * gtk/gtkaction.c (closure_accel_activate): Use
160 _gtk_action_emit_activate() instead of directly
161 emitting the activate signal. (#141429, Jody Goldberg)
163 * gtk/gtkactiongroup.c (gtk_action_group_add_action_with_accel):
164 Warn people when the accelerator can not be
165 parsed. (#141429, Jody Goldberg)
167 2004-04-29 Matthias Clasen <mclasen@redhat.com>
169 * tests/testentrycompletion.c (main): Add a missing
170 cat. (#141070, Chris Sherlock)
172 * gtk/gtkrc.c (gtk_rc_check_pixmap_dir): Remove unused
173 variable. (#141022, Chris Sherlock)
175 * gtk/gtkcombo.c (gtk_combo_popup_list): Add a missing
176 cast. (#141013, Chris Sherlock)
178 * gtk/gtkcellview.c (gtk_cell_view_cell_layout_clear): Remove
179 unused variable. (#141011, Chris Sherlock)
181 2004-04-29 Tor Lillqvist <tml@iki.fi>
183 * gdk/win32/gdkgc-win32.c (gdk_win32_gc_set_dashes): Plug memory
184 leak. (#140775, John Ehresman)
186 Thu Apr 29 01:09:50 2004 Matthias Clasen <maclas@gmx.de>
188 * gdk/gdkdraw.c (_gdk_drawable_get_scratch_gc): Use depth - 1
189 to index the cached gcs, not depth. (#139494)
191 2004-04-28 Matthias Clasen <mclasen@redhat.com>
193 * gdk/gdkdraw.c (_gdk_drawable_get_scratch_gc): Docs typo fix.
195 Sun Apr 25 15:36:02 2004 Soeren Sandmann <sandmann@daimi.au.dk>
197 * gtk/gtktoolbutton.c (gtk_tool_button_set_label_widget): Fix
198 cut'n'paste-o from previous commit. (#141046, Torsten Schoenfeld).
200 2004-04-24 Theppitak Karoonboonyanan <thep@linux.thai.net>
202 Patch to add support for string conversion callbacks to
203 GtkIMContextXIM (#101814)
205 * modules/input/gtkimcontextxim.c: Set the string conversion callback
206 if supported by the XIC.
208 (struct _GtkIMContextXIM): Add string_conversion_callback member.
210 (struct _GtkXIMInfo, setup_im): Check and keep flag inidicating
211 whether string conversion callback is supported.
213 (gtk_im_context_get_ic, +set_string_conversion_callback,
214 +string_conversion_callback): Also initialize string conversion
215 callback, if supported, along with the IC initialization.
217 * modules/input/imxim.c: Make "xim" module default for Thai as well.
219 2004-04-23 Matthias Clasen <mclasen@redhat.com>
221 * gtk/gtkclipboard.c (gtk_clipboard_wait_for_targets): Correctly
222 initialize targets. (#139883, John Finlay)
224 * gdk/gdkdraw.c (gdk_draw_drawable): Small doc improvement.
226 * gtk/gtktreeselection.c (gtk_tree_selection_get_selected_rows):
227 Don't recommend gtk_tree_row_reference_new_proxy(). (#138309,
230 * gtk/gtktreeviewcolumn.c (gtk_tree_view_column_cell_set_cell_data):
231 Remove an excessive g_return_if_fail().
233 * gdk/x11/gdkevents-x11.c (set_user_time): Make set_user_time()
235 * gdk/x11/gdkinput-x11.c (_gdk_input_common_other_event):
236 _-prefix calls of gdk_x11_window_set_user_time().
238 2004-04-22 Matthias Clasen <mclasen@redhat.com>
240 * gtk/gtkuimanager.c (update_node): Make sure the separators
241 used to demarkate placeholder ends don't show up on
242 show_all(). (#140496, Murray Cumming)
244 * gtk/gtkspinbutton.c (spin_button_at_limit): Make spinbuttons
245 work with negative increments. (#137975, Tim Gerla)
247 Wed Apr 21 21:38:03 2004 Soeren Sandmann <sandmann@daimi.au.dk>
249 * gtk/gtktoolbutton.c (gtk_tool_button_set_label_widget,
250 gtk_tool_button_set_icon_widget): Remove the old widget from the
251 tool button before overwriting it with the new widget.
253 (#140508, Todd Goyen)
255 2004-04-22 Tor Lillqvist <tml@iki.fi>
257 Fix the file chooser on Windows. I can't make it misbehave or
258 crash any more now. But presumably there are still corner cases
259 not handled. I haven't really checked behaviour of UNC paths, for
262 * gtk/gtkfilesystemwin32.c: Accept both backslash and slash in
263 several places. Use G_IS_DIR_SEPARATOR macro (which could be added
266 (gtk_file_system_win32_get_parent): Like the Unix version, assert
267 filename is absolute, and avoid one unnecessary string allocation
270 (canonicalize_filename,gtk_file_system_win32_parse): Handle drive
271 letters more correctly.
273 (gtk_file_system_win32_render_icon): Assure correct syntax is used
274 for root folder of a drive. (#137962, Morten Welinder)
276 (filename_is_some_root): New function that accepts also root
277 without any drive specified.
279 (filename_is_drive_root): Rename from filename_is_root.
281 * gtk/gtkfilechooserentry.c (completion_match_func): Casefold on
284 2004-04-21 Matthias Clasen <mclasen@redhat.com>
286 * gtk/gtkentry.c (gtk_entry_completion_timeout): Pop down the
287 completion window if there are no completions anymore.
289 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
290 Don't call gtk_tree_view_scroll_to_cell() on an empty tree view.
291 It doesn't like that. (#140642, Christian Persch)
293 * demos/gtk-demo/expander.c (do_expander): A new demo.
295 * demos/gtk-demo/Makefile.am (demos): Add expander.c.
297 2004-04-20 Matthias Clasen <mclasen@redhat.com>
299 * gtk/gtktextview.c (gtk_text_view_allocate_children): Make
300 sure anchored children get size allocated, even if the layout
301 is valid. (#122323, Andrew E. Makeev)
302 (gtk_text_view_scroll_pages):
303 (gtk_text_view_scroll_hpages): Don't scroll to cursor position
304 if we already have pending scrolls. Bandaid fix for #78513.
306 Mon Apr 19 17:59:17 2004 Owen Taylor <otaylor@redhat.com>
308 * INSTALL.in: Update libpng and libjpeg URLs, remove
309 note about building without since that's not the normal
312 Sun Apr 11 09:45:11 2004 Owen Taylor <otaylor@redhat.com>
314 * gtk/gtkicontheme.c (load_themes): Fix a couple of typos in
315 handling of SVG/non-SVG unthemed icons.
317 2004-04-19 Morten Welinder <terra@gnome.org>
319 * gtk/gtktoolbar.c (gtk_toolbar_focus): Don't leak list of
322 2004-04-19 Matthias Clasen <mclasen@redhat.com>
324 * gtk/gtktextbtree.c (_gtk_text_line_previous_could_contain_tag):
325 Don't stop the iteration up to the tag_root too
326 early. (#109945, Dongho Shin)
328 Sun Apr 18 17:06:03 2004 Soeren Sandmann <sandmann@daimi.au.dk>
330 * gdk/x11/gdkkeys-x11.c (get_effective_keymap): Make
331 gdk_keymap_translate_keyboard_state() handle NULL
332 keymaps. (#139715, Torsten Schoenfeld).
334 Sun Apr 18 16:59:21 2004 Soeren Sandmann <sandmann@daimi.au.dk>
336 * configure.in: Don't erase GDK_EXTRA_CFLAGS. Fixes bug 139586,
337 reported by Pedro RODRIGUEZ, about compilation problems when
338 Xcursor is installed in a non-standard location.
340 Sun Apr 18 16:15:15 2004 Soeren Sandmann <sandmann@daimi.au.dk>
342 Support for _NET_WM_USER_TIME (bug 115650). Patch by Elijah
345 * gdk/x11/gdkwindow-x11.[ch]: Add new internal function
346 _gdk_x11_set_user_time() to set the _NET_WM_USER_TIME property.
348 * gdk/x11/gdkdisplay-x11.h (struct _GdkDisplayX11): Add user_time field
350 * gdk/x11/gdkdisplay-x11.c: Add _NET_WM_USER_TIME to list of
353 * gdk/x11/gdkinput-x11.c, gdk/x11/gdkevents-x11.c: Set the
354 property on user interaction.
356 2004-04-15 Federico Mena Quintero <federico@ximian.com>
358 * gtk/gtkfilesel.c (open_new_dir): Tell the user to use
359 G_FILENAME_ENCODING, not G_BROKEN_FILENAMES. Fixes #114065.
361 * gtk/gtkfilechooserdefault.c (split_uris): Use a variant of the
362 code from gtkfilesel.c to parse a "text/uri-list" blob. Fixes
365 2004-04-15 Matthias Clasen <mclasen@redhat.com>
367 * gtk/gtkcellrenderer.c (gtk_cell_renderer_class_init):
368 * gtk/gtkbutton.c (gtk_button_class_init): Doc fixes.
370 2004-04-14 Matthias Clasen <mclasen@redhat.com>
374 Make all style properties readonly.
376 2004-04-14 Matthias Clasen <mclasen@redhat.com>
378 * gtk/gtkcolorsel.c: Add a11y relations between the color
379 wheel and the spin buttons. (#132745, Padraig O'Briain)
381 * gtk/gtkiconfactory.c (gtk_icon_set_render_icon): Document
382 the meaning of size == -1.
384 * gtk/gtkwidget.c (gtk_widget_render_icon): Explicitly accept
385 a size of -1. (#137436, Brian Cameron)
387 * gtk/gtkcombobox.c: Make the arrow and separator regular
388 children of an hbox inside the button, and propagate state
389 changes from the button to the cell view. (part of the fix
390 for #138650, should also fix #137535)
392 * gtk/gtkcellview.c (gtk_cell_view_expose): Pass the PRELIT
393 state to gtk_cell_renderer_render() when prelighted. (part
394 of the fix for #138650)
396 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_render):
397 Use PRELIGHT state when appropriate. (part of the fix for
400 * gtk/gtkcombobox.c (gtk_combo_box_relayout): Don't spit
401 out warnings if called before the combo box is
402 realized. (#139742, Philip Langdale)
404 Wed Apr 14 03:45:39 2004 Jonathan Blandford <jrb@gnome.org>
406 * gtk/gtktreeview.c (gtk_tree_view_expose): propagate expose
409 Wed Apr 14 03:32:58 2004 Jonathan Blandford <jrb@gnome.org>
411 * gtk/gtkpathbar.c (make_directory_button): remove spurious
414 Tue Apr 13 16:19:23 2004 Jonathan Blandford <jrb@redhat.com>
416 * gtk/gtkpathbar.c (make_directory_button): patch from Owen to
417 make the buttons sized by a bold label. This makes the text
418 'swim' a little, but stops the buttons from resizing, #137210
420 2004-04-13 Matthias Clasen <mclasen@redhat.com>
422 * gtk/gtkuimanager.c (get_child_node): Don't crash if a node
424 (start_element_handler): Accept separators without unique
425 names. (#133302, Anders Carlsson)
427 * gtk/gtkactiongroup.c (gtk_action_group_add_action): Document
428 possible accelerator gotcha when using this function. (#139641,
431 * gtk/gtkuimanager.c (node_remove_ui_reference): Don't leak
432 list nodes. (#138862, Morten Welinder)
434 Tue Apr 13 12:24:49 2004 Jonathan Blandford <jrb@redhat.com>
436 * gtk/gtktreeview.c (gtk_tree_view_destroy): remove unused
438 (gtk_tree_view_button_press): If we activated the row we don't
439 want to grab focus back, as moving focus to another widget is
440 pretty common, #138458
442 2004-04-12 Federico Mena Quintero <federico@ximian.com>
444 * gtk/gtkfilechooser.c (gtk_file_chooser_class_init): Added
445 documentation to all the signals.
447 2004-04-12 Matthias Clasen <mclasen@dhcp64-228.boston.redhat.com>
449 * gtk/gtkcombobox.c (gtk_combo_box_unset_model): Don't unref
450 model if it is NULL. (#139770)
452 * gtk/gtktreeview.c (gtk_tree_view_get_cell_area): Typo fix.
454 * gtk/gtkentrycompletion.c (gtk_entry_completion_init): Don't add
455 a shadow inside the scrolled window, add it around the vbox.
457 * gtk/gtkentryprivate.h:
458 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
459 Return a boolean indicating whether the popup is positioned above
460 or below. Scroll the completions to the beginning or the end,
461 depending on the positioning.
463 * gtk/gtkentry.c (gtk_entry_completion_key_press): Make keynav
464 wrap around in the entry completion popup, and allow GDK_UP to
465 enter the popup. (#137440)
467 2004-04-12 Matthias Clasen <mclasen@redhat.com>
469 * gtk/gtkentry.c (gtk_entry_size_request): Make sure the style is
470 there before using it.
472 Sun Apr 11 15:08:45 2004 Jonathan Blandford <jrb@gnome.org>
474 * gtk/gtktreeprivate.h: Moved search entries into priv data.
476 * gtk/gtktreeview.c: Prep for type-ahead support.
478 (gtk_tree_view_destroy): Destroy the search window explicitly.
479 (gtk_tree_view_key_press): Minor change; prep for type-ahead
480 (gtk_tree_view_ensure_interactive_directory): New function
481 (gtk_tree_view_focus_out): Rework to handle new entry life-cycle.
482 (gtk_tree_view_real_start_interactive_search): rework
483 (gtk_tree_view_search_dialog_hide): ditto
484 (gtk_tree_view_search_delete_event): ditto
485 (gtk_tree_view_search_button_press_event): ditto
486 (gtk_tree_view_search_key_press_event): ditto
487 (gtk_tree_view_search_move): ditto
488 (gtk_tree_view_search_init): ditto
490 * gtk/gtktreeviewcolumn.c:
491 (gtk_tree_view_column_cell_layout_clear): remove unused variable.
493 * tests/testfilechooser.c: (main): change
495 2004-04-11 Hans Breuer <hans@breuer.org>
497 * gdk/win32/gdkspawn-win32.c : workaround for bug #137496,
498 the real fix would involve just another small API breakage,
499 i.e. gdk_spawn_* using GPid not just gint.
501 * gtk/makefile.msc.in : build gtk-win32.res, not gtk.res
503 2004-04-10 Tor Lillqvist <tml@iki.fi>
505 * gdk/win32/gdkkeys-win32.c (gdk_keymap_translate_keyboard_state):
506 If both Shift and CapsLock pressed, ignore the shift only for
507 letters (that would have been affected by the CapsLock). (#139095)
509 * gdk/win32/gdkglobals-win32.c: Disable tablet support by default,
510 seems to be even buggier now than it used to be. (#138341)
511 Initialize _gdk_input_ignore_wintab to TRUE.
513 * gdk/win32/gdkmain-win32.c: Add --use-wintab switch and
514 GDK_USE_WINTAB environment variable to turn on tablet support.
516 2004-04-09 Christian Persch <chpe@cvs.gnome.org>
518 * gtk/gtkuimanager.c: (gtk_ui_manager_insert_action_group),
519 (gtk_ui_manager_remove_action_group): Terminate
520 g_object_[dis]connect() calls with NULL instead of 0.
523 2004-04-09 Guntupalli Karunakar <karunakar@freedomink.org>
525 * configure.in: Added "gu" (Gujarati) to ALL_LINGUAS.
527 2004-04-07 Federico Mena Quintero <federico@ximian.com>
531 * gtk/gtkfilesystem.c (gtk_file_system_parse): Ensure that the
532 passed-in 'str' is not NULL.
534 * gtk/gtkfilesystemunix.c (expand_tilde): New helper function;
535 expands "~/" or "~foo/" at the beginning of a filename.
536 (gtk_file_system_unix_parse): Use expand_tilde() before doing
539 * gtk/gtkfilechooserentry.c
540 (gtk_file_chooser_entry_maybe_update_directory): Take in a
541 force_reload argument.
542 (gtk_file_chooser_entry_changed): If gtk_file_system_parse()
543 returns an error, set the file_part_pos to -1.
544 (load_directory_callback): Only populate the model if the
545 file_part_pos is not -1.
547 2004-04-06 Pablo Saratxaga <pablo@mandrakesoft.com>
549 * configure.in: Added Icelandic (is) to ALL_LINGUAS
551 2004-04-05 Federico Mena Quintero <federico@ximian.com>
553 * gtk/gtkfilechooserdefault.c (location_popup_handler): Use a
554 title for SAVE and CREATE_FOLDER modes. Fixes #137272.
556 * gtk/gtkfilesystemunix.c (gtk_file_system_unix_make_path): Look
557 for G_DIR_SEPARATOR in the display_name, and err out if it is
558 present; use the same error message as Nautilus. Fixes #136467.
560 * gtk/gtkfilechooserdefault.c (file_pane_create): Make the
561 new-folder button say "Create Fo_lder" rather than "Create
562 _Folder", so that the mnemonic doesn't conflict with the "Save in
563 _folder" label. Fixes #136975.
565 2004-04-05 Federico Mena Quintero <federico@ximian.com>
567 * gtk/gtkpathbar.c (_gtk_path_bar_set_path): Ref/sink the
568 buttons. Also, free them correctly upon failure. Based on a
569 patch by Morten Welinder, fixes #137956.
571 2004-04-05 Anders Carlsson <andersca@gnome.org>
573 * gdk/gdk.c (gdk_arg_context_parse): Handle '--' correctly.
575 Fri Apr 2 17:57:33 2004 Jonathan Blandford <jrb@redhat.com>
577 * gtk/gtktreeview.c (gtk_tree_view_row_inserted): set the height
578 correctly for fixed height when inserting a node, #138082
580 2004-04-01 Federico Mena Quintero <federico@ximian.com>
584 * gtk/gtkpathbar.h (struct _GtkPathBarClass): Add a
585 "child_is_hidden" boolean argument to the "path-clicked" signal.
587 * gtk/gtkpathbar.c (struct _ButtonData): Added a file_is_hidden
589 (make_directory_button): Take a file_is_hidden argument; put it in
591 (_gtk_path_bar_set_path): See whether each path component path is
593 (gtk_path_bar_class_init): Add the file_is_hidden argument to the
594 "path-clicked" signal.
595 (button_clicked_cb): See if the downwards button represents a
596 hidden file for the file_is_hidden argument in the signal
599 * gtk/gtkmarshalers.list: Added a signal type VOID:POINTER,BOOLEAN.
601 * gtk/gtkfilechooserdefault.c
602 (gtk_file_chooser_default_select_path): If we fail to switch
603 folders, don't try to select the path in the file system model.
604 Also, return the result from _gtk_file_system_model_path_do().
605 (gtk_file_chooser_default_select_path): Turn on show_hidden in the
606 file system model if we are asked to select a hidden file.
607 (path_bar_clicked): Show hidden files based on whether the
608 immediate downwards folder in the path bar is a hidden file
610 (struct _GtkFileChooserDefault): Added fields
611 browse_files_popup_menu and browse_files_popup_menu_hidden_files_item.
612 (create_file_list): Set an object data key of
613 "GtkFileChooserDefault" on the tree view so that we can find the
614 impl from the popup menu callbacks. Also, hook up to the
615 "button-press-event" and "popup-menu" signals in the file list to
616 bring up a popup menu.
617 (list_popup_menu_cb): New callback.
618 (list_button_press_event_cb): New callback.
622 * gtk/gtkfilesystemmodel.c
623 (_gtk_file_system_model_new): Oops, connect_object to
626 2004-03-31 Tor Lillqvist <tml@iki.fi>
628 * configure.in: Move AC_CANONICAL_HOST earlier, before the check
629 for native Win32. (#136559, J. Ali Harlow)
631 * gdk/win32/gdkdrawable-win32.c (draw_arc): Use X11 semantics for
632 angles. Thanks to Tim Newsham.
634 2004-03-29 Federico Mena Quintero <federico@ximian.com>
638 * gtk/gtkfilesystem.h (struct _GtkFileFolderIface): Added slots
639 for an ::is_finished_loading() method and a ::finished_loading()
640 signal at the end of the struct.
642 * gtk/gtkfilesystem.c (gtk_file_folder_base_init): Create the
643 "finished-loading" signal.
644 (gtk_file_folder_is_finished_loading): New function.
646 * gtk/gtkfilesystemunix.c
647 (gtk_file_folder_unix_is_finished_loading): Implement.
649 * gtk/gtkfilesystemmodel.c (struct _GtkFileSystemModelClass): New
650 slot for a "finished-loading" signal.
651 (gtk_file_system_model_class_init): Create the "finished-loading"
653 (struct _GtkFileSystemModel): New field
654 idle_finished_loading_source. We emit the "finished-loading"
655 signal in an idle if the root folder was done loading right in
656 _gtk_file_system_model_new(), so that the caller has a chance to
657 connect to the signal.
658 (_gtk_file_system_model_new): Connect to the normal signals of the
659 folder even if the initial _list_children() fails. Also, see if
660 the folder is finished loading; connect to the "finished-loading"
662 (gtk_file_system_model_finalize): Remove the idle handler.
664 * gtk/gtkfilechooserdefault.c (set_list_model): Set a busy cursor
665 and connect to the model's "finished-loading" signal.
666 (get_toplevel): New helper function.
667 (error_message): Use get_toplevel().
668 (trap_activate_cb): Likewise.
669 (location_popup_handler): Likewise.
670 (set_busy_cursor): New function.
671 (browse_files_model_finished_loading_cb): New callback.
673 2004-03-25 Federico Mena Quintero <federico@ximian.com>
675 * gtk/gtkfilechooserdefault.c (check_preview_change): Just use the
676 file under the cursor; we don't need the logic from
677 GtkFileSelection after all. Fixes #132255.
679 2004-03-25 Federico Mena Quintero <federico@ximian.com>
681 * gtk/gtkfilechooserdefault.c (location_entry_create): Fill the
682 location entry with the display name of the file under the cursor
683 for Open mode, or the typed filename in Save mode.
685 2004-03-24 J. Ali Harlow <ali@juiblex.co.uk>
687 * gtk/gtkfilesystemwin32.c
688 (filename_is_root): Bare drive designators (eg., "c:") are
689 no longer considered as root filenames. Fixed #137942
691 2004-03-24 J. Ali Harlow <ali@juiblex.co.uk>
693 * gtk/gtkfilesystemwin32.c
694 (gtk_file_system_win32_create_folder): Invert test for error in
697 2004-03-24 J. Ali Harlow <ali@juiblex.co.uk>
699 Fixed #138004 using Federico's code from #132327.
701 * gtk/gtkfilesystemwin32.c (struct _GtkFileSystemWin32): Add a
702 folder_hash field to keep a list of live folder objects.
703 (gtk_file_system_win32_init): Create the folder_hash.
704 (gtk_file_system_win32_finalize): Destroy the folder_hash.
705 (gtk_file_system_win32_get_folder): Ref and return an existing
706 folder if we have it around, otherwise return a new folder object.
707 (struct _GtkFileFolderWin32): Add a field for the parent file system.
708 (gtk_file_folder_win32_finalize): Remove the folder from the file
710 (gtk_file_system_win32_create_folder): Emit "files-added" on the
711 newly-created folder's parent. Fixes #138004.
713 2004-03-24 J. Ali Harlow <ali@juiblex.co.uk>
715 * gtk/gtkfilesystemwin32.c
716 (gtk_file_system_win32_get_folder): Test that path is actually
717 a directory and throw error if not. Fixed bug #137950
719 2004-03-22 J. Ali Harlow <ali@juiblex.co.uk>
721 * gtk/gtkfilesystemwin32.c
722 (gtk_file_system_win32_volume_get_display_name): Ignore empty
723 volume labels; assume that GetVolumeInformation would fail if
724 GetVolumeInformationW does; catches a small memory leak;
725 pass the buffer size to GetVolumeInformationW in wide
726 characters instead of bytes. Fixes bug #137543
727 (list_volumes): Cope with the theoretical possibility of
728 more than 26 logical drives. Fixes bug #137940
729 (bookmarks_serialize): Now actually removes bookmarks.
732 2004-03-22 Guntupalli Karunakar <karunakar@freedomink.org>
734 * configure.in: Added "pa" (Punjabi) to ALL_LINGUAS.
736 2004-03-21 Tor Lillqvist <tml@iki.fi>
738 * gtk/gtkfilesystemwin32.c
739 (gtk_file_system_win32_volume_get_base_path): Include the
740 backslash. Otherwise gtk_file_system_win32_path_to_uri() returns
741 NULL for a volume base path, as g_filename_to_uri() requires an
742 absolute path, and just a drive letter and colon isn't. (#137543)
744 2004-03-20 Hans Breuer <hans@breuer.org>
746 * gtk/gtkfilesystemwin32.c : applied the undisputable and
747 required [due to recent gtkfilesystem internal api semantic
748 changes] part of patches to fix bug #137543 (Tor Lillqvist,
751 * gdk/gdkevents-win32.c (handle_configure_event) :
752 (gdk_event_translate), WM_WINDOWPOSCHANGED : initialize
753 GdkWindowObject::x, y with screen coords to make
754 gdk_window_get_position () return the right thing and thus fix
755 drag and drop positioning (e.g. Gimp tabs, fixes bug #137192)
757 2004-03-19 Federico Mena Quintero <federico@ximian.com>
759 * Revert the patch to #137520, as 2.4.1 is for conservative bug
760 fixes only. The patch is attached to the bug report, for
763 2004-03-19 Morten Welinder <terra@gnome.org>
765 * gtk/gtkfilechooserdefault.c
766 (gtk_file_chooser_default_set_current_folder): Test existance of
767 the path after checking for locality, if needed.
769 2004-03-19 Federico Mena Quintero <federico@ximian.com>
773 * gtk/gtkfilesystem.h (struct _GtkFileFolderIface): Added slots
774 for an ::is_finished_loading() method and a ::finished_loading()
775 signal at the end of the struct.
777 * gtk/gtkfilesystem.c (gtk_file_folder_base_init): Create the
778 "finished-loading" signal.
779 (gtk_file_folder_is_finished_loading): New function.
781 * gtk/gtkfilesystemunix.c
782 (gtk_file_folder_unix_is_finished_loading): Implement.
784 * gtk/gtkfilesystemmodel.c (struct _GtkFileSystemModelClass): New
785 slot for a "finished-loading" signal.
786 (gtk_file_system_model_class_init): Create the "finished-loading"
788 (struct _GtkFileSystemModel): New field
789 idle_finished_loading_source. We emit the "finished-loading"
790 signal in an idle if the root folder was done loading right in
791 _gtk_file_system_model_new(), so that the caller has a chance to
792 connect to the signal.
793 (_gtk_file_system_model_new): Connect to the normal signals of the
794 folder even if the initial _list_children() fails. Also, see if
795 the folder is finished loading; connect to the "finished-loading"
797 (gtk_file_system_model_finalize): Remove the idle handler.
799 * gtk/gtkfilechooserdefault.c (set_list_model): Set a busy cursor
800 and connect to the model's "finished-loading" signal.
801 (get_toplevel): New helper function.
802 (error_message): Use get_toplevel().
803 (trap_activate_cb): Likewise.
804 (location_popup_handler): Likewise.
805 (set_busy_cursor): New function.
806 (browse_files_model_finished_loading_cb): New callback.
808 Thu Mar 18 12:10:45 2004 Owen Taylor <otaylor@redhat.com>
810 * gtk/gtktreeitem.c (gtk_tree_item_forall): Include
811 eventbox for expander. (#137564, reported by
814 2004-03-18 Guntupalli Karunakar <karunakar@freedomink.org>
816 * mr.po: Added "mr" for Marathi to ALL_LINGUAS.
818 2004-03-17 Morten Welinder <terra@gnome.org>
820 * gtk/gtkfilechooserdefault.c (shortcuts_add_volumes): Free
821 volumes not actually put into the shortcut list.
823 * tests/prop-editor.c (object_changed): Plug leak.
825 * tests/testfilechooser.c (main): Plug some leaks and expose
828 * tests/prop-editor.c (create_prop_editor): Don't leak the tooltip
829 object. Fixed #136652.
831 * gtk/gtkfilechooserdefault.c (check_icon_theme): Do nothing if we
832 have no screen. Fixes #137260.
833 (shortcuts_add_bookmark_from_path): Simplify using check_is_folder
834 thereby fixing leak. Fixes #137259.
836 * gtk/gtkpathbar.c (gtk_path_bar_forall): Make this work when the
837 slider buttons have been destroyed.
838 (gtk_path_bar_remove): Make this work for slider buttons too.
841 2004-03-15 Morten Welinder <terra@gnome.org>
843 * gtk/gtkfilechooserdefault.c (shortcuts_add_bookmark_from_path):
844 Sanitize and plug leak.
845 (check_icon_theme): Only do something if the widget has a screen.
847 Wed Mar 17 01:20:28 2004 Matthias Clasen <maclas@gmx.de>
849 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
850 Move the repositioning logic from _gtk_entry_completion() popup
851 over here. Fixes #137355, reported by Niklas Knutsson.