1 2005-12-06 Behdad Esfahbod <behdad@gnome.org>
3 * gtk/gtksettings.c (settings_update_font_options): Turn metrics
4 hinting on (part of #307196)
6 2005-12-06 Matthias Clasen <mclasen@redhat.com>
8 * gtk/gtkimcontextsimple.c (gtk_im_context_simple_reset): Don't
9 commit from reset, it upstets GtkTextView.
11 * gtk/gtktextview.c (gtk_text_view_check_cursor_blink): Be more
12 careful when turning blinking on and off.
13 (gtk_text_view_focus_out_event): Make the cursor really invisible
14 when the focus goes away. (#323087, Sadrul Habib Chowdhury)
15 (cursor_blinks): Check the gtk-cursor-blink setting first.
17 * gtk/gtktreeview.c (gtk_tree_view_key_press): Fix refcounting
18 issues with new_event and its window.
20 * gtk/gtkmenu.c (gtk_menu_attach_to_widget): Accept NULL
21 as a detach func. (#323386, Jorn Baayen)
23 * gtk/gtkcalendar.c: Avoid conflict with win32 headers in
24 the libdate routines. (#323045, Kazuki Iwamoto)
26 * gdk/gdk.c (gdk_parse_args):
27 * gtk/gtkmain.c (gtk_parse_args): Don't ignore errors
28 from g_option_context_parse().
30 Tue Dec 6 11:37:59 2005 Tim Janik <timj@gtk.org>
32 * gdk/gdkevents.c (gdk_event_new): fix missing hash table
35 Tue Dec 6 10:32:17 2005 Tim Janik <timj@gtk.org>
37 * gtk/gtkstatusbar.c: ported memchunk uses to g_slice, so the code
40 2005-12-05 Federico Mena Quintero <federico@ximian.com>
42 * gtk/gtkfilechooserdefault.c (trap_activate_cb): "event->state &
43 modifiers", not "event->state && modifiers". Patch by Sadrul
44 Habib Chowdhury <imadil@gmail.com>. Fixes bug #323073.
46 2005-12-05 Matthias Clasen <mclasen@redhat.com>
50 * gtk/gtktreedatalist.c:
53 * gtk/gtkitemfactory.c:
54 * gtk/gtkseparator.[hc]:
57 * gtk/gtkgc.c: Use g_slice instead of mem chunks.
59 2005-12-05 Michael Natterer <mitch@imendio.com>
61 * gdk/x11/gdkevents-x11.c: map the new GtkSettings properties
62 "timeout-initial", "timeout-repeat", "color-scheme" and
63 "enable-enimations" to X settings.
65 2005-12-05 Matthias Clasen <mclasen@redhat.com>
68 * gdk/gdkcolor.c: Use g_slice instead of mem chunks.
70 * gtk/gtktreeview.c (gtk_tree_view_key_press): Free new_event
71 after sending it to the search entry. (#323209, Crispin Flowerday)
73 * README.in: Add a note about GTK_FLOATING.
75 * gtk/gtkobject.h (GTK_OBJECT_FLOATING): Use g_object_is_floating.
77 2005-12-02 Matthias Clasen <mclasen@redhat.com>
79 * gtk/gtktoolbutton.c (clone_image_menu_size): Don't leak
80 a pixbuf. (#323024, Paolo Borelli)
82 2005-12-02 Matthias Clasen <mclasen@redhat.com>
84 * gtk/gtkfilesystemunix.c (get_icon_for_mime_type): Don't crash
85 if mime_type is NULL. (#322998, Sadrul Habib Chowdhury)
87 2005-12-02 Michael Natterer <mitch@imendio.com>
89 * gtk/gtkmenu.c: applied modified patch from maemo-gtk which
90 adds a "horizontal-padding" style property. Fixes bug #323036.
92 2005-12-01 Michael Natterer <mitch@imendio.com>
94 Merged modified patch from maemo-gtk that allows to disable
95 toolbar animations. Addresses bug #142582.
97 * gtk/gtksettings.c: added boolean property "gtk-enable-animations".
98 (patch from Christian Neumair)
100 * gtk/gtktoolbar.c: don't animate toolbar changes if the settings
101 property is FALSE. Replaced the individual "notify::foo"
102 connections to GtkSettings by a single "notify" callback and
105 2005-12-01 Michael Natterer <mitch@imendio.com>
107 * gtk/gtkmenu.c (gtk_menu_class_init): removed redundant
108 assignment of widget_class->motion_notify_event.
110 2005-11-29 Matthias Clasen <mclasen@redhat.com>
112 * gtk/gtktoggleaction.c (gtk_toggle_action_class_init): Add
113 an active property. (#322673, Jorn Baayen)
115 Properly handle model changes in GtkTreeSelection: (#322569,
118 * gtk/gtktreeselection.c (gtk_tree_selection_selected_foreach):
119 Get a reference to the model, and stop the iteration if the model
120 of the treeview is changed on the way.
122 * gtk/gtktreeprivate.h:
123 * gtk/gtktreeselection.c (_gtk_tree_selection_emit_changed): New
124 private function to emit the GtkTreeSelection::changed signal.
126 * gtk/gtktreeview.c (gtk_tree_view_set_model): Call
127 _gtk_tree_selection_emit_changed() when the model changes.
129 2005-11-28 Federico Mena Quintero <federico@ximian.com>
131 Fixes the critical warnings from bug #317999, thus fixing the bug
134 * gtk/gtkfilechooserdefault.c
135 (gtk_file_chooser_default_get_paths): In SELECT_FOLDER mode,
136 use _gtk_file_chooser_get_current_folder_path() instead of fetching the
137 impl->current_folder directly. The latter may be null if we are
138 in RELOAD_NONE state.
140 2005-11-28 Federico Mena Quintero <federico@ximian.com>
142 Fix bug #321560, based on a patch by Bogdan Nicula (bogdanni@hotmail.com):
144 * gtk/gtkfilechooserdefault.c (up_folder_handler): Don't add the
145 current_folder to the pending select paths here; the path bar will
147 (path_bar_clicked): Add the child_path to the pending select paths
149 (show_and_select_paths): Don't filter out folders.
150 (show_and_select_paths): Don't take separate arguments for
151 only_one_path and multiple paths.
153 * tests/autotestfilechooser.c (test_folder_switch_and_filters):
154 New test about preserving the filters when we change folders.
156 2005-11-28 Matthias Clasen <mclasen@redhat.com>
158 * gtk/gtkscale.c (_gtk_scale_format_value): Insert an LRM, to prevent
159 -20 to come out as 20- in RTL locales. (#322571, Tze'ela Hebron)
161 * gtk/gtkaction.c (gtk_action_sync_button_stock_id)
162 (connect_proxy): Buttons use the label property for stock ids. (#322565,
165 * gtk/gtkiconview.c (update_text_cell, update_pixbuf_cell): Correctly
166 handle the cell list and indices into it. (#321856)
168 2005-11-28 Matthias Clasen <mclasen@redhat.com>
170 * gtk/gtktooltips.c (gtk_tooltips_timeout): Set timer_tag to 0 when
171 the timeout is done. (#322291, Jean-Yves Lefort)
173 2005-11-28 Matthias Clasen <mclasen@redhat.com>
175 * gtk/gtkfilechooserdefault.c (shortcuts_key_press_event_cb): Make
176 F2 work for renaming bookmarks. (#320822, Jaap A. Haitsma, patch
179 2005-11-28 Tor Lillqvist <tml@novell.com>
181 * gdk/win32/gdkwindow-win32.c (gdk_window_set_urgency_hint):
182 Implement the conditional use of FlashWindowEx() properly for MSVC
183 compilations. The code was confusingly assuming that if compiled
184 with a "new" compiler, it will only be run on "new" Windows
185 versions. We want it to run on "old" versions, too, even if
186 compiled with a "new" compiler. There are two orthogonal issues:
187 whether the compiler defines the necessary API in its headers, and
188 whether it is present at run-time. (#318077)
190 * gtk/gtkcalendar.c (gtk_calendar_init): Use GetLocaleInfo() on
191 Windows to get the localized weekday and month names. strftime()
192 in the Microsoft C library returns strings in the default codepage
193 for the locale of the process, not the system codepage. Thus
194 g_locale_to_utf8() isn't useable on the return value from
195 strftime(). (#322603)
197 2005-11-27 Matthias Clasen <mclasen@redhat.com>
199 * gtk/gtkmessagedialog.c (gtk_message_dialog_new_with_markup):
200 Fix an example. (#322493, Elie De Brauwer)
202 Fix two memory handling problems in GtkTreeView: (#322350,
205 * gtk/gtktreeview.c (gtk_tree_view_destroy)
206 (gtk_tree_view_set_model): Remove all references to nodes in
208 (gtk_tree_view_real_collapse_row): Unmark expanded_collapsed_node
209 before removing the children.
211 * gtk/gtkcolorbutton.c (gtk_color_button_init): Don't leak a
212 PangoLayout here. (#322505, Paolo Borelli)
214 2005-11-27 Tor Lillqvist <tml@novell.com>
216 Once again rework Win32 window decoration code. Doesn't break
217 #104514. The dialogs in gtk-demo now have the same decorations and
218 behaviour as on X11. Tried to fix #322516 but it seems very hard
219 to make the trivial sample program there behave as expected. OTOH,
220 simply moving the gtk_window_decorate() call in the #322516 sample
221 program after the call to gtk_widget_show() helps...
223 * gdk/win32/gdkwindow-win32.c (set_or_clear_style_bits): Revert to
224 the correct semantics. Each call to gdk_window_set_decorations()
225 which calls this function is supposed to affect all decorations.
227 (decorate_based_on_hints): New function, looks at both geometry
228 hints and type hint and sets window decorations based on
229 that. Consolidate code from gdk_window_set_geometry_hints() and
230 gdk_window_set_type_hint() here.
232 (gdk_window_set_geometry_hints, gdk_window_set_type_hint): Call
233 decorate_based_on_hints().
235 2005-11-25 Dom Lachowicz <cinamod@hotmail.com>
237 * modules/engines/ms-windows/*.[ch]: Merge with gtk-wimp's CVS.
238 Includes improved menu icon spacing, [+]/[-] expander drawing,
239 status-bar gippie drawing, and notebook tab drawing.
241 2005-11-24 Michael Natterer <mitch@imendio.com>
243 * gtk/gtktoolbar.h (struct _GtkToolbar): changed two private guint
244 that used to hold signal handler IDs to two guint of padding.
246 * gtk/gtktoolbar.c (struct _GtkToolbarPrivate): added them as
249 (gtk_toolbar_screen_changed): changed accordingly.
251 Wed Nov 23 18:55:47 2005 Tim Janik <timj@imendio.com>
253 * gtk/gtkobject.[hc]: deprecated floating/sink API and implemented it
254 in terms of the GObject floating/sink API.
256 * gtk/gtkaboutdialog.c:
262 * gtk/gtkfilechooserdefault.c:
264 * gtk/gtkinvisible.c:
265 * gtk/gtkitemfactory.c:
268 * gtk/gtkmenutoolbutton.c:
272 * gtk/gtkspinbutton.c:
273 * gtk/gtkstatusicon.c:
277 * gtk/gtktoolbutton.c:
281 * gtk/gtktreeviewcolumn.c:
282 * gtk/gtkuimanager.c:
286 ported to use GObject's g_object_ref_sink().
289 * gtk/gtkfilechooserdefault.c:
290 * gtk/gtkaboutdialog.c:
291 fixed compiler warnings.
293 2005-11-23 Matthias Clasen <mclasen@redhat.com>
295 * gtk/gtksettings.c (gtk_settings_class_init): Add some docs
296 about gtk-color-scheme.
298 2005-11-23 Behdad Esfahbod <behdad@gnome.org>
300 * configure.in (enable_explicit_deps): Fix typo when checking
301 libtool config deplibs_check_method. Moreover, enable explicit
302 deps if we get anything other than pass_all from libtool. (part of
305 2005-11-23 Matthias Clasen <mclasen@redhat.com>
307 * gtk/updateiconcache.c (write_csource): Don't create a big
308 string, since Visual C++ doesn't like strings longer than 64k.
309 (#322238, Kazuki IWAMOTO
311 * gtk/gtkentry.c: Include gtkimcontextsimple.h (#322235,
314 2005-11-23 Michael Natterer <mitch@imendio.com>
316 * gtk/gtkrc.c (gtk_rc_reset_widgets): don't leak all toplevel
317 windows on other screens (correctly remove all temporary
320 2005-11-23 Michael Natterer <mitch@imendio.com>
322 Added symbolic themable colors. Patch is a merged version of
323 proposals from Matthias and maemo-gtk. Fixes bug #114355.
325 * configure.in: require glib >= 2.9.1 for refcountable hashtables.
327 * gtk/gtksettings.c: added property "color-scheme" which is a
328 string defining colors like "foreground:black\nbackground:grey".
329 Automatically provide a name->GdkColor hash table mapping for the
332 * gtk/gtkrc.[ch]: added list of color hashes that works like the
333 list of icon factories. Append the color scheme hash from
334 GtkSettings if it exists. Extended gtkrc syntax to allow defining
335 and referencing of logical colors. Also allow to modulate colors
336 in gtkrc by using arbitrary expressions of mix(), shade(),
337 lighter() and darker(). Added internal function
338 _gtk_rc_style_get_color_hashes().
340 * gtk/gtkstyle.[ch]: keep a private list of color hashes around.
341 Get the list from _gtk_rc_style_get_color_hashes(). Export
342 internal function _gtk_style_shade() (used by above color
343 expressions). Added public API gtk_style_lookup_color() which
344 looks up a logical color by name.
346 * gtk/gtk.symbols: add gtk_style_lookup_color
348 * tests/testgtkrc: use symbolic colors for making
351 2005-11-22 Michael Natterer <mitch@imendio.com>
353 Made button-press timeouts which work like key repeat timeouts
354 configurable. Addresses bug #142582:
356 * gtk/gtksettings.c: added properties "gtk-timeout-initial" and
357 "gtk-timeout-repeat" which defalt to 200/20 (ms).
359 Use the values from GtkSettings instead of hardcoding them
360 (the repeat value is either taken as-is for fast repeat or
361 multiplied by 5 for slow repeat). Changed all places to use these
362 two standard initial/repeat timings:
364 * gtk/gtkcalendar.c (unchanged 200/20)
365 * gtk/gtknotebook.c (unchanged 200/100)
366 * gtk/gtkpathbar.c (changed from 300/150 to 200/100)
367 * gtk/gtkrange.c (changed from 250/100 to 200/100)
368 * gtk/gtkspinbutton.c (unchanged 200/20)
370 2005-11-21 Anders Carlsson <andersca@imendio.com>
378 * docs/tools/Makefile.am:
379 Only build docshooter when the X11 backend is used.
381 * gtk/gtkplug-stub.c:
382 Include gtkplug.h here.
384 * gtk/gtksocket-stub.c:
385 Include gtksocket.h here.
387 2005-11-21 Matthias Clasen <mclasen@redhat.com>
389 * gtk/gtkinputdialog.c: Convert GtkInputDialog to
390 g_type_class_add_private.
392 * gtk/gtksocket.c: Convert GtkSocket to g_type_class_add_private.
394 * gtk/gtkmenu.c: Convert GtkMenu to g_type_class_add_private.
397 * gtk/gtkcombobox.[hc]: Add a tearoff-title property,
398 with getter and setter. (#316482, Olexiy Avramchenko)
400 * tests/testcombo.c (main): Test gtk_combo_box_set_title
402 * gtk/gtkpathbar.c: Merge remaining fixes from the 2.8 branch,
403 pointed out by Michael Natterer.
405 Fix for bug #321542, Benedikt Meurer:
407 * gtk/gtkcombobox.c (gtk_combo_box_set_active_internal):
410 (gtk_combo_box_child_show, gtk_combo_box_child_hide): Use
411 g_signal_emit, not g_signal_emit_by_name.
413 2005-11-18 Matthias Clasen <mclasen@redhat.com>
415 Fix crashes in connection with pathbar scrolling (#321560,
418 * gtk/gtkpathbar.c (gtk_path_bar_update_slider_buttons):
419 Stop scrolling when desensitising slider buttons.
420 (gtk_path_bar_scroll_timeout, gtk_path_bar_slider_button_press):
423 * gtk/gtkpathbar.h (struct _GtkPathBar): Add a separate
426 2005-11-18 Matthias Clasen <mclasen@redhat.com>
428 * gtk/gtkpathbar.c (button_clicked_cb): Fix a C99ism.
429 (#321777, Jens Granseuer)
431 * gtk/gtkaction.c (disconnect_proxy): Disconnect the
432 sync callback for the visibility property. (#321761,
435 Turn off input methods in invisible entries, since
436 they are confusing. (#317002, James Su)
438 * gtk/gtkentry.c (gtk_entry_set_visibility): Toggle input
439 methods if visibility changes.
440 (popup_targets_received): Don't show the input method
441 menu if the entry is invisible.
443 2005-11-17 Matthias Clasen <mclasen@redhat.com>
445 * README.in: Add a note about range arrow sensitivity.
447 * perf/treeview.c: const correctness fixes
448 found by Arjan van de Ven and gcc.
450 2005-11-16 Michael Natterer <mitch@imendio.com>
452 * gtk/gtkimage.c (animation_timeout): call
453 gtk_window_process_updates() so the animation keeps running even
454 if the main loop is busy with sources that eat a lot of cpu with
455 high priority. Fixes bug #321444.
457 (gtk_image_new_from_animation): document the fact that the
458 animation will stop running if the main loop is busy with sources
459 that have priorities higher than G_PRIORITY_DEFAULT.
461 * tests/testimage.c: added test case that shows an animation even
462 though a cpu-eating idle function is running.
464 2005-11-16 Michael Natterer <mitch@imendio.com>
466 * gdk/x11/gdkevents-x11.c (_gdk_events_uninit): new internal
467 function which destroys the display's event source. Also removes
468 the source from the global display_sources list and unrefs it.
470 * gdk/x11/gdkprivate-x11.h: declare the function.
472 * gdk/x11/gdkdisplay-x11.c (gdk_display_x11_dispose): call it
473 instead of half-destroying the source here.
475 2005-11-15 Matthias Clasen <mclasen@redhat.com>
477 * gtk/gtktreestore.c (gtk_tree_store_move): Fix a memory
478 leak. (#321032, Peter Zelezny)
480 2005-11-15 Michael Natterer <mitch@imendio.com>
482 * gdk/x11/gdkdisplay-x11.c (gdk_display_x11_finalize): destroy
483 display->xid_ht as late as possible (right before XCloseDisplay)
484 because it still needs to be around when the display's screens are
487 2005-11-14 Matthias Clasen <mclasen@redhat.com>
489 * gtk/gtkselection.c (gtk_selection_data_set_uris): Don't
490 leak result. (#321441, Tommi Komulainen)
492 2005-11-14 Matthias Clasen <mclasen@redhat.com>
494 * gtk/gtkicontheme.c (gtk_icon_theme_get_icon_sizes):
495 Don't crash if there is no builtin icon.
497 2005-11-14 Michael Natterer <mitch@imendio.com>
499 * gtk/gtkcellrenderertoggle.c (gtk_cell_renderer_toggle_set_property):
500 removed redundant calls to g_object_notify().
502 2005-11-13 Matthias Clasen <mclasen@redhat.com>
504 * gdk/gdkcolor.c (gdk_color_parse): Documentation
505 improvements. (#321338)
507 * gtk/gtktextiter.c (gtk_text_iter_forward_search): Make
508 limit an inclusive boundary. (#321299)
510 2005-11-12 Michael Natterer <mitch@imendio.com>
512 * gtk/Makefile.am: fixed icon rules so gtkbuiltincache.h is only
515 2005-11-12 Dom Lachowicz <cinamod@hotmail.com>
517 * modules/engines/ms-windows/msw_style.c: Bug #313627. Make win32
518 theme's handling of toolbars, handleboxes, and menubars more in-line
519 with Microsoft's IE style.
520 * modules/engines/ms-windows/*.c: Indentation cleanups
522 2005-11-12 Matthias Clasen <mclasen@redhat.com>
524 Make builtin icons work in gtk_window_set_icon_name()
525 (#321046, Maxim Udushlivy)
527 * gtk/gtkicontheme.c (insert_theme): Always insert the default
529 (ensure_valid_themes): Call _gtk_icon_theme_ensure_builtin_cache()
531 (theme_lookup_icon, find_builtin_icon): ...and not from here.
532 (gtk_icon_theme_lookup_icon): Remove an unncessary assert.
533 (gtk_icon_theme_get_icon_sizes): Also check builtin icons.
535 2005-11-12 Tor Lillqvist <tml@novell.com>
537 * gtk/gtkfilesystemwin32.c (filename_get_info): Don't hide
538 dotfiles, no such convention on Win32. Just hide files with the
539 hidden attribute. (#314627)
541 2005-11-11 Federico Mena Quintero <federico@ximian.com>
543 * gtk/gtkfilechooserdefault.c (shortcuts_insert_path): Do not
544 check whether the path is a folder. It is useful to bookmark
545 files as well (e.g. todo.txt), and this will also help
547 (shortcuts_add_bookmark_from_path): Likewise.
548 (shortcuts_activate_iter): Change folders or select files, as
551 2005-11-11 Federico Mena Quintero <federico@ximian.com>
553 * tests/autotestfilechooser.c (main): Use
554 g_log_set_default_handler() instead of explicitly setting a
555 handler for each domain.
557 * gtk/gtkfilechooserdefault.c (shortcuts_add_volumes): Only get
558 the base path of the volume if it is mounted.
560 2005-11-11 Michael Natterer <mitch@imendio.com>
562 Added per-stepper API for GtkRange's stepper sensitivity as
563 discussed in bug #321056:
565 * gtk/gtkenums.h: added GtkSensitivityType which can be
568 * gtk/gtkrange.[ch]: added properties "lower-stepper-sensitivity"
569 and "upper-stepper-sensitivity" and public getters/setters for
570 them. Changed stepper drawing to honor the new properties.
572 * gtk/gtk.symbols: added the new symbols.
574 2005-11-10 Matthias Clasen <mclasen@redhat.com>
576 * gtk/gtkcombobox.c: Add show-popup and hide-popup signals and
577 emit them when the popup is shown or hidden. (#162531, Tommi
580 * tests/testcombo.c: Add an example of popuplating a combobox
583 * gtk/gtktreeview.c (gtk_tree_view_motion_resize_column): Another
586 * gdk/x11/gdkcolor-x11.c (gdkx_colormap_get): Remove an erroneous
589 Don't corrupt odd keymaps (#316638, Kean Johnston)
591 * gdk/x11/gdkkeys-x11.c (set_symbol): Auxiliary function to
592 handle frobbing keymaps with odd numbers of syms/code.
594 * gdk/x11/gdkkeys-x11.c (update_keymaps): Use set_symbol() to
597 Improve navigation to parent folders. (#318444, Andrei Yurkevich)
599 * gtk/gtkpathbar.[hc]: Add a child_path argument to
600 the path_clicked signal.
601 * gtk/gtkfilechooserdefault.c (path_bar_clicked): Select the
602 child_path, if it is provided.
603 * gtk/marshalers.list (path_bar_clicked): Add the necessary
606 * gtk/gtkmenu.c: Fix some compiler warnings. (#321141,
611 * gtk/gtktreeview.c: Implement a getter for headers-clickable.
612 (#163851, Richard Hult)
614 2005-11-10 Michael Natterer <mitch@imendio.com>
616 Applied patch from maemo-gtk that addresses many issues wrt
617 display migration and display closing (bug #85715).
619 * gdk/gdkdisplay.c (gdk_display_dispose): don't just set the
620 default display to NULL when it's closed. Instead set the most
621 recently opened display as new default (if one exists).
623 * gdk/gdkpango.c (on_renderer_display_closed): fixed signature
626 * gdk/gdkscreen.c (gdk_screen_dispose): check if the GCs still
627 exist before unrefing them.
629 * gdk/gdkwindow.c (_gdk_window_destroy_hierarchy): if the screen
630 is closed, allow destruction of the root window.
632 * gdk/x11/gdkdisplay-x11.c: moved some stuff from finalize() to
633 dispose(), free stuff that was leaked before.
635 * gdk/x11/gdkevents-x11.c (_gdk_x11_events_uninit_screen): check if
636 the xsettings_client still exists before destroying it.
638 * gdk/x11/gdkkeys-x11.c: added finalization and free the allocated
641 * gdk/x11/gdkpixmap-x11.c: moved stuff from finalize() to new
642 dispose() implementation.
644 * gdk/x11/gdkscreen-x11.c: moved stuff from finalize() to
645 dispose() and check if it still exists before unrefing it. Set
646 their pointers to NULL/None *after* upchaining in dispose(),
647 because X11 implementations of members of the parent class still
648 need them for their own destruction.
650 * gdk/x11/gdkvisual-x11.c: removed finalize() implementation which
651 was g_error()ing when finalizing a visual.
653 * gtk/gtkclipboard.c (gtk_clipboard_finalize): don't use
654 get_clipboard_widget() because it would create the widget if it
655 doesn't exist. Use g_object_get_data() directly instead.
657 * gtk/gtktextdisplay.c (on_renderer_display_closed): fixed signature
660 2005-11-10 Simos Xenitellis <simos@gnome.org>
662 * configure.in: Added Tatar (tt) to ALL_LINGUAS.
664 Wed Nov 9 16:29:42 2005 Tim Janik <timj@imendio.com>
666 * gtk/gtkrange.c: patch from maemo-gtk that changes GtkRange
667 to render its arrows insensitive when the adjustment is in
668 its min or max position. this makes range arrow behaviour
669 consistent with spin button behaviour. (#321056)
671 2005-11-09 Tor Lillqvist <tml@novell.com>
674 * gdk/gdk.c (gdk_debug_keys[]): Add new GDK_DEBUG_DRAW flag to
675 the GdkDebugFlag enum.
677 * gdk/win32/gdkdrawable-win32.c: Use DRAW to trigger GDK_NOTEs in
678 this file instead of MISC. Now asking for MISC will give mainly
679 window manipulation debugging output with the Win32 backend.
681 2005-11-09 Tor Lillqvist <tml@novell.com>
683 * gdk/win32/gdkwindow-win32.c: Remove unnecessary includes.
685 (_gdk_win32_get_adjusted_client_rect): Remove this two-line
686 function which was used only in one place.
688 (get_outer_rect): Use _gdk_win32_adjust_client_rect().
690 (gdk_window_set_geometry_hints): If we have identical minimum and
691 maximum size hints, remove the resize and maximize
692 decorations/functions. (#104514)
694 If we have a maximum size hint, remove the maximize
695 decoration/function but ensure the resize decoration/function is
696 available. Otherwise ensure both resize and maximize
697 decorations/functions are there.
699 (set_or_clear_style_bits): Factored out common code from
700 gdk_window_set_decorations() and gdk_window_set_functions().
702 Hack the window style setting once more: Only touch the window
703 style bits corresponding to the GdkWMDecoration or GdkWMFunction
704 parameter bitmasks. Hopefully this finally is the correct thing to
705 do. We used to clear all other bits than those that were being
706 set, or set all other bits than those that were being cleared.
708 Take into account that adding or removing decorations leaves the
709 window's outer size unchanged, i.e., the client area's size and
710 position change. This is apparently not what we want, so change
711 also the window's (outer) position and size appropriately so that
712 the client area's position and size stay constant.
714 gtk-demo's color selector dialog is now non-resizable like on X11
715 (I tested with metacity in GNOME). Torn off menus are shrinkable
716 vertically but have a maximum size, and are not maximizable or
717 minimizable, like on X11.
719 (gdk_window_set_decorations, gdk_window_set_functions): Let
720 set_or_clear_decorations() do most of the job.
722 * gdk/win32/gdkprivate-win32.h: Remove declaration of
723 _gdk_win32_get_adjusted_client_rect().
725 2005-11-09 Tor Lillqvist <tml@novell.com>
727 * gdk/win32/gdkwindow-win32.h (struct _GdkWindowImplWin32)
728 * gdk/win32/gdkwindow-win32.c (gdk_window_impl_win32_init,
729 gdk_window_get_type_hint, gdk_window_get_type_hint): Store the
730 type hint. Implement gdk_window_get_type_hint() by just returning
733 2005-11-09 Tor Lillqvist <tml@novell.com>
735 * gdk/win32/gdkwindow-win32.c (gdk_window_set_geometry_hints):
736 Remove code that has been permanently ifdeffed out for two years.
738 2005-11-08 Matthias Clasen <mclasen@redhat.com>
740 * gdk/gdkgc.c (gdk_gc_finalize): Unref tile and stipple when
741 finalizing a gc. (#320789, Nickolay V. Shmyrev)
743 * gdk/x11/gdkwindow-x11.c (gdk_window_set_icon_list): Ignore
744 icons if they would make the request large enough to cause
745 Xlib to loose the connection. (#320909, Claudio Saavedra)
747 2005-11-08 Michael Natterer <mitch@imendio.com>
751 * gdk/x11/gdkwindow-x11.c: added gdk_window_get_type_hint() (patch
752 extracted from maemo-gtk). Fixes bug #320872.
754 2005-11-07 Matthias Clasen <mclasen@redhat.com>
756 * gtk/gtkfilechooserdefault.c (shortcuts_reorder): Don't
757 looks the bookmark label when reordering. (#320720, Jeremy Cook)
759 * gtk/gtkpathbar.[hc]: Set focus-on-click to FALSE for all buttons.
760 Don't grab focus when a slider button is pressed, instead, use
761 a bit in the pathbar struct to determine whether to scroll up
762 or down. (#314486, Carlos Garnacho)
764 * gtk/gtkentrycompletion.c (_gtk_entry_completion_popup):
765 Don't popup the completions if the focus has already been
766 moved somewhere else. (#319914, Christian Persch)
768 * gtk/gtktoolitem.c (_gtk_tool_item_toolbar_reconfigured):
769 Raise the drag_window after reconfiguring the
770 toolbar. (#320803, Christian Persch)
773 * gtk/gtkfilechooserbutton.h:
774 * gtk/gtkfilechooserbutton.c: Add a focus-on-click property
775 with setter and getter. (#318945, Christian Persch)
777 Mon Nov 7 16:15:16 2005 Tim Janik <timj@imendio.com>
779 * configure.in: fixed missing $X_CFLAGS setup in case x11.pc is present.
781 2005-11-07 Matthias Clasen <mclasen@redhat.com>
783 * configure.in: Adjust to the stock icon changes.
785 2005-11-07 Tor Lillqvist <tml@novell.com>
787 * gdk/win32/gdkcursor-win32.c (pixbuf_to_hbitmaps_normal):
788 Correct the calculation of maskstride. (#320152, Peter Zelezny)
790 2005-11-06 Michael Natterer <mitch@imendio.com>
792 * gtk/Makefile.am (icons): fixed rule to actually create the
793 symlinks, erroring out if anything goes wrong.
795 2005-11-06 Tor Lillqvist <tml@novell.com>
797 * gtk/updateiconcache.c (build_cache): Can't rename a file if the
798 target exists on Win32. First rename the target temporarily, then
799 if the renaming of the source to target fails, restore the
800 original name for the target.
802 * gtk/Makefile.am: Use EXEEXT in the dependency on gtk-update-icon-cache.
804 2005-11-06 Tor Lillqvist <tml@novell.com>
806 (pixbuf_to_hbitmaps_alpha_winxp): Use an 1-bit mask bitmap,
807 like pixbuf_to_hbitmaps_normal().
808 (_gdk_win32_pixbuf_to_hicon_supports_alpha): Check
809 G_WIN32_IS_NT_BASED() first, so we can pretend being on Win9x by
810 setting the G_WIN32_PRETEND_WIN9X environment variable.
812 2005-11-06 Tor Lillqvist <tml@novell.com>
814 Make icon masks work on Win98 (#320152, Peter Zelezny)
816 * gdk/win32/gdkcursor-win32.c (create_color_bitmap): Take also a
817 parameter for the depth of the bitmap, so that this function can
818 be used to create 1-bit bitmaps, too.
819 (pixbuf_to_hbitmaps_normal): Create an 1-bit bitmap for the mask,
820 and initialize it properly.
822 2005-11-04 Matthias Clasen <mclasen@redhat.com>
824 Store builtin stock icons in an icon cache, instead of
825 populating a hash table with pixbufs at startup, to save both
826 memory and startup time.
828 * gtk/stock-icons/*: Reorganize the icons in a directory structure
829 suitable for gtk-update-icon-cache, and rename them to match the
832 * gtk/gtkiconcache.[hc]: Support non-mmapped icon caches, and
833 add _gtk_icon_cache_has_icon_in_directory().
835 * gtk/updateiconcache.c: Support a --source <VARIABLE> argument
836 to store the contents of the icon cache in a C header.
838 * gtk/gtkbuiltincache.h: Generated private header which contains
839 the icon cache for the builtin icons.
841 * gtk/gtkicontheme.c: Create a GtkIconCache for the builtin
842 icons, and use that in addition to the hash table whenever
843 builtin icons are searched.
845 * gtk/gtkiconfactory.c: Add GTK_ICON_SOURCE_STATIC_ICON_NAME and
846 use it for static stock ids.
847 (get_default_icons): Don't add the builtin
848 icons to the icon theme, just register the stock ids.
849 (render_fallback_image): Take the fallback image out of the
852 * gtk/Makefile.am: Remove stock-icons from SUBDIRS and add
853 the necessary machinery to rebuild gtkbuiltincache.h.
855 2005-11-04 Michael Natterer <mitch@imendio.com>
857 * gtk/gtkrc.c (gtk_rc_reparse_all_for_settings): applied patch
858 from maemo-gtk that changes the mtime check for rc files from
859 '>' to '!=', otherwise theme changes go unnoticed when turning
860 back the clock (Tommi Komulainen).
862 2005-11-04 Tor Lillqvist <tml@novell.com>
864 * gtk/gtkstatusicon.c (gtk_status_icon_set_tooltip): Plug memory
867 2005-11-03 Tor Lillqvist <tml@novell.com>
869 * gdk/win32/gdkcursor-win32.c: As there is only one GdkDisplay in
870 the Win32 backend, check that GdkDisplay* parameters are equal to
871 _gdk_display instead of using the unnecessarily general
874 (pixbuf_to_hbitmaps_alpha_winxp): Rename the variables for the
875 color bitmap to have "color" in their name, for similarity with
876 pixbuf_to_hbitmaps_normal(). Create a color bitmap for the mask,
877 too, instead of creating a b&w bitmap with CreateBitmap(). Set up
878 the mask bitmap's contents, ones for those pixels in the color
879 bitmap where the alpha is zero, zero for other pixels. We used to
880 use an uninitialized mask bitmap! This meant that icons and
881 cursors created presumably worked more or less by accident.
882 Totally blank icons with zero alpha everywhere (as used by
883 gtktrayicon.c) definitely did not work as expected.
885 * gtk/Makefile.am: Include gtkstatusicon.c on all platforms.
887 * gtk/gtkstatusicon.c: Implement for Win32. Use code from
888 gtktrayicon-win32.c as applicable. (gtktrayicon-win32.c is not
889 necessary and can be removed from CVS. It has never been mentioned
890 in gtk/Makefile.am.) No tray icon widget, GtkImage or GtkTooltips
891 are used on Win32. One label widget is used (but never shown) as
892 gtk_widget_render_icon() needs a widget.
894 Ifdefs used as necessary in several places. It might be cleaner to
895 split out the backend-specific parts to separate files, or at
896 least collect them into separate blocks in the file.
898 (wndproc): New function. Window procedure to monitor mouse events
899 in the system tray icon. Call gtk_status_icon_button_press() as
901 (create_tray_observer): New function. Creates a hidden window that
902 only serves as a tray icon message observer.
904 * tests/teststatusicon.c (icon_activated): Position the dialog
905 with GTK_WIN_POS_CENTER.
906 (do_quit): New function, hide and unref the GtkStatusIcon, and
907 call gtk_main_quit().
908 (popup_menu): Add a Quit menu item that calls do_quit().
910 2005-11-02 Tor Lillqvist <tml@novell.com>
912 * gdk/win32/gdkcolor-win32.c
913 * gdk/win32/gdkscreen-win32.c
914 * gdk/win32/gdkwindow-win32.c: Whitespace consistency
915 fixes. Remove superfluous test for GdkWindow* parameters being
916 non-NULL. Testing GDK_IS_WINDOW() is enough. As there is only one
917 GdkScreen and one GdkDisplay in the Win32 backend, use those
918 variables instead of the getter functions. For GdkDisplay* and
919 GdkScreen* parameters, check that they are equal to the
920 corresponding singleton variables instead of the more general
921 GDK_IS_DISPLAY() or GDK_IS_SCREEN().
923 2005-11-02 Matthias Clasen <mclasen@redhat.com>
925 * gtk/gtktextview.c: Remove some g_return_if_fail() from
926 static functions, replace some others by g_assert().
928 * gtk/gtktextview.c (selection_motion_event_handler)
929 (gtk_text_view_start_selection_drag): Keep track of the original
930 selection boundaries during a drag selection, in order to correctly
931 decide when to extend or shrink the selection. (#320167,
932 reported by Arvind S N, patch by Paolo Borelli)
934 * gtk/gtktextbtree.c (_gtk_text_line_char_to_byte_offsets):
935 * gtk/gtktextiter.c (gtk_text_iter_backward_chars): Replace
936 manual offset calculations by g_utf8_offset_to_pointer().
937 (#320360, Paolo Borelli)
939 Tue Nov 1 16:18:24 2005 Tim Janik <timj@imendio.com>
941 * gtk/gtkrbtree.[hc]: get rid of GAllocator usage, allocate and free
942 nodes via the g_slice_*() API.
943 _gtk_rbtree_new(): fixed wrong node allocation via g_new().
945 2005-11-01 Tor Lillqvist <tml@novell.com>
947 * gdk/win32/gdkprivate-win32.h
948 * gdk/win32/gdkglobals-win32.c
949 * gdk/win32/gdkmain-win32.c (_gdk_windowing_init): Add more
950 pre-interned GdkAtoms and pre-registered clipboard formats. Sort
951 their declarations, definitions and assignments into a more
952 logical and consistent order.
954 * gdk/win32/gdkmain-win32.c (_gdk_win32_cf_to_string): Include the
955 CF_ prefix for the predefined clipboard format names. Put quotes
956 around registered format names to distinguish them.
958 * gdk/win32/gdkproperty-win32.c (gdk_property_change): Return
959 immediately with a warning if the property type is STRING, TEXT,
960 COMPOUND_TEXT or SAVE_TARGETS, as these are X11-specific that we
961 should never pretend to handle on Win32. Handle only UTF8_STRING
962 here, other formats with delayed rendering. Use \uc1 instead of
963 \uc0 when generating Rich Text Format for easier testability on
964 XP, where WordPad misinterprets \uc0 encoded characters. Add more
965 GDK_NOTE debugging output for Clipboard operations.
967 * gdk/win32/gdkselection-win32.c: Debugging printout improvements.
968 (gdk_selection_convert): Don't pretent to handle STRING, just
969 UTF8_STRING. Streamline error handling, don't unnecessarily have a
970 GError which then isn't used for anything anyway if it gets set.
971 (gdk_win32_selection_add_targets): Skip also STRING, TEXT,
972 COMPOUND_TEXT and SAVE_TARGETS in addition to UTF8_STRING.
974 * config.h.win32.in: Sync with what configure produces.
976 * configure.in: Don't look for X_PACKAGES unless building for
977 x11. (#313986, John Ehresman)
979 2005-10-28 Erdal Ronahi <erdal.ronahi@gmail.com>
981 * configure.in: Added ku (Kurdish) to ALL_LINGUAS
982 Wondered why there was no ku there before??
984 2005-10-28 Matthias Clasen <mclasen@redhat.com>
986 * gtk/gtkentrycompletion.c (_gtk_entry_completion_popup): Add the popup
987 window to the toplevels window group. (#319912, Christian Persch)
989 2005-10-28 Kristian Rietveld <kris@gtk.org>
991 * gtk/gtktreemodelfilter.c (gtk_tree_model_filter_row_deleted): fix
994 2005-10-28 Matthias Clasen <mclasen@redhat.com>
996 * gtk/gtkdnd.c (gtk_drag_get_cursor): Fix the anchor of the default
997 drag cursors. (#319200, Federico Mena Quintero)
999 * gtk/gtktreeview.c (gtk_tree_view_search_key_press_event): Handle
1000 Shift-G to go to the previous match, like firefox. (#320061, Christian
1003 * gtk/gtktreemodelfilter.c (gtk_tree_model_filter_build_level): Fix a
1004 C99ism. (#320000, Kazuki Iwamoto)
1006 * gtk/gtkaboutdialog.c (gtk_about_dialog_init): Add the little
1007 stars. (#319985, Bastien Nocera)
1009 * gtk/gtktreeview.c (gtk_tree_view_search_entry_flush_timeout): Return
1010 FALSE, so we don't flush repeatedly. (#319151, Alexander Larsson)
1012 2005-10-26 Michael Natterer <mitch@imendio.com>
1016 * gtk/gtkcellrendererpixbuf.c (gtk_cell_renderer_pixbuf_set_property):
1017 make sure that setting any of pixbuf/stock-id/icon-name resets the
1018 others because they are mutually exclusive, and that unsetting any
1019 of them only resets the pixbuf and nothing else. Also added
1020 some missing g_object_notify().
1022 (gtk_cell_renderer_pixbuf_get_property): simplified calls to
1023 g_value_set_object().
1025 (gtk_cell_renderer_pixbuf_create_stock_pixbuf)
1026 (gtk_cell_renderer_pixbuf_create_named_icon_pixbuf): added
1027 g_object_notify ("pixbuf").
1029 2005-10-27 Matthias Clasen <mclasen@redhat.com>
1031 * gtk/gtktreeview.c (gtk_tree_view_button_press): Be more
1032 careful about initializing cell_area. (#319382, Tommi
1035 * gtk/gtkcombobox.c (gtk_combo_box_key_press): Don't eat
1036 Ctrl-PageUp/PageDown. (#318670, Christian Neumair)
1038 * demos/gtk-demo/clipboard.c (paste_received): Only set the
1039 text if it is not NULL. (#319930, Thomas Klausner)
1041 * gtk/gtkselection.c (gtk_selection_data_get_pixbuf): Close the
1042 loader before trying to get the pixbuf. (#319930, Thomas Klausner)
1044 2005-10-26 Matthias Clasen <mclasen@redhat.com>
1046 * gtk/gtkfilesystem.c (gtk_file_system_module_load):
1047 * gtk/gtkthemes.c (gtk_theme_engine_load):
1048 * gtk/gtkimmodule.c (gtk_im_module_load): Use G_MODULE_BIND_LAZY
1049 when dlopening modules. (#319557, Laszlo Peter)
1051 2005-10-26 Matthias Clasen <mclasen@redhat.com>
1053 * gtk/gtktextbtree.c (gtk_text_btree_resolve_bidi): Only use text
1054 segments when determining text direction. (#319065, Tommi Komulainen)
1056 * gtk/gtktreeview.c (gtk_tree_view_destroy): Don't crash
1057 on duplicate destroy. (#318953, Gustavo Carneiro)
1059 * gtk/gtkfilechooserbutton.c (gtk_file_chooser_button_new_with_dialog):
1060 Point out that destroy-with-parent is a bad idea for the dialog
1061 passed to this function. (#318943, Christian Persch)
1063 * */Makefile.am: use $(GLIB_MKENUMS) instead of
1064 glib-mkenums. (#318582, Damien Carbery)
1066 * gtk/gtktreemodel.c (gtk_tree_model_rows_reordered): Clarify
1067 docs. (#317682, Christian Neumair)
1069 * gdk/x11/gdkdnd-x11.c: Remove an extra const which doesn't
1070 seem to affect the placement of the data in the readonly
1071 section, and causes problems with some compilers. (#317844)
1073 2005-10-25 Matthias Clasen <mclasen@redhat.com>
1075 * gtk/gtktreeviewcolumn.c (gtk_tree_view_column_cell_process_action):
1076 Fix some issues with background drawing in RTL. (#318781,
1079 * tests/Makefile.am:
1080 * tests/testentrycompletion.c: Apply a patch by Christian
1081 Persch to add property editors.
1083 * gtk/gtkstatusicon.c: Emit activate on single-click,
1084 not on double-click, change proposed by Milosz Derezynski.
1086 2005-10-25 Kristian Rietveld <kris@gtk.org>
1088 Fixes #311955, reported by Markku Vire; and a lot more.
1090 * gtk/gtktreemodelfilter.c: Made this thing work correctly.
1091 Levels can now have invisible nodes cached, functions have been
1092 rewritten/refactored to take this into account; also the logic in
1093 some functions has been corrected.
1095 Each referenced node now references all visible children or a single
1096 invisible child, in order to be able to monitor all changes in the
1097 child model required for correct operation.
1099 When a virtual root is set, all nodes on the virtual root level are
1102 At last, a bunch of random bug fixes and comment updates.
1104 2005-10-25 Matthias Clasen <mclasen@redhat.com>
1106 * gtk/gtktexttagtable.c (gtk_text_tag_table_foreach): Add some
1107 more docs. (#319722, Paolo Borelli)
1109 * gdk/x11/gdkxftdefaults.c (init_xft_settings): Make the
1110 initialization of screen_x11->xft_rgba more explicit. (#319627,
1113 * gtk/gtkfilechooser.c (gtk_file_chooser_class_init): Fix whitespace
1114 in a blurb. (#319499, Francisco Javier F. Serrador)
1116 2005-10-24 Matthias Clasen <mclasen@redhat.com>
1118 Add settings to hide the input method and Unicode control character
1119 submenus in the context menus of GtkEntry and GtkTextView.
1121 * gdk/x11/gdkevents-x11.c: Map GTK+ settings to X settings.
1123 * gtk/gtksettings.c (gtk_settings_class_init): Declare GTK+ settings here.
1125 * gtk/gtktextview.c (popup_targets_received):
1126 * gtk/gtkentry.c (popup_targets_received): Use the settings here.
1128 2005-10-24 Kristian Rietveld <kris@gtk.org>
1130 * gtk/gtktreemodelsort.c (gtk_tree_model_sort_row_inserted): emitting
1131 row-has-child-toggled when the level is not in the cache does not
1132 make sense. (This bug probably crept in during the early stages
1133 of GtkTreeModelSort when there wasn't a correct row-has-child-toggled
1134 implementation yet),
1135 (gtk_tree_model_sort_real_unref_node): only get the child iter
1136 when we will actually also use it.
1138 2005-10-22 Michael Natterer <mitch@imendio.com>
1140 * gtk/gtktreeview.c (gtk_tree_view_scroll_to_cell): check for the
1141 widget being realized, in addition to being visible, to avoid
1142 running into precondition check in gtk_tree_view_get_cell_area().
1145 2005-10-22 Dom Lachowicz <cinamod@hotmail.com>
1147 * modules/engines/ms-windows/msw_style.c (setup_msw_rc_style):
1148 Experimentally, scrollbar steppers can shrink to 8 pixels on
1149 Win32. Reflect that in the theme.
1150 * modules/engines/ms-windows/Theme/gtk-2.0/gtkrc: Experimentally,
1151 there is a 1-pixel border between a scrollbar and its child
1152 in ScrolledWindows on Win32. Reflect that in the theme.
1154 2005-10-20 Matthias Clasen <mclasen@redhat.com>
1156 * gtk/gtklabel.c (gtk_label_create_window): Use GDK_WINDOW_CHILD
1157 for the selection window. (#318806, Alex Larsson)
1159 2005-10-18 Federico Mena Quintero <federico@ximian.com>
1163 * tests/autotestfilechooser.c
1164 (test_button_folder_states_for_action): Test that we have either
1165 $cwd or the explicitly-set folder.
1166 (test_reload_sequence): Likewise.
1168 * gtk/gtkfilechooserdefault.c
1169 (gtk_file_chooser_default_get_current_folder): If our reload_state
1170 is RELOAD_EMPTY, return a GtkFilePath corresponding to $cwd.
1172 2005-10-14 Tor Lillqvist <tml@novell.com>
1174 * gdk/win32/gdkdisplay-win32.c: Remove the clipboard viewer code.
1175 It didn't really do anything useful, and was just confusing and
1176 incomplete. Comments claimed we don't do delayed rendering, but in
1177 fact we do, for images. (The delayed rendering code has other
1178 problems, though, see #168173.) The clipboard viewer code was
1179 probably even buggy (the WM_CHANGECBCHAIN handled didn't propagate
1180 the message when necessary). It was just test code, it said so in
1181 a comment. Add something similar back later if necessary.
1183 (_win32_on_clipboard_change,
1184 _gdk_win32_register_clipboard_notification): Remove.
1186 (gdk_display_supports_selection_notification,
1187 gdk_display_request_selection_notification): Always just return
1188 FALSE. We didn't generate any GDK_OWNER_CHANGE events anywhere.
1190 2005-10-13 Tor Lillqvist <tml@novell.com>
1192 * gdk/win32/gdkevents-win32.c (gdk_event_translate): Don't treat
1193 Alt-Enter specially. It does not have any special meaning and
1194 should be passed on to the application. (#318378, Tim Evans)
1196 2005-10-13 Tor Lillqvist <tml@novell.com>
1198 Set visual depth to 24 for 32 bits-per-pixel devices on
1199 Win32. This allows gdk_drawable_real_draw_pixbuf() to use the
1200 optimized composite_0888() function rather than the slower image
1201 dithering functions to draw pixbufs (#313993, John Ehresman)
1203 * gdk/win32/gdkimage-win32.c (_gdk_win32_new_image): Use
1204 _gdk_windowing_get_bits_for_depth() to initialize
1205 GdkImage::bits_per_pixel.
1206 (_gdk_windowing_get_bits_for_depth): Return 32 bits for depth 24.
1208 * gdk/win32/gdkpixmap-win32.c (gdk_pixmap_new): Use
1209 _gdk_windowing_get_bits_for_depth() to initialize
1210 BITMAPINFOHEADER::biBitCount.
1212 * gdk/win32/gdkvisual-win32.c (_gdk_visual_init): Set
1213 GdkVisual::depth to 24 even if GetDeviceCaps(BITSPIXEL) returns
1216 2005-10-12 Stefan Kost <ensonic@users.sf.net>
1218 * demos/gtk-demo/appwindow.c: (about_cb):
1219 use PACKAGE_VERSION,bump year (#318654)
1221 2005-10-11 Matthias Clasen <mclasen@redhat.com>
1223 * gtk/gtktextbtree.c (_gtk_text_btree_delete): Try to match an off
1224 toggle here with the matching on toggle if it immediately follows.
1225 This is a common case, and handling it here prevents quadratic blowup
1226 in cleanup_line() below. (#317125)
1228 * gtk/gtktextsegment.h:
1229 * gtk/gtktextsegment.c (_gtk_char_segment_new_from_two_strings): Pass
1230 the character counts into this function instead of computing them
1233 2005-10-10 Tommi Komulainen <tommi.komulainen@iki.fi>
1235 * gtk/gtkfilechooser.h (GtkFileChooserError): Add ALREADY_EXISTS error
1237 * gtk/gtkfilechooserdefault.c
1238 (gtk_file_chooser_default_add_shortcut_folder): Return an error code
1239 when the shortcut already exists in the sidebar. (#147521)
1241 2005-10-09 Matthias Clasen <mclasen@redhat.com>
1243 * tests/testcombo.c: Demonstrate how to use custom widgets in
1246 2005-10-07 Federico Mena Quintero <federico@ximian.com>
1250 * tests/autotestfilechooser.c (test_reload_sequence): Ensure that
1251 the the result of gtk_file_chooser_get_folder() is NULL or
1252 non-NULL at the right times. Log the tests.
1253 (test_button_folder_states): New test for the initial states of
1254 the current folder in GtkFileChooserButton.
1255 (main): Test that the number of warnings/errors/critical errors is
1258 * gtk/gtkfilechooser.c (gtk_file_chooser_get_current_folder):
1259 Clarify the documentation on when this can return NULL.
1260 (gtk_file_chooser_get_current_folder_uri): Likewise.
1262 * gtk/gtkfilechooserbutton.c (struct
1263 _GtkFileChooserButtonPrivate): Added a folder_has_been_set flag;
1264 we use it to keep track of whether a folder has been set.
1265 (gtk_file_chooser_button_map): Implement. If no folder has been
1266 loaded before, we at least try to load $cwd here.
1267 (gtk_file_chooser_button_constructor): If the construct-time
1268 dialog already has a folder set, turn on our folder_has_been_set
1270 (dialog_current_folder_changed_cb): Turn on our
1271 folder_has_been_set flag.
1273 2005-10-07 Michael Natterer <mitch@gimp.org>
1275 * gtk/gtkfilechooserdefault.c: remove some explicit #defines of
1276 PROFILE_FILE_CHOOSER because they break compilation after the
1277 removal of <unistd.h>.
1279 2005-10-07 Matthias Clasen <mclasen@redhat.com>
1281 * gtk/gtkfilechooserdefault.c: Properly fix the unistd.h include
1282 by moving it out of the profiling ifdef.
1284 * gtk/gtkfilechooserdefault.c: Remove a redundant (and
1285 unconditional) include of unistd.h (#318211, Kazuki Iwamoto)
1287 * gtk/gtktexttag.c (gtk_text_attributes_ref): Use
1288 g_return_val_if_fail(), not g_return_if_fail(). (#318412,
1291 2005-10-06 Matthias Clasen <mclasen@redhat.com>
1294 * gtk/gtktextbuffer.h:
1295 * gtk/gtktextbuffer.c: Add a readonly has-selection property
1296 with a getter. (#318161, Paolo Borelli)
1298 2005-10-05 Matthias Clasen <mclasen@redhat.com>
1300 * README.in: Start collecting release notes for 2.10.
1302 * gtk/gtkrc.c (gtk_rc_clear_realized_style): Readd the memory
1303 leak fix, since the assertion failures were traced to
1304 an xchat bug. (#314696)
1306 * gtk/gtkstyle.c (gtk_style_detach):
1307 (gtk_style_attach): Documentation improvements.
1308 (gtk_style_detach): Assert that the attach_count is > 0.
1310 2005-10-04 Federico Mena Quintero <federico@ximian.com>
1312 * gtk/gtkfilechooserdefault.c (switch_to_shortcut): Take a
1313 shortcut position, not a ShortcutsIndex, to make the function more
1315 (home_folder_handler): Pass the resolved index to
1316 switch_to_shortcut(), rather than just SHORTCUTS_HOME.
1317 (desktop_folder_handler): Likewise for SHORTCUTS_DESKTOP.
1318 (gtk_file_chooser_default_class_init): Add a "quick-bookmark"
1319 binding signal, and bind it to Alt-1, Alt-2. ..., Alt-0. These
1320 make the respective key switch to the first, second, ..., tenth
1322 (quick_bookmark_handler): Implement.
1324 2005-10-04 Federico Mena Quintero <federico@ximian.com>
1326 * gtk/gtkpathbar.c (get_dir_name): Don't special-case Home and
1327 Desktop; just use their real names on the file system for the
1330 * gtk/gtkfilechooserdefault.c
1331 (gtk_file_chooser_default_class_init): Add a "desktop-folder"
1332 binding signal, and bind it to M-d by default.
1333 (desktop_folder_handler): Implement the default handler.
1334 (home_folder_handler): Use a helper function.
1335 (switch_to_shortcut): New helper function.
1336 (shortcuts_append_home): Don't special-case the name of "Home";
1337 just use the folder name.
1339 2005-10-04 Tor Lillqvist <tml@novell.com>
1341 * gtk/gtkcalendar.c (gtk_calendar_init): Make it compile without
1342 HAVE__NL_TIME_FIRST_WEEKDAY. (#317910, Mathias Hasselmann)
1344 2005-10-04 Matthias Clasen <mclasen@redhat.com>
1346 * gtk/gtkrc.c (gtk_rc_clear_realized_style): Revert the change
1347 from yesterday, since it leads to assertion failures. (#317879,
1350 2005-10-03 Matthias Clasen <mclasen@redhat.com>
1352 * gtk/gtkcalendar.c (gtk_calendar_init): Call
1353 calendar_compute_days() after setting priv->week_start.
1355 2005-10-03 Matthias Clasen <mclasen@redhat.com>
1357 * gtk/gtkrc.c (gtk_rc_clear_realized_style): Unref the style when
1358 removing it from the hash table. (#314696, Benjamin Berg)
1360 2005-10-01 Tor Lillqvist <tml@novell.com>
1362 * gdk/win32/gdkdrawable-win32.c (blit_from_pixmap): In case
1363 BitBlt() fails with ERROR_INVALID_HANDLE, the most probable cause
1364 is that the the desktop isn't visible because the session has been
1365 switched, the screen is locked, or a terminal server session
1366 disconnected, so no error message necessary. (#137796)
1368 It is of course remotely possible that BitBlt() failing with
1369 ERROR_INVALID_HANDLE might also be caused by some other
1370 problem. We could strive for perfection and track whether the
1371 desktop is visible by using WTSRegisterSessionNotification() and
1372 handling WM_WTSESSION_CHANGE. I think that's overdoing it just for
1373 this issue, though. If we would track desktop visibility, we
1374 should then avoid even trying to update the display at all while
1375 the desktop isn't visible.
1377 2005-09-30 Matthias Clasen <mclasen@redhat.com>
1379 * gtk/gtkcalendar.c (gtk_calendar_init): Another attempt
1380 to correct the calculations for the first week day. We may
1381 just have to remove this code if too many locales turn out
1382 to have broken data.
1384 * gtk/gtkimage.c (gtk_image_expose): Don't leak pixbuf in
1385 some cases. (#317611, Tommi Komulainen)
1387 * gtk/gtksocket-x11.c (_gtk_socket_windowing_size_request):
1388 Prevent overflow when storing size hints in an unsigned
1389 short variable. Tracked down by Ray Strode and Søren Sandmann.
1391 2005-09-29 Matthias Clasen <mclasen@redhat.com>
1393 * gtk/gtkbutton.c (gtk_button_set_image): Check arguments. (#317491,
1396 * gtk/gtkpaned.c (gtk_paned_grab_notify): Stop drags when being
1397 grab shadowed. (#317332)
1399 2005-09-29 Tor Lillqvist <tml@novell.com>
1401 * gtk-zip.sh.in: DLLs are always in bin nowadays, no need to test.
1403 2005-09-28 Federico Mena Quintero <federico@ximian.com>
1405 * tests/autotestfilechooser.c (test_reload_sequence): Oops, return
1406 if the unmap test fails.
1407 (test_reload_sequence): Use gtk_widget_show_now() instead of
1408 gtk_widget_show() for the dialog.
1409 Thanks to Tim Janik for noticing these.
1411 2005-09-28 Federico Mena Quintero <federico@ximian.com>
1413 * tests/testcellrenderertext.c: New file with a set of tests for
1414 GtkCellRendererText. The idea is to run a text renderer through
1415 most of its interesting property values to see that it works
1418 * tests/Makefile.am: Added testcellrenderertext.
1420 * gtk/gtkfilechooserdefault.c (load_set_model): Mark the
1421 entry/exit of this function for profiling.
1422 (gtk_file_chooser_default_style_set): Mark the start/end of the
1423 calls to the parent class and the the signal emission for profiling.
1425 2005-09-29 Tor Lillqvist <tml@novell.com>
1427 * gtk/gtkmain.c (_gtk_get_localedir): The locale directory is
1428 passed to bindtextdomain() which isn't UTF-8-aware, so convert to
1429 system codepage using g_win32_locale_filename_from_utf8().
1430 (#317457, Kazuki Iwamoto)
1432 2005-09-28 Matthias Clasen <mclasen@redhat.com>
1434 * gtk/gtkselection.c (_gtk_selection_request): Free mult_atoms
1435 here. (#317039, Paolo Borelli)
1438 * gtk/gtktexttag.c (gtk_text_attributes_ref): Return the attributes
1439 to make this function work as boxed copy function. (#317455,
1442 * gtk/gtkclipboard.c (request_image_received_func): Don't unref
1443 NULL. (#316828, Tor Lillqvist)
1445 2005-09-28 Tor Lillqvist <tml@novell.com>
1447 * modules/input/imime.c: Include <config.h>. (#317444, Kazuki
1450 2005-09-27 Federico Mena Quintero <federico@ximian.com>
1452 Don't reload the current folder unnecessarily on ::map().
1454 * gtk/gtkfilechooserprivate.h (ReloadState): New enum to represent
1455 the reloading state.
1456 (struct _GtkFileChooserDefault): Added a "reload_state" field.
1458 * gtk/gtkfilechooserdefault.c (gtk_file_chooser_default_init):
1459 Initialize impl->reload_state.
1460 (gtk_file_chooser_default_map): Check the impl->reload_state; load
1461 a default folder if no folder has been set, or reload the current
1462 one only if we had been unmapped first.
1463 (gtk_file_chooser_default_update_current_folder): Set the
1464 reload_state to RELOAD_HAS_FOLDER.
1465 (gtk_file_chooser_default_unmap): Implement, and set the
1466 reload_state to RELOAD_WAS_UNMAPPED.
1467 (shortcuts_model_create): Don't call shortcuts_add_bookmarks()
1468 here; they'll get (re)loaded on ::map() anyway.
1470 * gtk/gtkfilechooserwidget.c
1471 (gtk_file_chooser_widget_constructor): Don't set a default folder here.
1473 * tests/autotestfilechooser.c (test_action_widgets): Don't take in
1474 a dialog; build it ourselves.
1475 (test_reload): New test to ensure that we don't load the default
1476 folder more than once, and that we reload it when
1477 unmapping/remapping.
1478 (get_impl_from_dialog): New utility function.
1479 (test_widgets_for_current_action): Use get_impl_from_dialog().
1481 2005-09-27 Federico Mena Quintero <federico@ximian.com>
1483 * gtk/gtkfilechooserdefault.c
1484 (gtk_file_chooser_default_constructor): Mark the entry/exit of
1485 this function for profiling.
1486 (check_icon_theme): Likewise.
1487 (change_icon_theme): Likewise.
1488 (settings_notify_cb): Likewise.
1489 (gtk_file_chooser_default_screen_changed): Likewise.
1490 (update_chooser_entry): If the selection is empty, clear the file
1491 name entry only if we are in CREATE_FOLDER mode. In SAVE mode,
1492 nothing will be selected when the user starts typeahead in the
1493 treeview, and we don't want to clear the file name entry in that
1494 case --- the user could be typing-ahead to look for a folder name.
1495 Fixes bug #308332, patch by Jürg Billeter.
1497 2005-09-27 Matthias Clasen <mclasen@redhat.com>
1499 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
1500 Pop below the entry if there's more free space below the entry
1501 than above. (#316948, Tommi Komulainen)
1503 2005-09-26 Federico Mena Quintero <federico@ximian.com>
1505 Do not create the save mode-specific widgets in the open modes, so
1506 that we don't carry their baggage around.
1508 * gtk/gtkfilechooserdefault.c
1509 (gtk_file_chooser_default_constructor): Don't create the
1511 (save_widgets_create): Set the impl->save_widgets directly here,
1512 instead of passing the widgets back to the caller. Also, pack
1513 them into the impl's box.
1514 (update_appearance): Create or destroy the save widgets as
1515 appropriate. Set the action of the save_file_name_entry here.
1516 (shortcuts_add_current_folder): Set the active item in the
1517 save_folder_combo only if it exists.
1518 (gtk_file_chooser_default_set_property): Don't set the action of
1519 the save_file_name_entry here.
1520 (gtk_file_chooser_default_update_current_folder): Set the base
1521 folder of the save_file_name_entry only if the entry exists.
1522 (shortcuts_drag_data_received_cb): Cast the selection_data->data
1523 to (const char *) since that's what shortcuts_drop_uris() expects.
1524 (file_list_drag_data_received_cb): Likewise, for
1525 g_uri_list_extract_uris().
1527 2005-09-26 Tor Lillqvist <tml@novell.com>
1529 * gdk/win32/gdkwindow-win32.c (gdk_window_shape_combine_mask): Set
1530 the shaped flag here, too. (#316871)
1531 (gdk_window_shape_combine_region): Currently unimplemented, so
1532 don't do anything to the shaped flag here.
1534 2005-09-26 Matthias Clasen <mclasen@redhat.com>
1536 Fix #316871, reported by Dan Winship:
1538 * gdk/gdkwindow.h (struct _GdkWindowObject): Add a shaped flag.
1540 * gdk/x11/gdkwindow-x11.c (gdk_window_shape_combine_mask)
1541 (gdk_window_shape_combine_region): Set it here.
1543 * gdk/gdkwindow.c (gdk_window_invalidate_maybe_recurse): Don't
1544 remove the child area for shaped windows.
1546 2005-09-23 Matthias Clasen <mclasen@redhat.com>
1548 * gtk/gtkcellrendererpixbuf.c (gtk_cell_renderer_pixbuf_finalize):
1549 Don't leak expander pixbufs. (#316946, Tommi Komulainen)
1551 2005-09-22 Michael Natterer <mitch@imendio.com>
1553 Renamed GtkCellRendererKeys to GtkCellRendererAccel to be
1554 consistent with GTK+ terminology:
1556 * gtk/gtkcellrendererkeys.[ch]
1557 * tests/testkeys.c: removed...
1559 * gtk/gtkcellrendereraccel.[ch]
1560 * tests/testaccel.c: ...and added.
1565 * tests/Makefile.am: changed accordingly.
1567 2005-09-22 Matthias Clasen <mclasen@redhat.com>
1569 * gtk/gtkwidget.c (gtk_widget_class_init): Fix the documentation
1570 for the grab-broken-event signal, noticed by Damon Chaplin.
1572 2005-09-21 Tor Lillqvist <tml@novell.com>
1574 * gdk/win32/gdkselection-win32.c (gdk_selection_convert,
1575 gdk_text_property_to_text_list_for_display,
1576 gdk_text_property_to_utf8_list_for_display,
1577 gdk_win32_selection_add_targets,
1578 _gdk_win32_selection_convert_to_dib): Free return value from
1580 (gdk_text_property_to_text_list_for_display): Drop GError variable
1581 that isn't actually used after being set.
1583 2005-09-20 Johan Dahlin <jdahlin@async.com.br>
1585 * gtk/gtkentry.c (gtk_entry_set_completion): Mention NULL in
1588 2005-09-20 Tor Lillqvist <tml@novell.com>
1590 * gdk/win32/gdkselection-win32.c
1591 (gdk_selection_owner_get_for_display): Do return the correct owner
1592 for CLIPBOARD (i.e., the owner of the Windows Clipboard, if it is
1593 a window GDK knows about). The reason to return NULL seems to have
1594 gone when in the fix for bug #163702 the artificial
1595 GDK_SELECTION_CLEAR event generation was removed from
1596 gdk_selection_send_notify_for_display(). Fixes bug #316552.
1598 2005-09-20 Matthias Clasen <mclasen@redhat.com>
1600 Avoid unnecessary XkbGetState() calls and XkbStateNotify
1601 events. (#151555, Søren Sandmann)
1603 * gdk/x11/gdkdisplay-x11.c (gdk_display_open): Use
1604 XkbSelectEventDetails() to select XkbStateNotify events
1605 for only the state we care about.
1607 * gdk/x11/gdkprivate-x11.h:
1608 * gdk/x11/gdkkeys-x11.c (_gdk_keymap_state_changed): Pass
1609 the event into the function and update the keymap state from
1610 the state information contained in the event. Adjust all callers.
1612 2005-09-19 Matthias Clasen <mclasen@redhat.com>
1614 * gtk/gtkiconview.c: Use g_list_nth_data() instead of g_list_nth()->data
1615 in multiple places to avoid segfaults if the index is out of range.
1616 (#316422, Guillaume Cottenceau)
1617 (gtk_icon_view_set_drag_dest_item):
1618 (gtk_icon_view_scroll_to_path): Fix a typo in the docs. (#316419,
1619 #316424, Guillaume Cottenceau)
1621 2005-09-18 Hans Breuer <hans@breuer.org>
1623 * gtk/gtktrayicon-win32.c : now handling events by hard-coded
1624 g_signal_emit_by_name() - will break when gtkstatusicon.c changes.
1626 2005-09-18 Hans Breuer <hans@breuer.org>
1628 * gdk/gdk.symbols gdk/win32/gdkwin32.h gdk/win32/gdkcursorwin32.c : export
1629 _gdk_win32_pixbuf_to_hicon() as gdk_win32_pixbuf_to_hicon_libgtk_only()
1630 * gtk/gtktrayicon-win32.c : a lot of debug spew but it has started to show
1631 the icon and is blinking with teststatusicon. More to come ...
1633 2005-09-18 Hans Breuer <hans@breuer.org>
1635 * gtk/makefile.msc.in : fix typo for GTK_VER; define HAVE_CONFIG_H
1636 cause gtkprogressbar.c has #include <config.h> conditionally; less
1637 noise from generated gtk.def
1638 * gtk/stock-icons/makefile.msc gdk/makefile.msc tests/makefile.msc : updated
1640 * gtk/gtktrayicon-win32.c : dummy implmentation to make gtk compile.
1641 For me it works as well as the *NIX implemenation, that is not at all.
1643 * gdk/win32/gdkproperty-win32.c : implement gdk_atom_intern_static_string()
1645 * gdk/win32/gdkwindow-win32.c(gdk_window_set_urgency_hint) : only use
1646 only use (WINVER >= 0x0500) when available from the SDK. Otherwise fall
1647 back to true dynamic linking of FlashWindowEx. Makes gtk+ work on NT4.0
1648 again - if compiled properly.
1650 * tests/teststatusicon.c : don't use GNOME icons for testing, but icons
1651 already coming with Gtk+. Makes it compile on win32.
1653 2005-09-18 Guilherme de S. Pastore <gpastore@cvs.gnome.org>
1655 * README.cvs-commits: fixed some tiny typos
1657 2005-09-16 Tor Lillqvist <tml@novell.com>
1659 * modules/engines/ms-windows/msw_style.c (draw_extension,
1660 draw_box_gap): Check whether the widget actually is a GtkNotebook
1661 before treating it as such. Drop some unneeded local variables,
1662 use parameter with same information instead. (#316412)
1664 2005-09-15 Federico Mena Quintero <federico@ximian.com>
1666 * tests/autotestfilechooser.c: Start a set of automated tests for
1667 the file chooser. The only test in there right now doesn't pass
1668 yet. It specifies the intended behavior of the first optimization
1669 of a series which I'll do on the file chooser (see
1670 http://primates.ximian.com/~federico/news-2005-09.html#14 for the
1671 details of this optimization).
1673 * tests/Makefile.am: Added autotestfilechooser.c.
1675 * gtk/gtkfilechooserprivate.h (struct
1676 _GtkFileChooserDialogPrivate): Move all the file chooser's private
1677 structures to here, so that they can be accessed by
1678 tests/autotestfilechooser.c: _GtkFileChooserDialogPrivate,
1679 _GtkFileChooserWidgetPrivate, LoadState, _GtkFileChooserDefault.
1681 * gtk/gtkfilechooserdialog.c: See above.
1683 * gtk/gtkfilechooserwidget.c: See above.
1685 * gtk/gtkfilechooserdefault.c: See above.
1687 Thu Sep 15 15:27:55 2005 Tim Janik <timj@imendio.com>
1690 gtk_window_map_event(): new function to work around lost unmap requests.
1693 2005-09-14 Federico Mena Quintero <federico@ximian.com>
1695 * gtk/gtkfilechooserdefault.c (gtk_file_chooser_default_init): Add
1696 an easy-to-find profiling marker when starting to create a file
1698 (browse_files_model_finished_loading_cb): Likewise, for when the
1699 chooser is finished loading.
1701 2005-09-14 Tristan Van Berkom <tvb@cvs.gnome.org>
1703 * gtk/gtkcolorbutton.c: Check "color" argument in
1704 gtk_color_button_set_color ()
1706 2005-09-14 Matthias Clasen <mclasen@redhat.com>
1708 * gtk/gtklabel.c (gtk_label_get_type):
1709 * gtk/gtkbutton.c (gtk_button_get_type):
1710 * gtk/gtkwindow.c (gtk_window_group_get_type): No point in
1711 using a mem chunk for window groups, buttons, labels.
1713 * gtk/updateiconcache.c (foreach_remove_func): Fix
1714 a use-after-free bug. (#316256, Alexander Nedotsukov)
1716 2005-09-13 Matthias Clasen <mclasen@redhat.com>
1718 * gtk/*.c: Various cleanups. (#315360, Kjartan Maraas)
1720 * gdk/*.c: Various cleanups. (#315359, Kjartan Maraas)
1722 2005-09-13 Matthias Clasen <mclasen@redhat.com>
1724 * gtk/gtkimcontextsimple.c (gtk_im_context_simple_filter_keypress):
1725 Let GDK_Return pass through in some more cases.
1727 * gtk/gtkentry.c (gtk_entry_key_press): Reset the im context before
1728 activating the entry.
1730 * gtk/gtkiconview.c (gtk_icon_view_class_init):
1731 (gtk_icon_view_get_dest_item_at_pos): Fix typos in the
1732 docs. (#316008, #316027, #316121, Guillaume Cottenceau)
1734 * gtk/gtkfilechooser.c (gtk_file_chooser_class_init): Add some docs.
1735 (#316001, Guillaume Cottenceau)
1737 * gtk/gtkdnd.c (gtk_drag_set_icon_name): Fix a copy-and-paste
1738 mistake in the docs. (#315993, Guillaume Cottenceau)
1740 * tests/testentrycompletion.c (create_simple_completion_model): Add
1741 some strings containing multibyte characters.
1743 * gtk/gtkentrycompletion.c (gtk_entry_completion_real_insert_prefix):
1744 Fix prefix insertion for multibyte characters. (#316095,
1747 * gtk/gtktreeview.c (gtk_tree_view_create_row_drag_icon):
1748 * gtk/gtkiconview.c (gtk_icon_view_create_drag_icon): Silently
1749 return NULL if the widget is not realized. (#316023,
1750 Guillaume Cottenceau)
1752 2005-09-11 Matthias Clasen <mclasen@redhat.com>
1755 * gdk/gdkproperty.h:
1756 * gdk/x11/gdkproperty-x11.c (gdk_atom_intern_static_string):
1757 New function to avoid pointless strdups when creating atoms
1758 from static strings.
1761 * gtk/*.c: Use gdk_atom_intern_static_string() where
1764 2005-09-09 Matthias Clasen <mclasen@redhat.com>
1766 * gtk/gtkcellrendererkeys.h:
1767 * gtk/gtkcellrendererkeys.c: Add a cell renderer for displaying
1768 and editing accelerators, a port of EggCellRendererKeys .
1772 * gtk/Makefile.am: Add the keys cell renderer.
1774 * tests/Makefile.am:
1775 * tests/testkeys.c: Test GtkCellRendererKeys
1777 2005-09-09 Matthias Clasen <mclasen@redhat.com>
1779 Make it possible to determine if a key event is for a
1782 * gdk/x11/gdkprivate-x11.h:
1783 * gdk/x11/gdkkeys-x11.c (_gdk_keymap_key_is_modifier):
1784 New function to determine if a keycode is mapped to a modifier.
1785 (get_xkb): Get the modmap.
1787 * gdk/x11/gdkevents-x11.c (translate_key_event): Set the
1788 is_modifier bit by calling _gdk_keymap_key_is_modifier().
1790 * gdk/gdkevents.h (struct _GdkEventKey): Add an is_modifier
1793 2005-09-09 Matthias Clasen <mclasen@redhat.com>
1795 * gdk/gdkpixbuf-drawable.c (convert_real_slow): Remove an
1796 unused variable, noticed by Kjartan Maraas.
1798 2005-09-09 Matthias Clasen <mclasen@redhat.com>
1800 * gtk/gtktreeviewcolumn.c (gtk_tree_view_column_button_event):
1801 Make drag reordering work properly for columns other than the
1802 first. (#315054, Dan Winship)
1804 * gtk/gtkfontsel.c (gtk_font_selection_set_font_name): Handle
1805 invalid fontnames better. (#136926, Michael R. Walton)
1807 Stop cursor blinking in non-editable regions of a text view.
1808 (#311508, Torbjörn Andersson)
1810 * gtk/gtktextview.c (gtk_text_view_check_cursor_blink):
1811 (cursor_blinks): Take editability into account when deciding
1812 whether the cursor blinks.
1813 (gtk_text_view_button_release_event):
1814 (gtk_text_view_move_cursor_internal): Update cursor blinking here.
1816 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_start_editing):
1817 Use connect_after to connect to the focus_out event. This
1818 ensures that the entry has already stopped blinking by the time
1819 we emit the edited signal. (#315229, Thomas Leonard)
1821 * tests/testgtk.c: Use GDK_MOD1_MASK, not GDK_ALT_MASK.
1823 * gtk/gtkwindow.c (gtk_window_parse_geometry): Don't set
1824 unsigned ints to -1. (#315481, Kjartan Maraas)
1826 * gtk/gtkcalendar.c (gtk_calendar_init): first_weekday is relative
1827 to week_1stday, not to Sunday. Gotta love the ISO 14652 guys...
1828 (#314473, Stanislav Brabec)
1830 2005-09-09 Matthias Clasen <mclasen@redhat.com>
1832 * gtk/gtktreeview.c (gtk_tree_view_get_visible_range): Document
1833 memory handling. (#314975, Torsten Schoenfeld)
1835 * gtk/gtkiconview.c (gtk_icon_view_class_init):
1836 * gtk/gtkfilesel.c (gtk_file_selection_class_init):
1837 * gtk/gtkcombobox.c (gtk_combo_box_class_init):
1838 * gtk/gtklabel.c (gtk_label_class_init):
1839 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_class_init):
1840 Stylistic improvements and clarifications for some blurbs.
1841 (#315520, Clytie Siddall)
1843 2005-09-09 Tor Lillqvist <tml@novell.com>
1845 * gdk/win32/gdkdisplay-win32.c (gdk_display_get_name): Cache the
1846 display name. There is only one GdkDisplay on Win32, and
1847 constructing the display name isn't entirely trivial, so cacheing
1848 is probably worth it. For instance GIMP calls this function a lot.
1849 (gdk_display_open): Call gdk_display_get_name() to prime the
1851 (gdk_display_get_n_screens, gdk_display_get_screen,
1852 gdk_display_get_default_screen): Verify parameter correctness like
1853 the X11 backend does.
1855 * gdk/win32/gdkscreen-win32.c (gdk_screen_make_display_name):
1856 Return a freshly allocated string, as the API specifies. Fixes a
1857 heap corruption problem that caused random errors and crashes in
1860 2005-09-07 Matthias Clasen <mclasen@redhat.com>
1862 * gtk/gtkimcontextsimple.c (gtk_im_context_simple_filter_keypress):
1863 Make C-u commit and restart hex input if we are already in a
1866 2005-09-06 Matthias Clasen <mclasen@redhat.com>
1868 * gdk/x11/gdkkeys-x11.c (update_modmap): Make the modmap reflexive.
1869 (_gdk_keymap_add_virtual_modifiers): Don't add both Alt and Meta
1870 if they are mapped to the same modifier.
1872 * gtk/Makefile.am: Rename gtkstatusicon-x11.c and gtktrayicon.c
1873 to gtkstatusicon.c and gtktrayicon-x11.c
1875 * gtk/gtkaccelgroup.c: Include Super, Hyper and Meta in the
1876 default accel mod mask.
1878 * gtk/gtkaccelgroup.c (gtk_accelerator_parse):
1879 * gtk/gtkaccellabel.c (_gtk_accel_label_class_get_accelerator_label):
1880 Don't use GDK_ALT_MASK.
1882 * gdk/gdktypes.h: No need to introduce GDK_ALT_MASK
1884 2005-09-06 Matthias Clasen <mclasen@redhat.com>
1886 Add support for extra virtual modifiers: (#85780, Owen Taylor)
1888 * tests/testgtk.c (create_key_lookup): Add tests for extra virtual
1891 * gtk/gtkkeyhash.c (_gtk_key_hash_lookup): Try to match both against
1892 Mod2 - Mod5 and against Super, Hyper, Meta.
1894 * gtk/gtkaccellabel.c (_gtk_accel_label_class_get_accelerator_label):
1895 * gtk/gtkaccelgroup.c (gtk_accelerator_parse)
1896 (gtk_accelerator_name): Support Super, Hyper Meta and Mod2 - Mod5.
1898 * gdk/x11/gdkkeys-x11.c (struct _GdkKeymapX11): Add a
1899 modmap to maintain the information which X modifiers map to
1901 (get_xkb): Set up the modmap from the XKB tables.
1902 (update_keymaps): Set up the modmap from the information returned
1903 by XGetModifierMapping in the non-XKB case.
1905 * gdk/x11/gdkprivate-x11.h:
1906 * gdk/x11/gdkkeys-x11.c (_gdk_keymap_add_virtual_modifiers): New
1907 function to set the virtual modifiers in the state.
1909 * gdk/x11/gdkevents-x11.c (translate_key_event): Call
1910 _gdk_keymap_add_virtual_modifiers here.
1912 * gdk/gdktypes.h (GdkModifierType): Add bits for virtual Super,
1913 Hyper and Meta modifiers. Also add GDK_ALT_MASK as an alias
1916 2005-09-05 Matthias Clasen <mclasen@redhat.com>
1918 * gtk/gtkaction.c (connect_proxy): Set the label of a button
1919 if it has no child. (#315253, John Finlay)
1921 2005-09-02 Matthias Clasen <mclasen@redhat.com>
1923 * gtkimcontextsimple.h: Add a modifiers_dropped bit
1925 2005-09-02 Matthias Clasen <mclasen@redhat.com>
1927 * gtk/gtkentry.c (gtk_entry_destroy): Disconnect idle handlers
1928 on destroy to avoid problems when they are called on a destroyed
1929 widget. (#315135, John Cupitt)
1931 * gtk/gtkentry.c (gtk_entry_class_init):
1932 * gtk/gtktextview.c (gtk_text_view_class_init): Add bindings
1933 for Ctrl-Shift-A to unselect all. (#309301, Kathy Fernandes)
1935 * gtk/gtkimcontextsimple.c: Rework the Unicode hex input
1936 code. Now we only steal a single key combination, Ctrl-Shift-U,
1938 A hex Unicode sequence must be started with Ctrl-Shift-U, followed
1939 by a sequence of hex digits entered with Ctrl-Shift still held.
1940 Releasing one of the modifiers or pressing space while the modifiers
1941 are still held commits the character. It is possible to erase
1942 digits using backspace.
1943 As an extension to the above, we also allow to start the sequence
1944 with Ctrl-Shift-U, then release the modifiers before typing any
1945 digits, and enter the digits without modifiers.
1946 (#82011, Owen Taylor)
1948 2005-09-02 Matthias Clasen <mclasen@redhat.com>
1950 * gtk/gtkmain.c (gtk_get_event_widget): If the window is destroyed,
1951 we still need to deliver the destroy event. (#314980, Chris Lahey)
1953 * gtk/gtktextview.c (gtk_text_view_key_press_event): Reset
1954 im context before committing \n or \t.
1956 2005-09-02 Alexander Larsson <alexl@redhat.com>
1958 * gtk/gtkfilechooserdefault.c: (shortcuts_add_volumes),
1959 (shortcuts_activate_volume):
1960 Handle base_path being null in the rest of the cases (#310270)
1962 2005-09-02 Tor Lillqvist <tml@novell.com>
1964 * gdk/win32/gdkevents-win32.c (gdk_event_translate): Keep track of
1965 cursor position also in root window coordinates. Prune out
1966 superfluous WM_MOUSEMOVE events even earlier, based on root window
1967 coordinates. Windows sends WM_MOUSEMOVE messages after a new
1968 window has ben mapped below the cursor even if the mouse doesn't
1969 move. We used to generate GDK_MOTION_NOTIFY in these cases. This
1970 confused at least gtk_menu_motion_notify(). (#314995)
1972 * gtk/gtkintl.h: No need to include config.h here. It caused
1973 warnings about GTK_LOCALEDIR being redefined on Win32 when
1974 compiling files where gtkintl.h is included after gtkprivate.h
1975 (which #undefines and re-#defines GTK_LOCALEDIR on Win32).
1977 * gtk/gtkplug.c: Include config.h.
1979 2005-09-01 Matthias Clasen <mclasen@redhat.com>
1981 * gtk/gtkfilesystemunix.c: Pass statbufs down to
1982 xdg_mime_get_mime_type_for_file() where possible, to avoid
1985 * gtk/gtkaction.c (gtk_action_get_accel_closure): Fix doc
1986 typo. (#314921, Guillaume Cottenceau)
1988 * gdk/*.c: Intern some more strings.
1990 * gtk/*.c: Define an I_() macro and use it instead of the
1991 bulky g_intern_static_string().
1993 2005-08-31 Matthias Clasen <mclasen@redhat.com>
1995 * gtk/gtkbindings.c (binding_signal_new): Intern the signal name
1996 instead of copying it.
1998 * gtk/gtktypeutils.c (gtk_identifier_get_type): Some more string interning.
2000 * gtk/*.c: Also intern static strings passed to
2001 g_object_set_data().
2004 * gtk/Makefile.am: Intern type names in code generated by
2009 * gdk/*.c: Intern type names before registering the type to avoid
2012 * configure.in: Require GLib 2.9.0
2014 2005-08-31 Matthias Clasen <mclasen@redhat.com>
2016 * gtk/gtktoolbar.c: Undeprecate gtk_toolbar_set_icon_size(),
2017 and add icon-size and icon-size-set properties. (#314172)
2019 * gtk/gtkwindow.c (gtk_window_set_transient_for): Inherit window
2020 groups across transient parents. (#312918, Christian Persch)
2022 * gtk/gtktreemodel.c: Some documentation fixes. (#314882,
2023 Guillaume Cottenceau)
2025 * gtk/gtktextiter.c (gtk_text_iter_backward_visible_cursor_positions):
2026 Fix a typo in the docs. (#314878, Guillaume Cottenceau)
2028 2005-08-30 Matthias Clasen <mclasen@redhat.com>
2030 * gtk/gtkentry.c (gtk_entry_class_init): Add key bindings to
2031 make C-/ select all and C-\ unselect all. (#309301,
2034 * gtk/gtkimcontextsimple.c: Change the compose sequence for
2035 soft hyphen to be multi_key-minus-minus-space, and add
2036 compose sequences multi_key-minus-minus-period and
2037 multi_key-minus-minus-minus for en dash and em dash.
2038 (#172653, Christian Lohmaier)
2040 * gtk/gtkentry.c (gtk_entry_draw_frame): Fix some unused
2041 code. (#313946, Christian Persch)
2043 * gtk/gtkuimanager.c (gtk_ui_manager_class_init): Another
2044 fix for the default value of the "ui" property.
2046 2005-08-30 Matthias Clasen <mclasen@redhat.com>
2049 * gtk/gtkselection.h:
2050 * gtk/gtkselection.c: Add functions which look for text, image
2051 or uri targets in an array of atoms. (#314089, Mark Wielaard)
2054 * gtk/gtkselection.h:
2055 * gtk/gtkselection.c (gtk_selection_data_targets_include_uri):
2056 Add a function to check wether targets include uri.
2057 (#314092, Mark Wielaard)
2061 * gtk/gtkwindow.c: Add a deletable property with getter
2062 and setter, to control the close button in the window
2063 frame. (#59718, Havoc Pennington)
2065 2005-08-29 Matthias Clasen <mclasen@redhat.com>
2067 * gtk/gtkrc.key.emacs: Add C-n/C-p/C-f/C-b as alternatives
2068 to the arrow keys for menu navigation. (#162825, Carl Worth)
2070 * gtk/gtkentry.c, gtk/gtktextview.c: More typo fixes
2072 * gtk/gtksocket-x11.c, gtk/gtkstatusicon-x11.c: Fix typos.
2074 * gtk/gtkstatusicon-x11.c (gtk_status_icon_new_from_stock):
2075 * gtk/gtkimage.c (gtk_image_new_from_stock): Don't
2076 refer to nonexisting stock ids.
2078 * gtk/gtktextview.c (popup_targets_received):
2079 * gtk/gtkentry.c (popup_targets_received): Construct
2080 the "Select All" menuitem from stock.
2082 * gtk/stock-icons/stock_select_all_{16,24}.png:
2083 * gtk/stock-icons/Makefile.am:
2084 * gtk/gtkiconfactory.c:
2086 * gtk/gtkstock.c: Add a "Select All" stock item. (#78545,
2089 * gtk/gtktrayicon.c: Add a pointer to the spec.
2091 * gtk/gtkstatusicon-x11.c: Add docs.
2093 * gtk/gtkstatusicon.h: Fix a typo.
2095 Add a cross-platform "tray icon" API, by
2096 porting EggStatusIcon/EggTrayIcon (#105101)
2098 * gtk/gtkstatusicon.h: A GtkStatusIcon is an object which
2099 displays an icon in a notification area.
2101 * gtk/gtkstatusicon-x11.c: GtkStatusIcon implementation for
2102 X11, using GtkTrayIcon.
2104 * gtk/gtktrayicon.h:
2105 * gtk/gtktrayicon.c: An implementation of the freedesktop.org
2106 system tray specification, not public API.
2108 * gtk/gtk.symbols: Add new exported functions.
2110 * gtk/gtk.h: Include gtkstatusicon.h.
2112 * gtk/Makefile.am: Add new files.
2114 * tests/Makefile.am:
2115 * tests/teststatusicon.c: Test for GtkStatusIcon.
2117 2005-08-29 Christopher Aillon <caillon@redhat.com>
2119 * gtk/gtkstock.c: Add builtin GtkStockItems for GTK_STOCK_CONNECT
2120 and GTK_STOCK_DISCONNECT
2122 2005-08-29 Matthias Clasen <mclasen@redhat.com>
2124 * gtk/gtksocket-x11.c (_gtk_socket_windowing_embed_notify):
2125 Use XFixesChangeSaveSet if available. (#314682)
2127 * gtk/gtkmenu.c (gtk_menu_grab_notify): Only cancel if the menu
2128 was active. (#314298, Christian Persch, analysis by Mark McLoughlin)
2130 2005-08-29 Matthias Clasen <mclasen@redhat.com>
2132 * gtk/gtkiconcache.c (_gtk_icon_cache_get_icon): Remove an
2133 accidentally leftover duplicate pixbuf creation. (#314700,
2136 * gtk/gtksettings.c (settings_update_cursor_theme): Don't
2137 leak the cursor theme name. (#314693, Kjartan Maraas)
2139 * gdk/x11/gdkasync.c (_gdk_x11_get_window_child_info): Free
2140 state.children in all cases. (#313862, Kjartan Maraas)
2142 2005-08-28 Matthias Clasen <mclasen@redhat.com>
2144 * po/POTFILES.in, po-properties/POTFILES.in:
2147 2005-08-27 Matthias Clasen <mclasen@redhat.com>
2149 * gtk/gtkuimanager.c (gtk_ui_manager_class_init): Fix the default
2150 value of the ui property. (#314532, Yong Wang)
2152 * gdk/x11/gdkproperty-x11.c (gdk_property_get): Don't warn
2153 when G_MAXLONG is passed as length.
2155 2005-08-26 Matthias Clasen <mclasen@redhat.com>
2157 * gtk/updateiconcache.c: Add a separate --ignore-theme-index option
2158 to avoid overloading --force. (JP Rosevaar)
2160 2005-08-26 Matthias Clasen <mclasen@redhat.com>
2162 * configure.in: Bump version to 2.9.0
2166 * gdk/gdkscreen.c: Make the GdkScreen font options api
2167 public, and add properties GdkScreen::font-options and
2168 GdkScreen::resolution. (#314004)
2171 * gtk/gtksettings.c:
2172 * gtk/gtkwidget.c: Adjust all callers.
2174 * gdk/gdkintl.h: Simplify and use glib/gi18n-lib.h.
2175 * gdk/gdkpango.c: Include gdkintl.h, not gtkintl.h.
2176 * gdk/gdkscreen.c: Include gdkintl.h.
2178 * gtk/gtkicontheme.c (theme_lookup_icon): Avoid an uninitialized
2179 variable warning, pointed out by Colin Walters. (#314585)
2181 2005-08-26 Tor Lillqvist <tml@novell.com>
2183 * gtk/gtkfilesystemwin32.c: Remove some ifdeffed out debugging
2185 (gtk_file_system_win32_parse): Don't mishandle UNC paths. (#314519)
2187 2005-08-26 Matthias Clasen <mclasen@redhat.com>
2189 * gtk/gtkcalendar.c (gtk_calendar_init): Fix the calculation
2190 of week_start. (#314473, JP Rosevaar)
2192 2005-08-25 Thomas Fitzsimmons <fitzsim@redhat.com>
2194 * gtk/gtkfilesystemmodel.c (idle_finished_loading_cb): Acquire GDK
2195 lock. (#314533, Thomas Fitzsimmons)
2197 2005-08-25 Matthias Clasen <mclasen@redhat.com>
2199 * gtk/gtktoolbar.c (_gtk_toolbar_elide_underscores): Handle
2200 NULL gracefully. (#314523, Ed Catmur)
2202 2005-08-25 Owen Taylor <otaylor@redhat.com>
2204 * gdk/x11/gdkcursor-x11.c (gdk_x11_display_set_cursor_theme):
2205 Handle theme == NULL.
2207 2005-08-25 Matthias Clasen <mclasen@redhat.com>
2209 * gtk/gtkmenutoolbutton.c (menu_position_func): Take widget
2210 y offset into account when positioning the popup. (#314470,
2213 2005-08-25 Owen Taylor <otaylor@redhat.com>
2215 * gdk/gdkscreen.c (gdk_screen_get_type): Use gdk_screen_init
2216 as instance_init, not base_init! (#314452, Fix from Frederic
2217 Crozat, reported by Joe Marcus Clarke). Trivial cleanup: use -1.
2218 rather than 1 for a negative flag value.
2220 2005-08-24 Owen Taylor <otaylor@redhat.com>
2222 * gdk/gdkpango.c (draw_error_underline): Add a note about
2223 cut-and-paste between here and Pango.
2225 2005-08-24 Matthias Clasen <mclasen@redhat.com>
2227 * === Released 2.8.2 ===
2229 * gtk/gtkclipboard.c (request_image_received_func): Use the correct
2230 callback for image/gif, and also try image/bmp. (#314086, Mark
2233 * gtk/gtkfilesystemunix.c (gtk_file_system_unix_volume_render_icon):
2234 Use gnome-dev-harddisk for volumes, not gnome-fs-blockdev. (#314382,
2239 * gtk/gtksettings.c (gtk_settings_get_for_screen): Make sure font
2240 and cursor settings get propagated down to the screen initially.
2241 Pointed out by Frederic Crozat.
2243 * gtk/gtkicontheme.c (ensure_valid_themes): Don't try to send a client
2244 message if the screen is NULL. Noticed by Kjartan Maraas.
2246 2005-08-24 Matthias Clasen <mclasen@redhat.com>
2250 * === Released 2.8.1 ===
2254 2005-08-24 Matthias Clasen <mclasen@redhat.com>
2256 * gtk/gtktreemodelfilter.c (gtk_tree_model_filter_visible): Protect
2257 against lazy filterers which return values other than TRUE or
2258 FALSE from their visible func. (#314335)
2260 2005-08-23 Owen Taylor <otaylor@redhat.com>
2262 Fix for #314004, reported by Michael Reinsch:
2265 * gdk/gdkscreen.[ch]: Add gdk_screen_get/set_font_options_libgtk_only()
2266 Add gdk_screen_get/set_resolution_libgtk_only()
2268 * gdk/gdkpango.c (gdk_pango_context_get_for_screen): Set
2269 the options for the screen on the newly created context.
2271 * gtk/gtksettings.c (settings_update_font_options/dpi) gtkwidget.c:
2272 Move font options and dpi code from gtkwidget.c to gtksettings.c, set
2273 the font options on the screen.
2275 * gtk/gtkwidget.c (gtk_widget_update_pango_context): Just get
2276 the font options from the screen and set them on the context.
2278 2005-08-23 Kristian Rietveld <kris@gtk.org>
2280 * gtk/gtktreemodelsort.c (gtk_tree_model_sort_row_inserted): don't
2281 bother inserting new rows in a level with a zero refcount and
2282 immediately free the level. (Fixes #312350, reported by Markku Vire).
2284 2005-08-23 Matthias Clasen <mclasen@redhat.com>
2286 * gtk/updateiconcache.c: Complain when there is no index.theme file
2287 in the specified directory, unless --force is used. Also add an
2288 --index-only option to create caches without image data.
2290 * gtk/gtkfilechooserdefault.c (shortcuts_append_desktop): Fix a
2291 C99ism. (#314262, Robert Jeff Mitchell)
2293 2005-08-22 Manish Singh <yosh@gimp.org>
2295 * gtk/gtkicontheme.h: add declaration for _gtk_icon_theme_check_reload.
2297 * gtk/gtkwindow.c: remove declaration of gtk_window_read_rcfiles.
2299 2005-08-22 Matthias Clasen <mclasen@redhat.com>
2301 * gtk/gtkwindow.c (gtk_window_client_event):
2302 * gtk/gtkicontheme.c (ensure_valid_themes)
2303 (_gtk_icon_theme_check_reload): Implement a clientmessage based
2304 scheme for makeing sure that all GTK+ applications notice if an
2305 icon theme has been updated. This should prevent multiple versions
2306 of an icon theme cache to be mapped in memory at the same time,
2307 which can cause excessive memory consumption. (#313156, Chris
2310 2005-08-22 Matthias Clasen <mclasen@redhat.com>
2312 * gtk/gtkicontheme.c (gtk_icon_theme_load_icon): Add a note
2313 regarding icon theme changes.
2315 * gtk/gtkiconcache.c (_gtk_icon_cache_get_icon): When returning
2316 pixbufs which are backed by the mmapped memory of an icon cache,
2317 increase the refcount of the icon cache, so that the memory is not
2318 munmapped away underneath the pixbuf upon icon theme changes.
2319 (#314170, Kjartan Maraas)
2321 * docs/tools/Makefile.am (LDADDS): Add GTK_DEP_LIBS, in order
2322 to link against Xext. (#314062)
2324 * gtk/gtkhsv.c (paint_triangle): One more fix to prevent buffer
2325 overruns. (#314081, Hans Breuer)
2327 2005-08-20 Matthias Clasen <mclasen@redhat.com>
2329 * gtk/gtkentry.c (gtk_entry_get_layout): Clarify that the
2330 returned layout must not be modified.
2332 Sat Aug 20 16:12:14 2005 Jonathan Blandford <jrb@redhat.com>
2334 * gtk/gtktreeview.c (gtk_tree_view_set_model): clear
2335 scroll_to_path if the model changes.
2337 * gtk/gtkiconview.c: (gtk_icon_view_destroy),
2338 (gtk_icon_view_size_allocate), (gtk_icon_view_set_cursor),
2339 (gtk_icon_view_scroll_to_path): Handle scrolling to a path before
2340 we're realized, #312798
2341 (gtk_icon_view_set_model): clear scroll_to_path if the model
2344 2005-08-20 Matthias Clasen <mclasen@redhat.com>
2346 * gtk/gtkrange.c (gtk_range_adjustment_changed)
2347 (gtk_range_adjustment_value_changed): Don't queue a draw
2348 if the layout has not changed. (#313991, Benjamin Berg)
2350 2005-08-19 Matthias Clasen <mclasen@redhat.com>
2352 * gtk/gtktreeitem.c: Remove duplicate lines. (#313344,
2355 * modules/engines/ms-windows/msw_style.c (setup_system_styles):
2358 * gtk/gtkfilechooserbutton.c (change_icon_theme)
2359 (model_add_special, model_add_special, model_add_volumes):
2360 Handle pixbuf being NULL without warnings. Also, don't
2361 leak pixbuf references when the icon theme is changed.
2363 * gtk/gtkmain.c (gtk_get_event_widget): Don't access
2364 the user data on destroyed windows, since at best
2365 it can be a stale pointer. (#313953, Robin Green)
2367 2005-08-19 Matthias Clasen <mclasen@redhat.com>
2369 * gtk/gtkhsv.c (paint_triangle): Avoid a buffer overrun.
2370 (#313900, Sebastien Bacher)
2372 * gtk/gtktreeview.c (gtk_tree_view_get_visible_range): Return
2373 FALSE if the tree is empty. (#313891, Guillaume Cottenceau)
2375 * gdk/x11/gdkdnd-x11.c (_gdk_drag_get_protocol_for_display)
2376 (xdnd_read_actions, get_client_window_at_coords_recurse):
2377 Free data returned from XGetWindowProperty.
2379 * gdk/x11/gdkevents-x11.c (fetch_net_wm_check_window)
2380 Free data returned from XGetWindowProperty. (313867, Kjartan
2383 * gdk/x11/gdkdnd-x11.c (get_client_window_at_coords_recurse): Free
2384 children in all cases. (#313862, Kjartan Maraas)
2386 * gtk/gtkicontheme.c (theme_lookup_icon): Store GtkIconData structs
2387 in the per-directory hash, even if they come from the icon cache.
2388 We tried to avoid that before, but as a result leaked icon data
2389 structs. (#313852, Kjartan Maraas)
2391 2005-08-18 Matthias Clasen <mclasen@redhat.com>
2393 * gtk/gtkmenutoolbutton.c (gtk_menu_tool_button_destroy): Disconnect
2394 signal handlers on destroy, not on finalize. (#313759, Brett Atoms)
2396 2005-08-15 Owen Taylor <otaylor@redhat.com>
2398 * configure.in: Add -lXext to GDK_EXTRA_LIBS in absence of pkg-config
2399 files for x11/xext. (Jonas Bonn)
2401 2005-08-15 Tor Lillqvist <tml@novell.com>
2403 * gtk/gtkicontheme.c (theme_lookup_icon): Put debugging printout
2406 2005-08-15 Owen Taylor <otaylor@redhat.com>
2408 * configure.in: Fix have_base_pc / have_base_x_pc typo.
2410 * gdk/x11/gdkdrawable-x11.c gtk/gtksettings.c: Remove panoxft.h includes.
2411 (#313417, James Andrewartha)
2413 * configure.in: Add fontconfig to X_PACKAGES, since we use it for
2414 FcNameConstant(). (More of #313417)
2416 2005-08-15 Matthias Clasen <mclasen@redhat.com>
2418 * gtk/gtkfilechooserdefault.c: When using gtk_dialog_run() for
2419 modal dialogs, make sure to inherit the window group from
2420 the parent, since we don't inherit window groups across
2421 transient parents currently. (#312918, Christian Persch)
2423 * gtk/gtkmessagedialog.c (gtk_message_dialog_new):
2424 * gtk/gtkdialog.c (gtk_dialog_run): Slight update to the docs.
2426 * gtk/gtkiconview.c (gtk_icon_view_select_path)
2427 (gtk_icon_view_scroll_to_path): Handle paths of depth 0
2428 gracefully. (#312796, Jonathan Blandford)
2430 * tests/testtoolbar.c: Add some more tests for menu placement.
2432 * gtk/gtkmenutoolbutton.c (menu_position_func):
2433 * gtk/gtktoolbar.c (menu_position_func): Improve positioning
2434 of toolbutton menus and of the overflow menu. (#312937,
2435 #153870, Christian Persch, Paolo Borelli)
2437 2005-08-15 Tor Lillqvist <tml@novell.com>
2439 * gtk/updateiconcache.c: Use g_path_get_dirname() instead of
2440 the nonportable <libgen.h> and dirname().
2442 2005-08-15 Matthias Clasen <mclasen@redhat.com>
2444 * gtk/gtksizegroup.c: Use object data to mark widgets and
2445 groups as visited, so that we avoid constant extra list
2446 traversals. Also allocate quarks in class_init. (#311618,
2449 * gtk/gtkicontheme.c (gtk_icon_theme_lookup_icon): Correct the
2450 download location for the hicolor icon theme. (#313475, Olexiy
2453 * gtk/gtkicontheme.c: Remove debug spew.
2455 2005-08-15 Owen Taylor <otaylor@redhat.com>
2457 * gdk/linux-fb/gdkwindow-fb.c (gdk_window_set_back_pixmap):
2458 * gdk/win32/gdkwindow-win32.c (gdk_window_set_back_pixmap):
2459 * gdk/x11/gdkwindow-x11.c (gdk_window_set_back_pixmap):
2460 Handle pixmap == NULL when checking for a colormap.
2463 2005-08-14 Matthias Clasen <mclasen@redhat.com>
2465 * gtk/updateiconcache.c: Store only one copy of the pixel data
2466 for symlinked icons. To achieve this, maintain a hashtable
2467 mapping pathnames to pixel data, and share the pixel data for
2468 all symlinks resolving to the same pathname. When writing out
2469 the image data, write out the pixel data only the first time
2470 it is met, and store the offset pointing to the first copy
2471 for use in all later cases.
2472 This reduces the size of the Bluecurve icon cache from 40