1 2004-06-21 Michael Natterer <mitch@gimp.org>
5 * gdk/x11/gdkdrawable-x11.[ch]: made convert_format() utility
6 function public as _gdk_x11_convert_to_format().
8 * gdk/x11/gdkcursor-x11.c (create_cursor_image): premultiply
9 the pixels from the GdkPixbuf when putting them in the
10 Xcursor image. Fixes bug #144350.
12 2004-06-16 Federico Mena Quintero <federico@ximian.com>
14 * gtk/gtkfilesystemmodel.c (do_files_added): When inserting a
15 visible node, free the old path before creating the new one.
18 Tue Jun 15 01:10:32 2004 Matthias Clasen <maclas@gmx.de>
20 * gtk/gtkcombobox.c: Make GtkComboBox work without model.
21 (#144198, Mariano Suárez-Alvarez)
23 Fri Jun 11 22:05:56 2004 Matthias Clasen <maclas@gmx.de>
25 * gtk/gtkfilechooserdefault.c: Don't use
26 contractions like "don't" or "isn't" in error messages.
27 It isn't nice to use them in log entries either...
28 (#137774, Morten Welinder, patch by Alexander Winston)
30 2004-06-11 Federico Mena Quintero <federico@ximian.com>
34 * gtk/gtkfilesystemmodel.c (_gtk_file_system_model_add_editable):
35 Don't ref the editable node.
36 (_gtk_file_system_model_remove_editable): Don't unref the editable node.
37 (_gtk_file_system_model_remove_editable): Ahem, free the node.
39 * gtk/gtkfilechooserdefault.c (struct _GtkFileChooserDefault):
40 Added fields for edited_idle and edited_new_text.
41 (renderer_edited_cb): Queue the
42 creation of the folder in an idle handler.
43 (renderer_editing_canceled_cb): Likewise for the cancellation.
44 (gtk_file_chooser_default_finalize): Free the impl->edited_new_text.
46 Thu Jun 10 22:12:26 2004 Matthias Clasen <maclas@gmx.de>
48 * gtk/gtkmain.c (gtk_parse_args): Typo fix.
50 2004-06-10 Federico Mena Quintero <federico@ximian.com>
52 Fixes #144110, patch by Bastien Nocera <hadess@hadess.net>.
54 * gtk/gtkfilechooser.c (gtk_file_chooser_list_shortcut_folders):
55 Refer to gtk_file_chooser_add_shortcut_folder().
56 (gtk_file_chooser_list_shortcut_folder_uris): Refer to
57 gtk_file_chooser_add_shortcut_folder_uri().
59 Thu Jun 10 00:36:15 2004 Matthias Clasen <maclas@gmx.de>
61 * gtk/gtkcalendar.c (gtk_calendar_main_button): Start
62 the drag before focusing the selected.day.
63 * gtk/gtkcalendar.c (gtk_calendar_state_changed): Stop
64 a beginning drag if the widget becomes insensitive.
66 Thu Jun 10 00:09:06 2004 Matthias Clasen <maclas@gmx.de>
68 * gtk/gtkcalendar.c (gtk_calendar_button_press): Start
69 spinning before calling arrow_action(), so that a signal
70 handler triggered from arrow_action() has a chance to
71 stop the spinning. (#143966, Davyd Madeley)
73 Wed Jun 9 23:11:23 2004 Matthias Clasen <maclas@gmx.de>
75 * gtk/gtkstyle.c (_gtk_style_init_for_settings): Fix a
76 typo. (#144070, Kent Sandvik)
78 Thu Jun 10 00:22:51 2004 Soeren Sandmann <sandmann@daimi.au.dk>
80 * gtk/gtkmenu.c: Revert the "drag select" part of
83 Mon Jun 7 23:07:40 2004 Matthias Clasen <maclas@gmx.de>
85 * gtk/gtkcombobox.c (gtk_combo_box_remeasure): Handle
86 priv->model being NULL. (#143856, Mariano Suárez-Alvarez)
88 2004-06-07 Federico Mena Quintero <federico@ximian.com>
90 * gtk/gtktreeview.c (gtk_tree_view_button_press): Revert the patch
91 from 2003/Sep/12. This kept DnD in tree views within modal
92 dialogs from working, which is especially bad for the file
93 chooser. Fixes #135168.
95 Sun Jun 6 23:57:21 2004 Matthias Clasen <maclas@gmx.de>
97 Make the entry context menu work in editable text cells. The changes
98 are based on a patch by Kristian Rietveld, which implemented an
99 approach outlined by Owen Taylor. (#50075)
101 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_focus_out_event):
102 Ignore focus out if the entry menu is posted.
103 (gtk_cell_renderer_text_populate_popup): Mark the entry menu as
104 posted, and set up a signal handler to clear the flag if the menu
106 (gtk_cell_renderer_text_popup_unmap): Clear the in_entry_menu flag,
107 set up a timeout to stop editing if the focus is lost.
108 (popdown_timeout): Stop editing if the entry doesn't have focus anymore.
109 (gtk_cell_renderer_text_start_editing): Connect to the populate_popup
110 signal on the entry and keep a pointer to the entry.
111 (gtk_cell_renderer_text_editing_done): Disconnect from popuplate_popup,
112 clear the pointer to the entry.
114 Sun Jun 6 23:24:43 2004 Matthias Clasen <maclas@gmx.de>
116 * gtk/gtktexttag.c (gtk_text_tag_class_init): Improve the description
117 of the ::language property. (#143802, Owen Taylor)
119 Sat Jun 5 23:07:30 2004 Matthias Clasen <maclas@gmx.de>
121 * gtk/gtkentrycompletion.c: (gtk_entry_completion_init),
122 (gtk_entry_completion_list_enter_notify),
123 (gtk_entry_completion_list_motion_notify),
124 (_gtk_entry_completion_popup), (_gtk_entry_completion_popdown):
125 * gtk/gtkentryprivate.h: Add an ignore_enter flag and
126 use it as in the menu code to avoid the initial selection if
127 the window pops up under the pointer. (Anders Carlsson)
129 Sat Jun 5 20:05:39 2004 Soeren Sandmann <sandmann@daimi.au.dk>
131 * tests/testmerge.c: Add a checkbox to queue an
132 merge/unmerge. Patch from Matthias Clasen.
134 * gtk/gtktoolbar.c (struct _GtkToolbarPrivate): Add a new flag
136 (rebuild_menu): New function that rebuilds the overflow menu and
137 makes sure it doesn't start or end with a separator.
138 (toolbar_content_new_tool_item)
139 (toolbar_content_remove)
140 (toolbar_content_new_compatibility): Set the rebuild_needed flag
141 (gtk_toolbar_size_allocate): Only show the overflow arrow when we
142 have actually overflown an item with a proxy menu item. Also make
143 sure we rebuild the menu if needed.
145 Fix #125504, #142377, #143463
147 * gtk/gtkseparatortoolitem.c (gtk_separator_tool_item_expose):
148 Obey the "priv->draw" flag. (#143692)
150 2004-06-04 Matthias Clasen <mclasen@redhat.com>
152 * docs/widget_geometry.txt: Add a note about the !CAN_FOCUS
153 quirk in the button size allocation code.
155 * gtk/gtkbutton.c (gtk_button_size_allocate): Give the space
156 requested for drawing the focus indicator to the child in the
157 !CAN_FOCUS case. This should fix issues which the Gimp has with
158 the button allocation changes in 2.4.2.
160 Thu Jun 3 21:17:29 2004 Matthias Clasen <maclas@gmx.de>
162 * gtk/gtkentry.c (gtk_entry_completion_timeout): Calculate the
163 length of the entry contents in characters, not in bytes.
165 * gtk/gtkentry.c (paste_received): Don't pop up the completion
166 window on paste, noticed by Anders Carlsson.
168 Thu Jun 3 20:56:19 2004 Matthias Clasen <maclas@gmx.de>
170 * gtk/gtkcombobox.c (gtk_combo_box_class_init): Fix the allowed
171 values and default value for the ::active property. (#143669,
174 2004-06-03 Michael Natterer <mitch@gimp.org>
176 * gtk/gtkimagemenuitem.c: use gtk_widget_get_child_requisition()
177 instead of accessing item->image->allocation.width/height
178 directly. Makes widgets which only have a requisition set using
179 gtk_widget_set_size_request() work and fixes bug #142789.
181 Thu Jun 3 08:07:59 2004 Soeren Sandmann <sandmann@daimi.au.dk>
183 * gtk/gtkmenu.c: Revert previous commit. It caused the problem
184 of sticky right click menus to return.
186 Wed Jun 2 01:56:02 2004 Soeren Sandmann <sandmann@daimi.au.dk>
188 * gtk/gtkmenu.c: Fix the stay up algorithm for combo boxes to
189 better handle the "click" case. bug Better fix for #141169.
191 2004-06-02 Federico Mena Quintero <federico@ximian.com>
193 * gtk/gtktreeview.c (gtk_tree_view_search_init): Bail out if the
194 model is empty. Fixes #143536.
196 2004-06-02 Matthias Clasen <mclasen@redhat.com>
198 * gtk/gtkfontsel.c (gtk_font_selection_size_focus_out): Don't
199 close the dialog on focus out of the size entry. (#143505,
202 2004-06-02 Federico Mena Quintero <federico@ximian.com>
206 * gtk/fnmatch.c (_gtk_fnmatch): Take a no_leading_period argument.
207 (gtk_fnmatch_intern): Likewise; also implement this option.
209 * gtk/gtkprivate.h (_gtk_fnmatch): Updated prototype.
211 * gtk/gtkfilesel.c (find_completion_dir): Pass TRUE for the
212 no_leading_period argument of _gtk_fnmatch().
213 (attempt_file_completion): Likewise.
215 * gtk/gtkfilefilter.c (gtk_file_filter_filter): Pass FALSE for the
216 no_leading_period argument of _gtk_fnmatch().
218 Wed Jun 2 00:47:11 2004 Matthias Clasen <maclas@gmx.de>
220 * gtk/gtkselection.c (_gtk_selection_request): Remove leftover
223 Wed Jun 2 00:13:57 2004 Matthias Clasen <maclas@gmx.de>
225 * gtk/gtktreeselection.c (gtk_tree_selection_select_range): Don't
226 allow unless selection mode is multiple. (#142634, John Finlay)
228 Tue Jun 1 23:00:20 2004 Matthias Clasen <maclas@gmx.de>
232 * gtk/gtkentrycompletion.h:
233 * gtk/gtkentrycompletion.c:
235 * gtk/gtkcombobox.c: Rename function parameters from
236 index to index_ to prevent clash with BSD index(). (#143001)
238 Tue Jun 1 22:45:42 2004 Matthias Clasen <maclas@gmx.de>
240 * gtk/gtkmenu.c (get_accel_path): Handle accel_closure being
241 NULL on an accel label. (#139641, Sam Stephenson, patch by
244 Tue Jun 1 22:19:55 2004 Matthias Clasen <maclas@gmx.de>
246 * gtk/gtkicontheme.c (theme_subdir_load): Prevent icon
247 lookup finding icons in the wrong prefix. (#143328,
250 Wed Jun 2 00:39:58 2004 Soeren Sandmann <sandmann@daimi.au.dk>
254 * gtk/gtkmenushell.c (gtk_menu_shell_button_release): Make menus
255 only stay up if you release within 500 milliseconds.
256 (gtk_menu_shell_button_press): Set the activate_time to the event
257 time when a button is pressed.
259 * gtk/gtkmenu.c (gtk_menu_motion_notify, gtk_menu_enter_notify):
260 Interprete button releases as activate when we have seen both an
261 enter an a motion event.
263 2004-06-01 Federico Mena Quintero <federico@ximian.com>
265 * gtk/gtkfilesystemmodel.c (do_files_removed): Don't insert a
266 dummy node if there is no parent node. Fixes #143362.
268 2004-05-31 Federico Mena Quintero <federico@ximian.com>
270 * gtk/gtkfilechooserdefault.c (renderer_edited_cb): Change to the
271 newly-created folder. Fixes #138932.
272 (trap_activate_cb): Only return TRUE if we did handle the event.
273 Fixes #143359; patch by jylefort@brutele.be.
275 Mon May 31 02:39:32 2004 Matthias Clasen <maclas@gmx.de>
277 * gtk/gtkimage.c (gtk_image_new_from_pixmap): Fix typo in
278 docs. (#142892, Tommi Komulainen)
280 Mon May 31 02:16:37 2004 Matthias Clasen <maclas@gmx.de>
282 * gtk/gtkhandlebox.c: Make detached handleboxes work when their
283 parent is minimized, porting the fix from 1.2. (#1923, #57182)
285 Mon May 31 02:03:17 2004 Matthias Clasen <maclas@gmx.de>
287 * gtk/gtkwindow.c (gtk_window_show): Make moving realized,
288 unmapped windows work.
290 Mon May 31 00:27:33 2004 Matthias Clasen <maclas@gmx.de>
292 * gtk/gtkfilechooserutils.c (_gtk_file_chooser_set_delegate): Fix
295 Mon May 31 00:23:55 2004 Matthias Clasen <maclas@gmx.de>
297 * gtk/gtkfilechooser.c (gtk_file_chooser_set_preview_widget):
298 Refer to ::update-preview, not ::selection-changed.
300 2004-05-29 Christian Rose <menthos@menthos.com>
302 * configure.in: Added "tk" to ALL_LINGUAS.
304 Fri May 28 15:00:01 2004 Matthias Clasen <maclas@gmx.de>
306 * gtk/gtkwidget.c (gtk_widget_set_parent): Add informative
307 messages for common problems. (#137974, Owen Taylor)
309 Fri May 28 14:20:17 2004 Matthias Clasen <maclas@gmx.de>
311 * gdk/x11/gdkevents-x11.c: Fix off-by-one allocation
312 errors. (#143337, Billy Biggs)
314 Thu May 27 16:36:22 2004 Owen Taylor <otaylor@redhat.com>
316 * gdk/x11/gdkcolor-x11.c (gdk_colormap_alloc_colors): Set
317 bits within visual->depth that aren't used for color to
318 1s, in case they are alpha.
320 2004-05-27 Anders Carlsson <andersca@gnome.org>
322 * gtk/gtkfilechooserdefault.c (save_folder_combo_create):
323 Make separator rows insensitive.
325 Thu May 27 00:48:16 2004 Matthias Clasen <maclas@gmx.de>
327 * gtk/gtkentrycompletion.c (gtk_entry_completion_set_text_column):
330 Thu May 27 00:45:07 2004 Matthias Clasen <maclas@gmx.de>
332 * gtk/gtkentrycompletion.h:
333 * gtk/gtkentrycompletion.c (gtk_entry_completion_get_text_column):
334 Getter for text_column. Also make ::text_column a property.
336 Thu May 27 00:11:01 2004 Matthias Clasen <maclas@gmx.de>
338 * gtk/gtkmenuitem.c (gtk_menu_item_size_request): Fix a typo.
340 Thu May 27 00:07:47 2004 Jonathan Blandford <jrb@gnome.org>
342 * gtk/gtkcombobox.c (gtk_combo_box_list_destroy): only remove the
343 signal if the box exists.
345 Wed May 26 23:26:51 2004 Matthias Clasen <maclas@gmx.de>
347 Support insensitive cells in tree views and combo boxes:
349 * gtk/gtkcellrenderer.h:
350 * gtk/gtkcellrenderer.c: Add a ::sensitive property.
352 * gtk/gtkcellrendererpixbuf.c (gtk_cell_renderer_pixbuf_render):
353 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_render):
354 * gtk/gtkcellrenderertoggle.c (gtk_cell_renderer_toggle_render):
355 Support drawing insensitive.
358 * gtk/gtkcellview.c (gtk_cell_view_get_cell_renderers): New
359 function to obtain the cell renderers from a cell view. Also
360 export gtk_cell_view_set_cell_data().
362 * gtk/gtktreeselection.c (tree_column_is_sensitive):
363 * gtk/gtktreeselection.c (row_is_selectable): Helper functions
364 to determine whether all visible cells in a row are insensitive
365 and whether a row is selectable. A row is not selectable if the
366 user function says so or if all visible cells are insensitive.
367 * gtk/gtktreeselection.c (_gtk_tree_selection_internal_select_node):
368 * gtk/gtktreeselection.c (gtk_tree_selection_real_select_node):
369 Use row_is_selectable().
371 * gtk/gtkcombobox.c (row_is_sensitive):
372 * gtk/gtkcombobox.c (tree_column_row_is_sensitive):
373 * gtk/gtkcombobox.c (menu_row_is_sensitive): Helper functions
374 to determine row sensitivity in menu or list mode.
376 * gtk/gtkcombobox.c (update_menu_sensitivity): Helper function
377 to set up sensitivity menu items from the underlying rows.
379 * gtk/gtkcombobox.c (gtk_combo_box_popup):
380 * gtk/gtkcombobox.c (gtk_combo_box_menu_button_press): Use
381 update_menu_sensitivity().
383 * gtk/gtkcombobox.c (gtk_combo_box_list_setup): Setup the cell
386 * gtk/gtkcombobox.c (gtk_combo_box_key_press): Skip insensitive
389 * tests/testcombo.c (main): Make some rows insensitive.
391 2004-05-26 Robert Ögren <gtk@roboros.com>
393 * gdk/win32/gdkinput-win32.c (_gdk_input_other_event): Send key
394 modifiers (shift, ctrl etc) in button and motion events from the
397 2004-05-26 Robert Ögren <gtk@roboros.com>
399 * gdk/win32/gdkinput-win32.c (gdk_device_get_state): Simple
400 implementation for extended input devices using last known
401 device state (#143237)
403 Tue May 25 21:54:00 2004 Matthias Clasen <maclas@gmx.de>
405 * gtk/gtkframe.c: Move docs inline, fixing them on the
406 way. (#143029, Steve Chaplin)
408 2004-05-11 Robert Ögren <gtk@roboros.com>
410 * gdk/win32/gdkevents-win32.c (propagate): Don't propagate mouse
411 events to windows that want extended input events. (#142943)
412 (gdk_event_translate): Move check for extended input devices to
413 propagate, new parameter to propagate.
414 (gdk_pointer_grab, gdk_display_pointer_ungrab): Enable calls to
415 _gdk_input_(un)grab_pointer. (#142943)
417 * gdk/win32/gdkinput-win32.c (_gdk_input_other_event): Check for
418 input grab. [Fix missing update of impl in "dijkstra" event
419 propagation loop] Drop the parallel "impl" pointer, just use a
420 cast. Don't propagate beyond windows that want normal input
422 (gdk_input_grab_pointer, gdk_input_ungrab_pointer): Limited
423 implementation of input grab. (#142943)
425 2004-05-22 Tor Lillqvist <tml@iki.fi>
427 * gdk/win32/gdkinput-win32.c (print_lc): Remove duplicated
428 line. (Spotted by Benoît Carpentier.)
430 2004-05-18 Matthias Clasen <mclasen@redhat.com>
432 * configure.in: Check for XFIXES extension.
434 * gdk/x11/gdkdisplay-x11.h (struct _GdkDisplayX11): Add
435 a gboolean have_xfixes member.
437 * gdk/x11/gdkdisplay-x11.c (gdk_display_open): Register
438 XFIXES events and set have_xfixes.
440 * gdk/gdkevents.h (GdkEventType): Add GDK_OWNER_CHANGE.
441 (GdkEventOwnerChange): New event struct for owner change events.
442 (GdkOwnerChange): New enum for the reason field of GdkEventOwnerChange.
444 * gdk/x11/gdkevents-x11.c (gdk_event_translate): Translate
445 XFixesSelectionNotify events into GdkEventOwnerChange events.
448 * gdk/x11/gdkdisplay-x11.c (gdk_display_supports_selection_notification):
449 (gdk_display_request_selection_notification): New api
450 to support selection ownership notification.
452 * gtk/gtkclipboard.h:
453 * gtk/gtkclipboard.c (_gtk_clipboard_handle_event): New private
454 api to handle owner change events.
455 (clipboard_peek): Refactored out the body of
456 gtk_clipboard_get_for_display() for use in _gtk_clipboard_handle_event().
458 * gtk/gtkmain.c (gtk_main_do_event): Handle GDK_OWNER_CHANGE events
459 by calling _gtk_clipboard_handle_event().
461 2004-05-18 Matthias Clasen <mclasen@redhat.com>
463 * gtk/gtkintl.h: Include glib/gi18n-lib.h and only define
464 the P_() macros ourselves.
466 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
467 Restrict the width of the popup to be no larger than the
468 monitor. (#142678, DmD Ljungmark)
470 * gtk/gtkbutton.c: Go back to the initial fix for the
471 focus-overdrawing problem, which was actually correct
472 according to docs/widget_geometry.txt.
474 * gtk/gtkarrow.c (gtk_arrow_class_init): Bump the initial
475 arrow size from 11 to 15 to compensate for that.
477 * gtk/gtktextview.c (gtk_text_view_class_init): Document the
478 arguments of the ::move-cursor signal. (#142725)
480 2004-05-17 Matthias Clasen <mclasen@redhat.com>
484 * gtk/gtkbutton.c (gtk_button_size_request)
485 (gtk_button_size_allocate, _gtk_button_paint): Allocate
486 space for the focus rectangle only if necessary. (#142668,
489 Sun May 16 23:11:47 2004 Matthias Clasen <maclas@gmx.de>
493 * gtk/gtkhruler.c (gtk_hruler_draw_ticks): Remove two useless
494 lines. (#142479, Morten Welinder)
496 Sun May 16 22:27:17 2004 Matthias Clasen <maclas@gmx.de>
498 * gtk/gtkintl.h (Q_): Add a Q_() macro.
500 * gtk/gtkcellrendererprogress.h: Remove GTK_PROGRESS_CELL_UNKNOWN
501 and GTK_PROGRESS_CELL_FAILED. With the ability the set the label,
502 they are not really needed.
504 * gtk/gtkcellrendererprogress.c: Use the xpad and ypad properties
505 instead of hardwired padding, use Q_() for the default label,
506 compute a reasonable minimal size. (#142571, #142572, #142573,
507 Tommi Komulainen, Christian Persch)
509 2004-05-15 Tor Lillqvist <tml@iki.fi>
511 * gdk/win32/gdkdnd-win32.c: Put back the ref_count field in the
512 GdkDragContextPrivateWin32 struct (but inside ifdef OLE2_DND this
513 time). It is used by the OLE2_DND code, which is unfinished and
514 presumably horribly broken, but still, let's not make it not
515 compile on purpose. Silence some gcc warnings in the OLE2_DND
518 2004-05-14 Matthias Clasen <mclasen@redhat.com>
520 * gtk/gtktreeview.c (gtk_tree_view_tree_window_to_tree_coords):
521 New function to go from tree window to tree coordinates, kept
522 static for now until we figure out the multiple coordinate
523 system mess in GtkTreeView API-wise.
524 (gtk_tree_view_scroll_to_cell): Transform the coordinates
525 from tree window to tree coordinates, using the new function.
526 Previously, the x coordinate was wrongly transformed. (#142494)
528 * gdk/gdktypes.h (GdkModifierType): Add a comment about unused
531 * gtk/gtkstock.c (real_add, gtk_stock_lookup): Use an unused
532 modifier bit to mark stock item which need to be freed
533 eventually. (#140654, Michal Pasternak, Scott Tsai)
535 2004-05-11 Robert Ögren <gtk@roboros.com>
537 * gdk/win32/gdkevents-win32.c (gdk_event_translate): Add missing
538 call to g_object_ref in Wintab code. (#138341)
540 * gdk/win32/gdkinput-win32.c: Fix numerous Wintab problems
541 including unallocated buffers for event->motion.axes and
542 event->button.axes, unsigned wraparound problem in the code for
543 detecting missing press/release events and assigning min instead
544 of max when setting up axes.
546 2004-05-12 Matthias Clasen <mclasen@redhat.com>
548 * tests/testtreeedit.c: Add a progress column.
550 * gtk/Makefile.am: Add gtkcellrendererprogress.[hc] in the right
553 * gtk/gtk.h: Include gtkcellrendererprogress.h.
555 * gtk/gtkcellrendererprogress.[hc]: A progress cell renderer,
556 based on the one found in Epiphany.
558 2004-05-11 Michael Natterer <mitch@gimp.org>
560 * gtk/gtkcombobox.c (gtk_combo_box_popup)
561 (gtk_combo_box_menu_button_press): don't allocate the popup
562 smaller than the combobox. Fixes bug #59660.
564 2004-05-11 Matthias Clasen <mclasen@redhat.com>
566 * gtk/gtkuimanager.c (gtk_ui_manager_get_widget): Revert the
567 previous change to this function, clarify the docs instead.
569 * gtk/gtkcombobox.c (gtk_combo_box_list_setup): Use
570 GTK_SELECTION_BROWSE.
572 * gtk/gtktreeview.c: Make hover selection work for
573 GTK_SELECTION_BROWSE as well.
575 Tue May 11 00:38:25 2004 Matthias Clasen <maclas@gmx.de>
577 * gtk/gtkcellrenderertoggle.c (gtk_cell_renderer_toggle_class_init):
578 Document the ::toggled signal.
580 Mon May 10 23:04:25 2004 Soeren Sandmann <sandmann@daimi.au.dk>
582 * gtk/gtkwidget.h: Add prototype for _gtk_widget_grab_notify()
584 2004-05-10 Matthias Clasen <mclasen@redhat.com>
586 * gtk/gtkwindow.c (get_screen_icon_info): Make static.
588 * gdk/gdkdisplay.c (singlehead_...):
589 * gdk/x11/gdkkeys-x11.c (get_effective_keymap):
590 * gdk/x11/gdkgeometry-x11.c (expose_serial_predicate):
591 * gdk/x11/gdkdisplay-x11.c (escape_for_xmessage): Make static.
593 * gtk/gtktreeview.c (gtk_tree_view_set_fixed_height_mode): Add a
594 note about COLUMN_FIXED restriction.
596 * gtk/gtkentrycompletion.c (gtk_entry_completion_list_button_press):
597 Set the entry in the default handler of the ::match-selected signal.
600 * gtk/gtkcombobox.c (gtk_combo_box_menu_position_below): If we don't
601 do the move-selected-item below pointer thingie, do the
602 place-below-or-above one.
604 * tests/testentrycompletion.c: Make the second example use the
605 ::match-selected signal to make it actually work.
607 * gtk/gtkentrycompletion.c (gtk_entry_completion_init):
608 * gtk/gtkcombobox.c (gtk_combo_box_list_setup): Use hover selection
609 mode. (#127648, Dave Bordoley)
612 * gtk/gtktreeview.c: Add a new property "hover_selection", which
613 when TRUE makes the selection follow the mouse. Also add setter
614 and getter for the fixed_height property.
616 2004-05-10 Matthias Clasen <mclasen@redhat.com>
618 * gtk/gtkcombobox.c (gtk_combo_box_popup)
619 (gtk_combo_box_menu_button_press): Make sure the menu pops up
620 as wide as the combobox. (#59660, Havoc Pennington)
622 2004-05-10 Matthias Clasen <mclasen@redhat.com>
625 * gtk/gtkcombobox.c: Support tearoffable combo boxes (in menu
626 mode). Add a new property, add-tearoffs, for this. (#135956)
628 * gtk/gtkfontsel.c (list_row_activated): Make Return activate the
629 default button. (#118921)
631 Mon May 10 15:03:50 2004 Soeren Sandmann <sandmann@daimi.au.dk>
633 * gtk/gtkwidget.c (_gtk_widget_grab_notify): New internal function
634 that emits the grab notify signal.
636 * gtk/gtkmain.c (gtk_grab_notify_foreach): Use it here.
638 Mon May 10 00:48:08 2004 Matthias Clasen <maclas@gmx.de>
640 * gtk/gtkmenu.c: Make destruction of a torn off menu work
643 Sun May 9 21:05:38 2004 Matthias Clasen <maclas@gmx.de>
647 * gtk/gtkactiongroup.c (gtk_action_group_add_action_with_accel):
648 Allow to suppress the stock accelerator by using "". (#142196,
651 Sun May 9 02:01:13 2004 Matthias Clasen <maclas@gmx.de>
655 * gtk/gtkcombobox.c (gtk_combo_box_list_button_released):
656 In list mode, accept the same mouse/wheel bindings on
657 the cellview as on the button. (#136967)
659 Sun May 9 01:25:37 2004 Matthias Clasen <maclas@gmx.de>
661 * gtk/gtkiconfactory.c (add_to_cache): Actually count the
662 cached icons. (#135888, Crispin Flowerday)
664 Sun May 9 00:03:03 2004 Matthias Clasen <maclas@gmx.de>
666 * gtk/gtkuimanager.c (gtk_ui_manager_get_widget): Make sure
667 that we actually return menus for nodes of type menu, not the
668 menuitems they're attached to.
670 Sat May 8 22:50:55 2004 Matthias Clasen <maclas@gmx.de>
672 * gtk/gtkactiongroup.c (gtk_action_group_set_translation_domain):
673 Add a note regarding UTF-8 requirements, proposed by
674 Mariano Suárez-Alvarez.
676 Sat May 8 22:43:11 2004 Matthias Clasen <maclas@gmx.de>
678 * gtk/gtktearoffmenuitem.h:
679 * gtk/gtktearoffmenuitem.c: Put the torn_off flag back
680 into the GtkTearoffMenuItem struct, since it is used
681 by the Gimp, and keep it synchronized with the
682 tearoff_state property of the parent menu.
684 2004-05-08 Hans Breuer <hans@breuer.org>
686 * gtk/gtkfilesystemwin32.c (extract_icon) : finally also
687 create the correct mask for 'pseudo mime' icons
689 * gdk/win32/gdkwindow-win32.c(show_window_internal) : also
690 take focus_on_map into account
692 * gtk/gtkselection.c : g_message() only with DEBUG_SELECTION
694 * gtk/gtkactiongroup.c gtk/gtkcombobox.c :
695 ... must return a value
697 * gdk/gdk.def gtk/gtk.def demos/gtk-demo/makefile.msc.in : updated
699 2004-05-07 Matthias Clasen <mclasen@redhat.com>
701 * gtk/gtkbutton.c (gtk_button_size_allocate): Don't let the child
702 draw over the focus rectangle.
704 * gtk/gtkhsv.c: Draw focus indication in the color wheel using
705 standard focus style. (#63071, Bill Haneman, idea for new
706 style by Owen Taylor)
708 * gtk/gtkstyle.c (gtk_default_draw_focus): Support drawing on
709 focus on the colorwheel via details.
711 2004-05-06 Matthias Clasen <mclasen@redhat.com>
715 * gtk/gtkcombobox.c (gtk_combo_box_menu_state_changed): Remove
716 this no longer needed signal handler. (#141817, Paul Pogonyshev)
718 Fri May 7 00:41:46 2004 Matthias Clasen <maclas@gmx.de>
720 * gtk/gtktearoffmenuitem.h:
721 * gtk/gtktearoffmenuitem.c: Make the tearoff
722 functionality model/view, the tearoffmenuitem being
723 the view and the tearoff_state property of the menu
724 being the model. (#101185, Owen Taylor)
726 * gtk/gtkmenu.c: Add a tearoff_state property.
728 Thu May 6 23:52:13 2004 Matthias Clasen <maclas@gmx.de>
732 * gtk/gtkmenuitem.c (gtk_menu_item_select_timeout): Also
733 popup the submenu for items in torn off menus. (#122051)
735 2004-05-06 Sven Neumann <sven@gimp.org>
737 * gtk/gtkexpander.c (gtk_expander_size_allocate): in RTL mode,
738 position the title lable next to the arrow just as we do for LTR
739 rendering. Fixes bug #141825.
741 2004-05-06 Matthias Clasen <mclasen@redhat.com>
743 * docs/RELEASE-HOWTO: Document the new policy of
744 bumping version numbers after release.
746 * configure.in: Bump version number to 2.5.0.
748 2004-05-06 Padraig O'Briain <padraig.obriain@sun.com>
751 * gtk/gtkmenu.c: Add new function gtk_menu_get_for_attach_widget.
754 Thu May 6 00:24:11 2004 Matthias Clasen <maclas@gmx.de>
756 * gtk/gtkactiongroup.h:
757 * gtk/gtkactiongroup.c (gtk_action_group_translate_string):
758 New function to translate a string with translate_func.
761 Thu May 6 00:02:21 2004 Matthias Clasen <maclas@gmx.de>
763 * gtk/gtkcombobox.c (gtk_combo_box_get_wrap_width):
764 (gtk_combo_box_get_row_span_column):
765 (gtk_combo_box_get_column_span_column): Add missing getters
766 for readwrite properies. (#135649)
768 Wed May 5 23:42:42 2004 Matthias Clasen <maclas@gmx.de>
771 * gtk/gtkcombobox.c (gtk_combo_box_get_active_text):
772 Add gtk_combo_box_get_active_text() convenience
773 function. (#136372, Christian Neumeir, patch by Olivier Andrieu)
775 2004-05-05 Elijah Newren <newren@math.utah.edu>
777 Changes to support do-not-focus-on-map hint in conjunction with
778 _NET_WM_USER_TIME (#115650):
780 * gdk/gdkwindow.h (struct _GdkWindowObject): Add a new boolean
783 * gdk/gdkwindow.h (gdk_window_set_accept_focus): New function to
786 * gtk/gtkwindow.[hc]: Add a boolean property "focus_on_map"
787 and gtk_window_get_focus_on_map() and gtk_window_set_focus_on_map().
789 * gdk/win32/gdkwindow-win32.c (gdk_window_new):
790 * gdk/linux-fb/gdkwindow-fb.c (gdk_window_new):
791 * gdk/x11/gdkwindow-x11.c (gdk_window_new):
792 Initialize the focus_on_map field to TRUE.
794 * gdk/win32/gdkwindow-win32.c (gdk_window_set_focus_on_map):
795 * gdk/linux-fb/gdkwindow-fb.c (gdk_window_set_focus_on_map):
796 * gdk/x11/gdkwindow-x11.c (gdk_window_set_focus_on_map):
797 * gdk/x11/gdkwindow-x11.c (setup_toplevel_window):
798 Implementations for the various backends. The Win32 and linux-fb
799 implementations set the focus_on_map field, but don't use it yet
800 to actually implement noinput windows. The X implementation sets
801 _NET_WM_USER_TIME to 0 if focus_on_map is FALSE (see the EWMH).
803 * gdk/x11/gdkwindow-x11.h:
804 * gdk/x11/gdkevents-x11.c (set_user_time):
805 * gdk/x11/gdkinput-x11.c (_gdk_input_common_other_event):
806 * gdk/x11/gdkwindow-x11.c (gdk_x11_window_set_user_time):
807 s/_gdk_x11_window_set_user_time/gdk_x11_window_set_user_time/,
808 since we want that function to be part of the public API.
810 Wed May 5 22:20:21 2004 Matthias Clasen <maclas@gmx.de>
814 * gtk/gtkiconfactory.c (icon_source_clear): Don't
815 call g_free() on a pixbuf. (#141961, Crispin Flowerday)
817 2004-05-05 Matthias Clasen <mclasen@redhat.com>
821 * gtk/gtkuimanager.c (print_node): Make the output
822 parseable. (#141929, Sven Neumann)
824 2004-05-05 Tor Lillqvist <tml@iki.fi>
826 * gdk/win32/gdkdnd-win32.c (gdk_drag_find_window_for_screen): Add
827 multi-monitor offset. (#141842, John Ehresman)
829 2004-05-04 Federico Mena Quintero <federico@ximian.com>
831 Fixes #139562, based on a patch by Christian Neumair.
833 * gtk/gtkfilechooserdefault.c (struct _GtkFileChooserDefault): Add
834 a filter_combo_hbox field to contain the filter combo.
835 (show_filters): Show/hide the filter_combo_hbox.
836 (create_filename_entry_and_filter_combo): Removed.
837 (file_pane_create): Create the filter_combo_hbox here.
839 2004-05-04 Matthias Clasen <mclasen@redhat.com>
841 * modules/input/gtkimcontextxim.c: Fix the recent
842 string_conversion_callback change to work on
843 Solaris. (#141190, Padraig O'Briain)
845 * gtk/gtkselection.c: Disable debug logging again.
847 2004-05-03 Matthias Clasen <mclasen@redhat.com>
849 * gtk/gtkselection.c: Make the chunk size for
850 incremental transfers depend on the maximal request
851 size, capped at 256k. This should allow most selections
852 to be transferred nonincrementally, avoiding many
853 roundtrips and protocol overhead.
855 2004-05-03 Federico Mena Quintero <federico@ximian.com>
857 * gtk/gtkuimanager.c (gtk_ui_manager_class_init): Call
858 g_signal_new() correctly and initialize the signal fields. Fixes
859 #141749; patch based on Michael Natterer's.
861 u2004-05-03 Matthias Clasen <mclasen@redhat.com>
863 * gtk/gtkselection.c (_gtk_selection_request): Fix
864 a debug message to show correct information.
865 (_gtk_selection_incr_event): Make INCRemental transfer
866 of MULTIPLE targets work. This was broken since 1997!
868 2004-05-02 Hans Breuer <hans@breuer.org>
870 * gdk/win32/gdkdrawable-win32.c (draw_segments) : don't
871 modify the passed in GdkSegment(s) in place, we may get
872 them again to draw at the same place. Fixes bug #129095,
874 (draw_segments) draw the end pixel again to get the
875 pixmap mask right, fixes bug #126710, #130202
877 * gdk/win32/gdkwindow-win32.c : use SetForegroundWindow,
878 fixes bug #106013, John Ehresman
880 * gtk/makefile.msc.in : don't try to link gtk.res but
881 use gtk-win32.res (as supposed to be fixed below :)
883 2004-05-01 Hans Breuer <hans@breuer.org>
885 * tests/Makefile.am : tests/makefile.msc is in CVS for
886 a long time, finally added to EXTRA_DIST : fixes bug
887 #141334, John Ehresman
889 2004-04-30 Matthias Clasen <mclasen@redhat.com>
891 * === Released 2.4.1 ===
893 * configure.in: Version 2.4.1, interface age 1.
897 2004-04-29 Federico Mena Quintero <federico@ximian.com>
901 * gtk/gtkfilechooserdefault.c (remove_selected_bookmarks): New
902 function; moved the code over from
903 remove_bookmark_button_clicked_cb().
904 (remove_selected_bookmarks): Now, getting a non-removable bookmark
905 is not an error, as we may be called as a result of hitting the
907 (shortcuts_key_press_event_cb): New handler; delete the bookmark
908 if the user presses Backspace, Delete, or KP_Delete.
910 2004-04-29 Matthias Clasen <mclasen@redhat.com>
912 * gtk/gtkaction.c (closure_accel_activate): Use
913 _gtk_action_emit_activate() instead of directly
914 emitting the activate signal. (#141429, Jody Goldberg)
916 * gtk/gtkactiongroup.c (gtk_action_group_add_action_with_accel):
917 Warn people when the accelerator can not be
918 parsed. (#141429, Jody Goldberg)
920 2004-04-29 Matthias Clasen <mclasen@redhat.com>
922 * tests/testentrycompletion.c (main): Add a missing
923 cat. (#141070, Chris Sherlock)
925 * gtk/gtkrc.c (gtk_rc_check_pixmap_dir): Remove unused
926 variable. (#141022, Chris Sherlock)
928 * gtk/gtkcombo.c (gtk_combo_popup_list): Add a missing
929 cast. (#141013, Chris Sherlock)
931 * gtk/gtkcellview.c (gtk_cell_view_cell_layout_clear): Remove
932 unused variable. (#141011, Chris Sherlock)
934 2004-04-29 Tor Lillqvist <tml@iki.fi>
936 * gdk/win32/gdkgc-win32.c (gdk_win32_gc_set_dashes): Plug memory
937 leak. (#140775, John Ehresman)
939 Thu Apr 29 01:09:50 2004 Matthias Clasen <maclas@gmx.de>
941 * gdk/gdkdraw.c (_gdk_drawable_get_scratch_gc): Use depth - 1
942 to index the cached gcs, not depth. (#139494)
944 2004-04-28 Matthias Clasen <mclasen@redhat.com>
946 * gdk/gdkdraw.c (_gdk_drawable_get_scratch_gc): Docs typo fix.
948 Sun Apr 25 15:36:02 2004 Soeren Sandmann <sandmann@daimi.au.dk>
950 * gtk/gtktoolbutton.c (gtk_tool_button_set_label_widget): Fix
951 cut'n'paste-o from previous commit. (#141046, Torsten Schoenfeld).
953 2004-04-24 Theppitak Karoonboonyanan <thep@linux.thai.net>
955 Patch to add support for string conversion callbacks to
956 GtkIMContextXIM (#101814)
958 * modules/input/gtkimcontextxim.c: Set the string conversion callback
959 if supported by the XIC.
961 (struct _GtkIMContextXIM): Add string_conversion_callback member.
963 (struct _GtkXIMInfo, setup_im): Check and keep flag inidicating
964 whether string conversion callback is supported.
966 (gtk_im_context_get_ic, +set_string_conversion_callback,
967 +string_conversion_callback): Also initialize string conversion
968 callback, if supported, along with the IC initialization.
970 * modules/input/imxim.c: Make "xim" module default for Thai as well.
972 2004-04-23 Matthias Clasen <mclasen@redhat.com>
974 * gtk/gtkclipboard.c (gtk_clipboard_wait_for_targets): Correctly
975 initialize targets. (#139883, John Finlay)
977 * gdk/gdkdraw.c (gdk_draw_drawable): Small doc improvement.
979 * gtk/gtktreeselection.c (gtk_tree_selection_get_selected_rows):
980 Don't recommend gtk_tree_row_reference_new_proxy(). (#138309,
983 * gtk/gtktreeviewcolumn.c (gtk_tree_view_column_cell_set_cell_data):
984 Remove an excessive g_return_if_fail().
986 * gdk/x11/gdkevents-x11.c (set_user_time): Make set_user_time()
988 * gdk/x11/gdkinput-x11.c (_gdk_input_common_other_event):
989 _-prefix calls of gdk_x11_window_set_user_time().
991 2004-04-22 Matthias Clasen <mclasen@redhat.com>
993 * gtk/gtkuimanager.c (update_node): Make sure the separators
994 used to demarkate placeholder ends don't show up on
995 show_all(). (#140496, Murray Cumming)
997 * gtk/gtkspinbutton.c (spin_button_at_limit): Make spinbuttons
998 work with negative increments. (#137975, Tim Gerla)
1000 Wed Apr 21 21:38:03 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1002 * gtk/gtktoolbutton.c (gtk_tool_button_set_label_widget,
1003 gtk_tool_button_set_icon_widget): Remove the old widget from the
1004 tool button before overwriting it with the new widget.
1006 (#140508, Todd Goyen)
1008 2004-04-22 Tor Lillqvist <tml@iki.fi>
1010 Fix the file chooser on Windows. I can't make it misbehave or
1011 crash any more now. But presumably there are still corner cases
1012 not handled. I haven't really checked behaviour of UNC paths, for
1015 * gtk/gtkfilesystemwin32.c: Accept both backslash and slash in
1016 several places. Use G_IS_DIR_SEPARATOR macro (which could be added
1019 (gtk_file_system_win32_get_parent): Like the Unix version, assert
1020 filename is absolute, and avoid one unnecessary string allocation
1023 (canonicalize_filename,gtk_file_system_win32_parse): Handle drive
1024 letters more correctly.
1026 (gtk_file_system_win32_render_icon): Assure correct syntax is used
1027 for root folder of a drive. (#137962, Morten Welinder)
1029 (filename_is_some_root): New function that accepts also root
1030 without any drive specified.
1032 (filename_is_drive_root): Rename from filename_is_root.
1034 * gtk/gtkfilechooserentry.c (completion_match_func): Casefold on
1037 2004-04-21 Matthias Clasen <mclasen@redhat.com>
1039 * gtk/gtkentry.c (gtk_entry_completion_timeout): Pop down the
1040 completion window if there are no completions anymore.
1042 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
1043 Don't call gtk_tree_view_scroll_to_cell() on an empty tree view.
1044 It doesn't like that. (#140642, Christian Persch)
1046 * demos/gtk-demo/expander.c (do_expander): A new demo.
1048 * demos/gtk-demo/Makefile.am (demos): Add expander.c.
1050 2004-04-20 Matthias Clasen <mclasen@redhat.com>
1052 * gtk/gtktextview.c (gtk_text_view_allocate_children): Make
1053 sure anchored children get size allocated, even if the layout
1054 is valid. (#122323, Andrew E. Makeev)
1055 (gtk_text_view_scroll_pages):
1056 (gtk_text_view_scroll_hpages): Don't scroll to cursor position
1057 if we already have pending scrolls. Bandaid fix for #78513.
1059 Mon Apr 19 17:59:17 2004 Owen Taylor <otaylor@redhat.com>
1061 * INSTALL.in: Update libpng and libjpeg URLs, remove
1062 note about building without since that's not the normal
1065 Sun Apr 11 09:45:11 2004 Owen Taylor <otaylor@redhat.com>
1067 * gtk/gtkicontheme.c (load_themes): Fix a couple of typos in
1068 handling of SVG/non-SVG unthemed icons.
1070 2004-04-19 Morten Welinder <terra@gnome.org>
1072 * gtk/gtktoolbar.c (gtk_toolbar_focus): Don't leak list of
1075 2004-04-19 Matthias Clasen <mclasen@redhat.com>
1077 * gtk/gtktextbtree.c (_gtk_text_line_previous_could_contain_tag):
1078 Don't stop the iteration up to the tag_root too
1079 early. (#109945, Dongho Shin)
1081 Sun Apr 18 17:06:03 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1083 * gdk/x11/gdkkeys-x11.c (get_effective_keymap): Make
1084 gdk_keymap_translate_keyboard_state() handle NULL
1085 keymaps. (#139715, Torsten Schoenfeld).
1087 Sun Apr 18 16:59:21 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1089 * configure.in: Don't erase GDK_EXTRA_CFLAGS. Fixes bug 139586,
1090 reported by Pedro RODRIGUEZ, about compilation problems when
1091 Xcursor is installed in a non-standard location.
1093 Sun Apr 18 16:15:15 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1095 Support for _NET_WM_USER_TIME (bug 115650). Patch by Elijah
1098 * gdk/x11/gdkwindow-x11.[ch]: Add new internal function
1099 _gdk_x11_set_user_time() to set the _NET_WM_USER_TIME property.
1101 * gdk/x11/gdkdisplay-x11.h (struct _GdkDisplayX11): Add user_time field
1103 * gdk/x11/gdkdisplay-x11.c: Add _NET_WM_USER_TIME to list of
1106 * gdk/x11/gdkinput-x11.c, gdk/x11/gdkevents-x11.c: Set the
1107 property on user interaction.
1109 2004-04-15 Federico Mena Quintero <federico@ximian.com>
1111 * gtk/gtkfilesel.c (open_new_dir): Tell the user to use
1112 G_FILENAME_ENCODING, not G_BROKEN_FILENAMES. Fixes #114065.
1114 * gtk/gtkfilechooserdefault.c (split_uris): Use a variant of the
1115 code from gtkfilesel.c to parse a "text/uri-list" blob. Fixes
1118 2004-04-15 Matthias Clasen <mclasen@redhat.com>
1120 * gtk/gtkcellrenderer.c (gtk_cell_renderer_class_init):
1121 * gtk/gtkbutton.c (gtk_button_class_init): Doc fixes.
1123 2004-04-14 Matthias Clasen <mclasen@redhat.com>
1125 * gtk/gtkcombobox.c:
1127 Make all style properties readonly.
1129 2004-04-14 Matthias Clasen <mclasen@redhat.com>
1131 * gtk/gtkcolorsel.c: Add a11y relations between the color
1132 wheel and the spin buttons. (#132745, Padraig O'Briain)
1134 * gtk/gtkiconfactory.c (gtk_icon_set_render_icon): Document
1135 the meaning of size == -1.
1137 * gtk/gtkwidget.c (gtk_widget_render_icon): Explicitly accept
1138 a size of -1. (#137436, Brian Cameron)
1140 * gtk/gtkcombobox.c: Make the arrow and separator regular
1141 children of an hbox inside the button, and propagate state
1142 changes from the button to the cell view. (part of the fix
1143 for #138650, should also fix #137535)
1145 * gtk/gtkcellview.c (gtk_cell_view_expose): Pass the PRELIT
1146 state to gtk_cell_renderer_render() when prelighted. (part
1147 of the fix for #138650)
1149 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_render):
1150 Use PRELIGHT state when appropriate. (part of the fix for
1153 * gtk/gtkcombobox.c (gtk_combo_box_relayout): Don't spit
1154 out warnings if called before the combo box is
1155 realized. (#139742, Philip Langdale)
1157 Wed Apr 14 03:45:39 2004 Jonathan Blandford <jrb@gnome.org>
1159 * gtk/gtktreeview.c (gtk_tree_view_expose): propagate expose
1162 Wed Apr 14 03:32:58 2004 Jonathan Blandford <jrb@gnome.org>
1164 * gtk/gtkpathbar.c (make_directory_button): remove spurious
1167 Tue Apr 13 16:19:23 2004 Jonathan Blandford <jrb@redhat.com>
1169 * gtk/gtkpathbar.c (make_directory_button): patch from Owen to
1170 make the buttons sized by a bold label. This makes the text
1171 'swim' a little, but stops the buttons from resizing, #137210
1173 2004-04-13 Matthias Clasen <mclasen@redhat.com>
1175 * gtk/gtkuimanager.c (get_child_node): Don't crash if a node
1177 (start_element_handler): Accept separators without unique
1178 names. (#133302, Anders Carlsson)
1180 * gtk/gtkactiongroup.c (gtk_action_group_add_action): Document
1181 possible accelerator gotcha when using this function. (#139641,
1184 * gtk/gtkuimanager.c (node_remove_ui_reference): Don't leak
1185 list nodes. (#138862, Morten Welinder)
1187 Tue Apr 13 12:24:49 2004 Jonathan Blandford <jrb@redhat.com>
1189 * gtk/gtktreeview.c (gtk_tree_view_destroy): remove unused
1191 (gtk_tree_view_button_press): If we activated the row we don't
1192 want to grab focus back, as moving focus to another widget is
1193 pretty common, #138458
1195 2004-04-12 Federico Mena Quintero <federico@ximian.com>
1197 * gtk/gtkfilechooser.c (gtk_file_chooser_class_init): Added
1198 documentation to all the signals.
1200 2004-04-12 Matthias Clasen <mclasen@dhcp64-228.boston.redhat.com>
1202 * gtk/gtkcombobox.c (gtk_combo_box_unset_model): Don't unref
1203 model if it is NULL. (#139770)
1205 * gtk/gtktreeview.c (gtk_tree_view_get_cell_area): Typo fix.
1207 * gtk/gtkentrycompletion.c (gtk_entry_completion_init): Don't add
1208 a shadow inside the scrolled window, add it around the vbox.
1210 * gtk/gtkentryprivate.h:
1211 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
1212 Return a boolean indicating whether the popup is positioned above
1213 or below. Scroll the completions to the beginning or the end,
1214 depending on the positioning.
1216 * gtk/gtkentry.c (gtk_entry_completion_key_press): Make keynav
1217 wrap around in the entry completion popup, and allow GDK_UP to
1218 enter the popup. (#137440)
1220 2004-04-12 Matthias Clasen <mclasen@redhat.com>
1222 * gtk/gtkentry.c (gtk_entry_size_request): Make sure the style is
1223 there before using it.
1225 Sun Apr 11 15:08:45 2004 Jonathan Blandford <jrb@gnome.org>
1227 * gtk/gtktreeprivate.h: Moved search entries into priv data.
1229 * gtk/gtktreeview.c: Prep for type-ahead support.
1231 (gtk_tree_view_destroy): Destroy the search window explicitly.
1232 (gtk_tree_view_key_press): Minor change; prep for type-ahead
1233 (gtk_tree_view_ensure_interactive_directory): New function
1234 (gtk_tree_view_focus_out): Rework to handle new entry life-cycle.
1235 (gtk_tree_view_real_start_interactive_search): rework
1236 (gtk_tree_view_search_dialog_hide): ditto
1237 (gtk_tree_view_search_delete_event): ditto
1238 (gtk_tree_view_search_button_press_event): ditto
1239 (gtk_tree_view_search_key_press_event): ditto
1240 (gtk_tree_view_search_move): ditto
1241 (gtk_tree_view_search_init): ditto
1243 * gtk/gtktreeviewcolumn.c:
1244 (gtk_tree_view_column_cell_layout_clear): remove unused variable.
1246 * tests/testfilechooser.c: (main): change
1248 2004-04-11 Hans Breuer <hans@breuer.org>
1250 * gdk/win32/gdkspawn-win32.c : workaround for bug #137496,
1251 the real fix would involve just another small API breakage,
1252 i.e. gdk_spawn_* using GPid not just gint.
1254 * gtk/makefile.msc.in : build gtk-win32.res, not gtk.res
1256 2004-04-10 Tor Lillqvist <tml@iki.fi>
1258 * gdk/win32/gdkkeys-win32.c (gdk_keymap_translate_keyboard_state):
1259 If both Shift and CapsLock pressed, ignore the shift only for
1260 letters (that would have been affected by the CapsLock). (#139095)
1262 * gdk/win32/gdkglobals-win32.c: Disable tablet support by default,
1263 seems to be even buggier now than it used to be. (#138341)
1264 Initialize _gdk_input_ignore_wintab to TRUE.
1266 * gdk/win32/gdkmain-win32.c: Add --use-wintab switch and
1267 GDK_USE_WINTAB environment variable to turn on tablet support.
1269 2004-04-09 Christian Persch <chpe@cvs.gnome.org>
1271 * gtk/gtkuimanager.c: (gtk_ui_manager_insert_action_group),
1272 (gtk_ui_manager_remove_action_group): Terminate
1273 g_object_[dis]connect() calls with NULL instead of 0.
1276 2004-04-09 Guntupalli Karunakar <karunakar@freedomink.org>
1278 * configure.in: Added "gu" (Gujarati) to ALL_LINGUAS.
1280 2004-04-07 Federico Mena Quintero <federico@ximian.com>
1284 * gtk/gtkfilesystem.c (gtk_file_system_parse): Ensure that the
1285 passed-in 'str' is not NULL.
1287 * gtk/gtkfilesystemunix.c (expand_tilde): New helper function;
1288 expands "~/" or "~foo/" at the beginning of a filename.
1289 (gtk_file_system_unix_parse): Use expand_tilde() before doing
1292 * gtk/gtkfilechooserentry.c
1293 (gtk_file_chooser_entry_maybe_update_directory): Take in a
1294 force_reload argument.
1295 (gtk_file_chooser_entry_changed): If gtk_file_system_parse()
1296 returns an error, set the file_part_pos to -1.
1297 (load_directory_callback): Only populate the model if the
1298 file_part_pos is not -1.
1300 2004-04-06 Pablo Saratxaga <pablo@mandrakesoft.com>
1302 * configure.in: Added Icelandic (is) to ALL_LINGUAS
1304 2004-04-05 Federico Mena Quintero <federico@ximian.com>
1306 * gtk/gtkfilechooserdefault.c (location_popup_handler): Use a
1307 title for SAVE and CREATE_FOLDER modes. Fixes #137272.
1309 * gtk/gtkfilesystemunix.c (gtk_file_system_unix_make_path): Look
1310 for G_DIR_SEPARATOR in the display_name, and err out if it is
1311 present; use the same error message as Nautilus. Fixes #136467.
1313 * gtk/gtkfilechooserdefault.c (file_pane_create): Make the
1314 new-folder button say "Create Fo_lder" rather than "Create
1315 _Folder", so that the mnemonic doesn't conflict with the "Save in
1316 _folder" label. Fixes #136975.
1318 2004-04-05 Federico Mena Quintero <federico@ximian.com>
1320 * gtk/gtkpathbar.c (_gtk_path_bar_set_path): Ref/sink the
1321 buttons. Also, free them correctly upon failure. Based on a
1322 patch by Morten Welinder, fixes #137956.
1324 2004-04-05 Anders Carlsson <andersca@gnome.org>
1326 * gdk/gdk.c (gdk_arg_context_parse): Handle '--' correctly.
1328 Fri Apr 2 17:57:33 2004 Jonathan Blandford <jrb@redhat.com>
1330 * gtk/gtktreeview.c (gtk_tree_view_row_inserted): set the height
1331 correctly for fixed height when inserting a node, #138082
1333 2004-04-01 Federico Mena Quintero <federico@ximian.com>
1337 * gtk/gtkpathbar.h (struct _GtkPathBarClass): Add a
1338 "child_is_hidden" boolean argument to the "path-clicked" signal.
1340 * gtk/gtkpathbar.c (struct _ButtonData): Added a file_is_hidden
1342 (make_directory_button): Take a file_is_hidden argument; put it in
1344 (_gtk_path_bar_set_path): See whether each path component path is
1346 (gtk_path_bar_class_init): Add the file_is_hidden argument to the
1347 "path-clicked" signal.
1348 (button_clicked_cb): See if the downwards button represents a
1349 hidden file for the file_is_hidden argument in the signal
1352 * gtk/gtkmarshalers.list: Added a signal type VOID:POINTER,BOOLEAN.
1354 * gtk/gtkfilechooserdefault.c
1355 (gtk_file_chooser_default_select_path): If we fail to switch
1356 folders, don't try to select the path in the file system model.
1357 Also, return the result from _gtk_file_system_model_path_do().
1358 (gtk_file_chooser_default_select_path): Turn on show_hidden in the
1359 file system model if we are asked to select a hidden file.
1360 (path_bar_clicked): Show hidden files based on whether the
1361 immediate downwards folder in the path bar is a hidden file
1363 (struct _GtkFileChooserDefault): Added fields
1364 browse_files_popup_menu and browse_files_popup_menu_hidden_files_item.
1365 (create_file_list): Set an object data key of
1366 "GtkFileChooserDefault" on the tree view so that we can find the
1367 impl from the popup menu callbacks. Also, hook up to the
1368 "button-press-event" and "popup-menu" signals in the file list to
1369 bring up a popup menu.
1370 (list_popup_menu_cb): New callback.
1371 (list_button_press_event_cb): New callback.
1375 * gtk/gtkfilesystemmodel.c
1376 (_gtk_file_system_model_new): Oops, connect_object to
1379 2004-03-31 Tor Lillqvist <tml@iki.fi>
1381 * configure.in: Move AC_CANONICAL_HOST earlier, before the check
1382 for native Win32. (#136559, J. Ali Harlow)
1384 * gdk/win32/gdkdrawable-win32.c (draw_arc): Use X11 semantics for
1385 angles. Thanks to Tim Newsham.
1387 2004-03-29 Federico Mena Quintero <federico@ximian.com>
1391 * gtk/gtkfilesystem.h (struct _GtkFileFolderIface): Added slots
1392 for an ::is_finished_loading() method and a ::finished_loading()
1393 signal at the end of the struct.
1395 * gtk/gtkfilesystem.c (gtk_file_folder_base_init): Create the
1396 "finished-loading" signal.
1397 (gtk_file_folder_is_finished_loading): New function.
1399 * gtk/gtkfilesystemunix.c
1400 (gtk_file_folder_unix_is_finished_loading): Implement.
1402 * gtk/gtkfilesystemmodel.c (struct _GtkFileSystemModelClass): New
1403 slot for a "finished-loading" signal.
1404 (gtk_file_system_model_class_init): Create the "finished-loading"
1406 (struct _GtkFileSystemModel): New field
1407 idle_finished_loading_source. We emit the "finished-loading"
1408 signal in an idle if the root folder was done loading right in
1409 _gtk_file_system_model_new(), so that the caller has a chance to
1410 connect to the signal.
1411 (_gtk_file_system_model_new): Connect to the normal signals of the
1412 folder even if the initial _list_children() fails. Also, see if
1413 the folder is finished loading; connect to the "finished-loading"
1415 (gtk_file_system_model_finalize): Remove the idle handler.
1417 * gtk/gtkfilechooserdefault.c (set_list_model): Set a busy cursor
1418 and connect to the model's "finished-loading" signal.
1419 (get_toplevel): New helper function.
1420 (error_message): Use get_toplevel().
1421 (trap_activate_cb): Likewise.
1422 (location_popup_handler): Likewise.
1423 (set_busy_cursor): New function.
1424 (browse_files_model_finished_loading_cb): New callback.
1426 2004-03-25 Federico Mena Quintero <federico@ximian.com>
1428 * gtk/gtkfilechooserdefault.c (check_preview_change): Just use the
1429 file under the cursor; we don't need the logic from
1430 GtkFileSelection after all. Fixes #132255.
1432 2004-03-25 Federico Mena Quintero <federico@ximian.com>
1434 * gtk/gtkfilechooserdefault.c (location_entry_create): Fill the
1435 location entry with the display name of the file under the cursor
1436 for Open mode, or the typed filename in Save mode.
1438 2004-03-24 J. Ali Harlow <ali@juiblex.co.uk>
1440 * gtk/gtkfilesystemwin32.c
1441 (filename_is_root): Bare drive designators (eg., "c:") are
1442 no longer considered as root filenames. Fixed #137942
1444 2004-03-24 J. Ali Harlow <ali@juiblex.co.uk>
1446 * gtk/gtkfilesystemwin32.c
1447 (gtk_file_system_win32_create_folder): Invert test for error in
1448 mkdir. Fixes #137945
1450 2004-03-24 J. Ali Harlow <ali@juiblex.co.uk>
1452 Fixed #138004 using Federico's code from #132327.
1454 * gtk/gtkfilesystemwin32.c (struct _GtkFileSystemWin32): Add a
1455 folder_hash field to keep a list of live folder objects.
1456 (gtk_file_system_win32_init): Create the folder_hash.
1457 (gtk_file_system_win32_finalize): Destroy the folder_hash.
1458 (gtk_file_system_win32_get_folder): Ref and return an existing
1459 folder if we have it around, otherwise return a new folder object.
1460 (struct _GtkFileFolderWin32): Add a field for the parent file system.
1461 (gtk_file_folder_win32_finalize): Remove the folder from the file
1462 system's hash table.
1463 (gtk_file_system_win32_create_folder): Emit "files-added" on the
1464 newly-created folder's parent. Fixes #138004.
1466 2004-03-24 J. Ali Harlow <ali@juiblex.co.uk>
1468 * gtk/gtkfilesystemwin32.c
1469 (gtk_file_system_win32_get_folder): Test that path is actually
1470 a directory and throw error if not. Fixed bug #137950
1472 2004-03-22 J. Ali Harlow <ali@juiblex.co.uk>
1474 * gtk/gtkfilesystemwin32.c
1475 (gtk_file_system_win32_volume_get_display_name): Ignore empty
1476 volume labels; assume that GetVolumeInformation would fail if
1477 GetVolumeInformationW does; catches a small memory leak;
1478 pass the buffer size to GetVolumeInformationW in wide
1479 characters instead of bytes. Fixes bug #137543
1480 (list_volumes): Cope with the theoretical possibility of
1481 more than 26 logical drives. Fixes bug #137940
1482 (bookmarks_serialize): Now actually removes bookmarks.
1485 2004-03-22 Guntupalli Karunakar <karunakar@freedomink.org>
1487 * configure.in: Added "pa" (Punjabi) to ALL_LINGUAS.
1489 2004-03-21 Tor Lillqvist <tml@iki.fi>
1491 * gtk/gtkfilesystemwin32.c
1492 (gtk_file_system_win32_volume_get_base_path): Include the
1493 backslash. Otherwise gtk_file_system_win32_path_to_uri() returns
1494 NULL for a volume base path, as g_filename_to_uri() requires an
1495 absolute path, and just a drive letter and colon isn't. (#137543)
1497 2004-03-20 Hans Breuer <hans@breuer.org>
1499 * gtk/gtkfilesystemwin32.c : applied the undisputable and
1500 required [due to recent gtkfilesystem internal api semantic
1501 changes] part of patches to fix bug #137543 (Tor Lillqvist,
1504 * gdk/gdkevents-win32.c (handle_configure_event) :
1505 (gdk_event_translate), WM_WINDOWPOSCHANGED : initialize
1506 GdkWindowObject::x, y with screen coords to make
1507 gdk_window_get_position () return the right thing and thus fix
1508 drag and drop positioning (e.g. Gimp tabs, fixes bug #137192)
1510 2004-03-19 Federico Mena Quintero <federico@ximian.com>
1512 * Revert the patch to #137520, as 2.4.1 is for conservative bug
1513 fixes only. The patch is attached to the bug report, for
1516 2004-03-19 Morten Welinder <terra@gnome.org>
1518 * gtk/gtkfilechooserdefault.c
1519 (gtk_file_chooser_default_set_current_folder): Test existance of
1520 the path after checking for locality, if needed.
1522 2004-03-19 Federico Mena Quintero <federico@ximian.com>
1526 * gtk/gtkfilesystem.h (struct _GtkFileFolderIface): Added slots
1527 for an ::is_finished_loading() method and a ::finished_loading()
1528 signal at the end of the struct.
1530 * gtk/gtkfilesystem.c (gtk_file_folder_base_init): Create the
1531 "finished-loading" signal.
1532 (gtk_file_folder_is_finished_loading): New function.
1534 * gtk/gtkfilesystemunix.c
1535 (gtk_file_folder_unix_is_finished_loading): Implement.
1537 * gtk/gtkfilesystemmodel.c (struct _GtkFileSystemModelClass): New
1538 slot for a "finished-loading" signal.
1539 (gtk_file_system_model_class_init): Create the "finished-loading"
1541 (struct _GtkFileSystemModel): New field
1542 idle_finished_loading_source. We emit the "finished-loading"
1543 signal in an idle if the root folder was done loading right in
1544 _gtk_file_system_model_new(), so that the caller has a chance to
1545 connect to the signal.
1546 (_gtk_file_system_model_new): Connect to the normal signals of the
1547 folder even if the initial _list_children() fails. Also, see if
1548 the folder is finished loading; connect to the "finished-loading"
1550 (gtk_file_system_model_finalize): Remove the idle handler.
1552 * gtk/gtkfilechooserdefault.c (set_list_model): Set a busy cursor
1553 and connect to the model's "finished-loading" signal.
1554 (get_toplevel): New helper function.
1555 (error_message): Use get_toplevel().
1556 (trap_activate_cb): Likewise.
1557 (location_popup_handler): Likewise.
1558 (set_busy_cursor): New function.
1559 (browse_files_model_finished_loading_cb): New callback.
1561 Thu Mar 18 12:10:45 2004 Owen Taylor <otaylor@redhat.com>
1563 * gtk/gtktreeitem.c (gtk_tree_item_forall): Include
1564 eventbox for expander. (#137564, reported by
1567 2004-03-18 Guntupalli Karunakar <karunakar@freedomink.org>
1569 * mr.po: Added "mr" for Marathi to ALL_LINGUAS.
1571 2004-03-17 Morten Welinder <terra@gnome.org>
1573 * gtk/gtkfilechooserdefault.c (shortcuts_add_volumes): Free
1574 volumes not actually put into the shortcut list.
1576 * tests/prop-editor.c (object_changed): Plug leak.
1578 * tests/testfilechooser.c (main): Plug some leaks and expose
1581 * tests/prop-editor.c (create_prop_editor): Don't leak the tooltip
1582 object. Fixed #136652.
1584 * gtk/gtkfilechooserdefault.c (check_icon_theme): Do nothing if we
1585 have no screen. Fixes #137260.
1586 (shortcuts_add_bookmark_from_path): Simplify using check_is_folder
1587 thereby fixing leak. Fixes #137259.
1589 * gtk/gtkpathbar.c (gtk_path_bar_forall): Make this work when the
1590 slider buttons have been destroyed.
1591 (gtk_path_bar_remove): Make this work for slider buttons too.
1594 2004-03-15 Morten Welinder <terra@gnome.org>
1596 * gtk/gtkfilechooserdefault.c (shortcuts_add_bookmark_from_path):
1597 Sanitize and plug leak.
1598 (check_icon_theme): Only do something if the widget has a screen.
1600 Wed Mar 17 01:20:28 2004 Matthias Clasen <maclas@gmx.de>
1602 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
1603 Move the repositioning logic from _gtk_entry_completion() popup
1604 over here. Fixes #137355, reported by Niklas Knutsson.