1 2005-09-30 Matthias Clasen <mclasen@redhat.com>
3 * gtk/gtkcalendar.c (gtk_calendar_init): Another attempt
4 to correct the calculations for the first week day. We may
5 just have to remove this code if too many locales turn out
8 * gtk/gtkimage.c (gtk_image_expose): Don't leak pixbuf in
9 some cases. (#317611, Tommi Komulainen)
11 * gtk/gtksocket-x11.c (_gtk_socket_windowing_size_request):
12 Prevent overflow when storing size hints in an unsigned
13 short variable. Tracked down by Ray Strode and Søren Sandmann.
15 2005-09-29 Matthias Clasen <mclasen@redhat.com>
17 * gtk/gtkbutton.c (gtk_button_set_image): Check arguments. (#317491,
20 * gtk/gtkpaned.c (gtk_paned_grab_notify): Stop drags when being
21 grab shadowed. (#317332)
23 2005-09-29 Tor Lillqvist <tml@novell.com>
25 * gtk-zip.sh.in: DLLs are always in bin nowadays, no need to test.
27 2005-09-28 Federico Mena Quintero <federico@ximian.com>
29 * tests/autotestfilechooser.c (test_reload_sequence): Oops, return
30 if the unmap test fails.
31 (test_reload_sequence): Use gtk_widget_show_now() instead of
32 gtk_widget_show() for the dialog.
33 Thanks to Tim Janik for noticing these.
35 2005-09-28 Federico Mena Quintero <federico@ximian.com>
37 * tests/testcellrenderertext.c: New file with a set of tests for
38 GtkCellRendererText. The idea is to run a text renderer through
39 most of its interesting property values to see that it works
42 * tests/Makefile.am: Added testcellrenderertext.
44 * gtk/gtkfilechooserdefault.c (load_set_model): Mark the
45 entry/exit of this function for profiling.
46 (gtk_file_chooser_default_style_set): Mark the start/end of the
47 calls to the parent class and the the signal emission for profiling.
49 2005-09-29 Tor Lillqvist <tml@novell.com>
51 * gtk/gtkmain.c (_gtk_get_localedir): The locale directory is
52 passed to bindtextdomain() which isn't UTF-8-aware, so convert to
53 system codepage using g_win32_locale_filename_from_utf8().
54 (#317457, Kazuki Iwamoto)
56 2005-09-28 Matthias Clasen <mclasen@redhat.com>
58 * gtk/gtkselection.c (_gtk_selection_request): Free mult_atoms
59 here. (#317039, Paolo Borelli)
62 * gtk/gtktexttag.c (gtk_text_attributes_ref): Return the attributes
63 to make this function work as boxed copy function. (#317455,
66 * gtk/gtkclipboard.c (request_image_received_func): Don't unref
67 NULL. (#316828, Tor Lillqvist)
69 2005-09-28 Tor Lillqvist <tml@novell.com>
71 * modules/input/imime.c: Include <config.h>. (#317444, Kazuki
74 2005-09-27 Federico Mena Quintero <federico@ximian.com>
76 Don't reload the current folder unnecessarily on ::map().
78 * gtk/gtkfilechooserprivate.h (ReloadState): New enum to represent
80 (struct _GtkFileChooserDefault): Added a "reload_state" field.
82 * gtk/gtkfilechooserdefault.c (gtk_file_chooser_default_init):
83 Initialize impl->reload_state.
84 (gtk_file_chooser_default_map): Check the impl->reload_state; load
85 a default folder if no folder has been set, or reload the current
86 one only if we had been unmapped first.
87 (gtk_file_chooser_default_update_current_folder): Set the
88 reload_state to RELOAD_HAS_FOLDER.
89 (gtk_file_chooser_default_unmap): Implement, and set the
90 reload_state to RELOAD_WAS_UNMAPPED.
91 (shortcuts_model_create): Don't call shortcuts_add_bookmarks()
92 here; they'll get (re)loaded on ::map() anyway.
94 * gtk/gtkfilechooserwidget.c
95 (gtk_file_chooser_widget_constructor): Don't set a default folder here.
97 * tests/autotestfilechooser.c (test_action_widgets): Don't take in
98 a dialog; build it ourselves.
99 (test_reload): New test to ensure that we don't load the default
100 folder more than once, and that we reload it when
102 (get_impl_from_dialog): New utility function.
103 (test_widgets_for_current_action): Use get_impl_from_dialog().
105 2005-09-27 Federico Mena Quintero <federico@ximian.com>
107 * gtk/gtkfilechooserdefault.c
108 (gtk_file_chooser_default_constructor): Mark the entry/exit of
109 this function for profiling.
110 (check_icon_theme): Likewise.
111 (change_icon_theme): Likewise.
112 (settings_notify_cb): Likewise.
113 (gtk_file_chooser_default_screen_changed): Likewise.
114 (update_chooser_entry): If the selection is empty, clear the file
115 name entry only if we are in CREATE_FOLDER mode. In SAVE mode,
116 nothing will be selected when the user starts typeahead in the
117 treeview, and we don't want to clear the file name entry in that
118 case --- the user could be typing-ahead to look for a folder name.
119 Fixes bug #308332, patch by Jürg Billeter.
121 2005-09-27 Matthias Clasen <mclasen@redhat.com>
123 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
124 Pop below the entry if there's more free space below the entry
125 than above. (#316948, Tommi Komulainen)
127 2005-09-26 Federico Mena Quintero <federico@ximian.com>
129 Do not create the save mode-specific widgets in the open modes, so
130 that we don't carry their baggage around.
132 * gtk/gtkfilechooserdefault.c
133 (gtk_file_chooser_default_constructor): Don't create the
135 (save_widgets_create): Set the impl->save_widgets directly here,
136 instead of passing the widgets back to the caller. Also, pack
137 them into the impl's box.
138 (update_appearance): Create or destroy the save widgets as
139 appropriate. Set the action of the save_file_name_entry here.
140 (shortcuts_add_current_folder): Set the active item in the
141 save_folder_combo only if it exists.
142 (gtk_file_chooser_default_set_property): Don't set the action of
143 the save_file_name_entry here.
144 (gtk_file_chooser_default_update_current_folder): Set the base
145 folder of the save_file_name_entry only if the entry exists.
146 (shortcuts_drag_data_received_cb): Cast the selection_data->data
147 to (const char *) since that's what shortcuts_drop_uris() expects.
148 (file_list_drag_data_received_cb): Likewise, for
149 g_uri_list_extract_uris().
151 2005-09-26 Tor Lillqvist <tml@novell.com>
153 * gdk/win32/gdkwindow-win32.c (gdk_window_shape_combine_mask): Set
154 the shaped flag here, too. (#316871)
155 (gdk_window_shape_combine_region): Currently unimplemented, so
156 don't do anything to the shaped flag here.
158 2005-09-26 Matthias Clasen <mclasen@redhat.com>
160 Fix #316871, reported by Dan Winship:
162 * gdk/gdkwindow.h (struct _GdkWindowObject): Add a shaped flag.
164 * gdk/x11/gdkwindow-x11.c (gdk_window_shape_combine_mask)
165 (gdk_window_shape_combine_region): Set it here.
167 * gdk/gdkwindow.c (gdk_window_invalidate_maybe_recurse): Don't
168 remove the child area for shaped windows.
170 2005-09-23 Matthias Clasen <mclasen@redhat.com>
172 * gtk/gtkcellrendererpixbuf.c (gtk_cell_renderer_pixbuf_finalize):
173 Don't leak expander pixbufs. (#316946, Tommi Komulainen)
175 2005-09-22 Michael Natterer <mitch@imendio.com>
177 Renamed GtkCellRendererKeys to GtkCellRendererAccel to be
178 consistent with GTK+ terminology:
180 * gtk/gtkcellrendererkeys.[ch]
181 * tests/testkeys.c: removed...
183 * gtk/gtkcellrendereraccel.[ch]
184 * tests/testaccel.c: ...and added.
189 * tests/Makefile.am: changed accordingly.
191 2005-09-22 Matthias Clasen <mclasen@redhat.com>
193 * gtk/gtkwidget.c (gtk_widget_class_init): Fix the documentation
194 for the grab-broken-event signal, noticed by Damon Chaplin.
196 2005-09-21 Tor Lillqvist <tml@novell.com>
198 * gdk/win32/gdkselection-win32.c (gdk_selection_convert,
199 gdk_text_property_to_text_list_for_display,
200 gdk_text_property_to_utf8_list_for_display,
201 gdk_win32_selection_add_targets,
202 _gdk_win32_selection_convert_to_dib): Free return value from
204 (gdk_text_property_to_text_list_for_display): Drop GError variable
205 that isn't actually used after being set.
207 2005-09-20 Johan Dahlin <jdahlin@async.com.br>
209 * gtk/gtkentry.c (gtk_entry_set_completion): Mention NULL in
212 2005-09-20 Tor Lillqvist <tml@novell.com>
214 * gdk/win32/gdkselection-win32.c
215 (gdk_selection_owner_get_for_display): Do return the correct owner
216 for CLIPBOARD (i.e., the owner of the Windows Clipboard, if it is
217 a window GDK knows about). The reason to return NULL seems to have
218 gone when in the fix for bug #163702 the artificial
219 GDK_SELECTION_CLEAR event generation was removed from
220 gdk_selection_send_notify_for_display(). Fixes bug #316552.
222 2005-09-20 Matthias Clasen <mclasen@redhat.com>
224 Avoid unnecessary XkbGetState() calls and XkbStateNotify
225 events. (#151555, Søren Sandmann)
227 * gdk/x11/gdkdisplay-x11.c (gdk_display_open): Use
228 XkbSelectEventDetails() to select XkbStateNotify events
229 for only the state we care about.
231 * gdk/x11/gdkprivate-x11.h:
232 * gdk/x11/gdkkeys-x11.c (_gdk_keymap_state_changed): Pass
233 the event into the function and update the keymap state from
234 the state information contained in the event. Adjust all callers.
236 2005-09-19 Matthias Clasen <mclasen@redhat.com>
238 * gtk/gtkiconview.c: Use g_list_nth_data() instead of g_list_nth()->data
239 in multiple places to avoid segfaults if the index is out of range.
240 (#316422, Guillaume Cottenceau)
241 (gtk_icon_view_set_drag_dest_item):
242 (gtk_icon_view_scroll_to_path): Fix a typo in the docs. (#316419,
243 #316424, Guillaume Cottenceau)
245 2005-09-18 Hans Breuer <hans@breuer.org>
247 * gtk/gtktrayicon-win32.c : now handling events by hard-coded
248 g_signal_emit_by_name() - will break when gtkstatusicon.c changes.
250 2005-09-18 Hans Breuer <hans@breuer.org>
252 * gdk/gdk.symbols gdk/win32/gdkwin32.h gdk/win32/gdkcursorwin32.c : export
253 _gdk_win32_pixbuf_to_hicon() as gdk_win32_pixbuf_to_hicon_libgtk_only()
254 * gtk/gtktrayicon-win32.c : a lot of debug spew but it has started to show
255 the icon and is blinking with teststatusicon. More to come ...
257 2005-09-18 Hans Breuer <hans@breuer.org>
259 * gtk/makefile.msc.in : fix typo for GTK_VER; define HAVE_CONFIG_H
260 cause gtkprogressbar.c has #include <config.h> conditionally; less
261 noise from generated gtk.def
262 * gtk/stock-icons/makefile.msc gdk/makefile.msc tests/makefile.msc : updated
264 * gtk/gtktrayicon-win32.c : dummy implmentation to make gtk compile.
265 For me it works as well as the *NIX implemenation, that is not at all.
267 * gdk/win32/gdkproperty-win32.c : implement gdk_atom_intern_static_string()
269 * gdk/win32/gdkwindow-win32.c(gdk_window_set_urgency_hint) : only use
270 only use (WINVER >= 0x0500) when available from the SDK. Otherwise fall
271 back to true dynamic linking of FlashWindowEx. Makes gtk+ work on NT4.0
272 again - if compiled properly.
274 * tests/teststatusicon.c : don't use GNOME icons for testing, but icons
275 already coming with Gtk+. Makes it compile on win32.
277 2005-09-18 Guilherme de S. Pastore <gpastore@cvs.gnome.org>
279 * README.cvs-commits: fixed some tiny typos
281 2005-09-16 Tor Lillqvist <tml@novell.com>
283 * modules/engines/ms-windows/msw_style.c (draw_extension,
284 draw_box_gap): Check whether the widget actually is a GtkNotebook
285 before treating it as such. Drop some unneeded local variables,
286 use parameter with same information instead. (#316412)
288 2005-09-15 Federico Mena Quintero <federico@ximian.com>
290 * tests/autotestfilechooser.c: Start a set of automated tests for
291 the file chooser. The only test in there right now doesn't pass
292 yet. It specifies the intended behavior of the first optimization
293 of a series which I'll do on the file chooser (see
294 http://primates.ximian.com/~federico/news-2005-09.html#14 for the
295 details of this optimization).
297 * tests/Makefile.am: Added autotestfilechooser.c.
299 * gtk/gtkfilechooserprivate.h (struct
300 _GtkFileChooserDialogPrivate): Move all the file chooser's private
301 structures to here, so that they can be accessed by
302 tests/autotestfilechooser.c: _GtkFileChooserDialogPrivate,
303 _GtkFileChooserWidgetPrivate, LoadState, _GtkFileChooserDefault.
305 * gtk/gtkfilechooserdialog.c: See above.
307 * gtk/gtkfilechooserwidget.c: See above.
309 * gtk/gtkfilechooserdefault.c: See above.
311 Thu Sep 15 15:27:55 2005 Tim Janik <timj@imendio.com>
314 gtk_window_map_event(): new function to work around lost unmap requests.
317 2005-09-14 Federico Mena Quintero <federico@ximian.com>
319 * gtk/gtkfilechooserdefault.c (gtk_file_chooser_default_init): Add
320 an easy-to-find profiling marker when starting to create a file
322 (browse_files_model_finished_loading_cb): Likewise, for when the
323 chooser is finished loading.
325 2005-09-14 Tristan Van Berkom <tvb@cvs.gnome.org>
327 * gtk/gtkcolorbutton.c: Check "color" argument in
328 gtk_color_button_set_color ()
330 2005-09-14 Matthias Clasen <mclasen@redhat.com>
332 * gtk/gtklabel.c (gtk_label_get_type):
333 * gtk/gtkbutton.c (gtk_button_get_type):
334 * gtk/gtkwindow.c (gtk_window_group_get_type): No point in
335 using a mem chunk for window groups, buttons, labels.
337 * gtk/updateiconcache.c (foreach_remove_func): Fix
338 a use-after-free bug. (#316256, Alexander Nedotsukov)
340 2005-09-13 Matthias Clasen <mclasen@redhat.com>
342 * gtk/*.c: Various cleanups. (#315360, Kjartan Maraas)
344 * gdk/*.c: Various cleanups. (#315359, Kjartan Maraas)
346 2005-09-13 Matthias Clasen <mclasen@redhat.com>
348 * gtk/gtkimcontextsimple.c (gtk_im_context_simple_filter_keypress):
349 Let GDK_Return pass through in some more cases.
351 * gtk/gtkentry.c (gtk_entry_key_press): Reset the im context before
352 activating the entry.
354 * gtk/gtkiconview.c (gtk_icon_view_class_init):
355 (gtk_icon_view_get_dest_item_at_pos): Fix typos in the
356 docs. (#316008, #316027, #316121, Guillaume Cottenceau)
358 * gtk/gtkfilechooser.c (gtk_file_chooser_class_init): Add some docs.
359 (#316001, Guillaume Cottenceau)
361 * gtk/gtkdnd.c (gtk_drag_set_icon_name): Fix a copy-and-paste
362 mistake in the docs. (#315993, Guillaume Cottenceau)
364 * tests/testentrycompletion.c (create_simple_completion_model): Add
365 some strings containing multibyte characters.
367 * gtk/gtkentrycompletion.c (gtk_entry_completion_real_insert_prefix):
368 Fix prefix insertion for multibyte characters. (#316095,
371 * gtk/gtktreeview.c (gtk_tree_view_create_row_drag_icon):
372 * gtk/gtkiconview.c (gtk_icon_view_create_drag_icon): Silently
373 return NULL if the widget is not realized. (#316023,
374 Guillaume Cottenceau)
376 2005-09-11 Matthias Clasen <mclasen@redhat.com>
380 * gdk/x11/gdkproperty-x11.c (gdk_atom_intern_static_string):
381 New function to avoid pointless strdups when creating atoms
385 * gtk/*.c: Use gdk_atom_intern_static_string() where
388 2005-09-09 Matthias Clasen <mclasen@redhat.com>
390 * gtk/gtkcellrendererkeys.h:
391 * gtk/gtkcellrendererkeys.c: Add a cell renderer for displaying
392 and editing accelerators, a port of EggCellRendererKeys .
396 * gtk/Makefile.am: Add the keys cell renderer.
399 * tests/testkeys.c: Test GtkCellRendererKeys
401 2005-09-09 Matthias Clasen <mclasen@redhat.com>
403 Make it possible to determine if a key event is for a
406 * gdk/x11/gdkprivate-x11.h:
407 * gdk/x11/gdkkeys-x11.c (_gdk_keymap_key_is_modifier):
408 New function to determine if a keycode is mapped to a modifier.
409 (get_xkb): Get the modmap.
411 * gdk/x11/gdkevents-x11.c (translate_key_event): Set the
412 is_modifier bit by calling _gdk_keymap_key_is_modifier().
414 * gdk/gdkevents.h (struct _GdkEventKey): Add an is_modifier
417 2005-09-09 Matthias Clasen <mclasen@redhat.com>
419 * gdk/gdkpixbuf-drawable.c (convert_real_slow): Remove an
420 unused variable, noticed by Kjartan Maraas.
422 2005-09-09 Matthias Clasen <mclasen@redhat.com>
424 * gtk/gtktreeviewcolumn.c (gtk_tree_view_column_button_event):
425 Make drag reordering work properly for columns other than the
426 first. (#315054, Dan Winship)
428 * gtk/gtkfontsel.c (gtk_font_selection_set_font_name): Handle
429 invalid fontnames better. (#136926, Michael R. Walton)
431 Stop cursor blinking in non-editable regions of a text view.
432 (#311508, Torbjörn Andersson)
434 * gtk/gtktextview.c (gtk_text_view_check_cursor_blink):
435 (cursor_blinks): Take editability into account when deciding
436 whether the cursor blinks.
437 (gtk_text_view_button_release_event):
438 (gtk_text_view_move_cursor_internal): Update cursor blinking here.
440 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_start_editing):
441 Use connect_after to connect to the focus_out event. This
442 ensures that the entry has already stopped blinking by the time
443 we emit the edited signal. (#315229, Thomas Leonard)
445 * tests/testgtk.c: Use GDK_MOD1_MASK, not GDK_ALT_MASK.
447 * gtk/gtkwindow.c (gtk_window_parse_geometry): Don't set
448 unsigned ints to -1. (#315481, Kjartan Maraas)
450 * gtk/gtkcalendar.c (gtk_calendar_init): first_weekday is relative
451 to week_1stday, not to Sunday. Gotta love the ISO 14652 guys...
452 (#314473, Stanislav Brabec)
454 2005-09-09 Matthias Clasen <mclasen@redhat.com>
456 * gtk/gtktreeview.c (gtk_tree_view_get_visible_range): Document
457 memory handling. (#314975, Torsten Schoenfeld)
459 * gtk/gtkiconview.c (gtk_icon_view_class_init):
460 * gtk/gtkfilesel.c (gtk_file_selection_class_init):
461 * gtk/gtkcombobox.c (gtk_combo_box_class_init):
462 * gtk/gtklabel.c (gtk_label_class_init):
463 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_class_init):
464 Stylistic improvements and clarifications for some blurbs.
465 (#315520, Clytie Siddall)
467 2005-09-09 Tor Lillqvist <tml@novell.com>
469 * gdk/win32/gdkdisplay-win32.c (gdk_display_get_name): Cache the
470 display name. There is only one GdkDisplay on Win32, and
471 constructing the display name isn't entirely trivial, so cacheing
472 is probably worth it. For instance GIMP calls this function a lot.
473 (gdk_display_open): Call gdk_display_get_name() to prime the
475 (gdk_display_get_n_screens, gdk_display_get_screen,
476 gdk_display_get_default_screen): Verify parameter correctness like
477 the X11 backend does.
479 * gdk/win32/gdkscreen-win32.c (gdk_screen_make_display_name):
480 Return a freshly allocated string, as the API specifies. Fixes a
481 heap corruption problem that caused random errors and crashes in
484 2005-09-07 Matthias Clasen <mclasen@redhat.com>
486 * gtk/gtkimcontextsimple.c (gtk_im_context_simple_filter_keypress):
487 Make C-u commit and restart hex input if we are already in a
490 2005-09-06 Matthias Clasen <mclasen@redhat.com>
492 * gdk/x11/gdkkeys-x11.c (update_modmap): Make the modmap reflexive.
493 (_gdk_keymap_add_virtual_modifiers): Don't add both Alt and Meta
494 if they are mapped to the same modifier.
496 * gtk/Makefile.am: Rename gtkstatusicon-x11.c and gtktrayicon.c
497 to gtkstatusicon.c and gtktrayicon-x11.c
499 * gtk/gtkaccelgroup.c: Include Super, Hyper and Meta in the
500 default accel mod mask.
502 * gtk/gtkaccelgroup.c (gtk_accelerator_parse):
503 * gtk/gtkaccellabel.c (_gtk_accel_label_class_get_accelerator_label):
504 Don't use GDK_ALT_MASK.
506 * gdk/gdktypes.h: No need to introduce GDK_ALT_MASK
508 2005-09-06 Matthias Clasen <mclasen@redhat.com>
510 Add support for extra virtual modifiers: (#85780, Owen Taylor)
512 * tests/testgtk.c (create_key_lookup): Add tests for extra virtual
515 * gtk/gtkkeyhash.c (_gtk_key_hash_lookup): Try to match both against
516 Mod2 - Mod5 and against Super, Hyper, Meta.
518 * gtk/gtkaccellabel.c (_gtk_accel_label_class_get_accelerator_label):
519 * gtk/gtkaccelgroup.c (gtk_accelerator_parse)
520 (gtk_accelerator_name): Support Super, Hyper Meta and Mod2 - Mod5.
522 * gdk/x11/gdkkeys-x11.c (struct _GdkKeymapX11): Add a
523 modmap to maintain the information which X modifiers map to
525 (get_xkb): Set up the modmap from the XKB tables.
526 (update_keymaps): Set up the modmap from the information returned
527 by XGetModifierMapping in the non-XKB case.
529 * gdk/x11/gdkprivate-x11.h:
530 * gdk/x11/gdkkeys-x11.c (_gdk_keymap_add_virtual_modifiers): New
531 function to set the virtual modifiers in the state.
533 * gdk/x11/gdkevents-x11.c (translate_key_event): Call
534 _gdk_keymap_add_virtual_modifiers here.
536 * gdk/gdktypes.h (GdkModifierType): Add bits for virtual Super,
537 Hyper and Meta modifiers. Also add GDK_ALT_MASK as an alias
540 2005-09-05 Matthias Clasen <mclasen@redhat.com>
542 * gtk/gtkaction.c (connect_proxy): Set the label of a button
543 if it has no child. (#315253, John Finlay)
545 2005-09-02 Matthias Clasen <mclasen@redhat.com>
547 * gtkimcontextsimple.h: Add a modifiers_dropped bit
549 2005-09-02 Matthias Clasen <mclasen@redhat.com>
551 * gtk/gtkentry.c (gtk_entry_destroy): Disconnect idle handlers
552 on destroy to avoid problems when they are called on a destroyed
553 widget. (#315135, John Cupitt)
555 * gtk/gtkentry.c (gtk_entry_class_init):
556 * gtk/gtktextview.c (gtk_text_view_class_init): Add bindings
557 for Ctrl-Shift-A to unselect all. (#309301, Kathy Fernandes)
559 * gtk/gtkimcontextsimple.c: Rework the Unicode hex input
560 code. Now we only steal a single key combination, Ctrl-Shift-U,
562 A hex Unicode sequence must be started with Ctrl-Shift-U, followed
563 by a sequence of hex digits entered with Ctrl-Shift still held.
564 Releasing one of the modifiers or pressing space while the modifiers
565 are still held commits the character. It is possible to erase
566 digits using backspace.
567 As an extension to the above, we also allow to start the sequence
568 with Ctrl-Shift-U, then release the modifiers before typing any
569 digits, and enter the digits without modifiers.
570 (#82011, Owen Taylor)
572 2005-09-02 Matthias Clasen <mclasen@redhat.com>
574 * gtk/gtkmain.c (gtk_get_event_widget): If the window is destroyed,
575 we still need to deliver the destroy event. (#314980, Chris Lahey)
577 * gtk/gtktextview.c (gtk_text_view_key_press_event): Reset
578 im context before committing \n or \t.
580 2005-09-02 Alexander Larsson <alexl@redhat.com>
582 * gtk/gtkfilechooserdefault.c: (shortcuts_add_volumes),
583 (shortcuts_activate_volume):
584 Handle base_path being null in the rest of the cases (#310270)
586 2005-09-02 Tor Lillqvist <tml@novell.com>
588 * gdk/win32/gdkevents-win32.c (gdk_event_translate): Keep track of
589 cursor position also in root window coordinates. Prune out
590 superfluous WM_MOUSEMOVE events even earlier, based on root window
591 coordinates. Windows sends WM_MOUSEMOVE messages after a new
592 window has ben mapped below the cursor even if the mouse doesn't
593 move. We used to generate GDK_MOTION_NOTIFY in these cases. This
594 confused at least gtk_menu_motion_notify(). (#314995)
596 * gtk/gtkintl.h: No need to include config.h here. It caused
597 warnings about GTK_LOCALEDIR being redefined on Win32 when
598 compiling files where gtkintl.h is included after gtkprivate.h
599 (which #undefines and re-#defines GTK_LOCALEDIR on Win32).
601 * gtk/gtkplug.c: Include config.h.
603 2005-09-01 Matthias Clasen <mclasen@redhat.com>
605 * gtk/gtkfilesystemunix.c: Pass statbufs down to
606 xdg_mime_get_mime_type_for_file() where possible, to avoid
609 * gtk/gtkaction.c (gtk_action_get_accel_closure): Fix doc
610 typo. (#314921, Guillaume Cottenceau)
612 * gdk/*.c: Intern some more strings.
614 * gtk/*.c: Define an I_() macro and use it instead of the
615 bulky g_intern_static_string().
617 2005-08-31 Matthias Clasen <mclasen@redhat.com>
619 * gtk/gtkbindings.c (binding_signal_new): Intern the signal name
620 instead of copying it.
622 * gtk/gtktypeutils.c (gtk_identifier_get_type): Some more string interning.
624 * gtk/*.c: Also intern static strings passed to
628 * gtk/Makefile.am: Intern type names in code generated by
633 * gdk/*.c: Intern type names before registering the type to avoid
636 * configure.in: Require GLib 2.9.0
638 2005-08-31 Matthias Clasen <mclasen@redhat.com>
640 * gtk/gtktoolbar.c: Undeprecate gtk_toolbar_set_icon_size(),
641 and add icon-size and icon-size-set properties. (#314172)
643 * gtk/gtkwindow.c (gtk_window_set_transient_for): Inherit window
644 groups across transient parents. (#312918, Christian Persch)
646 * gtk/gtktreemodel.c: Some documentation fixes. (#314882,
647 Guillaume Cottenceau)
649 * gtk/gtktextiter.c (gtk_text_iter_backward_visible_cursor_positions):
650 Fix a typo in the docs. (#314878, Guillaume Cottenceau)
652 2005-08-30 Matthias Clasen <mclasen@redhat.com>
654 * gtk/gtkentry.c (gtk_entry_class_init): Add key bindings to
655 make C-/ select all and C-\ unselect all. (#309301,
658 * gtk/gtkimcontextsimple.c: Change the compose sequence for
659 soft hyphen to be multi_key-minus-minus-space, and add
660 compose sequences multi_key-minus-minus-period and
661 multi_key-minus-minus-minus for en dash and em dash.
662 (#172653, Christian Lohmaier)
664 * gtk/gtkentry.c (gtk_entry_draw_frame): Fix some unused
665 code. (#313946, Christian Persch)
667 * gtk/gtkuimanager.c (gtk_ui_manager_class_init): Another
668 fix for the default value of the "ui" property.
670 2005-08-30 Matthias Clasen <mclasen@redhat.com>
673 * gtk/gtkselection.h:
674 * gtk/gtkselection.c: Add functions which look for text, image
675 or uri targets in an array of atoms. (#314089, Mark Wielaard)
678 * gtk/gtkselection.h:
679 * gtk/gtkselection.c (gtk_selection_data_targets_include_uri):
680 Add a function to check wether targets include uri.
681 (#314092, Mark Wielaard)
685 * gtk/gtkwindow.c: Add a deletable property with getter
686 and setter, to control the close button in the window
687 frame. (#59718, Havoc Pennington)
689 2005-08-29 Matthias Clasen <mclasen@redhat.com>
691 * gtk/gtkrc.key.emacs: Add C-n/C-p/C-f/C-b as alternatives
692 to the arrow keys for menu navigation. (#162825, Carl Worth)
694 * gtk/gtkentry.c, gtk/gtktextview.c: More typo fixes
696 * gtk/gtksocket-x11.c, gtk/gtkstatusicon-x11.c: Fix typos.
698 * gtk/gtkstatusicon-x11.c (gtk_status_icon_new_from_stock):
699 * gtk/gtkimage.c (gtk_image_new_from_stock): Don't
700 refer to nonexisting stock ids.
702 * gtk/gtktextview.c (popup_targets_received):
703 * gtk/gtkentry.c (popup_targets_received): Construct
704 the "Select All" menuitem from stock.
706 * gtk/stock-icons/stock_select_all_{16,24}.png:
707 * gtk/stock-icons/Makefile.am:
708 * gtk/gtkiconfactory.c:
710 * gtk/gtkstock.c: Add a "Select All" stock item. (#78545,
713 * gtk/gtktrayicon.c: Add a pointer to the spec.
715 * gtk/gtkstatusicon-x11.c: Add docs.
717 * gtk/gtkstatusicon.h: Fix a typo.
719 Add a cross-platform "tray icon" API, by
720 porting EggStatusIcon/EggTrayIcon (#105101)
722 * gtk/gtkstatusicon.h: A GtkStatusIcon is an object which
723 displays an icon in a notification area.
725 * gtk/gtkstatusicon-x11.c: GtkStatusIcon implementation for
726 X11, using GtkTrayIcon.
729 * gtk/gtktrayicon.c: An implementation of the freedesktop.org
730 system tray specification, not public API.
732 * gtk/gtk.symbols: Add new exported functions.
734 * gtk/gtk.h: Include gtkstatusicon.h.
736 * gtk/Makefile.am: Add new files.
739 * tests/teststatusicon.c: Test for GtkStatusIcon.
741 2005-08-29 Christopher Aillon <caillon@redhat.com>
743 * gtk/gtkstock.c: Add builtin GtkStockItems for GTK_STOCK_CONNECT
744 and GTK_STOCK_DISCONNECT
746 2005-08-29 Matthias Clasen <mclasen@redhat.com>
748 * gtk/gtksocket-x11.c (_gtk_socket_windowing_embed_notify):
749 Use XFixesChangeSaveSet if available. (#314682)
751 * gtk/gtkmenu.c (gtk_menu_grab_notify): Only cancel if the menu
752 was active. (#314298, Christian Persch, analysis by Mark McLoughlin)
754 2005-08-29 Matthias Clasen <mclasen@redhat.com>
756 * gtk/gtkiconcache.c (_gtk_icon_cache_get_icon): Remove an
757 accidentally leftover duplicate pixbuf creation. (#314700,
760 * gtk/gtksettings.c (settings_update_cursor_theme): Don't
761 leak the cursor theme name. (#314693, Kjartan Maraas)
763 * gdk/x11/gdkasync.c (_gdk_x11_get_window_child_info): Free
764 state.children in all cases. (#313862, Kjartan Maraas)
766 2005-08-28 Matthias Clasen <mclasen@redhat.com>
768 * po/POTFILES.in, po-properties/POTFILES.in:
771 2005-08-27 Matthias Clasen <mclasen@redhat.com>
773 * gtk/gtkuimanager.c (gtk_ui_manager_class_init): Fix the default
774 value of the ui property. (#314532, Yong Wang)
776 * gdk/x11/gdkproperty-x11.c (gdk_property_get): Don't warn
777 when G_MAXLONG is passed as length.
779 2005-08-26 Matthias Clasen <mclasen@redhat.com>
781 * gtk/updateiconcache.c: Add a separate --ignore-theme-index option
782 to avoid overloading --force. (JP Rosevaar)
784 2005-08-26 Matthias Clasen <mclasen@redhat.com>
786 * configure.in: Bump version to 2.9.0
790 * gdk/gdkscreen.c: Make the GdkScreen font options api
791 public, and add properties GdkScreen::font-options and
792 GdkScreen::resolution. (#314004)
796 * gtk/gtkwidget.c: Adjust all callers.
798 * gdk/gdkintl.h: Simplify and use glib/gi18n-lib.h.
799 * gdk/gdkpango.c: Include gdkintl.h, not gtkintl.h.
800 * gdk/gdkscreen.c: Include gdkintl.h.
802 * gtk/gtkicontheme.c (theme_lookup_icon): Avoid an uninitialized
803 variable warning, pointed out by Colin Walters. (#314585)
805 2005-08-26 Tor Lillqvist <tml@novell.com>
807 * gtk/gtkfilesystemwin32.c: Remove some ifdeffed out debugging
809 (gtk_file_system_win32_parse): Don't mishandle UNC paths. (#314519)
811 2005-08-26 Matthias Clasen <mclasen@redhat.com>
813 * gtk/gtkcalendar.c (gtk_calendar_init): Fix the calculation
814 of week_start. (#314473, JP Rosevaar)
816 2005-08-25 Thomas Fitzsimmons <fitzsim@redhat.com>
818 * gtk/gtkfilesystemmodel.c (idle_finished_loading_cb): Acquire GDK
819 lock. (#314533, Thomas Fitzsimmons)
821 2005-08-25 Matthias Clasen <mclasen@redhat.com>
823 * gtk/gtktoolbar.c (_gtk_toolbar_elide_underscores): Handle
824 NULL gracefully. (#314523, Ed Catmur)
826 2005-08-25 Owen Taylor <otaylor@redhat.com>
828 * gdk/x11/gdkcursor-x11.c (gdk_x11_display_set_cursor_theme):
829 Handle theme == NULL.
831 2005-08-25 Matthias Clasen <mclasen@redhat.com>
833 * gtk/gtkmenutoolbutton.c (menu_position_func): Take widget
834 y offset into account when positioning the popup. (#314470,
837 2005-08-25 Owen Taylor <otaylor@redhat.com>
839 * gdk/gdkscreen.c (gdk_screen_get_type): Use gdk_screen_init
840 as instance_init, not base_init! (#314452, Fix from Frederic
841 Crozat, reported by Joe Marcus Clarke). Trivial cleanup: use -1.
842 rather than 1 for a negative flag value.
844 2005-08-24 Owen Taylor <otaylor@redhat.com>
846 * gdk/gdkpango.c (draw_error_underline): Add a note about
847 cut-and-paste between here and Pango.
849 2005-08-24 Matthias Clasen <mclasen@redhat.com>
851 * === Released 2.8.2 ===
853 * gtk/gtkclipboard.c (request_image_received_func): Use the correct
854 callback for image/gif, and also try image/bmp. (#314086, Mark
857 * gtk/gtkfilesystemunix.c (gtk_file_system_unix_volume_render_icon):
858 Use gnome-dev-harddisk for volumes, not gnome-fs-blockdev. (#314382,
863 * gtk/gtksettings.c (gtk_settings_get_for_screen): Make sure font
864 and cursor settings get propagated down to the screen initially.
865 Pointed out by Frederic Crozat.
867 * gtk/gtkicontheme.c (ensure_valid_themes): Don't try to send a client
868 message if the screen is NULL. Noticed by Kjartan Maraas.
870 2005-08-24 Matthias Clasen <mclasen@redhat.com>
874 * === Released 2.8.1 ===
878 2005-08-24 Matthias Clasen <mclasen@redhat.com>
880 * gtk/gtktreemodelfilter.c (gtk_tree_model_filter_visible): Protect
881 against lazy filterers which return values other than TRUE or
882 FALSE from their visible func. (#314335)
884 2005-08-23 Owen Taylor <otaylor@redhat.com>
886 Fix for #314004, reported by Michael Reinsch:
889 * gdk/gdkscreen.[ch]: Add gdk_screen_get/set_font_options_libgtk_only()
890 Add gdk_screen_get/set_resolution_libgtk_only()
892 * gdk/gdkpango.c (gdk_pango_context_get_for_screen): Set
893 the options for the screen on the newly created context.
895 * gtk/gtksettings.c (settings_update_font_options/dpi) gtkwidget.c:
896 Move font options and dpi code from gtkwidget.c to gtksettings.c, set
897 the font options on the screen.
899 * gtk/gtkwidget.c (gtk_widget_update_pango_context): Just get
900 the font options from the screen and set them on the context.
902 2005-08-23 Kristian Rietveld <kris@gtk.org>
904 * gtk/gtktreemodelsort.c (gtk_tree_model_sort_row_inserted): don't
905 bother inserting new rows in a level with a zero refcount and
906 immediately free the level. (Fixes #312350, reported by Markku Vire).
908 2005-08-23 Matthias Clasen <mclasen@redhat.com>
910 * gtk/updateiconcache.c: Complain when there is no index.theme file
911 in the specified directory, unless --force is used. Also add an
912 --index-only option to create caches without image data.
914 * gtk/gtkfilechooserdefault.c (shortcuts_append_desktop): Fix a
915 C99ism. (#314262, Robert Jeff Mitchell)
917 2005-08-22 Manish Singh <yosh@gimp.org>
919 * gtk/gtkicontheme.h: add declaration for _gtk_icon_theme_check_reload.
921 * gtk/gtkwindow.c: remove declaration of gtk_window_read_rcfiles.
923 2005-08-22 Matthias Clasen <mclasen@redhat.com>
925 * gtk/gtkwindow.c (gtk_window_client_event):
926 * gtk/gtkicontheme.c (ensure_valid_themes)
927 (_gtk_icon_theme_check_reload): Implement a clientmessage based
928 scheme for makeing sure that all GTK+ applications notice if an
929 icon theme has been updated. This should prevent multiple versions
930 of an icon theme cache to be mapped in memory at the same time,
931 which can cause excessive memory consumption. (#313156, Chris
934 2005-08-22 Matthias Clasen <mclasen@redhat.com>
936 * gtk/gtkicontheme.c (gtk_icon_theme_load_icon): Add a note
937 regarding icon theme changes.
939 * gtk/gtkiconcache.c (_gtk_icon_cache_get_icon): When returning
940 pixbufs which are backed by the mmapped memory of an icon cache,
941 increase the refcount of the icon cache, so that the memory is not
942 munmapped away underneath the pixbuf upon icon theme changes.
943 (#314170, Kjartan Maraas)
945 * docs/tools/Makefile.am (LDADDS): Add GTK_DEP_LIBS, in order
946 to link against Xext. (#314062)
948 * gtk/gtkhsv.c (paint_triangle): One more fix to prevent buffer
949 overruns. (#314081, Hans Breuer)
951 2005-08-20 Matthias Clasen <mclasen@redhat.com>
953 * gtk/gtkentry.c (gtk_entry_get_layout): Clarify that the
954 returned layout must not be modified.
956 Sat Aug 20 16:12:14 2005 Jonathan Blandford <jrb@redhat.com>
958 * gtk/gtktreeview.c (gtk_tree_view_set_model): clear
959 scroll_to_path if the model changes.
961 * gtk/gtkiconview.c: (gtk_icon_view_destroy),
962 (gtk_icon_view_size_allocate), (gtk_icon_view_set_cursor),
963 (gtk_icon_view_scroll_to_path): Handle scrolling to a path before
964 we're realized, #312798
965 (gtk_icon_view_set_model): clear scroll_to_path if the model
968 2005-08-20 Matthias Clasen <mclasen@redhat.com>
970 * gtk/gtkrange.c (gtk_range_adjustment_changed)
971 (gtk_range_adjustment_value_changed): Don't queue a draw
972 if the layout has not changed. (#313991, Benjamin Berg)
974 2005-08-19 Matthias Clasen <mclasen@redhat.com>
976 * gtk/gtktreeitem.c: Remove duplicate lines. (#313344,
979 * modules/engines/ms-windows/msw_style.c (setup_system_styles):
982 * gtk/gtkfilechooserbutton.c (change_icon_theme)
983 (model_add_special, model_add_special, model_add_volumes):
984 Handle pixbuf being NULL without warnings. Also, don't
985 leak pixbuf references when the icon theme is changed.
987 * gtk/gtkmain.c (gtk_get_event_widget): Don't access
988 the user data on destroyed windows, since at best
989 it can be a stale pointer. (#313953, Robin Green)
991 2005-08-19 Matthias Clasen <mclasen@redhat.com>
993 * gtk/gtkhsv.c (paint_triangle): Avoid a buffer overrun.
994 (#313900, Sebastien Bacher)
996 * gtk/gtktreeview.c (gtk_tree_view_get_visible_range): Return
997 FALSE if the tree is empty. (#313891, Guillaume Cottenceau)
999 * gdk/x11/gdkdnd-x11.c (_gdk_drag_get_protocol_for_display)
1000 (xdnd_read_actions, get_client_window_at_coords_recurse):
1001 Free data returned from XGetWindowProperty.
1003 * gdk/x11/gdkevents-x11.c (fetch_net_wm_check_window)
1004 Free data returned from XGetWindowProperty. (313867, Kjartan
1007 * gdk/x11/gdkdnd-x11.c (get_client_window_at_coords_recurse): Free
1008 children in all cases. (#313862, Kjartan Maraas)
1010 * gtk/gtkicontheme.c (theme_lookup_icon): Store GtkIconData structs
1011 in the per-directory hash, even if they come from the icon cache.
1012 We tried to avoid that before, but as a result leaked icon data
1013 structs. (#313852, Kjartan Maraas)
1015 2005-08-18 Matthias Clasen <mclasen@redhat.com>
1017 * gtk/gtkmenutoolbutton.c (gtk_menu_tool_button_destroy): Disconnect
1018 signal handlers on destroy, not on finalize. (#313759, Brett Atoms)
1020 2005-08-15 Owen Taylor <otaylor@redhat.com>
1022 * configure.in: Add -lXext to GDK_EXTRA_LIBS in absence of pkg-config
1023 files for x11/xext. (Jonas Bonn)
1025 2005-08-15 Tor Lillqvist <tml@novell.com>
1027 * gtk/gtkicontheme.c (theme_lookup_icon): Put debugging printout
1030 2005-08-15 Owen Taylor <otaylor@redhat.com>
1032 * configure.in: Fix have_base_pc / have_base_x_pc typo.
1034 * gdk/x11/gdkdrawable-x11.c gtk/gtksettings.c: Remove panoxft.h includes.
1035 (#313417, James Andrewartha)
1037 * configure.in: Add fontconfig to X_PACKAGES, since we use it for
1038 FcNameConstant(). (More of #313417)
1040 2005-08-15 Matthias Clasen <mclasen@redhat.com>
1042 * gtk/gtkfilechooserdefault.c: When using gtk_dialog_run() for
1043 modal dialogs, make sure to inherit the window group from
1044 the parent, since we don't inherit window groups across
1045 transient parents currently. (#312918, Christian Persch)
1047 * gtk/gtkmessagedialog.c (gtk_message_dialog_new):
1048 * gtk/gtkdialog.c (gtk_dialog_run): Slight update to the docs.
1050 * gtk/gtkiconview.c (gtk_icon_view_select_path)
1051 (gtk_icon_view_scroll_to_path): Handle paths of depth 0
1052 gracefully. (#312796, Jonathan Blandford)
1054 * tests/testtoolbar.c: Add some more tests for menu placement.
1056 * gtk/gtkmenutoolbutton.c (menu_position_func):
1057 * gtk/gtktoolbar.c (menu_position_func): Improve positioning
1058 of toolbutton menus and of the overflow menu. (#312937,
1059 #153870, Christian Persch, Paolo Borelli)
1061 2005-08-15 Tor Lillqvist <tml@novell.com>
1063 * gtk/updateiconcache.c: Use g_path_get_dirname() instead of
1064 the nonportable <libgen.h> and dirname().
1066 2005-08-15 Matthias Clasen <mclasen@redhat.com>
1068 * gtk/gtksizegroup.c: Use object data to mark widgets and
1069 groups as visited, so that we avoid constant extra list
1070 traversals. Also allocate quarks in class_init. (#311618,
1073 * gtk/gtkicontheme.c (gtk_icon_theme_lookup_icon): Correct the
1074 download location for the hicolor icon theme. (#313475, Olexiy
1077 * gtk/gtkicontheme.c: Remove debug spew.
1079 2005-08-15 Owen Taylor <otaylor@redhat.com>
1081 * gdk/linux-fb/gdkwindow-fb.c (gdk_window_set_back_pixmap):
1082 * gdk/win32/gdkwindow-win32.c (gdk_window_set_back_pixmap):
1083 * gdk/x11/gdkwindow-x11.c (gdk_window_set_back_pixmap):
1084 Handle pixmap == NULL when checking for a colormap.
1087 2005-08-14 Matthias Clasen <mclasen@redhat.com>
1089 * gtk/updateiconcache.c: Store only one copy of the pixel data
1090 for symlinked icons. To achieve this, maintain a hashtable
1091 mapping pathnames to pixel data, and share the pixel data for
1092 all symlinks resolving to the same pathname. When writing out
1093 the image data, write out the pixel data only the first time
1094 it is met, and store the offset pointing to the first copy
1095 for use in all later cases.
1096 This reduces the size of the Bluecurve icon cache from 40