1 2004-06-25 Matthias Clasen <mclasen@redhat.com>
3 * gtk/gtkfontbutton.c (gtk_font_button_update_font_info): Avoid
4 a crash if the font doesn't exist. (#144967, Yevgen Muntyan)
6 Fri Jun 25 00:32:15 2004 Matthias Clasen <maclas@gmx.de>
8 * gtk/gtktreestore.c (gtk_tree_store_swap): Commit the change
9 which was mentioned below.
11 Thu Jun 24 23:35:09 2004 Matthias Clasen <maclas@gmx.de>
13 * gtk/gtknotebook.c (gtk_notebook_class_init): Fix a typo,
14 string change. (#139503, Baris Cicek)
16 2004-06-22 Federico Mena Quintero <federico@ximian.com>
18 * gtk/gtkfilechooserdefault.c (location_popup_handler): Use a Save
19 or an Open stock button for the C-l dialog depending on the action
20 in which the file chooser operates. Fixes #141753.
22 2004-06-22 Federico Mena Quintero <federico@ximian.com>
24 Fixes the GTK+ part of #142308:
26 * gtk/gtkfilesystemunix.c (gtk_file_system_unix_filename_to_path):
27 Use filename_to_path().
28 (gtk_file_system_unix_uri_to_path): Likewise.
29 (filename_to_path): Use remove_trailing_slash().
31 2004-06-22 Matthias Clasen <mclasen@redhat.com>
33 * gtk/gtktextview.c (gtk_text_view_class_init): Improve docs
34 for the ::move_cursor signal.
36 * gtk/gtkaccelmap.c (_gtk_accel_path_is_valid): Accept
37 "<WINDOWTYPE>" as a valid accel path. (#144427, Philip
40 * gtk/gtkselection.c (GTK_SELECTION_MAX_SIZE): Make sure
41 this gets defined for all backends, so linux-fb has a
44 * gdk/x11/gdkgc-x11.c:
45 * gdk/gdkgc.c: Move function docs inline, add hints about
46 obtaining rgb colors from gcs. (#144688, Steve Chaplin)
48 * gtk/gtktreestore.c (gtk_tree_store_swap): Make this work
49 for children of the root. (#139785, Jean-François Wauthy,
52 * gtk/gtkicontheme.h (GTK_ICON_THEME_GET_CLASS): Typo
53 fix. (#144750, Jeff Franks)
55 2004-06-21 Michael Natterer <mitch@gimp.org>
58 * gdk/x11/gdkdrawable-x11.[ch]: made convert_format() utility
59 function public as _gdk_x11_convert_to_format().
61 * gdk/x11/gdkcursor-x11.c (create_cursor_image): premultiply
62 the pixels from the GdkPixbuf when putting them in the
63 Xcursor image. Fixes bug #144350.
65 2004-06-16 Federico Mena Quintero <federico@ximian.com>
67 * gtk/gtkfilesystemmodel.c (do_files_added): When inserting a
68 visible node, free the old path before creating the new one.
71 Tue Jun 15 01:10:32 2004 Matthias Clasen <maclas@gmx.de>
73 * gtk/gtkcombobox.c: Make GtkComboBox work without model.
74 (#144198, Mariano Suárez-Alvarez)
76 Fri Jun 11 22:05:56 2004 Matthias Clasen <maclas@gmx.de>
78 * gtk/gtkfilechooserdefault.c: Don't use
79 contractions like "don't" or "isn't" in error messages.
80 It isn't nice to use them in log entries either...
81 (#137774, Morten Welinder, patch by Alexander Winston)
83 2004-06-11 Federico Mena Quintero <federico@ximian.com>
87 * gtk/gtkfilesystemmodel.c (_gtk_file_system_model_add_editable):
88 Don't ref the editable node.
89 (_gtk_file_system_model_remove_editable): Don't unref the editable node.
90 (_gtk_file_system_model_remove_editable): Ahem, free the node.
92 * gtk/gtkfilechooserdefault.c (struct _GtkFileChooserDefault):
93 Added fields for edited_idle and edited_new_text.
94 (renderer_edited_cb): Queue the
95 creation of the folder in an idle handler.
96 (renderer_editing_canceled_cb): Likewise for the cancellation.
97 (gtk_file_chooser_default_finalize): Free the impl->edited_new_text.
99 Thu Jun 10 22:12:26 2004 Matthias Clasen <maclas@gmx.de>
101 * gtk/gtkmain.c (gtk_parse_args): Typo fix.
103 2004-06-10 Federico Mena Quintero <federico@ximian.com>
105 Fixes #144110, patch by Bastien Nocera <hadess@hadess.net>.
107 * gtk/gtkfilechooser.c (gtk_file_chooser_list_shortcut_folders):
108 Refer to gtk_file_chooser_add_shortcut_folder().
109 (gtk_file_chooser_list_shortcut_folder_uris): Refer to
110 gtk_file_chooser_add_shortcut_folder_uri().
112 Thu Jun 10 00:36:15 2004 Matthias Clasen <maclas@gmx.de>
114 * gtk/gtkcalendar.c (gtk_calendar_main_button): Start
115 the drag before focusing the selected.day.
116 * gtk/gtkcalendar.c (gtk_calendar_state_changed): Stop
117 a beginning drag if the widget becomes insensitive.
119 Thu Jun 10 00:09:06 2004 Matthias Clasen <maclas@gmx.de>
121 * gtk/gtkcalendar.c (gtk_calendar_button_press): Start
122 spinning before calling arrow_action(), so that a signal
123 handler triggered from arrow_action() has a chance to
124 stop the spinning. (#143966, Davyd Madeley)
126 Wed Jun 9 23:11:23 2004 Matthias Clasen <maclas@gmx.de>
128 * gtk/gtkstyle.c (_gtk_style_init_for_settings): Fix a
129 typo. (#144070, Kent Sandvik)
131 Thu Jun 10 00:22:51 2004 Soeren Sandmann <sandmann@daimi.au.dk>
133 * gtk/gtkmenu.c: Revert the "drag select" part of
136 Mon Jun 7 23:07:40 2004 Matthias Clasen <maclas@gmx.de>
138 * gtk/gtkcombobox.c (gtk_combo_box_remeasure): Handle
139 priv->model being NULL. (#143856, Mariano Suárez-Alvarez)
141 2004-06-07 Federico Mena Quintero <federico@ximian.com>
143 * gtk/gtktreeview.c (gtk_tree_view_button_press): Revert the patch
144 from 2003/Sep/12. This kept DnD in tree views within modal
145 dialogs from working, which is especially bad for the file
146 chooser. Fixes #135168.
148 Sun Jun 6 23:57:21 2004 Matthias Clasen <maclas@gmx.de>
150 Make the entry context menu work in editable text cells. The changes
151 are based on a patch by Kristian Rietveld, which implemented an
152 approach outlined by Owen Taylor. (#50075)
154 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_focus_out_event):
155 Ignore focus out if the entry menu is posted.
156 (gtk_cell_renderer_text_populate_popup): Mark the entry menu as
157 posted, and set up a signal handler to clear the flag if the menu
159 (gtk_cell_renderer_text_popup_unmap): Clear the in_entry_menu flag,
160 set up a timeout to stop editing if the focus is lost.
161 (popdown_timeout): Stop editing if the entry doesn't have focus anymore.
162 (gtk_cell_renderer_text_start_editing): Connect to the populate_popup
163 signal on the entry and keep a pointer to the entry.
164 (gtk_cell_renderer_text_editing_done): Disconnect from popuplate_popup,
165 clear the pointer to the entry.
167 Sun Jun 6 23:24:43 2004 Matthias Clasen <maclas@gmx.de>
169 * gtk/gtktexttag.c (gtk_text_tag_class_init): Improve the description
170 of the ::language property. (#143802, Owen Taylor)
172 Sat Jun 5 23:07:30 2004 Matthias Clasen <maclas@gmx.de>
174 * gtk/gtkentrycompletion.c: (gtk_entry_completion_init),
175 (gtk_entry_completion_list_enter_notify),
176 (gtk_entry_completion_list_motion_notify),
177 (_gtk_entry_completion_popup), (_gtk_entry_completion_popdown):
178 * gtk/gtkentryprivate.h: Add an ignore_enter flag and
179 use it as in the menu code to avoid the initial selection if
180 the window pops up under the pointer. (Anders Carlsson)
182 Sat Jun 5 20:05:39 2004 Soeren Sandmann <sandmann@daimi.au.dk>
184 * tests/testmerge.c: Add a checkbox to queue an
185 merge/unmerge. Patch from Matthias Clasen.
187 * gtk/gtktoolbar.c (struct _GtkToolbarPrivate): Add a new flag
189 (rebuild_menu): New function that rebuilds the overflow menu and
190 makes sure it doesn't start or end with a separator.
191 (toolbar_content_new_tool_item)
192 (toolbar_content_remove)
193 (toolbar_content_new_compatibility): Set the rebuild_needed flag
194 (gtk_toolbar_size_allocate): Only show the overflow arrow when we
195 have actually overflown an item with a proxy menu item. Also make
196 sure we rebuild the menu if needed.
198 Fix #125504, #142377, #143463
200 * gtk/gtkseparatortoolitem.c (gtk_separator_tool_item_expose):
201 Obey the "priv->draw" flag. (#143692)
203 2004-06-04 Matthias Clasen <mclasen@redhat.com>
205 * docs/widget_geometry.txt: Add a note about the !CAN_FOCUS
206 quirk in the button size allocation code.
208 * gtk/gtkbutton.c (gtk_button_size_allocate): Give the space
209 requested for drawing the focus indicator to the child in the
210 !CAN_FOCUS case. This should fix issues which the Gimp has with
211 the button allocation changes in 2.4.2.
213 Thu Jun 3 21:17:29 2004 Matthias Clasen <maclas@gmx.de>
215 * gtk/gtkentry.c (gtk_entry_completion_timeout): Calculate the
216 length of the entry contents in characters, not in bytes.
218 * gtk/gtkentry.c (paste_received): Don't pop up the completion
219 window on paste, noticed by Anders Carlsson.
221 Thu Jun 3 20:56:19 2004 Matthias Clasen <maclas@gmx.de>
223 * gtk/gtkcombobox.c (gtk_combo_box_class_init): Fix the allowed
224 values and default value for the ::active property. (#143669,
227 2004-06-03 Michael Natterer <mitch@gimp.org>
229 * gtk/gtkimagemenuitem.c: use gtk_widget_get_child_requisition()
230 instead of accessing item->image->allocation.width/height
231 directly. Makes widgets which only have a requisition set using
232 gtk_widget_set_size_request() work and fixes bug #142789.
234 Thu Jun 3 08:07:59 2004 Soeren Sandmann <sandmann@daimi.au.dk>
236 * gtk/gtkmenu.c: Revert previous commit. It caused the problem
237 of sticky right click menus to return.
239 Wed Jun 2 01:56:02 2004 Soeren Sandmann <sandmann@daimi.au.dk>
241 * gtk/gtkmenu.c: Fix the stay up algorithm for combo boxes to
242 better handle the "click" case. bug Better fix for #141169.
244 2004-06-02 Federico Mena Quintero <federico@ximian.com>
246 * gtk/gtktreeview.c (gtk_tree_view_search_init): Bail out if the
247 model is empty. Fixes #143536.
249 2004-06-02 Matthias Clasen <mclasen@redhat.com>
251 * gtk/gtkfontsel.c (gtk_font_selection_size_focus_out): Don't
252 close the dialog on focus out of the size entry. (#143505,
255 2004-06-02 Federico Mena Quintero <federico@ximian.com>
259 * gtk/fnmatch.c (_gtk_fnmatch): Take a no_leading_period argument.
260 (gtk_fnmatch_intern): Likewise; also implement this option.
262 * gtk/gtkprivate.h (_gtk_fnmatch): Updated prototype.
264 * gtk/gtkfilesel.c (find_completion_dir): Pass TRUE for the
265 no_leading_period argument of _gtk_fnmatch().
266 (attempt_file_completion): Likewise.
268 * gtk/gtkfilefilter.c (gtk_file_filter_filter): Pass FALSE for the
269 no_leading_period argument of _gtk_fnmatch().
271 Wed Jun 2 00:47:11 2004 Matthias Clasen <maclas@gmx.de>
273 * gtk/gtkselection.c (_gtk_selection_request): Remove leftover
276 Wed Jun 2 00:13:57 2004 Matthias Clasen <maclas@gmx.de>
278 * gtk/gtktreeselection.c (gtk_tree_selection_select_range): Don't
279 allow unless selection mode is multiple. (#142634, John Finlay)
281 Tue Jun 1 23:00:20 2004 Matthias Clasen <maclas@gmx.de>
285 * gtk/gtkentrycompletion.h:
286 * gtk/gtkentrycompletion.c:
288 * gtk/gtkcombobox.c: Rename function parameters from
289 index to index_ to prevent clash with BSD index(). (#143001)
291 Tue Jun 1 22:45:42 2004 Matthias Clasen <maclas@gmx.de>
293 * gtk/gtkmenu.c (get_accel_path): Handle accel_closure being
294 NULL on an accel label. (#139641, Sam Stephenson, patch by
297 Tue Jun 1 22:19:55 2004 Matthias Clasen <maclas@gmx.de>
299 * gtk/gtkicontheme.c (theme_subdir_load): Prevent icon
300 lookup finding icons in the wrong prefix. (#143328,
303 Wed Jun 2 00:39:58 2004 Soeren Sandmann <sandmann@daimi.au.dk>
307 * gtk/gtkmenushell.c (gtk_menu_shell_button_release): Make menus
308 only stay up if you release within 500 milliseconds.
309 (gtk_menu_shell_button_press): Set the activate_time to the event
310 time when a button is pressed.
312 * gtk/gtkmenu.c (gtk_menu_motion_notify, gtk_menu_enter_notify):
313 Interprete button releases as activate when we have seen both an
314 enter an a motion event.
316 2004-06-01 Federico Mena Quintero <federico@ximian.com>
318 * gtk/gtkfilesystemmodel.c (do_files_removed): Don't insert a
319 dummy node if there is no parent node. Fixes #143362.
321 2004-05-31 Federico Mena Quintero <federico@ximian.com>
323 * gtk/gtkfilechooserdefault.c (renderer_edited_cb): Change to the
324 newly-created folder. Fixes #138932.
325 (trap_activate_cb): Only return TRUE if we did handle the event.
326 Fixes #143359; patch by jylefort@brutele.be.
328 Mon May 31 02:39:32 2004 Matthias Clasen <maclas@gmx.de>
330 * gtk/gtkimage.c (gtk_image_new_from_pixmap): Fix typo in
331 docs. (#142892, Tommi Komulainen)
333 Mon May 31 02:16:37 2004 Matthias Clasen <maclas@gmx.de>
335 * gtk/gtkhandlebox.c: Make detached handleboxes work when their
336 parent is minimized, porting the fix from 1.2. (#1923, #57182)
338 Mon May 31 02:03:17 2004 Matthias Clasen <maclas@gmx.de>
340 * gtk/gtkwindow.c (gtk_window_show): Make moving realized,
341 unmapped windows work.
343 Mon May 31 00:27:33 2004 Matthias Clasen <maclas@gmx.de>
345 * gtk/gtkfilechooserutils.c (_gtk_file_chooser_set_delegate): Fix
348 Mon May 31 00:23:55 2004 Matthias Clasen <maclas@gmx.de>
350 * gtk/gtkfilechooser.c (gtk_file_chooser_set_preview_widget):
351 Refer to ::update-preview, not ::selection-changed.
353 2004-05-29 Christian Rose <menthos@menthos.com>
355 * configure.in: Added "tk" to ALL_LINGUAS.
357 Fri May 28 15:00:01 2004 Matthias Clasen <maclas@gmx.de>
359 * gtk/gtkwidget.c (gtk_widget_set_parent): Add informative
360 messages for common problems. (#137974, Owen Taylor)
362 Fri May 28 14:20:17 2004 Matthias Clasen <maclas@gmx.de>
364 * gdk/x11/gdkevents-x11.c: Fix off-by-one allocation
365 errors. (#143337, Billy Biggs)
367 Thu May 27 16:36:22 2004 Owen Taylor <otaylor@redhat.com>
369 * gdk/x11/gdkcolor-x11.c (gdk_colormap_alloc_colors): Set
370 bits within visual->depth that aren't used for color to
371 1s, in case they are alpha.
373 2004-05-27 Anders Carlsson <andersca@gnome.org>
375 * gtk/gtkfilechooserdefault.c (save_folder_combo_create):
376 Make separator rows insensitive.
378 Thu May 27 00:48:16 2004 Matthias Clasen <maclas@gmx.de>
380 * gtk/gtkentrycompletion.c (gtk_entry_completion_set_text_column):
383 Thu May 27 00:45:07 2004 Matthias Clasen <maclas@gmx.de>
385 * gtk/gtkentrycompletion.h:
386 * gtk/gtkentrycompletion.c (gtk_entry_completion_get_text_column):
387 Getter for text_column. Also make ::text_column a property.
389 Thu May 27 00:11:01 2004 Matthias Clasen <maclas@gmx.de>
391 * gtk/gtkmenuitem.c (gtk_menu_item_size_request): Fix a typo.
393 Thu May 27 00:07:47 2004 Jonathan Blandford <jrb@gnome.org>
395 * gtk/gtkcombobox.c (gtk_combo_box_list_destroy): only remove the
396 signal if the box exists.
398 Wed May 26 23:26:51 2004 Matthias Clasen <maclas@gmx.de>
400 Support insensitive cells in tree views and combo boxes:
402 * gtk/gtkcellrenderer.h:
403 * gtk/gtkcellrenderer.c: Add a ::sensitive property.
405 * gtk/gtkcellrendererpixbuf.c (gtk_cell_renderer_pixbuf_render):
406 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_render):
407 * gtk/gtkcellrenderertoggle.c (gtk_cell_renderer_toggle_render):
408 Support drawing insensitive.
411 * gtk/gtkcellview.c (gtk_cell_view_get_cell_renderers): New
412 function to obtain the cell renderers from a cell view. Also
413 export gtk_cell_view_set_cell_data().
415 * gtk/gtktreeselection.c (tree_column_is_sensitive):
416 * gtk/gtktreeselection.c (row_is_selectable): Helper functions
417 to determine whether all visible cells in a row are insensitive
418 and whether a row is selectable. A row is not selectable if the
419 user function says so or if all visible cells are insensitive.
420 * gtk/gtktreeselection.c (_gtk_tree_selection_internal_select_node):
421 * gtk/gtktreeselection.c (gtk_tree_selection_real_select_node):
422 Use row_is_selectable().
424 * gtk/gtkcombobox.c (row_is_sensitive):
425 * gtk/gtkcombobox.c (tree_column_row_is_sensitive):
426 * gtk/gtkcombobox.c (menu_row_is_sensitive): Helper functions
427 to determine row sensitivity in menu or list mode.
429 * gtk/gtkcombobox.c (update_menu_sensitivity): Helper function
430 to set up sensitivity menu items from the underlying rows.
432 * gtk/gtkcombobox.c (gtk_combo_box_popup):
433 * gtk/gtkcombobox.c (gtk_combo_box_menu_button_press): Use
434 update_menu_sensitivity().
436 * gtk/gtkcombobox.c (gtk_combo_box_list_setup): Setup the cell
439 * gtk/gtkcombobox.c (gtk_combo_box_key_press): Skip insensitive
442 * tests/testcombo.c (main): Make some rows insensitive.
444 2004-05-26 Robert Ögren <gtk@roboros.com>
446 * gdk/win32/gdkinput-win32.c (_gdk_input_other_event): Send key
447 modifiers (shift, ctrl etc) in button and motion events from the
450 2004-05-26 Robert Ögren <gtk@roboros.com>
452 * gdk/win32/gdkinput-win32.c (gdk_device_get_state): Simple
453 implementation for extended input devices using last known
454 device state (#143237)
456 Tue May 25 21:54:00 2004 Matthias Clasen <maclas@gmx.de>
458 * gtk/gtkframe.c: Move docs inline, fixing them on the
459 way. (#143029, Steve Chaplin)
461 2004-05-11 Robert Ögren <gtk@roboros.com>
463 * gdk/win32/gdkevents-win32.c (propagate): Don't propagate mouse
464 events to windows that want extended input events. (#142943)
465 (gdk_event_translate): Move check for extended input devices to
466 propagate, new parameter to propagate.
467 (gdk_pointer_grab, gdk_display_pointer_ungrab): Enable calls to
468 _gdk_input_(un)grab_pointer. (#142943)
470 * gdk/win32/gdkinput-win32.c (_gdk_input_other_event): Check for
471 input grab. [Fix missing update of impl in "dijkstra" event
472 propagation loop] Drop the parallel "impl" pointer, just use a
473 cast. Don't propagate beyond windows that want normal input
475 (gdk_input_grab_pointer, gdk_input_ungrab_pointer): Limited
476 implementation of input grab. (#142943)
478 2004-05-22 Tor Lillqvist <tml@iki.fi>
480 * gdk/win32/gdkinput-win32.c (print_lc): Remove duplicated
481 line. (Spotted by Benoît Carpentier.)
483 2004-05-18 Matthias Clasen <mclasen@redhat.com>
485 * configure.in: Check for XFIXES extension.
487 * gdk/x11/gdkdisplay-x11.h (struct _GdkDisplayX11): Add
488 a gboolean have_xfixes member.
490 * gdk/x11/gdkdisplay-x11.c (gdk_display_open): Register
491 XFIXES events and set have_xfixes.
493 * gdk/gdkevents.h (GdkEventType): Add GDK_OWNER_CHANGE.
494 (GdkEventOwnerChange): New event struct for owner change events.
495 (GdkOwnerChange): New enum for the reason field of GdkEventOwnerChange.
497 * gdk/x11/gdkevents-x11.c (gdk_event_translate): Translate
498 XFixesSelectionNotify events into GdkEventOwnerChange events.
501 * gdk/x11/gdkdisplay-x11.c (gdk_display_supports_selection_notification):
502 (gdk_display_request_selection_notification): New api
503 to support selection ownership notification.
505 * gtk/gtkclipboard.h:
506 * gtk/gtkclipboard.c (_gtk_clipboard_handle_event): New private
507 api to handle owner change events.
508 (clipboard_peek): Refactored out the body of
509 gtk_clipboard_get_for_display() for use in _gtk_clipboard_handle_event().
511 * gtk/gtkmain.c (gtk_main_do_event): Handle GDK_OWNER_CHANGE events
512 by calling _gtk_clipboard_handle_event().
514 2004-05-18 Matthias Clasen <mclasen@redhat.com>
516 * gtk/gtkintl.h: Include glib/gi18n-lib.h and only define
517 the P_() macros ourselves.
519 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
520 Restrict the width of the popup to be no larger than the
521 monitor. (#142678, DmD Ljungmark)
523 * gtk/gtkbutton.c: Go back to the initial fix for the
524 focus-overdrawing problem, which was actually correct
525 according to docs/widget_geometry.txt.
527 * gtk/gtkarrow.c (gtk_arrow_class_init): Bump the initial
528 arrow size from 11 to 15 to compensate for that.
530 * gtk/gtktextview.c (gtk_text_view_class_init): Document the
531 arguments of the ::move-cursor signal. (#142725)
533 2004-05-17 Matthias Clasen <mclasen@redhat.com>
537 * gtk/gtkbutton.c (gtk_button_size_request)
538 (gtk_button_size_allocate, _gtk_button_paint): Allocate
539 space for the focus rectangle only if necessary. (#142668,
542 Sun May 16 23:11:47 2004 Matthias Clasen <maclas@gmx.de>
546 * gtk/gtkhruler.c (gtk_hruler_draw_ticks): Remove two useless
547 lines. (#142479, Morten Welinder)
549 Sun May 16 22:27:17 2004 Matthias Clasen <maclas@gmx.de>
551 * gtk/gtkintl.h (Q_): Add a Q_() macro.
553 * gtk/gtkcellrendererprogress.h: Remove GTK_PROGRESS_CELL_UNKNOWN
554 and GTK_PROGRESS_CELL_FAILED. With the ability the set the label,
555 they are not really needed.
557 * gtk/gtkcellrendererprogress.c: Use the xpad and ypad properties
558 instead of hardwired padding, use Q_() for the default label,
559 compute a reasonable minimal size. (#142571, #142572, #142573,
560 Tommi Komulainen, Christian Persch)
562 2004-05-15 Tor Lillqvist <tml@iki.fi>
564 * gdk/win32/gdkdnd-win32.c: Put back the ref_count field in the
565 GdkDragContextPrivateWin32 struct (but inside ifdef OLE2_DND this
566 time). It is used by the OLE2_DND code, which is unfinished and
567 presumably horribly broken, but still, let's not make it not
568 compile on purpose. Silence some gcc warnings in the OLE2_DND
571 2004-05-14 Matthias Clasen <mclasen@redhat.com>
573 * gtk/gtktreeview.c (gtk_tree_view_tree_window_to_tree_coords):
574 New function to go from tree window to tree coordinates, kept
575 static for now until we figure out the multiple coordinate
576 system mess in GtkTreeView API-wise.
577 (gtk_tree_view_scroll_to_cell): Transform the coordinates
578 from tree window to tree coordinates, using the new function.
579 Previously, the x coordinate was wrongly transformed. (#142494)
581 * gdk/gdktypes.h (GdkModifierType): Add a comment about unused
584 * gtk/gtkstock.c (real_add, gtk_stock_lookup): Use an unused
585 modifier bit to mark stock item which need to be freed
586 eventually. (#140654, Michal Pasternak, Scott Tsai)
588 2004-05-11 Robert Ögren <gtk@roboros.com>
590 * gdk/win32/gdkevents-win32.c (gdk_event_translate): Add missing
591 call to g_object_ref in Wintab code. (#138341)
593 * gdk/win32/gdkinput-win32.c: Fix numerous Wintab problems
594 including unallocated buffers for event->motion.axes and
595 event->button.axes, unsigned wraparound problem in the code for
596 detecting missing press/release events and assigning min instead
597 of max when setting up axes.
599 2004-05-12 Matthias Clasen <mclasen@redhat.com>
601 * tests/testtreeedit.c: Add a progress column.
603 * gtk/Makefile.am: Add gtkcellrendererprogress.[hc] in the right
606 * gtk/gtk.h: Include gtkcellrendererprogress.h.
608 * gtk/gtkcellrendererprogress.[hc]: A progress cell renderer,
609 based on the one found in Epiphany.
611 2004-05-11 Michael Natterer <mitch@gimp.org>
613 * gtk/gtkcombobox.c (gtk_combo_box_popup)
614 (gtk_combo_box_menu_button_press): don't allocate the popup
615 smaller than the combobox. Fixes bug #59660.
617 2004-05-11 Matthias Clasen <mclasen@redhat.com>
619 * gtk/gtkuimanager.c (gtk_ui_manager_get_widget): Revert the
620 previous change to this function, clarify the docs instead.
622 * gtk/gtkcombobox.c (gtk_combo_box_list_setup): Use
623 GTK_SELECTION_BROWSE.
625 * gtk/gtktreeview.c: Make hover selection work for
626 GTK_SELECTION_BROWSE as well.
628 Tue May 11 00:38:25 2004 Matthias Clasen <maclas@gmx.de>
630 * gtk/gtkcellrenderertoggle.c (gtk_cell_renderer_toggle_class_init):
631 Document the ::toggled signal.
633 Mon May 10 23:04:25 2004 Soeren Sandmann <sandmann@daimi.au.dk>
635 * gtk/gtkwidget.h: Add prototype for _gtk_widget_grab_notify()
637 2004-05-10 Matthias Clasen <mclasen@redhat.com>
639 * gtk/gtkwindow.c (get_screen_icon_info): Make static.
641 * gdk/gdkdisplay.c (singlehead_...):
642 * gdk/x11/gdkkeys-x11.c (get_effective_keymap):
643 * gdk/x11/gdkgeometry-x11.c (expose_serial_predicate):
644 * gdk/x11/gdkdisplay-x11.c (escape_for_xmessage): Make static.
646 * gtk/gtktreeview.c (gtk_tree_view_set_fixed_height_mode): Add a
647 note about COLUMN_FIXED restriction.
649 * gtk/gtkentrycompletion.c (gtk_entry_completion_list_button_press):
650 Set the entry in the default handler of the ::match-selected signal.
653 * gtk/gtkcombobox.c (gtk_combo_box_menu_position_below): If we don't
654 do the move-selected-item below pointer thingie, do the
655 place-below-or-above one.
657 * tests/testentrycompletion.c: Make the second example use the
658 ::match-selected signal to make it actually work.
660 * gtk/gtkentrycompletion.c (gtk_entry_completion_init):
661 * gtk/gtkcombobox.c (gtk_combo_box_list_setup): Use hover selection
662 mode. (#127648, Dave Bordoley)
665 * gtk/gtktreeview.c: Add a new property "hover_selection", which
666 when TRUE makes the selection follow the mouse. Also add setter
667 and getter for the fixed_height property.
669 2004-05-10 Matthias Clasen <mclasen@redhat.com>
671 * gtk/gtkcombobox.c (gtk_combo_box_popup)
672 (gtk_combo_box_menu_button_press): Make sure the menu pops up
673 as wide as the combobox. (#59660, Havoc Pennington)
675 2004-05-10 Matthias Clasen <mclasen@redhat.com>
678 * gtk/gtkcombobox.c: Support tearoffable combo boxes (in menu
679 mode). Add a new property, add-tearoffs, for this. (#135956)
681 * gtk/gtkfontsel.c (list_row_activated): Make Return activate the
682 default button. (#118921)
684 Mon May 10 15:03:50 2004 Soeren Sandmann <sandmann@daimi.au.dk>
686 * gtk/gtkwidget.c (_gtk_widget_grab_notify): New internal function
687 that emits the grab notify signal.
689 * gtk/gtkmain.c (gtk_grab_notify_foreach): Use it here.
691 Mon May 10 00:48:08 2004 Matthias Clasen <maclas@gmx.de>
693 * gtk/gtkmenu.c: Make destruction of a torn off menu work
696 Sun May 9 21:05:38 2004 Matthias Clasen <maclas@gmx.de>
700 * gtk/gtkactiongroup.c (gtk_action_group_add_action_with_accel):
701 Allow to suppress the stock accelerator by using "". (#142196,
704 Sun May 9 02:01:13 2004 Matthias Clasen <maclas@gmx.de>
708 * gtk/gtkcombobox.c (gtk_combo_box_list_button_released):
709 In list mode, accept the same mouse/wheel bindings on
710 the cellview as on the button. (#136967)
712 Sun May 9 01:25:37 2004 Matthias Clasen <maclas@gmx.de>
714 * gtk/gtkiconfactory.c (add_to_cache): Actually count the
715 cached icons. (#135888, Crispin Flowerday)
717 Sun May 9 00:03:03 2004 Matthias Clasen <maclas@gmx.de>
719 * gtk/gtkuimanager.c (gtk_ui_manager_get_widget): Make sure
720 that we actually return menus for nodes of type menu, not the
721 menuitems they're attached to.
723 Sat May 8 22:50:55 2004 Matthias Clasen <maclas@gmx.de>
725 * gtk/gtkactiongroup.c (gtk_action_group_set_translation_domain):
726 Add a note regarding UTF-8 requirements, proposed by
727 Mariano Suárez-Alvarez.
729 Sat May 8 22:43:11 2004 Matthias Clasen <maclas@gmx.de>
731 * gtk/gtktearoffmenuitem.h:
732 * gtk/gtktearoffmenuitem.c: Put the torn_off flag back
733 into the GtkTearoffMenuItem struct, since it is used
734 by the Gimp, and keep it synchronized with the
735 tearoff_state property of the parent menu.
737 2004-05-08 Hans Breuer <hans@breuer.org>
739 * gtk/gtkfilesystemwin32.c (extract_icon) : finally also
740 create the correct mask for 'pseudo mime' icons
742 * gdk/win32/gdkwindow-win32.c(show_window_internal) : also
743 take focus_on_map into account
745 * gtk/gtkselection.c : g_message() only with DEBUG_SELECTION
747 * gtk/gtkactiongroup.c gtk/gtkcombobox.c :
748 ... must return a value
750 * gdk/gdk.def gtk/gtk.def demos/gtk-demo/makefile.msc.in : updated
752 2004-05-07 Matthias Clasen <mclasen@redhat.com>
754 * gtk/gtkbutton.c (gtk_button_size_allocate): Don't let the child
755 draw over the focus rectangle.
757 * gtk/gtkhsv.c: Draw focus indication in the color wheel using
758 standard focus style. (#63071, Bill Haneman, idea for new
759 style by Owen Taylor)
761 * gtk/gtkstyle.c (gtk_default_draw_focus): Support drawing on
762 focus on the colorwheel via details.
764 2004-05-06 Matthias Clasen <mclasen@redhat.com>
768 * gtk/gtkcombobox.c (gtk_combo_box_menu_state_changed): Remove
769 this no longer needed signal handler. (#141817, Paul Pogonyshev)
771 Fri May 7 00:41:46 2004 Matthias Clasen <maclas@gmx.de>
773 * gtk/gtktearoffmenuitem.h:
774 * gtk/gtktearoffmenuitem.c: Make the tearoff
775 functionality model/view, the tearoffmenuitem being
776 the view and the tearoff_state property of the menu
777 being the model. (#101185, Owen Taylor)
779 * gtk/gtkmenu.c: Add a tearoff_state property.
781 Thu May 6 23:52:13 2004 Matthias Clasen <maclas@gmx.de>
785 * gtk/gtkmenuitem.c (gtk_menu_item_select_timeout): Also
786 popup the submenu for items in torn off menus. (#122051)
788 2004-05-06 Sven Neumann <sven@gimp.org>
790 * gtk/gtkexpander.c (gtk_expander_size_allocate): in RTL mode,
791 position the title lable next to the arrow just as we do for LTR
792 rendering. Fixes bug #141825.
794 2004-05-06 Matthias Clasen <mclasen@redhat.com>
796 * docs/RELEASE-HOWTO: Document the new policy of
797 bumping version numbers after release.
799 * configure.in: Bump version number to 2.5.0.
801 2004-05-06 Padraig O'Briain <padraig.obriain@sun.com>
804 * gtk/gtkmenu.c: Add new function gtk_menu_get_for_attach_widget.
807 Thu May 6 00:24:11 2004 Matthias Clasen <maclas@gmx.de>
809 * gtk/gtkactiongroup.h:
810 * gtk/gtkactiongroup.c (gtk_action_group_translate_string):
811 New function to translate a string with translate_func.
814 Thu May 6 00:02:21 2004 Matthias Clasen <maclas@gmx.de>
816 * gtk/gtkcombobox.c (gtk_combo_box_get_wrap_width):
817 (gtk_combo_box_get_row_span_column):
818 (gtk_combo_box_get_column_span_column): Add missing getters
819 for readwrite properies. (#135649)
821 Wed May 5 23:42:42 2004 Matthias Clasen <maclas@gmx.de>
824 * gtk/gtkcombobox.c (gtk_combo_box_get_active_text):
825 Add gtk_combo_box_get_active_text() convenience
826 function. (#136372, Christian Neumeir, patch by Olivier Andrieu)
828 2004-05-05 Elijah Newren <newren@math.utah.edu>
830 Changes to support do-not-focus-on-map hint in conjunction with
831 _NET_WM_USER_TIME (#115650):
833 * gdk/gdkwindow.h (struct _GdkWindowObject): Add a new boolean
836 * gdk/gdkwindow.h (gdk_window_set_accept_focus): New function to
839 * gtk/gtkwindow.[hc]: Add a boolean property "focus_on_map"
840 and gtk_window_get_focus_on_map() and gtk_window_set_focus_on_map().
842 * gdk/win32/gdkwindow-win32.c (gdk_window_new):
843 * gdk/linux-fb/gdkwindow-fb.c (gdk_window_new):
844 * gdk/x11/gdkwindow-x11.c (gdk_window_new):
845 Initialize the focus_on_map field to TRUE.
847 * gdk/win32/gdkwindow-win32.c (gdk_window_set_focus_on_map):
848 * gdk/linux-fb/gdkwindow-fb.c (gdk_window_set_focus_on_map):
849 * gdk/x11/gdkwindow-x11.c (gdk_window_set_focus_on_map):
850 * gdk/x11/gdkwindow-x11.c (setup_toplevel_window):
851 Implementations for the various backends. The Win32 and linux-fb
852 implementations set the focus_on_map field, but don't use it yet
853 to actually implement noinput windows. The X implementation sets
854 _NET_WM_USER_TIME to 0 if focus_on_map is FALSE (see the EWMH).
856 * gdk/x11/gdkwindow-x11.h:
857 * gdk/x11/gdkevents-x11.c (set_user_time):
858 * gdk/x11/gdkinput-x11.c (_gdk_input_common_other_event):
859 * gdk/x11/gdkwindow-x11.c (gdk_x11_window_set_user_time):
860 s/_gdk_x11_window_set_user_time/gdk_x11_window_set_user_time/,
861 since we want that function to be part of the public API.
863 Wed May 5 22:20:21 2004 Matthias Clasen <maclas@gmx.de>
867 * gtk/gtkiconfactory.c (icon_source_clear): Don't
868 call g_free() on a pixbuf. (#141961, Crispin Flowerday)
870 2004-05-05 Matthias Clasen <mclasen@redhat.com>
874 * gtk/gtkuimanager.c (print_node): Make the output
875 parseable. (#141929, Sven Neumann)
877 2004-05-05 Tor Lillqvist <tml@iki.fi>
879 * gdk/win32/gdkdnd-win32.c (gdk_drag_find_window_for_screen): Add
880 multi-monitor offset. (#141842, John Ehresman)
882 2004-05-04 Federico Mena Quintero <federico@ximian.com>
884 Fixes #139562, based on a patch by Christian Neumair.
886 * gtk/gtkfilechooserdefault.c (struct _GtkFileChooserDefault): Add
887 a filter_combo_hbox field to contain the filter combo.
888 (show_filters): Show/hide the filter_combo_hbox.
889 (create_filename_entry_and_filter_combo): Removed.
890 (file_pane_create): Create the filter_combo_hbox here.
892 2004-05-04 Matthias Clasen <mclasen@redhat.com>
894 * modules/input/gtkimcontextxim.c: Fix the recent
895 string_conversion_callback change to work on
896 Solaris. (#141190, Padraig O'Briain)
898 * gtk/gtkselection.c: Disable debug logging again.
900 2004-05-03 Matthias Clasen <mclasen@redhat.com>
902 * gtk/gtkselection.c: Make the chunk size for
903 incremental transfers depend on the maximal request
904 size, capped at 256k. This should allow most selections
905 to be transferred nonincrementally, avoiding many
906 roundtrips and protocol overhead.
908 2004-05-03 Federico Mena Quintero <federico@ximian.com>
910 * gtk/gtkuimanager.c (gtk_ui_manager_class_init): Call
911 g_signal_new() correctly and initialize the signal fields. Fixes
912 #141749; patch based on Michael Natterer's.
914 u2004-05-03 Matthias Clasen <mclasen@redhat.com>
916 * gtk/gtkselection.c (_gtk_selection_request): Fix
917 a debug message to show correct information.
918 (_gtk_selection_incr_event): Make INCRemental transfer
919 of MULTIPLE targets work. This was broken since 1997!
921 2004-05-02 Hans Breuer <hans@breuer.org>
923 * gdk/win32/gdkdrawable-win32.c (draw_segments) : don't
924 modify the passed in GdkSegment(s) in place, we may get
925 them again to draw at the same place. Fixes bug #129095,
927 (draw_segments) draw the end pixel again to get the
928 pixmap mask right, fixes bug #126710, #130202
930 * gdk/win32/gdkwindow-win32.c : use SetForegroundWindow,
931 fixes bug #106013, John Ehresman
933 * gtk/makefile.msc.in : don't try to link gtk.res but
934 use gtk-win32.res (as supposed to be fixed below :)
936 2004-05-01 Hans Breuer <hans@breuer.org>
938 * tests/Makefile.am : tests/makefile.msc is in CVS for
939 a long time, finally added to EXTRA_DIST : fixes bug
940 #141334, John Ehresman
942 2004-04-30 Matthias Clasen <mclasen@redhat.com>
944 * === Released 2.4.1 ===
946 * configure.in: Version 2.4.1, interface age 1.
950 2004-04-29 Federico Mena Quintero <federico@ximian.com>
954 * gtk/gtkfilechooserdefault.c (remove_selected_bookmarks): New
955 function; moved the code over from
956 remove_bookmark_button_clicked_cb().
957 (remove_selected_bookmarks): Now, getting a non-removable bookmark
958 is not an error, as we may be called as a result of hitting the
960 (shortcuts_key_press_event_cb): New handler; delete the bookmark
961 if the user presses Backspace, Delete, or KP_Delete.
963 2004-04-29 Matthias Clasen <mclasen@redhat.com>
965 * gtk/gtkaction.c (closure_accel_activate): Use
966 _gtk_action_emit_activate() instead of directly
967 emitting the activate signal. (#141429, Jody Goldberg)
969 * gtk/gtkactiongroup.c (gtk_action_group_add_action_with_accel):
970 Warn people when the accelerator can not be
971 parsed. (#141429, Jody Goldberg)
973 2004-04-29 Matthias Clasen <mclasen@redhat.com>
975 * tests/testentrycompletion.c (main): Add a missing
976 cat. (#141070, Chris Sherlock)
978 * gtk/gtkrc.c (gtk_rc_check_pixmap_dir): Remove unused
979 variable. (#141022, Chris Sherlock)
981 * gtk/gtkcombo.c (gtk_combo_popup_list): Add a missing
982 cast. (#141013, Chris Sherlock)
984 * gtk/gtkcellview.c (gtk_cell_view_cell_layout_clear): Remove
985 unused variable. (#141011, Chris Sherlock)
987 2004-04-29 Tor Lillqvist <tml@iki.fi>
989 * gdk/win32/gdkgc-win32.c (gdk_win32_gc_set_dashes): Plug memory
990 leak. (#140775, John Ehresman)
992 Thu Apr 29 01:09:50 2004 Matthias Clasen <maclas@gmx.de>
994 * gdk/gdkdraw.c (_gdk_drawable_get_scratch_gc): Use depth - 1
995 to index the cached gcs, not depth. (#139494)
997 2004-04-28 Matthias Clasen <mclasen@redhat.com>
999 * gdk/gdkdraw.c (_gdk_drawable_get_scratch_gc): Docs typo fix.
1001 Sun Apr 25 15:36:02 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1003 * gtk/gtktoolbutton.c (gtk_tool_button_set_label_widget): Fix
1004 cut'n'paste-o from previous commit. (#141046, Torsten Schoenfeld).
1006 2004-04-24 Theppitak Karoonboonyanan <thep@linux.thai.net>
1008 Patch to add support for string conversion callbacks to
1009 GtkIMContextXIM (#101814)
1011 * modules/input/gtkimcontextxim.c: Set the string conversion callback
1012 if supported by the XIC.
1014 (struct _GtkIMContextXIM): Add string_conversion_callback member.
1016 (struct _GtkXIMInfo, setup_im): Check and keep flag inidicating
1017 whether string conversion callback is supported.
1019 (gtk_im_context_get_ic, +set_string_conversion_callback,
1020 +string_conversion_callback): Also initialize string conversion
1021 callback, if supported, along with the IC initialization.
1023 * modules/input/imxim.c: Make "xim" module default for Thai as well.
1025 2004-04-23 Matthias Clasen <mclasen@redhat.com>
1027 * gtk/gtkclipboard.c (gtk_clipboard_wait_for_targets): Correctly
1028 initialize targets. (#139883, John Finlay)
1030 * gdk/gdkdraw.c (gdk_draw_drawable): Small doc improvement.
1032 * gtk/gtktreeselection.c (gtk_tree_selection_get_selected_rows):
1033 Don't recommend gtk_tree_row_reference_new_proxy(). (#138309,
1036 * gtk/gtktreeviewcolumn.c (gtk_tree_view_column_cell_set_cell_data):
1037 Remove an excessive g_return_if_fail().
1039 * gdk/x11/gdkevents-x11.c (set_user_time): Make set_user_time()
1041 * gdk/x11/gdkinput-x11.c (_gdk_input_common_other_event):
1042 _-prefix calls of gdk_x11_window_set_user_time().
1044 2004-04-22 Matthias Clasen <mclasen@redhat.com>
1046 * gtk/gtkuimanager.c (update_node): Make sure the separators
1047 used to demarkate placeholder ends don't show up on
1048 show_all(). (#140496, Murray Cumming)
1050 * gtk/gtkspinbutton.c (spin_button_at_limit): Make spinbuttons
1051 work with negative increments. (#137975, Tim Gerla)
1053 Wed Apr 21 21:38:03 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1055 * gtk/gtktoolbutton.c (gtk_tool_button_set_label_widget,
1056 gtk_tool_button_set_icon_widget): Remove the old widget from the
1057 tool button before overwriting it with the new widget.
1059 (#140508, Todd Goyen)
1061 2004-04-22 Tor Lillqvist <tml@iki.fi>
1063 Fix the file chooser on Windows. I can't make it misbehave or
1064 crash any more now. But presumably there are still corner cases
1065 not handled. I haven't really checked behaviour of UNC paths, for
1068 * gtk/gtkfilesystemwin32.c: Accept both backslash and slash in
1069 several places. Use G_IS_DIR_SEPARATOR macro (which could be added
1072 (gtk_file_system_win32_get_parent): Like the Unix version, assert
1073 filename is absolute, and avoid one unnecessary string allocation
1076 (canonicalize_filename,gtk_file_system_win32_parse): Handle drive
1077 letters more correctly.
1079 (gtk_file_system_win32_render_icon): Assure correct syntax is used
1080 for root folder of a drive. (#137962, Morten Welinder)
1082 (filename_is_some_root): New function that accepts also root
1083 without any drive specified.
1085 (filename_is_drive_root): Rename from filename_is_root.
1087 * gtk/gtkfilechooserentry.c (completion_match_func): Casefold on
1090 2004-04-21 Matthias Clasen <mclasen@redhat.com>
1092 * gtk/gtkentry.c (gtk_entry_completion_timeout): Pop down the
1093 completion window if there are no completions anymore.
1095 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
1096 Don't call gtk_tree_view_scroll_to_cell() on an empty tree view.
1097 It doesn't like that. (#140642, Christian Persch)
1099 * demos/gtk-demo/expander.c (do_expander): A new demo.
1101 * demos/gtk-demo/Makefile.am (demos): Add expander.c.
1103 2004-04-20 Matthias Clasen <mclasen@redhat.com>
1105 * gtk/gtktextview.c (gtk_text_view_allocate_children): Make
1106 sure anchored children get size allocated, even if the layout
1107 is valid. (#122323, Andrew E. Makeev)
1108 (gtk_text_view_scroll_pages):
1109 (gtk_text_view_scroll_hpages): Don't scroll to cursor position
1110 if we already have pending scrolls. Bandaid fix for #78513.
1112 Mon Apr 19 17:59:17 2004 Owen Taylor <otaylor@redhat.com>
1114 * INSTALL.in: Update libpng and libjpeg URLs, remove
1115 note about building without since that's not the normal
1118 Sun Apr 11 09:45:11 2004 Owen Taylor <otaylor@redhat.com>
1120 * gtk/gtkicontheme.c (load_themes): Fix a couple of typos in
1121 handling of SVG/non-SVG unthemed icons.
1123 2004-04-19 Morten Welinder <terra@gnome.org>
1125 * gtk/gtktoolbar.c (gtk_toolbar_focus): Don't leak list of
1128 2004-04-19 Matthias Clasen <mclasen@redhat.com>
1130 * gtk/gtktextbtree.c (_gtk_text_line_previous_could_contain_tag):
1131 Don't stop the iteration up to the tag_root too
1132 early. (#109945, Dongho Shin)
1134 Sun Apr 18 17:06:03 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1136 * gdk/x11/gdkkeys-x11.c (get_effective_keymap): Make
1137 gdk_keymap_translate_keyboard_state() handle NULL
1138 keymaps. (#139715, Torsten Schoenfeld).
1140 Sun Apr 18 16:59:21 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1142 * configure.in: Don't erase GDK_EXTRA_CFLAGS. Fixes bug 139586,
1143 reported by Pedro RODRIGUEZ, about compilation problems when
1144 Xcursor is installed in a non-standard location.
1146 Sun Apr 18 16:15:15 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1148 Support for _NET_WM_USER_TIME (bug 115650). Patch by Elijah
1151 * gdk/x11/gdkwindow-x11.[ch]: Add new internal function
1152 _gdk_x11_set_user_time() to set the _NET_WM_USER_TIME property.
1154 * gdk/x11/gdkdisplay-x11.h (struct _GdkDisplayX11): Add user_time field
1156 * gdk/x11/gdkdisplay-x11.c: Add _NET_WM_USER_TIME to list of
1159 * gdk/x11/gdkinput-x11.c, gdk/x11/gdkevents-x11.c: Set the
1160 property on user interaction.
1162 2004-04-15 Federico Mena Quintero <federico@ximian.com>
1164 * gtk/gtkfilesel.c (open_new_dir): Tell the user to use
1165 G_FILENAME_ENCODING, not G_BROKEN_FILENAMES. Fixes #114065.
1167 * gtk/gtkfilechooserdefault.c (split_uris): Use a variant of the
1168 code from gtkfilesel.c to parse a "text/uri-list" blob. Fixes
1171 2004-04-15 Matthias Clasen <mclasen@redhat.com>
1173 * gtk/gtkcellrenderer.c (gtk_cell_renderer_class_init):
1174 * gtk/gtkbutton.c (gtk_button_class_init): Doc fixes.
1176 2004-04-14 Matthias Clasen <mclasen@redhat.com>
1178 * gtk/gtkcombobox.c:
1180 Make all style properties readonly.
1182 2004-04-14 Matthias Clasen <mclasen@redhat.com>
1184 * gtk/gtkcolorsel.c: Add a11y relations between the color
1185 wheel and the spin buttons. (#132745, Padraig O'Briain)
1187 * gtk/gtkiconfactory.c (gtk_icon_set_render_icon): Document
1188 the meaning of size == -1.
1190 * gtk/gtkwidget.c (gtk_widget_render_icon): Explicitly accept
1191 a size of -1. (#137436, Brian Cameron)
1193 * gtk/gtkcombobox.c: Make the arrow and separator regular
1194 children of an hbox inside the button, and propagate state
1195 changes from the button to the cell view. (part of the fix
1196 for #138650, should also fix #137535)
1198 * gtk/gtkcellview.c (gtk_cell_view_expose): Pass the PRELIT
1199 state to gtk_cell_renderer_render() when prelighted. (part
1200 of the fix for #138650)
1202 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_render):
1203 Use PRELIGHT state when appropriate. (part of the fix for
1206 * gtk/gtkcombobox.c (gtk_combo_box_relayout): Don't spit
1207 out warnings if called before the combo box is
1208 realized. (#139742, Philip Langdale)
1210 Wed Apr 14 03:45:39 2004 Jonathan Blandford <jrb@gnome.org>
1212 * gtk/gtktreeview.c (gtk_tree_view_expose): propagate expose
1215 Wed Apr 14 03:32:58 2004 Jonathan Blandford <jrb@gnome.org>
1217 * gtk/gtkpathbar.c (make_directory_button): remove spurious
1220 Tue Apr 13 16:19:23 2004 Jonathan Blandford <jrb@redhat.com>
1222 * gtk/gtkpathbar.c (make_directory_button): patch from Owen to
1223 make the buttons sized by a bold label. This makes the text
1224 'swim' a little, but stops the buttons from resizing, #137210
1226 2004-04-13 Matthias Clasen <mclasen@redhat.com>
1228 * gtk/gtkuimanager.c (get_child_node): Don't crash if a node
1230 (start_element_handler): Accept separators without unique
1231 names. (#133302, Anders Carlsson)
1233 * gtk/gtkactiongroup.c (gtk_action_group_add_action): Document
1234 possible accelerator gotcha when using this function. (#139641,
1237 * gtk/gtkuimanager.c (node_remove_ui_reference): Don't leak
1238 list nodes. (#138862, Morten Welinder)
1240 Tue Apr 13 12:24:49 2004 Jonathan Blandford <jrb@redhat.com>
1242 * gtk/gtktreeview.c (gtk_tree_view_destroy): remove unused
1244 (gtk_tree_view_button_press): If we activated the row we don't
1245 want to grab focus back, as moving focus to another widget is
1246 pretty common, #138458
1248 2004-04-12 Federico Mena Quintero <federico@ximian.com>
1250 * gtk/gtkfilechooser.c (gtk_file_chooser_class_init): Added
1251 documentation to all the signals.
1253 2004-04-12 Matthias Clasen <mclasen@dhcp64-228.boston.redhat.com>
1255 * gtk/gtkcombobox.c (gtk_combo_box_unset_model): Don't unref
1256 model if it is NULL. (#139770)
1258 * gtk/gtktreeview.c (gtk_tree_view_get_cell_area): Typo fix.
1260 * gtk/gtkentrycompletion.c (gtk_entry_completion_init): Don't add
1261 a shadow inside the scrolled window, add it around the vbox.
1263 * gtk/gtkentryprivate.h:
1264 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
1265 Return a boolean indicating whether the popup is positioned above
1266 or below. Scroll the completions to the beginning or the end,
1267 depending on the positioning.
1269 * gtk/gtkentry.c (gtk_entry_completion_key_press): Make keynav
1270 wrap around in the entry completion popup, and allow GDK_UP to
1271 enter the popup. (#137440)
1273 2004-04-12 Matthias Clasen <mclasen@redhat.com>
1275 * gtk/gtkentry.c (gtk_entry_size_request): Make sure the style is
1276 there before using it.
1278 Sun Apr 11 15:08:45 2004 Jonathan Blandford <jrb@gnome.org>
1280 * gtk/gtktreeprivate.h: Moved search entries into priv data.
1282 * gtk/gtktreeview.c: Prep for type-ahead support.
1284 (gtk_tree_view_destroy): Destroy the search window explicitly.
1285 (gtk_tree_view_key_press): Minor change; prep for type-ahead
1286 (gtk_tree_view_ensure_interactive_directory): New function
1287 (gtk_tree_view_focus_out): Rework to handle new entry life-cycle.
1288 (gtk_tree_view_real_start_interactive_search): rework
1289 (gtk_tree_view_search_dialog_hide): ditto
1290 (gtk_tree_view_search_delete_event): ditto
1291 (gtk_tree_view_search_button_press_event): ditto
1292 (gtk_tree_view_search_key_press_event): ditto
1293 (gtk_tree_view_search_move): ditto
1294 (gtk_tree_view_search_init): ditto
1296 * gtk/gtktreeviewcolumn.c:
1297 (gtk_tree_view_column_cell_layout_clear): remove unused variable.
1299 * tests/testfilechooser.c: (main): change
1301 2004-04-11 Hans Breuer <hans@breuer.org>
1303 * gdk/win32/gdkspawn-win32.c : workaround for bug #137496,
1304 the real fix would involve just another small API breakage,
1305 i.e. gdk_spawn_* using GPid not just gint.
1307 * gtk/makefile.msc.in : build gtk-win32.res, not gtk.res
1309 2004-04-10 Tor Lillqvist <tml@iki.fi>
1311 * gdk/win32/gdkkeys-win32.c (gdk_keymap_translate_keyboard_state):
1312 If both Shift and CapsLock pressed, ignore the shift only for
1313 letters (that would have been affected by the CapsLock). (#139095)
1315 * gdk/win32/gdkglobals-win32.c: Disable tablet support by default,
1316 seems to be even buggier now than it used to be. (#138341)
1317 Initialize _gdk_input_ignore_wintab to TRUE.
1319 * gdk/win32/gdkmain-win32.c: Add --use-wintab switch and
1320 GDK_USE_WINTAB environment variable to turn on tablet support.
1322 2004-04-09 Christian Persch <chpe@cvs.gnome.org>
1324 * gtk/gtkuimanager.c: (gtk_ui_manager_insert_action_group),
1325 (gtk_ui_manager_remove_action_group): Terminate
1326 g_object_[dis]connect() calls with NULL instead of 0.
1329 2004-04-09 Guntupalli Karunakar <karunakar@freedomink.org>
1331 * configure.in: Added "gu" (Gujarati) to ALL_LINGUAS.
1333 2004-04-07 Federico Mena Quintero <federico@ximian.com>
1337 * gtk/gtkfilesystem.c (gtk_file_system_parse): Ensure that the
1338 passed-in 'str' is not NULL.
1340 * gtk/gtkfilesystemunix.c (expand_tilde): New helper function;
1341 expands "~/" or "~foo/" at the beginning of a filename.
1342 (gtk_file_system_unix_parse): Use expand_tilde() before doing
1345 * gtk/gtkfilechooserentry.c
1346 (gtk_file_chooser_entry_maybe_update_directory): Take in a
1347 force_reload argument.
1348 (gtk_file_chooser_entry_changed): If gtk_file_system_parse()
1349 returns an error, set the file_part_pos to -1.
1350 (load_directory_callback): Only populate the model if the
1351 file_part_pos is not -1.
1353 2004-04-06 Pablo Saratxaga <pablo@mandrakesoft.com>
1355 * configure.in: Added Icelandic (is) to ALL_LINGUAS
1357 2004-04-05 Federico Mena Quintero <federico@ximian.com>
1359 * gtk/gtkfilechooserdefault.c (location_popup_handler): Use a
1360 title for SAVE and CREATE_FOLDER modes. Fixes #137272.
1362 * gtk/gtkfilesystemunix.c (gtk_file_system_unix_make_path): Look
1363 for G_DIR_SEPARATOR in the display_name, and err out if it is
1364 present; use the same error message as Nautilus. Fixes #136467.
1366 * gtk/gtkfilechooserdefault.c (file_pane_create): Make the
1367 new-folder button say "Create Fo_lder" rather than "Create
1368 _Folder", so that the mnemonic doesn't conflict with the "Save in
1369 _folder" label. Fixes #136975.
1371 2004-04-05 Federico Mena Quintero <federico@ximian.com>
1373 * gtk/gtkpathbar.c (_gtk_path_bar_set_path): Ref/sink the
1374 buttons. Also, free them correctly upon failure. Based on a
1375 patch by Morten Welinder, fixes #137956.
1377 2004-04-05 Anders Carlsson <andersca@gnome.org>
1379 * gdk/gdk.c (gdk_arg_context_parse): Handle '--' correctly.
1381 Fri Apr 2 17:57:33 2004 Jonathan Blandford <jrb@redhat.com>
1383 * gtk/gtktreeview.c (gtk_tree_view_row_inserted): set the height
1384 correctly for fixed height when inserting a node, #138082
1386 2004-04-01 Federico Mena Quintero <federico@ximian.com>
1390 * gtk/gtkpathbar.h (struct _GtkPathBarClass): Add a
1391 "child_is_hidden" boolean argument to the "path-clicked" signal.
1393 * gtk/gtkpathbar.c (struct _ButtonData): Added a file_is_hidden
1395 (make_directory_button): Take a file_is_hidden argument; put it in
1397 (_gtk_path_bar_set_path): See whether each path component path is
1399 (gtk_path_bar_class_init): Add the file_is_hidden argument to the
1400 "path-clicked" signal.
1401 (button_clicked_cb): See if the downwards button represents a
1402 hidden file for the file_is_hidden argument in the signal
1405 * gtk/gtkmarshalers.list: Added a signal type VOID:POINTER,BOOLEAN.
1407 * gtk/gtkfilechooserdefault.c
1408 (gtk_file_chooser_default_select_path): If we fail to switch
1409 folders, don't try to select the path in the file system model.
1410 Also, return the result from _gtk_file_system_model_path_do().
1411 (gtk_file_chooser_default_select_path): Turn on show_hidden in the
1412 file system model if we are asked to select a hidden file.
1413 (path_bar_clicked): Show hidden files based on whether the
1414 immediate downwards folder in the path bar is a hidden file
1416 (struct _GtkFileChooserDefault): Added fields
1417 browse_files_popup_menu and browse_files_popup_menu_hidden_files_item.
1418 (create_file_list): Set an object data key of
1419 "GtkFileChooserDefault" on the tree view so that we can find the
1420 impl from the popup menu callbacks. Also, hook up to the
1421 "button-press-event" and "popup-menu" signals in the file list to
1422 bring up a popup menu.
1423 (list_popup_menu_cb): New callback.
1424 (list_button_press_event_cb): New callback.
1428 * gtk/gtkfilesystemmodel.c
1429 (_gtk_file_system_model_new): Oops, connect_object to
1432 2004-03-31 Tor Lillqvist <tml@iki.fi>
1434 * configure.in: Move AC_CANONICAL_HOST earlier, before the check
1435 for native Win32. (#136559, J. Ali Harlow)
1437 * gdk/win32/gdkdrawable-win32.c (draw_arc): Use X11 semantics for
1438 angles. Thanks to Tim Newsham.
1440 2004-03-29 Federico Mena Quintero <federico@ximian.com>
1444 * gtk/gtkfilesystem.h (struct _GtkFileFolderIface): Added slots
1445 for an ::is_finished_loading() method and a ::finished_loading()
1446 signal at the end of the struct.
1448 * gtk/gtkfilesystem.c (gtk_file_folder_base_init): Create the
1449 "finished-loading" signal.
1450 (gtk_file_folder_is_finished_loading): New function.
1452 * gtk/gtkfilesystemunix.c
1453 (gtk_file_folder_unix_is_finished_loading): Implement.
1455 * gtk/gtkfilesystemmodel.c (struct _GtkFileSystemModelClass): New
1456 slot for a "finished-loading" signal.
1457 (gtk_file_system_model_class_init): Create the "finished-loading"
1459 (struct _GtkFileSystemModel): New field
1460 idle_finished_loading_source. We emit the "finished-loading"
1461 signal in an idle if the root folder was done loading right in
1462 _gtk_file_system_model_new(), so that the caller has a chance to
1463 connect to the signal.
1464 (_gtk_file_system_model_new): Connect to the normal signals of the
1465 folder even if the initial _list_children() fails. Also, see if
1466 the folder is finished loading; connect to the "finished-loading"
1468 (gtk_file_system_model_finalize): Remove the idle handler.
1470 * gtk/gtkfilechooserdefault.c (set_list_model): Set a busy cursor
1471 and connect to the model's "finished-loading" signal.
1472 (get_toplevel): New helper function.
1473 (error_message): Use get_toplevel().
1474 (trap_activate_cb): Likewise.
1475 (location_popup_handler): Likewise.
1476 (set_busy_cursor): New function.
1477 (browse_files_model_finished_loading_cb): New callback.
1479 2004-03-25 Federico Mena Quintero <federico@ximian.com>
1481 * gtk/gtkfilechooserdefault.c (check_preview_change): Just use the
1482 file under the cursor; we don't need the logic from
1483 GtkFileSelection after all. Fixes #132255.
1485 2004-03-25 Federico Mena Quintero <federico@ximian.com>
1487 * gtk/gtkfilechooserdefault.c (location_entry_create): Fill the
1488 location entry with the display name of the file under the cursor
1489 for Open mode, or the typed filename in Save mode.
1491 2004-03-24 J. Ali Harlow <ali@juiblex.co.uk>
1493 * gtk/gtkfilesystemwin32.c
1494 (filename_is_root): Bare drive designators (eg., "c:") are
1495 no longer considered as root filenames. Fixed #137942
1497 2004-03-24 J. Ali Harlow <ali@juiblex.co.uk>
1499 * gtk/gtkfilesystemwin32.c
1500 (gtk_file_system_win32_create_folder): Invert test for error in
1501 mkdir. Fixes #137945
1503 2004-03-24 J. Ali Harlow <ali@juiblex.co.uk>
1505 Fixed #138004 using Federico's code from #132327.
1507 * gtk/gtkfilesystemwin32.c (struct _GtkFileSystemWin32): Add a
1508 folder_hash field to keep a list of live folder objects.
1509 (gtk_file_system_win32_init): Create the folder_hash.
1510 (gtk_file_system_win32_finalize): Destroy the folder_hash.
1511 (gtk_file_system_win32_get_folder): Ref and return an existing
1512 folder if we have it around, otherwise return a new folder object.
1513 (struct _GtkFileFolderWin32): Add a field for the parent file system.
1514 (gtk_file_folder_win32_finalize): Remove the folder from the file
1515 system's hash table.
1516 (gtk_file_system_win32_create_folder): Emit "files-added" on the
1517 newly-created folder's parent. Fixes #138004.
1519 2004-03-24 J. Ali Harlow <ali@juiblex.co.uk>
1521 * gtk/gtkfilesystemwin32.c
1522 (gtk_file_system_win32_get_folder): Test that path is actually
1523 a directory and throw error if not. Fixed bug #137950
1525 2004-03-22 J. Ali Harlow <ali@juiblex.co.uk>
1527 * gtk/gtkfilesystemwin32.c
1528 (gtk_file_system_win32_volume_get_display_name): Ignore empty
1529 volume labels; assume that GetVolumeInformation would fail if
1530 GetVolumeInformationW does; catches a small memory leak;
1531 pass the buffer size to GetVolumeInformationW in wide
1532 characters instead of bytes. Fixes bug #137543
1533 (list_volumes): Cope with the theoretical possibility of
1534 more than 26 logical drives. Fixes bug #137940
1535 (bookmarks_serialize): Now actually removes bookmarks.
1538 2004-03-22 Guntupalli Karunakar <karunakar@freedomink.org>
1540 * configure.in: Added "pa" (Punjabi) to ALL_LINGUAS.
1542 2004-03-21 Tor Lillqvist <tml@iki.fi>
1544 * gtk/gtkfilesystemwin32.c
1545 (gtk_file_system_win32_volume_get_base_path): Include the
1546 backslash. Otherwise gtk_file_system_win32_path_to_uri() returns
1547 NULL for a volume base path, as g_filename_to_uri() requires an
1548 absolute path, and just a drive letter and colon isn't. (#137543)
1550 2004-03-20 Hans Breuer <hans@breuer.org>
1552 * gtk/gtkfilesystemwin32.c : applied the undisputable and
1553 required [due to recent gtkfilesystem internal api semantic
1554 changes] part of patches to fix bug #137543 (Tor Lillqvist,
1557 * gdk/gdkevents-win32.c (handle_configure_event) :
1558 (gdk_event_translate), WM_WINDOWPOSCHANGED : initialize
1559 GdkWindowObject::x, y with screen coords to make
1560 gdk_window_get_position () return the right thing and thus fix
1561 drag and drop positioning (e.g. Gimp tabs, fixes bug #137192)
1563 2004-03-19 Federico Mena Quintero <federico@ximian.com>
1565 * Revert the patch to #137520, as 2.4.1 is for conservative bug
1566 fixes only. The patch is attached to the bug report, for
1569 2004-03-19 Morten Welinder <terra@gnome.org>
1571 * gtk/gtkfilechooserdefault.c
1572 (gtk_file_chooser_default_set_current_folder): Test existance of
1573 the path after checking for locality, if needed.
1575 2004-03-19 Federico Mena Quintero <federico@ximian.com>
1579 * gtk/gtkfilesystem.h (struct _GtkFileFolderIface): Added slots
1580 for an ::is_finished_loading() method and a ::finished_loading()
1581 signal at the end of the struct.
1583 * gtk/gtkfilesystem.c (gtk_file_folder_base_init): Create the
1584 "finished-loading" signal.
1585 (gtk_file_folder_is_finished_loading): New function.
1587 * gtk/gtkfilesystemunix.c
1588 (gtk_file_folder_unix_is_finished_loading): Implement.
1590 * gtk/gtkfilesystemmodel.c (struct _GtkFileSystemModelClass): New
1591 slot for a "finished-loading" signal.
1592 (gtk_file_system_model_class_init): Create the "finished-loading"
1594 (struct _GtkFileSystemModel): New field
1595 idle_finished_loading_source. We emit the "finished-loading"
1596 signal in an idle if the root folder was done loading right in
1597 _gtk_file_system_model_new(), so that the caller has a chance to
1598 connect to the signal.
1599 (_gtk_file_system_model_new): Connect to the normal signals of the
1600 folder even if the initial _list_children() fails. Also, see if
1601 the folder is finished loading; connect to the "finished-loading"
1603 (gtk_file_system_model_finalize): Remove the idle handler.
1605 * gtk/gtkfilechooserdefault.c (set_list_model): Set a busy cursor
1606 and connect to the model's "finished-loading" signal.
1607 (get_toplevel): New helper function.
1608 (error_message): Use get_toplevel().
1609 (trap_activate_cb): Likewise.
1610 (location_popup_handler): Likewise.
1611 (set_busy_cursor): New function.
1612 (browse_files_model_finished_loading_cb): New callback.
1614 Thu Mar 18 12:10:45 2004 Owen Taylor <otaylor@redhat.com>
1616 * gtk/gtktreeitem.c (gtk_tree_item_forall): Include
1617 eventbox for expander. (#137564, reported by
1620 2004-03-18 Guntupalli Karunakar <karunakar@freedomink.org>
1622 * mr.po: Added "mr" for Marathi to ALL_LINGUAS.
1624 2004-03-17 Morten Welinder <terra@gnome.org>
1626 * gtk/gtkfilechooserdefault.c (shortcuts_add_volumes): Free
1627 volumes not actually put into the shortcut list.
1629 * tests/prop-editor.c (object_changed): Plug leak.
1631 * tests/testfilechooser.c (main): Plug some leaks and expose
1634 * tests/prop-editor.c (create_prop_editor): Don't leak the tooltip
1635 object. Fixed #136652.
1637 * gtk/gtkfilechooserdefault.c (check_icon_theme): Do nothing if we
1638 have no screen. Fixes #137260.
1639 (shortcuts_add_bookmark_from_path): Simplify using check_is_folder
1640 thereby fixing leak. Fixes #137259.
1642 * gtk/gtkpathbar.c (gtk_path_bar_forall): Make this work when the
1643 slider buttons have been destroyed.
1644 (gtk_path_bar_remove): Make this work for slider buttons too.
1647 2004-03-15 Morten Welinder <terra@gnome.org>
1649 * gtk/gtkfilechooserdefault.c (shortcuts_add_bookmark_from_path):
1650 Sanitize and plug leak.
1651 (check_icon_theme): Only do something if the widget has a screen.
1653 Wed Mar 17 01:20:28 2004 Matthias Clasen <maclas@gmx.de>
1655 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
1656 Move the repositioning logic from _gtk_entry_completion() popup
1657 over here. Fixes #137355, reported by Niklas Knutsson.