1 Fri Jul 23 10:28:43 2004 Matthias Clasen <maclas@gmx.de>
3 * gtk/gtktreeview.c (gtk_tree_view_finalize):
4 * gtk/gtkradioaction.c (gtk_radio_action_finalize):
5 * gtk/gtkfontsel.c (gtk_font_selection_finalize):
6 * gtk/gtkcellview.c (gtk_cell_view_finalize):
7 * gtk/gtkcalendar.c (gtk_calendar_finalize):
8 * gtk/gtkactiongroup.c (gtk_action_group_finalize): Remove
9 unnecessary checks. (#148175, Morten Welinder)
11 Thu Jul 22 01:42:16 2004 Matthias Clasen <maclas@gmx.de>
13 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_class_init):
14 Add a new :ellipsize property which controls ellipsization of the
15 rendered text. (#144835, Vincent Untz, patch by Jonathan Blandford
18 * gtk/gtkfilechooserdefault.c (create_file_list): Use ellipsization
21 Thu Jul 22 01:21:28 2004 Matthias Clasen <maclas@gmx.de>
23 * gtk/gtkfontsel.c (gtk_font_selection_init): Add additional
24 accessability relations. (#141804, Padraig O'Briain)
26 Thu Jul 22 01:16:23 2004 Matthias Clasen <maclas@gmx.de>
28 * gtk/gtkcombobox.c: Avoid some warnings.
30 Thu Jul 22 01:05:16 2004 Matthias Clasen <maclas@gmx.de>
32 * configure.in: Require Pango 1.5.1 (for ellipsisation).
35 * gtk/gtklabel.c (gtk_label_class_init): Add a new :ellipsize
36 property which controls ellipsization of the label. (#125250,
37 Tim Van Wassenhove, patch by James M. Cape)
39 * tests/testellipsise.c: Simple test for ellipsizsation.
41 Wed Jul 21 22:46:27 2004 Matthias Clasen <maclas@gmx.de>
43 * gtk/gtkcombobox.c (gtk_combo_box_new_text): Don't leak the
44 list store. (#148134, Crispin Flowerday)
46 Wed Jul 21 22:35:47 2004 Matthias Clasen <maclas@gmx.de>
48 * gtk/gtkcombobox.c (gtk_combo_box_destroy): Don't leak the
49 menu. (#148110, Tommi Komulainen)
51 Wed Jul 21 22:24:10 2004 Matthias Clasen <maclas@gmx.de>
53 * gtk/gtkcellview.c (gtk_cell_view_finalize): Don't leak
54 tree model and tree row reference. (#148125, Crispin Flowerday)
56 Wed Jul 21 22:17:06 2004 Matthias Clasen <maclas@gmx.de>
58 * tests/testcombo.c (main): Don't leak models. (#148128,
61 Wed Jul 21 21:26:08 2004 Matthias Clasen <maclas@gmx.de>
63 * gtk/gtkviewport.c (viewport_set_adjustment): Don't leak
64 the adjustments. (#148089, Tommi Komulainen)
66 Wed Jul 21 21:20:21 2004 Matthias Clasen <maclas@gmx.de>
68 * gtk/gtktreeview.c (gtk_tree_view_destroy): Don't leak
69 the adjustments. (#148073, Tommi Komulainen)
71 Wed Jul 21 21:04:50 2004 Matthias Clasen <maclas@gmx.de>
73 * gtk/gtktoolbar.c (gtk_toolbar_finalize): Don't leak the
74 arrow. (#148064, Tommi Komulainen)
76 2004-07-21 Matthias Clasen <mclasen@redhat.com>
78 * gtk/gtkcalendar.c: Use the new text target functionality
79 in GtkTargetList instead of hardcoding a subset of text targets.
81 Tue Jul 20 23:11:23 2004 Matthias Clasen <maclas@gmx.de>
83 * gdk/x11/gdkevents-x11.c: Hook up gtk-menu-bar-accel to
84 an XSetting, Gtk/MenuBarAccel. (#120859, Scott James Remnant)
86 Tue Jul 20 22:26:29 2004 Matthias Clasen <maclas@gmx.de>
88 * gtk/gtkfilechooserutils.h:
89 * gtk/gtktoolbutton.c:
93 * demos/gtk-demo/ui_manager.c:
94 * demos/gtk-demo/appwindow.c: Remove trailing commas
95 from enumerations. (#148035)
97 2004-07-20 Federico Mena Quintero <federico@ximian.com>
99 * gtk/gtkcellrenderer.c (gtk_cell_renderer_class_init): Fix the
100 documentation comment for the editing-started signal.
102 * gtk/gtkmarshalers.list: Added VOID:OBJECT,STRING for
103 GtkCellRenderer::editing-started.
105 2004-07-20 Matthias Clasen <mclasen@redhat.com>
107 * tests/testactions.c (main):
108 * tests/testmerge.c (main): Add some refcount debugging.
110 * gtk/gtkuimanager.c (update_node, free_node): Ref an sink
111 all proxies, so that we can properly clean up floating proxies
112 which the app didn't adopt. (#147926, Tommi Komulainen)
114 2004-07-20 Matthias Clasen <mclasen@redhat.com>
116 Allow custom initialization of cell editables. (#147221)
118 * gtk/gtkcellrenderer.h (struct _GtkCellRendererClass):
119 * gtk/gtkcellrenderer.c (gtk_cell_renderer_class_init): Add a
120 ::editing-started signal as a hook for setting up the
122 (gtk_cell_renderer_start_editing): ...and emit it here.
124 Mon Jul 19 23:51:50 2004 Matthias Clasen <maclas@gmx.de>
126 * gtk/gtktreeview.c (gtk_tree_view_button_press): Set drag_pos
127 before grabbing the focus, since we may reenter into
128 gtk_tree_view_motion_resize_column() which requires drag_pos
129 to be set. (#147913, Guilherme Salgado, patch by John Finlay)
131 Mon Jul 19 23:51:50 2004 Matthias Clasen <maclas@gmx.de>
133 * gtk/gtktreeview.c (gtk_tree_view_enter_notify): Don't
134 use uninitialized node pointer. (#147911, Peter Zelezny)
136 Tue Jul 20 04:34:56 2004 Soeren Sandmann <sandmann@daimi.au.dk>
138 * configure.in: Bump version number
140 Sun Jul 18 17:21:10 2004 Soeren Sandmann <sandmann@daimi.au.dk>
142 * === Released 2.5.0 ===
146 * tests/testcombo.c: Fix compilation
148 2004-07-19 Matthias Clasen <mclasen@redhat.com>
150 * gtk/gtkentrycompletion.c (gtk_entry_completion_set_popup_completion):
153 2004-07-19 Matthias Clasen <mclasen@redhat.com>
155 Make GtkCellView public, since people seem to have uses for it,
156 it is clean API and we were just conservative in not making it
157 public initially. At the same time, get rid of GtkCellViewMenuItem,
158 which doesn't have any function which can't be served by a
159 GtkMenuItem with a GtkCellView child. (#136637, Padraig O'Briain)
161 * gtk/gtk.h: Include gtkcellview.h
163 * gtk/Makefile.am (gtk_public_h_sources):
165 * gtk/Makefile.am (gtk_private_h_sources):
166 (gtk_c_sources): Remove gtkcellviewmenuitem.[hc]
167 * gtk/gtkcombobox.c: Replace all uses of GtkCellViewMenuItem by
168 GtkMenuItem with a GtkCellView child.
170 * gtk/gtkcellviewmenuitem.[hc]: Removed.
172 2004-07-19 Matthias Clasen <mclasen@redhat.com>
174 Support inline autocompletion in entries (#135953)
176 * gtk/gtkentryprivate.h:
177 * gtk/gtkentrycompletion.h:
178 * gtk/gtkentrycompletion.c (gtk_entry_completion_class_init):
179 Add a new signal ::insert-prefix which can be used to override
180 the default inline-completion behaviour. Add two new boolean
181 properties, :popup_completion and :inline_completion which
182 determine how the possible completions should be presented.
183 (gtk_entry_completion_insert_prefix): New function to request
186 * gtk/gtkentry.c: Add the necessary glue for inline completion.
188 Sun Jul 18 15:28:24 2004 Soeren Sandmann <sandmann@daimi.au.dk>
190 * gtk/gtkdnd.c (gtk_drag_source_set, gtk_drag_dest_set): Create an
191 empty target list if targets is NULL.
193 * configure.in: Add check for X11/extensions/sync.h. (#147416,
196 Sun Jul 18 01:24:31 2004 Matthias Clasen <maclas@gmx.de>
198 * NEWS: Updates for 2.5.0
200 Sat Jul 17 23:11:04 2004 Matthias Clasen <maclas@gmx.de>
203 * gtk/gtkiconview.c (gtk_icon_view_class_init):
204 * gtk/gtkiconview.c (gtk_icon_view_set_orientation):
205 * gtk/gtkiconview.c (gtk_icon_view_get_orientation):
206 * gtk/gtkiconview.c (gtk_icon_view_calculate_item_size):
207 * gtk/gtkiconview.c (gtk_icon_view_layout_single_row):
208 Add a new :orientation property to determine whether text
209 is positioned below or beside icons. (#147463)
211 Sat Jul 17 23:03:30 2004 Matthias Clasen <maclas@gmx.de>
213 * gtk/gtkiconview.c (gtk_icon_view_paint_item):
214 * gtk/gtkiconview.c (gtk_icon_view_calculate_item_size):
215 * gtk/gtkiconview.c (gtk_icon_view_layout_single_row): Draw
216 focus indicator outside the selection, respect focus
217 line width. (#147460)
219 Sat Jul 17 01:17:33 2004 Matthias Clasen <maclas@gmx.de>
221 * gdk/x11/gdkdnd-x11.c (xdnd_check_dest): Fix a warning
224 Sat Jul 17 00:48:27 2004 Matthias Clasen <maclas@gmx.de>
226 Support text/plain selection target (#55117, Owen Taylor)
228 * gtk/gtkselection.h:
230 * gtk/gtkselection.c (gtk_target_list_add_text_targets):
231 * gtk/gtkdnd.c (gtk_drag_dest_add_text_targets):
232 * gtk/gtkdnd.c (gtk_drag_source_add_text_targets): New
233 functions to facilitate handling of text targets.
236 * gtk/gtktextview.c: Use the new text target handling
237 functions instead of hardwiring the list of supported
238 text targets everywhere.
240 * gtk/gtkselection.c (gtk_selection_data_get_text):
241 (gtk_selection_data_set_text):
242 Support the targets text/plain, text/plain?charset=utf-8
243 and text/plain?charset=<LOCALE-CHARSET> as outlined in
245 For text/plain send only ASCII, but accept 8-bit text
246 and treat it as ISO-8859-1 as specified by the Xdnd spec.
247 Always send CRLF terminators. Accept either and convert
248 into the native terminator for the platform.
250 Fri Jul 16 23:20:34 2004 Matthias Clasen <maclas@gmx.de>
252 Support themed window icons. (#92346, Calum Benson)
254 * gtk/gtkicontheme.c (gtk_icon_theme_get_icon_sizes): New
255 function to obtain information about the sizes in which an
259 * gtk/gtkwindow.c (gtk_window_class_init):
260 (gtk_window_set_icon_name):
261 (gtk_window_get_icon_name): Add an "icon_name" property
262 (gtk_window_set_default_icon_name): ...and a default icon name.
263 (icon_list_from_theme):
264 (update_themed_icon): New auxiliary functions to create a
265 list of all available sizes of a themed icon and update the
266 window icon list from it.
268 2004-07-16 Matthias Clasen <mclasen@redhat.com>
270 * gtk/gtkcombobox.c (gtk_combo_box_scroll_event): Make
271 scrolling work if no item is selected.
272 (gtk_cell_editable_key_press): Don't eat space.
274 Add a combo box cell renderer (#139347, Lorenzo Gil Sanchez)
276 * gtk/gtkcellrenderercombo.[hc]: New Files.
279 * gtk/Makefile.am (gtk_public_h_sources, gtk_c_sources):
282 * gtk/gtkcombobox.[hc]: Implement GtkCellEditable, add a
283 :has-frame property for suppressing the frame around
284 the child and redo the size allocation logic to take
285 focus width into account.
287 * gtk/gtkcomboboxentry.c (gtk_combo_box_entry_init):
288 Acknowledge the GtkComboBox:has-frame property and make
289 the entry fill its allocation vertically.
291 * gtk/gtkmarshalers.list: Add BOOLEAN:STRING.
293 * gtk/gtktreeview.c (gtk_tree_view_remove_widget): Queue
294 a draw here to keep non-widget windows from leaving
297 2004-07-16 Matthias Clasen <mclasen@redhat.com>
299 * gtk/gtkcombobox.c (gtk_combo_box_forall): Don't iterate
300 multiple times over some of the children.
302 Thu Jul 15 22:19:40 2004 Matthias Clasen <maclas@gmx.de>
304 Fix #60128, #58307, #144706:
306 * gtk/gtkstyle.c (gtk_style_real_copy): Handle references
307 to bg_pixmaps properly.
308 (gtk_style_real_unrealize): Don't keep dangling references
310 (gtk_style_attach): Split the loop into two loops, first
311 looking for a matching style, then for an empty one.
312 (gtk_style_finalize):
313 (gtk_style_duplicate): Add comments explaining the handling
316 Thu Jul 15 20:31:28 2004 Matthias Clasen <maclas@gmx.de>
318 * gtk/gtkspinbutton.c (start_spinning): Install the timeout
319 before changing the value, so that a ::value_changed handler
320 has a chance to remove it. (#122427, Elke Meier)
322 Thu Jul 15 19:20:05 2004 Matthias Clasen <maclas@gmx.de>
324 * gdk/x11/gdkgtk+/im-x11.c (_gdk_x11_initialize_locale):
325 * gtk/gtkcalendar.c (gtk_calendar_class_init): Use 'cannot'
326 instead of 'can not' in messages. (#144226, Morten Welinder)
328 2004-07-15 Matthias Clasen <mclasen@redhat.com>
330 * gtk/gtktreeview.c (gtk_tree_view_class_init):
331 * gtk/gtkcellrenderer.c (gtk_cell_renderer_class_init):
332 Correct the declared default values of several properties
333 to be in sync with the actual initial values.
335 * gtk/gtktreeviewcolumn.c (gtk_tree_view_column_class_init):
336 Make spacing a property, correct the declared default values
337 of several properties to be in sync with the actual initial
338 values. (#147654, Matthias Clasen)
340 * gtk/gtkmenu.c (gtk_menu_set_tearoff_state): Don't reparent
341 back to menu->toplevel if it is already gone because we're
342 shutting down. (#147656, John Cupitt)
344 2004-07-14 Federico Mena Quintero <federico@ximian.com>
348 * gtk/gtktreeview.c (gtk_tree_view_bin_expose): Draw a focus
349 indicator along the edge of the bin_window when the tree is empty.
350 (grab_focus_and_unset_draw_keyfocus): New helper function.
351 (gtk_tree_view_button_press): Remove a bit of superfluous code.
352 Use the helper function to save on duplicated code.
353 (gtk_tree_view_button_press): Grab the focus if the tree is empty.
354 (gtk_tree_view_focus): Allow focusing into an empty tree.
356 2004-07-14 Matthias Clasen <mclasen@redhat.com>
358 * gtk/gtkaboutdialog.c (add_credits_page): Don't use
359 gcc extensions for the ternary ?: operator. (#147590,
362 2004-07-14 Federico Mena Quintero <federico@ximian.com>
364 Fix #144405, patch by Padraig O'Briain <padraig.obriain@sun.com>:
366 * gtk/gtkfilechooserdefault.c (shortcuts_list_create): Set the
367 accessible object name for the tree view.
368 (create_file_list): Likewise.
370 Tue Jul 13 21:53:08 2004 Matthias Clasen <maclas@gmx.de>
372 * gtk/gtkicontheme.c (free_unthemed_icon): Don't leak
373 no_svg_filename. (#147399, Kjartan Maraas)
375 2004-07-13 Matthias Clasen <mclasen@redhat.com>
377 * gtk/gtktreeviewcolumn.c (_gtk_tree_view_column_get_neighbor_sizes):
378 Make this work in RTL context.
380 2004-07-13 Federico Mena Quintero <federico@ximian.com>
382 * gtk/gtkfilechooserdefault.c (shortcuts_activate_volume): Set a
383 busy cursor while mounting the volume. Also, ref the chooser
384 while mounting, as we may re-enter. Fixes #139376.
386 2004-07-13 Matthias Clasen <mclasen@redhat.com>
388 * gtk/gtktreeview.c (gtk_tree_view_adjustment_changed):
389 Prepare to handle composite implementations of
390 GtkCellEditable, but recursively poking at
391 allocation->y (hack stolen from GtkCList).
392 (check_expander_max): Tweak the warning.
394 * gtk/gtkmain.h: Add gtk_parse_args(), its a public
395 function. (#147476, Owen Taylor)
397 * gtk/gtkcombobox.c (gtk_combo_box_popdown): Don't
400 Tue Jul 13 01:50:06 2004 Matthias Clasen <maclas@gmx.de>
402 * gtk/gtkaboutdialog.c (display_credits_dialog): Don't
403 display untranslated translator credits.
405 Tue Jul 13 01:15:05 2004 Matthias Clasen <maclas@gmx.de>
407 * gtk/gtkiconview.c: Some documentation updates.
409 Tue Jul 13 00:40:29 2004 Soeren Sandmann <sandmann@daimi.au.dk>
411 * gdk/gdkwindow.c (gdk_window_process_updates_internal): Do an
412 empty begin_paint_region()/end_paint() for windows without
415 * gdk/x11/gdkwindow-x11.c (_gdk_x11_window_tmp_unset_bg,
416 _gdk_x11_window_tmp_reset_bg): Remove checks for EXPOSURE_MASK.
418 2004-07-12 Matthias Clasen <mclasen@redhat.com>
420 * demos/gtk-demo/appwindow.c: Use a GtkAboutDialog.
422 * gtk/gtkaboutdialog.h:
423 * gtk/gtkaboutdialog.c: New widget: GtkAboutDialog.
425 * gtk/Makefile.am (gtk_public_h_sources, gtk_c_sources):
426 * gtk/gtk.h: Add GtkAboutDialog. (#109435, Paolo Borelli,
427 patch by Matthias Clasen)
429 * gtk/gtkrc.c (_gtk_rc_init): Apply the gtk-default-menu-item-style
430 to cell view menu items as well. (#147405, John Cupitt)
432 * gtk/gtkentrycompletion.c: Warning fixes. (#147420,
435 * gtk/gtkcombobox.c (gtk_combo_box_destroy): Pop down
436 first. (#147399, John Cupitt)
438 Mon Jul 12 01:56:26 2004 Matthias Clasen <maclas@gmx.de>
440 * gdk/x11/gdkwindow-x11.c (gdk_toplevel_x11_free_contents):
441 Include the update_counter check in the HAVE_XSYNC condition,
442 since update_counter isn't present in the !HAVE_XSYNC case.
444 Mon Jul 12 00:52:04 2004 Matthias Clasen <maclas@gmx.de>
446 * gtk/stock-icons/Makefile.am:
447 * gtk/stock-icons/stock_about_{16,24}.png:
448 * gtk/stock-icons/stock_connect_{16,24}.png:
449 * gtk/stock-icons/stock_disconnect_{16,24}.png:
450 * gtk/stock-icons/stock_edit_{16,24}.png:
451 * gtk/stock-icons/stock_media_forward_{16,24}.png:
452 * gtk/stock-icons/stock_media_next_{16,24}.png:
453 * gtk/stock-icons/stock_media_pause_{16,24}.png:
454 * gtk/stock-icons/stock_media_play_{16,24}.png:
455 * gtk/stock-icons/stock_media_previous_{16,24}.png:
456 * gtk/stock-icons/stock_media_record_{16,24}.png:
457 * gtk/stock-icons/stock_media_rewind_{16,24}.png:
458 * gtk/stock-icons/stock_media_stop_{16,24}.png:
459 * gtk/gtkstock.h (GTK_STOCK_ABOUT):
460 * gtk/gtkstock.h (GTK_STOCK_CONNECT):
461 * gtk/gtkstock.h (GTK_STOCK_DISCONNECT):
462 * gtk/gtkstock.h (GTK_STOCK_EDIT):
463 * gtk/gtkstock.h (GTK_STOCK_MEDIA_FORWARD):
464 * gtk/gtkstock.h (GTK_STOCK_MEDIA_NEXT):
465 * gtk/gtkstock.h (GTK_STOCK_MEDIA_PAUSE):
466 * gtk/gtkstock.h (GTK_STOCK_MEDIA_PLAY):
467 * gtk/gtkstock.h (GTK_STOCK_MEDIA_PREVIOUS):
468 * gtk/gtkstock.h (GTK_STOCK_MEDIA_RECORD):
469 * gtk/gtkstock.h (GTK_STOCK_MEDIA_REWIND):
470 * gtk/gtkstock.h (GTK_STOCK_MEDIA_STOP):
471 * gtk/gtkiconfactory.c (get_default_icons):
472 * gtk/gtkstock.c (builtin_items): Add a number of new stock
473 items. (#102530, #68015, #109811, Jordi Mallach, Benjamin Otte,
476 Sun Jul 11 15:24:03 2004 Soeren Sandmann <sandmann@daimi.au.dk>
478 Bug 143330, support update counter spec.
480 * configure.in: Add check for the Sync extension
482 * gdk/gdkwindow.h: gdk_window_enable_synchronized_configure() and
483 gdk_window_configure_finished()
485 * gtk/gtkwindow.c (gtk_window_move_resize): Call gdk_window_finish_configure().
486 * gtk/gtkwindow.c (gtk_window_realize): Automatically enable
487 synchronized configures.
489 * gdk/x11/gdkwindow-x11.h (struct _GdkToplevelX11): Store current
490 and pending counter values.
492 * gdk/x11/gdkwindow-x11.c (gdk_window_configure_finished): New function.
493 * gdk/x11/gdkwindow-x11.c
494 (gdk_window_enable_synchronized_configure): New function.
495 * gdk/x11/gdkwindow-x11.c (gdk_toplevel_x11_free_contents):
496 Delete update counter.
497 * gdk/x11/gdkwindow-x11.c (set_wm_protocols): Advertise
498 _NET_WM_SYNC_REQUEST when Sync is available
500 * gdk/x11/gdkevents-x11.c (gdk_wm_protocols_filter): Handle
501 _NET_WM_SYNC_REQUEST messages
502 * gdk/x11/gdkevents-x11.c (gdk_event_translate): Save counter
503 value for use by gdk_window_configure_finished() when receiving
506 * gdk/x11/gdkdisplay-x11.h (struct _GdkDisplayX11): Add use_sync flag
507 * gdk/x11/gdkdisplay-x11.c (gdk_display_open): Check if the XSync
508 extension is available
509 * gdk/x11/gdkdisplay-x11.c: Add _NET_WM_SYNC_REQUEST and
510 _NET_WM_SYNC_REQUEST_COUNTER to list of supported atoms.
512 * gdk/linux-fb/gdkwindow-fb.c, gdk/win32/gdkwindow-win32.c: Add
513 stubs for enable_synchronized_configure() and configure_finished()
515 Sat Jul 10 23:35:13 2004 Matthias Clasen <maclas@gmx.de>
517 * gtk/gtkentry.c (paste_received): Make middle-button pasting
518 work as expected inside the entry. (#116789, Scott Bronson)
520 Sat Jul 10 22:13:53 2004 Matthias Clasen <maclas@gmx.de>
522 * gtk/gtktextbuffer.c (gtk_text_buffer_select_range): Update
523 clipboards. (#142805, Mikael Hallendal)
525 Sun Jul 11 01:38:48 2004 Soeren Sandmann <sandmann@daimi.au.dk>
527 * gtk/gtkpaned.c (gtk_paned_expose): Remove clip-region computing
528 code. Just use &paned->handle_pos.
530 Sun Jul 11 01:12:50 2004 Soeren Sandmann <sandmann@daimi.au.dk>
534 * gtk/gtknotebook.c (gtk_notebook_size_allocate): Remove an
537 * gtk/gtknotebook.c (gtk_notebook_page_allocate): Remove some
540 Sat Jul 10 01:33:25 2004 Matthias Clasen <maclas@gmx.de>
542 * docs/RELEASE-HOWTO: Updates.
544 Sat Jul 10 01:55:29 2004 Soeren Sandmann <sandmann@daimi.au.dk>
546 * gdk/x11/gdkwindow-x11.c (_gdk_x11_window_tmp_{re|un}set_bg):
547 Insert checks for root window. The root window is never mapped.
549 Sat Jul 10 01:06:05 2004 Soeren Sandmann <sandmann@daimi.au.dk>
551 * gdk/x11/gdkwindow-x11.c (post_unmap): Fix a warning
552 * gdk/x11/gdkwindow-x11.c (show_window_internal): Actually unset
555 Sat Jul 10 00:37:45 2004 Soeren Sandmann <sandmann@daimi.au.dk>
559 * gdk/x11/gdkwindow-x11.c (_gdk_x11_window_tmp_{un|re}set_bg):
560 New functions that can do a recursive unset/reset bg.
562 * gdk/x11/gdkgeometry-x11.c: Remove
563 gdk_window_tmp_{un|re}set_bg().
565 * gdk/x11/gdkwindow-x11.c (pre_unmap, post_unmap): New functions
566 called before and after unmapping a window. They unset the
567 background of all other windows to prevent flicker from the X
568 server repainting the background. post_unmap() also invalidates
569 the parent of the unmapped window to draw it without roundtrips.
571 * gdk/x11/gdkwindow-x11.c (show_window_internal): Unset
572 background of newly mapped windows and all desendants to prevent
575 Fri Jul 9 15:33:55 2004 Manish Singh <yosh@gimp.org>
577 * gdk/gdkevents.c: have a dummy case GDK_OWNER_CHANGE in switch
578 statements to avoid gcc warnings about not all enum values handled.
580 * gdk/x11/gdkdisplay-x11.c (gdk_display_open): ignore should live in
583 Fri Jul 9 23:26:09 2004 Soeren Sandmann <sandmann@daimi.au.dk>
587 * gdk/x11/gdkwindow-x11.h (struct _GdkWindowImplX11): Add an
588 "override_redirect" bit.
590 * gdk/x11/gdkwindow-x11.c (gdk_window_new): Set it here.
592 * gdk/x11/gdkwindow-x11.c (gdk_window_move, gdk_window_resize,
593 gdk_window_move_resize):
594 Update the local size/position cache
595 immediately for override redirect windows.
597 * gdk/x11/gdkwindow-x11.c (show_window_internal): Invalidate
598 newly mapped child and override redirect windows.
600 2004-07-09 Federico Mena Quintero <federico@ximian.com>
604 * gtk/gtkfilesystemunix.c (get_fallback_icon): New helper
605 function, fetches a stock icon as a fallback.
606 (gtk_file_system_unix_volume_render_icon): Fall back to a stock
608 (gtk_file_system_unix_render_icon): Fall back to a stock icon.
609 Use helper functions rather than being a mega-function.
610 (get_icon_name_for_directory): Renamed from
611 get_icon_for_directory().
612 (get_icon_type_from_path): New helper function; code pulled out
613 from gtk_file_system_unix_render_icon().
614 (get_special_icon): Likewise.
615 (get_icon_for_mime_type): Likewise.
617 2004-07-09 Federico Mena Quintero <federico@ximian.com>
619 * gdk/x11/gdkdnd-x11.c (xdnd_send_xevent): Fix typo; tmp_event ->
622 2004-07-09 Matthias Clasen <mclasen@redhat.com>
624 * gtk/gtktooltips.c (gtk_tooltips_paint_window): Use the
625 requisition of the widget instead of relying on the style
626 drawing function to supply the size of the drawable. (#146531)
628 2004-07-09 Matthias Clasen <mclasen@redhat.com>
630 Make GtkEntry work harder to protect passwords: (#143955,
633 * gtk/gtkentry.c (gtk_entry_destroy): Add a destroy handler
634 to clear the password even if the widget is leaked.
636 * gtk/gtkentry.c (gtk_entry_real_delete_text):
637 * gtk/gtkentry.c (gtk_entry_finalize): Zero out the memory
640 * gtk/gtkentry.c (gtk_entry_real_insert_text): Zero and free
641 the old memory instead of just reallocating it.
643 * gtk/gtkentry.c (gtk_entry_create_layout): Don't leak text
644 direction information for passwords.
646 2004-07-09 Matthias Clasen <mclasen@redhat.com>
648 * gtk/gtkstyle.c: Fix some cases where style functions were
649 not handling widget == NULL properly. (#146282)
651 Thu Jul 8 22:38:58 2004 Matthias Clasen <maclas@gmx.de>
653 * gtk/gtktreeview.c: Improve the EXPANDER_MAX warning.
655 2004-07-08 Federico Mena Quintero <federico@ximian.com>
659 * gtk/gtkfilesystemmodel.c (_gtk_file_system_model_new): Add a
660 GError argument. Do check for errors when getting the
661 GtkFileFolder: get the folder and read the children before
662 actually creating the model. Removed obsolete code that handled
663 roots-changed on the file system.
664 (file_model_node_get_info): Assert that we don't reach the old
665 case to display file system roots.
666 (roots_changed_callback): Removed.
668 * gtk/gtkfilechooserdefault.c (set_list_model): Add a GError
669 argument, and a boolean return value. Return an error if we
670 cannot create the file system model. On error, set a NULL model
672 (gtk_file_chooser_default_set_current_folder): Use the error value
673 from set_list_model().
674 (gtk_file_chooser_default_set_property): Set the show_hidden
675 property only if the browse_files_model exists.
676 (gtk_file_chooser_default_unselect_path): Only operate if the
677 browse_files_model exists.
678 (check_preview_change): Check whether we have the sort_model.
679 (change_folder_and_display_error): Copy the path we get passed
680 before using it. There's a comment in there that explains why we
681 need to copy it; basically, if the passed path belongs to the
682 model, the model may go away in the middle of this function and
683 we'll be left with a dangling pointer.
684 (install_list_model_filter): Assert that the model is not NULL.
685 (set_current_filter): Check whether the model exists.
687 * gtk/gtktreeselection.c (gtk_tree_selection_get_selected): Don't
688 g_return_if_fail if the model is NULL.
689 (gtk_tree_selection_get_selected_rows): Likewise.
690 (gtk_tree_selection_count_selected_rows): Likewise.
691 (gtk_tree_selection_selected_foreach): Likewise.
692 (gtk_tree_selection_path_is_selected): Likewise; rather just
694 (gtk_tree_selection_select_all): Likewise.
695 (gtk_tree_selection_unselect_all): Likewise.
696 (gtk_tree_selection_select_range): Do g_return_if_fail() if the
698 (gtk_tree_selection_unselect_range): Likewise.
700 * gtk/gtkfilesystemunix.c (fill_in_names): Return immediately if
701 g_dir_open() fails: there is no need to set the error ourselves,
702 as g_dir_open() already does it.
704 2004-07-08 Matthias Clasen <mclasen@redhat.com>
706 * gtk/gtktreeview.c (gtk_tree_view_set_search_equal_func): Allow
707 to restore the default search function. (#145365, John Finlay)
709 * gdk/x11/gdkdnd-x11.c (xdnd_send_xevent): Don't leak
710 references to the drag context. (#144324, Alex Larsson)
712 Thu Jul 8 00:31:34 2004 Matthias Clasen <maclas@gmx.de>
714 * gtk/gtktreeview.c (gtk_tree_view_set_model): Stop editing
715 when a new model is set. (#145566, Dmitry M. Shatrov)
717 Wed Jul 7 23:44:32 2004 Matthias Clasen <maclas@gmx.de>
719 * gtk/gtkimage.c (gtk_image_expose): Make sure that subpixbufs
720 are properly aligned for gdk_pixbuf_saturate_and_pixelate(),
721 in order to avoid rendering artifacts from misaligned
722 pixelation patterns. (#145585, Felipe Heidrich, Billy Biggs)
724 2004-07-07 Matthias Clasen <mclasen@redhat.com>
727 * gtk/gtktreeview.h: Small documentation fixes.
729 2004-07-07 Matthias Clasen <mclasen@redhat.com>
731 Support separators in combo boxes and more generally in tree
735 * gtk/gtkcombobox.c (gtk_combo_box_get_row_separator_column):
736 * gtk/gtkcombobox.c (gtk_combo_box_set_row_separator_column):
737 Add a ::row-separator-column property with getter and setter,
738 which can indicate a boolean model column to determine which
741 * gtk/gtkcombobox.c: Display separator rows as separator menu
742 items in menu mode, and by using the new treeview separator
743 functionality in list mode.
746 * gtk/gtktreeprivate.h:
747 * gtk/gtktreeview.c (gtk_tree_view_get_row_separator_func):
748 * gtk/gtktreeview.c (gtk_tree_view_set_row_separator_func):
749 Add a callback to determine whether a row is a separator.
751 * gtk/gtktreeview.c (gtk_tree_view_bin_expose):
752 * gtk/gtktreeview.c (gtk_tree_view_create_row_drag_icon):
753 * gtk/gtktreeview.c (validate_row): Use the new callback
754 to determine whether a row is a separator, and draw it
755 as a separator then. Since separators should take up less
756 vertical space than regular rows, this requires removing
757 the redundant MAX(...,expander_size) calls which appear in
758 many places. Instead, the MAX() is now only done in
759 validate_row(), and only if the row is not a separator.
760 To catch possible side effects of this intrusive change,
761 I have left EXPANDER_MAX() calls in place of the MAX() calls
762 which will emit a warning if something breaks. They should
763 be removed before 2.6.
765 * gtk/gtktreeselection.c (row_is_selectable): Don't let
766 separator rows be selected.
768 * tests/testcombo.c (create_blaat): Add a separator column.
770 Tue Jul 6 22:58:00 2004 Matthias Clasen <maclas@gmx.de>
772 * gdk/x11/gdkwindow-x11.c (gdk_x11_window_set_user_time): Fix
773 a 64bit alignment issue. (#144302, Sunil)
775 2004-07-07 Tor Lillqvist <tml@iki.fi>
777 * gdk/win32/gdkdrawable-win32.c (gdk_win32_draw_text)
778 * gdk/win32/gdkfont-win32.c (gdk_text_extents)
779 * gdk/win32/gdkproperty-win32.c (find_common_locale,
781 * gdk/win32/gdkselection-win32.c (gdk_selection_convert): Use
782 g_utf8_to_utf16() instead of the removed _gdk_utf8_to_ucs2() (see
785 * gdk/win32/gdkglobals-win32.c
786 * gdk/win32/gdkmain-win32.c (_gdk_windowing_init)
787 * gdk/win3/gdkprivate-win32.h: Add a variable for the TARGETS
788 atom. Initialize it. Declare it. Drop the variable for the
791 * gdk/win32/gdkim-win32.c (gdk_wcstombs): Don't return UTF-8. This
792 function is supposed to return the string in the locale's charset
793 and encoding. Use g_convert().
795 (gdk_mbstowcs): Similarily, don't take an UTF-8 string, but a
796 string in the locale's charset. Use g_convert().
798 (_gdk_ucs2_to_utf8, _gdk_utf8_to_wcs, _gdk_utf8_to_ucs2):
799 Delete. The UCS-2 functions didn't handle surrogates anyway. Use
800 GLib's UTF-16 functions instead. Windows uses UTF-16.
802 * gdk/win32/gdkprivate-win32.h: Remove declarations of the deleted
803 functions mentioned above.
805 * gdk/win32/gdkproperty-win32.c (gdk_property_change): Use CF_TEXT
806 also if the string is of type STRING, i.e. ISO-8859-1, and the
807 current codepage is 1252, and contains no C1 chars. Accept
810 * gdk/win32/gdkselection-win32.c (_gdk_selection_property_store):
811 Mark as static. When storing STRING data, convert to
813 (gdk_selection_owner_set_for_display): Now that STRING is always
814 ISO-8859-1, use UTF8_STRING when sending the selection request
817 (gdk_selection_convert): Handle also UTF8_STRING. (#140537, John
820 (gdk_text_property_to_text_list_for_display): Make work more like
821 X11 version. Do obey the encoding parameter.
823 (gdk_string_to_compound_text_for_display,
824 gdk_utf8_to_compound_text_for_display): Don't even pretend
825 supporting COMPOUND_TEXT.
827 (gdk_utf8_to_string_target): Convert to ISO-8859-1, like on X11.
829 (sanitize_utf8): Zero-terminate string.
831 2004-07-06 Matthias Clasen <mclasen@redhat.com>
833 * gtk/stock-icons/Makefile.am: Add stock_file_16.png,
834 stock_file_24.png, stock_directory_16.png and stock_directory_24.png.
836 * gtk/gtkstock.h (GTK_STOCK_FILE, GTK_STOCK_DIRECTORY):
837 * gtk/gtkiconfactory.c (get_default_icons): New stock icons as
838 fallbacks for gtkfilechooser. Currently these are the same images
839 as the "new" and "open" items...
841 Tue Jul 6 10:00:22 2004 Jonathan Blandford <jrb@redhat.com>
843 Fix for #136496, Pawel Salek:
845 * gtk/gtktreeview.c (gtk_tree_view_row_changed): Queue a redraw on
846 a node when it changes in fixed_height mode.
848 (gtk_tree_view_node_queue_redraw): new function to queue a redraw
851 2004-07-06 Matthias Clasen <mclasen@redhat.com>
853 * gtk/gtkmenu.c (gtk_menu_position): Make sure
854 private->monitor_num is a valid monitor number before
855 using it. (#139187, Michael Natterer)
857 Tue Jul 6 02:00:28 2004 Matthias Clasen <maclas@gmx.de>
859 * gtk/gtkfilechooserdefault.c (popup_position_func):
860 * gtk/gtkentry.c (popup_position_func):
861 * gtk/gtktextview.c (popup_position_func): Improve positioning
862 of keyboard-activated menus with Xinerama.
864 Tue Jul 6 00:29:03 2004 Matthias Clasen <maclas@gmx.de>
866 * gtk/gtkuimanager.c (do_updates):
867 (do_updates_idle): Only call GDK_THREADS_ENTER() / _LEAVE()
868 when called from an idle handler. (#145429, Jan-Marek Glogowski)
870 Mon Jul 5 23:47:38 2004 Matthias Clasen <maclas@gmx.de>
872 * gtk/gtkfilechooserutils.c (delegate_notify): Use
873 the less efficient g_object_interface_find_property () instead
874 of the param_id range check, since the GParamSpecs we're
875 dealing with are the overridden onces on the interface, whose
876 param_id is always zero. (#145312, Alex Roitman, fix proposed
879 2004-07-05 Lorenzo Gil Sanchez <lgs@sicem.biz>
881 * gtk/gtklayout.c (gtk_layout_add): added a default method for the add
882 virtual method of GtkContainer.
883 (gtk_layout_class_init): assign gtk_layout_add to the 'add' virtual
884 method slot of the container class.
886 2004-07-05 Anders Carlsson <andersca@gnome.org>
888 * gtk/gtkiconview.c: (gtk_icon_view_set_markup_column):
890 Use gint, not int in gtk_icon_view_set_markup_column,
893 2004-07-05 Anders Carlsson <andersca@gnome.org>
895 * gtk/gtkiconview.c: (gtk_icon_view_class_init),
896 (gtk_icon_view_real_select_cursor_item),
897 (gtk_icon_view_real_activate_cursor_item):
899 Add an "activate_cursor_item" action signal
900 and bind it to the return key.
902 2004-07-04 Anders Carlsson <andersca@gnome.org>
904 * demos/gtk-demo/Makefile.am:
905 * demos/gtk-demo/gnome-fs-directory.png:
906 * demos/gtk-demo/gnome-fs-regular.png:
907 * demos/gtk-demo/iconview.c: (load_pixbufs), (fill_store),
908 (sort_func), (create_store), (item_activated), (up_clicked),
909 (home_clicked), (do_iconview):
910 Add a simple file browser based on the icon view.
913 Add gtk/gtkiconview.h
915 * gtk/gtkiconview.c: (gtk_icon_view_layout),
916 (gtk_icon_view_item_new), (gtk_icon_view_item_activated):
917 Fix a few bugs discovered while writing the demo.
919 2004-07-04 Anders Carlsson <andersca@gnome.org>
924 Add GtkIconView to the build, remove debugging output.
926 Sun Jul 4 01:29:35 2004 Matthias Clasen <maclas@gmx.de>
928 * gtk/gtkcalendar.c (gtk_calendar_drag_data_get):
929 (gtk_calendar_drag_data_received): Fix off-by-one error.
930 GDate month is one-based and GtkCalendar month is zero-based.
931 (#145134, William Jon McCann)
933 Sun Jul 4 01:11:07 2004 Matthias Clasen <maclas@gmx.de>
935 * gtk/gtktreestore.c (gtk_tree_store_move): Don't crash if
936 somebody tries to move a node after itself in a list of
937 length 1. (#145291, Sampo Nurmentaus)
939 Sat Jul 3 23:43:23 2004 Matthias Clasen <maclas@gmx.de>
941 * docs/faq/gtk-faq.sgml:
942 * gtk/gtkwindow.c: Fix links to www.freedesktop.org. (#145210,
945 Sat Jul 3 02:09:51 2004 Matthias Clasen <maclas@gmx.de>
947 * gtk/gtksocket.c (gtk_socket_end_embedding): Reset current_width
948 and current_height to 0 when ending the embedding. (#143675,
951 Sat Jul 3 01:48:19 2004 Matthias Clasen <maclas@gmx.de>
953 * gtk/gtkentry.c (gtk_entry_move_visually): Let the cursor move
954 to the right end of the entry text, even if it ends in combining
955 marks. (#141728, Theppitak Karoonboonyanan)
957 Fri Jul 2 23:34:33 2004 Matthias Clasen <maclas@gmx.de>
959 * gtk/gtkcombobox.c (gtk_combo_box_unset_model): Unset the displayed
960 row when unsetting the model. (#138560, Christian Persch)
962 Fri Jul 2 23:01:07 2004 Matthias Clasen <maclas@gmx.de>
964 * gtk/gtkcombobox.c (update_menu_sensitivity): Don't crash if there
967 Fri Jul 2 22:41:27 2004 Matthias Clasen <maclas@gmx.de>
969 * gtk/gtkimage.c (gtk_image_expose): Properly align mask and
970 pixbuf if a subarea is exposed. (#135423, fix by John Ehresman)
972 Fri Jul 2 21:40:21 2004 Matthias Clasen <maclas@gmx.de>
974 * gtk/gtknotebook.c (gtk_notebook_realize): Add scroll events
975 to the event mask, set a scroll_event handler.
976 * gtk/gtknotebook.c (gtk_notebook_scroll): Handle scroll events
977 by switching tabs. (#145244, Gabriel de Perthuis)
979 2004-07-02 Anders Carlsson <andersca@gnome.org>
981 * gtk/gtktreeview.c (gtk_tree_view_set_model):
982 Make sure we check for a NULL model first.
984 2004-07-01 J. Ali Harlow <ali@juiblex.co.uk>
986 * gdk/win32/gdkinput-win32.c (_gdk_input_ungrab_pointer): Fix
987 win32 build problem w/o wintab. Fixed #145242
989 2004-06-30 Anders Carlsson <andersca@gnome.org>
991 * gtk/gtktreeview.c (gtk_tree_view_set_model): Use
992 g_return_if_fail to make sure that the model is a GtkTreeModel.
994 Sat Jun 26 17:41:10 2004 Soeren Sandmann <sandmann@daimi.au.dk>
996 * gtk/gtk[hv]separator.c (gtk_[hv]separator_expose): Draw line with the
997 current state, not GTK_STATE_NORMAL
999 * gtk/gtkframe.c (gtk_frame_paint): Fix a rounding error
1001 Sat Jun 26 15:07:25 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1003 * gtk/gtkstyle.c, gtk/gtkrc.c: small color tweak. (#141173)
1005 Sat Jun 26 01:15:40 2004 Matthias Clasen <maclas@gmx.de>
1007 * gdk/x11/gdkwindow-x11.c (set_initial_hints): Handle
1008 _NET_WM_STATE_ABOVE and _NET_WM_STATE_BELOW. (#144851,
1011 Sat Jun 26 01:04:31 2004 Matthias Clasen <maclas@gmx.de>
1013 * gtk/gtkiconfactory.c (clear_cache): Prevent unwanted
1014 recursion by resetting icon_set->cache before freeing
1015 the cache. (#144947, Tim Janik)
1017 Sat Jun 26 00:40:02 2004 Matthias Clasen <maclas@gmx.de>
1019 * gtk/gtkiconfactory.c (render_icon_name_pixbuf):
1020 * gtk/gtkiconfactory.c (gtk_icon_set_render_icon):
1021 * gtk/gtkstyle.c (gtk_default_render_icon): Accept a NULL
1024 Sat Jun 26 00:04:36 2004 Matthias Clasen <maclas@gmx.de>
1026 * gtk/gtkentrycompletion.c (gtk_entry_completion_set_model):
1027 * gtk/gtkcombobox.c (gtk_combo_box_set_model): Reflect the
1028 last change in the docs.
1030 Fri Jun 25 23:35:42 2004 Matthias Clasen <maclas@gmx.de>
1032 * gtk/gtkentrycompletion.c (gtk_entry_completion_set_model):
1033 * gtk/gtkcombobox.c (gtk_combo_box_set_model): Allow passing
1034 NULL to unset the model. (#137211, patch by Mariano Suárez-Alvarez)
1036 Fri Jun 25 23:33:05 2004 Matthias Clasen <maclas@gmx.de>
1038 * gtk/gtkcombobox.c (gtk_combo_box_menu_position_below): Fix the
1039 placement policy for GtkComboBoxEntry to be: if it fits below,
1040 place below, if it fits above place above, else place in the
1041 larger space and scroll so that the scroll arrow appear at the
1042 far end. (#144362, David A. Knight)
1044 Fri Jun 25 22:49:58 2004 Matthias Clasen <maclas@gmx.de>
1046 * gtk/gtktreestore.c (gtk_tree_store_move): Avoid uninitialized
1047 use of &parent_iter. (#145007, John Finlay)
1049 2004-06-25 Bastien Nocera <hadess@hadess.net>
1051 reviewed by: Matthias Clasen <maclas@gmx.de>
1053 * gdk/x11/gdkkeys-x11.c: (get_symbol), (update_keymaps),
1054 (gdk_keymap_lookup_key), (translate_keysym): fix keys parsing when
1055 the number of keysyms per keycode is odd. Fixes #144808.
1057 2004-06-25 Matthias Clasen <mclasen@redhat.com>
1059 * gtk/gtkfontbutton.c (gtk_font_button_update_font_info): Avoid
1060 a crash if the font doesn't exist. (#144967, Yevgen Muntyan)
1062 Fri Jun 25 00:32:15 2004 Matthias Clasen <maclas@gmx.de>
1064 * gtk/gtktreestore.c (gtk_tree_store_swap): Commit the change
1065 which was mentioned below.
1067 Thu Jun 24 23:35:09 2004 Matthias Clasen <maclas@gmx.de>
1069 * gtk/gtknotebook.c (gtk_notebook_class_init): Fix a typo,
1070 string change. (#139503, Baris Cicek)
1072 2004-06-22 Federico Mena Quintero <federico@ximian.com>
1074 * gtk/gtkfilechooserdefault.c (location_popup_handler): Use a Save
1075 or an Open stock button for the C-l dialog depending on the action
1076 in which the file chooser operates. Fixes #141753.
1078 2004-06-22 Federico Mena Quintero <federico@ximian.com>
1080 Fixes the GTK+ part of #142308:
1082 * gtk/gtkfilesystemunix.c (gtk_file_system_unix_filename_to_path):
1083 Use filename_to_path().
1084 (gtk_file_system_unix_uri_to_path): Likewise.
1085 (filename_to_path): Use remove_trailing_slash().
1087 2004-06-22 Matthias Clasen <mclasen@redhat.com>
1089 * gtk/gtktextview.c (gtk_text_view_class_init): Improve docs
1090 for the ::move_cursor signal.
1092 * gtk/gtkaccelmap.c (_gtk_accel_path_is_valid): Accept
1093 "<WINDOWTYPE>" as a valid accel path. (#144427, Philip
1096 * gtk/gtkselection.c (GTK_SELECTION_MAX_SIZE): Make sure
1097 this gets defined for all backends, so linux-fb has a
1098 chance of compiling.
1100 * gdk/x11/gdkgc-x11.c:
1101 * gdk/gdkgc.c: Move function docs inline, add hints about
1102 obtaining rgb colors from gcs. (#144688, Steve Chaplin)
1104 * gtk/gtktreestore.c (gtk_tree_store_swap): Make this work
1105 for children of the root. (#139785, Jean-François Wauthy,
1106 patch by John Finlay)
1108 * gtk/gtkicontheme.h (GTK_ICON_THEME_GET_CLASS): Typo
1109 fix. (#144750, Jeff Franks)
1111 2004-06-21 Michael Natterer <mitch@gimp.org>
1114 * gdk/x11/gdkdrawable-x11.[ch]: made convert_format() utility
1115 function public as _gdk_x11_convert_to_format().
1117 * gdk/x11/gdkcursor-x11.c (create_cursor_image): premultiply
1118 the pixels from the GdkPixbuf when putting them in the
1119 Xcursor image. Fixes bug #144350.
1121 2004-06-16 Federico Mena Quintero <federico@ximian.com>
1123 * gtk/gtkfilesystemmodel.c (do_files_added): When inserting a
1124 visible node, free the old path before creating the new one.
1127 Tue Jun 15 01:10:32 2004 Matthias Clasen <maclas@gmx.de>
1129 * gtk/gtkcombobox.c: Make GtkComboBox work without model.
1130 (#144198, Mariano Suárez-Alvarez)
1132 Fri Jun 11 22:05:56 2004 Matthias Clasen <maclas@gmx.de>
1134 * gtk/gtkfilechooserdefault.c: Don't use
1135 contractions like "don't" or "isn't" in error messages.
1136 It isn't nice to use them in log entries either...
1137 (#137774, Morten Welinder, patch by Alexander Winston)
1139 2004-06-11 Federico Mena Quintero <federico@ximian.com>
1143 * gtk/gtkfilesystemmodel.c (_gtk_file_system_model_add_editable):
1144 Don't ref the editable node.
1145 (_gtk_file_system_model_remove_editable): Don't unref the editable node.
1146 (_gtk_file_system_model_remove_editable): Ahem, free the node.
1148 * gtk/gtkfilechooserdefault.c (struct _GtkFileChooserDefault):
1149 Added fields for edited_idle and edited_new_text.
1150 (renderer_edited_cb): Queue the
1151 creation of the folder in an idle handler.
1152 (renderer_editing_canceled_cb): Likewise for the cancellation.
1153 (gtk_file_chooser_default_finalize): Free the impl->edited_new_text.
1155 Thu Jun 10 22:12:26 2004 Matthias Clasen <maclas@gmx.de>
1157 * gtk/gtkmain.c (gtk_parse_args): Typo fix.
1159 2004-06-10 Federico Mena Quintero <federico@ximian.com>
1161 Fixes #144110, patch by Bastien Nocera <hadess@hadess.net>.
1163 * gtk/gtkfilechooser.c (gtk_file_chooser_list_shortcut_folders):
1164 Refer to gtk_file_chooser_add_shortcut_folder().
1165 (gtk_file_chooser_list_shortcut_folder_uris): Refer to
1166 gtk_file_chooser_add_shortcut_folder_uri().
1168 Thu Jun 10 00:36:15 2004 Matthias Clasen <maclas@gmx.de>
1170 * gtk/gtkcalendar.c (gtk_calendar_main_button): Start
1171 the drag before focusing the selected.day.
1172 * gtk/gtkcalendar.c (gtk_calendar_state_changed): Stop
1173 a beginning drag if the widget becomes insensitive.
1175 Thu Jun 10 00:09:06 2004 Matthias Clasen <maclas@gmx.de>
1177 * gtk/gtkcalendar.c (gtk_calendar_button_press): Start
1178 spinning before calling arrow_action(), so that a signal
1179 handler triggered from arrow_action() has a chance to
1180 stop the spinning. (#143966, Davyd Madeley)
1182 Wed Jun 9 23:11:23 2004 Matthias Clasen <maclas@gmx.de>
1184 * gtk/gtkstyle.c (_gtk_style_init_for_settings): Fix a
1185 typo. (#144070, Kent Sandvik)
1187 Thu Jun 10 00:22:51 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1189 * gtk/gtkmenu.c: Revert the "drag select" part of
1192 Mon Jun 7 23:07:40 2004 Matthias Clasen <maclas@gmx.de>
1194 * gtk/gtkcombobox.c (gtk_combo_box_remeasure): Handle
1195 priv->model being NULL. (#143856, Mariano Suárez-Alvarez)
1197 2004-06-07 Federico Mena Quintero <federico@ximian.com>
1199 * gtk/gtktreeview.c (gtk_tree_view_button_press): Revert the patch
1200 from 2003/Sep/12. This kept DnD in tree views within modal
1201 dialogs from working, which is especially bad for the file
1202 chooser. Fixes #135168.
1204 Sun Jun 6 23:57:21 2004 Matthias Clasen <maclas@gmx.de>
1206 Make the entry context menu work in editable text cells. The changes
1207 are based on a patch by Kristian Rietveld, which implemented an
1208 approach outlined by Owen Taylor. (#50075)
1210 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_focus_out_event):
1211 Ignore focus out if the entry menu is posted.
1212 (gtk_cell_renderer_text_populate_popup): Mark the entry menu as
1213 posted, and set up a signal handler to clear the flag if the menu
1215 (gtk_cell_renderer_text_popup_unmap): Clear the in_entry_menu flag,
1216 set up a timeout to stop editing if the focus is lost.
1217 (popdown_timeout): Stop editing if the entry doesn't have focus anymore.
1218 (gtk_cell_renderer_text_start_editing): Connect to the populate_popup
1219 signal on the entry and keep a pointer to the entry.
1220 (gtk_cell_renderer_text_editing_done): Disconnect from popuplate_popup,
1221 clear the pointer to the entry.
1223 Sun Jun 6 23:24:43 2004 Matthias Clasen <maclas@gmx.de>
1225 * gtk/gtktexttag.c (gtk_text_tag_class_init): Improve the description
1226 of the ::language property. (#143802, Owen Taylor)
1228 Sat Jun 5 23:07:30 2004 Matthias Clasen <maclas@gmx.de>
1230 * gtk/gtkentrycompletion.c: (gtk_entry_completion_init),
1231 (gtk_entry_completion_list_enter_notify),
1232 (gtk_entry_completion_list_motion_notify),
1233 (_gtk_entry_completion_popup), (_gtk_entry_completion_popdown):
1234 * gtk/gtkentryprivate.h: Add an ignore_enter flag and
1235 use it as in the menu code to avoid the initial selection if
1236 the window pops up under the pointer. (Anders Carlsson)
1238 Sat Jun 5 20:05:39 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1240 * tests/testmerge.c: Add a checkbox to queue an
1241 merge/unmerge. Patch from Matthias Clasen.
1243 * gtk/gtktoolbar.c (struct _GtkToolbarPrivate): Add a new flag
1245 (rebuild_menu): New function that rebuilds the overflow menu and
1246 makes sure it doesn't start or end with a separator.
1247 (toolbar_content_new_tool_item)
1248 (toolbar_content_remove)
1249 (toolbar_content_new_compatibility): Set the rebuild_needed flag
1250 (gtk_toolbar_size_allocate): Only show the overflow arrow when we
1251 have actually overflown an item with a proxy menu item. Also make
1252 sure we rebuild the menu if needed.
1254 Fix #125504, #142377, #143463
1256 * gtk/gtkseparatortoolitem.c (gtk_separator_tool_item_expose):
1257 Obey the "priv->draw" flag. (#143692)
1259 2004-06-04 Matthias Clasen <mclasen@redhat.com>
1261 * docs/widget_geometry.txt: Add a note about the !CAN_FOCUS
1262 quirk in the button size allocation code.
1264 * gtk/gtkbutton.c (gtk_button_size_allocate): Give the space
1265 requested for drawing the focus indicator to the child in the
1266 !CAN_FOCUS case. This should fix issues which the Gimp has with
1267 the button allocation changes in 2.4.2.
1269 Thu Jun 3 21:17:29 2004 Matthias Clasen <maclas@gmx.de>
1271 * gtk/gtkentry.c (gtk_entry_completion_timeout): Calculate the
1272 length of the entry contents in characters, not in bytes.
1274 * gtk/gtkentry.c (paste_received): Don't pop up the completion
1275 window on paste, noticed by Anders Carlsson.
1277 Thu Jun 3 20:56:19 2004 Matthias Clasen <maclas@gmx.de>
1279 * gtk/gtkcombobox.c (gtk_combo_box_class_init): Fix the allowed
1280 values and default value for the ::active property. (#143669,
1283 2004-06-03 Michael Natterer <mitch@gimp.org>
1285 * gtk/gtkimagemenuitem.c: use gtk_widget_get_child_requisition()
1286 instead of accessing item->image->allocation.width/height
1287 directly. Makes widgets which only have a requisition set using
1288 gtk_widget_set_size_request() work and fixes bug #142789.
1290 Thu Jun 3 08:07:59 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1292 * gtk/gtkmenu.c: Revert previous commit. It caused the problem
1293 of sticky right click menus to return.
1295 Wed Jun 2 01:56:02 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1297 * gtk/gtkmenu.c: Fix the stay up algorithm for combo boxes to
1298 better handle the "click" case. bug Better fix for #141169.
1300 2004-06-02 Federico Mena Quintero <federico@ximian.com>
1302 * gtk/gtktreeview.c (gtk_tree_view_search_init): Bail out if the
1303 model is empty. Fixes #143536.
1305 2004-06-02 Matthias Clasen <mclasen@redhat.com>
1307 * gtk/gtkfontsel.c (gtk_font_selection_size_focus_out): Don't
1308 close the dialog on focus out of the size entry. (#143505,
1311 2004-06-02 Federico Mena Quintero <federico@ximian.com>
1315 * gtk/fnmatch.c (_gtk_fnmatch): Take a no_leading_period argument.
1316 (gtk_fnmatch_intern): Likewise; also implement this option.
1318 * gtk/gtkprivate.h (_gtk_fnmatch): Updated prototype.
1320 * gtk/gtkfilesel.c (find_completion_dir): Pass TRUE for the
1321 no_leading_period argument of _gtk_fnmatch().
1322 (attempt_file_completion): Likewise.
1324 * gtk/gtkfilefilter.c (gtk_file_filter_filter): Pass FALSE for the
1325 no_leading_period argument of _gtk_fnmatch().
1327 Wed Jun 2 00:47:11 2004 Matthias Clasen <maclas@gmx.de>
1329 * gtk/gtkselection.c (_gtk_selection_request): Remove leftover
1332 Wed Jun 2 00:13:57 2004 Matthias Clasen <maclas@gmx.de>
1334 * gtk/gtktreeselection.c (gtk_tree_selection_select_range): Don't
1335 allow unless selection mode is multiple. (#142634, John Finlay)
1337 Tue Jun 1 23:00:20 2004 Matthias Clasen <maclas@gmx.de>
1341 * gtk/gtkentrycompletion.h:
1342 * gtk/gtkentrycompletion.c:
1343 * gtk/gtkcombobox.h:
1344 * gtk/gtkcombobox.c: Rename function parameters from
1345 index to index_ to prevent clash with BSD index(). (#143001)
1347 Tue Jun 1 22:45:42 2004 Matthias Clasen <maclas@gmx.de>
1349 * gtk/gtkmenu.c (get_accel_path): Handle accel_closure being
1350 NULL on an accel label. (#139641, Sam Stephenson, patch by
1353 Tue Jun 1 22:19:55 2004 Matthias Clasen <maclas@gmx.de>
1355 * gtk/gtkicontheme.c (theme_subdir_load): Prevent icon
1356 lookup finding icons in the wrong prefix. (#143328,
1359 Wed Jun 2 00:39:58 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1363 * gtk/gtkmenushell.c (gtk_menu_shell_button_release): Make menus
1364 only stay up if you release within 500 milliseconds.
1365 (gtk_menu_shell_button_press): Set the activate_time to the event
1366 time when a button is pressed.
1368 * gtk/gtkmenu.c (gtk_menu_motion_notify, gtk_menu_enter_notify):
1369 Interprete button releases as activate when we have seen both an
1370 enter an a motion event.
1372 2004-06-01 Federico Mena Quintero <federico@ximian.com>
1374 * gtk/gtkfilesystemmodel.c (do_files_removed): Don't insert a
1375 dummy node if there is no parent node. Fixes #143362.
1377 2004-05-31 Federico Mena Quintero <federico@ximian.com>
1379 * gtk/gtkfilechooserdefault.c (renderer_edited_cb): Change to the
1380 newly-created folder. Fixes #138932.
1381 (trap_activate_cb): Only return TRUE if we did handle the event.
1382 Fixes #143359; patch by jylefort@brutele.be.
1384 Mon May 31 02:39:32 2004 Matthias Clasen <maclas@gmx.de>
1386 * gtk/gtkimage.c (gtk_image_new_from_pixmap): Fix typo in
1387 docs. (#142892, Tommi Komulainen)
1389 Mon May 31 02:16:37 2004 Matthias Clasen <maclas@gmx.de>
1391 * gtk/gtkhandlebox.c: Make detached handleboxes work when their
1392 parent is minimized, porting the fix from 1.2. (#1923, #57182)
1394 Mon May 31 02:03:17 2004 Matthias Clasen <maclas@gmx.de>
1396 * gtk/gtkwindow.c (gtk_window_show): Make moving realized,
1397 unmapped windows work.
1399 Mon May 31 00:27:33 2004 Matthias Clasen <maclas@gmx.de>
1401 * gtk/gtkfilechooserutils.c (_gtk_file_chooser_set_delegate): Fix
1404 Mon May 31 00:23:55 2004 Matthias Clasen <maclas@gmx.de>
1406 * gtk/gtkfilechooser.c (gtk_file_chooser_set_preview_widget):
1407 Refer to ::update-preview, not ::selection-changed.
1409 2004-05-29 Christian Rose <menthos@menthos.com>
1411 * configure.in: Added "tk" to ALL_LINGUAS.
1413 Fri May 28 15:00:01 2004 Matthias Clasen <maclas@gmx.de>
1415 * gtk/gtkwidget.c (gtk_widget_set_parent): Add informative
1416 messages for common problems. (#137974, Owen Taylor)
1418 Fri May 28 14:20:17 2004 Matthias Clasen <maclas@gmx.de>
1420 * gdk/x11/gdkevents-x11.c: Fix off-by-one allocation
1421 errors. (#143337, Billy Biggs)
1423 Thu May 27 16:36:22 2004 Owen Taylor <otaylor@redhat.com>
1425 * gdk/x11/gdkcolor-x11.c (gdk_colormap_alloc_colors): Set
1426 bits within visual->depth that aren't used for color to
1427 1s, in case they are alpha.
1429 2004-05-27 Anders Carlsson <andersca@gnome.org>
1431 * gtk/gtkfilechooserdefault.c (save_folder_combo_create):
1432 Make separator rows insensitive.
1434 Thu May 27 00:48:16 2004 Matthias Clasen <maclas@gmx.de>
1436 * gtk/gtkentrycompletion.c (gtk_entry_completion_set_text_column):
1439 Thu May 27 00:45:07 2004 Matthias Clasen <maclas@gmx.de>
1441 * gtk/gtkentrycompletion.h:
1442 * gtk/gtkentrycompletion.c (gtk_entry_completion_get_text_column):
1443 Getter for text_column. Also make ::text_column a property.
1445 Thu May 27 00:11:01 2004 Matthias Clasen <maclas@gmx.de>
1447 * gtk/gtkmenuitem.c (gtk_menu_item_size_request): Fix a typo.
1449 Thu May 27 00:07:47 2004 Jonathan Blandford <jrb@gnome.org>
1451 * gtk/gtkcombobox.c (gtk_combo_box_list_destroy): only remove the
1452 signal if the box exists.
1454 Wed May 26 23:26:51 2004 Matthias Clasen <maclas@gmx.de>
1456 Support insensitive cells in tree views and combo boxes:
1458 * gtk/gtkcellrenderer.h:
1459 * gtk/gtkcellrenderer.c: Add a ::sensitive property.
1461 * gtk/gtkcellrendererpixbuf.c (gtk_cell_renderer_pixbuf_render):
1462 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_render):
1463 * gtk/gtkcellrenderertoggle.c (gtk_cell_renderer_toggle_render):
1464 Support drawing insensitive.
1466 * gtk/gtkcellview.h:
1467 * gtk/gtkcellview.c (gtk_cell_view_get_cell_renderers): New
1468 function to obtain the cell renderers from a cell view. Also
1469 export gtk_cell_view_set_cell_data().
1471 * gtk/gtktreeselection.c (tree_column_is_sensitive):
1472 * gtk/gtktreeselection.c (row_is_selectable): Helper functions
1473 to determine whether all visible cells in a row are insensitive
1474 and whether a row is selectable. A row is not selectable if the
1475 user function says so or if all visible cells are insensitive.
1476 * gtk/gtktreeselection.c (_gtk_tree_selection_internal_select_node):
1477 * gtk/gtktreeselection.c (gtk_tree_selection_real_select_node):
1478 Use row_is_selectable().
1480 * gtk/gtkcombobox.c (row_is_sensitive):
1481 * gtk/gtkcombobox.c (tree_column_row_is_sensitive):
1482 * gtk/gtkcombobox.c (menu_row_is_sensitive): Helper functions
1483 to determine row sensitivity in menu or list mode.
1485 * gtk/gtkcombobox.c (update_menu_sensitivity): Helper function
1486 to set up sensitivity menu items from the underlying rows.
1488 * gtk/gtkcombobox.c (gtk_combo_box_popup):
1489 * gtk/gtkcombobox.c (gtk_combo_box_menu_button_press): Use
1490 update_menu_sensitivity().
1492 * gtk/gtkcombobox.c (gtk_combo_box_list_setup): Setup the cell
1495 * gtk/gtkcombobox.c (gtk_combo_box_key_press): Skip insensitive
1498 * tests/testcombo.c (main): Make some rows insensitive.
1500 2004-05-26 Robert Ögren <gtk@roboros.com>
1502 * gdk/win32/gdkinput-win32.c (_gdk_input_other_event): Send key
1503 modifiers (shift, ctrl etc) in button and motion events from the
1506 2004-05-26 Robert Ögren <gtk@roboros.com>
1508 * gdk/win32/gdkinput-win32.c (gdk_device_get_state): Simple
1509 implementation for extended input devices using last known
1510 device state (#143237)
1512 Tue May 25 21:54:00 2004 Matthias Clasen <maclas@gmx.de>
1514 * gtk/gtkframe.c: Move docs inline, fixing them on the
1515 way. (#143029, Steve Chaplin)
1517 2004-05-11 Robert Ögren <gtk@roboros.com>
1519 * gdk/win32/gdkevents-win32.c (propagate): Don't propagate mouse
1520 events to windows that want extended input events. (#142943)
1521 (gdk_event_translate): Move check for extended input devices to
1522 propagate, new parameter to propagate.
1523 (gdk_pointer_grab, gdk_display_pointer_ungrab): Enable calls to
1524 _gdk_input_(un)grab_pointer. (#142943)
1526 * gdk/win32/gdkinput-win32.c (_gdk_input_other_event): Check for
1527 input grab. [Fix missing update of impl in "dijkstra" event
1528 propagation loop] Drop the parallel "impl" pointer, just use a
1529 cast. Don't propagate beyond windows that want normal input
1531 (gdk_input_grab_pointer, gdk_input_ungrab_pointer): Limited
1532 implementation of input grab. (#142943)
1534 2004-05-22 Tor Lillqvist <tml@iki.fi>
1536 * gdk/win32/gdkinput-win32.c (print_lc): Remove duplicated
1537 line. (Spotted by Benoît Carpentier.)
1539 2004-05-18 Matthias Clasen <mclasen@redhat.com>
1541 * configure.in: Check for XFIXES extension.
1543 * gdk/x11/gdkdisplay-x11.h (struct _GdkDisplayX11): Add
1544 a gboolean have_xfixes member.
1546 * gdk/x11/gdkdisplay-x11.c (gdk_display_open): Register
1547 XFIXES events and set have_xfixes.
1549 * gdk/gdkevents.h (GdkEventType): Add GDK_OWNER_CHANGE.
1550 (GdkEventOwnerChange): New event struct for owner change events.
1551 (GdkOwnerChange): New enum for the reason field of GdkEventOwnerChange.
1553 * gdk/x11/gdkevents-x11.c (gdk_event_translate): Translate
1554 XFixesSelectionNotify events into GdkEventOwnerChange events.
1557 * gdk/x11/gdkdisplay-x11.c (gdk_display_supports_selection_notification):
1558 (gdk_display_request_selection_notification): New api
1559 to support selection ownership notification.
1561 * gtk/gtkclipboard.h:
1562 * gtk/gtkclipboard.c (_gtk_clipboard_handle_event): New private
1563 api to handle owner change events.
1564 (clipboard_peek): Refactored out the body of
1565 gtk_clipboard_get_for_display() for use in _gtk_clipboard_handle_event().
1567 * gtk/gtkmain.c (gtk_main_do_event): Handle GDK_OWNER_CHANGE events
1568 by calling _gtk_clipboard_handle_event().
1570 2004-05-18 Matthias Clasen <mclasen@redhat.com>
1572 * gtk/gtkintl.h: Include glib/gi18n-lib.h and only define
1573 the P_() macros ourselves.
1575 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
1576 Restrict the width of the popup to be no larger than the
1577 monitor. (#142678, DmD Ljungmark)
1579 * gtk/gtkbutton.c: Go back to the initial fix for the
1580 focus-overdrawing problem, which was actually correct
1581 according to docs/widget_geometry.txt.
1583 * gtk/gtkarrow.c (gtk_arrow_class_init): Bump the initial
1584 arrow size from 11 to 15 to compensate for that.
1586 * gtk/gtktextview.c (gtk_text_view_class_init): Document the
1587 arguments of the ::move-cursor signal. (#142725)
1589 2004-05-17 Matthias Clasen <mclasen@redhat.com>
1593 * gtk/gtkbutton.c (gtk_button_size_request)
1594 (gtk_button_size_allocate, _gtk_button_paint): Allocate
1595 space for the focus rectangle only if necessary. (#142668,
1598 Sun May 16 23:11:47 2004 Matthias Clasen <maclas@gmx.de>
1602 * gtk/gtkhruler.c (gtk_hruler_draw_ticks): Remove two useless
1603 lines. (#142479, Morten Welinder)
1605 Sun May 16 22:27:17 2004 Matthias Clasen <maclas@gmx.de>
1607 * gtk/gtkintl.h (Q_): Add a Q_() macro.
1609 * gtk/gtkcellrendererprogress.h: Remove GTK_PROGRESS_CELL_UNKNOWN
1610 and GTK_PROGRESS_CELL_FAILED. With the ability the set the label,
1611 they are not really needed.
1613 * gtk/gtkcellrendererprogress.c: Use the xpad and ypad properties
1614 instead of hardwired padding, use Q_() for the default label,
1615 compute a reasonable minimal size. (#142571, #142572, #142573,
1616 Tommi Komulainen, Christian Persch)
1618 2004-05-15 Tor Lillqvist <tml@iki.fi>
1620 * gdk/win32/gdkdnd-win32.c: Put back the ref_count field in the
1621 GdkDragContextPrivateWin32 struct (but inside ifdef OLE2_DND this
1622 time). It is used by the OLE2_DND code, which is unfinished and
1623 presumably horribly broken, but still, let's not make it not
1624 compile on purpose. Silence some gcc warnings in the OLE2_DND
1627 2004-05-14 Matthias Clasen <mclasen@redhat.com>
1629 * gtk/gtktreeview.c (gtk_tree_view_tree_window_to_tree_coords):
1630 New function to go from tree window to tree coordinates, kept
1631 static for now until we figure out the multiple coordinate
1632 system mess in GtkTreeView API-wise.
1633 (gtk_tree_view_scroll_to_cell): Transform the coordinates
1634 from tree window to tree coordinates, using the new function.
1635 Previously, the x coordinate was wrongly transformed. (#142494)
1637 * gdk/gdktypes.h (GdkModifierType): Add a comment about unused
1640 * gtk/gtkstock.c (real_add, gtk_stock_lookup): Use an unused
1641 modifier bit to mark stock item which need to be freed
1642 eventually. (#140654, Michal Pasternak, Scott Tsai)
1644 2004-05-11 Robert Ögren <gtk@roboros.com>
1646 * gdk/win32/gdkevents-win32.c (gdk_event_translate): Add missing
1647 call to g_object_ref in Wintab code. (#138341)
1649 * gdk/win32/gdkinput-win32.c: Fix numerous Wintab problems
1650 including unallocated buffers for event->motion.axes and
1651 event->button.axes, unsigned wraparound problem in the code for
1652 detecting missing press/release events and assigning min instead
1653 of max when setting up axes.
1655 2004-05-12 Matthias Clasen <mclasen@redhat.com>
1657 * tests/testtreeedit.c: Add a progress column.
1659 * gtk/Makefile.am: Add gtkcellrendererprogress.[hc] in the right
1662 * gtk/gtk.h: Include gtkcellrendererprogress.h.
1664 * gtk/gtkcellrendererprogress.[hc]: A progress cell renderer,
1665 based on the one found in Epiphany.
1667 2004-05-11 Michael Natterer <mitch@gimp.org>
1669 * gtk/gtkcombobox.c (gtk_combo_box_popup)
1670 (gtk_combo_box_menu_button_press): don't allocate the popup
1671 smaller than the combobox. Fixes bug #59660.
1673 2004-05-11 Matthias Clasen <mclasen@redhat.com>
1675 * gtk/gtkuimanager.c (gtk_ui_manager_get_widget): Revert the
1676 previous change to this function, clarify the docs instead.
1678 * gtk/gtkcombobox.c (gtk_combo_box_list_setup): Use
1679 GTK_SELECTION_BROWSE.
1681 * gtk/gtktreeview.c: Make hover selection work for
1682 GTK_SELECTION_BROWSE as well.
1684 Tue May 11 00:38:25 2004 Matthias Clasen <maclas@gmx.de>
1686 * gtk/gtkcellrenderertoggle.c (gtk_cell_renderer_toggle_class_init):
1687 Document the ::toggled signal.
1689 Mon May 10 23:04:25 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1691 * gtk/gtkwidget.h: Add prototype for _gtk_widget_grab_notify()
1693 2004-05-10 Matthias Clasen <mclasen@redhat.com>
1695 * gtk/gtkwindow.c (get_screen_icon_info): Make static.
1697 * gdk/gdkdisplay.c (singlehead_...):
1698 * gdk/x11/gdkkeys-x11.c (get_effective_keymap):
1699 * gdk/x11/gdkgeometry-x11.c (expose_serial_predicate):
1700 * gdk/x11/gdkdisplay-x11.c (escape_for_xmessage): Make static.
1702 * gtk/gtktreeview.c (gtk_tree_view_set_fixed_height_mode): Add a
1703 note about COLUMN_FIXED restriction.
1705 * gtk/gtkentrycompletion.c (gtk_entry_completion_list_button_press):
1706 Set the entry in the default handler of the ::match-selected signal.
1709 * gtk/gtkcombobox.c (gtk_combo_box_menu_position_below): If we don't
1710 do the move-selected-item below pointer thingie, do the
1711 place-below-or-above one.
1713 * tests/testentrycompletion.c: Make the second example use the
1714 ::match-selected signal to make it actually work.
1716 * gtk/gtkentrycompletion.c (gtk_entry_completion_init):
1717 * gtk/gtkcombobox.c (gtk_combo_box_list_setup): Use hover selection
1718 mode. (#127648, Dave Bordoley)
1720 * gtk/gtktreeview.h:
1721 * gtk/gtktreeview.c: Add a new property "hover_selection", which
1722 when TRUE makes the selection follow the mouse. Also add setter
1723 and getter for the fixed_height property.
1725 2004-05-10 Matthias Clasen <mclasen@redhat.com>
1727 * gtk/gtkcombobox.c (gtk_combo_box_popup)
1728 (gtk_combo_box_menu_button_press): Make sure the menu pops up
1729 as wide as the combobox. (#59660, Havoc Pennington)
1731 2004-05-10 Matthias Clasen <mclasen@redhat.com>
1733 * gtk/gtkcombobox.h:
1734 * gtk/gtkcombobox.c: Support tearoffable combo boxes (in menu
1735 mode). Add a new property, add-tearoffs, for this. (#135956)
1737 * gtk/gtkfontsel.c (list_row_activated): Make Return activate the
1738 default button. (#118921)
1740 Mon May 10 15:03:50 2004 Soeren Sandmann <sandmann@daimi.au.dk>
1742 * gtk/gtkwidget.c (_gtk_widget_grab_notify): New internal function
1743 that emits the grab notify signal.
1745 * gtk/gtkmain.c (gtk_grab_notify_foreach): Use it here.
1747 Mon May 10 00:48:08 2004 Matthias Clasen <maclas@gmx.de>
1749 * gtk/gtkmenu.c: Make destruction of a torn off menu work
1750 like un-tearing off.
1752 Sun May 9 21:05:38 2004 Matthias Clasen <maclas@gmx.de>
1756 * gtk/gtkactiongroup.c (gtk_action_group_add_action_with_accel):
1757 Allow to suppress the stock accelerator by using "". (#142196,
1760 Sun May 9 02:01:13 2004 Matthias Clasen <maclas@gmx.de>
1764 * gtk/gtkcombobox.c (gtk_combo_box_list_button_released):
1765 In list mode, accept the same mouse/wheel bindings on
1766 the cellview as on the button. (#136967)
1768 Sun May 9 01:25:37 2004 Matthias Clasen <maclas@gmx.de>
1770 * gtk/gtkiconfactory.c (add_to_cache): Actually count the
1771 cached icons. (#135888, Crispin Flowerday)
1773 Sun May 9 00:03:03 2004 Matthias Clasen <maclas@gmx.de>
1775 * gtk/gtkuimanager.c (gtk_ui_manager_get_widget): Make sure
1776 that we actually return menus for nodes of type menu, not the
1777 menuitems they're attached to.
1779 Sat May 8 22:50:55 2004 Matthias Clasen <maclas@gmx.de>
1781 * gtk/gtkactiongroup.c (gtk_action_group_set_translation_domain):
1782 Add a note regarding UTF-8 requirements, proposed by
1783 Mariano Suárez-Alvarez.
1785 Sat May 8 22:43:11 2004 Matthias Clasen <maclas@gmx.de>
1787 * gtk/gtktearoffmenuitem.h:
1788 * gtk/gtktearoffmenuitem.c: Put the torn_off flag back
1789 into the GtkTearoffMenuItem struct, since it is used
1790 by the Gimp, and keep it synchronized with the
1791 tearoff_state property of the parent menu.
1793 2004-05-08 Hans Breuer <hans@breuer.org>
1795 * gtk/gtkfilesystemwin32.c (extract_icon) : finally also
1796 create the correct mask for 'pseudo mime' icons
1798 * gdk/win32/gdkwindow-win32.c(show_window_internal) : also
1799 take focus_on_map into account
1801 * gtk/gtkselection.c : g_message() only with DEBUG_SELECTION
1803 * gtk/gtkactiongroup.c gtk/gtkcombobox.c :
1804 ... must return a value
1806 * gdk/gdk.def gtk/gtk.def demos/gtk-demo/makefile.msc.in : updated
1808 2004-05-07 Matthias Clasen <mclasen@redhat.com>
1810 * gtk/gtkbutton.c (gtk_button_size_allocate): Don't let the child
1811 draw over the focus rectangle.
1813 * gtk/gtkhsv.c: Draw focus indication in the color wheel using
1814 standard focus style. (#63071, Bill Haneman, idea for new
1815 style by Owen Taylor)
1817 * gtk/gtkstyle.c (gtk_default_draw_focus): Support drawing on
1818 focus on the colorwheel via details.
1820 2004-05-06 Matthias Clasen <mclasen@redhat.com>
1824 * gtk/gtkcombobox.c (gtk_combo_box_menu_state_changed): Remove
1825 this no longer needed signal handler. (#141817, Paul Pogonyshev)
1827 Fri May 7 00:41:46 2004 Matthias Clasen <maclas@gmx.de>
1829 * gtk/gtktearoffmenuitem.h:
1830 * gtk/gtktearoffmenuitem.c: Make the tearoff
1831 functionality model/view, the tearoffmenuitem being
1832 the view and the tearoff_state property of the menu
1833 being the model. (#101185, Owen Taylor)
1835 * gtk/gtkmenu.c: Add a tearoff_state property.
1837 Thu May 6 23:52:13 2004 Matthias Clasen <maclas@gmx.de>
1841 * gtk/gtkmenuitem.c (gtk_menu_item_select_timeout): Also
1842 popup the submenu for items in torn off menus. (#122051)
1844 2004-05-06 Sven Neumann <sven@gimp.org>
1846 * gtk/gtkexpander.c (gtk_expander_size_allocate): in RTL mode,
1847 position the title lable next to the arrow just as we do for LTR
1848 rendering. Fixes bug #141825.
1850 2004-05-06 Matthias Clasen <mclasen@redhat.com>
1852 * docs/RELEASE-HOWTO: Document the new policy of
1853 bumping version numbers after release.
1855 * configure.in: Bump version number to 2.5.0.
1857 2004-05-06 Padraig O'Briain <padraig.obriain@sun.com>
1860 * gtk/gtkmenu.c: Add new function gtk_menu_get_for_attach_widget.
1863 Thu May 6 00:24:11 2004 Matthias Clasen <maclas@gmx.de>
1865 * gtk/gtkactiongroup.h:
1866 * gtk/gtkactiongroup.c (gtk_action_group_translate_string):
1867 New function to translate a string with translate_func.
1870 Thu May 6 00:02:21 2004 Matthias Clasen <maclas@gmx.de>
1872 * gtk/gtkcombobox.c (gtk_combo_box_get_wrap_width):
1873 (gtk_combo_box_get_row_span_column):
1874 (gtk_combo_box_get_column_span_column): Add missing getters
1875 for readwrite properies. (#135649)
1877 Wed May 5 23:42:42 2004 Matthias Clasen <maclas@gmx.de>
1879 * gtk/gtkcombobox.h:
1880 * gtk/gtkcombobox.c (gtk_combo_box_get_active_text):
1881 Add gtk_combo_box_get_active_text() convenience
1882 function. (#136372, Christian Neumeir, patch by Olivier Andrieu)
1884 2004-05-05 Elijah Newren <newren@math.utah.edu>
1886 Changes to support do-not-focus-on-map hint in conjunction with
1887 _NET_WM_USER_TIME (#115650):
1889 * gdk/gdkwindow.h (struct _GdkWindowObject): Add a new boolean
1892 * gdk/gdkwindow.h (gdk_window_set_accept_focus): New function to
1895 * gtk/gtkwindow.[hc]: Add a boolean property "focus_on_map"
1896 and gtk_window_get_focus_on_map() and gtk_window_set_focus_on_map().
1898 * gdk/win32/gdkwindow-win32.c (gdk_window_new):
1899 * gdk/linux-fb/gdkwindow-fb.c (gdk_window_new):
1900 * gdk/x11/gdkwindow-x11.c (gdk_window_new):
1901 Initialize the focus_on_map field to TRUE.
1903 * gdk/win32/gdkwindow-win32.c (gdk_window_set_focus_on_map):
1904 * gdk/linux-fb/gdkwindow-fb.c (gdk_window_set_focus_on_map):
1905 * gdk/x11/gdkwindow-x11.c (gdk_window_set_focus_on_map):
1906 * gdk/x11/gdkwindow-x11.c (setup_toplevel_window):
1907 Implementations for the various backends. The Win32 and linux-fb
1908 implementations set the focus_on_map field, but don't use it yet
1909 to actually implement noinput windows. The X implementation sets
1910 _NET_WM_USER_TIME to 0 if focus_on_map is FALSE (see the EWMH).
1912 * gdk/x11/gdkwindow-x11.h:
1913 * gdk/x11/gdkevents-x11.c (set_user_time):
1914 * gdk/x11/gdkinput-x11.c (_gdk_input_common_other_event):
1915 * gdk/x11/gdkwindow-x11.c (gdk_x11_window_set_user_time):
1916 s/_gdk_x11_window_set_user_time/gdk_x11_window_set_user_time/,
1917 since we want that function to be part of the public API.
1919 Wed May 5 22:20:21 2004 Matthias Clasen <maclas@gmx.de>
1923 * gtk/gtkiconfactory.c (icon_source_clear): Don't
1924 call g_free() on a pixbuf. (#141961, Crispin Flowerday)
1926 2004-05-05 Matthias Clasen <mclasen@redhat.com>
1930 * gtk/gtkuimanager.c (print_node): Make the output
1931 parseable. (#141929, Sven Neumann)
1933 2004-05-05 Tor Lillqvist <tml@iki.fi>
1935 * gdk/win32/gdkdnd-win32.c (gdk_drag_find_window_for_screen): Add
1936 multi-monitor offset. (#141842, John Ehresman)
1938 2004-05-04 Federico Mena Quintero <federico@ximian.com>
1940 Fixes #139562, based on a patch by Christian Neumair.
1942 * gtk/gtkfilechooserdefault.c (struct _GtkFileChooserDefault): Add
1943 a filter_combo_hbox field to contain the filter combo.
1944 (show_filters): Show/hide the filter_combo_hbox.
1945 (create_filename_entry_and_filter_combo): Removed.
1946 (file_pane_create): Create the filter_combo_hbox here.
1948 2004-05-04 Matthias Clasen <mclasen@redhat.com>
1950 * modules/input/gtkimcontextxim.c: Fix the recent
1951 string_conversion_callback change to work on
1952 Solaris. (#141190, Padraig O'Briain)
1954 * gtk/gtkselection.c: Disable debug logging again.
1956 2004-05-03 Matthias Clasen <mclasen@redhat.com>
1958 * gtk/gtkselection.c: Make the chunk size for
1959 incremental transfers depend on the maximal request
1960 size, capped at 256k. This should allow most selections
1961 to be transferred nonincrementally, avoiding many
1962 roundtrips and protocol overhead.
1964 2004-05-03 Federico Mena Quintero <federico@ximian.com>
1966 * gtk/gtkuimanager.c (gtk_ui_manager_class_init): Call
1967 g_signal_new() correctly and initialize the signal fields. Fixes
1968 #141749; patch based on Michael Natterer's.
1970 u2004-05-03 Matthias Clasen <mclasen@redhat.com>
1972 * gtk/gtkselection.c (_gtk_selection_request): Fix
1973 a debug message to show correct information.
1974 (_gtk_selection_incr_event): Make INCRemental transfer
1975 of MULTIPLE targets work. This was broken since 1997!
1977 2004-05-02 Hans Breuer <hans@breuer.org>
1979 * gdk/win32/gdkdrawable-win32.c (draw_segments) : don't
1980 modify the passed in GdkSegment(s) in place, we may get
1981 them again to draw at the same place. Fixes bug #129095,
1983 (draw_segments) draw the end pixel again to get the
1984 pixmap mask right, fixes bug #126710, #130202
1986 * gdk/win32/gdkwindow-win32.c : use SetForegroundWindow,
1987 fixes bug #106013, John Ehresman
1989 * gtk/makefile.msc.in : don't try to link gtk.res but
1990 use gtk-win32.res (as supposed to be fixed below :)
1992 2004-05-01 Hans Breuer <hans@breuer.org>
1994 * tests/Makefile.am : tests/makefile.msc is in CVS for
1995 a long time, finally added to EXTRA_DIST : fixes bug
1996 #141334, John Ehresman
1998 2004-04-30 Matthias Clasen <mclasen@redhat.com>
2000 * === Released 2.4.1 ===
2002 * configure.in: Version 2.4.1, interface age 1.
2006 2004-04-29 Federico Mena Quintero <federico@ximian.com>
2010 * gtk/gtkfilechooserdefault.c (remove_selected_bookmarks): New
2011 function; moved the code over from
2012 remove_bookmark_button_clicked_cb().
2013 (remove_selected_bookmarks): Now, getting a non-removable bookmark
2014 is not an error, as we may be called as a result of hitting the
2016 (shortcuts_key_press_event_cb): New handler; delete the bookmark
2017 if the user presses Backspace, Delete, or KP_Delete.
2019 2004-04-29 Matthias Clasen <mclasen@redhat.com>
2021 * gtk/gtkaction.c (closure_accel_activate): Use
2022 _gtk_action_emit_activate() instead of directly
2023 emitting the activate signal. (#141429, Jody Goldberg)
2025 * gtk/gtkactiongroup.c (gtk_action_group_add_action_with_accel):
2026 Warn people when the accelerator can not be
2027 parsed. (#141429, Jody Goldberg)
2029 2004-04-29 Matthias Clasen <mclasen@redhat.com>
2031 * tests/testentrycompletion.c (main): Add a missing
2032 cat. (#141070, Chris Sherlock)
2034 * gtk/gtkrc.c (gtk_rc_check_pixmap_dir): Remove unused
2035 variable. (#141022, Chris Sherlock)
2037 * gtk/gtkcombo.c (gtk_combo_popup_list): Add a missing
2038 cast. (#141013, Chris Sherlock)
2040 * gtk/gtkcellview.c (gtk_cell_view_cell_layout_clear): Remove
2041 unused variable. (#141011, Chris Sherlock)
2043 2004-04-29 Tor Lillqvist <tml@iki.fi>
2045 * gdk/win32/gdkgc-win32.c (gdk_win32_gc_set_dashes): Plug memory
2046 leak. (#140775, John Ehresman)
2048 Thu Apr 29 01:09:50 2004 Matthias Clasen <maclas@gmx.de>
2050 * gdk/gdkdraw.c (_gdk_drawable_get_scratch_gc): Use depth - 1
2051 to index the cached gcs, not depth. (#139494)
2053 2004-04-28 Matthias Clasen <mclasen@redhat.com>
2055 * gdk/gdkdraw.c (_gdk_drawable_get_scratch_gc): Docs typo fix.
2057 Sun Apr 25 15:36:02 2004 Soeren Sandmann <sandmann@daimi.au.dk>
2059 * gtk/gtktoolbutton.c (gtk_tool_button_set_label_widget): Fix
2060 cut'n'paste-o from previous commit. (#141046, Torsten Schoenfeld).
2062 2004-04-24 Theppitak Karoonboonyanan <thep@linux.thai.net>
2064 Patch to add support for string conversion callbacks to
2065 GtkIMContextXIM (#101814)
2067 * modules/input/gtkimcontextxim.c: Set the string conversion callback
2068 if supported by the XIC.
2070 (struct _GtkIMContextXIM): Add string_conversion_callback member.
2072 (struct _GtkXIMInfo, setup_im): Check and keep flag inidicating
2073 whether string conversion callback is supported.
2075 (gtk_im_context_get_ic, +set_string_conversion_callback,
2076 +string_conversion_callback): Also initialize string conversion
2077 callback, if supported, along with the IC initialization.
2079 * modules/input/imxim.c: Make "xim" module default for Thai as well.
2081 2004-04-23 Matthias Clasen <mclasen@redhat.com>
2083 * gtk/gtkclipboard.c (gtk_clipboard_wait_for_targets): Correctly
2084 initialize targets. (#139883, John Finlay)
2086 * gdk/gdkdraw.c (gdk_draw_drawable): Small doc improvement.
2088 * gtk/gtktreeselection.c (gtk_tree_selection_get_selected_rows):
2089 Don't recommend gtk_tree_row_reference_new_proxy(). (#138309,
2090 Tim-Philipp Müller)
2092 * gtk/gtktreeviewcolumn.c (gtk_tree_view_column_cell_set_cell_data):
2093 Remove an excessive g_return_if_fail().
2095 * gdk/x11/gdkevents-x11.c (set_user_time): Make set_user_time()
2097 * gdk/x11/gdkinput-x11.c (_gdk_input_common_other_event):
2098 _-prefix calls of gdk_x11_window_set_user_time().
2100 2004-04-22 Matthias Clasen <mclasen@redhat.com>
2102 * gtk/gtkuimanager.c (update_node): Make sure the separators
2103 used to demarkate placeholder ends don't show up on
2104 show_all(). (#140496, Murray Cumming)
2106 * gtk/gtkspinbutton.c (spin_button_at_limit): Make spinbuttons
2107 work with negative increments. (#137975, Tim Gerla)
2109 Wed Apr 21 21:38:03 2004 Soeren Sandmann <sandmann@daimi.au.dk>
2111 * gtk/gtktoolbutton.c (gtk_tool_button_set_label_widget,
2112 gtk_tool_button_set_icon_widget): Remove the old widget from the
2113 tool button before overwriting it with the new widget.
2115 (#140508, Todd Goyen)
2117 2004-04-22 Tor Lillqvist <tml@iki.fi>
2119 Fix the file chooser on Windows. I can't make it misbehave or
2120 crash any more now. But presumably there are still corner cases
2121 not handled. I haven't really checked behaviour of UNC paths, for
2124 * gtk/gtkfilesystemwin32.c: Accept both backslash and slash in
2125 several places. Use G_IS_DIR_SEPARATOR macro (which could be added
2128 (gtk_file_system_win32_get_parent): Like the Unix version, assert
2129 filename is absolute, and avoid one unnecessary string allocation
2132 (canonicalize_filename,gtk_file_system_win32_parse): Handle drive
2133 letters more correctly.
2135 (gtk_file_system_win32_render_icon): Assure correct syntax is used
2136 for root folder of a drive. (#137962, Morten Welinder)
2138 (filename_is_some_root): New function that accepts also root
2139 without any drive specified.
2141 (filename_is_drive_root): Rename from filename_is_root.
2143 * gtk/gtkfilechooserentry.c (completion_match_func): Casefold on
2146 2004-04-21 Matthias Clasen <mclasen@redhat.com>
2148 * gtk/gtkentry.c (gtk_entry_completion_timeout): Pop down the
2149 completion window if there are no completions anymore.
2151 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
2152 Don't call gtk_tree_view_scroll_to_cell() on an empty tree view.
2153 It doesn't like that. (#140642, Christian Persch)
2155 * demos/gtk-demo/expander.c (do_expander): A new demo.
2157 * demos/gtk-demo/Makefile.am (demos): Add expander.c.
2159 2004-04-20 Matthias Clasen <mclasen@redhat.com>
2161 * gtk/gtktextview.c (gtk_text_view_allocate_children): Make
2162 sure anchored children get size allocated, even if the layout
2163 is valid. (#122323, Andrew E. Makeev)
2164 (gtk_text_view_scroll_pages):
2165 (gtk_text_view_scroll_hpages): Don't scroll to cursor position
2166 if we already have pending scrolls. Bandaid fix for #78513.
2168 Mon Apr 19 17:59:17 2004 Owen Taylor <otaylor@redhat.com>
2170 * INSTALL.in: Update libpng and libjpeg URLs, remove
2171 note about building without since that's not the normal
2174 Sun Apr 11 09:45:11 2004 Owen Taylor <otaylor@redhat.com>
2176 * gtk/gtkicontheme.c (load_themes): Fix a couple of typos in
2177 handling of SVG/non-SVG unthemed icons.
2179 2004-04-19 Morten Welinder <terra@gnome.org>
2181 * gtk/gtktoolbar.c (gtk_toolbar_focus): Don't leak list of
2184 2004-04-19 Matthias Clasen <mclasen@redhat.com>
2186 * gtk/gtktextbtree.c (_gtk_text_line_previous_could_contain_tag):
2187 Don't stop the iteration up to the tag_root too
2188 early. (#109945, Dongho Shin)
2190 Sun Apr 18 17:06:03 2004 Soeren Sandmann <sandmann@daimi.au.dk>
2192 * gdk/x11/gdkkeys-x11.c (get_effective_keymap): Make
2193 gdk_keymap_translate_keyboard_state() handle NULL
2194 keymaps. (#139715, Torsten Schoenfeld).
2196 Sun Apr 18 16:59:21 2004 Soeren Sandmann <sandmann@daimi.au.dk>
2198 * configure.in: Don't erase GDK_EXTRA_CFLAGS. Fixes bug 139586,
2199 reported by Pedro RODRIGUEZ, about compilation problems when
2200 Xcursor is installed in a non-standard location.
2202 Sun Apr 18 16:15:15 2004 Soeren Sandmann <sandmann@daimi.au.dk>
2204 Support for _NET_WM_USER_TIME (bug 115650). Patch by Elijah
2207 * gdk/x11/gdkwindow-x11.[ch]: Add new internal function
2208 _gdk_x11_set_user_time() to set the _NET_WM_USER_TIME property.
2210 * gdk/x11/gdkdisplay-x11.h (struct _GdkDisplayX11): Add user_time field
2212 * gdk/x11/gdkdisplay-x11.c: Add _NET_WM_USER_TIME to list of
2215 * gdk/x11/gdkinput-x11.c, gdk/x11/gdkevents-x11.c: Set the
2216 property on user interaction.
2218 2004-04-15 Federico Mena Quintero <federico@ximian.com>
2220 * gtk/gtkfilesel.c (open_new_dir): Tell the user to use
2221 G_FILENAME_ENCODING, not G_BROKEN_FILENAMES. Fixes #114065.
2223 * gtk/gtkfilechooserdefault.c (split_uris): Use a variant of the
2224 code from gtkfilesel.c to parse a "text/uri-list" blob. Fixes
2227 2004-04-15 Matthias Clasen <mclasen@redhat.com>
2229 * gtk/gtkcellrenderer.c (gtk_cell_renderer_class_init):
2230 * gtk/gtkbutton.c (gtk_button_class_init): Doc fixes.
2232 2004-04-14 Matthias Clasen <mclasen@redhat.com>
2234 * gtk/gtkcombobox.c:
2236 Make all style properties readonly.
2238 2004-04-14 Matthias Clasen <mclasen@redhat.com>
2240 * gtk/gtkcolorsel.c: Add a11y relations between the color
2241 wheel and the spin buttons. (#132745, Padraig O'Briain)
2243 * gtk/gtkiconfactory.c (gtk_icon_set_render_icon): Document
2244 the meaning of size == -1.
2246 * gtk/gtkwidget.c (gtk_widget_render_icon): Explicitly accept
2247 a size of -1. (#137436, Brian Cameron)
2249 * gtk/gtkcombobox.c: Make the arrow and separator regular
2250 children of an hbox inside the button, and propagate state
2251 changes from the button to the cell view. (part of the fix
2252 for #138650, should also fix #137535)
2254 * gtk/gtkcellview.c (gtk_cell_view_expose): Pass the PRELIT
2255 state to gtk_cell_renderer_render() when prelighted. (part
2256 of the fix for #138650)
2258 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_render):
2259 Use PRELIGHT state when appropriate. (part of the fix for
2262 * gtk/gtkcombobox.c (gtk_combo_box_relayout): Don't spit
2263 out warnings if called before the combo box is
2264 realized. (#139742, Philip Langdale)
2266 Wed Apr 14 03:45:39 2004 Jonathan Blandford <jrb@gnome.org>
2268 * gtk/gtktreeview.c (gtk_tree_view_expose): propagate expose
2271 Wed Apr 14 03:32:58 2004 Jonathan Blandford <jrb@gnome.org>
2273 * gtk/gtkpathbar.c (make_directory_button): remove spurious
2276 Tue Apr 13 16:19:23 2004 Jonathan Blandford <jrb@redhat.com>
2278 * gtk/gtkpathbar.c (make_directory_button): patch from Owen to
2279 make the buttons sized by a bold label. This makes the text
2280 'swim' a little, but stops the buttons from resizing, #137210
2282 2004-04-13 Matthias Clasen <mclasen@redhat.com>
2284 * gtk/gtkuimanager.c (get_child_node): Don't crash if a node
2286 (start_element_handler): Accept separators without unique
2287 names. (#133302, Anders Carlsson)
2289 * gtk/gtkactiongroup.c (gtk_action_group_add_action): Document
2290 possible accelerator gotcha when using this function. (#139641,
2293 * gtk/gtkuimanager.c (node_remove_ui_reference): Don't leak
2294 list nodes. (#138862, Morten Welinder)
2296 Tue Apr 13 12:24:49 2004 Jonathan Blandford <jrb@redhat.com>
2298 * gtk/gtktreeview.c (gtk_tree_view_destroy): remove unused
2300 (gtk_tree_view_button_press): If we activated the row we don't
2301 want to grab focus back, as moving focus to another widget is
2302 pretty common, #138458
2304 2004-04-12 Federico Mena Quintero <federico@ximian.com>
2306 * gtk/gtkfilechooser.c (gtk_file_chooser_class_init): Added
2307 documentation to all the signals.
2309 2004-04-12 Matthias Clasen <mclasen@dhcp64-228.boston.redhat.com>
2311 * gtk/gtkcombobox.c (gtk_combo_box_unset_model): Don't unref
2312 model if it is NULL. (#139770)
2314 * gtk/gtktreeview.c (gtk_tree_view_get_cell_area): Typo fix.
2316 * gtk/gtkentrycompletion.c (gtk_entry_completion_init): Don't add
2317 a shadow inside the scrolled window, add it around the vbox.
2319 * gtk/gtkentryprivate.h:
2320 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
2321 Return a boolean indicating whether the popup is positioned above
2322 or below. Scroll the completions to the beginning or the end,
2323 depending on the positioning.
2325 * gtk/gtkentry.c (gtk_entry_completion_key_press): Make keynav
2326 wrap around in the entry completion popup, and allow GDK_UP to
2327 enter the popup. (#137440)
2329 2004-04-12 Matthias Clasen <mclasen@redhat.com>
2331 * gtk/gtkentry.c (gtk_entry_size_request): Make sure the style is
2332 there before using it.
2334 Sun Apr 11 15:08:45 2004 Jonathan Blandford <jrb@gnome.org>
2336 * gtk/gtktreeprivate.h: Moved search entries into priv data.
2338 * gtk/gtktreeview.c: Prep for type-ahead support.
2340 (gtk_tree_view_destroy): Destroy the search window explicitly.
2341 (gtk_tree_view_key_press): Minor change; prep for type-ahead
2342 (gtk_tree_view_ensure_interactive_directory): New function
2343 (gtk_tree_view_focus_out): Rework to handle new entry life-cycle.
2344 (gtk_tree_view_real_start_interactive_search): rework
2345 (gtk_tree_view_search_dialog_hide): ditto
2346 (gtk_tree_view_search_delete_event): ditto
2347 (gtk_tree_view_search_button_press_event): ditto
2348 (gtk_tree_view_search_key_press_event): ditto
2349 (gtk_tree_view_search_move): ditto
2350 (gtk_tree_view_search_init): ditto
2352 * gtk/gtktreeviewcolumn.c:
2353 (gtk_tree_view_column_cell_layout_clear): remove unused variable.
2355 * tests/testfilechooser.c: (main): change
2357 2004-04-11 Hans Breuer <hans@breuer.org>
2359 * gdk/win32/gdkspawn-win32.c : workaround for bug #137496,
2360 the real fix would involve just another small API breakage,
2361 i.e. gdk_spawn_* using GPid not just gint.
2363 * gtk/makefile.msc.in : build gtk-win32.res, not gtk.res
2365 2004-04-10 Tor Lillqvist <tml@iki.fi>
2367 * gdk/win32/gdkkeys-win32.c (gdk_keymap_translate_keyboard_state):
2368 If both Shift and CapsLock pressed, ignore the shift only for
2369 letters (that would have been affected by the CapsLock). (#139095)
2371 * gdk/win32/gdkglobals-win32.c: Disable tablet support by default,
2372 seems to be even buggier now than it used to be. (#138341)
2373 Initialize _gdk_input_ignore_wintab to TRUE.
2375 * gdk/win32/gdkmain-win32.c: Add --use-wintab switch and
2376 GDK_USE_WINTAB environment variable to turn on tablet support.
2378 2004-04-09 Christian Persch <chpe@cvs.gnome.org>
2380 * gtk/gtkuimanager.c: (gtk_ui_manager_insert_action_group),
2381 (gtk_ui_manager_remove_action_group): Terminate
2382 g_object_[dis]connect() calls with NULL instead of 0.
2385 2004-04-09 Guntupalli Karunakar <karunakar@freedomink.org>
2387 * configure.in: Added "gu" (Gujarati) to ALL_LINGUAS.
2389 2004-04-07 Federico Mena Quintero <federico@ximian.com>
2393 * gtk/gtkfilesystem.c (gtk_file_system_parse): Ensure that the
2394 passed-in 'str' is not NULL.
2396 * gtk/gtkfilesystemunix.c (expand_tilde): New helper function;
2397 expands "~/" or "~foo/" at the beginning of a filename.
2398 (gtk_file_system_unix_parse): Use expand_tilde() before doing
2401 * gtk/gtkfilechooserentry.c
2402 (gtk_file_chooser_entry_maybe_update_directory): Take in a
2403 force_reload argument.
2404 (gtk_file_chooser_entry_changed): If gtk_file_system_parse()
2405 returns an error, set the file_part_pos to -1.
2406 (load_directory_callback): Only populate the model if the
2407 file_part_pos is not -1.
2409 2004-04-06 Pablo Saratxaga <pablo@mandrakesoft.com>
2411 * configure.in: Added Icelandic (is) to ALL_LINGUAS
2413 2004-04-05 Federico Mena Quintero <federico@ximian.com>
2415 * gtk/gtkfilechooserdefault.c (location_popup_handler): Use a
2416 title for SAVE and CREATE_FOLDER modes. Fixes #137272.
2418 * gtk/gtkfilesystemunix.c (gtk_file_system_unix_make_path): Look
2419 for G_DIR_SEPARATOR in the display_name, and err out if it is
2420 present; use the same error message as Nautilus. Fixes #136467.
2422 * gtk/gtkfilechooserdefault.c (file_pane_create): Make the
2423 new-folder button say "Create Fo_lder" rather than "Create
2424 _Folder", so that the mnemonic doesn't conflict with the "Save in
2425 _folder" label. Fixes #136975.
2427 2004-04-05 Federico Mena Quintero <federico@ximian.com>
2429 * gtk/gtkpathbar.c (_gtk_path_bar_set_path): Ref/sink the
2430 buttons. Also, free them correctly upon failure. Based on a
2431 patch by Morten Welinder, fixes #137956.
2433 2004-04-05 Anders Carlsson <andersca@gnome.org>
2435 * gdk/gdk.c (gdk_arg_context_parse): Handle '--' correctly.
2437 Fri Apr 2 17:57:33 2004 Jonathan Blandford <jrb@redhat.com>
2439 * gtk/gtktreeview.c (gtk_tree_view_row_inserted): set the height
2440 correctly for fixed height when inserting a node, #138082
2442 2004-04-01 Federico Mena Quintero <federico@ximian.com>
2446 * gtk/gtkpathbar.h (struct _GtkPathBarClass): Add a
2447 "child_is_hidden" boolean argument to the "path-clicked" signal.
2449 * gtk/gtkpathbar.c (struct _ButtonData): Added a file_is_hidden
2451 (make_directory_button): Take a file_is_hidden argument; put it in
2453 (_gtk_path_bar_set_path): See whether each path component path is
2455 (gtk_path_bar_class_init): Add the file_is_hidden argument to the
2456 "path-clicked" signal.
2457 (button_clicked_cb): See if the downwards button represents a
2458 hidden file for the file_is_hidden argument in the signal
2461 * gtk/gtkmarshalers.list: Added a signal type VOID:POINTER,BOOLEAN.
2463 * gtk/gtkfilechooserdefault.c
2464 (gtk_file_chooser_default_select_path): If we fail to switch
2465 folders, don't try to select the path in the file system model.
2466 Also, return the result from _gtk_file_system_model_path_do().
2467 (gtk_file_chooser_default_select_path): Turn on show_hidden in the
2468 file system model if we are asked to select a hidden file.
2469 (path_bar_clicked): Show hidden files based on whether the
2470 immediate downwards folder in the path bar is a hidden file
2472 (struct _GtkFileChooserDefault): Added fields
2473 browse_files_popup_menu and browse_files_popup_menu_hidden_files_item.
2474 (create_file_list): Set an object data key of
2475 "GtkFileChooserDefault" on the tree view so that we can find the
2476 impl from the popup menu callbacks. Also, hook up to the
2477 "button-press-event" and "popup-menu" signals in the file list to
2478 bring up a popup menu.
2479 (list_popup_menu_cb): New callback.
2480 (list_button_press_event_cb): New callback.
2484 * gtk/gtkfilesystemmodel.c
2485 (_gtk_file_system_model_new): Oops, connect_object to
2488 2004-03-31 Tor Lillqvist <tml@iki.fi>
2490 * configure.in: Move AC_CANONICAL_HOST earlier, before the check
2491 for native Win32. (#136559, J. Ali Harlow)
2493 * gdk/win32/gdkdrawable-win32.c (draw_arc): Use X11 semantics for
2494 angles. Thanks to Tim Newsham.
2496 2004-03-29 Federico Mena Quintero <federico@ximian.com>
2500 * gtk/gtkfilesystem.h (struct _GtkFileFolderIface): Added slots
2501 for an ::is_finished_loading() method and a ::finished_loading()
2502 signal at the end of the struct.
2504 * gtk/gtkfilesystem.c (gtk_file_folder_base_init): Create the
2505 "finished-loading" signal.
2506 (gtk_file_folder_is_finished_loading): New function.
2508 * gtk/gtkfilesystemunix.c
2509 (gtk_file_folder_unix_is_finished_loading): Implement.
2511 * gtk/gtkfilesystemmodel.c (struct _GtkFileSystemModelClass): New
2512 slot for a "finished-loading" signal.
2513 (gtk_file_system_model_class_init): Create the "finished-loading"
2515 (struct _GtkFileSystemModel): New field
2516 idle_finished_loading_source. We emit the "finished-loading"
2517 signal in an idle if the root folder was done loading right in
2518 _gtk_file_system_model_new(), so that the caller has a chance to
2519 connect to the signal.
2520 (_gtk_file_system_model_new): Connect to the normal signals of the
2521 folder even if the initial _list_children() fails. Also, see if
2522 the folder is finished loading; connect to the "finished-loading"
2524 (gtk_file_system_model_finalize): Remove the idle handler.
2526 * gtk/gtkfilechooserdefault.c (set_list_model): Set a busy cursor
2527 and connect to the model's "finished-loading" signal.
2528 (get_toplevel): New helper function.
2529 (error_message): Use get_toplevel().
2530 (trap_activate_cb): Likewise.
2531 (location_popup_handler): Likewise.
2532 (set_busy_cursor): New function.
2533 (browse_files_model_finished_loading_cb): New callback.
2535 2004-03-25 Federico Mena Quintero <federico@ximian.com>
2537 * gtk/gtkfilechooserdefault.c (check_preview_change): Just use the
2538 file under the cursor; we don't need the logic from
2539 GtkFileSelection after all. Fixes #132255.
2541 2004-03-25 Federico Mena Quintero <federico@ximian.com>
2543 * gtk/gtkfilechooserdefault.c (location_entry_create): Fill the
2544 location entry with the display name of the file under the cursor
2545 for Open mode, or the typed filename in Save mode.
2547 2004-03-24 J. Ali Harlow <ali@juiblex.co.uk>
2549 * gtk/gtkfilesystemwin32.c
2550 (filename_is_root): Bare drive designators (eg., "c:") are
2551 no longer considered as root filenames. Fixed #137942
2553 2004-03-24 J. Ali Harlow <ali@juiblex.co.uk>
2555 * gtk/gtkfilesystemwin32.c
2556 (gtk_file_system_win32_create_folder): Invert test for error in
2557 mkdir. Fixes #137945
2559 2004-03-24 J. Ali Harlow <ali@juiblex.co.uk>
2561 Fixed #138004 using Federico's code from #132327.
2563 * gtk/gtkfilesystemwin32.c (struct _GtkFileSystemWin32): Add a
2564 folder_hash field to keep a list of live folder objects.
2565 (gtk_file_system_win32_init): Create the folder_hash.
2566 (gtk_file_system_win32_finalize): Destroy the folder_hash.
2567 (gtk_file_system_win32_get_folder): Ref and return an existing
2568 folder if we have it around, otherwise return a new folder object.
2569 (struct _GtkFileFolderWin32): Add a field for the parent file system.
2570 (gtk_file_folder_win32_finalize): Remove the folder from the file
2571 system's hash table.
2572 (gtk_file_system_win32_create_folder): Emit "files-added" on the
2573 newly-created folder's parent. Fixes #138004.
2575 2004-03-24 J. Ali Harlow <ali@juiblex.co.uk>
2577 * gtk/gtkfilesystemwin32.c
2578 (gtk_file_system_win32_get_folder): Test that path is actually
2579 a directory and throw error if not. Fixed bug #137950
2581 2004-03-22 J. Ali Harlow <ali@juiblex.co.uk>
2583 * gtk/gtkfilesystemwin32.c
2584 (gtk_file_system_win32_volume_get_display_name): Ignore empty
2585 volume labels; assume that GetVolumeInformation would fail if
2586 GetVolumeInformationW does; catches a small memory leak;
2587 pass the buffer size to GetVolumeInformationW in wide
2588 characters instead of bytes. Fixes bug #137543
2589 (list_volumes): Cope with the theoretical possibility of
2590 more than 26 logical drives. Fixes bug #137940
2591 (bookmarks_serialize): Now actually removes bookmarks.
2594 2004-03-22 Guntupalli Karunakar <karunakar@freedomink.org>
2596 * configure.in: Added "pa" (Punjabi) to ALL_LINGUAS.
2598 2004-03-21 Tor Lillqvist <tml@iki.fi>
2600 * gtk/gtkfilesystemwin32.c
2601 (gtk_file_system_win32_volume_get_base_path): Include the
2602 backslash. Otherwise gtk_file_system_win32_path_to_uri() returns
2603 NULL for a volume base path, as g_filename_to_uri() requires an
2604 absolute path, and just a drive letter and colon isn't. (#137543)
2606 2004-03-20 Hans Breuer <hans@breuer.org>
2608 * gtk/gtkfilesystemwin32.c : applied the undisputable and
2609 required [due to recent gtkfilesystem internal api semantic
2610 changes] part of patches to fix bug #137543 (Tor Lillqvist,
2613 * gdk/gdkevents-win32.c (handle_configure_event) :
2614 (gdk_event_translate), WM_WINDOWPOSCHANGED : initialize
2615 GdkWindowObject::x, y with screen coords to make
2616 gdk_window_get_position () return the right thing and thus fix
2617 drag and drop positioning (e.g. Gimp tabs, fixes bug #137192)
2619 2004-03-19 Federico Mena Quintero <federico@ximian.com>
2621 * Revert the patch to #137520, as 2.4.1 is for conservative bug
2622 fixes only. The patch is attached to the bug report, for
2625 2004-03-19 Morten Welinder <terra@gnome.org>
2627 * gtk/gtkfilechooserdefault.c
2628 (gtk_file_chooser_default_set_current_folder): Test existance of
2629 the path after checking for locality, if needed.
2631 2004-03-19 Federico Mena Quintero <federico@ximian.com>
2635 * gtk/gtkfilesystem.h (struct _GtkFileFolderIface): Added slots
2636 for an ::is_finished_loading() method and a ::finished_loading()
2637 signal at the end of the struct.
2639 * gtk/gtkfilesystem.c (gtk_file_folder_base_init): Create the
2640 "finished-loading" signal.
2641 (gtk_file_folder_is_finished_loading): New function.
2643 * gtk/gtkfilesystemunix.c
2644 (gtk_file_folder_unix_is_finished_loading): Implement.
2646 * gtk/gtkfilesystemmodel.c (struct _GtkFileSystemModelClass): New
2647 slot for a "finished-loading" signal.
2648 (gtk_file_system_model_class_init): Create the "finished-loading"
2650 (struct _GtkFileSystemModel): New field
2651 idle_finished_loading_source. We emit the "finished-loading"
2652 signal in an idle if the root folder was done loading right in
2653 _gtk_file_system_model_new(), so that the caller has a chance to
2654 connect to the signal.
2655 (_gtk_file_system_model_new): Connect to the normal signals of the
2656 folder even if the initial _list_children() fails. Also, see if
2657 the folder is finished loading; connect to the "finished-loading"
2659 (gtk_file_system_model_finalize): Remove the idle handler.
2661 * gtk/gtkfilechooserdefault.c (set_list_model): Set a busy cursor
2662 and connect to the model's "finished-loading" signal.
2663 (get_toplevel): New helper function.
2664 (error_message): Use get_toplevel().
2665 (trap_activate_cb): Likewise.
2666 (location_popup_handler): Likewise.
2667 (set_busy_cursor): New function.
2668 (browse_files_model_finished_loading_cb): New callback.
2670 Thu Mar 18 12:10:45 2004 Owen Taylor <otaylor@redhat.com>
2672 * gtk/gtktreeitem.c (gtk_tree_item_forall): Include
2673 eventbox for expander. (#137564, reported by
2676 2004-03-18 Guntupalli Karunakar <karunakar@freedomink.org>
2678 * mr.po: Added "mr" for Marathi to ALL_LINGUAS.
2680 2004-03-17 Morten Welinder <terra@gnome.org>
2682 * gtk/gtkfilechooserdefault.c (shortcuts_add_volumes): Free
2683 volumes not actually put into the shortcut list.
2685 * tests/prop-editor.c (object_changed): Plug leak.
2687 * tests/testfilechooser.c (main): Plug some leaks and expose
2690 * tests/prop-editor.c (create_prop_editor): Don't leak the tooltip
2691 object. Fixed #136652.
2693 * gtk/gtkfilechooserdefault.c (check_icon_theme): Do nothing if we
2694 have no screen. Fixes #137260.
2695 (shortcuts_add_bookmark_from_path): Simplify using check_is_folder
2696 thereby fixing leak. Fixes #137259.
2698 * gtk/gtkpathbar.c (gtk_path_bar_forall): Make this work when the
2699 slider buttons have been destroyed.
2700 (gtk_path_bar_remove): Make this work for slider buttons too.
2703 2004-03-15 Morten Welinder <terra@gnome.org>
2705 * gtk/gtkfilechooserdefault.c (shortcuts_add_bookmark_from_path):
2706 Sanitize and plug leak.
2707 (check_icon_theme): Only do something if the widget has a screen.
2709 Wed Mar 17 01:20:28 2004 Matthias Clasen <maclas@gmx.de>
2711 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
2712 Move the repositioning logic from _gtk_entry_completion() popup
2713 over here. Fixes #137355, reported by Niklas Knutsson.