1 Wed May 5 22:20:21 2004 Matthias Clasen <maclas@gmx.de>
5 * gtk/gtkiconfactory.c (icon_source_clear): Don't
6 call g_free() on a pixbuf. (#141961, Crispin Flowerday)
8 2004-05-05 Matthias Clasen <mclasen@redhat.com>
12 * gtk/gtkuimanager.c (print_node): Make the output
13 parseable. (#141929, Sven Neumann)
15 2004-05-05 Tor Lillqvist <tml@iki.fi>
17 * gdk/win32/gdkdnd-win32.c (gdk_drag_find_window_for_screen): Add
18 multi-monitor offset. (#141842, John Ehresman)
20 2004-05-04 Federico Mena Quintero <federico@ximian.com>
22 Fixes #139562, based on a patch by Christian Neumair.
24 * gtk/gtkfilechooserdefault.c (struct _GtkFileChooserDefault): Add
25 a filter_combo_hbox field to contain the filter combo.
26 (show_filters): Show/hide the filter_combo_hbox.
27 (create_filename_entry_and_filter_combo): Removed.
28 (file_pane_create): Create the filter_combo_hbox here.
30 2004-05-04 Matthias Clasen <mclasen@redhat.com>
32 * modules/input/gtkimcontextxim.c: Fix the recent
33 string_conversion_callback change to work on
34 Solaris. (#141190, Padraig O'Briain)
36 * gtk/gtkselection.c: Disable debug logging again.
38 2004-05-03 Matthias Clasen <mclasen@redhat.com>
40 * gtk/gtkselection.c: Make the chunk size for
41 incremental transfers depend on the maximal request
42 size, capped at 256k. This should allow most selections
43 to be transferred nonincrementally, avoiding many
44 roundtrips and protocol overhead.
46 2004-05-03 Federico Mena Quintero <federico@ximian.com>
48 * gtk/gtkuimanager.c (gtk_ui_manager_class_init): Call
49 g_signal_new() correctly and initialize the signal fields. Fixes
50 #141749; patch based on Michael Natterer's.
52 u2004-05-03 Matthias Clasen <mclasen@redhat.com>
54 * gtk/gtkselection.c (_gtk_selection_request): Fix
55 a debug message to show correct information.
56 (_gtk_selection_incr_event): Make INCRemental transfer
57 of MULTIPLE targets work. This was broken since 1997!
59 2004-05-02 Hans Breuer <hans@breuer.org>
61 * gdk/win32/gdkdrawable-win32.c (draw_segments) : don't
62 modify the passed in GdkSegment(s) in place, we may get
63 them again to draw at the same place. Fixes bug #129095,
65 (draw_segments) draw the end pixel again to get the
66 pixmap mask right, fixes bug #126710, #130202
68 * gdk/win32/gdkwindow-win32.c : use SetForegroundWindow,
69 fixes bug #106013, John Ehresman
71 * gtk/makefile.msc.in : don't try to link gtk.res but
72 use gtk-win32.res (as supposed to be fixed below :)
74 2004-05-01 Hans Breuer <hans@breuer.org>
76 * tests/Makefile.am : tests/makefile.msc is in CVS for
77 a long time, finally added to EXTRA_DIST : fixes bug
78 #141334, John Ehresman
80 2004-04-30 Matthias Clasen <mclasen@redhat.com>
82 * === Released 2.4.1 ===
84 * configure.in: Version 2.4.1, interface age 1.
88 2004-04-29 Federico Mena Quintero <federico@ximian.com>
92 * gtk/gtkfilechooserdefault.c (remove_selected_bookmarks): New
93 function; moved the code over from
94 remove_bookmark_button_clicked_cb().
95 (remove_selected_bookmarks): Now, getting a non-removable bookmark
96 is not an error, as we may be called as a result of hitting the
98 (shortcuts_key_press_event_cb): New handler; delete the bookmark
99 if the user presses Backspace, Delete, or KP_Delete.
101 2004-04-29 Matthias Clasen <mclasen@redhat.com>
103 * gtk/gtkaction.c (closure_accel_activate): Use
104 _gtk_action_emit_activate() instead of directly
105 emitting the activate signal. (#141429, Jody Goldberg)
107 * gtk/gtkactiongroup.c (gtk_action_group_add_action_with_accel):
108 Warn people when the accelerator can not be
109 parsed. (#141429, Jody Goldberg)
111 2004-04-29 Matthias Clasen <mclasen@redhat.com>
113 * tests/testentrycompletion.c (main): Add a missing
114 cat. (#141070, Chris Sherlock)
116 * gtk/gtkrc.c (gtk_rc_check_pixmap_dir): Remove unused
117 variable. (#141022, Chris Sherlock)
119 * gtk/gtkcombo.c (gtk_combo_popup_list): Add a missing
120 cast. (#141013, Chris Sherlock)
122 * gtk/gtkcellview.c (gtk_cell_view_cell_layout_clear): Remove
123 unused variable. (#141011, Chris Sherlock)
125 2004-04-29 Tor Lillqvist <tml@iki.fi>
127 * gdk/win32/gdkgc-win32.c (gdk_win32_gc_set_dashes): Plug memory
128 leak. (#140775, John Ehresman)
130 Thu Apr 29 01:09:50 2004 Matthias Clasen <maclas@gmx.de>
132 * gdk/gdkdraw.c (_gdk_drawable_get_scratch_gc): Use depth - 1
133 to index the cached gcs, not depth. (#139494)
135 2004-04-28 Matthias Clasen <mclasen@redhat.com>
137 * gdk/gdkdraw.c (_gdk_drawable_get_scratch_gc): Docs typo fix.
139 Sun Apr 25 15:36:02 2004 Soeren Sandmann <sandmann@daimi.au.dk>
141 * gtk/gtktoolbutton.c (gtk_tool_button_set_label_widget): Fix
142 cut'n'paste-o from previous commit. (#141046, Torsten Schoenfeld).
144 2004-04-24 Theppitak Karoonboonyanan <thep@linux.thai.net>
146 Patch to add support for string conversion callbacks to
147 GtkIMContextXIM (#101814)
149 * modules/input/gtkimcontextxim.c: Set the string conversion callback
150 if supported by the XIC.
152 (struct _GtkIMContextXIM): Add string_conversion_callback member.
154 (struct _GtkXIMInfo, setup_im): Check and keep flag inidicating
155 whether string conversion callback is supported.
157 (gtk_im_context_get_ic, +set_string_conversion_callback,
158 +string_conversion_callback): Also initialize string conversion
159 callback, if supported, along with the IC initialization.
161 * modules/input/imxim.c: Make "xim" module default for Thai as well.
163 2004-04-23 Matthias Clasen <mclasen@redhat.com>
165 * gtk/gtkclipboard.c (gtk_clipboard_wait_for_targets): Correctly
166 initialize targets. (#139883, John Finlay)
168 * gdk/gdkdraw.c (gdk_draw_drawable): Small doc improvement.
170 * gtk/gtktreeselection.c (gtk_tree_selection_get_selected_rows):
171 Don't recommend gtk_tree_row_reference_new_proxy(). (#138309,
174 * gtk/gtktreeviewcolumn.c (gtk_tree_view_column_cell_set_cell_data):
175 Remove an excessive g_return_if_fail().
177 * gdk/x11/gdkevents-x11.c (set_user_time): Make set_user_time()
179 * gdk/x11/gdkinput-x11.c (_gdk_input_common_other_event):
180 _-prefix calls of gdk_x11_window_set_user_time().
182 2004-04-22 Matthias Clasen <mclasen@redhat.com>
184 * gtk/gtkuimanager.c (update_node): Make sure the separators
185 used to demarkate placeholder ends don't show up on
186 show_all(). (#140496, Murray Cumming)
188 * gtk/gtkspinbutton.c (spin_button_at_limit): Make spinbuttons
189 work with negative increments. (#137975, Tim Gerla)
191 Wed Apr 21 21:38:03 2004 Soeren Sandmann <sandmann@daimi.au.dk>
193 * gtk/gtktoolbutton.c (gtk_tool_button_set_label_widget,
194 gtk_tool_button_set_icon_widget): Remove the old widget from the
195 tool button before overwriting it with the new widget.
197 (#140508, Todd Goyen)
199 2004-04-22 Tor Lillqvist <tml@iki.fi>
201 Fix the file chooser on Windows. I can't make it misbehave or
202 crash any more now. But presumably there are still corner cases
203 not handled. I haven't really checked behaviour of UNC paths, for
206 * gtk/gtkfilesystemwin32.c: Accept both backslash and slash in
207 several places. Use G_IS_DIR_SEPARATOR macro (which could be added
210 (gtk_file_system_win32_get_parent): Like the Unix version, assert
211 filename is absolute, and avoid one unnecessary string allocation
214 (canonicalize_filename,gtk_file_system_win32_parse): Handle drive
215 letters more correctly.
217 (gtk_file_system_win32_render_icon): Assure correct syntax is used
218 for root folder of a drive. (#137962, Morten Welinder)
220 (filename_is_some_root): New function that accepts also root
221 without any drive specified.
223 (filename_is_drive_root): Rename from filename_is_root.
225 * gtk/gtkfilechooserentry.c (completion_match_func): Casefold on
228 2004-04-21 Matthias Clasen <mclasen@redhat.com>
230 * gtk/gtkentry.c (gtk_entry_completion_timeout): Pop down the
231 completion window if there are no completions anymore.
233 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
234 Don't call gtk_tree_view_scroll_to_cell() on an empty tree view.
235 It doesn't like that. (#140642, Christian Persch)
237 * demos/gtk-demo/expander.c (do_expander): A new demo.
239 * demos/gtk-demo/Makefile.am (demos): Add expander.c.
241 2004-04-20 Matthias Clasen <mclasen@redhat.com>
243 * gtk/gtktextview.c (gtk_text_view_allocate_children): Make
244 sure anchored children get size allocated, even if the layout
245 is valid. (#122323, Andrew E. Makeev)
246 (gtk_text_view_scroll_pages):
247 (gtk_text_view_scroll_hpages): Don't scroll to cursor position
248 if we already have pending scrolls. Bandaid fix for #78513.
250 Mon Apr 19 17:59:17 2004 Owen Taylor <otaylor@redhat.com>
252 * INSTALL.in: Update libpng and libjpeg URLs, remove
253 note about building without since that's not the normal
256 Sun Apr 11 09:45:11 2004 Owen Taylor <otaylor@redhat.com>
258 * gtk/gtkicontheme.c (load_themes): Fix a couple of typos in
259 handling of SVG/non-SVG unthemed icons.
261 2004-04-19 Morten Welinder <terra@gnome.org>
263 * gtk/gtktoolbar.c (gtk_toolbar_focus): Don't leak list of
266 2004-04-19 Matthias Clasen <mclasen@redhat.com>
268 * gtk/gtktextbtree.c (_gtk_text_line_previous_could_contain_tag):
269 Don't stop the iteration up to the tag_root too
270 early. (#109945, Dongho Shin)
272 Sun Apr 18 17:06:03 2004 Soeren Sandmann <sandmann@daimi.au.dk>
274 * gdk/x11/gdkkeys-x11.c (get_effective_keymap): Make
275 gdk_keymap_translate_keyboard_state() handle NULL
276 keymaps. (#139715, Torsten Schoenfeld).
278 Sun Apr 18 16:59:21 2004 Soeren Sandmann <sandmann@daimi.au.dk>
280 * configure.in: Don't erase GDK_EXTRA_CFLAGS. Fixes bug 139586,
281 reported by Pedro RODRIGUEZ, about compilation problems when
282 Xcursor is installed in a non-standard location.
284 Sun Apr 18 16:15:15 2004 Soeren Sandmann <sandmann@daimi.au.dk>
286 Support for _NET_WM_USER_TIME (bug 115650). Patch by Elijah
289 * gdk/x11/gdkwindow-x11.[ch]: Add new internal function
290 _gdk_x11_set_user_time() to set the _NET_WM_USER_TIME property.
292 * gdk/x11/gdkdisplay-x11.h (struct _GdkDisplayX11): Add user_time field
294 * gdk/x11/gdkdisplay-x11.c: Add _NET_WM_USER_TIME to list of
297 * gdk/x11/gdkinput-x11.c, gdk/x11/gdkevents-x11.c: Set the
298 property on user interaction.
300 2004-04-15 Federico Mena Quintero <federico@ximian.com>
302 * gtk/gtkfilesel.c (open_new_dir): Tell the user to use
303 G_FILENAME_ENCODING, not G_BROKEN_FILENAMES. Fixes #114065.
305 * gtk/gtkfilechooserdefault.c (split_uris): Use a variant of the
306 code from gtkfilesel.c to parse a "text/uri-list" blob. Fixes
309 2004-04-15 Matthias Clasen <mclasen@redhat.com>
311 * gtk/gtkcellrenderer.c (gtk_cell_renderer_class_init):
312 * gtk/gtkbutton.c (gtk_button_class_init): Doc fixes.
314 2004-04-14 Matthias Clasen <mclasen@redhat.com>
318 Make all style properties readonly.
320 2004-04-14 Matthias Clasen <mclasen@redhat.com>
322 * gtk/gtkcolorsel.c: Add a11y relations between the color
323 wheel and the spin buttons. (#132745, Padraig O'Briain)
325 * gtk/gtkiconfactory.c (gtk_icon_set_render_icon): Document
326 the meaning of size == -1.
328 * gtk/gtkwidget.c (gtk_widget_render_icon): Explicitly accept
329 a size of -1. (#137436, Brian Cameron)
331 * gtk/gtkcombobox.c: Make the arrow and separator regular
332 children of an hbox inside the button, and propagate state
333 changes from the button to the cell view. (part of the fix
334 for #138650, should also fix #137535)
336 * gtk/gtkcellview.c (gtk_cell_view_expose): Pass the PRELIT
337 state to gtk_cell_renderer_render() when prelighted. (part
338 of the fix for #138650)
340 * gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_render):
341 Use PRELIGHT state when appropriate. (part of the fix for
344 * gtk/gtkcombobox.c (gtk_combo_box_relayout): Don't spit
345 out warnings if called before the combo box is
346 realized. (#139742, Philip Langdale)
348 Wed Apr 14 03:45:39 2004 Jonathan Blandford <jrb@gnome.org>
350 * gtk/gtktreeview.c (gtk_tree_view_expose): propagate expose
353 Wed Apr 14 03:32:58 2004 Jonathan Blandford <jrb@gnome.org>
355 * gtk/gtkpathbar.c (make_directory_button): remove spurious
358 Tue Apr 13 16:19:23 2004 Jonathan Blandford <jrb@redhat.com>
360 * gtk/gtkpathbar.c (make_directory_button): patch from Owen to
361 make the buttons sized by a bold label. This makes the text
362 'swim' a little, but stops the buttons from resizing, #137210
364 2004-04-13 Matthias Clasen <mclasen@redhat.com>
366 * gtk/gtkuimanager.c (get_child_node): Don't crash if a node
368 (start_element_handler): Accept separators without unique
369 names. (#133302, Anders Carlsson)
371 * gtk/gtkactiongroup.c (gtk_action_group_add_action): Document
372 possible accelerator gotcha when using this function. (#139641,
375 * gtk/gtkuimanager.c (node_remove_ui_reference): Don't leak
376 list nodes. (#138862, Morten Welinder)
378 Tue Apr 13 12:24:49 2004 Jonathan Blandford <jrb@redhat.com>
380 * gtk/gtktreeview.c (gtk_tree_view_destroy): remove unused
382 (gtk_tree_view_button_press): If we activated the row we don't
383 want to grab focus back, as moving focus to another widget is
384 pretty common, #138458
386 2004-04-12 Federico Mena Quintero <federico@ximian.com>
388 * gtk/gtkfilechooser.c (gtk_file_chooser_class_init): Added
389 documentation to all the signals.
391 2004-04-12 Matthias Clasen <mclasen@dhcp64-228.boston.redhat.com>
393 * gtk/gtkcombobox.c (gtk_combo_box_unset_model): Don't unref
394 model if it is NULL. (#139770)
396 * gtk/gtktreeview.c (gtk_tree_view_get_cell_area): Typo fix.
398 * gtk/gtkentrycompletion.c (gtk_entry_completion_init): Don't add
399 a shadow inside the scrolled window, add it around the vbox.
401 * gtk/gtkentryprivate.h:
402 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
403 Return a boolean indicating whether the popup is positioned above
404 or below. Scroll the completions to the beginning or the end,
405 depending on the positioning.
407 * gtk/gtkentry.c (gtk_entry_completion_key_press): Make keynav
408 wrap around in the entry completion popup, and allow GDK_UP to
409 enter the popup. (#137440)
411 2004-04-12 Matthias Clasen <mclasen@redhat.com>
413 * gtk/gtkentry.c (gtk_entry_size_request): Make sure the style is
414 there before using it.
416 Sun Apr 11 15:08:45 2004 Jonathan Blandford <jrb@gnome.org>
418 * gtk/gtktreeprivate.h: Moved search entries into priv data.
420 * gtk/gtktreeview.c: Prep for type-ahead support.
422 (gtk_tree_view_destroy): Destroy the search window explicitly.
423 (gtk_tree_view_key_press): Minor change; prep for type-ahead
424 (gtk_tree_view_ensure_interactive_directory): New function
425 (gtk_tree_view_focus_out): Rework to handle new entry life-cycle.
426 (gtk_tree_view_real_start_interactive_search): rework
427 (gtk_tree_view_search_dialog_hide): ditto
428 (gtk_tree_view_search_delete_event): ditto
429 (gtk_tree_view_search_button_press_event): ditto
430 (gtk_tree_view_search_key_press_event): ditto
431 (gtk_tree_view_search_move): ditto
432 (gtk_tree_view_search_init): ditto
434 * gtk/gtktreeviewcolumn.c:
435 (gtk_tree_view_column_cell_layout_clear): remove unused variable.
437 * tests/testfilechooser.c: (main): change
439 2004-04-11 Hans Breuer <hans@breuer.org>
441 * gdk/win32/gdkspawn-win32.c : workaround for bug #137496,
442 the real fix would involve just another small API breakage,
443 i.e. gdk_spawn_* using GPid not just gint.
445 * gtk/makefile.msc.in : build gtk-win32.res, not gtk.res
447 2004-04-10 Tor Lillqvist <tml@iki.fi>
449 * gdk/win32/gdkkeys-win32.c (gdk_keymap_translate_keyboard_state):
450 If both Shift and CapsLock pressed, ignore the shift only for
451 letters (that would have been affected by the CapsLock). (#139095)
453 * gdk/win32/gdkglobals-win32.c: Disable tablet support by default,
454 seems to be even buggier now than it used to be. (#138341)
455 Initialize _gdk_input_ignore_wintab to TRUE.
457 * gdk/win32/gdkmain-win32.c: Add --use-wintab switch and
458 GDK_USE_WINTAB environment variable to turn on tablet support.
460 2004-04-09 Christian Persch <chpe@cvs.gnome.org>
462 * gtk/gtkuimanager.c: (gtk_ui_manager_insert_action_group),
463 (gtk_ui_manager_remove_action_group): Terminate
464 g_object_[dis]connect() calls with NULL instead of 0.
467 2004-04-09 Guntupalli Karunakar <karunakar@freedomink.org>
469 * configure.in: Added "gu" (Gujarati) to ALL_LINGUAS.
471 2004-04-07 Federico Mena Quintero <federico@ximian.com>
475 * gtk/gtkfilesystem.c (gtk_file_system_parse): Ensure that the
476 passed-in 'str' is not NULL.
478 * gtk/gtkfilesystemunix.c (expand_tilde): New helper function;
479 expands "~/" or "~foo/" at the beginning of a filename.
480 (gtk_file_system_unix_parse): Use expand_tilde() before doing
483 * gtk/gtkfilechooserentry.c
484 (gtk_file_chooser_entry_maybe_update_directory): Take in a
485 force_reload argument.
486 (gtk_file_chooser_entry_changed): If gtk_file_system_parse()
487 returns an error, set the file_part_pos to -1.
488 (load_directory_callback): Only populate the model if the
489 file_part_pos is not -1.
491 2004-04-06 Pablo Saratxaga <pablo@mandrakesoft.com>
493 * configure.in: Added Icelandic (is) to ALL_LINGUAS
495 2004-04-05 Federico Mena Quintero <federico@ximian.com>
497 * gtk/gtkfilechooserdefault.c (location_popup_handler): Use a
498 title for SAVE and CREATE_FOLDER modes. Fixes #137272.
500 * gtk/gtkfilesystemunix.c (gtk_file_system_unix_make_path): Look
501 for G_DIR_SEPARATOR in the display_name, and err out if it is
502 present; use the same error message as Nautilus. Fixes #136467.
504 * gtk/gtkfilechooserdefault.c (file_pane_create): Make the
505 new-folder button say "Create Fo_lder" rather than "Create
506 _Folder", so that the mnemonic doesn't conflict with the "Save in
507 _folder" label. Fixes #136975.
509 2004-04-05 Federico Mena Quintero <federico@ximian.com>
511 * gtk/gtkpathbar.c (_gtk_path_bar_set_path): Ref/sink the
512 buttons. Also, free them correctly upon failure. Based on a
513 patch by Morten Welinder, fixes #137956.
515 2004-04-05 Anders Carlsson <andersca@gnome.org>
517 * gdk/gdk.c (gdk_arg_context_parse): Handle '--' correctly.
519 Fri Apr 2 17:57:33 2004 Jonathan Blandford <jrb@redhat.com>
521 * gtk/gtktreeview.c (gtk_tree_view_row_inserted): set the height
522 correctly for fixed height when inserting a node, #138082
524 2004-04-01 Federico Mena Quintero <federico@ximian.com>
528 * gtk/gtkpathbar.h (struct _GtkPathBarClass): Add a
529 "child_is_hidden" boolean argument to the "path-clicked" signal.
531 * gtk/gtkpathbar.c (struct _ButtonData): Added a file_is_hidden
533 (make_directory_button): Take a file_is_hidden argument; put it in
535 (_gtk_path_bar_set_path): See whether each path component path is
537 (gtk_path_bar_class_init): Add the file_is_hidden argument to the
538 "path-clicked" signal.
539 (button_clicked_cb): See if the downwards button represents a
540 hidden file for the file_is_hidden argument in the signal
543 * gtk/gtkmarshalers.list: Added a signal type VOID:POINTER,BOOLEAN.
545 * gtk/gtkfilechooserdefault.c
546 (gtk_file_chooser_default_select_path): If we fail to switch
547 folders, don't try to select the path in the file system model.
548 Also, return the result from _gtk_file_system_model_path_do().
549 (gtk_file_chooser_default_select_path): Turn on show_hidden in the
550 file system model if we are asked to select a hidden file.
551 (path_bar_clicked): Show hidden files based on whether the
552 immediate downwards folder in the path bar is a hidden file
554 (struct _GtkFileChooserDefault): Added fields
555 browse_files_popup_menu and browse_files_popup_menu_hidden_files_item.
556 (create_file_list): Set an object data key of
557 "GtkFileChooserDefault" on the tree view so that we can find the
558 impl from the popup menu callbacks. Also, hook up to the
559 "button-press-event" and "popup-menu" signals in the file list to
560 bring up a popup menu.
561 (list_popup_menu_cb): New callback.
562 (list_button_press_event_cb): New callback.
566 * gtk/gtkfilesystemmodel.c
567 (_gtk_file_system_model_new): Oops, connect_object to
570 2004-03-31 Tor Lillqvist <tml@iki.fi>
572 * configure.in: Move AC_CANONICAL_HOST earlier, before the check
573 for native Win32. (#136559, J. Ali Harlow)
575 * gdk/win32/gdkdrawable-win32.c (draw_arc): Use X11 semantics for
576 angles. Thanks to Tim Newsham.
578 2004-03-29 Federico Mena Quintero <federico@ximian.com>
582 * gtk/gtkfilesystem.h (struct _GtkFileFolderIface): Added slots
583 for an ::is_finished_loading() method and a ::finished_loading()
584 signal at the end of the struct.
586 * gtk/gtkfilesystem.c (gtk_file_folder_base_init): Create the
587 "finished-loading" signal.
588 (gtk_file_folder_is_finished_loading): New function.
590 * gtk/gtkfilesystemunix.c
591 (gtk_file_folder_unix_is_finished_loading): Implement.
593 * gtk/gtkfilesystemmodel.c (struct _GtkFileSystemModelClass): New
594 slot for a "finished-loading" signal.
595 (gtk_file_system_model_class_init): Create the "finished-loading"
597 (struct _GtkFileSystemModel): New field
598 idle_finished_loading_source. We emit the "finished-loading"
599 signal in an idle if the root folder was done loading right in
600 _gtk_file_system_model_new(), so that the caller has a chance to
601 connect to the signal.
602 (_gtk_file_system_model_new): Connect to the normal signals of the
603 folder even if the initial _list_children() fails. Also, see if
604 the folder is finished loading; connect to the "finished-loading"
606 (gtk_file_system_model_finalize): Remove the idle handler.
608 * gtk/gtkfilechooserdefault.c (set_list_model): Set a busy cursor
609 and connect to the model's "finished-loading" signal.
610 (get_toplevel): New helper function.
611 (error_message): Use get_toplevel().
612 (trap_activate_cb): Likewise.
613 (location_popup_handler): Likewise.
614 (set_busy_cursor): New function.
615 (browse_files_model_finished_loading_cb): New callback.
617 2004-03-25 Federico Mena Quintero <federico@ximian.com>
619 * gtk/gtkfilechooserdefault.c (check_preview_change): Just use the
620 file under the cursor; we don't need the logic from
621 GtkFileSelection after all. Fixes #132255.
623 2004-03-25 Federico Mena Quintero <federico@ximian.com>
625 * gtk/gtkfilechooserdefault.c (location_entry_create): Fill the
626 location entry with the display name of the file under the cursor
627 for Open mode, or the typed filename in Save mode.
629 2004-03-24 J. Ali Harlow <ali@juiblex.co.uk>
631 * gtk/gtkfilesystemwin32.c
632 (filename_is_root): Bare drive designators (eg., "c:") are
633 no longer considered as root filenames. Fixed #137942
635 2004-03-24 J. Ali Harlow <ali@juiblex.co.uk>
637 * gtk/gtkfilesystemwin32.c
638 (gtk_file_system_win32_create_folder): Invert test for error in
641 2004-03-24 J. Ali Harlow <ali@juiblex.co.uk>
643 Fixed #138004 using Federico's code from #132327.
645 * gtk/gtkfilesystemwin32.c (struct _GtkFileSystemWin32): Add a
646 folder_hash field to keep a list of live folder objects.
647 (gtk_file_system_win32_init): Create the folder_hash.
648 (gtk_file_system_win32_finalize): Destroy the folder_hash.
649 (gtk_file_system_win32_get_folder): Ref and return an existing
650 folder if we have it around, otherwise return a new folder object.
651 (struct _GtkFileFolderWin32): Add a field for the parent file system.
652 (gtk_file_folder_win32_finalize): Remove the folder from the file
654 (gtk_file_system_win32_create_folder): Emit "files-added" on the
655 newly-created folder's parent. Fixes #138004.
657 2004-03-24 J. Ali Harlow <ali@juiblex.co.uk>
659 * gtk/gtkfilesystemwin32.c
660 (gtk_file_system_win32_get_folder): Test that path is actually
661 a directory and throw error if not. Fixed bug #137950
663 2004-03-22 J. Ali Harlow <ali@juiblex.co.uk>
665 * gtk/gtkfilesystemwin32.c
666 (gtk_file_system_win32_volume_get_display_name): Ignore empty
667 volume labels; assume that GetVolumeInformation would fail if
668 GetVolumeInformationW does; catches a small memory leak;
669 pass the buffer size to GetVolumeInformationW in wide
670 characters instead of bytes. Fixes bug #137543
671 (list_volumes): Cope with the theoretical possibility of
672 more than 26 logical drives. Fixes bug #137940
673 (bookmarks_serialize): Now actually removes bookmarks.
676 2004-03-22 Guntupalli Karunakar <karunakar@freedomink.org>
678 * configure.in: Added "pa" (Punjabi) to ALL_LINGUAS.
680 2004-03-21 Tor Lillqvist <tml@iki.fi>
682 * gtk/gtkfilesystemwin32.c
683 (gtk_file_system_win32_volume_get_base_path): Include the
684 backslash. Otherwise gtk_file_system_win32_path_to_uri() returns
685 NULL for a volume base path, as g_filename_to_uri() requires an
686 absolute path, and just a drive letter and colon isn't. (#137543)
688 2004-03-20 Hans Breuer <hans@breuer.org>
690 * gtk/gtkfilesystemwin32.c : applied the undisputable and
691 required [due to recent gtkfilesystem internal api semantic
692 changes] part of patches to fix bug #137543 (Tor Lillqvist,
695 * gdk/gdkevents-win32.c (handle_configure_event) :
696 (gdk_event_translate), WM_WINDOWPOSCHANGED : initialize
697 GdkWindowObject::x, y with screen coords to make
698 gdk_window_get_position () return the right thing and thus fix
699 drag and drop positioning (e.g. Gimp tabs, fixes bug #137192)
701 2004-03-19 Federico Mena Quintero <federico@ximian.com>
703 * Revert the patch to #137520, as 2.4.1 is for conservative bug
704 fixes only. The patch is attached to the bug report, for
707 2004-03-19 Morten Welinder <terra@gnome.org>
709 * gtk/gtkfilechooserdefault.c
710 (gtk_file_chooser_default_set_current_folder): Test existance of
711 the path after checking for locality, if needed.
713 2004-03-19 Federico Mena Quintero <federico@ximian.com>
717 * gtk/gtkfilesystem.h (struct _GtkFileFolderIface): Added slots
718 for an ::is_finished_loading() method and a ::finished_loading()
719 signal at the end of the struct.
721 * gtk/gtkfilesystem.c (gtk_file_folder_base_init): Create the
722 "finished-loading" signal.
723 (gtk_file_folder_is_finished_loading): New function.
725 * gtk/gtkfilesystemunix.c
726 (gtk_file_folder_unix_is_finished_loading): Implement.
728 * gtk/gtkfilesystemmodel.c (struct _GtkFileSystemModelClass): New
729 slot for a "finished-loading" signal.
730 (gtk_file_system_model_class_init): Create the "finished-loading"
732 (struct _GtkFileSystemModel): New field
733 idle_finished_loading_source. We emit the "finished-loading"
734 signal in an idle if the root folder was done loading right in
735 _gtk_file_system_model_new(), so that the caller has a chance to
736 connect to the signal.
737 (_gtk_file_system_model_new): Connect to the normal signals of the
738 folder even if the initial _list_children() fails. Also, see if
739 the folder is finished loading; connect to the "finished-loading"
741 (gtk_file_system_model_finalize): Remove the idle handler.
743 * gtk/gtkfilechooserdefault.c (set_list_model): Set a busy cursor
744 and connect to the model's "finished-loading" signal.
745 (get_toplevel): New helper function.
746 (error_message): Use get_toplevel().
747 (trap_activate_cb): Likewise.
748 (location_popup_handler): Likewise.
749 (set_busy_cursor): New function.
750 (browse_files_model_finished_loading_cb): New callback.
752 Thu Mar 18 12:10:45 2004 Owen Taylor <otaylor@redhat.com>
754 * gtk/gtktreeitem.c (gtk_tree_item_forall): Include
755 eventbox for expander. (#137564, reported by
758 2004-03-18 Guntupalli Karunakar <karunakar@freedomink.org>
760 * mr.po: Added "mr" for Marathi to ALL_LINGUAS.
762 2004-03-17 Morten Welinder <terra@gnome.org>
764 * gtk/gtkfilechooserdefault.c (shortcuts_add_volumes): Free
765 volumes not actually put into the shortcut list.
767 * tests/prop-editor.c (object_changed): Plug leak.
769 * tests/testfilechooser.c (main): Plug some leaks and expose
772 * tests/prop-editor.c (create_prop_editor): Don't leak the tooltip
773 object. Fixed #136652.
775 * gtk/gtkfilechooserdefault.c (check_icon_theme): Do nothing if we
776 have no screen. Fixes #137260.
777 (shortcuts_add_bookmark_from_path): Simplify using check_is_folder
778 thereby fixing leak. Fixes #137259.
780 * gtk/gtkpathbar.c (gtk_path_bar_forall): Make this work when the
781 slider buttons have been destroyed.
782 (gtk_path_bar_remove): Make this work for slider buttons too.
785 2004-03-15 Morten Welinder <terra@gnome.org>
787 * gtk/gtkfilechooserdefault.c (shortcuts_add_bookmark_from_path):
788 Sanitize and plug leak.
789 (check_icon_theme): Only do something if the widget has a screen.
791 Wed Mar 17 01:20:28 2004 Matthias Clasen <maclas@gmx.de>
793 * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
794 Move the repositioning logic from _gtk_entry_completion() popup
795 over here. Fixes #137355, reported by Niklas Knutsson.